profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/matthewlein/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Matthew Lein matthewlein Minneapolis/St. Paul, MN http://matthewlein.com Front-End/Fullstack Developer, Independent Make-Awesomer

matthewlein/jQuery-jSlots 162

jQuery slot machine insanity! Turns any list into a slot machine (you provide the insanity)

matthewlein/jQuery-widowFix 85

Widow Fix is a jQuery plugin to fix widows, or orphans, or whatever you call them—those single words on their own line. It does this by adding a   (non-breaking space) in between the last 2 words. It's super lite and easy to use!

matthewlein/Ceaser 76

Ceaser page and JS

matthewlein/Ceaser-CSS-Easing-tmbundle 43

TextMate bundle for the Ceaser CSS Easing Equations

matthewlein/jQuery-ViewMaster 16

A jQuery CSS3 slideshow

matthewlein/cicadaJS 12

A tiny JavaScript to create endless nearly non-repeating stripe patterns based on prime (or coprime) numbers

matthewlein/inline-block-no-space-font 11

This is an attempt to use a font to get rid of space between inline blocks

matthewlein/bustify 7

Bustify breaks an image into a series of boxes and adds 3D transforms to bust it apart

matthewlein/custom-chrome-devtools 5

custom css for chrome dev tools. dark theme w left side check boxes!

startedvendure-ecommerce/vendure

started time in 18 days

PR closed cowboy/jquery-outside-events

added touch events

I added touchstart, touchend, and touchmove events to the list. Passes all the unit tests and my tests on an iPad.

Created a touchstart example also, but couldn't use your vodoo code for it.

+228 -1

2 comments

3 changed files

matthewlein

pr closed time in 19 days

pull request commentcowboy/jquery-outside-events

added touch events

Happy Birthday to my first open source PR 🍰

On the 10th anniversary of this PR, I've decided it is time to close it.

Rest easy little PR, your time is done.

matthewlein

comment created time in 19 days

issue openednaver/egjs-flicking

arrow plugin `moveByViewportSize` not calculating correct panels

Description

When moving by viewport size back and forth, incorrect panels are shown.

Steps to check or reproduce

https://codesandbox.io/s/elegant-raman-7w3n7?file=/src/App.tsx

  1. starts showing abc
  2. click next arrow, shows def
  3. click next arrow, shows ghi
  4. click back arrow, shows cde

slide F was skipped over.

created time in 20 days

issue openedprismicio/prismic-gatsby

Add pageSize customization

I have received an email that prismic will be blocking large api responses soon. I believe some of these are coming from the primsic-gatsby plugin to build all the prismic pages. The easiest solution is lowering pageSize from 100 to something smaller, but I don't think this can be configured in the plugin.

I would like to be able to set pageSize in the config to any number and have it use that to build the pages.

created time in a month

issue commentnaver/egjs-flicking

bound=true + align="prev" with few children not working correctly

😍 Love it!

Thanks so much for the quick turnaround. Very happy to have a flexbox based carousel meeting all my needs.

matthewlein

comment created time in a month

issue commentnaver/egjs-flicking

Cannot read property 'currentStyle' of null

I suppose it's up to you. React itself doesn't blow up with an error when you have duplicate keys. It can cause some weird rendering issues sure, but it doesn't cause an unrecoverable error.

My preference would be to not break everything if it happens.

Although its a good way to find accidental duplicates coming from the database... 😈

matthewlein

comment created time in 2 months

issue commentfoundation/foundation-emails

Cut a new gem release

Is this right? The latest gem uses a 5 years old version, and references possible outdated documentation?

markokajzer

comment created time in 2 months

issue commentnaver/egjs-flicking

Cannot read property 'currentStyle' of null

Even changing the heading text will trigger it. So I'd guess it happens in rerendering, not the initial render.

matthewlein

comment created time in 2 months

issue commentnaver/egjs-flicking

Cannot read property 'currentStyle' of null

Incredibly, I found a reproducible case today in production.

It seems like it has to do with:

  • rendering the flicking component with children
  • having a duplicate key (by accident)
  • possibly having arrows

https://codesandbox.io/s/brave-night-bokrd?file=/src/App.tsx

I can get it to happen by changing the letters in the items array, like ["a", "b", "a", "c", "d", "e"]; to ["a", "a", "a", "c", "d", "e"];

The error message is not identical, but it's happening at the same place in the code. I think it's the same issue.

Screen Shot 2021-08-12 at 11 05 37 AM

So that would explain why it's rare, duplicate keys are very unlikely.

matthewlein

comment created time in 2 months

issue openednaver/egjs-flicking

Cannot read property 'currentStyle' of null

Description

Locally I have seen this error a few times, and now I'm seeing it occasionally in production error reporting.

I have looked at this almost identical error: https://github.com/naver/egjs-flicking/issues/485 but there are no duplicate reacts or anything like that in package-lock.

Steps to check or reproduce

This is the code that is erroring. el is null or undefined at times.

 var getStyle = function(el) {
   return window.getComputedStyle(el) || el.currentStyle;
 };

I believe generating a key based on children prevents this error from causing any user problems, but I'm not 100% sure on that. It's a rare error and I haven't figured out a way to reproduce it.

created time in 2 months

startedigorkulman/ChangeMenuBarColor

started time in 2 months

issue commentnaver/egjs-flicking

bound=true + align="prev" with few children not working correctly

Here is the arrow example: https://codesandbox.io/s/determined-black-91oen?file=/src/App.tsx

matthewlein

comment created time in 2 months

issue commentnaver/egjs-flicking

Dynamic children errors with `Cannot read property 'key' of undefined`

Awesome, glad you could figure it out so quickly

matthewlein

comment created time in 2 months

issue commentnaver/egjs-flicking

bound=true + align="prev" with few children not working correctly

OK, sounds good. Hopefully everyone agrees, I think it leads to a kind of confusing user experience especially with the arrow plugin, the arrow is active, and it advances the carousel, but there are no new panels to see.

matthewlein

comment created time in 2 months

issue openednaver/egjs-flicking

Dynamic children errors with `Cannot read property 'key' of undefined`

Description

Having a dynamic children will cause errors in flicking. Is this meant to be supported? As a workaround, you can generate a key based on the children, so it will mount a new component when children change, but this is not ideal.

Steps to check or reproduce

In this sandbox, the children are randomly generated every second. If you remove the key on <Flicking>, it will cause an error pretty quickly. https://codesandbox.io/s/restless-butterfly-ttl8g?file=/src/App.tsx

created time in 2 months

issue openednaver/egjs-flicking

bound=true + align="prev" with few children not working correctly

Description

When you have a small number of children and the settings bound={true} and align="prev", the carousel allows advancing beyond the bound edge. When the number of children is less than a full viewport, it should not advance at all.

Steps to check or reproduce

Example: https://codesandbox.io/s/nice-cannon-hhio5?file=/src/App.tsx

created time in 2 months

startednaver/egjs-flicking

started time in 3 months