Matias Insaurralde matiasinsaurralde @TykTechnologies Paraguay https://matias.insaurral.de/ software developer (most of the time), infosec enthusiast, human being, self-taught. 23 years.

pull request commentTykTechnologies/tyk

Avoid duplicate request body in gRPC request object

A note about this, when reconstructing the request object after the hook is called, we always take raw_body:

// ObjectPostProcess does CoProcessObject post-processing (adding/removing headers or params, etc.).
func (c *CoProcessor) ObjectPostProcess(object *coprocess.Object, r *http.Request) {
        r.ContentLength = int64(len(object.Request.RawBody))
        r.Body = ioutil.NopCloser(bytes.NewReader(object.Request.RawBody))

I don't think that this behavior should be modified whenraw_body_only flag is in use. We should clarify in the docs that when a hook needs to modify the body, they should modify raw_body, perhaps we can mention that the body field is "read-only" (we don't have a way of enforcing this, as the bindings are generated by PB, but any hook that modifies body won't make any effect, raw_body will still be used).

matiasinsaurralde

comment created time in a day

issue commentTykTechnologies/tyk-docs

java pre-plugin injects header - does not authenticate user

We could add a small reference to this repository, this includes tests and also the authentication middleware: https://github.com/TykTechnologies/tyk-plugin-demo-java/tree/maven

asoorm

comment created time in a day

push eventmatiasinsaurralde/tyk-docs

push time in 2 days

PR opened TykTechnologies/tyk-docs

Add note for 2.8 "bundle" gateway command

In the upcoming release, the tyk-cli functionality is integrated into the gateway binary, I've added some compatibility notes

+38 -0

0 comment

6 changed files

pr created time in 2 days

push eventmatiasinsaurralde/tyk-docs

Matias Insaurralde

commit sha 25a094398217179f57f604b01f15f37528071801

Add note for 2.8 "bundle" gateway command

view details

push time in 2 days

push eventmatiasinsaurralde/tyk-docs

Matias Insaurralde

commit sha 283673b79f8eb34832451aa11893eaba7f89d6bb

Add note for 2.8 "bundle" gateway command

view details

push time in 2 days

push eventmatiasinsaurralde/tyk-docs

Matias Insaurralde

commit sha 8fbfb35f5e7007f17bf93218ea79a75e244137fa

Add note for 2.8 "bundle" gateway gommand

view details

push time in 2 days

push eventmatiasinsaurralde/tyk

dencoded

commit sha b29a5e8bbd89817b8971537a035ac67a79044318

don't touch last_updated when suppress_reset=1 (#2219) added changes for https://github.com/TykTechnologies/tyk-analytics/issues/1221

view details

Lanre Adelowo

commit sha 513829c9fc8a20cec3b886a33b06fa6223febe66

Debug instead of Warning (#2220) Fixes https://github.com/TykTechnologies/tyk/issues/2216

view details

Komal Sukhani

commit sha fbaf23884e921d38b7d7f68ce3de41f02c962ef3

Bug/2211 fix strip path (#2212) Fixes #2211 Previously, strings.Replace() method was used to strip the `listen_path`. So when URL rewrite plugin was used to call an endpoint that contained `listen_path` anywhere in it's path, it was getting removed. To fix this I replaced `strings.Replace()` with `strings.TrimPrefix()`

view details

push time in 2 days

create barnchmatiasinsaurralde/tyk-docs

branch : tyk-cli

created branch time in 2 days

push eventmatiasinsaurralde/tyk-docs

Mark Southee

commit sha ce1394d50e8139f85306e5913728c3876aa3b398

Minor changes to page

view details

Mark Southee

commit sha 1618dc9338e37eb462272a3e4a8a236b0119e94e

Move File Handles section

view details

Mark Southee

commit sha b90c0e7f7ab0198dfb02bfd5057621b81a389ab6

Merge pull request #735 from TykTechnologies/prod-fix Move File Handles section

view details

Josh Blakeley

commit sha 24e7dee7c93b44ca47eb35a1ff0b214caa5fa785

Correct redis cluster typo and add "gotcha" values Added redis_ prefixed values to example config as they are possible gotchas and while were here basically add all the parts necessary for ssl comms with DBs

view details

Mark Southee

commit sha a5a7a282461ad70336c85fa5bfa0b143b7213e78

Update link in FAQ

view details

Mark Southee

commit sha b593c5acd2ba041e789e4f5f50fa2a7612d22659

Merge pull request #738 from TykTechnologies/portal-options-link Update link in FAQ

view details

Ahmet Soormally

commit sha 454b8d61ca2d2e37f7a6dd1923f998dae467b54f

guidance on how to swap out swagger-ui for redoc (#728)

view details

Mark Southee

commit sha 754e8c030617fab71acdb72e4f21c54fc89e580f

Merge pull request #737 from TykTechnologies/joshblakeley-patch-1 Correct redis cluster typo and add "gotcha" values

view details

Mark Southee

commit sha 36b41b6750ff7beb9f794f6b6248150f727dedb0

Change Tutorial Heading

view details

Mark Southee

commit sha 08e571af65e59b57676f42b304e5ad4d26e486f1

Merge pull request #681 from TykTechnologies/jsvm-changes Minor changes to page

view details

Mark Southee

commit sha 62205ed93c29f9731f3a2dbc6a56c2893ded89f5

Fix broken link

view details

Mark Southee

commit sha 7f42f84afdd6f24182c45efa601fe67e207d19f3

Merge pull request #743 from TykTechnologies/ldap-tib-link Fix broken link

view details

Mark Southee

commit sha 12f940b809a28c6cb796d1e1cc5070ad214cb7f0

Merge pull request #741 from TykTechnologies/portal-tut Change Tutorial Heading

view details

Mark Southee

commit sha ebd1569a7b2a166bcd7bef66726132284a0f5574

typo fix

view details

Mark Southee

commit sha 1646c2de183887d654f3484402015628db44c859

Merge pull request #745 from TykTechnologies/claimname-update typo fix

view details

Leonid Bugaev

commit sha be516e2add95eb3680ca4ba7960822f16acd912e

Update portal-developers.md

view details

Mark Southee

commit sha 173d50384a048c1dbc9f87a1b461e99c0c434c85

Add enable_master_keys to Dashboard Config settings

view details

Mark Southee

commit sha 9769fa51fb224624aad754cb435e751ec4eb37b1

Merge pull request #746 from TykTechnologies/master-keys Add enable_master_keys to Dashboard Config settings

view details

push time in 2 days

startedautom8ter/engine

started time in 6 days

startedSafetyCulture/grpc-web-devtools

started time in 6 days

startedmuninrpc/muninrpc

started time in 6 days

issue openedTykTechnologies/tyk-docs

Versioning in rich plugin Protocol Buffers definitions

We should add a note to clarify how PB definitions are versioned, the basic conventions are described here.

created time in 6 days

push eventTykTechnologies/tyk-protobuf

Matias Insaurralde

commit sha 7fdb96ac6430157cef32ce97f9087cbbbeb01f89

Update definitions

view details

push time in 6 days

push eventmatiasinsaurralde/tyk

Furkan Senharputlu

commit sha e0a2b30548e8767034168c071664e99d527f17a6

Fix key update EOF issue (#2215) See https://github.com/TykTechnologies/tyk-analytics/issues/1224 The issue is about trying to read a `ReadCloser` without resetting it.

view details

Lanre Adelowo

commit sha 81265fcef2ae7f203f7d20f68587f172049ea2b1

Make sure there can only be one Access-Control-Allow-Origin header as per https://www.w3.org/TR/cors/\#resource-sharing-check (#2202) Fixes https://github.com/TykTechnologies/tyk/issues/2199 Also see https://www.w3.org/TR/cors/#resource-sharing-check The value of `Access-Control-Allow-Origin` in the proxy target's header takes precedence

view details

push time in 6 days

pull request commentTykTechnologies/tyk

Avoid duplicate request body in gRPC request object

Fixed all the issues, the failing test seems to beTestRateLimitForAPIAndRateLimitAndQuotaCheck (not related)

matiasinsaurralde

comment created time in 8 days

issue commentTykTechnologies/tyk

gRPC: can only send message no larger than 2MB eventhough grpc limit is 4MB

Having an extra field that takes up 50% of the payload just for accommodating format difference seems expensive. Is it possible to inspect the raw_body to see if it's UTF-8?

We already inspect raw_body before populating body.

In the meantime, what is the work-around to fully utilize the 4MB limit if our data is UTF-8? Should we leave the body empty and only fill the raw_body?

I've added a flag that allows you to populate only raw_body. The PR is #2213.

jeffrngu

comment created time in 8 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 6e1c0486e70930e5f90c151564973ea509533acd

coprocess: adjust error handling

view details

Matias Insaurralde

commit sha a6a59565f14e1da3f522b892c5e09d8105630eee

coprocess: goimports on bindings

view details

push time in 8 days

Pull request review commentTykTechnologies/tyk

Avoid duplicate request body in gRPC request object

 func (c *CoProcessor) ObjectFromRequest(r *http.Request) *coprocess.Object { 	if r.Body != nil { 		defer r.Body.Close() 		miniRequestObject.RawBody, _ = ioutil.ReadAll(r.Body)

Have extended ObjectFromRequest to also return errors 👍

matiasinsaurralde

comment created time in 9 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha a66be3ff9e0b8736fbb2a5c3ad010cd872509e58

coprocess: extend error handling when building request object

view details

push time in 9 days

PR opened TykTechnologies/tyk

Avoid duplicate request body in gRPC request object

Potential fix for #2208, described here. Need to add tests.

+201 -199

0 comment

13 changed files

pr created time in 10 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 312fbe88fe8f87760edd8f0992adfdfc7a5e5f7c

coprocess: add boolean field "raw_body_only" to request object

view details

Matias Insaurralde

commit sha 12862ea177088db814f7134271a9f6127af2d381

coprocess: add check for "raw_body_only"

view details

push time in 10 days

create barnchmatiasinsaurralde/tyk

branch : grpc-avoid-body-dup

created branch time in 10 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 00d9ac05548b5a8db2df1a296867f424b19557ff

mw_basic_auth: avoid missing header error when body basic auth is enabled (#2194) Fix #2193

view details

dencoded

commit sha 32859da5b997f58e972416660a5f3823a973950c

update key endpoint changed (#2209) added changes for https://github.com/TykTechnologies/tyk-analytics/issues/996 The problem was because we were setting `quota_renews` to 0 when updating key with `suppress_reset=1` as it forces starting new quota renewal period (which equal to reseting quotas)

view details

push time in 10 days

issue commentTykTechnologies/tyk

gRPC: can only send message no larger than 2MB eventhough grpc limit is 4MB

A potential solution could be a flag that avoids populating the body field and only makes use of raw_body. The reason why we have two fields is described in #1724. raw_body is always populated and body is only used if the data contains is a valid UTF-8 string. When this happens we end up with duplicate data and this only leaves you with half of the actual gRPC message limit.

jeffrngu

comment created time in 10 days

issue commentTykTechnologies/tyk

gRPC: can only send message no larger than 2MB eventhough grpc limit is 4MB

Thanks, the issue is related to these two body fields, we will find a solution.

jeffrngu

comment created time in 11 days

pull request commentTykTechnologies/tyk

mw_basic_auth: avoid missing header errors when using body basic auth…

The CI error isn't related to this change, looks like a linking issue:

/home/travis/.gimme/versions/go1.11.8.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-995235108/000016.o: unrecognized relocation (0x2a) in section `.text'
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
matiasinsaurralde

comment created time in 13 days

Pull request review commentTykTechnologies/tyk

mw_basic_auth: avoid missing header errors when using body basic auth…

 func (k *BasicAuthKeyIsValid) basicAuthHeaderCredentials(w http.ResponseWriter, 	logger := k.Logger().WithField("key", obfuscateKey(token)) 	if token == "" { 		// No header value, fail-		logger.Info("Attempted access with malformed header, no auth header found.")+		if !k.Spec.BasicAuth.ExtractFromBody {+			logger.Info("Attempted access with malformed header, no auth header found.")

Think we don't need to check for token with the new change, this scenario will occur when basicAuthHeaderCredentials fails.

matiasinsaurralde

comment created time in 13 days

Pull request review commentTykTechnologies/tyk

mw_basic_auth: avoid missing header errors when using body basic auth…

 func (k *BasicAuthKeyIsValid) basicAuthHeaderCredentials(w http.ResponseWriter, 	logger := k.Logger().WithField("key", obfuscateKey(token)) 	if token == "" { 		// No header value, fail-		logger.Info("Attempted access with malformed header, no auth header found.")+		if !k.Spec.BasicAuth.ExtractFromBody {+			logger.Info("Attempted access with malformed header, no auth header found.")

@dencoded Updated, can you review?

matiasinsaurralde

comment created time in 13 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha fb8e073d9ea40780d8d7f3271e67d5c29191d5ab

mw_basic_auth: avoid missing header error when body basic auth is enabled

view details

push time in 13 days

pull request commentTykTechnologies/tyk

Make maximum gRPC message size configurable

Updated schema

matiasinsaurralde

comment created time in 14 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 95e5e5203160a7623ccd48119bb3dbffae3ea06e

cli: update schema

view details

push time in 14 days

pull request commentTykTechnologies/tyk

Make maximum gRPC message size configurable

It's important to note that the gRPC server needs to have the same value (or a higher value) than what's set in tyk.conf but this depends on the user's implementation. Just adding this for documentation.

matiasinsaurralde

comment created time in 14 days

PR opened TykTechnologies/tyk

Make maximum gRPC message size configurable

Potential fix for #2203

This introduces two new parameters in tyk.conf:

{
  "grpc_recv_max_size": 100000,
  "grpc_send_max_size": 100000
}

When no parameter is set (and both parameters equal 0), we call WithDefaultCallOptions so default values are used. The value is a number of bytes.

+50 -17

0 comment

5 changed files

pr created time in 14 days

issue openedTykTechnologies/tyk

gRPC fails when sending large messages

Do you want to request a feature or report a bug? Bug

What is the current behavior? When using a gRPC plugin and sending a message that's larger than 4 MB, the request fails. 4 MB is the default value for maximum length as mentioned here.

What is the expected behavior? It should be possible to configure this parameter.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem All Which versions of Tyk affected by this issue? Did this work in previous versions of Tyk?

created time in 14 days

create barnchmatiasinsaurralde/tyk

branch : grpc-msg-size

created branch time in 14 days

push eventTykTechnologies/tyk-plugin-demo-java

Matias Insaurralde

commit sha d3117ffaab6a869c48638649bcff2b29af5dec79

Update Maven configuration

view details

Matias Insaurralde

commit sha 9623d3c4d751c5633c452e456399d524112b68d3

Extend tests

view details

push time in 15 days

startedcabupy/bdset

started time in 15 days

pull request commentTykTechnologies/tyk

mw_basic_auth: avoid missing header errors when using body basic auth…

@dencoded I've replaced this with a simpler solution, now we should discuss if we want to log auth errors on basicAuthBodyCredentials in the same way we do for basicAuthHeaderCredentials, think this should be a separate issue/PR.

matiasinsaurralde

comment created time in 15 days

push eventmatiasinsaurralde/tyk

Furkan Senharputlu

commit sha 42bfb74b340d877ca95b1c43b28b1eb0bee4963e

Make linter schema a separate json file (#2196)

view details

Komal Sukhani

commit sha b363c8b33b665f3fab5c8499916801a0104e5ca4

Feature/1838 cache post requests (#2114) * Add support for caching of POST request When an endpoint is added in cache list, caching will be enabled to for all safe methods as well as POST request. * Add test for per path caching * Use hash of POST body while creating checksum for cache key * 1. Add new advance_cache_config field in api definition 2. Add support of defining regex pattern to calculate cache key from post body * Add test for caching of POST request * Add delay in TestCachePostRequest test * Minor fixes * Add test cases to check cache works correctly with regex

view details

Komal Sukhani

commit sha 6f2f9f3fbcf61c7d7792c4079f706e1a10d22ba0

Bug/2195 fix looping issue (#2200) Fixes #2195 Every middleware call CheckSpecMathesStatus() to check if middlewares are set for the path. In case of url-rewrite, path set in ctxGetUrlRewritePath was used, which stores value of original path before url-write. That variable was used to run response middleware of the original path and not of the rewritten path But in case of looping feature, we want to run request middlewares of the rewritten path as well. So I changed the code to use ctxGetUrlRewritePath only in case of response middleware and use r.url.Path otherwise.

view details

Matias Insaurralde

commit sha 3898a4ff9be90c597bb8e457f18799a160a46b0f

mw_basic_auth: avoid missing header error when body basic auth is enabled

view details

push time in 15 days

push eventmatiasinsaurralde/tyk-docs

Yaara

commit sha 11ffb11a8beb3e8393b44c4ad3cd7ffff6d022cf

Fixed the double quotes

view details

Leonid Bugaev

commit sha cf8513bd22788de66357f6c60e93e03a3bdb928d

GW redis.timeout (#721) * GW redis.timeout * Update tyk-dashboard-configuration-options.md * Update tyk-pump-configuration.md * Update tyk-dashboard-configuration-options.md * Update bearer-tokens.md * Update basic-auth.md

view details

Ahmet Soormally

commit sha 83c64d2c5ff4dba58932c1a7ac8a180b0a0df2d6

Fix Typo

view details

Mark Southee

commit sha 60708b94982d25b6a8d7ba2db7cb4adfb3ef1285

Merge pull request #723 from TykTechnologies/asoorm-patch-9 Fix Typo

view details

Mark Southee

commit sha 0c82fed13a44ee027e6b92d3e4b9c72cae910f53

Merge pull request #714 from TykTechnologies/letzya-patch-20 Fixed the double quotes

view details

Yaara

commit sha a3808a1846ca6a731ca4f1c25a22c1c6c7a99b2a

markdown wasn't translated correctly to a list Looks like this: The following levels can be set: * debug * info * warn * error If unset or left empty, it will default to info.

view details

Yaara

commit sha ab1b760489283ed94db9b26c8dccbaf83606f8f1

typos

view details

Mark Southee

commit sha 7fbd2a349c941da69de95f867c77969feaee0331

Merge pull request #730 from TykTechnologies/letzya-patch-22 typos

view details

Mark Southee

commit sha 1c6a04046c55011fff858e6d7f9b6f2b69c73dc9

Merge pull request #729 from TykTechnologies/letzya-patch-21 markdown wasn't translated correctly to a list

view details

Jeff Shantz

commit sha d5814853c626ac8814b67b3a89015f3728b911d0

Add undocumented TYK_DB_SSOCUSTOMPORTALLOGINURL environment variable

view details

Furkan Senharputlu

commit sha 7dd86e417816ccd07b37333033f64b6618518c25

Add Request Throttling documentation (#720) * Add Request Throttling documentation * Update request-throttling.md Couple of amendments

view details

Ahmet Soormally

commit sha c8a502f89db9084d937592dc82e2759b2376b7fb

document proxy.ssl_insecure_skip_verify (#716) https://github.com/TykTechnologies/tyk-docs/pull/621

view details

Lanre Adelowo

commit sha 1543512e3bbaa0a72772f08a96eca9f791ff7db0

document API details retrieval via public ID (#717) * The dashboard now supports retrieving an API via it's public ID * update docs

view details

dencoded

commit sha fbec4fa507a5775513609caabcc67a053c4ec8dc

audit description added (#722)

view details

Mark Southee

commit sha 3f5a90b7531c28f9beecc64c917cada45d121cd6

Merge pull request #731 from jeffshantz/master Add undocumented TYK_DB_SSOCUSTOMPORTALLOGINURL environment variable

view details

dencoded

commit sha ad2cc4519d3d1108507d605aeec29424d6122fa9

hybrid oump description added (#724)

view details

Ahmet Soormally

commit sha b82d3e3cf34439f6ce90dfbd65400812533d5cc1

document ssl_ciphers and prefer_server_ciphers (#715) * document ssl_ciphers and prefer_server_ciphers https://github.com/TykTechnologies/tyk-docs/pull/621 * Update tyk-dashboard-configuration-options.md Couple of typos fixed

view details

Josh Blakeley

commit sha a7848f60645f8aa658727cb4dc8fc993659f00e1

Add multi org config option (#726) * add multi org config option * Update tyk-dashboard-configuration-options.md Capitalised a couple of urls

view details

Ahmet Soormally

commit sha 774caa852ca3243af52f3371888b19da4f749869

fix docs: bind_to_slugs should be false for MDCB

view details

Mark Southee

commit sha 3337815f7183907eaa80e9434ab0014e4f69cb15

Merge pull request #734 from TykTechnologies/asoorm-patch-10 fix docs: bind_to_slugs should be false for MDCB

view details

push time in 15 days

push eventTykTechnologies/tyk-plugin-demo-java

Matias Insaurralde

commit sha 498729fbdc9f6433ed6bfaf2385f249b4a10b2d8

Extend sample to cover test request headers

view details

push time in 15 days

startedhjacobs/kubernetes-failure-stories

started time in 15 days

push eventTykTechnologies/tyk-plugin-demo-java

Matias Insaurralde

commit sha 1ae0bcee778489114434e2a28d4fa022ff802b4b

Add gRPC client sample

view details

push time in 16 days

push eventmatiasinsaurralde/tyk

Komal Sukhani

commit sha 6f2f9f3fbcf61c7d7792c4079f706e1a10d22ba0

Bug/2195 fix looping issue (#2200) Fixes #2195 Every middleware call CheckSpecMathesStatus() to check if middlewares are set for the path. In case of url-rewrite, path set in ctxGetUrlRewritePath was used, which stores value of original path before url-write. That variable was used to run response middleware of the original path and not of the rewritten path But in case of looping feature, we want to run request middlewares of the rewritten path as well. So I changed the code to use ctxGetUrlRewritePath only in case of response middleware and use r.url.Path otherwise.

view details

push time in 16 days

startedHandBrake/HandBrake

started time in 17 days

issue commentTykTechnologies/tyk

multiple Access-Control-Allow-Origin response headers

@altaurog Thanks for reporting the issue, I've been able to reproduce it with the configuration you've shared:

< HTTP/1.1 200 OK
< Access-Control-Allow-Credentials: true
< Access-Control-Allow-Origin: test.com
< Access-Control-Allow-Origin: test.com
< Content-Type: application/json
< Date: Sun, 07 Apr 2019 14:53:38 GMT
< Server: nginx
< Vary: Origin
< X-Ratelimit-Limit: 0
< X-Ratelimit-Remaining: 0
< X-Ratelimit-Reset: 0
< Content-Length: 164

We'll investigate potential solutions for this.

altaurog

comment created time in 17 days

push eventmatiasinsaurralde/tyk

Furkan Senharputlu

commit sha 42bfb74b340d877ca95b1c43b28b1eb0bee4963e

Make linter schema a separate json file (#2196)

view details

Komal Sukhani

commit sha b363c8b33b665f3fab5c8499916801a0104e5ca4

Feature/1838 cache post requests (#2114) * Add support for caching of POST request When an endpoint is added in cache list, caching will be enabled to for all safe methods as well as POST request. * Add test for per path caching * Use hash of POST body while creating checksum for cache key * 1. Add new advance_cache_config field in api definition 2. Add support of defining regex pattern to calculate cache key from post body * Add test for caching of POST request * Add delay in TestCachePostRequest test * Minor fixes * Add test cases to check cache works correctly with regex

view details

push time in 17 days

Pull request review commentTykTechnologies/tyk

mw_basic_auth: avoid missing header errors when using body basic auth…

 func (k *BasicAuthKeyIsValid) requestForBasicAuth(w http.ResponseWriter, msg str func (k *BasicAuthKeyIsValid) basicAuthHeaderCredentials(w http.ResponseWriter, r *http.Request) (username, password string, err error, code int) { 	token := r.Header.Get("Authorization") 	logger := k.Logger().WithField("key", obfuscateKey(token))+	if token == "" && k.Spec.BasicAuth.ExtractFromBody {

Seems that we already have tests with empty headers + body extraction enabled in TestBasicAuthFromBody.

matiasinsaurralde

comment created time in 20 days

Pull request review commentTykTechnologies/tyk

Make linter schema a separate json file

 func Init(version string, confPaths []string) { 	// Linter: 	lintCmd := app.Command("lint", "Runs a linter on Tyk configuration file") 	lintCmd.Action(func(c *kingpin.ParseContext) error {-		path, lines, err := lint.Run(lint.ConfSchema, confPaths)+		confSchema, err := ioutil.ReadFile("cli/linter/schema.json")

Should we use a more specific path here? Just thinking about potential issues

furkansenharputlu

comment created time in 20 days

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 89cab945918dede64bc3b146e51b30be51d4239f

mw_basic_auth: avoid missing header errors when using body basic auth

view details

push time in 21 days

create barnchmatiasinsaurralde/tyk

branch : mw-basic-auth-fix

created branch time in 21 days

push eventmatiasinsaurralde/tyk

Leonid Bugaev

commit sha 01763169027110cf0e55c1554295fb7f2ca09b77

Fix Basic Auth body extraction (#2188) Since body extraction used as fallback, previous Www-Authenticate header should be removed Fix https://github.com/TykTechnologies/tyk/issues/1855#issuecomment-478634874

view details

Furkan Senharputlu

commit sha 0287258fc20d245dcef4f0be290e75ab2ec311bc

Add Host field to AnalyticsRecord (#2190)

view details

Furkan Senharputlu

commit sha 1c21bd3ef87eded4e73dbaa43d02bfaa865265b9

Make linter generic to be able to use in other projects (#2189)

view details

push time in 21 days

push eventmatiasinsaurralde/tyk

Leonid Bugaev

commit sha f34a5a5dc53c9b838009b9d30770f7a490238635

Should hash oauth tokens before appending to list (#2161) Fix https://github.com/TykTechnologies/tyk/issues/2158

view details

Leonid Bugaev

commit sha d3e3b144e067b1fb61702c96929ba2cc81636140

Fix debug mode for looping (#2162) Additionally found that looping to API had a bug Fix https://github.com/TykTechnologies/tyk/issues/2159

view details

Leonid Bugaev

commit sha 2344343e97059481b91c6a691a77e41679642dbc

Fix quota counter reset for tokens with API limits (#2164) Fix https://github.com/TykTechnologies/tyk-analytics/issues/996

view details

Leonid Bugaev

commit sha 023290a4678781185b48aebacd39e69957c4a0c3

Add support for specifying Redis Timeout (#2166) Added new variable `storage.timeout` Fix https://github.com/TykTechnologies/tyk/issues/2165

view details

Leonid Bugaev

commit sha 6f7a006a68537849fb0897a32d7ec87f82d5d8e3

Do not set timeouts for pubsub

view details

Artem Hluvchynskyi

commit sha 574c8be287670a158c6fc92659872e4cf6428c66

Fixes Redis being initialised by event handlers before storing global config (#2168) Without global config stored Redis is unable to correctly initialize. This regression happens when event handlers such as webhooks are present in the configuration. Fix https://github.com/TykTechnologies/tyk/issues/2170

view details

Josh Blakeley

commit sha b11a7d1343e862b93f69d5188efa62cafc275665

update README.md (#2167) Bump go version

view details

Leonid Bugaev

commit sha 241fd01d2ac3b86a22daaf7267bfc8da0fb6b9d5

Custom signature validation (#2171) #2045 `auth` section now has new `validate_signature` boolean field, and `signature` section for configuring signature flow. Currently supports mashery signature validation modes `MasherySHA256` and `MasheryMD5`. ```json "auth": { "validate_signature": true, "signature": { "algorithm": "MasherySHA256", "header": "X-Signature", "secret": "secret", "allowed_clock_skew": 2 } } ``` "secret" field can hold dynamic values from meta or context, for example: "$tyk_meta.signature_secret". Additionally, you can override error code and message using: ``` "error_code": 403, "error_message": "your signature is invalid" ``` Benchmarks: ``` BenchmarkMasherySha256Sum_Hash-4 500000 2094 ns/op 208 B/op 4 allocs/op ```

view details

Leonid Bugaev

commit sha dede56574956c3886635f440dd9e523a75072aad

Hash oAuth tokens in redis (#2176) Added backward compatibility with unhashed version Fix https://github.com/TykTechnologies/tyk/issues/2158

view details

Leonid Bugaev

commit sha 63204205552a342408131724cd2b2fb933a58433

Cache failed OrgKey expiration attempts (#2185) At the moment it expects that OrgKey is exists, and if not, it asks for an Org key on every request. Fix https://github.com/TykTechnologies/tyk/issues/2184

view details

Lanre Adelowo

commit sha 9ddfe394f51d7b488a1c36cd21fbd3122baa313f

retain body for requests (#2182) Retain request body for requests with application/x-www-form-urlencoded as it is drained when ParseForm

view details

Leonid Bugaev

commit sha fa23e1abe95a2bed9d54f3dd22895719d0384030

Basic auth now can extract credentials from body (#2186) You can specify regexps for username and body. Regexp should contain one match group, which points to either username or password. Example: ``` "basic_auth": { "extract_from_body": true, "body_user_regexp": "<User>(.*)</User>", "body_password_regexp": "<Password>(.*)</Password>" } ``` Fix https://github.com/TykTechnologies/tyk/issues/1855

view details

push time in 24 days

startedguitmz/memrun

started time in 24 days

push eventmatiasinsaurralde/tyk-docs

Mark Southee

commit sha 4b5701dc49233d7e1b4fb7e86c52d10b6bf82d5a

Add Community Edition section

view details

Mark Southee

commit sha c72ff9e020e822bfbcb42ce7ddad45757dab581c

Merge remote-tracking branch 'origin' into commedition

view details

Mark Southee

commit sha aae3f2737b26e85ce75cd610c6c95de0bffd2b64

Merge remote-tracking branch 'origin' into commedition

view details

Mark Southee

commit sha 8e7327c5d5d8637dcc10cbf2a2096fde4f312b73

Update following review

view details

Mark Southee

commit sha ec906a462303ea94316b10ee0033db714ec5c0bf

Remove final MongoDB Ref

view details

Mark Southee

commit sha 2ecfa1055f6df553c966abc2fdd358263967c2dc

Merge remote-tracking branch 'origin' into commedition

view details

Mark Southee

commit sha 5e46ca64c08c07553f42b83be14a58c6970c2052

Udated after @asoorm review

view details

Mark Southee

commit sha fb5ad1fc01783c850f8749e885b6dd1d144cd282

Further indentation amendments

view details

Mark Southee

commit sha 6a5f3bc7b2b674b68324764bd00ceee3e7c30eae

Update text and menu screenshot

view details

Mark Southee

commit sha 9749ecbfe1659fca164a700124cbde5ebd0cc8b5

Merge remote-tracking branch 'origin' into webhooks

view details

Yaara

commit sha 9e99205c911519bdedccd10dca6a52266cecdfaf

Update 3rd-party-identity-providers.md

view details

Matias Insaurralde

commit sha dcc9010a9554a746e2ce964b97c90b548cb49280

Add "python_path_prefix" notes

view details

Mark Southee

commit sha 4111162d59ecf28c0aa466f952e1ff78e0a7cbd3

Merge pull request #490 from TykTechnologies/webhooks Webhooks

view details

Mark Southee

commit sha bbbca0a95aca46847916aedf997eb1264b24e1ec

Merge pull request #488 from TykTechnologies/letzya-patch-3 Changed to bullets list

view details

Mark Southee

commit sha f03668aa714b05a5ca5e3aca7a5060a5b1680f68

Merge pull request #463 from TykTechnologies/commedition Add Community Edition section

view details

Mark Southee

commit sha 705dd5e0821ff5eb48ea6a2c03281593458cf92e

Fix links

view details

Mark Southee

commit sha a1700f71513ebf2ad966403ecb19b85d9389f1be

Merge pull request #491 from TykTechnologies/links Fix links

view details

Mark Southee

commit sha cd289f1d1a05b03b99c5d921b3dbed8b85cb246d

Analyse

view details

Mark Southee

commit sha 34414d2862c616190a2409475d5debd940efd6f0

Compose APIs

view details

Mark Southee

commit sha 56b57067f0838ff99331282628108581f64a3d8d

Couple of 2.7 amendments

view details

push time in a month

startedradareorg/cutter

started time in a month

startedmaxmcd/wasabi

started time in a month

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 51f00fd69451a925f7749d45ee4cf90a66c59d05

storage: avoid MGET call when no keys are specified (#2156) Fixes #2155 `GetKeysAndValuesWithFilter` lists keys and runs `MGET`(https://redis.io/commands/mget) using these keys. This patch avoids the `MGET` call when the list is empty. This method is only called by the `oauth_manager.go` code.

view details

Matias Insaurralde

commit sha 2d8cd0543f3021185578a33a3e8535dbfc47912a

res_handler_transform: make sure bodyData is available on XML errors (#2133) For #2016. I was able to reproduce using the instructions described in the ticket. The issue occurs at this point: ```go bodyData := make(map[string]interface{}) switch tmeta.TemplateData.Input { case apidef.RequestXML: if len(body) == 0 { body = []byte("<_/>") } mxj.XmlCharsetReader = WrappedCharsetReader var err error bodyData, err := mxj.NewMapXml(body) if err != nil { logger.WithError(err).Error("Error unmarshalling XML") } ``` When `mxj.NewMapXml` returns an error, `bodyData` is not properly set and further references to it fail (like setting context vars using `bodyData["_tyk_context"] = ctxGetData(req)`). This approach avoids replacing `bodyData`.

view details

Furkan Senharputlu

commit sha 0edfb003701957be51584c45070e285e7d00792f

Fix URLs in virtual endpoint, js-plugin and coprocess (#2138) This PR fixes #2112

view details

push time in a month

startedbartlomieju/deno-postgres

started time in a month

startedfen-land/deno-fen

started time in a month

startedmanyuanrong/deno_mysql

started time in a month

starteddenolib/animated-deno-logo

started time in a month

startedsholladay/pogo

started time in a month

starteddenolib/awesome-deno

started time in a month

startedcyanly/gotrade

started time in a month

startedelectron/node-rcedit

started time in a month

startedenfipy/grpchat

started time in a month

startedsercand/kuberesolver

started time in a month

issue commentTykTechnologies/tyk

XML in listen_path breaks whitelist/blacklist rules

Yes, seems related

ilijabojanovic

comment created time in 2 months

issue commentTykTechnologies/tyk

XML in listen_path breaks whitelist/blacklist rules

Stripping the listen path in api_definition.go seems to fix it but might break the behavior for some users:

// URLAllowedAndIgnored checks if a url is allowed and ignored.
func (a *APISpec) URLAllowedAndIgnored(r *http.Request, rxPaths []URLSpec, whiteListStatus bool) (RequestStatus, interface{}) {
	path := strings.Replace(r.URL.Path, a.APIDefinition.Proxy.ListenPath, "", -1)
	// Check if ignored
	for _, v := range rxPaths {
		if !v.Spec.MatchString(path) {
			continue
		}
ilijabojanovic

comment created time in 2 months

PR opened TykTechnologies/tyk

storage: avoid MGET call when no keys are specified

Fixes #2155

GetKeysAndValuesWithFilter lists keys and runs MGET(https://redis.io/commands/mget) using these keys. This patch avoids the MGET call when the list is empty.

This method is only called by the oauth_manager.go code.

+3 -0

0 comment

1 changed file

pr created time in 2 months

push eventmatiasinsaurralde/tyk

Matias Insaurralde

commit sha 8a6fcf5a0b73057b48d20a2ef54bacf1bb8d2e6e

storage: avoid MGET call when no keys are specified

view details

push time in 2 months

create barnchmatiasinsaurralde/tyk

branch : fix-2155

created branch time in 2 months

push eventTykTechnologies/tyk-buildpack

Matias Insaurralde

commit sha 432020717e83019d0cbcdd4c36503bd0a754b069

Upgrade Tyk binary

view details

Matias Insaurralde

commit sha b88ca44d0ecd7d2d47e5ea844c117c1a9922e5b7

Add Httpbin definition

view details

push time in 2 months

create barnchmatiasinsaurralde/tyk-buildpack

branch : release-2.8

created branch time in 2 months

startedgithub/vulcanizer

started time in 2 months

push eventTykTechnologies/tyk-plugin-demo-java

Matias Insaurralde

commit sha 08200bd580767e1f7fc31a1e771d112bb4f94cfb

README: update instructions

view details

push time in 2 months

create barnchTykTechnologies/tyk-plugin-demo-java

branch : maven

created branch time in 2 months

startedhashmatter/libp2p-onion-routing

started time in 2 months

startedxlab/structwalk

started time in 2 months

push eventmatiasinsaurralde/beats

Matias Insaurralde

commit sha 6b8f7628a5691f0a63d0ecfead3e1498f359e185

Use custom HostParser when parsing Redis module hosts parameter

view details

push time in 2 months

Pull request review commentelastic/beats

Allow URL format in Metricbeat Redis module

 func NewMetricSet(base mb.BaseMetricSet) (*MetricSet, error) { 		return nil, errors.Wrap(err, "failed to read configuration") 	} +	var password string+	if base.HostData().Password != "" {+		password = base.HostData().Password+	} else {+		password = config.Password

Great, thanks!

matiasinsaurralde

comment created time in 2 months

push eventmatiasinsaurralde/tyk

Furkan Senharputlu

commit sha 14ffe74cf4bbce1b890dd9f368a5e59be3b1c6d7

Fix broken logstash UDP support (#2141) This PR disables `gas` reconnection functionality when `"logstash_transport": "udp"` because it doesn't support `udp`. Also, we need to fix doc here: https://tyk.io/docs/log-data/#a-name-aggregated-logs-with-logstash-a-aggregated-logs-with-logstash. It says `logstash_transport: The Logstash transport to use, should be "tcp".` but we support `udp` too. And, it would be easier for user if we give a logstash input configuration there like: ``` input { tcp { port => 5044 codec => json } } ``` Fixes #2136

view details

push time in 2 months

starteddvassallo/bootstrapping-calculator

started time in 2 months

startedkyren/luster

started time in 2 months

startedwix/react-templates

started time in 2 months

startedrucio/rucio

started time in 2 months

startedcvmfs/cvmfs

started time in 2 months

startedMicrosoft/Windows-classic-samples

started time in 2 months

startedcernbox/reva

started time in 2 months

startedgo-hep/hep

started time in 2 months

startedamahi/spdy

started time in 2 months

startedExaScience/elprep

started time in 2 months

startedmotemen/gore

started time in 2 months

startedCovenantSQL/CovenantForum

started time in 2 months

PR opened cosmos72/gomacro

README: add syntax highlighting
+4 -4

0 comment

1 changed file

pr created time in 2 months

push eventmatiasinsaurralde/gomacro

Matias Insaurralde

commit sha cd1f244046a853eda6b5b5b3ca8fc8fb21d0e35d

README: add syntax highlighting

view details

push time in 2 months

more