profile
viewpoint

matangover/dereverberate 7

An implementation of a sound dereverberation algorithm by Gilbert Soulodre

matangover/musicquery 5

A notation-based query language for symbolic music

matangover/MuseScore 3

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!

boblsturm/folkplagiarism 1

Code to detect plagiarism in folkrnn generated output

matangover/a-painter 0

🎨 Paint in VR in your browser.

matangover/abjad 0

Abjad is a Python API for Formalized Score Control

matangover/aio-s3 0

The asyncio client for Amazon S3

matangover/atom 0

The hackable text editor

matangover/azure-devops-docs 0

This repo is the home of the official Azure DevOps documentation for Microsoft. GitHub Issues filed in this repository should be for problems with the documentation.

startedfacebookresearch/denoiser

started time in 9 days

issue commentmatangover/mypyls

pip install fails

OK thanks, I'll try

amacfie

comment created time in 19 days

issue commentmatangover/mypyls

pip install fails

Thanks! I actually already got this issue on the other repo but I couldn't reproduce it :\ I should try again. Are you also on Fedora?

amacfie

comment created time in 19 days

startedaardappel/lobster

started time in 20 days

starteddipjyoti92/SC-WaveRNN

started time in a month

startedttaoREtw/semi-tts

started time in a month

startedmanojpamk/pytorch_xvectors

started time in a month

starteddmgutierrez/spotify-musixmatch-data-collector

started time in a month

issue closedmicrosoft/pyright

List[int

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots or Code If applicable, add screenshots or the text of the code (surrounded by triple back ticks) to help explain your problem.

from typing import List, Union

def main() -> None:
    l: List[float] = [1]
    # Pyright gives error here but mypy doesn't
    func(l)

def func(param: List[Union[int, float]]):
    pass

closed time in a month

matangover

issue openedmicrosoft/pyright

List[int

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots or Code If applicable, add screenshots or the text of the code (surrounded by triple back ticks) to help explain your problem.

from typing import List, Union

def main() -> None:
    l: List[float] = [1]
    # Pyright gives error here but mypy doesn't
    func(l)

def func(param: List[Union[int, float]]):
    pass

created time in a month

issue commentmicrosoft/pylance-release

Auto-import should suggest exact matches with higher priority

P.S. I believe most other IDEs don't offer 'fuzzy' matches for auto-import, and this is why I'm surprised to see so many options in the dropdown. But as long as the best option is selected first, it doesn't matter that much.

matangover

comment created time in a month

issue commentmicrosoft/pylance-release

Auto-import should suggest exact matches with higher priority

Oh, that's great! I see two separate issues:

  1. Values from unanalyzed modules do not show up. I was just about to report this: Add import Path from pathlib doesn't show up unless I type import pathlib manually first (causing the module to be analyzed). I understand I don't need to report this, as it's already being worked on.

  2. As I wrote above: When the module is already analyzed, the ordering of the items is not intuitive (exact match doesn't come first). Is this also being worked on / improved in the next release?

Thanks!

matangover

comment created time in a month

issue openedmicrosoft/pylance-release

Auto-import should suggest exact matches with higher priority

When showing code actions for Path, I get:

image

The fourth item is clearly the one I'm after, as it's an exact match to what I've typed. Personally I'm inclined to think code actions should not suggest 'fuzzy' auto-imports at all (e.g. it's very improbably that I'm looking to import pathccompiler from numpy.distutils). That is, I don't naturally expect auto-complete in code actions, only auto-import of what I've already typed. But my main suggestion is to show the most relevant option (exact match) on top or at least have it initially selected.

created time in a month

startedpraat/praat

started time in a month

startedprosodylab/Prosodylab-Aligner

started time in a month

issue commentmatangover/mypy-vscode

Installation: Activate venv before install via pip

Thanks for the heads up! I remember testing the installation instructions on Windows so that's a bit surprising:) Let me check again to see if I can reproduce.

TimErdmann87

comment created time in a month

issue commentmatangover/mypy-vscode

not respecting mypy.ini

Hi @jbcpollak, according to the log mypy.ini is being read successfully. Can you share the contents of mypy.ini, the output of mypy on the command line, and the errors shown by the mypy plugin in VS Code? Thanks!

jbcpollak

comment created time in a month

issue openedmicrosoft/vscode-python

On macOS, selecting venv interpreter actually selects system interpreter

<!-- Please search existing issues to avoid creating duplicates. -->

Environment data

  • VS Code version: 1.48.0
  • Extension version: v2020.8.103604
  • OS and version: macOS 10.14.6
  • Python version: 3.8.1
  • Type of virtual environment used: venv
  • Value of the python.languageServer setting: Pylance

Steps to reproduce

  1. Python: Select Interpreter -> Enter interpreter path... -> Find...
  2. Browse to a venv bin directory, e.g. Documents/my-venv/bin
  3. Select the python file (it's actually a symlink, because it's a venv)
  4. Click Select Interpreter

Expected behaviour

The selected venv should show up in the interpreter status bar.

Actual behaviour

The system interpreter is selected instead. That is because the file chooser dialog follows the venv's python symlink and returns the path to the system python (or more accurately, to the Python used to create the venv).

Discussion

Electron has a noResolveAliases option for showOpenDialog, but seems like this isn't available in VS Code. I noticed that selecting the venv directory (rather than the interpreter itself) is a workaround for this bug. Another workaround is typing the path manually instead of browsing. This may be clarified to the user somehow.

created time in a month

issue openedmicrosoft/vscode-python

Space is erased from end of text when printing in notebook

Bug: Notebook Editor, Interactive Window, Editor cells

<!----------------------------------------------------------------------------------------------- PLEASE READ If this issue doesn't relate to Jupyter Notebooks, Python Interactive Window features or other notebook or "cell"-based features of the Python extension, please use the main Python bug template instead of this one. Thank you! ------------------------------------------------------------------------------------------------->

Steps to cause the bug to occur

Minimal example to reproduce:

Create a notebook with the following content in one cell, and run the cell:

import time

# Test 1 - Works as expected
print('123 ', end='')
print('456')

# Test 2 - Bug
print('123 ', end='')
time.sleep(1)
print('456')

I of course encountered this with a more complex notebook that had actual long-running operations (not time.sleep).

Actual behavior

Test 1 correctly prints 123 456, but Test 2 prints 123456. Bug happens for both classic notebook editor and preview notebook editor. Also happens in interactive window. Does NOT happen in Jupyter Notebook and Jupyter Lab.

Expected behavior

Both tests should print 123 456.

<!----------------------------------------------------------------------------------------------- Animated GIFs can be effective means to describe a bug. Consider using a tool like https://github.com/phw/peek or https://www.screentogif.com/ to create one. ------------------------------------------------------------------------------------------------->

Your Jupyter and/or Python environment

  • Jupyter server running: Local
  • Extension version: v2020.8.103604
  • VS Code version: 1.49.0-insider (4ccab0deda29628076ce1bbb17e9fef239337f21)
  • Setting python.jediEnabled: unset
  • Setting python.languageServer: Jedi
  • Python and/or Anaconda version: Python 3.8.1, not using Anaconda
  • OS: macOS Mojave 10.14.6
  • Virtual environment: venv

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

created time in a month

startediamyuanchung/Autoregressive-Predictive-Coding

started time in a month

startedDBraun/DawDreamer

started time in a month

issue closedmatangover/mypy-vscode

No .py[i] files found

I've followed the installation instructions for a mac but keep getting the error message saying

"Error running mypy: There are no .py[i] files in directory"

The default mypy linter in VSCode runs fine. Confirmed that running mypy in the directory on the terminal also works fine.

Is there anything additional that needs to be done e.g. configuring a venv or supplying additional arguments to ensure the extension picks up my files. I have a .mypy.ini file in the top level directory

closed time in 2 months

jeremygoh

push eventmatangover/mypy-daemon-vscode

Matan Gover

commit sha 4c0bf4e6ee9680cdd2eec52525e3f5a5ec8b58fe

Fix column number off-by-one error.

view details

push time in 2 months

push eventmatangover/mypyls

Matan Gover

commit sha 628ed24d07a0c41824e7aec5767b185726d34615

Update README.md

view details

push time in 2 months

issue closedmatangover/mypy-vscode

Upgrade mypy version and allow follow_imports = normal

Hello, would it be possible to upgrade the mypy version from .770 to the latest version (0.782), and change the mypyls code to allow follow_imports = normal in the config?

As of 0.780 dmypy now supports following imports. See note here: https://mypy.readthedocs.io/en/stable/mypy_daemon.html#basic-usage

Right now there is code here that blocks follow_imports = normal: https://github.com/matangover/mypyls/blob/master/mypyls/mypy_server.py#L109

Thank you very much!

closed time in 2 months

seansnyder

issue commentmatangover/mypy-vscode

Upgrade mypy version and allow follow_imports = normal

Finally done, sorry for the delay :)

seansnyder

comment created time in 2 months

push eventmatangover/mypyls

Matan Gover

commit sha de915aae8d79feb9ac9310cc19c889936b594b8d

Version 0.2.3 - Use mypy 0.782 - Use follow_imports=normal by default, as it's now supported by dmypy - Fix column number off-by-one error

view details

push time in 2 months

issue commentmatangover/mypy-vscode

No .py[i] files found

Hi, sorry for the late reply :)

  1. Do you have Python files in the root of the workspace folder (not in subfolders)? Mypy doesn't look in subfolders unless they contain an __init__.py file.

  2. You said running mypy from the terminal works fine. Do you run mypy without any arguments, or do you provide a target folder?

  3. If you want to set the target folder (or several target folders) for the mypy vscode extension, you can change the mypy.targets setting in VS Code settings.

jeremygoh

comment created time in 2 months

startedxinjli/allosaurus

started time in 2 months

startedtimgaripov/swa

started time in 2 months

startedtanersener/mobile-ffmpeg

started time in 2 months

startedgoogle/skicka

started time in 2 months

startedtiangolo/full-stack-fastapi-postgresql

started time in 2 months

startedtiangolo/meinheld-gunicorn-flask-docker

started time in 2 months

issue openedmicrosoft/pylance-release

Support inserting argument placeholders when completing function name

When completing a function, it would be nice to add argument placeholders. This is already supported by several language servers, like TypeScript, Dart, and Go, using a preference. See https://github.com/Microsoft/vscode/issues/34641.

created time in 2 months

startedperformous/composer

started time in 2 months

issue commentmatangover/mypy-vscode

Upgrade mypy version and allow follow_imports = normal

I agree. Thanks for your input!

seansnyder

comment created time in 2 months

issue commentmatangover/mypy-vscode

Upgrade mypy version and allow follow_imports = normal

Thanks! I've actually started working on this, but before pushing I was debating whether I should enable follow_imports=normal by default because it's still 'experimental' (but very useful in some cases). I was trying follow_imports=normal for about a week and it seems to be working fine. I did get a couple of internal mypy errors looking a bit like this, which may or may not be related. Perhaps the smart choice is to keep using skip by default and let users override in mypy.ini.

seansnyder

comment created time in 2 months

PR opened python/typeshed

Flask.root_path cannot be None

Extension of #2792 (see #2791). See implementation.

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventmatangover/typeshed

Matan Gover

commit sha 2b8e5fe3d3571280d118595572229d17e4329b98

Flask.root_path cannot be None Extension of #2792 (see #2791). See [implementation](https://github.com/pallets/flask/blob/4e854ee49687ceac90985526928d901570d3585d/src/flask/helpers.py#L959).

view details

push time in 3 months

fork matangover/typeshed

Collection of library stubs for Python, with static types

fork in 3 months

startedtomlepaine/fast-wavenet

started time in 3 months

startedmagenta/note-seq

started time in 3 months

startednapulen/MiniBach

started time in 3 months

more