profile
viewpoint

marun/api 0

Canonical location of the OpenShift API definition.

marun/apiserver-builder 0

apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types

marun/apiserver-library-go 0

k/k dependent helpers for kube-apiserver and openshift-apiserver

marun/build-machinery-go 0

Shared location for Makefiles, helper scripts, and other common build machinery

marun/ci-tools 0

DPTP Tooling

marun/cilium 0

API-aware Networking and Security using eBPF and XDP

marun/cincinnati-graph-data 0

Release node and upgrade edge metadata for Cincinnati graphs.

marun/client-go 0

Go client for OpenShift

marun/clientgofix 0

clientgofix rewrites calls to old k8s.io/client-go methods to use newer invocations

pull request commentopenshift/cluster-etcd-operator

Bug 1915560: operator: remove EtcdMemberIPMigratorDegraded stale condition

@openshift-bot: This pull request references Bugzilla bug 1915560, which is invalid:

  • expected dependent Bugzilla bug 1851351 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment <code>/bugzilla refresh</code> to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

<details>

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

hexfusion

comment created time in 7 hours

pull request commentopenshift/cluster-etcd-operator

Bug 1915560: operator: remove EtcdMemberIPMigratorDegraded stale condition

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

hexfusion

comment created time in 7 hours

issue commentkubernetes-sigs/controller-runtime

Patch applied but still getting an old version

I have the same issue!

cscetbon

comment created time in 11 hours

push eventtelepresenceio/telepresence

Abhay Saxena

commit sha d580844248d07d8a081b000f1258bd9ea6dcf8fa

tests: Avoid hypothesis error in forwarder test See https://hypothesis.readthedocs.io/en/latest/healthchecks.html#hypothesis.HealthCheck.function_scoped_fixture Signed-off-by: Abhay Saxena <ark3@email.com>

view details

push time in 11 hours

issue commentkubernetes-sigs/controller-runtime

Feature: extensible leader election interface

@fejta-bot: Closing this issue.

<details>

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

joelanford

comment created time in 13 hours

issue closedkubernetes-sigs/controller-runtime

Feature: extensible leader election interface

Currently, it seems like the interface exposed by controller-runtime for setting up leader election does not permit custom leader election implementations to be substituted in and used.

Controller-runtime leader election can be completely disabled, and an alternate implementation can be used outside the context of the controller-runtime manager lifecycle.

However, the manager has nice functionality that allows other Runnables to be run either before or after controller-runtime inititiates leader election, so it would be desirable for the controller-runtime manager to handle arbitrary leader election implementations that implement a well-defined interface.

closed time in 13 hours

joelanford

issue commentkubernetes-sigs/controller-runtime

Feature: extensible leader election interface

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

joelanford

comment created time in 13 hours

pull request commentkubernetes-sigs/controller-tools

🐛 Provide error when CRD has multiple versions marked for storage

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

theishshah

comment created time in 14 hours

pull request commentkubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/kubebuilder/pull/1972#" title="Author self-approved">daenney</a> To complete the pull request process, please assign estroz after the PR has been reviewed. You can assign the PR to them by writing /assign @estroz in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["estroz"]} -->

daenney

comment created time in 16 hours

pull request commentkubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

Hi @daenney. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

daenney

comment created time in 16 hours

pull request commentkubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

Welcome @daenney! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes-sigs/kubebuilder'>kubernetes-sigs/kubebuilder</a> 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. <br><br>You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines. <br><br>You may want to refer to our testing guide if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:

daenney

comment created time in 16 hours

pull request commentkubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

<!-- need_sender_cla -->

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details>

daenney

comment created time in 16 hours

pull request commentkubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7fd65d6 :bug: Don't recurse into hidden directories

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details>

daenney

comment created time in 16 hours

PR opened kubernetes-sigs/kubebuilder

:bug: Don't recurse into hidden directories

checkDir() currently recurses into hidden directories at the root. This is a problem, because only the directory itself will have a . at the root of it's path, but any files within it won't when calling info.Name. This causes init to fail on a directory containing any hidden directory with files within them, such as .git.

Since we use filepath.Walk(".") we can't skip a directory that just starts with ., as that would include the current directory. So instead we also check that Name() doesn't return just "."

Fixes #1971

+3 -0

0 comment

1 changed file

pr created time in 16 hours

issue commentkubernetes-sigs/kubebuilder

failed to initialize project with "go.kubebuilder.io/v3"

The error also triggers in a new git repo without anything present but a .git when the plugin is invoked with --repo.

abhi1693

comment created time in 16 hours

issue commentkubernetes-sigs/kubebuilder

failed to initialize project with "go.kubebuilder.io/v3"

You have a go.sum in that directory it seems, which would explain the error since it seems to only permit go.mod?

But I get the exact same error without a go.sum present, so this seems broken one way or another.

abhi1693

comment created time in 16 hours

issue openedkubernetes-sigs/kubebuilder

failed to initialize project with "go.kubebuilder.io/v3"

<!-- STOP

  • If this is an issue with some sort of runtime mechanics, it probably belongs in https://sigs.k8s.io/controller-runtime instead
  • If this is an issue with CRD generation or webhook config generation, it probably belongs in sigs.k8s.io/controller-tools instead
  • If this is an issue with scaffolding, or is definitely a cross repository effort, it probably belongs here.

-->

<!--

Hiya! Welcome to KubeBuilder! For a smooth issue process, try to answer the following questions. Don't worry if they're not all applicable; just try to include what you can :-)

If you need to include code snippets or logs, please put them in fenced code blocks. If they're super-long, please use the details tag like <details><summary>super-long log</summary> lots of stuff </details>

-->

➜  kubeact-operator git:(feat/v0.0.1) ✗ kubebuilder init                                                                                        git:(feat/v0.0.1|●53✚1…2 
Error: failed to initialize project with "go.kubebuilder.io/v3": only the go.mod and files with the prefix "(.)" are allowed before the init
Usage:
  kubebuilder init [flags]

Examples:
  # Scaffold a project using the apache2 license with "The Kubernetes authors" as owners
  kubebuilder init --project-version=2 --domain example.org --license apache2 --owner "The Kubernetes authors"


Flags:
      --component-config         create a versioned ComponentConfig file, may be 'true' or 'false'
      --domain string            domain for groups (default "my.domain")
      --fetch-deps               ensure dependencies are downloaded (default true)
  -h, --help                     help for init
      --license string           license to use to boilerplate, may be one of 'apache2', 'none' (default "apache2")
      --owner string             owner to add to the copyright
      --plugins strings          Name and optionally version of the plugin to initialize the project with. Available plugins: ("go.kubebuilder.io/v2", "go.kubebuilder.io/v3")
      --project-name string      name of this project
      --project-version string   project version, possible values: ("2", "3-alpha") (default "3-alpha")
      --repo string              name to use for go module (e.g., github.com/user/repo), defaults to the go package of the current working directory.
      --skip-go-version-check    if specified, skip checking the Go version

2021/01/24 07:14:18 failed to initialize project with "go.kubebuilder.io/v3": only the go.mod and files with the prefix "(.)" are allowed before the init
➜  kubeact-operator git:(feat/v0.0.1) ✗ ls                                                                                                                                       git:(feat/v0.0.1|●53✚1…2 
go.mod  go.sum
➜  kubeact-operator git:(feat/v0.0.1) ✗ 

<!-- What broke (please include exact error messages if you can) -->

<!-- What did you expect to happen? What do you think went wrong? -->

<!-- If you don't know what broke, but have a minimal reproducer, that would be super-helpful helpful! -->

<!--

What versions of software are you using? Specifically, the following are often useful:

  • go version go version go1.15.6 linux/amd64
  • kubebuilder version (kubebuilder version) and scaffolding version (check your PROJECT file)
  • controller-runtime version (check your go.mod file)
  • controller-tools version
  • Kubernetes & kubectl versions (just run kubectl version against your API server)

-->

  • go version go1.15.6 linux/amd64
  • git:(feat/v0.0.1|●53✚1…2 Version: main.version{KubeBuilderVersion:"3.0.0-alpha.1", KubernetesVendor:"1.19.2", GitCommit:"1428bba7c162cf2b783c89fd6f07f4efbae97130", BuildDate:"2021-01-08T22:30:36Z", GoOs:"linux", GoArch:"amd64"}

<!-- If this is actually about documentation, add /kind documentation below -->

/kind bug

created time in 16 hours

issue commentkubernetes-sigs/controller-runtime

Envtest: filtering duplicated webhook configurations by GVK and Name

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

jiachengxu

comment created time in 21 hours

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

@coderanger Interesting.. I will try and tackle those ideas. Indeed this implementation if fairly Naive.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

Or there's the option @vincepri mentioned of doing a similar looped get with an iterator function callback so you never have to hold the full list of objects in memory at once. Both could be useful in different situations.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

That List() would automatically check if a continue token was returned, and (give or take an option flag) automatically fetch the next page and combine it with the the results you already have, and repeat until no more data is returned. When accessing a huge list of objects that change frequently (e.g. all Pods) this can spread out the load on the API server, trading increased effective latency to remove the massive IO spike that could disrupt API server stability.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

@coderanger I had implemented it this way b/c I thought that is what reported in #532 - how do you view it?

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

I don't think this is what #532 was referring to. In what situation would you ever want to ask for "page 4 of the results" when you have no idea what that will even contain? The only time I could see someone doing that is in error when they want to get all items via pagination, but using this code they would get all those bugs I mentioned, which is why a pagination cursor is returned.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

@coderanger I tend to agree. I guess the idea is to hide the use of Continue from the user. Albeit the user can simply use Continue and view pages of data as it is now. Please refer to #532 for more information.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

This feels weird to me. What is the use case for this? Generally when a pagination cursor exists, not using it will lead to lots of weird race condition bugs when the object set changes between requests.

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/controller-runtime/pull/1358#" title="Author self-approved">nimrodshn</a> To complete the pull request process, please assign vincepri after the PR has been reviewed. You can assign the PR to them by writing /assign @vincepri in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["vincepri"]} -->

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

Hi @nimrodshn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

Welcome @nimrodshn! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes-sigs/controller-runtime'>kubernetes-sigs/controller-runtime</a> 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. <br><br>You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines. <br><br>You may want to refer to our testing guide if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:

nimrodshn

comment created time in a day

pull request commentkubernetes-sigs/controller-runtime

:sperkles: Add support for implicit paging in un/structured clients

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

<!-- need_sender_cla -->

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details>

nimrodshn

comment created time in a day

more