profile
viewpoint

martin-t/chat-analyzer 1

Stats / graphs from fb chat history (WIP)

martin-t/sokoban-solver 1

Mirror of https://gitlab.com/martin-t/sokoban-solver - a simple Sokoban solver in Rust

martin-t/xon-activity-stats 1

Scrape stats.xonotic.org and dpmaster.deathmask.net/?game=xonotic and make some nice graphs

martin-t/antlr4 0

ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.

martin-t/AutumnRTS 0

Real time strategy game/engine written in Rust and Godot

martin-t/c2rust 0

C to Rust translation, refactoring, and cross-checking

martin-t/criterion.rs 0

Statistics-driven micro-benchmarking library

martin-t/jcompile 0

A QuakeC compiler

martin-t/legion 0

High performance Rust ECS library

martin-t/num-traits 0

Numeric traits for generic mathematics in Rust

issue commentdeadlinks/cargo-deadlinks

Output is not deterministic and sometimes misses broken links

Seems this depends on the computer where it runs too - the above outputs are from my laptop, my desktop always produces:

Found invalid urls in /home/martin/dev/rust/legion2/target/doc/legion/struct.World.html:
        Linked file at path /home/martin/dev/rust/legion2/target/doc/query/index.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/storage/struct.ComponentTypeId.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/serialize/struct.Registry.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/query/trait.LayoutFilter.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/serialize/trait.WorldSerializer.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/storage/struct.Group.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/storage/trait.Component.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/legion/struct.Duplicate.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/legion/trait.Merger.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/event/enum.Event.html does not exist!
        Linked file at path /home/martin/dev/rust/legion2/target/doc/legion/struct.Entry.html does not exist!

This output is always the same, even after recloning and using cargo +nightly doc.

However, it still misses the broken links on the main page.

martin-t

comment created time in 6 days

PR opened amethyst/legion

2 tiny docs improvements

Some crates put examples on the struct, some on the module, I couldn't find the examples the first time i was looking for them because i am more used to docs on the struct so now i linked them explicitly. The standard library does it like this (e.g. Rc struct links to rc module).

I would do the same for World vs world but it seems the links wouldn't sometimes work as reported in #195.

Also unified whether just "Entity" or "Entity ID" is part of the link.

+3 -1

0 comment

2 changed files

pr created time in 7 days

issue openedamethyst/legion

Broken links in docs due to reexports

Example:

legion::EntityStore vs legion::world::EntityStory - the link to SubWorld on the first one is broken but works on the second one.

Note that there are probably more cases (e.g. link to SoA on the main page) but it seems cargo-deadlinks doesn't always find them all, the output changes on each run. I reported it as https://github.com/deadlinks/cargo-deadlinks/issues/56.

I don't know how to fix this until https://github.com/rust-lang/rust/issues/43466 is merged.

created time in 7 days

issue openeddeadlinks/cargo-deadlinks

Output is not deterministic and sometimes misses broken links

How to reproduce:

  • clone https://github.com/amethyst/legion and checkout 2e9219326f524ae052b4976f20ec9da3836be720
  • run cargo doc
  • run cargo deadlinks several times
  • sometimes the result will only show one broken link like:
Found invalid urls in /home/martin/dev/rust/legion/target/doc/legion/struct.WorldOptions.html:
        Linked file at path /home/martin/dev/rust/legion/target/doc/storage/struct.Group.html does not exist!
  • sometimes it will find more:
Found invalid urls in /home/martin/dev/rust/legion/target/doc/legion/struct.WorldOptions.html:
        Linked file at path /home/martin/dev/rust/legion/target/doc/storage/struct.Group.html does not exist!
Found invalid urls in /home/martin/dev/rust/legion/target/doc/legion/index.html:
        Linked file at path /home/martin/dev/rust/legion/target/doc/legion/trait.Soa.html does not exist!
        Linked file at path /home/martin/dev/rust/legion/target/doc/legion/struct.SubWorld.html does not exist!
Found invalid urls in /home/martin/dev/rust/legion/target/doc/legion/trait.IntoSoa.html:
        Linked file at path /home/martin/dev/rust/legion/target/doc/legion/trait.Soa.html does not exist!

Could it be because legion uses reexports? E.g. the SubWorld link works from legion::world::EntityStore but not from legion::EntityStore (which is also visible on the main page).

created time in 7 days

push eventmartin-t/legion

Martin Taibr

commit sha 55755b73e97a9c1fc2adc72f19422890602b8748

unify Entity vs Entity ID links

view details

push time in 7 days

create barnchmartin-t/legion

branch : docs

created branch time in 7 days

issue openedamethyst/legion

`Or` filter description

The And and Or filters have the same description - this appears to be a copy paste error.

created time in 9 days

PR opened amethyst/legion

Prefer wasm-bindgen over stdweb in readme

It seems stdweb development is dead so it might be better to show that wasm-bindgen in the example.

+1 -1

0 comment

1 changed file

pr created time in 9 days

PR opened amethyst/legion

Improve WASM feature docs

I was puzzled why i was able to compile legion to WASM without the feature - it appears to be only used in serialization so there's no need for everyone to enable it unless they use serialization.

+1 -1

0 comment

1 changed file

pr created time in 9 days

create barnchmartin-t/legion

branch : wasm-bindgen

created branch time in 9 days

create barnchmartin-t/legion

branch : serialize

created branch time in 9 days

fork martin-t/legion

High performance Rust ECS library

fork in 10 days

push eventmartin-t/AutumnRTS

Winsalot

commit sha a00bce3281f13dbe86f4f8cc53e1f28a1a9f5c50

smart movement system done. No idea if it works yet though

view details

Winsalot

commit sha ad01959d32fd9595bd6c08af430eeb65f2190401

git commit before I rework UnitState

view details

Winsalot

commit sha f2c381764e77e8e5294b4584de2386f971b49886

New smart movement system tested and it works

view details

push time in 18 days

push eventmartin-t/AutumnRTS

Winsalot

commit sha 5ae874f069934a4355f1ea4136c65769e0fc886d

New plan for developement and some changes

view details

Vilius Peteraitis

commit sha 40697a9b161d84122552e92a4c9a69cca9a24ef2

Merge pull request #1 from martin-t/master Add links, fix typos

view details

Winsalot

commit sha 7b4afb2d0122f670ee94a6d533ee9e34df13930a

Working towards first active ability

view details

Winsalot

commit sha fc934ddadde2a544473e21077892d713933d9d1d

Ongoing refactor. Commit before I inevitably break everything

view details

Winsalot

commit sha f4188810fde66ed757fda7214dea08b354764753

fps counter changes

view details

Winsalot

commit sha cf5e1028560e0fa9eaab5b7bb432870237ddea11

Merge branch 'master' of https://github.com/Winsalot/AutumnRTS

view details

Winsalot

commit sha 4ade3616238a4ad741f7afca50ea35127261b98d

refactor systems

view details

Winsalot

commit sha 73f47f51fa92881ed2713275d2c698bc78ef0ba6

Workding towards ability implementation

view details

Winsalot

commit sha 4422029c5a9c32b291b020464cf8e18887f1ef42

Implemented first ability. Some other changes

view details

Winsalot

commit sha 2b955c4715aed776986d74c7975b479fcf180d54

cargo fmt

view details

Winsalot

commit sha 2f22f4cca234320175ea2d583a6a6f0f413237dc

improve the SimState, use properly entity queries

view details

Winsalot

commit sha efa3fb84bd019fd15e71a7f24f5f8dec05a6510a

next step descriptions

view details

Winsalot

commit sha c660d38ee93868f71c8a7a59457309ad789c143c

Slowly towards refactored messages

view details

Winsalot

commit sha a2b32955bf4f9090b49eadf3e696097401295058

refactored engine messages into SimMsg

view details

Winsalot

commit sha d2ac7488f0ae389c8f4116845c70056f051d790f

Spawn players with particlar teams.

view details

Winsalot

commit sha b3e1c7dfc9f0e9873c622793292f6a1b975e1a2b

still working towards multiple teams

view details

Winsalot

commit sha 6f148eaefe4f4bcbd5b439befd156b1e4c72bf62

finally can spawn units of different factions. Also there is validation for orders

view details

Winsalot

commit sha 98ec1af855c45e99f92067c947ada8aa035e5d9c

towards targeting

view details

Winsalot

commit sha 9d0bfc286d6e27eea763b23138f2f6fe8bfa15ca

towards targeting system

view details

Winsalot

commit sha 631497d7e054d62501ab343361777e72ba20f709

finished automatic targeting system

view details

push time in 20 days

pull request commentrust-num/num-traits

Update AsPrimitive Safety docs for rust 1.45

Sure, I also changed the phrasing into past tense in the first example and removed the bullet point since it's no longer a list. Is is ok like this?

martin-t

comment created time in a month

push eventmartin-t/num-traits

Martin Taibr

commit sha 652e4204c95df50c0aeb36c102046cbf3254d03f

remove example which was never UB from AsPrimitive docs

view details

push time in a month

issue openedrustwasm/wasm-pack

--help should accept command name after the --help too

💡 Feature description

Allow wasm-pack --help <command> in addition to wasm-pack <command> --help.

💻 Basic example

Currently only wasm-pack build --help shows help message for the build command, using wasm-pack --help build produces the main help message as if i didn't specify the build command - this made me think it's not documented at all. I think wasm-pack --help build should behave just like wasm-pack build --help and shows the help message specific to the build command too.

created time in a month

starteddasifefe/rust-game-development-frameworks

started time in a month

PR opened Winsalot/AutumnRTS

Add links, fix typos

It's always helpful to provide links so people can more easily find out what you're talking about.

Also fixed a few typos i spotted, there's definitely more :P

+7 -7

0 comment

1 changed file

pr created time in a month

push eventmartin-t/AutumnRTS

Martin Taibr

commit sha 3b26d5feb6022d496e4a3c130944d7ba893483f3

add links, fix typos

view details

push time in a month

fork martin-t/AutumnRTS

Real time strategy game/engine written in Rust and Godot

fork in a month

push eventmartin-t/sokoban-solver

Martin Taibr

commit sha 11288f2d04bcea7b1a42927df7e031488fb7c525

Update README.md

view details

push time in a month

startedWinsalot/AutumnRTS

started time in 2 months

pull request commentyoanlcq/vek

Make Display impl respect formatting parameters

Hmm, they might not impl Display but they do impl Debug...

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6e584bde76b74bb3f0d94bbc9f8beab8

...which appears to have the same "issue" as this code, same with tuple structs. So if std is ok with this behavior, i guess it's fine here.

This looks great to me. Would you like to add anything before I merge this? :)

Nope, i think it's done.

martin-t

comment created time in 2 months

pull request commentyoanlcq/vek

Make Display impl respect formatting parameters

I did the same for matrices and realized i don't need macro recursion so i also replaced the recursive solution with iteration on vectors because it looks cleaner to me. Didn't bench perf - not sure if it matters for printing. Relatedly - matrices have two Display impls - for row-major and column-major - if perf doesn't matter, could be simplified into one by using Index.

This PR solved the original issue i had but i am not sure all its effects are so desirable - e.g.:

let v1 = Vec2::new(5.322, 6.464616);
let v2 = Vec2::new(-5.0003, -0.0);
println!("{1:6.2} | {0:6.2}", v1, v2);

aligns the individual elements which might be surprising if people want to align the whole result instead. (Sry no example in comment, GitHub removes consecutive spaces fsr) Not sure what other similar crates do - your thoughts?

martin-t

comment created time in 2 months

push eventmartin-t/vek

Martin Taibr

commit sha 5ab4c93e765a795dae0338770c8f54bc860852df

document format for Display on Vecs

view details

Martin Taibr

commit sha 782bcfe346ae16a78fd6542ffa8f1e8c1b8d4dc7

make Display on matrices respect formatting params

view details

Martin Taibr

commit sha 8d75d60096c70caa0607eaa4703d2694a63f53b0

replace macro recursion by iteration through vector elements

view details

Martin Taibr

commit sha 84603183dfa13cfe0d01e9279246c083ba115fd5

add martin-t to readme

view details

push time in 2 months

issue commentyoanlcq/vek

Casting can no longer produce undefined behavior (UB)

I noticed the text here originally comes from the num-traits crate and opened a PR there. In the process, i noticed the second case (float to float conversion) probably never was UB and the second example might be removed. Might wanna keep an eye on that PR to keep the docs in sync.

martin-t

comment created time in 2 months

PR opened rust-num/num-traits

Update AsPrimitive Safety docs for rust 1.45

Fixes #174

The safety section should not be removed entirely since people might be using older compilers (as was pointed out to me in a related issue in the vek crate).

However, this and followup comments indicate that the second case (float to float) was never UB in the first place - should the second example be removed?

+2 -2

0 comment

1 changed file

pr created time in 2 months

push eventmartin-t/num-traits

Martin Taibr

commit sha 7d26cecdabf96c871314ff49b54593a57032f4b1

update AsPrimitive Safety docs for rust 1.45

view details

push time in 2 months

fork martin-t/num-traits

Numeric traits for generic mathematics in Rust

fork in 2 months

issue openedyoanlcq/vek

Casting can no longer produce undefined behavior (UB)

It looks like the 2 issues linked here and in some other places have been resolved and the reference has been updated too.

Should i update the docs?

created time in 2 months

issue openedrustwasm/wasm-bindgen

Strange naming scheme for overloaded methods where some params have a different position

Using CanvasRenderingContext2D.drawImage() as example:

The overloads all have dx and dy but overload 3 has them in a different position with sx and sy in their original place. The generated methods however contain dx and dy but never mention sx and sy. Wouldn't a more correct name be draw_image_with_html_image_element_and_sx_and_sy_and_sw_and_sh_and_dw_and_dh?

created time in 2 months

PR opened yoanlcq/vek

Make Display impl respect formatting parameters

Fixes #57

I don't think there's a cleaner (without another macro) way to handle the repetition.

I used fmt_prefix but i noticed you prefer naming without underscores, should i rename it to fmtprefix?

Not sure how to proceed with the doc comments:

Option 1: keep it as it: e.g. "Displays the vector, formatted as ({}, {}, {})." - it wouldn't be completely right since it now passes the formatting params correctly. Which actually reminds me that this PR is technically a breaking change.

Option 2: e.g. "Displays the vector, formatted as ({...}, {...}, {...}) where ... are the actual formatting parameters." - would pass this into the macro as $fmt in addition to $fmt_prefix.

Option 3: make it somewhat vague like "Displays the vector, numbers are separated by commas." - would also need a special case for the vectors with prefixes.

Thoughts?

Also when we agree how to do this, I should do the same for matrices.

+40 -24

0 comment

1 changed file

pr created time in 2 months

push eventmartin-t/vek

Martin Taibr

commit sha 894b0cb362af3b09b9d006cf9f911a54bc2f680c

improve comment

view details

push time in 2 months

push eventmartin-t/vek

Martin Taibr

commit sha cf2894aa67c120423a867ccefa778f52b8e6108f

respect formatting parameters in Display

view details

push time in 2 months

issue openedyoanlcq/vek

Display impl should respect formatting parameters like Debug

Example: Currently formatting with {:.2?} correctly shows only 2 decimal places but using {:.2} prints all the digits.

I took a brief look at the code and I think it's only a matter of slightly modifying the macro:

  • take only e.g "rgba" instead of "rgba({}, {}, {}, {})"
  • iterate through the vector's elements and pass them the Formatter when printing them

If you agree, i should be able to make a PR.

created time in 2 months

fork martin-t/vek

Generic 2D-3D math swiss army knife for game engines, with SIMD support and focus on convenience.

https://docs.rs/vek

fork in 2 months

issue openedrustwasm/wasm-bindgen

Some web-sys docs link to pages which don't exist - should point to the type instead

Some properties and methods on MDN are only documented on the type's page and don't have a separate page. The generated docs, however, assume the pages exist.

Examples: property: HtmlInputElement::height() should link to HTMLInputElement inherited method: DomMatrix::rotate() should link to DOMMatrixReadOnly

created time in 2 months

push eventmartin-t/xonotic-config

Martin Taibr

commit sha 77769d4a11a9d5965e003cca3d44358da77a31af

try something

view details

push time in 3 months

more