profile
viewpoint
Who? Me?! mark-i-m operating systems, compilers, distributed systems, and chocolate. A follower of Jesus Christ :)

mark-i-m/jobserver 5

A jobserver for running experiments on test machines and copying results back.

mark-i-m/journey 2

Microbenchmarks for linux memory management system

mark-i-m/bus 1

Hacky CLI Utility to help me with buses...

mark-i-m/isb350c 1

A toy implementation of the ISB in verilog for our toy processor.

mark-i-m/backlight 0

Simple program to update the backlight brightness on my laptop

mark-i-m/BaseConverter 0

Converts any base (2 to 35) integer to any other base (2 to 35)

mark-i-m/beta.rust-lang.org 0

the home of the new rust website - now in beta!

mark-i-m/blog.rust-lang.org 0

The Rust Programming Language Blog

mark-i-m/bmk_linux 0

My collection of useful stuff for writing benchmarks on Linux ~4.4 (not very idiomatic or complete)

mark-i-m/bootloader 0

An experimental pure-Rust x86 bootloader

push eventmark-i-m/jobserver

mark

commit sha f6aa62d434b05a50c278dc88feb08ee1a6917eec

update changelog

view details

push time in 2 days

push eventmark-i-m/jobserver

mark

commit sha cd6addb21e7d3194cf4e82dd8fc70e19cb006a2b

isolate unknown hosts to their own class to avoid repeated failures

view details

push time in 2 days

push eventmark-i-m/jobserver

mark

commit sha 9bffa258170b9e679041e5ba4b2378675164153b

fix rsync command

view details

push time in 2 days

push eventmark-i-m/jobserver

mark

commit sha 5ff2f4b56a9d562c18c533a9aae0aa4821230a95

detect and handle unknown SSH hosts during results copying

view details

push time in 2 days

push eventmark-i-m/jobserver

mark

commit sha 176e97f751dcc4f56f4aefef7cc6d8e9b56dbfdf

backwards logic

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha 857dca32684dd3ab287fe11e8c0755a752880a22

add flag to skip headers in text mode

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha c2280cc1bcef3a3edc84038bc5b7aec71d1813cf

also copy error log

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha 78dfe86d9706d0637782bac58fa5b2e215a08289

fix cli for cpresults

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha 8f333f43ee212ff1923fac32c5de3d594a469524

reorder args for cpresults

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha e47f28f50fd8d6275ac08f8a1b43e7c1e5b287c9

add job cpresults subcommand (untested)

view details

push time in 3 days

push eventmark-i-m/jobserver

mark

commit sha 147dee17c8f73aaa9ef9a510e7502b4139473a1f

remove commands/flags in preparation for improving job stat

view details

mark

commit sha 4d47666928e73a8816118936ae093fd5feea8465

rename job matrix stat -> ls

view details

mark

commit sha 6463f75a15f2fa42274c20afcc9d7f078cca0248

update changelog with planned changes

view details

mark

commit sha a17c22c57607a66397e54902b276b9d8687e2289

start to break up client into smaller files

view details

mark

commit sha 361a34fe78ecb41d13ee6040dc647f64181cd683

move pretty-printing to a new module

view details

mark

commit sha e94d6542aa1b32aa237aca530998b07be0c0d5f8

minor cleanup

view details

mark

commit sha b9a23585c175f5fa4690c7d64ca672851b5936f8

more cleanup

view details

mark

commit sha 82e1324157bb34d541b01156b4cbbcf21f674919

add new module for post-processing jobs

view details

mark

commit sha 5ce528bed6e4da6569d5d6c7587efa10f0905757

move cli to new module

view details

mark

commit sha 21a960d13ea8e3360660c0aeb3592a9d7f06229e

update deps and add serde

view details

mark

commit sha 33a4b8f336eb4eac850d65da9b82ceed421cf524

minor refactor to machine subcommand cli builder

view details

mark

commit sha cb03521f87626e53707631f6a52b7d6e254055dc

implement first draft of new job stat cmd (untested)

view details

mark

commit sha 6a5b8b6a01f294b3aa0e4be1c8718bc17fb20c5e

bump major version

view details

mark

commit sha f2e265dbfe89159d8360e5538aedc4279ae09496

fix flag name

view details

mark

commit sha feb8ac0cb507d2723724a288d03a3dea1a940d0c

fix flag name

view details

mark

commit sha 1a94d9072d3dde83ceeb77db74f0dab324209580

fix CSV output error

view details

mark

commit sha 2fc839b9887febe9f1979a24ca9b9916c6b35891

fix --id flag of job stat

view details

mark

commit sha 0ba896fbdd888d0232ca8f2152c539acb71e7141

require outputing at least one column

view details

mark

commit sha 7e30845953dee6ac58daf151c7dee927fee5d717

add ability to print results path

view details

mark

commit sha 99e4705f99adf4a1edb3165833a899564e9cda04

clean up changelog a bit

view details

push time in 4 days

push eventmark-i-m/jobserver

mark

commit sha 1e647ad57f3c1c98c710cdec2279eda64a9aaf61

update changelog

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha 0ba896fbdd888d0232ca8f2152c539acb71e7141

require outputing at least one column

view details

mark

commit sha 7e30845953dee6ac58daf151c7dee927fee5d717

add ability to print results path

view details

mark

commit sha 99e4705f99adf4a1edb3165833a899564e9cda04

clean up changelog a bit

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha 2fc839b9887febe9f1979a24ca9b9916c6b35891

fix --id flag of job stat

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha 1a94d9072d3dde83ceeb77db74f0dab324209580

fix CSV output error

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha feb8ac0cb507d2723724a288d03a3dea1a940d0c

fix flag name

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha f2e265dbfe89159d8360e5538aedc4279ae09496

fix flag name

view details

push time in 5 days

push eventmark-i-m/jobserver

mark

commit sha 6a5b8b6a01f294b3aa0e4be1c8718bc17fb20c5e

bump major version

view details

push time in 5 days

create barnchmark-i-m/jobserver

branch : jobstat

created branch time in 5 days

delete branch mark-i-m/team

delete branch : patch-3

delete time in 7 days

pull request commentrust-lang/team

Remove mark-i-m from wg-prioritization

@pietroalbini to merge? (Sorry, not sure who else to ping)

mark-i-m

comment created time in 7 days

startedchriswalz/bit

started time in 7 days

push eventmark-i-m/jobserver

Mark Mansi

commit sha 295feb847ab9ce3d4ea9a113a5174f431422d8fa

update cargo.lock

view details

push time in 8 days

push eventmark-i-m/jobserver

Mark Mansi

commit sha 7ee7ed0c4dff31f1956bb47d1ae012d62b3f4da2

fix underflow

view details

Mark Mansi

commit sha c2756371f53ec405c29e980792ab2cf0f59bfab9

bump minor version

view details

push time in 8 days

starteddtolnay/paste

started time in 8 days

startedoxidecomputer/expectorate

started time in 8 days

startedoxidecomputer/dropshot

started time in 8 days

startedoxidecomputer/tockilator

started time in 8 days

Pull request review commentrust-lang/rustc-dev-guide

Use official mdbook-linkcheck version

 New-Item -Path .git/hooks/pre-commit -ItemType HardLink -Value <absolute_path/to We use `mdbook-linkcheck` to validate URLs included in our documentation. To perform link checks, uncomment the `[output.linkcheck]` field in the `book.toml` configuration file and install `mdbook-linkcheck` with:  ```bash-> cargo install mdbook-linkcheck --git https://github.com/Michael-F-Bryan/mdbook-linkcheck --rev 14441d77646d58cea8ffc32fde9ea33b2bedb1a2+> cargo install mdbook-linkcheck ``` -Note that we use an alpha version of `mdbook-linkcheck` to be able to use a feature that hasn't landed in a release yet.-You will also need `mdbook` version `>= 0.3.5`.+You will need `mdbook` version `>= 0.3.5` and `mdbook-linkcheck` version `>= 0.7.1` to check links.

We could also just update the number to the most recent version...

camelid

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Use official mdbook-linkcheck version

 New-Item -Path .git/hooks/pre-commit -ItemType HardLink -Value <absolute_path/to We use `mdbook-linkcheck` to validate URLs included in our documentation. To perform link checks, uncomment the `[output.linkcheck]` field in the `book.toml` configuration file and install `mdbook-linkcheck` with:  ```bash-> cargo install mdbook-linkcheck --git https://github.com/Michael-F-Bryan/mdbook-linkcheck --rev 14441d77646d58cea8ffc32fde9ea33b2bedb1a2+> cargo install mdbook-linkcheck ``` -Note that we use an alpha version of `mdbook-linkcheck` to be able to use a feature that hasn't landed in a release yet.-You will also need `mdbook` version `>= 0.3.5`.+You will need `mdbook` version `>= 0.3.5` and `mdbook-linkcheck` version `>= 0.7.1` to check links. `linkcheck` will be run automatically when you build with the instructions in the section above.  **Please note**: You may receive errors like the following when link checks are active on local `mdbook` builds:

I think it's still theoretically possible (e.g. if a file has a ton of links or if you touch a bunch of files). I thinks it's ok to keep this.

camelid

comment created time in 8 days

PullRequestReviewEvent

pull request commentrust-lang/rust

Add regression issue template

How about something like "Breakage on Stable Rust"

camelid

comment created time in 8 days

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha d1e314f53ebae543e5491c5b0587452345c2365c

Recommend debug-logging instead of debug This makes the compiler faster to running without sacrificing too much performance. It still shows logging so contributors aren't confused by `debug!` doing nothing.

view details

push time in 11 days

PR merged rust-lang/rustc-dev-guide

Recommend debug-logging instead of debug waiting-on-review

This makes the compiler faster to run without sacrificing too much functionality. It still shows logging so contributors aren't confused by debug! doing nothing.

This includes the changes from https://github.com/rust-lang/rust/pull/77701.

cc @Mark-Simulacrum

+7 -20

2 comments

1 changed file

jyn514

pr closed time in 11 days

PullRequestReviewEvent

delete branch mark-i-m/rustc-guide

delete branch : better-ci-2

delete time in 11 days

push eventmark-i-m/rustc-guide

Who? Me?!

commit sha 436ffc37aaab2a3dc44687e606c7bd98efcb5992

Better error message Co-authored-by: Camelid <camelidcamel@gmail.com>

view details

push time in 11 days

push eventmark-i-m/rustc-guide

Who? Me?!

commit sha 4e840a0af897e1f7501fd759b6a719a6530eec07

Lol logic is hard Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

push time in 11 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

+#!/usr/bin/env bash++if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then # running in cron job+  FLAGS=""++  echo "Doing full link check."+elif [ "$CI" = "true" ] ; then # running in PR CI build+  CHANGED_FILES=$(git diff --name-only $TRAVIS_COMMIT_RANGE | tr '\n' ' ')

Ok, I have added the check.

mark-i-m

comment created time in 11 days

PullRequestReviewEvent

push eventmark-i-m/rustc-guide

mark

commit sha 4fd429aa1385711a3fc3aa5558f0ee74a5caad07

add assert

view details

push time in 11 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

+#!/usr/bin/env bash++if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then # running in cron job+  FLAGS=""++  echo "Doing full link check."+elif [ "$CI" = "true" ] ; then # running in PR CI build+  CHANGED_FILES=$(git diff --name-only $TRAVIS_COMMIT_RANGE | tr '\n' ' ')

Hmm... As I understand it, neither the range nor the environment variable will be empty for push or pr runs... that is, if you either create a new PR or push commits to a PR, TRAVIS_COMMIT_RANGE will exist and contain a non-empty range with all changes back to the merge-base with master...

Thus, I believe the ! [ "$TRAVIS_EVENT_TYPE" = push ] is incorrect?

mark-i-m

comment created time in 11 days

PullRequestReviewEvent

push eventmark-i-m/rustc-guide

Who? Me?!

commit sha 6dd9d5eef143cbaf5d446359f730168cf9ab4377

More debuggable bash settings Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

push time in 11 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

+#!/usr/bin/env bash++if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then # running in cron job+  FLAGS=""++  echo "Doing full link check."+elif [ "$CI" = "true" ] ; then # running in PR CI build+  CHANGED_FILES=$(git diff --name-only $TRAVIS_COMMIT_RANGE | tr '\n' ' ')

I'm not sure I understand the concern... wouldn't [ -n "$TRAVIS_COMMIT_RANGE" ] be sufficient?

mark-i-m

comment created time in 11 days

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

+#!/usr/bin/env bash

What do these do?

mark-i-m

comment created time in 11 days

PullRequestReviewEvent

push eventmark-i-m/rustc-guide

Who? Me?!

commit sha daed1a228a60d0835f35652283bc2788e16b13e2

Add comment referring to travis docs Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

push time in 11 days

push eventmark-i-m/team

Steve Klabnik

commit sha 3c4e1d6cc7aa534947ae544655513075c7810e5d

Remove myself from the crates.io team While I do care about policy, and want to help with that in the future, I haven't done any work on crates.io in a long time.

view details

Yohei Tamura

commit sha 526d2f5993c0daa5120aef8bead6cb00fe4292f3

add tamuhey to icebreakers and wg-prioritization

view details

Pietro Albini

commit sha 7f1ea9577fdd69d1b1b149f62417aa2cce4feedc

Merge pull request #436 from tamuhey/add_tamuhey_icebreakers_wgprio Add tamuhey to icebreakers and wg-prioritization

view details

Niko Matsakis

commit sha 14d5eeaee0e57f03d66f558a67bd80cff9642d31

adjust project_foundation to have me/ag_dubs as leads, few members As discussed in the group, ag_dubs/nikomatsakis will be driving the effort going forward, with pietro/skade helping as needed.

view details

Pietro Albini

commit sha 76636a13dadd4ea405ab79c6399b48c477ffb798

Merge pull request #440 from nikomatsakis/master adjust project_foundation to have me/ag_dubs as leads, few members

view details

Kyle J Strand

commit sha 2a29a8d0ce2f14ca928933e977ce44fc82903937

Remove myself from Release team

view details

Mark Rousskov

commit sha b095e673abb8eadec90a47f2d27b19379c1f1adc

Merge pull request #441 from BatmanAoD/patch-3 Remove myself from Release team

view details

Steve Klabnik

commit sha 89207252eb914c6835a500d77debdb0b9176b6ff

add myself to alumni

view details

Pietro Albini

commit sha 295fe6d393a318c4fcb62ffc7f874bd4b11a5992

Merge pull request #414 from rust-lang/steveklabnik-patch-1 Remove myself from the crates.io team

view details

Tyler Mandry

commit sha 8425affb8eef7a1560f8846ed448ae8f10ab2e98

Add @lbernick, @betamos, @bIgBV to wg-async-foundations And sort the list of members.

view details

Tyler Mandry

commit sha dd2422a98dbbd422d00cbd627728762fb50ba2a2

Update people/bIgBV.toml with email Co-authored-by: Bhargav <bIgBV@users.noreply.github.com>

view details

Stefano Probst

commit sha da9c40d394aa48b64715c01fa7fc46007e81e9a4

Remove senden9 from icebreakers

view details

Manish Goregaokar

commit sha 9bcbf85dfac48cc759e6d17db8e552b5967c390a

Merge pull request #447 from senden9/feature/remove_senden9 Remove senden9 from icebreakers

view details

Pietro Albini

commit sha 1525bd30513741223d02602e24b5ea63ab340ac5

Merge pull request #442 from tmandry/new-members Add @lbernick, @betamos, @bIgBV to wg-async-foundations

view details

Camelid

commit sha d21d90c283b9a7b5ea4ad9b444607af4091fba22

Add myself to wg-triage

view details

Pietro Albini

commit sha db0d277a63d6e8aedddcc1d7e433074c2d3945bd

Merge pull request #448 from camelid/patch-2 Add myself to wg-triage

view details

Santiago Pastorino

commit sha dd160729441401ab9d8bddde30c4a2b15cde48b1

Add Joshua Nelson as a Rustc Dev Guide WG lead

view details

Manish Goregaokar

commit sha 8acc0ca985a25e6e73ef09895299c37c66a5ff06

Merge pull request #449 from spastorino/add-jyn514-as-guide-lead Add Joshua Nelson as a Rustc Dev Guide WG lead

view details

Who? Me?!

commit sha 91d62e41d02bcd0416e0bb35e9d03e7bf281a105

Merge branch 'master' into patch-4

view details

push time in 11 days

pull request commentrust-lang/team

Remove mark-i-m from wg-prioritization

@spastorino Not related to the other PR, but just mentioning it....

mark-i-m

comment created time in 12 days

pull request commentrust-lang/team

Add Joshua Nelson as a Rustc Dev Guide WG lead

🚀

(also fyi #439)

spastorino

comment created time in 12 days

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

Ah, yeah, that's a good idea.

mark-i-m

comment created time in 13 days

push eventmark-i-m/rustc-guide

mark

commit sha 2edc2c1fe916cbdb573abdf899fdc821a7e2ebff

pin mdbook-linkcheck version

view details

push time in 13 days

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

Ok, I've squashed... I'm actually ok with just merging this, even though it will cause us to use master mdbook-linkcheck.

mark-i-m

comment created time in 13 days

push eventmark-i-m/rustc-guide

mark

commit sha 5e44f19db25bb1054378961cf6bf3622b6448939

linkcheck only for changed files except in cron jobs

view details

push time in 13 days

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

Indeed, it does seem to work properly this way.

mark-i-m

comment created time in 13 days

push eventmark-i-m/rustc-guide

mark

commit sha c108ac7f2b3368a22a7abf66fe219d5c94f1292c

remove unneeded line

view details

push time in 13 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash -if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then+if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then # running in cron job   FLAGS=""    echo "Doing full link check."-else-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r origin/master... | tr '\n' ' ')+elif [ "$CI" = "true" ] ; then # running in PR CI build+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ')   FLAGS="-f $CHANGED_FILES" -  echo "Checking files changed in origin/master...: $CHANGED_FILES"+  echo "Checking files changed in $TRAVIS_COMMIT_RANGE: $CHANGED_FILES"+else # running locally+  COMMIT_RANGE=master..

Why?

mark-i-m

comment created time in 13 days

PullRequestReviewEvent

push eventmark-i-m/rustc-guide

mark

commit sha 2ce3e0f964b09e67c902a651d40c6f265670849c

play around with ranges a bit more

view details

push time in 13 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

+#!/usr/bin/env bash++if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then # running in cron job+  FLAGS=""++  echo "Doing full link check."+elif [ "$CI" = "true" ] ; then # running in PR CI build+  COMMIT_RANGE=$(echo $TRAVIS_COMMIT_RANGE | sed 's/\.\.\./../g')+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $COMMIT_RANGE | tr '\n' ' ')+  FLAGS="-f $CHANGED_FILES"++  echo "Checking files changed in $TRAVIS_COMMIT_RANGE: $CHANGED_FILES"+else # running locally+  COMMIT_RANGE=master..+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $COMMIT_RANGE | tr '\n' ' ')

Interesting... it looks like git diff parses ranges with different syntax from git diff-tree...

@camelid Any reason for including origin/master, rather than just master? For me, my local master branch is more up-to-date than my origin/master branch, so using origin/master makes it think that nearly every file has changed...

mark-i-m

comment created time in 13 days

PullRequestReviewEvent

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

@jyn514 @camelid The latest commit pulls out the files I would expect it to... Now the question is: is it correct? You both suggested simpler alternatives. Could you explain why they are more correct than what we have now?

mark-i-m

comment created time in 13 days

push eventmark-i-m/rustc-guide

mark

commit sha c1624657af1ccdcdbeb6e655a1fe84926421795d

still working on fixing commit range

view details

push time in 13 days

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

Hmm... somehow we are still messing up the git commit ranges, so there is something I don't understand. However, hopefully the current version works correctly.

mark-i-m

comment created time in 13 days

push eventmark-i-m/rustc-guide

mark

commit sha 20490d53fc9c00b28c7e91535341daafec506f52

fix commit ranges, attempt #2

view details

push time in 13 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash  if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then-  echo "Doing full link check."   FLAGS=""-else-  echo "Checking files changed in commit range: $TRAVIS_COMMIT_RANGE"-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ') -  echo "Checking only changed files: $CHANGED_FILES"+  echo "Doing full link check."+else+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r master..HEAD | tr '\n' ' ')

Hmm... well, it seems like it didn't work...

mark-i-m

comment created time in 13 days

PullRequestReviewEvent

push eventmark-i-m/rustc-guide

mark

commit sha 5659e322370c454081822f0eac68ba154b4dce8b

use master mdbook-linkcheck for now

view details

push time in 13 days

issue commentrust-lang/rustc-dev-guide

Add more about why stage 2 is useful and what constraints bootstrapping has

I changed the title. I think the current docs still don't get me to the point where I fully/intuitively understand the requirements for bootstrapping. For example. I still find it hard to grasp the answers to things like this:

  • Why is stage 2 needed at all? (which Mark answers in that thread)
  • Why can't we make rustc build with beta std or vice versa?
  • Why is cfg(bootsrap) needed?
  • Why not in the compiler?
  • Why build the compiler with beta instead of something else?
  • etc

I believe you have had a deep dive into these sorts of questions recently too.

mark-i-m

comment created time in 13 days

startedmozilla/uniffi-rs

started time in 13 days

startedverilator/verilator

started time in 13 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash  if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then-  echo "Doing full link check."   FLAGS=""-else-  echo "Checking files changed in commit range: $TRAVIS_COMMIT_RANGE"-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ') -  echo "Checking only changed files: $CHANGED_FILES"+  echo "Doing full link check."+else+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r master..HEAD | tr '\n' ' ')

I just changed it to origin/master, so I think this should work properly, but let's just watch the first few PRs and make sure that the right set of files is checked.

mark-i-m

comment created time in 14 days

PullRequestReviewEvent

pull request commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

@camelid Yes, and also good catch on the endpoint... I misread the docs.

mark-i-m

comment created time in 14 days

push eventmark-i-m/rustc-guide

mark

commit sha 7be957322ed2edcfc1809479d5db59b8b3a2a336

use proper endpoint ... head is implied

view details

push time in 14 days

push eventmark-i-m/rustc-guide

mark

commit sha 2e6bfe349ef8a580ea8b399e8e1545409cea8a73

make sure it is origin/master

view details

push time in 14 days

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash  if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then-  echo "Doing full link check."   FLAGS=""-else-  echo "Checking files changed in commit range: $TRAVIS_COMMIT_RANGE"-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ') -  echo "Checking only changed files: $CHANGED_FILES"+  echo "Doing full link check."+else+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r master..HEAD | tr '\n' ' ')

That said, I'm not super confident...

mark-i-m

comment created time in 14 days

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash  if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then-  echo "Doing full link check."   FLAGS=""-else-  echo "Checking files changed in commit range: $TRAVIS_COMMIT_RANGE"-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ') -  echo "Checking only changed files: $CHANGED_FILES"+  echo "Doing full link check."+else+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r master..HEAD | tr '\n' ' ')

I think it is this repo. I messed it up a few times before it finally worked.

mark-i-m

comment created time in 14 days

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

 #!/usr/bin/env bash  if [ "$TRAVIS_EVENT_TYPE" = "cron" ] ; then-  echo "Doing full link check."   FLAGS=""-else-  echo "Checking files changed in commit range: $TRAVIS_COMMIT_RANGE"-  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r $TRAVIS_COMMIT_RANGE | tr '\n' ' ') -  echo "Checking only changed files: $CHANGED_FILES"+  echo "Doing full link check."+else+  CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r master..HEAD | tr '\n' ' ')

Even though we rebase first?

https://github.com/rust-lang/rustc-dev-guide/blob/d4581a56ae7b16c258b7e43b21d9caacc66e9ff4/.travis.yml#L18

mark-i-m

comment created time in 14 days

PullRequestReviewEvent

startedtidyverse/ggplot2

started time in 14 days

push eventmark-i-m/rustc-guide

mark

commit sha 82294ad9efdc6a1cf6fa104a2e8a969b891f45e9

fix git range to be usable locally

view details

push time in 14 days

push eventmark-i-m/rustc-guide

mark

commit sha 0cd568df7478968cd3a66ee4e1b540913eb07298

check all commits in the PR

view details

push time in 14 days

push eventmark-i-m/rustc-guide

mark

commit sha 43d424ca837421bcb3c532b4b823c68cfbae47da

update mdbook-linkcheck version

view details

push time in 14 days

pull request commentMichael-F-Bryan/mdbook-linkcheck

Add option to check subset of files

Thanks @Michael-F-Bryan! Any possibility of a point release soon?

mark-i-m

comment created time in 14 days

create barnchmark-i-m/rustc-guide

branch : better-ci-2

created branch time in 14 days

PR opened rust-lang/rustc-dev-guide

Linkcheck only changed files (except for cron jobs)

Closes #886

In this PR, we change the CI setup to only check files that have changed in the most recent git commit. This means that changes in PRs are less likely to get blocked on unrelated breakage (it's still possible if that breakage happens to be in the same file).

On the other hand, we do want to periodically check all files. Currently, there is a cron job that runs every day. We change the CI script to check if the Travis run is a cron job and if so do a full link check. The hope is that by having the cron job run often enough and preserving the linkcheck cache, we can continue to find breakage relatively soon while avoiding the 429 Too Many Requests issues we've been seeing.

This is currently blocked on a new mdbook-linkcheck release.

+14 -0

0 comment

2 changed files

pr created time in 14 days

issue commentrust-lang/rustc-dev-guide

Only run linkcheck on changed files

Michael-F-Bryan/mdbook-linkcheck#41 has merged... I'll try to put up some sort of PR soon...

camelid

comment created time in 14 days

startedgonum/plot

started time in 15 days

pull request commentrust-lang/rustc-dev-guide

Name `rustbuild` instead of saying 'the bootstrap binary'

What's the status of this?

jyn514

comment created time in 16 days

pull request commentrust-lang/rust

Add a command to install a git hook to automatically run `x.py test tidy --bless`

What's the status of this?

caass

comment created time in 16 days

pull request commentrust-lang/rustc-dev-guide

Explain stages in terms of the compiler currently running (take N+1)

Personally, I think this is an improvement. Many thanks to @jyn514 for continuing to pursue improvements to the bootstrapping system!

jyn514

comment created time in 16 days

push eventrust-lang/rustc-dev-guide

Santiago Pastorino

commit sha c583e8b98290ac10d6a49bd2105fd424123a5534

hir_map -> hir()

view details

push time in 16 days

PR merged rust-lang/rustc-dev-guide

Hir map

I believe what's right now in the guide is outdated.

+2 -2

4 comments

1 changed file

spastorino

pr closed time in 16 days

PullRequestReviewEvent
more