profile
viewpoint
Marc R. Hoffmann marchof @mtrail GmbH Berne

marchof/java-almanac 698

Some Java Historiography

marchof/asm 34

Fork of the ASM Java bytecode manipulation and analysis framework at http://asm.ow2.org/

marchof/jacoco-maven-examples 17

Examples of Maven builds with JaCoCo for different JVM languages

marchof/lambda-mechanics 6

Examples for "Lambda Mechanics" presentation

marchof/article-eclipsecommands 1

The never finished article about the Eclipse command framework

marchof/eclipseinspector 1

Eclipse plug-in for runtime inspection

marchof/io.javaalmanac.sandbox 1

Java sandboxes for javaalmanac.io

issue commentjacoco/jacoco

Feature: Support Cobertura output format for coverage

This can be a perfect tool separate from JaCoCo.

Please understand that we have no time to take care of all the questions and issue that arise from the integration with all those tools, especially if we don't own the file format.

dragetd

comment created time in 2 days

push eventmarchof/java-almanac

GitHub Action

commit sha ae8f256f839dd15bd39eefdd25efc50acc4669f2

Update API diffs to 11.0.9+11-adpt

view details

push time in 2 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha cad825385ba4e1ff81723ea03b96327c6db776db

Use lower case for os tags

view details

push time in 5 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 316ac8a86f059ffb00c1622f952883edab2f1c8a

Add latest Java 16 features

view details

push time in 5 days

issue closedjacoco/jacoco

Feature: Support Cobertura output format for coverage

  • JaCoCo version: JaCoCo 0.8.5.201910111838
  • Operating system: Gentoo x86 linux-5.4.72-gentoo
  • Tool integration: Maven / Gradle
  • Description of your use case:

I am using Jacoco in a CI/CD envionrment with GitLab. GitLab is an alternative Git-based platform for project-management that has integrated CI/CD functionality. It allows parsing Cobertura based coverage reports and integrating them directly in the Diff view for a merge request. The functionality is described here: https://docs.gitlab.com/ee/user/project/merge_requests/test_coverage_visualization.html#maven-example

The recommendation is to use the well supported and modern coverage tool Jacoco. But the common parsing format for coverage is based on Cobertura. To bridge that gap, they recommend using two little converter scripts that convert the coverage report to Cobertura compatible format, based on these scripts: https://gitlab.com/haynes/jacoco2cobertura

Eventho this is a viable approach, I wonder how difficult it would be to implement a feature to output Cobertura format directly from JaCoCo.

A random example for the format I found online: https://gist.github.com/apetro/fcfffb8c4cdab2c1061d

Possible Workarounds

If such functionality is out of the scope of this project, I do not think there is any viable workaround. Instead, users should use scripts like https://gitlab.com/haynes/jacoco2cobertura or GitLab should integrate parsing the JaCoCo XML format.

closed time in 5 days

dragetd

issue commentjacoco/jacoco

Feature: Support Cobertura output format for coverage

Indeed, this is out of scope of the project. Please understand that we cannot maintain file formats of other products - especially if those products are not actively maintained any more.

dragetd

comment created time in 5 days

push eventmarchof/java-almanac

GitHub Action

commit sha b1843c1b498301caaccdaa4f9c57c03f33a208e5

Updating API diffs to 16-ea+21-1209-open

view details

push time in 5 days

pull request commentmarchof/java-almanac

Adding 16 for Zulu

I would propose to have a separate product for every release, see for example Oracle. This allows to provide release specific information like download link or platforms.

I think this was already done on foojay.io. Maybe you can get the content from there?

geertjanw

comment created time in 6 days

push eventmarchof/java-almanac

push time in 6 days

push eventmarchof/java-almanac

GitHub Action

commit sha 41a4b0504f1069d652e128d34b58cdfd4a29c74a

Updating API diffs to 16-ea+20-1092-open

view details

push time in 6 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 7b65d4035407727d20cdb42b0bbeaf95bbccc154

Test API automatic API diff update

view details

push time in 7 days

pull request commentmarchof/java-almanac

Adding 16 for Zulu

I wonder whether it would make sense to have a separate product per release. This would come with the following benefits:

  1. Version specific download URLs (e.g. https://www.azul.com/downloads/zulu-community/?version=java-16-ea)
  2. Version specific supported architectures

I think something similar was already done on foojay.io: https://foojay.io/almanac/jdk-16/

geertjanw

comment created time in 7 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha f16715fc4b22e3e2631f0f68f0d25b9518b3033c

Sort added/removed tags

view details

push time in 7 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 42b764f80928cd8b97c7b694d09f8b721572b425

List JDK versions used for API diffs

view details

push time in 7 days

issue closedjacoco/jacoco

jacoco.exec file Very large

jacoco version: 0.8.4

dump settings

use ant in build.xml

<target name="dump">
      <jacoco:dump address="${server_ip}" reset="false" destfile="${jacocoexecPath}" port="${server_port}" append="true"/>
</target>

file size -rw-r--r-- 1 root root 1.1G Oct 21 06:13 jacoco.exec

How can this be avoided

closed time in 7 days

liangshaoJY

issue commentjacoco/jacoco

jacoco.exec file Very large

This is indeed big. Hard to tell what the reason is without more context information. Maybe append="true" will increase the file size over time because it is never deleted?

Anyways, our mailing list is the place to ask questions.

liangshaoJY

comment created time in 7 days

pull request commentjacoco/jacoco

adds reconnectMs for tcpclient mode

Hi @nathanwray, beside my concerns raised at the mailing list this PR seems to completely miss testing:

  1. Exiting tests fail
  2. No new tests that verify the new options and intended behavior

Please understand that we cannot manually test JaCoCo and therefore have unit and integration tests for alle features.

nathanwray

comment created time in 8 days

PR opened jacoco/jacoco

Reviewers
Fix wording
+3 -3

0 comment

1 changed file

pr created time in 9 days

create barnchjacoco/jacoco

branch : fix-wording-in-flow

created branch time in 9 days

pull request commentjacoco/jacoco

Upgrade Groovy to 3.0.6 to support latest Java versions

@Godin Thanks for updating & cleaning-up!

marchof

comment created time in 9 days

push eventmarchof/io.javaalmanac.sandbox

Marc R. Hoffmann

commit sha 7ffaebea5b940acc8a0b43892ed4a608b5f7edef

Automate service update

view details

push time in 10 days

push eventmarchof/io.javaalmanac.sandbox

Marc R. Hoffmann

commit sha 436e3287513865e208d2901927bb1b054f8541af

Automate service update

view details

push time in 10 days

push eventmarchof/io.javaalmanac.sandbox

Marc R. Hoffmann

commit sha 3db04759f95eec399fc1ed0b7f81bed87e4df8bb

Automate service update

view details

push time in 10 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 877e62a1db596c762c91552544c5eea8c3492349

Update to 16-ea+20-1092

view details

push time in 10 days

push eventmarchof/jdk

David Holmes

commit sha 73c75ed83863619f1c29d24b394402b45227da21

8249650: Optimize JNIHandle::make_local thread variable usage Reviewed-by: kbarrett, dcubed, kvn, coleenp, sspitsyn

view details

Christian Hagedorn

commit sha 4f99e1fb11f7923ce64301f3f35299163b02a8f0

8248467: C2: compiler/intrinsics/object/TestClone fails with -XX:+VerifyGraphEdges Fix assert by taking MemBarNodes into account whose precedence edge can be NULL. Reviewed-by: kvn, thartmann

view details

Christian Hagedorn

commit sha 18cf3d8080d346e435a8e3d2525a2e5bef7b0f14

8247743: Segmentation fault in debug builds due to stack overflow in find_recur with deep graphs Replace the recursive algorithm of Node::find() by an iterative one to avoid a stack overflow crash with deep graphs. Reviewed-by: kvn, thartmann

view details

Roman Kennke

commit sha 45e17d8dd26d5558bb06197e64f7d62df7bc72f8

8249877: Shenandoah: Report number of dead weak oops during STW weak roots Reviewed-by: zgu

view details

Raffaello Giulietti

commit sha 4d43cf9fc67eabd1d370a311c19989eb33d4206a

8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end Reviewed-by: lancea, rriggs

view details

Coleen Phillimore

commit sha 2d8e74ddea7d2f8495ad713e991a832743aa9d40

8249768: Move static oops and NullPointerException oops from Universe into OopStorage Make NPE oops an objArrayOop. Reviewed-by: dholmes, eosterlund

view details

Roman Kennke

commit sha 9b42f4786c10824a34478493e51db252d527d16d

8249884: Shenandoah: Call report_num_dead() from ShParallelWeakRootsCleaningTask destructor Reviewed-by: zgu

view details

Bob Vandette

commit sha a764279daacac457350b99f8a1cbe97d3046643a

8249880: JVMCI calling register_nmethod without CodeCache lock Reviewed-by: eosterlund, kvn, never

view details

Alexander Matveev

commit sha f8a06bc497e05c1eb40d44cb697d68583ffe544a

8245311: [macos] misc package tests failed due to "execution error: Finder got an error: AppleEvent timed out." Reviewed-by: herrick, asemenyuk

view details

Mikael Vidstedt

commit sha 668acc758154e009241f1c7d0c677e0f7d01fef7

Added tag jdk-16+7 for changeset c3a4a7ea7c30

view details

Mikael Vidstedt

commit sha 9cf96bf398a4b699e07a7741c34aaf1b1944b7cb

Merge

view details

Yasumasa Suenaga

commit sha 401d3ea9bcf71ff2bff2f5e1e595935785972c32

8249875: GCC 10 warnings -Wtype-limits with JFR code Reviewed-by: mgronlun

view details

David Holmes

commit sha 1b1c1cd7b94e21bbcfcf2cd1b930c7ec02781413

8249940: Remove unnecessary includes of jni_util.h in native tests Reviewed-by: iignatyev, mchung

view details

Bernhard Urban-Forster

commit sha 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469

8248666: AArch64: Use THREAD_LOCAL instead of __thread __thread is gcc-ism, instead rely on compiler independent macro. Reviewed-by: dholmes

view details

Phil Race

commit sha b1ff2bd00a6a289be29158e0acd134151b468d41

8249821: Separate libharfbuzz from libfontmanager Reviewed-by: erikj

view details

Bob Vandette

commit sha 33016a8325c98eed8fb93b46c59f88a68d6cc019

8249880: JVMCI calling register_nmethod without CodeCache lock Reviewed-by: eosterlund, kvn, never

view details

Mikael Vidstedt

commit sha 54ad4f9a80d093b10fd59a83c1fcc51737d6c430

Added tag jdk-15+33 for changeset 6b65f4e7a975

view details

Alexander Scherbatiy

commit sha 993b1b0afacdc8d772fe8cbf86411c003b727cca

8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h Reviewed-by: darcy

view details

Doug Simon

commit sha 63d2421c3bb9286a133c90750aa81bfe4f58a432

8249888: failure to create a libgraal JavaVM should result in a VM crash Reviewed-by: never, kvn

view details

Aleksey Shipilev

commit sha dc80e638119e00b624ca004a8e937edfd33b8957

8249953: Shenandoah: gc/shenandoah/mxbeans tests should account for corner cases Reviewed-by: rkennke

view details

push time in 13 days

pull request commentjacoco/jacoco

improve clarity of violation message

Correct, element and counter overlaps: CLASS and METHOD can server as check scope as well as a coverage counter.

monperrus

comment created time in 13 days

pull request commentjacoco/jacoco

improve clarity of violation message

Messages are printed on a per limit base. It does not detail how the respective counter was calculated. There is no option to enable this.

Anyways I highly recommend to make the coverage report (not exec file) available to the developers. From my point of view the check goal alone is worthless.

monperrus

comment created time in 13 days

pull request commentjacoco/jacoco

improve clarity of violation message

Correct. The element property defined the scope of the rule. Your example reads:

  • For every class check the following limits:
    • the number of missed lines must not be more than 6
monperrus

comment created time in 13 days

pull request commentjacoco/jacoco

improve clarity of violation message

Documentation states:

Each limit applies to a certain counter (INSTRUCTION, LINE, BRANCH, COMPLEXITY, METHOD, CLASS)

That is what the counter property is for. If that can be expressed more clearly please propose a rewording of the documentation. Also documentation contains a example with LINEas coverage counter.

monperrus

comment created time in 13 days

delete branch jacoco/jacoco

delete branch : junit

delete time in 13 days

push eventjacoco/jacoco

Evgeny Mandrikov

commit sha cb72979b049b4b9e1c153736601c1651319f5d06

Upgrade JUnit to 4.13.1 (#1106)

view details

push time in 13 days

PR merged jacoco/jacoco

Upgrade JUnit to 4.13.1 component: build

This closes #1102 , closes #1103 , and closes #1104

+3 -3

0 comment

3 changed files

Godin

pr closed time in 13 days

PR closed jacoco/jacoco

Bump junit from 4.13 to 4.13.1 in /org.jacoco.build dependencies

Bumps junit from 4.13 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md">junit's changelog</a>.</em></p> <blockquote> <h2>Summary of changes in version 4.13.1</h2> <h1>Rules</h1> <h3>Security fix: <code>TemporaryFolder</code> now limits access to temporary folders on Java 1.7 or later</h3> <p>A local information disclosure vulnerability in <code>TemporaryFolder</code> has been fixed. See the published <a href="https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp">security advisory</a> for details.</p> <h1>Test Runners</h1> <h3>[Pull request <a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1669">#1669</a>:](<a href="https://github-redirect.dependabot.com/junit-team/junit/pull/1669">junit-team/junit#1669</a>) Make <code>FrameworkField</code> constructor public</h3> <p>Prior to this change, custom runners could make <code>FrameworkMethod</code> instances, but not <code>FrameworkField</code> instances. This small change allows for both now, because <code>FrameworkField</code>'s constructor has been promoted from package-private to public.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.13...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

PR closed jacoco/jacoco

Bump junit from 4.8.2 to 4.13.1 in /jacoco-maven-plugin.test/it/setup-parent dependencies

Bumps junit from 4.8.2 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.12</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 2</h2> <p>No release notes provided.</p> <h2>JUnit 4.12 Beta 1</h2> <p>No release notes provided.</p> <h2>JUnit 4.11</h2> <p>No release notes provided.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md">junit's changelog</a>.</em></p> <blockquote> <h2>Summary of changes in version 4.13.1</h2> <h1>Rules</h1> <h3>Security fix: <code>TemporaryFolder</code> now limits access to temporary folders on Java 1.7 or later</h3> <p>A local information disclosure vulnerability in <code>TemporaryFolder</code> has been fixed. See the published <a href="https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp">security advisory</a> for details.</p> <h1>Test Runners</h1> <h3>[Pull request <a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1669">#1669</a>:](<a href="https://github-redirect.dependabot.com/junit-team/junit/pull/1669">junit-team/junit#1669</a>) Make <code>FrameworkField</code> constructor public</h3> <p>Prior to this change, custom runners could make <code>FrameworkMethod</code> instances, but not <code>FrameworkField</code> instances. This small change allows for both now, because <code>FrameworkField</code>'s constructor has been promoted from package-private to public.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.8.2...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

PR closed jacoco/jacoco

Bump junit from 4.10 to 4.13.1 in /org.jacoco.examples/build dependencies

Bumps junit from 4.10 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.12</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 2</h2> <p>No release notes provided.</p> <h2>JUnit 4.12 Beta 1</h2> <p>No release notes provided.</p> <h2>JUnit 4.11</h2> <p>No release notes provided.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.10...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

PullRequestReviewEvent

pull request commentjacoco/jacoco

improve clarity of violation message

And here are the counter definitions: https://www.jacoco.org/jacoco/trunk/doc/counters.html

monperrus

comment created time in 13 days

pull request commentjacoco/jacoco

improve clarity of violation message

Hi, not sure whether the re-wording works for all combinations (like ratio). If you fix the unit tests you should see the different wordings that result from your change.

monperrus

comment created time in 13 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha d4fed6bb8d31038d27cccb34c41f802a93584941

Update to 16-ea+19-985

view details

push time in 14 days

push eventmarchof/PiCI

Marc R. Hoffmann

commit sha 175acb4aac3fdccafa5b6c53748245e6c86a6484

Install JDK 15 as bootstrap JDK (no Docker image yet for arm32)

view details

push time in 15 days

issue closedjacoco/jacoco

Jacoco executes all android project variant test tasks

  • JaCoCo version: 0.8.5
  • Gradle Version: 4.0.1 for android (Gradle 6.1.1)
  • Operating system: MacOS
  • Tool integration: Android, Gradle
  • Complete executable reproducer: See code snippet below
  • Steps: See problem section

Expected behaviour

JacocoReport task to execute specified dependent variant only.

Actual behaviour

JacocoReport task executes all variants

Problem

There are build variants like dev,prep,prod in our project. I have a distinct jacoco.gradle file which i apply to my module level gradle file.

apply from '../scripts/jacoco.gradle'

In jacoco.gradle file i have a task like this

project.afterEvaluate {
    tasks.create(name: "testReport", type: JacocoReport, dependsOn: testDevDebugUnitTest) {
        reports {
            xml.enabled = true
            html.enabled = true
        }

        def classDirectories = fileTree(dir: "$project.buildDir/tmp/kotlin-classes/devDebug", excludes: someExcludedFiles)
        def sourceDirectories = "$project.projectDir/src/main/java"
        def executionData = fileTree(dir: $projectDir.buildDir, includes: ['jacoco/testDevDebugUnitTest.exec', 'outputs/code-coverage/connected/*coverage.ec'])

        getClassDirectories().setFrom(files([classDirectories]))
        getSourceDirectories().setFrom(files([sourceDirectories]))
        getExecutionData().setFrom(files([executionData]))
    }
}

After i execute testReport task, gradle executes all flavors like testDevDebugUnitTest, testDevReleaseUnitTest, testProdDebugUnitTest, testProdReleaseUnitTest and it results with a plus one hour task execution. If i delete dependsOn part and execute again, then it executes all variant tasks again, no change. It used to work well but maybe after updating gradle plugin or jacoco, this task became a problematic one. What is the reason behind it, any ideas?

closed time in 20 days

volsahin

issue commentjacoco/jacoco

Jacoco executes all android project variant test tasks

As you can see here Grade is a 3rd party integration and not maintained by us. Please submit this to the Gradle project.

volsahin

comment created time in 20 days

push eventmarchof/io.javaalmanac.sandbox

Marc R. Hoffmann

commit sha f636d054e23b6a11155570f18dc9a32df337762a

Use AdoptOpenJDK image for Java 15

view details

push time in 21 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 524ec5942074f1b7c8f5f5858191474a89c54eb4

Categorize JEP 353 as internal

view details

Marc R. Hoffmann

commit sha 0e6e54034abdd253cc1050446786956acee033bb

Fix wrong reference for JEP 352

view details

Marc R. Hoffmann

commit sha bec54a61ca3ab9999b611e8d3a827d96770125f7

Categorize 373 as internal

view details

Marc R. Hoffmann

commit sha 5d5cfa43bf1fc0c99515799b8a62a4d300fed425

Add Java 16 features implemented so far

view details

push time in 22 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 07537e02ac5f920083df06427fd1a8ce0a797c5c

New category for JDK internal changes

view details

push time in 22 days

issue commentjacoco/jacoco

Using --xml option of jacococli report fails if the folder does not exist

The same hold true for the CSV output. Missing parent files are not created. Also the same happens with our Maven goal and Ant task.

wlad

comment created time in 22 days

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 01245fd4ae78cf6367539667a05bde4fba40af85

Update to 16-ea+18-901

view details

push time in 22 days

issue commentjacoco/jacoco

Support for Kotlin Convention packaging for report

Hi @JavierSegoviaCordoba, I implemented a new lookup heuristic in #953. Bit as @Godin noticed this will break other szenarios because lookup become fuzzy.

My personal preference is to drop this feature as it will cause more trouble (== undeterministic behaviour).

MarkRobbo

comment created time in 25 days

PullRequestReviewEvent

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 53d1ecbc23edb51ca0c72fd1724d8ccce66d829a

Add JEP 238 (Multi-Release JAR Files)

view details

push time in a month

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 422570133f578f19ff318d2936f82019aa23dea9

Consistent color for header and footer

view details

push time in a month

pull request commentjacoco/www.eclemma.org

Use HTTPS for EclEmma zip downloads

Thanks! ❤️

Godin

comment created time in a month

push eventjacoco/www.eclemma.org

Evgeny Mandrikov

commit sha e53082c72c4dec85f3794f7ece3c05b82356aa92

Use HTTPS for EclEmma zip downloads (#30)

view details

push time in a month

PullRequestReviewEvent

pull request commentjacoco/jacoco

Remove empty timestamp column in test report

I don't think this information is really relevant. For it is ok to just remove it.

marchof

comment created time in a month

PR opened jacoco/jacoco

Reviewers
Remove empty timestamp column in test report component: build

While reviewing #1091 I discovered that we show an always empty column in the JUnit test report.

+0 -3

0 comment

1 changed file

pr created time in a month

create barnchjacoco/jacoco

branch : junit-remove-empty-column

created branch time in a month

push eventjacoco/jacoco

dependabot[bot]

commit sha 50b6bd8f99776f25b11fe75743ba802842ecf48a

Use Ant 1.9.15 (#1091)

view details

push time in a month

PR merged jacoco/jacoco

Reviewers
Use Ant 1.9.15 dependencies

Bumps ant.version from 1.7.1 to 1.10.8. Updates ant from 1.7.1 to 1.10.8

Updates ant-junit from 1.7.1 to 1.10.8

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+21 -3

4 comments

3 changed files

dependabot[bot]

pr closed time in a month

PullRequestReviewEvent

push eventjacoco/www.eclemma.org

Evgeny Mandrikov

commit sha ed557dce2985190048623cc0194beb10e5d6d019

Use HTTPS for JaCoCo downloads (#29)

view details

push time in a month

PR merged jacoco/www.eclemma.org

Use HTTPS for JaCoCo downloads

Using Google Chrome Version 85.0.4183.121 (Official Build) while trying to download any released JaCoCo version from page https://www.jacoco.org/jacoco/index.html

I'm getting

jacoco-downloading

"Keep" allows to download file, "Learn more" points to https://support.google.com/chrome/answer/6261569 that states

Chrome may also block insecure downloads from secure sites.

i.e. non-HTTPS downloads started on HTTPS pages.

And according to https://blog.chromium.org/2020/02/protecting-users-from-insecure.html next Chrome Version 86 will entirely block such downloads.

+42 -42

3 comments

1 changed file

Godin

pr closed time in a month

pull request commentjacoco/www.eclemma.org

Use HTTPS for JaCoCo downloads

Perfectly ok to put move our artifacts to GitHub releases!

Beside chrome it might be considered a security flaw to have the update site without https. I can check with Eclipse foundation what options we have. If we take at least DNS hosting back we can easily create a AWS CloudFront distribution with https.

Godin

comment created time in a month

pull request commentjacoco/jacoco

Use Ant 1.9.15

@marchof are you talking with bot? 😆

This was more a note to myself about class file versions

so what do you think then about use of 1.9.15?

Perfect!

Well, seems that I succeeded 😉

Great! I didn't realize that there are now additional dependencies.

dependabot[bot]

comment created time in a month

Pull request review commentjacoco/jacoco

Use Ant 1.9.15

       <groupId>org.apache.ant</groupId>       <artifactId>ant-antunit</artifactId>     </dependency>+    <dependency>+      <groupId>org.apache.ant</groupId>+      <artifactId>ant-launcher</artifactId>+    </dependency>     <dependency>       <groupId>org.apache.ant</groupId>       <artifactId>ant-junit</artifactId>+      <version>${ant.version}</version>

Isn't this version already fixed in dependencyManagent of the parent POM?

dependabot[bot]

comment created time in a month

PullRequestReviewEvent

pull request commentjacoco/jacoco

Bump ant.version from 1.7.1 to 1.10.8 in /org.jacoco.build

@Godin I already spend some time on this to find a working combination of Ant 1.9.x and Ant-Unit -- without success.

dependabot[bot]

comment created time in a month

pull request commentjacoco/www.eclemma.org

Use HTTPS for JaCoCo downloads

We have the same problem with currently no https support:

  • here with the http://download.eclipselab.org/ URL and
  • on our update site update.eclemma.org
Godin

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Use ASM9 API

 <h2>Snapshot Build @qualified.bundle.version@ (@build.date@)</h2> <h3>New Features</h3> <ul>   <li>JaCoCo now officially supports Java 15-      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1094">#1094</a>).</li>+      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1094">#1094</a>

Sure. I was just waiting for the build.

Godin

comment created time in a month

push eventjacoco/jacoco

Marc R. Hoffmann

commit sha 306a984e7dff3a79f128211b9a593d150bd203cd

Add missing colon

view details

push time in a month

Pull request review commentjacoco/jacoco

Use ASM9 API

 <h2>Snapshot Build @qualified.bundle.version@ (@build.date@)</h2> <h3>New Features</h3> <ul>   <li>JaCoCo now officially supports Java 15-      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1094">#1094</a>).</li>+      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1094">#1094</a>

Colon missing here.

      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1094">#1094</a>,
Godin

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

Thanks!

marchof

comment created time in a month

PullRequestReviewEvent

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha 799cafe810e81454669552a95427c0b58aae6c01

Adjust logo size to actual usage

view details

push time in a month

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha c33333ea7518a3642da7829fbc5e37ff5964ba76

Replace large ico file with smaller png files to reduce traffic

view details

push time in a month

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

Can you please directly push the changes that you have in mind?

marchof

comment created time in a month

PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

Ok, this means no downgrading at all ATM?

marchof

comment created time in a month

PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

If I understand correctly my original proposal is:

  • Java 16 class file: leave as is
  • Java 17 class file: downgrade to 16

I simply did it this because I was lazy and

  1. We actually use ASM for Java 16
  2. We keep the downgrade infrastructure and tests in place
  3. (we're prepared for java 17...)
marchof

comment created time in a month

PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

             </Export-Package>             <Import-Package>               org.jacoco.*;version="${range;[===,==+);${Bundle-Version}}",-              org.objectweb.asm.*;version="${range;[===,=+);${asm.version}}"+              org.objectweb.asm.*;version="[9.0.0,10.0)"

Correct, this was not supposed to be part of this commit. Fixed.

marchof

comment created time in a month

PullRequestReviewEvent

push eventjacoco/jacoco

Marc R. Hoffmann

commit sha f0f9fef6838f8b35041e2317fb552948f5c715c3

Review: Revert temp change to version rule

view details

push time in a month

PullRequestReviewEvent

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

Not sure whether I understand this correctly: So you're suggesting that we don't do any downgrade at the moment? This means we would also remove the corresponding tests for now?

marchof

comment created time in a month

Pull request review commentjacoco/jacoco

Upgrade to ASM 9.0

 public static void push(final MethodVisitor mv, final int value) { 	 */ 	public static ClassReader classReaderFor(final byte[] b) { 		final int originalVersion = getMajorVersion(b);-		if (originalVersion == Opcodes.V15 + 1) {+		if (originalVersion == Opcodes.V16 + 1) {

If you prefer we can remove support for Java 17. But in any case I would not downgrade Java 16 files otherwise we're not actually using (and testing) ASM for Java 16 files.

marchof

comment created time in a month

PullRequestReviewEvent

push eventmarchof/java-almanac

Marc R. Hoffmann

commit sha dd3f7d0eae0e83814e8b7701ee680b012dd918cf

Update to 16-ea+17-805

view details

push time in a month

issue commentjacoco/jacoco

Filter out hibernate-generated methods

Thanks for the link! ❤️

Unfortunately exclude filter only work on class file level. There is no option to specify filters on method level.

fenuks

comment created time in a month

issue closedjacoco/jacoco

Filter out hibernate-generated methods

Scenario

  • JaCoCo version: 0.8,6
  • Operating system: Linux
  • Tool integration: Maven
  • Description of your use case: Hibernate Bytecode Enhancements generates various methods, all starting with common prefix $$_hibernate_. Jacoco should ignore these. Sadly, maven hibernate plugin has no option to mark these methods are generated. I've tried to filter them out with configuration options, but without success.

Current Behaviour

$$_hibernate_* methods are included in coverage reports.

Wanted Behaviour

$$_hibernate_* methods should not be included in coverage reports.

Possible Workarounds

Adding filter to jacoco plugin exclude configuration, but I was unable to do so. I've tried *#$$_hibernate, *#$$_hibernate*, *#$$_hibernate*(*). None seems to be working.

closed time in a month

fenuks

issue commentjacoco/jacoco

Filter out hibernate-generated methods

Please open a bug at hibernate to mark those methods as synthetic. The JaCoCo will filter them out.

JaCoCo is a general purpose coverage tool and cannot provide specific filters for all the libraries that exist

fenuks

comment created time in a month

issue commentjacoco/jacoco

javaagent excludes isn't working

IMHO, an elegant solution would be to mark the excluded classes as 'excluded', in the execution files. This will provide the reporting tools, the information they need.

This does not work: The JaCoCo agent only sees the classes which are actually loaded by the application. Even if add a new entry to the exec file to mark these classes as "excluded", classes which are not executed at all (=> never seen by the agent) will not get such a record in the exec file.

Really, the scope of the report is defined when you create the report, not when you configure the agent!

PadrePadrone

comment created time in a month

pull request commentjacoco/jacoco

Bump ant.version from 1.7.1 to 1.10.8 in /org.jacoco.build

The current LTS release of Ant which supports Java 5 is 1.9.x

dependabot[bot]

comment created time in a month

push eventjacoco/jacoco

Marc R. Hoffmann

commit sha 5819d7a67c24284213660f493e9c2cb8687493cc

Update change log

view details

push time in a month

more