Mani Maghsoudlou manidlou Los Angeles, CA full stack dev, collaborator at node-fs-extra &-> mind explorer.

issue commentjprichardson/node-fs-extra

Error: Cannot find module './fs.js'

Seems like your environment is browser. fs-extra doesn't work on browsers.

zjh12580

comment created time in 7 days

startedgreena13/react-hotkeys

started time in 8 days

push eventjprichardson/node-fs-extra

Mani Maghsoudlou

commit sha bb30e7f1758c0388a8e4cddb48752e83bcb85e8b

some reformatting

view details

push time in 21 days

pull request commentjprichardson/node-fs-extra

v8 release

fixed the commits!

manidlou

comment created time in 21 days

push eventjprichardson/node-fs-extra

Mani Maghsoudlou

commit sha a0bb74f4ce61e2563f72563818cc0fdc5545d452

Remove secure-random from dev-deps (#610)

view details

Mani Maghsoudlou

commit sha 7701ef2406b9ec5162a4d72ccca407fd8d873419

fix ensureDir() doc

view details

Mani Maghsoudlou

commit sha e85799d0955f5c65ce1bb0ed28042ece54f945b5

moveSync: refactor to use renameSync

view details

Mani Maghsoudlou

commit sha 5116248b6ac1314c98edba03b40417b7a5ecbdf1

copy*(): fix copying bind-mounted directories (#618) * copy*(): fix copying bind-mounted dirs * copy*(): fix case-insensitive-paths tests * copy*(): refactor to check paths more efficiently * destructure stats object after checking err

view details

Mani Maghsoudlou

commit sha f9e25195f302e00499490ef7b3a99d44b5962abb

move*(): check paths before moving

view details

Mani Maghsoudlou

commit sha 5ea17f2336fc762603477d84aabbba353c808428

move*(): add case-insensitive paths test

view details

Mani Maghsoudlou

commit sha 7513e2671c9a66240e1ec36caf47ae21feb87a66

remove unnecessary done callback from test

view details

Mani Maghsoudlou

commit sha 0c30f8c1e23a52af5be38d5a21bd788987b4b420

copy*(): add new option checkPathsBeforeCopying

view details

Mani Maghsoudlou

commit sha 033d7cf8ec1ab67ee083323bb8b6fd82e3db785c

update copy*() docs to include checkPathsBeforeCopying

view details

push time in 21 days

pull request commentjprichardson/node-fs-extra

v8 release

@RyanZim yeah i know! I will fix it for sure!

manidlou

comment created time in 21 days

pull request commentjprichardson/node-fs-extra

v8 release

I will rebase this!

manidlou

comment created time in 24 days

pull request commentjprichardson/node-fs-extra

v8 release

It is already rebased.

manidlou

comment created time in 24 days

push eventjprichardson/node-fs-extra

Mani Maghsoudlou

commit sha 30a1dea1b16eb8a6891c41a68c3ba1c54b423760

update copy*() docs to include checkPathsBeforeCopying

view details

push time in 24 days

PR opened jprichardson/node-fs-extra

v8 release

I think it is time to release v8. @jprichardson @RyanZim @JPeer264 please let me know if you think differently!

graceful-fs has not been updated yet to support bigint option. I opened an issue there, but there has been no responses yet! So we'll update once the upstream is updated.

So, I figured for now, the quickest way to fix #657 is by adding a new option { checkPathsBeforeCopying: true|false } to copy*() to let users decide if they want us to check paths or not. This is to make windows users happy again until we figure this out properly!

WARNING FOR USERS: since overwrite is true by default, be careful when using { checkPathsBeforeCopying: false } since you may end up losing your source file! see #565 as an example.

Also, removed standard-markdown as it started giving us more headaches than benefits!

+1797 -468

0 comment

48 changed files

pr created time in 24 days

push eventjprichardson/node-fs-extra

Alexander Lewitt

commit sha 287f234817871976f80e28ab50b339471e4c4223

Fix typo in docs (#628)

view details

Austin Gordon

commit sha ab254b1efdefe0b05f73e96fb3f1d17902e03942

Added docs/ and CHANGELOG.md to .npmignore (#642) (#643) These files are not necessary. Closes #642

view details

Pete Gonzalez

commit sha ddc1a2f9d42da77342d58f6fd86942a231f5f27f

Fix removeSync() to eliminate spurious ENOTEMPTY errors on Windows (#646) Fix removeSync() to measure its retry interval in milliseconds instead of CPU cycles

view details

Ryan Zimmerman

commit sha 639291769eff8c57d47147d8426bdd26ed9429b6

Temporarily disable standard-markdown

view details

Ryan Zimmerman

commit sha a32c85282185aa008759890cce059594e4348262

7.0.1

view details

Steve Moser

commit sha 8e0879110fbdd597c36602fe3b81ef03a4b3ec7a

Remove --save option as it isn't required anymore (#660)

view details

Mani Maghsoudlou

commit sha a6787566af8fb4b5d0d391a77d62b958b229cc8c

Remove secure-random from dev-deps (#610)

view details

Mani Maghsoudlou

commit sha f847d0b79a9f2189bbdd04a5822677e2a290f6aa

docs: refactor to be consistent with node docs (#611)

view details

Mani Maghsoudlou

commit sha db09339cbe5e4237a42068044244b506709cc5d5

moveSync: refactor to use renameSync

view details

Mani Maghsoudlou

commit sha e3838c25cf192e2933b22ffc47c12f03c0af8fd1

copy*(): fix copying bind-mounted directories (#618) * copy*(): fix copying bind-mounted dirs * copy*(): fix case-insensitive-paths tests * copy*(): refactor to check paths more efficiently * destructure stats object after checking err

view details

Mani Maghsoudlou

commit sha 69cd600343ae896cf21cc03ab9cb2b97d9f348c9

move*(): check paths before moving

view details

Mani Maghsoudlou

commit sha fab5c2722856d0b0a33c6a3b6dffdde781711ca7

move*(): add case-insensitive paths test

view details

Mani Maghsoudlou

commit sha 7d324ce49facf864c9f4e21ec26196dbbffe0015

remove unnecessary done callback from test

view details

Mani Maghsoudlou

commit sha 562902f9578a8150efce2abb70aa15227cbe96a6

Merge branch 'v8-dev' of github.com:jprichardson/node-fs-extra into v8-dev

view details

Mani Maghsoudlou

commit sha 3d24bbf53fffc236f3bfa1affca716e2d979f429

copy*(): add new option checkPathsBeforeCopying

view details

push time in 24 days

issue openedjprichardson/node-fs-extra

fs.stat() with option doesn't work on graceful-fs

I was working on fixing the inode bug and noticed that apparently graceful-fs hasn't been updated yet to support fs.stat() with additional options object. I tried with the latest version v4.1.15 also and still no success! I opened an issue there: https://github.com/isaacs/node-graceful-fs/issues/158.

created time in a month

issue openedisaacs/node-graceful-fs

fs.stat() with options doesn't work

fs.stat() and its relatives accept an additional options object fs.stat(path[, options], callback) since node v10.5.0.

https://nodejs.org/api/fs.html#fs_fs_stat_path_options_callback

seems like graceful-fs hasn't been updated yet! This will cause issues for projects that depend on graceful-fs. I am one of the maintainers of fs-extra and this prevents us from using fs.stat() with bigint option!

created time in a month

issue commentjprichardson/node-fs-extra

copy and copySync can fail with 'Source and destination must not be the same'

I will work on this and try to have a PR ASAP! However, I am not a fan of not checking the paths by default because that means we clearly ship the buggy code because of issues like #83, #565 and alike! But I am open to have the checkPaths as an option and let users decide how copy should be handled.

bvachon

comment created time in a month

startedyargs/yargs

started time in a month

issue commentjprichardson/node-fs-extra

copy and copySync can fail with 'Source and destination must not be the same'

@oliversalzburg, we mainly check paths to ensure copy doesn't end up with unintended results! We used to check just paths as strings but as you mentioned, obviously that is not enough to handle cases like symlinks. Basically, implementing cross-platform copy that handles all types of files, dirs, and links in one shot is not easy. There are a lot of edge cases when it comes to copy. We've been trying really hard to abstract all of these away to provide an easy to use api so that the end users don't need to deal with any of that! So in terms of solution, we can do couple of things here. @jprichardson @RyanZim @JPeer264 I'd like to know your thoughts on this too please!

  1. add a new option to copy, something like checkPaths: true|false, and let users decide if they want us to check the paths before copying or not.
  2. as @oliversalzburg mentioned, perform the copy and handles it appropriately if it fails. This might get a bit tricky because of inconsistencies in OS error codes.
  3. use bigint option if is available and fallback to old function if not available.
  4. refactor check paths to not use inodes.
bvachon

comment created time in 2 months

issue commentjprichardson/node-fs-extra

copy and copySync can fail with 'Source and destination must not be the same'

It is unfortunate that older versions of node are buggy in terms of inodes! I agree we need to fix this!

bvachon

comment created time in 2 months

startedbabel/babel

started time in 2 months

startedrequest/request

started time in 2 months

startedmanidlou/elemon

started time in 2 months

issue commentjprichardson/node-fs-extra

copy and copySync can fail with 'Source and destination must not be the same'

yeah but we should note that bigint option was added in v10.5.0 and we are still supporting node >=6.

bvachon

comment created time in 3 months

pull request commentjprichardson/node-fs-extra

make move-sync stronger

@carlsirce what kind of error is this EERROR?!

carlsirce

comment created time in 3 months

more