profile
viewpoint

jruesga/rview 47

A Gerrit client application for Android

maniac103/android_packages_apps_MotoFM 20

Motorola FM radio application

DvTonder/Sample_icon_set 18

Sample Weather Icons Set for Chronus and cLock Widgets

maniac103/android_device_motorola_jordan-common 11

Motorola Defy MB525 CM7 RCx (umts_jordan)

maniac103/android_packages_apps_MotoFMService 8

Motorola FM radio service

ingof/ems-php-webinterface 4

EMS Webinterface as frontend to the ems-collector by Danny Baumann.

maniac103/android_frameworks_base 4

Android base frameworks (cyanogenmod)

PullRequestReviewEvent

issue commentopenhab/openhab-android

Certain JPEG files are not shown/decoded

Chrome probably includes its own copy of Skia or a different JPEG decoding library. I don't see this being meaningfully feasible for us, though. Are gallery apps able to decode that image after downloading it?

tobiasisenberg

comment created time in 5 days

Pull request review commentopenhab/openhab-android

New Crowdin updates

     <string name="settings_add_server">Server hinzufügen</string>     <string name="settings_edit_server">Server bearbeiten</string>     <string name="server_with_name">Server %s</string>+    <string name="settings_server_confirm_deletion">Möchten Sie diesen Server wirklich entfernen?</string>+    <string name="settings_server_confirm_leave_title">Ungespeicherte Änderungen</string>+    <string name="settings_server_confirm_leave_message">Sie haben Änderungen vorgenommen. Möchten Sie sie speichern oder verwerfen?</string>     <string name="settings_server_primary_title">Primärer Server</string>+    <string name="settings_server_primary_summary_is_primary">Dieser Server ist der primäre Server.\nDerzeit wird nur der primäre Server von allen Funktionen dieser App unterstützt. Klicken Sie auf den Hilfe-Button für mehr Informationen.</string>+    <string name="settings_server_primary_summary_is_not_primary">\"%s\" ist der primäre Server. Klicke, um diesen Server zum primären zu machen.\nDerzeit wird nur der primäre Server von allen Funktionen dieser App unterstützt. Klicken Sie auf den Hilfe-Button für mehr Informationen.</string>

Ja, das klingt sinnvoll. 'Klicken' passt bei Touchscreens nicht wirklich. (Davon mal abgesehen siezen wir den Benutzer üblicherweise.)

openhab-bot

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

New Crowdin updates

     <string name="settings_add_server">Server hinzufügen</string>     <string name="settings_edit_server">Server bearbeiten</string>     <string name="server_with_name">Server %s</string>+    <string name="settings_server_confirm_deletion">Möchten Sie diesen Server wirklich entfernen?</string>+    <string name="settings_server_confirm_leave_title">Ungespeicherte Änderungen</string>+    <string name="settings_server_confirm_leave_message">Sie haben Änderungen vorgenommen. Möchten Sie sie speichern oder verwerfen?</string>     <string name="settings_server_primary_title">Primärer Server</string>+    <string name="settings_server_primary_summary_is_primary">Dieser Server ist der primäre Server.\nDerzeit wird nur der primäre Server von allen Funktionen dieser App unterstützt. Klicken Sie auf den Hilfe-Button für mehr Informationen.</string>+    <string name="settings_server_primary_summary_is_not_primary">\"%s\" ist der primäre Server. Klicke, um diesen Server zum primären zu machen.\nDerzeit wird nur der primäre Server von allen Funktionen dieser App unterstützt. Klicken Sie auf den Hilfe-Button für mehr Informationen.</string>

@mueller-ma 'Hier berühren, um diesen Server...'? Außerdem 'Hilfe-Schaltfläche' statt 'Hilfe-Button'?

openhab-bot

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

closes #2209 Trim username and password fields

 open class CustomInputTypePreference constructor(context: Context, attrs: Attrib         return PrefFragment.newInstance(key, title, inputType, autofillHints)     } -    class PrefFragment : EditTextPreferenceDialogFragmentCompat() {+    class PrefFragment : EditTextPreferenceDialogFragmentCompat(), TextWatcher {+        private lateinit var wrapper: TextInputLayout+        private lateinit var editor: EditText+         override fun onBindDialogView(view: View?) {-            val wrapper = view?.findViewById<TextInputLayout>(R.id.input_wrapper)-            val editor = view?.findViewById<EditText>(android.R.id.edit)-            arguments?.getInt(KEY_INPUT_TYPE)?.let { type ->-                editor?.inputType = type-            }-            arguments?.getCharSequence(KEY_TITLE)?.let { title ->-                wrapper?.hint = title-            }-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {-                val hints = arguments?.getStringArray(KEY_AUTOFILL_HINTS)-                if (hints == null) {-                    editor?.importantForAutofill = View.IMPORTANT_FOR_AUTOFILL_NO-                } else {-                    editor?.importantForAutofill = View.IMPORTANT_FOR_AUTOFILL_YES-                    editor?.setAutofillHints(*hints)+            super.onBindDialogView(view)+            if (view != null) {

Or keep initialization of editor and wrapper as they are (can keep them lateinit then) and just return if they're null.

Gosunet

comment created time in 12 days

PullRequestReviewEvent

issue commentslapperwan/gh4a

Add system dark mode for Android 9 or Lineage os based

The problem with that approach is that it'll also offer the 'system' theme to Android 9 users who do not have the system wide dark mode (essentially everybody on Android 9 who's not using LineageOS) ...

B0pol

comment created time in 14 days

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Add confirm leave dialog to tiles prefs

 class PreferencesActivity : AbstractBaseActivity() {             }         } +        override fun onLeaveAndSave() {+            Log.d(TAG, "Save tile $tileId")+            val context = preferenceManager.context+            val data: TileData? = if (enabledPref.isChecked) {+                val itemName = itemAndStatePref.item

Yes, I understand that part, but can't you create the TileData instance and check validity of its members afterwards?

mueller-ma

comment created time in 18 days

PullRequestReviewEvent

Pull request review commentpa-pa/AskSinPP

Clean up Message class instantiations

 class RemoteEventMsg : public Message {     if( lowbat == true ) {       flags |= 0x80; // low battery     }-    Message::init(0xb,msgcnt,0x40, BIDI|WKMEUP,(ch & 0x3f) | flags,counter);+    Message::init(11,msgcnt,AS_MESSAGE_REMOTE_EVENT,BIDI|WKMEUP,(ch & 0x3f) | flags,counter);

I do not exactly agree to that idea (adapting source code to conform to a certain debug output format rather than to a human line of thinking, particularly if calculations are involved), but I've updated the commit to match your request.

maniac103

comment created time in 20 days

PullRequestReviewEvent

push eventmaniac103/AskSinPP

Danny Baumann

commit sha 1e6eccc8486692cd2ada94b21d0e04c82017ea3e

Use symbolic constants for message types instead of magic numbers

view details

push time in 20 days

PullRequestReviewEvent

Pull request review commentpa-pa/AskSinPP

Clean up Message class instantiations

 class RemoteEventMsg : public Message {     if( lowbat == true ) {       flags |= 0x80; // low battery     }-    Message::init(0xb,msgcnt,0x40, BIDI|WKMEUP,(ch & 0x3f) | flags,counter);+    Message::init(11,msgcnt,AS_MESSAGE_REMOTE_EVENT,BIDI|WKMEUP,(ch & 0x3f) | flags,counter);

Just for my understanding: Why not? IMHO formatting it as decimal number makes it look like some magic flag value, and additionally it incurs some mental overhead when trying to follow packet layout because one needs to convert hex-to-dec on the fly in that case. This is especially true in cases where the length value is the result of some calculation (e.g. in the peer list message).

maniac103

comment created time in 20 days

PR opened pa-pa/AskSinPP

Clean up Message class instantiations
  • Use symbolic constants for message types instead of magic numbers
  • Use decimal numbers for length argument
+20 -20

0 comment

4 changed files

pr created time in 20 days

push eventmaniac103/AskSinPP

Danny Baumann

commit sha 90a3e96368039d92032d012085297bbe670060f0

Clean up Message class instantiations - Use symbolic constants for message types instead of magic numbers - Use decimal numbers for length argument

view details

push time in 20 days

create barnchmaniac103/AskSinPP

branch : msg-init-cleanup

created branch time in 20 days

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Add confirm leave dialog to tiles prefs

 class PreferencesActivity : AbstractBaseActivity() {             }         } +        override fun onLeaveAndSave() {+            Log.d(TAG, "Save tile $tileId")+            val context = preferenceManager.context+            val data: TileData? = if (enabledPref.isChecked) {+                val itemName = itemAndStatePref.item

Is there a reason for constructing the TileData instance slightly different than above here? I think it would be preferable to have a common method for constructing it.

mueller-ma

comment created time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Only show confirm leave dialog if the config was changed

 class PreferencesActivity : AbstractBaseActivity() {         ConfirmationDialogFragment.Callback,         ServerEditorConfirmLeaveDialogFragment.Callback {         private lateinit var config: ServerConfiguration+        private lateinit var initialConfig: ServerConfiguration         private var markAsPrimary = false          override val titleResId: Int get() = R.string.settings_edit_server          override fun onCreate(savedInstanceState: Bundle?) {             config = requireArguments().getParcelable("config")!!+            initialConfig = config

Ah, right, due to ServerConfiguration being immutable. Nevermind then :-)

mueller-ma

comment created time in 20 days

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Only show confirm leave dialog if the config was changed

 class PreferencesActivity : AbstractBaseActivity() {         ConfirmationDialogFragment.Callback,         ServerEditorConfirmLeaveDialogFragment.Callback {         private lateinit var config: ServerConfiguration+        private lateinit var initialConfig: ServerConfiguration         private var markAsPrimary = false          override val titleResId: Int get() = R.string.settings_edit_server          override fun onCreate(savedInstanceState: Bundle?) {             config = requireArguments().getParcelable("config")!!+            initialConfig = config

Dies this actually work? I'd expect only the reference to be copied and thus later modifications to config also being applied to initialConfig.

mueller-ma

comment created time in 23 days

PullRequestReviewEvent

issue commentopenhab/openhab-android

Android app creates new SSE subsciptions on every page change

When the client closes the connection this should be detected by the server (#2215 (comment)) and it will remove the subscription.

But - if I understand that comment correctly - it will be discarded only after 5 minutes, right? Which would mean there's no way for the client to relase subscriptions immediately? If that's the case, the subscription pooling is the only solution I can see.

kaikreuzer

comment created time in a month

issue commentopenhab/openhab-android

Android app creates new SSE subsciptions on every page change

But this is not what I see in the logs - it seems that a new subscription is invariably created on every single page change, which definitely is not good

Yes, that's the case currently. I described the state after the change, in which case there still would be one open subscription per page in the back stack.

(and I do not see any subscriptions being release either).

How can a client release subscriptions? I asked earlier already because I don't see a way of doing that.

kaikreuzer

comment created time in a month

issue commentopenhab/openhab-android

Android app creates new SSE subsciptions on every page change

How many pages does it keep open in the background?

Depends on navigation depth. There's no limit coded into the app itself, so the limit is the nesting depth in the respective sitemap.

kaikreuzer

comment created time in a month

issue commentopenhab/openhab-android

Android app creates new SSE subsciptions on every page change

OK, I checked the code a bit. To recap, the app currently for every new page does

  • create a new subscription
  • creates an event stream using that subscription and page ID of the new page

What I think might work from my understanding of the SSE API is

  • have a pool of previously used subscriptions
  • when opening a new page, try to reuse a pooled subscription
  • if event stream creation yields a 404 (subscription discarded already) or other error, remove it from pool
  • if no pooled subscription exists, create a new one

Does that make sense to everyone? I think that approach would limit the number of subscriptions to 'number of open pages + pool size'.

kaikreuzer

comment created time in a month

issue commentslapperwan/gh4a

Error during building, lint found fatal errors

Can you pastebin the full build output? It obviously works for me since I can build a release build, so something must be special in either your or my environment.

dhammel

comment created time in a month

issue commentopenhab/openhab-android

Android app creates new SSE subsciptions on every page change

I wouldn't consider keeping more than one open SSE connection a bug. The app is currently designed to keep pages in the back stack updated, so it opens one subscription for each page. Since it seems unlikely that the back stacks grows to more than 50 pages, I think the actual problem is the subscriptions not being released properly when navigating back. Is there anything we need to do to release a subscription besides closing the connection?

kaikreuzer

comment created time in a month

issue commentopenhab/openhab-android

Trim username and password fields

A space character is not allowed in passwords?

mueller-ma

comment created time in a month

pull request commentLogitech/slimserver

Support playback restore after player power loss

Am I doing something wrong, is there some player configuration missing? Both are set to "Pause at power off / Resume at power on".

That should be the only required configuration here. I only tested this on a SB Receiver device (which should be close enough to your SB2), so I'm not sure how the Touch will react to this. I'll update to 7.9.3 and give this a try with local music files when I find some time.

maniac103

comment created time in a month

created tagmaniac103/GitHubSdk

tag0.7.0.1

created time in a month

create barnchmaniac103/GitHubSdk

branch : gh4a-rebase

created branch time in a month

push eventslapperwan/gh4a

Danny Baumann

commit sha 83a66333d145af6578c736afa7e83206d75aefd1

Update to API 29 and remove most deprecated code usage.

view details

Danny Baumann

commit sha 09567e4f2bf7e0ceb0ea4481e0d4f7481a1ac269

Fix wrong status for draft PRs.

view details

Danny Baumann

commit sha 3671dd579514bd1f12ddf140b07e63865c7cd798

Fix some lint issues.

view details

Danny Baumann

commit sha 70fe364b78ab32160e0aa5475efa2a81b9c23d20

Update used libraries

view details

push time in a month

PullRequestReviewEvent

pull request commentslapperwan/gh4a

Hide explore section if logged in

I don't see the relationship between the explore section and the 'user is logged in status'. Personally, I use both trending list and (occasionally) the blog list despite being logged in. The only thing that probably isn't too useful for logged in users is the global GH timeline ... but at the same time, I wonder why there should be a problem in keeping it. The only item that comes after these items is 'Settings', and that surely isn't used that often?

asdoi

comment created time in a month

pull request commentslapperwan/gh4a

Add setting for image loading

Do you have an example for overly large README images that would justify this? GIFs can be several megabytes in size, but is that also the case for static images?

asdoi

comment created time in a month

push eventslapperwan/gh4a

asdoi

commit sha f3c872b70eb21550d619eef8c7579fd3ec2e0d14

Add source code button in about dialog

view details

asdoi

commit sha 2dae7d73303136bc918e6f3cd4e51ab3fe8af97e

align settings on the left

view details

push time in a month

PR merged slapperwan/gh4a

Add source code link in about & move settings to the left

First of all thank you for your great app. As the title says, this adds a link to the source code in the about dialog and removes the space between the left side and the settings. gh4a

Personally, I like a direct link to the source code more, than first being redirected to the issues and then going back to the source code.

+26 -1

0 comment

4 changed files

asdoi

pr closed time in a month

created tagslapperwan/gh4a

tag4.6.4

Github client for Android

created time in a month

release slapperwan/gh4a

4.6.4

released time in a month

push eventslapperwan/gh4a

Danny Baumann

commit sha c18cc027231fe443ca10626f3b00979399def602

Fix crash when viewing some PRs. In particular, PRs which had review requested from teams were crashing. Fixes #1033

view details

Danny Baumann

commit sha 7126cfa3971b3f3bf7e702496320a8b01073fb39

Include an (un)follow action in the follower list fragment. Closes #1026

view details

Danny Baumann

commit sha c57a68fa957262dbb0846234e1861cb59911b312

Bump version

view details

push time in a month

issue closedslapperwan/gh4a

[Feature Request] Follow Button

Follow Button On

  1. User
  2. Releases Feed
  3. Issue Feed

closed time in a month

zpcol

issue closedslapperwan/gh4a

Crash on open pull requests

Try to open this pull request. https://github.com/microsoft/hcsshim/pull/871 There are other too but mostly pull requests in Microsoft repositories Android 10 Samsung note 10 App version 4.6.3

closed time in a month

quangkieu

created tagmaniac103/GitHubSdk

tag0.5.1.20

created time in a month

push eventmaniac103/GitHubSdk

Danny Baumann

commit sha 3e07ac5aad1eff716463e265bf380a714839928f

Add requested_team field for IssueEvent.

view details

Danny Baumann

commit sha 3fc7e5d78d5c9139c2fa50b2b2396dc015c3d5bc

Disable bintray integration for our purposes. jitpack doesn't like BINTRAY_USER not being defined.

view details

push time in a month

Pull request review commentopenhab/openhab-android

Add support for configuring multiple OH targets

 class NotificationHelper constructor(private val context: Context) {         var iconBitmap: Bitmap? = null          if (message.icon != null) {-            val connection = ConnectionFactory.cloudConnectionOrNull-            if (connection != null && context.determineDataUsagePolicy().canDoLargeTransfers) {+            val connection = ConnectionFactory.primaryCloudConnection?.connection+            if (connection != null && !context.determineDataUsagePolicy().canDoLargeTransfers) {

@mueller-ma Was this change intentional? It looks wrong on first impression.

maniac103

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

push eventmaniac103/openhab.android

Danny Baumann

commit sha 8e4e08294e3b9fcae726565e863d604ac24a52e7

Grammar fixes in docs. Signed-off-by: Danny Baumann <dannybaumann@web.de>

view details

Danny Baumann

commit sha a8ba056ff5ab7809a4645559cda8634541dc0190

Cleanup Signed-off-by: Danny Baumann <dannybaumann@web.de>

view details

Danny Baumann

commit sha c9e1ff51de7fccadaf86ac62c9e7ce5069028ac7

Pop back stack also if last fragment isn't an AbstractSettingsFragment Signed-off-by: Danny Baumann <dannybaumann@web.de>

view details

push time in a month

pull request commentopenhab/openhab-android

Use Item tags for tile icon suggestion

https://github.com/maniac103/openhab.android/commit/0b8e57171b414897451e2615e1d831f75a37aa28 is the fix for the issue - its commit message has the explanation for the failure ;-)

mueller-ma

comment created time in a month

create barnchmaniac103/openhab.android

branch : tags

created branch time in a month

pull request commentopenhab/openhab-android

Add support for configuring multiple OH targets

I'll give it a last double check tomorrow.

maniac103

comment created time in a month

pull request commentopenhab/openhab-android

Android 11 Support

IMO we could use them instead, suppress the warnings and open an issue to keep track of that.

Yeah, that sounds like a good plan.

mueller-ma

comment created time in a month

pull request commentopenhab/openhab-android

Add a toggle for image item scaling behavior.

@NoWhere2Go19 It's at 20% rollout coverage. For me, 2.15.0 is available already.

maniac103

comment created time in a month

IssuesEvent

issue closedslapperwan/gh4a

Theme - custom color selection

Add the option to select the theme, based on the colors you select, currently green, i would like to change to blue, and the gray menu part to dark blue for example...

Theme - Custom - Accent color...

I would like to set my theme to look like FastHub libre's premium theme.

closed time in a month

aha999

issue commentslapperwan/gh4a

Theme - custom color selection

Dupe of #936

aha999

comment created time in a month

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Fix fragement manager IllegalStateException

 abstract class ContentController protected constructor(private val activity: Mai         activity.showSnackbar(R.string.error_sse_failed, tag = MainActivity.TAG_SNACKBAR_SSE_ERROR)     } -    internal abstract fun executeStateUpdate(reason: FragmentUpdateReason, allowStateLoss: Boolean)+    internal abstract fun executeStateUpdate(reason: FragmentUpdateReason)      private fun updateFragmentState(reason: FragmentUpdateReason) {         if (fm.isDestroyed) {             return         }         // Allow state loss if activity is still started, as we'll get         // another onSaveInstanceState() callback on activity stop

Can/should also nuke that comment now.

mueller-ma

comment created time in a month

PullRequestReviewEvent

issue commentopenhab/openhab-android

Next Release

I'd like to keep it only for a short time in beta, because Android 11 is already released.

It'll be some time before targeting API 30 will become mandatory, though.

digitaldan

comment created time in a month

PR opened pa-pa/AskSinPP

Fix debug lines not starting at line start.

Terminal programs commonly expect newlines to have both CR and LF, so comply to that. Without doing that, those terminal programs (e.g. ckermit) start the new line at a column that matches the line length of the previous line - IOW, they're following the meaning of 'line feed' to the letter. This also matches what the Arduino classes are doing.

+6 -6

0 comment

1 changed file

pr created time in a month

create barnchmaniac103/AskSinPP

branch : debug-crlf-fix

created branch time in a month

PR opened pa-pa/AskSinPP

Improve tick conversion macros.

Allow them to be called with more than simple variables: previous version only accepted e.g. seconds2ticks(x), while the new version also allows seconds2ticks(x - y).

+8 -8

0 comment

1 changed file

pr created time in a month

create barnchmaniac103/AskSinPP

branch : tick-convert-fix

created branch time in a month

pull request commentopenhab/openhab-android

Android 11 Support

I got two cleanup commits on top of this: https://github.com/maniac103/openhab.android/commits/android11

Other than that, LGTM after fixing the conflicts.

mueller-ma

comment created time in a month

create barnchmaniac103/openhab.android

branch : android11

created branch time in a month

pull request commentopenhab/openhab-android

Add a toggle for image item scaling behavior.

Sure you got 2.4.10 and not just 2.4.9? It's there for me: Screenshot_20200910-110303_openHAB_Beta

maniac103

comment created time in a month

pull request commentopenhab/openhab-android

Fix 'invalid notification' crashes

Here's the place throwing the exception: https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-10.0.0_r46/services/core/java/com/android/server/am/ActiveServices.java#836 called from here: https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-10.0.0_r46/services/core/java/com/android/server/am/ServiceRecord.java#900

Unfortunately from there it becomes fuzzy, at least as long as we don't have the logcat output. Obvious causes are no channel (line 878) or no small icon (line 888), both of which don't seem the case here. Besides that, it's only NotificationManagerService.enqueueNotificationInternal (via here: https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-10.0.0_r46/services/core/java/com/android/server/notification/NotificationManagerService.java#4622) that could throw then, and it's less obvious there. I totally can't see contentText being required to be non-null though.

mueller-ma

comment created time in 2 months

Pull request review commentopenhab/openhab-android

Add a toggle for image item scaling behavior.

     <string name="settings_openhab_icon_format_value_svg" translatable="false">SVG</string>     <string name="settings_openhab_icon_format_png">Bitmap</string>     <string name="settings_openhab_icon_format_svg">Vector</string>+    <string name="settings_image_widget_scaling">Scale images to fit screen</string>+    <string name="settings_image_widget_scaling_summary_off">Only scale images down \'Image\' widgets when they\'re larger than the screen, but don\'t scale them up to match the screen size</string>

Reworded it slightly differently, but keeping the gist of the suggestion.

maniac103

comment created time in 2 months

PullRequestReviewEvent

push eventmaniac103/openhab.android

dependabot-preview[bot]

commit sha 836b668c9e2cfec0ef057e759483d2505212e69e

Bump mockito-core from 3.5.7 to 3.5.9 (#2188) Bumps [mockito-core](https://github.com/mockito/mockito) from 3.5.7 to 3.5.9. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](https://github.com/mockito/mockito/compare/v3.5.7...v3.5.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

mueller-ma

commit sha 8d3156e99e92746f373d97887997d5cca4031e63

Show image loading indicator if present (#2181) Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

mueller-ma

commit sha 81250efc5b1925977f762bfdf5976175d582b8c9

Add long press behavior for color widgets (#2164) Fixes #2161 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

mueller-ma

commit sha 907a0db35692356b328d4d964c9b06931b72ea2f

Upgrade to the Firebase Crashlytics SDK (#2182) Fixes #2179 Disable crash reporting for builds older than 6 months and debug builds. Fixes #564 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha eebe76ff1feba276ba8ccd7a8322e6691870340c

Bump firebase-crashlytics-gradle from 2.2.0 to 2.2.1 (#2191) Bumps firebase-crashlytics-gradle from 2.2.0 to 2.2.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

openhab-bot

commit sha f13f020b766512dd8d195d8840564ff7a5f8425d

Bump version to 2.14.7-beta and update fastlane metadata

view details

mueller-ma

commit sha 3db2826d001c5701044155ea19e5b4f6f1e05e1e

Fix divider not showing when there're invible widgets (#2157) https://community.openhab.org/t/not-always-lines-under-items-on-sitemap-openhab-app/103961 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 6285f49ad418128bf237aee5189c6b97efd885a6

Bump mockito-core from 3.5.9 to 3.5.10 (#2193) Bumps [mockito-core](https://github.com/mockito/mockito) from 3.5.9 to 3.5.10. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](https://github.com/mockito/mockito/compare/v3.5.9...v3.5.10) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

openhab-bot

commit sha fad0e3f920d34943a97d3503122f1d97fc8e3bcc

Bump version to 2.14.8-beta and update fastlane metadata

view details

mueller-ma

commit sha 727d5f826b7ae92fe7e113cbc3c8b638468edd7f

Show only successful work infos in item update pref summary (#2197) Before it showed "Last update was null..." if the last update was unsuccessful. Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

mueller-ma

commit sha 28307ddea4f08c6caa0ccd69f2e91f037597020f

Hide all connection related snackbars on connection change (#2196) Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

mueller-ma

commit sha 51623388c96aa106ff374a61c50392628f468c21

Fix crash "FragmentManager has been destroyed" (#2195) ```` Fatal Exception: java.lang.IllegalStateException: FragmentManager has been destroyed at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java:1737) at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.java:321) at androidx.fragment.app.BackStackRecord.commit(BackStackRecord.java:286) at org.openhab.habdroid.ui.activity.ContentControllerOnePane.executeStateUpdate$mobile_fullStableRelease(ContentControllerOnePane.kt:50) at org.openhab.habdroid.ui.activity.ContentController.updateFragmentState(ContentController.kt:459) at org.openhab.habdroid.ui.activity.ContentController.clearServerCommunicationFailure(ContentController.kt:314) at org.openhab.habdroid.ui.MainActivity.retryServerPropertyQuery(MainActivity.kt:525) at org.openhab.habdroid.ui.MainActivity$handlePropertyFetchFailure$2.invoke(MainActivity.kt:1039) at org.openhab.habdroid.ui.MainActivity$handlePropertyFetchFailure$2.invoke(MainActivity.kt:116) at org.openhab.habdroid.ui.MainActivity$scheduleRetry$1.invokeSuspend(MainActivity.kt:479) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:175) at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:111) at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:308) at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:318) at kotlinx.coroutines.CancellableContinuationImpl.resumeUndispatched(CancellableContinuationImpl.kt:400) at kotlinx.coroutines.android.HandlerContext$scheduleResumeAfterDelay$$inlined$Runnable$1.run(Runnable.kt:19) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6718) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) ```` Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

view details

openhab-bot

commit sha b66e043cec6942be4442fc086b8542f281cedb7b

Bump version to 2.14.9-beta and update fastlane metadata

view details

Danny Baumann

commit sha 45dfc83130e2da5c8aeddc7db1ffbe0f6ac7cf90

Add a toggle for image item scaling behavior. Signed-off-by: Danny Baumann <dannybaumann@web.de>

view details

push time in 2 months

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Tiles: Display status in subtitle

 import android.service.quicksettings.TileService import android.util.Log import androidx.annotation.DrawableRes import androidx.annotation.RequiresApi+import androidx.annotation.StringRes import androidx.annotation.VisibleForTesting+import androidx.lifecycle.Lifecycle+import androidx.lifecycle.LifecycleOwner+import androidx.lifecycle.LifecycleRegistry+import androidx.work.WorkInfo+import androidx.work.WorkManager import kotlinx.android.parcel.Parcelize+import kotlinx.coroutines.Dispatchers+import kotlinx.coroutines.GlobalScope+import kotlinx.coroutines.Job+import kotlinx.coroutines.delay+import kotlinx.coroutines.launch import org.json.JSONException import org.json.JSONObject import org.openhab.habdroid.R import org.openhab.habdroid.background.BackgroundTasksManager+import org.openhab.habdroid.background.ItemUpdateWorker import org.openhab.habdroid.background.tiles.AbstractTileService.Companion.getPrefKeyForId import org.openhab.habdroid.util.getPrefs import org.openhab.habdroid.util.showToast  @RequiresApi(Build.VERSION_CODES.N) abstract class AbstractTileService : TileService() {-    @VisibleForTesting abstract val ID: Int+    @Suppress("PropertyName") @VisibleForTesting abstract val ID: Int+    var subtitleUpdateJob: Job? = null      override fun onStartListening() {         Log.d(TAG, "onStartListening()")         qsTile?.let { updateTile(it) }+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {+            val workManager = WorkManager.getInstance(applicationContext)+            val lifeCycleOwner = object : LifecycleOwner {+                private val lifecycleRegistry = LifecycleRegistry(this).apply {+                    handleLifecycleEvent(Lifecycle.Event.ON_START)

To me this sounds like the OS will kill the tile service anyway.

Yes, and the point I was trying to make was to emit a destroy event when that happens (and onDestroy is called).

However I could stop lifecycleRegistry when the "Success" message is cleared and start it again in onClick().

:+1:

mueller-ma

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentopenhab/openhab-android

Tiles: Display status in subtitle

 import android.service.quicksettings.TileService import android.util.Log import androidx.annotation.DrawableRes import androidx.annotation.RequiresApi+import androidx.annotation.StringRes import androidx.annotation.VisibleForTesting+import androidx.lifecycle.Lifecycle+import androidx.lifecycle.LifecycleOwner+import androidx.lifecycle.LifecycleRegistry+import androidx.work.WorkInfo+import androidx.work.WorkManager import kotlinx.android.parcel.Parcelize+import kotlinx.coroutines.Dispatchers+import kotlinx.coroutines.GlobalScope+import kotlinx.coroutines.Job+import kotlinx.coroutines.delay+import kotlinx.coroutines.launch import org.json.JSONException import org.json.JSONObject import org.openhab.habdroid.R import org.openhab.habdroid.background.BackgroundTasksManager+import org.openhab.habdroid.background.ItemUpdateWorker import org.openhab.habdroid.background.tiles.AbstractTileService.Companion.getPrefKeyForId import org.openhab.habdroid.util.getPrefs import org.openhab.habdroid.util.showToast  @RequiresApi(Build.VERSION_CODES.N) abstract class AbstractTileService : TileService() {-    @VisibleForTesting abstract val ID: Int+    @Suppress("PropertyName") @VisibleForTesting abstract val ID: Int+    var subtitleUpdateJob: Job? = null      override fun onStartListening() {         Log.d(TAG, "onStartListening()")         qsTile?.let { updateTile(it) }+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {+            val workManager = WorkManager.getInstance(applicationContext)+            val lifeCycleOwner = object : LifecycleOwner {+                private val lifecycleRegistry = LifecycleRegistry(this).apply {+                    handleLifecycleEvent(Lifecycle.Event.ON_START)

I don't think this is sufficient, since you never emit a destroy event. See here for a reference to a full implementation: https://stackoverflow.com/a/50279360

mueller-ma

comment created time in 2 months

PullRequestReviewEvent

pull request commentopenhab/openhab-android

Fix crash "FragmentManager has been destroyed"

I'd rather do this in updateFragmentState in the base class.

mueller-ma

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentopenhab/openhab-android

Fix 'invalid notification' crashes

What Android version do you see this on? The crash complains about channel, not content text... I'll look into the AOSP sources.

mueller-ma

comment created time in 2 months

issue commentslapperwan/gh4a

[Question] API rate limit exceeded

Did you found out why it only happened to me ?

I have no idea why you had that many workers running, but when adding debug logging I found that I also had 4 or 5 running simultaneously.

When will the fix be released in Google Play ?

In the next 1 or 2 weeks, I want to test drive the new code for check run support for a few days.

KaKi87

comment created time in 2 months

push eventslapperwan/gh4a

Danny Baumann

commit sha c7923718603d918e07846f2eb9e0f466b66f966e

Fix notifications worker being scheduled several times in parallel. On app start, we used to schedule periodic work without canceling the previously scheduled work. Avoid that by using enqueueUniquePeriodicWork which makes sure only one worker runs at a given time. Also add some log statements to the notifications worker to make it more easy to understand what's going on. Fixes #1013

view details

Danny Baumann

commit sha e4964c27157f5bee4214ec0a94ccb3ab2ab47d4d

Fix notification list sometimes not updating correctly. When at onStart time we notice we need to reload the notifications due to the notifications worker having noticed new notifications since our last fetch, make sure we force the reload so we don't get the cached last loader result as return value.

view details

Danny Baumann

commit sha 1dda4ed7c349cb36fad7bea507d697081a22ab6a

Only show one instance per check run

view details

Danny Baumann

commit sha d0d0efb36b78e5fddf2df532550a3b3329bafa14

Improve pending/running check run output.

view details

push time in 2 months

issue closedslapperwan/gh4a

[Question] API rate limit exceeded

Hello,

API rate limit exceeded for user ID 21284089 (403)

I'm getting a lot of these lately, while I didn't used to in my first months using OctoDroid.

What changed ?

Thanks

closed time in 2 months

KaKi87

pull request commentopenhab/openhab-android

Use Item tags for tile icon suggestion

Android Studio suggested to override equals() and hashCode(), so I added the auto generated functions.

I think AS is wrong there, as - AFAIK - data classes already implement those.

mueller-ma

comment created time in 2 months

issue commentslapperwan/gh4a

Not all issue comments shown

Might be related to the pictures attached to the missing comments?

I somewhat doubt it ... the pictures are present for me as well ;-)

I am connected using a key, could it make any difference?

What do you mean here?

Lineflyer

comment created time in 2 months

push eventslapperwan/gh4a

Danny Baumann

commit sha 7574c3cd87188698b81776bcebcc745b479fa858

Improve check run status output. Show check runtime (like web UI is doing it).

view details

Danny Baumann

commit sha b711b226fd083ddde469adfaf053fe85de22e2ea

Fix accept header format. GitHub's API can not deal with multiple preview accept header entries at once. Regression of commit c51b1e0123db5cf01d221242b04b5ef283d23f5d

view details

push time in 2 months

issue commentslapperwan/gh4a

Not all issue comments shown

I wonder whether this was a temporary glitch in Github's API ... at least I am not able to reproduce the issue here. Can you still repro it?

Lineflyer

comment created time in 2 months

push eventslapperwan/gh4a

Danny Baumann

commit sha c51b1e0123db5cf01d221242b04b5ef283d23f5d

Show check run results alongside statuses in PR fragment. Closes #1011

view details

push time in 2 months

issue closedslapperwan/gh4a

[BUG] Travis CI checks don't show up on pull requests

Steps to reproduce:

  1. Open a repository with TraviCI hXtreme/tasks3.
  2. Open any pr from the repository.

Expected outcome:

All the checks should show up in app along with their status.

Actual outcome:

Travis checks don't show up in app.


(dup of: #962)

App version: 4.6.2


Attachments

Screenshot_20200804-132623

Screenshot_20200804-132653

closed time in 2 months

hXtreme

created tagmaniac103/GitHubSdk

tag0.5.1.19

created time in 2 months

push eventmaniac103/GitHubSdk

Danny Baumann

commit sha 6ce3078ec3a0b52e47b0394e865d0ae8e94d4091

Add support for check runs API.

view details

Danny Baumann

commit sha 4385a59495aea35024e6ecb0fcdd4c56703e1be4

Disable bintray integration for our purposes. jitpack doesn't like BINTRAY_USER not being defined.

view details

push time in 2 months

more