profile
viewpoint

lrs-lang/lib 204

An experimental standard library

mahkoh/comm 65

Communication primitives

mahkoh/dns2 5

Rudimentary DNS library

lrs-lang/build 4

The lrs build system

lrs-lang/driver 2

The lrs compiler driver

magnets-moe/database-dump 1

Dump of the magnets.moe database

magnets-moe/Magnets.moe 1

The source code of Magnets.moe

mahkoh/align 1

Align text

mahkoh/areasel 1

select area with mouse

mahkoh/cmus 1

Small, fast and powerful console music player for Unix-like operating systems.

push eventmagnets-moe/database-dump

magnets-moe-dumper

commit sha 92d51ea83387e43a4e9c9e090194feb7f0ee4572

Create new dump

view details

push time in 16 hours

pull request commentcmus/cmus

add amazon.theme

You need to push something to the branch to trigger it for the first time.

blackdead263

comment created time in a day

startedmahkoh/uapi

started time in a day

pull request commentcmus/cmus

add amazon.theme

Hm, looks like Github Actions got stuck here :-(

blackdead263

comment created time in a day

push eventcmus/cmus

Niko E

commit sha 2a26b9b9aca750d22fa89c4775f1f1ac2d3752a7

Fixes truncation warnings by replacing %s with %.s (#1040) Co-authored-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>

view details

push time in a day

PR merged cmus/cmus

Fixes truncation warnings by replacing %s with %.s

Fixes gcc warnings about format trunctations

+3 -4

3 comments

1 changed file

nefthy

pr closed time in a day

push eventcmus/cmus

Patrick Gaskin

commit sha bc5a362e89d4960bdb067ed9be1d6f64dd4aae84

Remove unused functions in op/sndio.c (#1041)

view details

push time in a day

PR merged cmus/cmus

Remove unused functions in op/sndio.c
+0 -10

2 comments

1 changed file

pgaskin

pr closed time in a day

GollumEvent

push eventmagnets-moe/database-dump

magnets-moe-dumper

commit sha c6cca1c6d5ede764d4f9cea60a17d4a7942e44b9

Create new dump

view details

push time in 2 days

issue commentcmus/cmus

cmus is not actively maintained

Note that since earlier this year, you can now assign roles with more specific permissions to organization members.

flyingmutant

comment created time in 2 days

issue commentcmus/cmus

cmus is not actively maintained

@flyingmutant would you consider making @pgaskin a contributor? It would be a bit less bureaucratic if he can close old issues and stuff.

flyingmutant

comment created time in 2 days

Pull request review commentcmus/cmus

Fixes truncation warnings by replacing %s with %.s

 static void update_editable_window(struct editable *e, const char *title, const 			utf8_encode_to_buf(filename); 			filename = conv_buffer; 		}-		snprintf(buf, sizeof(buf), "%s %s - %d tracks", title,-				pretty(filename), e->nr_tracks);+#pragma GCC diagnostic push+#pragma GCC diagnostic ignored "-Wformat-truncation"+		snprintf(buf, sizeof(buf), "%s %s - %d tracks", title, pretty(filename), e->nr_tracks);+#pragma GCC diagnostic pop
		snprintf(buf, sizeof(buf), "%s %.256s - %d tracks", title, pretty(filename), e->nr_tracks);
nefthy

comment created time in 2 days

pull request commentcmus/cmus

Fixes truncation warnings by replacing %s with %.s

thanks. any ideas on the comment above concerning #pragma?

That's due to the second parameter since GCC doesn't realize the max length 256 since pretty is defined in another file. To fix the warning, you can either:

  • Change it to %.256s.
  • Keep the current pragma.
  • Increase the buffer size > 535.

Usually, you'd use the alloc_size attribute for this kind of thing, but it only works when the size is passed as a function argument (I guess one could be added and checked to ensure it's < 256, but that's a larger refactor).

nefthy

comment created time in 2 days

pull request commentcmus/cmus

Fixes truncation warnings by replacing %s with %.s

thanks. any ideas on the comment above concerning #pragma?

nefthy

comment created time in 2 days

push eventcmus/cmus

Nicu Borta

commit sha b9b2568f4c1958dc6ae33b1782b7835ff92c26b2

ip/cdio.c: only declare track_comments_found if (#1030) HAVE_CDDB was defined Also change it's data type: int -> bool Co-authored-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>

view details

push time in 2 days

PR merged cmus/cmus

ip/cdio.c: only declare track_comments_found if HAVE_CDDB was defined

Also change it's data type: int -> bool,

this variable is only needed when HAVE_CDDB is defined.

+7 -3

4 comments

1 changed file

BouncyMaster

pr closed time in 2 days

pull request commentcmus/cmus

Remove unused functions in op/sndio.c

@flyingmutant @nefthy

pgaskin

comment created time in 2 days

issue commentcmus/cmus

cmus is not actively maintained

I've also enabled GitHub Discussions for the repo, let's look if there will be any interest in that.

Not to be too negative, but are you sure we have the capacity to manage it?

Oh, I definitely do not. I am looking at this as a self-service thing like a wiki. For example, this very thread now looks like it belongs to a forum topic more that to an issue :-)

flyingmutant

comment created time in 2 days

pull request commentcmus/cmus

Remove unused functions in op/sndio.c

I'm not sure why they were there to begin with...

pgaskin

comment created time in 2 days

PR opened cmus/cmus

Remove unused functions in op/sndio.c
+0 -10

0 comment

1 changed file

pr created time in 2 days

pull request commentcmus/cmus

Fixes truncation warnings by replacing %s with %.s

@pgaskin can you review?

nefthy

comment created time in 2 days

PR opened cmus/cmus

Fixes truncation warnings by replacing %s with %.s

Fixes gcc warnings about format trunctations

+6 -4

0 comment

1 changed file

pr created time in 2 days

issue commentcmus/cmus

cmus is not actively maintained

I closed the old PRs. Hopefully I didn't step on any toes by doing so :)

flyingmutant

comment created time in 2 days

pull request commentcmus/cmus

ip/cdio.c: only declare track_comments_found if HAVE_CDDB was defined

I think this can be merged.

BouncyMaster

comment created time in 2 days

PR closed cmus/cmus

Ignore false positive format truncation warnings

Ignore -Wformat-truncation where buffer would be truncated later to fit the screen anyway. This is gcc specific warning, so I check for gcc before, so it works with clang and other compilers. Now there are no warnings/errors when compiling with gcc.

+24 -0

1 comment

1 changed file

mokulus

pr closed time in 2 days

pull request commentcmus/cmus

Ignore false positive format truncation warnings

Closing due to inactivity. Please feel free to reopen or create a new one.

mokulus

comment created time in 2 days

PR closed cmus/cmus

Fix :mark on playlist view so filter is used

The manpage says filter expressions can be used in views 2-4, and I don't see the utility in :mark inverting the selection in the playlist view.

+1 -1

1 comment

1 changed file

torbiak

pr closed time in 2 days

pull request commentcmus/cmus

Fix :mark on playlist view so filter is used

Closing due to inactivity. Please feel free to reopen or create a new one.

torbiak

comment created time in 2 days

PR closed cmus/cmus

ip/ffmpeg: decode multiple frames from one packet

See here https://github.com/cmus/cmus/issues/812#issuecomment-495201322 for a breakdown of the problem. This is mostly a hack, but fixes the problem as far as i know. APE files play without a problem (fixes https://github.com/cmus/cmus/issues/812). It should also fix https://github.com/cmus/cmus/issues/895, but I don't have any WMA files to test it.

+58 -38

3 comments

1 changed file

Ashymad

pr closed time in 2 days

more