profile
viewpoint
Madhav Varshney madhavarshney Full-stack web and mobile developer, open-source contributor.

Foothill-SLI/pl4-server 2

The main central server for the Foothill SLI parking lot project.

madhavarshney/nodebb-plugin-google-forms 2

📝 A plugin for NodeBB to embed Google Forms in posts.

Foothill-SLI/pl4-moving-cars 1

The code for the moving cars team in the parking lot project.

madhavarshney/codive 1

:octocat: A real-time platform for hosting coding workshops 👨‍💻 👩‍💻

madhavarshney/github-discord-integration 1

Information about setting up Discord with GitHub

madhavarshney/hangouts-explorer 1

:tada: A clean and intuitive viewer for Google Hangouts data archives :ok_hand:

madhavarshney/hangouts-reader 1

A well-maintained viewer for Hangouts data exported with Google Takeout

madhavarshney/ansi-colors 0

Collection of ansi colors and styles.

madhavarshney/AppleALC 0

Native macOS HD audio for not officially supported codecs

madhavarshney/awesome-react-native 0

Awesome React Native components, news, tools, and learning material!

push eventacidanthera/VoodooPS2

vit9696

commit sha 1052e19ffb0855a3c71ec3c1343826b6c786e700

Disable Command and Option swap by default closes #35

view details

push time in 34 minutes

PR closed acidanthera/VoodooPS2

Add ssdt Swap command and option

Schermata 2020-12-04 alle 00 24 52 many notebooks need it

+14 -0

1 comment

1 changed file

Lorys89

pr closed time in 34 minutes

push eventPandawan/classesfyi

Miguel

commit sha 611555049687345f233864dea017466599d34974

Frontend Cleanup (WIP)

view details

push time in 20 hours

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

@vit9696 or in plist or ssdt and a function that can be useful if you think it's not useful i close the pr i don't want to create disagreement ☹️

I created this pr to give users with different layout keyboards used to using windows and macos to use this ssdt that modifies the keys, just that.

Lorys89

comment created time in a day

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

Personally I'm neutral on that. Users take it for granted that PrtSc is just disable touchpad and Alt for Command rather than Option. That prejudice have been around for a long time but they will eventually realize it after switching to other input devices.

@Lorys89 Just change the plist value quoted above to false is enough.

Lorys89

comment created time in a day

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

I wouldn't touch the kext plist, just adding ssdt explaining what it's for.

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

I always wanted to disable it by default, just haven't done it. I prefer using keys for what they are designed and what's written on them, no matter where they are located on the keyboard.

I think of the many users who use this fix or do it from system preferences, so my thoughts go to them.

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

I always wanted to disable it by default, just haven't done it. I prefer using keys for what they are designed and what's written on them, no matter where they are located on the keyboard.

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

@zhen-zen I prefer Apple mapping myself, but that does not seem right to enforce it by default. I suugest disable it by default and include and SSDT to enable it in the samples. Do you agree? Also CC @usr-sse2

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

I use this ssdt in my notebooks, I don't want to always change the setting to system preferences

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

Maybe that's the difference between a generic HID driver and one trying to emulate vanilla Apple keyboards' behavior. Current VoodooPS2 configuration and default mapping tries to imitate apple ones, so this option and "Make Application key into right windows" is enabled by default as well.

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

@zhen-zen I agree that it is a great feature, and I also expect it to work properly, but I believe it is counter-intuitive to have it enabled by default.

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

in my opinion, it is useful for the rest of the layouts I do not propose modification to the plist but an ssdt for those who need it

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

Yes, it's enabled by default and for English layout this function works ootb without any issues: https://github.com/acidanthera/VoodooPS2/blob/096f654c986d8d135c0e422eb89e582136cf5736/VoodooPS2Keyboard/VoodooPS2Keyboard-Info.plist#L281

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

we use keyboards born for windows, not Apple keyboards, so you have to use it for Italian layout keyboard, I don't know for other layouts if you need to

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

the Italian keyboard for the @ you press alt gr + @ on windows, instead on macos corresponds to cmd + @, if I use this ssdt everything is back normal

Lorys89

comment created time in 2 days

Pull request review commentacidanthera/VoodooPS2

Add ssdt Swap command and option

+// This sample shows how to Swap command and option.+DefinitionBlock ("", "SSDT", 2, "ACDT", "ps2", 0)+{+    External (_SB_.PCI0.LPCB.PS2K, DeviceObj)+    +    Name(_SB.PCI0.LPCB.PS2K.RMCF, Package()+    {+        "Keyboard", Package()+        {+            "Swap command and option", ">n", 

Does this disable command and option swapping? This looks a bit counter-intuitive to me. Why is that enabled by default? CC @usr-sse2 @zhen-zen

Lorys89

comment created time in 2 days

pull request commentacidanthera/VoodooPS2

Add ssdt Swap command and option

this ssdt no longer reverses command to option in notebooks

Lorys89

comment created time in 2 days

PR opened acidanthera/VoodooPS2

Add ssdt Swap command and option

Schermata 2020-12-04 alle 00 24 52

+15 -0

0 comment

1 changed file

pr created time in 2 days

delete branch acidanthera/VoodooPS2

delete branch : fix_possible_startup_issue

delete time in 3 days

delete branch acidanthera/VoodooPS2

delete branch : fix_sporadic_startup_panics

delete time in 3 days

delete branch acidanthera/VoodooPS2

delete branch : elanv3

delete time in 3 days

push eventacidanthera/VoodooPS2

zhen-zen

commit sha 096f654c986d8d135c0e422eb89e582136cf5736

Disable PrntScr remap by default (#33)

view details

push time in 3 days

PR merged acidanthera/VoodooPS2

Disable PrntScr remap by default

A quick implementation to skip key remap for PrntScr since the original approach involves complicated control flow. Same as other configurations, the option can be toggled using ioio -s ApplePS2Keyboard RemapPrntScr true during runtime and persisted using SSDT or Info.plist property (not recommended).

https://github.com/acidanthera/bugtracker/issues/989

+43 -24

5 comments

6 changed files

zhen-zen

pr closed time in 3 days

pull request commentacidanthera/VoodooPS2

Switch to GitHub Actions

Thanks! By the way, I added Coverity. @zhen-zen will need your e-mail for Coverity access. Or you could request it on https://scan.coverity.com/projects/acidanthera-voodoops2 simply (same route all the other members from Acidanthera for all the other projects).

zhen-zen

comment created time in 3 days

push eventacidanthera/VoodooPS2

Vitaly Cheptsov

commit sha 3355926c12a27a7e3ec209103b368e662cf0486a

Add Coverity shield

view details

push time in 3 days

push eventacidanthera/VoodooPS2

Vitaly Cheptsov

commit sha 346dc1f6615618ef390218f893a819fff86ed52b

Add Coverity analysis

view details

push time in 3 days

push eventacidanthera/VoodooPS2

zhen-zen

commit sha cff27a429caa16e23611e584cded515c20c4e9c8

Switch to GitHub Actions (#34)

view details

push time in 3 days

PR merged acidanthera/VoodooPS2

Switch to GitHub Actions
+69 -37

0 comment

3 changed files

zhen-zen

pr closed time in 3 days

PR opened acidanthera/VoodooPS2

Switch to GitHub Actions
+69 -37

0 comment

3 changed files

pr created time in 3 days

more