profile
viewpoint
Luke Hatcher lukeman Pandora Media Oakland, CA http://luke.io

ericflo/django-pagination 514

A set of utilities for creating robust pagination tools throughout a django application.

lukeman/cocos2d-sprite-color-demo 9

Sprite coloration demo using cocos2d-iphone

lukeman/django-dash-2010 8

Django Dash

lukeman/django-sorting 6

Like ericflo's django pagination, but this one does the sorting! used with ericflo's pagination, displaying tabular paginated and sortable data is very easy!

jj0hns0n/geonode 3

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.

lukeman/classlist-photos-jfx 3

JFX extension that adds student photos to the Jenzabar ICS academic portal class lists.

lukeman/jquery-timeago 3

Timeago is a jQuery plugin that makes it easy to support automatically updating fuzzy timestamps (e.g. "4 minutes ago").

lukeman/pinax-ldap-project 3

A Pinax starter project integrating an LDAP authentication backend

lukeman/geek-time-touch 2

Geek Time for iOS

lukeman/bootstrap 1

HTML, CSS, and JS toolkit from Twitter

startedcaarlos0/speedtest-exporter

started time in 3 days

issue openedmetabase/metabase

Activity entries for dashboard-add-cards events using incorrect card permalink

Describe the bug When cards are added to a dashboard, the activity entry in the frontend links to the wrong question ID. It's using the id of the report_dashboardcard instead of the card_id that was added to the dashboard.

To Reproduce Steps to reproduce the behavior:

  1. Add an existing card to a dashboard, observing the question's ID
  2. Click through to Settings > Activity
  3. Observe the link to the card you just added uses an incorrect ID (+ the correct slug for the question)

Expected behavior Card name in the activity should link to the card as it does when the same card is created or edited.

Screenshots Note the permalinks for the activity when I created the card and then the second when I added that card to a dashboard: bug-repro

Activity log entry for the dashboard-add-cards event (both the join table id and the card_id are present): Screen Shot 2021-10-18 at 8 47 17 PM

Information about your Metabase Installation:

You can get this information by going to Admin -> Troubleshooting.

  • Your browser and the version: Safari
  • Your operating system: Mac
  • Your databases: Postgres
  • Metabase version: 0.41.0
  • Metabase hosting environment: Self-hosted dockerfile + nomad
  • Metabase internal database: Postgres

Severity P3. Bug is limited to the activity log and mostly just confused me for a minute.

Additional context I heart Metabase and all of y'all.

created time in a month

issue commentmetabase/metabase

Caching on 0.41.0 caches results for very long time (does not respect settings defined)

I've experienced this as well, but hadn't yet isolated the issue (it seemed so off that I assumed it was something on my end). I believe my cache settings were >30s with a TTL multiplier of 10. I noticed cached results on a public dashboard from a week prior were being used. Disabling caching seemed to resolve this, but when I enabled caching again after a few days the original very old results returned.

flamber

comment created time in 2 months

issue commentmetabase/metabase

Pulse table cards with INT64 values fail to render in 0.41.0

A table should always be a table, if you ask me, but generally it's #5493. I have never used Pulses in real-life for this reason and created my own email reporting tools back in the days.

Not to go too off-topic, but for ^ those reasons and the maintenance burden of juggling multiple identical cards with different variables to support different sets of recipients (prior to dashboard subscriptions), I too ended up building a custom Python multi-channel (email/Slack) reporting system.

Dashboard subscriptions seem to solve my issues with scaling out Pulses, so I'll be kicking the tires more for the next few releases and try to be more responsible with taking time to file issues.

lukeman

comment created time in 2 months

issue openedmetabase/metabase

Pulses with rounded floats render a hanging decimal point in 0.41.0

Describe the bug Pulses with table results that include fractional numbers that are formatted to round off to 0 decimals include a hanging decimal point when rendered for email/Slack.

To Reproduce Steps to reproduce the behavior:

  1. Create a card with fractional numbers: select 'a' a, 4.9 b, 8.38 c
  2. Format the number columns to have 0 minimum digits (rounding them off to a whole number for display)
  3. Add that card to a new dashboard
  4. Create a dashboard subscription that sends to Email or Slack
  5. Click the 'Send now' button

Expected behavior Numbers rounded off in the cell formatting shouldn't include a decimal point after the whole number.

Screenshots

Original question: Screen Shot 2021-10-08 at 3 12 36 PM

Dashboard rendering (still good): Screen Shot 2021-10-08 at 3 13 20 PM

Email rendering (!): Screen Shot 2021-10-08 at 3 13 45 PM

Information about your Metabase Installation:

  • Your browser and the version: Latest Safari
  • Your operating system: macOS Big Sur
  • Your databases: New and legacy BigQuery (also think this would affect other engines that use INT64)
  • Metabase version: 0.41.0
  • Metabase hosting environment: Self-hosted docker on nomad
  • Metabase internal database: Postgres

Severity P3. I'd originally thought digits on a pulse were just being cut off, but since it's rounding as the cards were set up to do it's just a visual bug.

created time in 2 months

issue openedmetabase/metabase

Slack renders of table results in 0.41.0 include too much right padding

Describe the bug Pulses with table results render as a very wide image when sent to Slack (static width of 1200px?). This makes scanning the contents near impossible without zooming on the attachment.

To Reproduce Steps to reproduce the behavior:

  1. Create a card that selects 3–5 columns
  2. Add that card to a new dashboard
  3. Create a dashboard subscription that sends to Slack
  4. Click the 'Send now' button

Expected behavior Tables should try to render at an appropriate width so the text is legible without zooming the image.

Screenshots image-5

Information about your Metabase Installation:

  • Your browser and the version: Latest Safari
  • Your operating system: macOS Big Sur
  • Your databases: New and legacy BigQuery (also think this would affect other engines that use INT64)
  • Metabase version: 0.41.0
  • Metabase hosting environment: Self-hosted docker on nomad
  • Metabase internal database: Postgres

Severity P2/P3, since it's limited to Slack (important to me, but maybe not as much generally) and technically things still work.

created time in 2 months

issue commentmetabase/metabase

Pulse table cards with INT64 values fail to render in 0.41.0

Update: it appears that adding more columns to the query avoids the problematic call, so this seems less like a general INT64 thing than I thought at first glance.

select 'a' n, 'alpha' o, 2 p, 4 q, 8 r
union all
select 'b', 'beta', 7, 2, 16

Slack output (fwiw, that right padding is how it renders): image-4

lukeman

comment created time in 2 months

issue openedmetabase/metabase

Pulse table cards with INT64 values fail to render in 0.41.0

Describe the bug A native BigQuery query that returns a table of the form name STRING, events INT64 fails to render with a java.lang.ClassCastException when sent as part of a pulse/alert/subscription. This happens with existing pulses as well as newly created ones.

You can get around this exception by FORMATting the int to a string. It appears that this could be isolated to tables—while trying to repro with a single row the pulse sent as what seemed like a properly rendered line graph.

Logs The logs aren't showing anything beyond the exception class:

[1aac307c-a076-4cdc-8f6f-d24f8b91a4b9] 2021-10-08T12:27:54-04:00 ERROR metabase.pulse.render Pulse card render error
java.lang.ClassCastException
[1aac307c-a076-4cdc-8f6f-d24f8b91a4b9] 2021-10-08T12:27:55-04:00 DEBUG metabase.server.middleware.log POST /api/pulse/test 200 3.7 s (17 DB calls) App DB connections: 0/15 Jetty threads: 4/50 (3 idle, 0 queued) (113 total active threads) Queries in flight: 0 (0 queued)

To Reproduce Steps to reproduce the behavior:

  1. Create a BigQuery card (old or new driver) using SELECT 'a', 1 UNION ALL SELECT 'b', 2
  2. Add that card to a new dashboard
  3. Create up a dashboard subscription (either email or slack is fine)
  4. Click the 'Send now' button
  5. See exception in server logs and 'An error occurred while displaying this card' in your email/slack

Expected behavior Tables with numbers should render.

Screenshots If applicable, add screenshots to help explain your problem.

Information about your Metabase Installation:

  • Your browser and the version: Latest Safari
  • Your operating system: macOS Big Sur
  • Your databases: New and legacy BigQuery (also think this would affect other engines that use INT64)
  • Metabase version: 0.41.0
  • Metabase hosting environment: Self-hosted docker on nomad
  • Metabase internal database: Postgres

Severity Since this breaks pulses/alerts/subs for the most basic of BigQuery table cards it seems like a pretty big blocker.

Additional context

There might be more going on in this area as I'm seeing some odd formatting/truncation of fractional numbers in some pulses that still render, but I don't have enough info to file a formal issue on that just yet.

One thing that made it harder to discover this prior to 0.41.0's release was the lack of "Send to Slack now"/"Send test email" on existing Pulses and Alerts. The few cards I picked to set up schedules and wait for sadly didn't include INT64. I'm new to dashboard subscriptions and only discovered you can still send tests from those after I upgraded to 0.41.0 in prod.

created time in 2 months

more