profile
viewpoint
Lukas Reineke lukas-reineke @HENNGE Tokyo, Japan lukas-reineke.com

lukas-reineke/indent-blankline.nvim 108

Indent guides on blank lines for Neovim

lukas-reineke/format.nvim 40

Neovim lua plugin to format the current buffer with external executables

lukas-reineke/ale 0

Asynchronous linting/fixing for Vim and Language Server Protocol (LSP) integration

lukas-reineke/auto-pairs 0

Vim plugin, insert or delete brackets, parens, quotes in pair

lukas-reineke/bouncy-balls 0

Watch Javascript "AI" learn how to launch balls into a target.

lukas-reineke/bugwarrior 0

Pull github, bitbucket, and trac issues into taskwarrior

lukas-reineke/chartist-plugin-tooltip 0

Tooltip plugin for Chartist.js

lukas-reineke/ci 0

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y

created repositoryujihisa/gcpgochat

created time in 21 hours

pull request commentHDE/python-lambda-local

Drop support of Python 2.7

I can't check the logs of wercker, but maybe the py2 build also needs to get removed somewhere on that service?

suzil

comment created time in a day

PR opened HDE/python-lambda-local

Drop support of Python 2.7

Closes #65

+7 -32

0 comment

6 changed files

pr created time in a day

startedlukas-reineke/indent-blankline.nvim

started time in 2 days

startedlukas-reineke/meishi

started time in 2 days

startedlukas-reineke/dotfiles

started time in 2 days

startedlukas-reineke/indent-blankline.nvim

started time in 2 days

issue commentlukas-reineke/indent-blankline.nvim

Plugin does not work.

@lukas-reineke I'm also on Arch Linux, same neovim version, but running :echo jobpid(g:indent_blankline_nvim_instance) shows -

E121: Undefined variable: g:indent_blankline_nvim_instance
E116: Invalid arguments for function jobpid

i.e. the instance isn't even starting :confused:

Also :echo filereadable(expand('%')) returns 1 and I am testing this in a file that has already been saved. I also use indentLine plugin..

dominikduda

comment created time in 2 days

push eventmhartington/formatter.nvim

Mike Hartington

commit sha 0f961c6bece91b9d3854ff0599633d86d577a81d

chore(): cleanup

view details

push time in 4 days

startedgiantswarm/prometheus

started time in 4 days

starteddraios/sysdig

started time in 4 days

created repositoryaynik/django-graphql-api

Example django graphql api

created time in 4 days

startedlukas-reineke/indent-blankline.nvim

started time in 5 days

startedlukas-reineke/indent-blankline.nvim

started time in 5 days

startedlukas-reineke/indent-blankline.nvim

started time in 5 days

startedlukas-reineke/format.nvim

started time in 5 days

pull request commentmhartington/formatter.nvim

Refactor

Oh, I found an issue with this branch. Are you able to make prettier work with a file that has a filename like [slug].js? It throws an error but I don't know where to trace that error. It only says 'Formatter: Error running prettier. Tried to setlogging` to true but it does nothing.

This issue was fixed in prettier 2.0

mhartington

comment created time in 6 days

PR closed mhartington/formatter.nvim

Add fallback to o.args to prevent throwing an error

Currently, if a user doesn't pass an args table, the plugin will throw an error because table.concat() is trying to concat a table but it's receiving nil

Some formatters work fine without any args & just passing an empty args table to prevent the error IMO should be handled by the plugin.

Maybe another way to fix this is to change the defaults object in config.lua to be defaults or {args ={}} but I didn't try that

+1 -1

2 comments

1 changed file

ahmedelgabri

pr closed time in 6 days

pull request commentmhartington/formatter.nvim

Add fallback to o.args to prevent throwing an error

@mhartington looks like it's fixed in that branch already https://github.com/mhartington/formatter.nvim/blob/e4946221fd893e3f2506d3264f837b7735564b75/lua/formatter/format.lua#L72

ahmedelgabri

comment created time in 6 days

pull request commentmhartington/formatter.nvim

Add fallback to o.args to prevent throwing an error

Looks good, could you PR this to the refactor branch though? Have a bunch of changes in place in #12 that will improve a lot inside the codebase

ahmedelgabri

comment created time in 6 days

PR opened mhartington/formatter.nvim

Remove no formatters defined message

This is a bit of a preference than a fix, but I think the log doesn't make much sense & removing it actually can simplify the setup a bit.

autocmd BufWritePre * Format

Instead of keeping track of which filetypes that should be formatted in two places, the table inside setup & the autocmd.

The user can just add this autocmd & forget about it & the plugin will do the right thing.

+0 -1

0 comment

1 changed file

pr created time in 6 days

PR opened mhartington/formatter.nvim

Add fallback to o.args to prevent throwing an error

Currently if a user doesn't pass an args table, the plugin will throw an error because table.concat() is trying to concat a table but it's receiving nil

Some formatters work fine without any args & just passing an empty args table to prevent the error IMO should be handled by the plugin.

+1 -1

0 comment

1 changed file

pr created time in 6 days

startedlukas-reineke/format.nvim

started time in 6 days

issue closedlukas-reineke/format.nvim

extra key press after save

Hi, thanks again for the plug-in. After the latest update, I noticed have to press Enter after saving (and auto formatting). Is there a way to go back to the previous behavior where auto formatting doesn't ask me for an extra key press? Screen Shot 2020-11-16 at 11 12 04 PM

These are the settings I used to invoke formatting

" auto format and save
augroup Format
    autocmd!
    autocmd BufWritePost * FormatWrite
augroup END

closed time in 6 days

caheredia

issue commentlukas-reineke/format.nvim

extra key press after save

awesome, thanks!

caheredia

comment created time in 6 days

pull request commentmhartington/formatter.nvim

Refactor

ok gotcha! I found the solution which is adding the quote in my config. Thanks :)

mhartington

comment created time in 6 days

pull request commentmhartington/formatter.nvim

Refactor

the plugin doesn't really process the buffers name in any space except from the users defined formatters. What's probably happening is that the [] in the file name are getting treated as shell escape sequences, so the job never starts.

2 options I see:

  • don't name files like that? Kind of a drastic change if you already have them, but I could see this being problematic with any tool that would run on that kind of a codebase.

  • escape the file name in your config?

mhartington

comment created time in 6 days

pull request commentmhartington/formatter.nvim

Refactor

Ok, I think I found the issue. I need to wrap the filename with quote. e.g cat '[slug].js' | prettier --stdin-filepath '[slug].js' Maybe formatter didn't wrap the filename with quote? So it fails to format it.

mhartington

comment created time in 6 days

pull request commentmhartington/formatter.nvim

Refactor

Mm, not sure. Is the file name exactly [slug].js? a quick way to validate your settings is to try to run them through the command line directly

cat [slug].js | prettier --stdin-filepath {path to file}
mhartington

comment created time in 6 days

more