profile
viewpoint
Louis-Félix Tessier louisfelix FXinnovation Montréal, Québec, Canada https://www.fxinnovation.com/

louisfelix/alertmanager-maintenance-scheduler 0

A maintenance scheduler UI for Prometheus Alertmanager

louisfelix/alertmanager-silences-exporter 0

Prometheus exporter exposing Alertmanager silences as metrics

louisfelix/alertmanager-webhook-rocketchat 0

Sends alerts from Prometheus AlertManager to Rocket.Chat

louisfelix/alertmanager-webhook-servicenow 0

A Prometheus AlertManager webhook receiver that manages ServiceNow incidents from alerts

louisfelix/alertmanager-webhook-template 0

Prometheus AlertManager webhook receiver template

louisfelix/azure-health-exporter 0

Prometheus exporter exposing Azure Health API status as metrics

louisfelix/azure-resources-exporter 0

Prometheus exporter exposing Azure resources status as metrics

louisfelix/azure_metrics_exporter 0

Azure metrics exporter for Prometheus

louisfelix/exporter-template 0

Prometheus exporter template

louisfelix/jetty-documentation 0

Jetty Documentation Project

push eventseeds-of-diversity/seeds

bob

commit sha 5096fe02a5f41c54096debbc707ce44668cc1bc9

AddMbrDonation(), doRecordDonations

view details

bob

commit sha 5c2571683c5a310333c8d385cdc7c7f051165295

PurchaseFulfil(), PurchaseIsFulfilled(), SEEDBasket_Purchase methods,

view details

bob

commit sha 777a53d809ea042d71e2f980aa4cc13db2d4c83b

SEEDBasket_Purchase_donation, SEEDBasket_Product_{prodType} and SEEDBasket_Purchase_{prodType}

view details

bob

commit sha bd558071aff245c687edbcb4213d8328cdd2415e

GetPurchasesInBasket() returns derived purchase objects

view details

bob

commit sha 1781db67e25726ebf2bd60428b3a9070a52cbb0c

M_D relation

view details

bob

commit sha c189a871defbaf1bbcb87313661a4ed1fb1a1b7d

SFG2020 donation slips

view details

bob

commit sha da8144a10f0c1eeb28e9de9d347ff5440dd0a37c

DrawAddressBlock()

view details

bob

commit sha 6b46a64eba7c151ba69465e862c3e375c24c670e

fix issues with accepting donations

view details

bob

commit sha c2d1c20b70332cd202148c3d435bbef6ab1a2436

defensive @ in case data not available

view details

bob

commit sha b2ef15f24bbd2fb9909ddfa18662a114bbedcd5a

firstname2/lastname2 in label

view details

bob

commit sha 407f6095b2ea8c1a13b8fa16f54f02828273c33d

SFG2020 slip format

view details

bobwildfong

commit sha 1a2b138e18e699f96046ec9d9a7a703f12688c2f

SEEDStd to SEEDCore

view details

bobwildfong

commit sha f1c484bd4d4f290566967756dcaedbb382dc4032

quotes

view details

bobwildfong

commit sha e405fe24645849526252cbd73afc24bc8ccb922d

show more info about directory

view details

bobwildfong

commit sha 10fb9f15b47da01d09f2d52631e95624b0851eb2

multi-process convert

view details

bobwildfong

commit sha 4c0b2ed02a148f47c68360b7d455603e87e266b4

show whatYouSaved

view details

bobwildfong

commit sha 3574c7be744a27b4b5f17bd5acbe623449142062

use _myseedconfig.php

view details

bob

commit sha 50044aff1092bc5586dcfa0222bf175cd8ba76c3

debug sfg2020 list

view details

bob

commit sha fb75dfc397fd527437a03f7e7aa52fa2b15fc1a0

only ArrayExpand strings and numbers

view details

bob

commit sha d465ff8a1a41f8d4f01e64fabbdb6bacecc28bc6

Merge branch 'master' of https://github.com/seeds-of-diversity/seeds.git

view details

push time in 2 days

issue commentRobustPerception/azure_metrics_exporter

Unable to get storage account used capacity metric

Same issue. No solution?

mboret

comment created time in 2 days

issue commentprometheus/cloudwatch_exporter

[latest] Failed to load class "org.slf4j.impl.StaticLoggerBinder".

I get the same with a fresh build, but not the most recent release so this is likely the AWS v2 libraries breaking something.

mandarg

comment created time in 5 days

issue openedprometheus/cloudwatch_exporter

[latest] Failed to load class "org.slf4j.impl.StaticLoggerBinder".

I'm running the latest imagefrom Docker Hub (DIGEST:sha256:74ad197210aed00145de2e6ebf24bf699ffc2de4c3d352c9c745ee7f4e77fd5d) – and get the following errors on startup.

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".                                                      
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

The application seems to still scrape CloudWatch, but I'm unable to debug properly due to the logging. Any way in which I can help with this? The referenced link in the error message tells me that “This happens when no appropriate SLF4J binding could be found on the class path.” which makes sense; but I don't understand why SLF4J is expected there in the first place; given that it's not in the list of dependencies as of ef0a8acf. Perhaps an issue with the artifacts pushed to Maven?

created time in 5 days

issue closedprometheus/cloudwatch_exporter

Performace improvement with concurrent calls

Currently all the API call are done sequential and it takes minutes to retrieve the metrics. meshuga - https://github.com/meshuga/cloudwatch_exporter/tree/async_client has implemented concurrent processing so it takes very less time. However this is one year old. I have updated it to be in sync with latest - https://github.com/gogineni99/cloudwatch_exporter/tree/async_client

There is a huge improvement in the performance to populate prometheus endpoint.

Can this be merged to master branch ?

closed time in 7 days

gogineni99

pull request commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

Thanks!

anas-aso

comment created time in 7 days

push eventprometheus/cloudwatch_exporter

Anas

commit sha ef0a8acfe1ee5b3f44ba024ddc2b75701d6aea73

Migrate to AWS SDK v2 (#307) * Update AWS SDK dependency to v2 Signed-off-by: Anas <anas-aso@users.noreply.github.com>

view details

push time in 7 days

PR merged prometheus/cloudwatch_exporter

Reviewers
Migrate to AWS SDK v2

Signed-off-by: Anas anas.oubrahim@commercetools.com

Fixes https://github.com/prometheus/cloudwatch_exporter/issues/172

@brian-brazil can I have your review please ?

+316 -299

4 comments

3 changed files

anas-aso

pr closed time in 7 days

issue closedprometheus/cloudwatch_exporter

Migrate to AWS version 2 Java API

AWS version 2 api have already released for half year. Do you have plan to upgrade? It might be a refactoring.

closed time in 7 days

silenceleaf

created repositoryrolandvarga/rename-tool

created time in 10 days

pull request commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

I haven't had a chance to test this out myself yet.

anas-aso

comment created time in 14 days

pull request commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

@brian-brazil is there anything else needed for this PR ?

anas-aso

comment created time in 14 days

issue closedprometheus/cloudwatch_exporter

Do we need 2 config.yml for fetching metrics from 2 separate regions ?

Hi..i have a scenario where i need to fetch ALB metrics from us-west-2 region, and also Cloudfront metrics. As per documentation, we need to specify region=us-east-1 for cloudfront metrics. But, as per the cloudwatch exporter docs, looks like we can specify only 1 region name in single config file. Please let me know whether we need 2 separate config files, and also do we need to create 2 cloudwatch-exporter services with separate ports like 9106, 9107 ? Please guide me on this.

closed time in 15 days

m-mukesh

issue commentprometheus/cloudwatch_exporter

Do we need 2 config.yml for fetching metrics from 2 separate regions ?

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

m-mukesh

comment created time in 15 days

issue openedprometheus/cloudwatch_exporter

Do we need 2 config.yml for fetching metrics from 2 separate regions ?

Hi..i have a scenario where i need to fetch ALB metrics from us-west-2 region, and also Cloudfront metrics. As per documentation, we need to specify region=us-east-1 for cloudfront metrics. But, as per the cloudwatch exporter docs, looks like we can specify only 1 region name in single config file. Please let me know whether we need 2 separate config files, and also do we need to create 2 cloudwatch-exporter services with separate ports like 9106, 9107 ? Please guide me on this.

created time in 15 days

issue commentprometheus/cloudwatch_exporter

cloudwatch taking worker role in AWS and not using OIDC

@brian-brazil Unfortunatley that did not changed the behavior :/ I built a docker image from the fork of anas-aso and replaced it in the helm chart but the error looks the same.

joshi55

comment created time in 16 days

issue commentprometheus/cloudwatch_exporter

cloudwatch taking worker role in AWS and not using OIDC

If this is fixed in v2, then #307 could fix it. Could you try that?

joshi55

comment created time in 16 days

issue commentprometheus/cloudwatch_exporter

cloudwatch taking worker role in AWS and not using OIDC

I also got the same issue. I did the setup of the serviceAccount properly and it the role and token is exported and mounted properly in the pod. As soon as the exporter starts it will fail because the role attached to the EKS nodegroup is used instead of the attached serviceaccount role. The only difference on my end is the "aws sts get-caller-identity" also states the role of EKS nodegroup instead of the attached serviceaccount. Any advice on that? @joshi55 How did you installed/used the awscli?

joshi55

comment created time in 16 days

fork lmazuel/NoodleExtensions-python

A python library to make it easier to do Noodle Extensions

fork in 18 days

pull request commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

@brian-brazil I have tried all the config options and all seems fine. It was time consuming but I think it was worth it since I found something that I missed before https://github.com/prometheus/cloudwatch_exporter/pull/307/commits/ecd822ffbe49bbf2ffc96d8fc274ff044b8f3640

Regarding the tagging feature, here is the results of the tests I did:

Test 1: Without tag filtering

Using the config below:

region: eu-central-1
metrics:
  - aws_namespace: AWS/ApplicationELB
    aws_metric_name: RequestCount
    aws_dimensions: [LoadBalancer]
    aws_statistics: [Sum]

I got the following results

# HELP cloudwatch_requests_total API requests made to CloudWatch
# TYPE cloudwatch_requests_total counter
cloudwatch_requests_total{action="listMetrics",namespace="AWS/ApplicationELB",} 4.0
cloudwatch_requests_total{action="getMetricStatistics",namespace="AWS/ApplicationELB",} 33.0
# HELP tagging_api_requests_total API requests made to the Resource Groups Tagging API
# TYPE tagging_api_requests_total counter
# HELP aws_applicationelb_request_count_sum CloudWatch metric AWS/ApplicationELB RequestCount Dimensions: [LoadBalancer] Statistic: Sum Unit: Count
# TYPE aws_applicationelb_request_count_sum gauge
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 14.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 6.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 2.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 4.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 3.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 4.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 4.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 0.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 2.0 1604676480000
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 2.0 1604676480000
# HELP aws_resource_info AWS information available for resource
# TYPE aws_resource_info gauge
# HELP cloudwatch_exporter_scrape_duration_seconds Time this CloudWatch scrape took, in seconds.
# TYPE cloudwatch_exporter_scrape_duration_seconds gauge
cloudwatch_exporter_scrape_duration_seconds 0.377298838
# HELP cloudwatch_exporter_scrape_error Non-zero if this scrape failed.
# TYPE cloudwatch_exporter_scrape_error gauge
cloudwatch_exporter_scrape_error 0.0

Test 2: With tag filtering

Using the config below:

region: eu-central-1
metrics:
  - aws_namespace: AWS/ApplicationELB
    aws_metric_name: RequestCount
    aws_dimensions: [LoadBalancer]
    aws_statistics: [Sum]
    aws_tag_select:
      tag_selections:
        kubernetes.io/ingress-name: ["REDACTED"]
      resource_type_selection: "elasticloadbalancing:loadbalancer"
      resource_id_dimension: LoadBalancer

I got the following results

# HELP cloudwatch_requests_total API requests made to CloudWatch
# TYPE cloudwatch_requests_total counter
cloudwatch_requests_total{action="listMetrics",namespace="AWS/ApplicationELB",} 10.0
cloudwatch_requests_total{action="getMetricStatistics",namespace="AWS/ApplicationELB",} 64.0
# HELP tagging_api_requests_total API requests made to the Resource Groups Tagging API
# TYPE tagging_api_requests_total counter
tagging_api_requests_total{action="getResources",resource_type="elasticloadbalancing:loadbalancer",} 4.0
# HELP aws_applicationelb_request_count_sum CloudWatch metric AWS/ApplicationELB RequestCount Dimensions: [LoadBalancer] Statistic: Sum Unit: Count
# TYPE aws_applicationelb_request_count_sum gauge
aws_applicationelb_request_count_sum{job="aws_applicationelb",instance="",load_balancer="app/REDACTED",} 6.0 1604676480000
# HELP aws_resource_info AWS information available for resource
# TYPE aws_resource_info gauge
aws_resource_info{job="aws_applicationelb",instance="",arn="arn:aws:elasticloadbalancing:eu-central-1:REDACTED:loadbalancer/app/REDACTED",load_balancer="app/REDACTED",tag_ingress_k8s_aws_cluster="REDACTED",tag_ingress_k8s_aws_resource="LoadBalancer",tag_ingress_k8s_aws_stack="REDACTED",tag_kubernetes_io_cluster_REDACTED="REDACTED",tag_kubernetes_io_ingress_name="REDACTED",tag_kubernetes_io_namespace="REDACTED",} 1.0
# HELP cloudwatch_exporter_scrape_duration_seconds Time this CloudWatch scrape took, in seconds.
# TYPE cloudwatch_exporter_scrape_duration_seconds gauge
cloudwatch_exporter_scrape_duration_seconds 0.138822136
# HELP cloudwatch_exporter_scrape_error Non-zero if this scrape failed.
# TYPE cloudwatch_exporter_scrape_error gauge
cloudwatch_exporter_scrape_error 0.0
anas-aso

comment created time in 19 days

Pull request review commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

  import org.yaml.snakeyaml.Yaml; +import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;+import software.amazon.awssdk.regions.Region;+import software.amazon.awssdk.services.cloudwatch.CloudWatchClient;+import software.amazon.awssdk.services.cloudwatch.CloudWatchClientBuilder;+import software.amazon.awssdk.services.cloudwatch.model.*;

Done : https://github.com/prometheus/cloudwatch_exporter/pull/307/commits/c7fd02fba98cc0bca1cc30e13510be148c647388

anas-aso

comment created time in 19 days

Pull request review commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

  import org.yaml.snakeyaml.Yaml; +import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;+import software.amazon.awssdk.regions.Region;+import software.amazon.awssdk.services.cloudwatch.CloudWatchClient;+import software.amazon.awssdk.services.cloudwatch.CloudWatchClientBuilder;+import software.amazon.awssdk.services.cloudwatch.model.*;

This one isn't explicit.

anas-aso

comment created time in 19 days

issue commentprometheus/cloudwatch_exporter

cloudwatch taking worker role in AWS and not using OIDC

I figured out my problem: the Java SDK was silently failing to acquire the role_arn, and using the instance role since it's the last in the DefaultAWSCredentialsProviderChain. I was using an IAM Role issued to me by the network security team, but that IAM Role did not have the EKS cluster's OIDC Identity Provider in it's Trusted Relationships description, so sts:AssumeRole failed, and the Java SDK used the next IAM Role it could acquire -- a Role that doesn't have access to cloudwatch:ListMetrics .

I can't say if what I encountered is what @joshi55 encountered.

joshi55

comment created time in 19 days

push eventseeds-of-diversity/seedsx

bob

commit sha 74e55638559229db78a9370f6bc02ae9d8b3a8b0

fix obsolete char indexing

view details

push time in 20 days

push eventseeds-of-diversity/seeds

bob

commit sha 64d96ede982bb9df0e3db9b4891a346b9ca1631b

move msd:seedlist to SoDMasterTemplate

view details

push time in 20 days

push eventseeds-of-diversity/seedsx

bob

commit sha d90ea0bf295d59d08035be5b3b5906bcccfe13c4

extend templating with SoDMasterTemplate

view details

bob

commit sha ac304474bc1320f4d95895ad7f4e168125e43d56

move msd:seedlist to SoDMasterTemplate

view details

push time in 20 days

pull request commentprometheus/cloudwatch_exporter

Migrate to AWS SDK v2

@brian-brazil I have addressed your reviews. Can you please have a 2nd look ?

From a cursory review this looks okay, however I expect the devil is in the details. What sort of manual testing have you done on this?

I run the latest released version and this PR locally, fetch the metrics (wget) and compare the output (I did it multiple times). The result is always like this :

2a3,6
> # HELP cloudwatch_requests_total API requests made to CloudWatch
> # TYPE cloudwatch_requests_total counter
> cloudwatch_requests_total{action="getMetricStatistics",namespace="AWS/SQS",} 5117.0
> cloudwatch_requests_total{action="listMetrics",namespace="AWS/SQS",} 119.0
637c641
< cloudwatch_exporter_scrape_duration_seconds 25.683923456
---
> cloudwatch_exporter_scrape_duration_seconds 25.514181182
641,644d644
< # HELP cloudwatch_requests_total API requests made to CloudWatch
< # TYPE cloudwatch_requests_total counter
< cloudwatch_requests_total{action="getMetricStatistics",namespace="AWS/SQS",} 27692.0
< cloudwatch_requests_total{action="listMetrics",namespace="AWS/SQS",} 644.0

I am also running a local Prometheus and it's scrapping both version of the exporter : count sum

Not perfect, but should give a rough idea about the returned results by both versions of the exporter.

PS: I am importing SQS metrics only.

If you have a better idea for manual testing I can give it a try (if it doesn't require too much time).

anas-aso

comment created time in 20 days

push eventseeds-of-diversity/seeds

bob

commit sha 028b303c22b4715c52dce74d6169363c03372778

SEEDCore_ArraySmartBool()

view details

bob

commit sha f225171071a490b8ccc8dea64defd737d8f5e9f8

bEatUnknownTags

view details

bob

commit sha f72dd30aa1ac87f5e08c8c5374a18167d38a7b4e

include basket handlers for apps that don't already do that

view details

push time in 20 days

more