profile
viewpoint
Loïc Guychard lguychard @sourcegraph Brittany, France loicguychard.com Software Engineer

Dashlane/ts-event-bus 68

📨 Distributed messaging in TypeScript

codecov/sourcegraph-codecov 50

See code coverage information from Codecov on GitHub, Sourcegraph, and other tools.

sourcegraph/bitbucket-server-plugin 3

Get code intelligence and run Sourcegraph extensions on Bitbucket Server.

lguychard/sourcegraph-string-references 2

A Sourcegraph extension allowing to find references to a string literal

lguychard/istio 0

Connect, secure, control, and observe services.

lguychard/loispy 0

My toy lisp

lguychard/phabricator-extension 0

Get code intelligence on Phabricator

lguychard/pollyjs 0

Record, Replay, and Stub HTTP Interactions.

lguychard/puppeteer-interceptor 0

Easy request interception/response modification for puppeteer

create barnchsourcegraph/puppeteer-interceptor-poc

branch : master

created branch time in a day

created repositorysourcegraph/puppeteer-interceptor-poc

created time in a day

PR opened jsoverson/puppeteer-interceptor

Add ability to fulfill requests

I'm exploring using this project as a base to build a new Puppeteer adaptor for https://github.com/Netflix/pollyjs. In order to do this, I need the ability to fulfill requests without letting them passthrough to the server.

+18 -0

0 comment

1 changed file

pr created time in a day

create barnchlguychard/puppeteer-interceptor

branch : lg/add-request-fulfill

created branch time in a day

fork lguychard/puppeteer-interceptor

Easy request interception/response modification for puppeteer

fork in a day

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

Now using setBreadcrumb() in all RepoContainer children: https://github.com/sourcegraph/sourcegraph/pull/12536/commits/3d89207be5b3d0d51551b625321cf26bb41c1459

marekweb

comment created time in 2 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 3d89207be5b3d0d51551b625321cf26bb41c1459

Set filePath breadcrumbs in BlobPage, TreePage

view details

push time in 2 days

Pull request review commentsourcegraph/sourcegraph

web: highlight search operators and/or/not

 describe('parseSearchQuery()', () => {                             start: 15,                         },                         token: {-                            type: 'literal',-                            value: 'and',+                            type: 'operator',

I'd love that! I'll trade you web coding sessions for backend parser sessions 😄

rvantonder

comment created time in 3 days

Pull request review commentsourcegraph/sourcegraph

web: highlight search operators and/or/not

 describe('parseSearchQuery()', () => {                             start: 15,                         },                         token: {-                            type: 'literal',-                            value: 'and',+                            type: 'operator',

Pushed https://github.com/sourcegraph/sourcegraph/pull/12694/commits/666ed5a85fd27e0e7c221b917abc57f01acdc855 to help out with this

rvantonder

comment created time in 4 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 666ed5a85fd27e0e7c221b917abc57f01acdc855

Capture operator value

view details

push time in 4 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 08659d63a2fa946ebe5428dd13325e7dfda47165

Fix patternType addition in SearchResults (#12698) By calling `convertPlainTextToInteractiveQuery()`, SearchResults did quite a bit more than simply setting `patternType` in the URL if it didn't exist, mutating the query content needlessly.

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : lg/fix-search-patterntype-addition

delete time in 4 days

PR merged sourcegraph/sourcegraph

Fix patternType addition in SearchResults

By calling convertPlainTextToInteractiveQuery(), SearchResults did quite a bit more than simply setting patternType in the URL if it didn't exist, mutating the query content needlessly.

There's more that needs to happen for a fully correct fix to #12506 and #12690, but this is a start.

+4 -7

1 comment

2 changed files

lguychard

pr closed time in 4 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 7bcc8cb86321fb062b0d27f4db25a91b0a6930c9

CHANGELOG entry

view details

push time in 4 days

create barnchsourcegraph/sourcegraph

branch : lg/fix-convert-to-interactive-query

created branch time in 4 days

PR opened sourcegraph/sourcegraph

Fix patternType addition in SearchResults

By calling convertPlainTextToInteractiveQuery(), SearchResults did quite a bit more than simply setting patternType in the URL if it didn't exist, mutating the query content needlessly.

There's more that needs to happen for a fully correct fix to #12506 and #12690, but this is a start.

+3 -7

0 comment

1 changed file

pr created time in 4 days

create barnchsourcegraph/sourcegraph

branch : lg/fix-search-patterntype-addition

created branch time in 4 days

pull request commentsourcegraph/sourcegraph

Fix: trailing parens get removed from interactive mode queries

The closing paren is meant to be parsed as a closingParen, as you'll see in the failing tests: https://buildkite.com/sourcegraph/sourcegraph/builds/69872#16759d99-1a75-4dea-a547-257e94b0e371/92-388

attfarhan

comment created time in 4 days

issue closedsourcegraph/sourcegraph

Add browser argument to BrowserExtensionConnectedToServer event

Now that we're sending browser extension data to Sourcegraph.com, could we add which browser it's coming from?

To me, the most logical path would be to add browser: Chrome (or similar) as an argument to the event BrowserExtensionConnectedToServer. Does that seem like the best route for this?

I'm only interested in this data for Sourcegraph.com, but it would give us the option to add to pings at a later date.

@lguychard tagging you on this because it'd be in the web team domain (pun intended)

closed time in 4 days

ebrodymoore

issue commentsourcegraph/sourcegraph

Add browser argument to BrowserExtensionConnectedToServer event

This is now implemented.

ebrodymoore

comment created time in 4 days

issue commentsourcegraph/sourcegraph

Web: 3.19 tracking issue

Last week I worked with the team on the breadcrumbs project: reviewing the designs as a group, then implementing them, starting with using a new shared breadcrumbs component instead of the ad-hoc breadcrumbs component that had been used in the repository header. We've been making progress on this PR: https://github.com/sourcegraph/sourcegraph/pull/12536

lguychard

comment created time in 7 days

Pull request review commentsourcegraph/sourcegraph

Stop word-count extension from breaking extensions and command palette

 export function mergeContributions(contributions: Evaluated<Contributions>[]): E             }         }         if (contribution.views) {-            if (!merged.views) {-                merged.views = [...contribution.views]-            } else {-                merged.views = [...merged.views, ...contribution.views]+            // swallow errors from malformed manifests so the sqs/word-count extension doesn't+            // break other extensions: https://github.com/sourcegraph/sourcegraph/issues/10600+            try {+                if (!merged.views) {+                    merged.views = [...contribution.views]+                } else {+                    merged.views = [...merged.views, ...contribution.views]+                }+            } catch {+                continue

Maybe this try/catch should encompass the entire body of the for loop? Items other than views may be malformed, and the goal here is to prevent any future malformed manifest from breaking other extensions (not just sqs/word-count)

tjkandala

comment created time in 7 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

Here is a fun one for the next of us who looks at this: toggling between tabs in settings messes up the order of the breadcrumbs:

Kapture 2020-07-31 at 15 05 42

So does the initial load of the Tags page.

marekweb

comment created time in 7 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

@eseliger my implementation is remarkably close to yours https://sourcegraph.com/github.com/sourcegraph/sourcegraph@4713f2b5acfa4c40cbdc4f4cfc4353a93ddb041a/-/blob/shared/src/hover/useHoverifier.ts?subtree=true

Position events are correctly detected on code views, but they are never resolved / getHover() is never called... Probably something dumb, I'll take another look at that branch soon.

@marekweb @felixfbecker the last Portal contribution to convert is the one in routes.tsx -- all other Repository* components now use pushBreadcrumb()

marekweb

comment created time in 7 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 8b4586c8e1b6d60089a9a3bf47f839943c548b77

Fix RepositoryCommitsPage

view details

push time in 7 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha f420705bac58705f6f3be8983fbd4cadb33a00de

Use pushBreadcrumb in RepositoryCommitsPage

view details

push time in 7 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

I got down a bit of a rabbithole converting RepositoryCompareArea to a function component (the hoverifier wouldn't cooperate). So -- for reference, here's how you use pushBreadcrumb in a class component 😄 : https://github.com/sourcegraph/sourcegraph/pull/12536/commits/c2c20374dc75412a8982fe76d0a862a6cf6ceba9

Also was still seeing duplicate branch selectors showing up -- fixed it with this cc @marekweb: https://github.com/sourcegraph/sourcegraph/pull/12536/commits/ac11ad28cd1e6c3b12108cc17855d32a947112b8

marekweb

comment created time in 7 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha ac11ad28cd1e6c3b12108cc17855d32a947112b8

Return pushBreadcrumb from RepoRevisionContainer

view details

push time in 7 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha c2c20374dc75412a8982fe76d0a862a6cf6ceba9

Use pushBreadcrumb in RepositoryCompareArea

view details

push time in 7 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

RepoHeader now contributes the repo name / repository dropdown through pushBreadcrumb instead of the contributions portal: 604cb3a 🎉

Now working on converting RepositoryCompareArea.

marekweb

comment created time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha d0c80b801c2622b3d1196731c214e991484365da

Don't break Rules of Hooks in RepoRevisionContainer

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 604cb3ac6a25b4460ba7146d875118d4caebfc75

RepoHeader pushes a breadcrumb

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha fec1873dda765c4e18264fd029c8dc4edeaf8c08

RepoHeader pushes a breadcrumb

view details

push time in 8 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

fa57d0f fixes the "infinite loop if pushBreadcrumb is in dependencies" problem. It should also fix @marekweb's problem of breadcrumbs not getting removed.

marekweb

comment created time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha fa57d0fa6a9b05c9e7ed48618ab6b7287629722b

Use callback form for setBreadcrumbs

view details

push time in 8 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

Regarding this:

What is the right Figma-to-CSS process here -- do we already have styles for the sub-components like the h1 or badge? For now in the PageHeader, I naively copied the header from the Insights Page so it's a starting point, but not yet styled according to the Figma designs.

  • Badge styles were updated by @felixfbecker in https://github.com/sourcegraph/sourcegraph/pull/12390
  • For the header, let's try to compose as much as possible from existing utility classes (for margins, layout, etc.). I'm not sure about the h1 -- if it doesn't match our existing styles for .h1 / <h1>, does it match web content styles? Or is it different from both of those? If so, that might be something we'll want to review with design.
marekweb

comment created time in 8 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

I converted a couple more pages, and noticed an issue with our useBreadcrumbs() hook: adding pushBreadcrumbs to the useEffect() dependencies array causes infinite render cycles.

useEffect(() => pushBreadcrumb('Something'), [pushBreadcrumb]) // no bueno
marekweb

comment created time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha ef457a57d482796522762cfed5023ec71706168f

Convert RepoSettingsArea, RepositoryStatsArea

view details

push time in 8 days

push eventsourcegraph/about

Loïc Guychard

commit sha 60cb987bef9b303fe1df0fda55bcf3f341cf2b43

Add docs for class->function component conversion (#1306)

view details

push time in 8 days

delete branch sourcegraph/about

delete branch : lg/function-component-conversion-guidelines

delete time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha fb73fcc9927011992081418f6eb6d805a4a5d454

Remove props from deps

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 30911c85bd2b44453d23bed202503ce0bfeb9d7b

RepoRevisionContainer to function component

view details

push time in 8 days

delete branch sourcegraph/about

delete branch : lg/generalize-onboarding

delete time in 8 days

push eventsourcegraph/about

Loïc Guychard

commit sha 2dd6e6214114aca326287b04a4e6db8a470f21f8

Generalize onboarding process (#1289) As discussed during the product/eng manager sync, lifts up the new web onboarding process to apply to all new engineering hires.

view details

push time in 8 days

PR merged sourcegraph/about

Reviewers
Generalize onboarding process

As discussed during the product/eng manager sync, lifts up the new web onboarding process to apply to all new engineering hires.

+82 -118

0 comment

3 changed files

lguychard

pr closed time in 8 days

push eventsourcegraph/about

Loïc Guychard

commit sha 44f2ebfe6212e32a210b5ebf475809f5e2f5864f

Update handbook/engineering/languages/typescript.md Co-authored-by: Erik Seliger <erikseliger@me.com>

view details

push time in 8 days

push eventsourcegraph/about

Loïc Guychard

commit sha 09882e348df867e3fd9b5079fc33a1b60a182ad7

Update handbook/engineering/onboarding.md Co-authored-by: Thorsten Ball <mrnugget@gmail.com>

view details

push time in 8 days

push eventsourcegraph/about

Loïc Guychard

commit sha 5ab45fc28ba6bd81f16ebc6f8534c1fe7d42a71b

Add docs for class->function component conversion

view details

push time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 70b6f64e2a16bcdb1d3c85336778f22da05c2c89

Code host integrations: always add utm_source (#12534) Rel. #11447 Ensures we always add `?utm_source=platform_name` to links pointing back to the Sourcegraph instance from code host integrations, where the platform name is one of: `firefox-extension`, `chrome-extension`, `phabricator-integration`, `bitbucket-integration`, `gitlab-integration`

view details

push time in 8 days

delete branch sourcegraph/sourcegraph

delete branch : lg/open-on-sourcegraph-utm-source

delete time in 8 days

PR merged sourcegraph/sourcegraph

Code host integrations: always add utm_source

Rel. #11447

Ensures we always add ?utm_source=platform_name to links pointing back to the Sourcegraph instance from code host integrations, where the platform name is one of:

firefox-extension, chrome-extension, phabricator-integration, bitbucket-integration, gitlab-integration

As a side-effect, simplifies <OpenOnSourcegraph/> and cleans up OpenInSourcegraphProps to remove unused properties.

+22 -71

2 comments

6 changed files

lguychard

pr closed time in 8 days

create barnchsourcegraph/about

branch : lg/function-component-conversion-guidelines

created branch time in 8 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 24d4d80c3c5b38f556ee5609775aca63815069b7

Convert RepoContainer to function component (#12552)

view details

push time in 9 days

delete branch sourcegraph/sourcegraph

delete branch : lg/convert-repo-container

delete time in 9 days

PR merged sourcegraph/sourcegraph

Convert RepoContainer to function component

Necessary to allow us to use useBreadcrumbs() from <RepoContainer>. It also makes the component quite a bit simpler 😅

The refactor works well in my manual testing, with the exception of the following warning:

Warning: Cannot update a component from inside the function body of a different component.
    in RepoHeader (created by RepoContainer)
    in div (created by RepoContainer)
    in RepoContainer (created by Context.Consumer)

This is due to <RepoHeader/> calling onLifecyclePropsChange() immediately in its constructor. I think we should change that store pattern too...

+240 -353

3 comments

6 changed files

lguychard

pr closed time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 6f9caf57acc28a7811b7915031e0f0eba20add1c

eslint fixes

view details

push time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 64e9977d31d53315c3511781b3dae1faaf83e22e

fix URL tests

view details

push time in 9 days

pull request commentsourcegraph/sourcegraph

Convert RepoContainer to function component

When I navigate to <RepositoryBranchesArea/>, which @marekweb updated to use pushBreadcrumb(), I get no warning (as expected).

lguychard

comment created time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 83937bbac140011b942b574a55ebde323006509e

Fix compile

view details

push time in 9 days

pull request commentsourcegraph/sourcegraph

Convert RepoContainer to function component

I don't think so: the issue here is triggering a state update from a nested component's constructor, which, for React, === 'function body of a different component' , as opposed to useEffect callbacks, event handlers, etc.

Moving the call to componentDidMount() fixes the warning. Similarly, pushBreadcrumb() calls would always be done in a useEffect() callback.

lguychard

comment created time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha fe213f034303dfa1c2dcf3a8afb60dca52dd0a56

Move onLifecyclePropsChange() call to componentDidMount()

view details

push time in 9 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

I converted <RepoContainer/> to a function component to give an example of how that would work (converting componentUpdates patterns to simple useEffect() calls with props as dependencies, using useObservable() where applicable, etc.): https://github.com/sourcegraph/sourcegraph/pull/12552

marekweb

comment created time in 9 days

PR opened sourcegraph/sourcegraph

Convert RepoContainer to function component

Necessary to allow us to use useBreadcrumbs() from <RepoContainer>. It also makes the component quite a bit simpler 😅

The refactor works well in my manual testing, with the exception of the following warning:

Warning: Cannot update a component from inside the function body of a different component.
    in RepoHeader (created by RepoContainer)
    in div (created by RepoContainer)
    in RepoContainer (created by Context.Consumer)

This is due to <RepoHeader/> calling onLifecyclePropsChange() immediately in its constructor. I think we should change that store pattern too...

+223 -349

0 comment

3 changed files

pr created time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 7bb52f2579ccb3009f18f4bd29fc7cba9bf23020

convert RepoContainer to function component

view details

push time in 9 days

create barnchsourcegraph/sourcegraph

branch : lg/convert-repo-container

created branch time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 30152df4c85697f59549a776c2cfba37108ca8d3

update snapshots

view details

push time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha e06be89633a3b29524a09b12a9cf96afcd497657

Add platform to BrowserExtensionConnectedToServer event log (#12535) Rel. #11447 Last piece of the solution to track browser extension usage, for users who never click any injected links or take any code intelligence action, but visit the Sourcegraph instance with the browser extension connected. I could have just added a `browser` argument parsed from the user agent string here, but figured standardizing on the `platform` sent by the browser extension like in other logs (#12533) or utm_sources (#12534) would be better for consistency.

view details

push time in 9 days

delete branch sourcegraph/sourcegraph

delete branch : lg/add-platform-to-browser-extension-connected

delete time in 9 days

PR merged sourcegraph/sourcegraph

Add platform to BrowserExtensionConnectedToServer event log

Rel. #11447

Last piece of the solution to track browser extension usage, for users who never click any injected links or take any code intelligence action, but visit the Sourcegraph instance with the browser extension connected.

I could have just added a browser argument parsed from the user agent string here, but figured standardizing on the platform sent by the browser extension like in other logs (#12533) or utm_sources (#12534) would be better for consistency.

+25 -8

2 comments

4 changed files

lguychard

pr closed time in 9 days

Pull request review commentsourcegraph/about

Generalize onboarding process

 Welcome to Sourcegraph! This document will guide you through engineering specifi   - [Site24x7](https://www.site24x7.com) (optional; recommended for Distribution team members)   - [HoneyComb.io](https://www.honeycomb.io/)   - Ask Christina to send an invite to [Productboard](https://sourcegraph.productboard.com)-- Schedule a recurring [1-1](../leadership/1-1.md).-- Schedule time to discuss Sourcegraph's system architecture and tech stack.-- Schedule a time to discuss on-call rotation.-- Assign one or more starter tasks (e.g. small bugs or issues). -## Engineer checklist+## Weeks 1-3 -As you are completing these tasks, you may notice documentation, processes, or code that is broken or out of date. Your first priority is to fix these things. **Act like you own the onboarding experience of the next engineer that we hire.**+### Starter tasks -- [Complete general onboarding](../people-ops/onboarding.md#for-all-new-teammates)-- [Configure your GitHub notifications.](github-notifications/index.md)-- Message each person on your immediate team to setup a time to meet them. Some things you might want to learn:-  - What brought them to Sourcegraph?-  - What are they currently working on?-  - What do they do for fun?-- Join #dev-announce, #dev-chat, and your team's channel on Slack. [Team chat documentation](../communication/team_chat.md#engineering)+Your manager will assign to you three starter tasks that you should aim to complete in your first three weeks. These tasks are small, atomic, and intended to expose you to different parts of our codebase and product: it's important that you build the flexibility to fix any problem you'll be faced with at Sourcegraph, and don't narrow down your comfort zone to a certain part of our codebase or product.++As you're working on these tasks:

What do you think of this?

As you're working on these tasks:
- Optimize for learning: your priority is to soak up as much context as possible.
lguychard

comment created time in 9 days

Pull request review commentsourcegraph/about

Generalize onboarding process

-# Engineering onboarding+# Onboarding -Welcome to Sourcegraph! This document will guide you through engineering specific onboarding.+Welcome! We're excited to have you join the team. This document outlines the structure of your first few weeks at Sourcegraph. -## Manager checklist+## Guiding principles +### There are no stupid questions++Joining a new company can be overwhelming — there's a lot to learn! As you navigate your first few weeks at Sourcegraph, we want you to know that everyone on the team is here to help, and that there are **no stupid questions**.++Every time you're curious or confused about something — just ask! When you do so, use [public discussion channels](../communication/team_chat.md#avoid_private_messages) as much as possible.++### Think and act like an owner++At Sourcegraph, we don't think of engineers as resources — we think of them as owners of their work, who constantly reevaluate how to use their talents to be as impactful as possible. We value your opinions and ideas. You should always feel empowered to identify potential improvements and act upon them, whether they be improvements to processes (like onboarding), our handbook and general documentation, our codebase and tooling, or our product.++Never assume that a problem is somebody else's to fix!++## Getting set up++You'll have to get some basics set up in your first few days:+- Complete [general onboarding](../people-ops/from-graphbook/onboarding.md#for-all-new-teammates)
- Complete [general onboarding](../people-ops/onboarding/index.md#for-all-new-teammates)
lguychard

comment created time in 9 days

push eventsourcegraph/about

Loïc Guychard

commit sha 6c8442e986e8db743fc19040cb2cccbce06797ba

Update handbook/engineering/onboarding.md

view details

push time in 9 days

pull request commentsourcegraph/sourcegraph

Add platform to BrowserExtensionConnectedToServer event log

Yup, I tested with a dev Sourcegraph instance + browser extension and inspected the event_logs table to make sure the platform was included.

lguychard

comment created time in 9 days

pull request commentsourcegraph/sourcegraph

Use a shared Breadcrumbs component throughout the app

@marekweb I think you might be the one working on this the soonest here. Could you decide what next steps you want to tackle and tell me & @felixfbecker what we should help with?

marekweb

comment created time in 9 days

pull request commentsourcegraph/sourcegraph

Make RepoHeader accept initial contributions as a prop

TODOs stemming from our last session:

  • [ ] Make sure <Breadcrumbs/> matches the styling in figma
  • [ ] Always add Home breadcrumb
  • [ ] Use <Breadcrumbs/> and useBreadcrumbs in place of RepoHeaderContributionPortal in RepoContainer (may require converting components to function components to be able to use the hook)
    • [ ] routes.tsx: add filePath
    • [ ] RepoRevisionContainer: add revision element
    • [ ] RepositoryBranchesArea: add "branches"
    • [ ] RepositoryCommitsPage: add "commits"
    • [ ] RepositoryComparArea: add "compare"
    • [ ] RepositoryReleasesArea: add "Tags"
    • [ ] RepoSettingsArea: add "Settings"
    • [ ] RepoStatsArea: add "Contributors"
  • [ ] Use <Breadcrumbs/> for other page types:
    • [ ] Insights
    • [ ] Campaigns
    • [ ] Extensions
    • [ ] Search
    • [ ] Explore
    • [ ] Query builder
    • [ ] Code statistics
    • [ ] Settings
    • [ ] Organization
  • [ ] Write & use common header component for other page types
marekweb

comment created time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha 43eb673a09d2606fbbcd2e748b13105e50b5e244

Add breadcrumbs hook + component

view details

push time in 9 days

delete branch sourcegraph/sourcegraph

delete branch : lg/add-platform-to-code-host-integration-events

delete time in 9 days

push eventsourcegraph/sourcegraph

Loïc Guychard

commit sha c6ca86f0b63f73a4f4ccd148f35049e45e2be3eb

Add platform to code host integration event logs (#12533) Rel. #11447 Adds platform argument to `CODEHOSTINTEGRATION` events, where platform will be one of: `firefox-extension`, `chrome-extension`, `phabricator-integration`, `bitbucket-integration`, `gitlab-integration`

view details

push time in 9 days

PR merged sourcegraph/sourcegraph

Reviewers
Add platform to code host integration event logs

Rel. #11447

Adds platform argument to CODEHOSTINTEGRATION events, where platform will be one of:

firefox-extension, chrome-extension, phabricator-integration, bitbucket-integration, gitlab-integration

+20 -5

4 comments

3 changed files

lguychard

pr closed time in 9 days

PR opened sourcegraph/sourcegraph

Reviewers
Add platform to BrowserExtensionConnectedToServer event log

Rel. #11447

Last piece of the solution to track browser extension usage, for users who never click any injected links or take any code intelligence action, but visit the Sourcegraph instance with the browser extension connected.

I could have just added a browser argument parsed from the user agent string here, but figured standardizing on the platform sent by the browser extension like in other logs (#12533) or utm_sources (#12534) would be better for consistency.

+25 -8

0 comment

4 changed files

pr created time in 9 days

PR opened sourcegraph/sourcegraph

Code host integrations: always add utm_source

Rel. #11447

Ensures we always add ?utm_source=platform_name to links pointing back to the Sourcegraph instance from code host integrations, where the platform name is one of:

firefox-extension, chrome-extension, phabricator-integration, bitbucket-integration, gitlab-integration

As a side-effect, simplifies <OpenOnSourcegraph/> and cleans up OpenInSourcegraphProps to remove unused properties.

+15 -64

0 comment

5 changed files

pr created time in 9 days

create barnchsourcegraph/sourcegraph

branch : lg/open-on-sourcegraph-utm-source

created branch time in 9 days

PR opened sourcegraph/sourcegraph

Reviewers
Add platform to code host integration event logs

Rel. #11447

Adds platform argument to CODEHOSTINTEGRATION events, where platform will be one of:

firefox-extension, chrome-extension, phabricator-integration, bitbucket-integration, gitlab-integration

+20 -5

0 comment

3 changed files

pr created time in 9 days

push eventsourcegraph/about

Loïc Guychard

commit sha 17d642657d50c821cdd64db4ec59f0c517b032ab

Update handbook/engineering/onboarding.md Co-authored-by: Tomás Senart <tomas@sourcegraph.com>

view details

push time in 9 days

push eventsourcegraph/about

Loïc Guychard

commit sha c4209c70c9fc55781e8ee52192bda7b2bd1a1644

Update handbook/engineering/onboarding.md Co-authored-by: Tomás Senart <tomas@sourcegraph.com>

view details

push time in 9 days

push eventsourcegraph/about

Loïc Guychard

commit sha 8b2decbb01b2d6cbdf44cc062bdca1d061682c4a

Update handbook/engineering/onboarding.md Co-authored-by: Tomás Senart <tomas@sourcegraph.com>

view details

push time in 9 days

issue openedsourcegraph/sourcegraph

Add integration tests for add/update/remove repository actions

We should have frontend integration tests that validate:

  • Adding / editing repositories, manually and with quick actions
  • Verifying the behaviour added in https://github.com/sourcegraph/sourcegraph/pull/11782 for adding / updating / deleting repositories

created time in 10 days

PR opened sourcegraph/about

Reviewers
Generalize onboarding process

As discussed during the product/eng manager sync, lifts up the new web onboarding process to apply to all new engineering hires.

+83 -118

0 comment

3 changed files

pr created time in 10 days

create barnchsourcegraph/about

branch : lg/generalize-onboarding

created branch time in 10 days

push eventsourcegraph/about

Loïc Guychard

commit sha 9e103d22c681b3876e0bf8450c35e33687b7b02b

Update web team handbook page (#1287) - Remove duplicate link to onboarding process - Reflect that TJ has joined the team - Reflect that Simon is no longer part of the team

view details

push time in 11 days

delete branch sourcegraph/about

delete branch : lg/update-web-team-page

delete time in 11 days

PR merged sourcegraph/about

Update web team handbook page
  • Remove duplicate link to onboarding process
  • Reflect that TJ has joined the team
  • Reflect that Simon is no longer part of the team
+1 -4

0 comment

1 changed file

lguychard

pr closed time in 11 days

Pull request review commentsourcegraph/sourcegraph

Fix browser extension broken links when branch is specified

 export const resolveFileInfo = (): BlobInfo => {     const { revisionAndFilePath, rawRepoName } = parsedURL      const filePath = getFilePath()-    const filePathWithLeadingSlash = filePath.startsWith('/') ? filePath : `/${filePath}`+    // Don't prepend empty filePath with slash; it's the root directory of the repo+    const filePathWithLeadingSlash = !filePath ? '' : filePath.startsWith('/') ? filePath : `/${filePath}`
    const filePathWithLeadingSlash = filePath && !filePath.startsWith('/') ? `/${filePath}` : filePath

Nit: I would find this slightly easier to grok with a single ternary operator.

tjkandala

comment created time in 11 days

Pull request review commentsourcegraph/sourcegraph

Fix browser extension broken links when branch is specified

 async function main(): Promise<void> { }  main().catch(console.error.bind(console))+
tjkandala

comment created time in 11 days

Pull request review commentsourcegraph/sourcegraph

Fix browser extension broken links when branch is specified

 if [[ "$OSTYPE" == "linux-gnu" ]]; then   DATA_SOURCE_NAME="postgresql://${PGUSER}:${PGPASSWORD}@${ADJUSTED_HOST}:${PGPORT}/postgres?sslmode=${PGSSLMODE:-disable}" fi -exec docker run --rm -p9187:9187 ${NET_ARG} --name="$CONTAINER" -e DATA_SOURCE_NAME="${DATA_SOURCE_NAME}" ${IMAGE}+exec docker run --rm -p9187:9187 ${NET_ARG} --name="$CONTAINER" -e DATA_SOURCE_NAME="${DATA_SOURCE_NAME}" ${IMAGE}

You probably didn't mean to change this? 🙂

tjkandala

comment created time in 11 days

more