profile
viewpoint
Leonardo Pistone lepistone @spotify Stockholm

push eventlepistone/dotfiles

Leonardo Pistone

commit sha 903f98d3a935488d5d47a40ae656ddad4dfb737b

macos now ships a ncurses with codes for italics

view details

push time in 24 days

push eventlepistone/dotfiles

Leonardo Pistone

commit sha e31ad0e78a64a6f8619d03d563e51816ca074e68

Nowadays recent openssl seems better than libressl

view details

push time in 25 days

push eventlepistone/dotfiles

Leonardo Pistone

commit sha 7980d60387742b075eea69139bc0e208f3c6f2bf

Don't need the hostname in the prompt

view details

push time in a month

push eventlepistone/dotfiles

Leonardo Pistone

commit sha bb4eabb8901b64ae959857fbdaa7feb5c1f46d16

Cleanup casks and vim

view details

Leonardo Pistone

commit sha 8e761ebf8064dacfa74110f4b1b1c23483e20973

shfmt

view details

push time in a month

pull request commentcamptocamp/AIS.py

Gets AIS.py working with pyHanko as a replacement for itext.

First, thank you! I worked on this when I was at Camptocamp, and it's a pleasure to see a contribution.

The general idea of this PR sounds right to me:

Regarding itext, I remember that the choice was a pragmatic one, as we didn't manage to do what wee needed in pure Python at the time. I can imagine that vendoring itext brings licensing issues, and also forking a Java process is not ideal because it's slow and operations are more complicated. If today we can do without itext, sounds great to replace it.

Also running only on recent Pythons sounds like a no-brainer to me. Python 2 is finally gone, and with it the complexity of support both 2 and 3; also there is no much point supporting Python 3s that are not supported upstream.

A couple questions:

  • Do you think that the test coverage is at least similar to before? I don't mean in a strict sense of lines of code, but more overall sense of confidence in the tests compared to before.
  • This change would definitely need a major release, with an update in the History to explain the change from the point of view of the user: API changes, missing features, no more need for itext.

Specifically for my friends at Camptocamp: is the featured removed here - namely signing an existing placeholder - a problem for you?

Daverball

comment created time in a month

push eventlepistone/dotfiles

Leonardo Pistone

commit sha 1ae328ed4ae3bcc5912438021be52b78a2116320

Java17 is out

view details

Leonardo Pistone

commit sha c9527f5863f895a2c2ed5f4f85dbed926e096956

gh config

view details

push time in 2 months

startedGoogleContainerTools/jib

started time in 2 months

PR closed spotify/dns-java

Version bumps
+20 -11

1 comment

2 changed files

flozano

pr closed time in 2 months

pull request commentspotify/dns-java

Version bumps

Many changes (bump of dnsjava, guava, Java 8) superseded by other PRs. Thank you!

flozano

comment created time in 2 months

delete branch spotify/dns-java

delete branch : klaraward-patch-1

delete time in 2 months

PR closed spotify/dns-java

Bump dnsjava to 3.4.1
+1 -1

1 comment

1 changed file

klaraward

pr closed time in 2 months

pull request commentspotify/dns-java

Bump dnsjava to 3.4.1

Superseded by #47. Thank you!

klaraward

comment created time in 2 months

PR closed spotify/dns-java

Bump dnsjava to 3.1.0

Resolves https://github.com/dnsjava/dnsjava/issues/102

+12 -11

1 comment

2 changed files

rschildmeijer

pr closed time in 2 months

pull request commentspotify/dns-java

Bump dnsjava to 3.1.0

Superseded by #47. Thank you!

rschildmeijer

comment created time in 2 months

delete branch spotify/dns-java

delete branch : dependabot/maven/com.google.guava-guava-29.0-jre

delete time in 2 months

push eventspotify/dns-java

dependabot[bot]

commit sha efb38c4b0669c91247d657bd200dfe179a497069

Bump guava from 28.2-jre to 29.0-jre Bumps [guava](https://github.com/google/guava) from 28.2-jre to 29.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Leonardo Pistone

commit sha 7925465f1efb5f76e58e8717d20267aa6913c214

Merge pull request #52 from spotify/dependabot/maven/com.google.guava-guava-29.0-jre Bump guava from 28.2-jre to 29.0-jre

view details

push time in 2 months

PR merged spotify/dns-java

Bump guava from 28.2-jre to 29.0-jre dependencies

Bumps guava from 28.2-jre to 29.0-jre. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/guava/releases">guava's releases</a>.</em></p> <blockquote> <h2>29.0</h2> <h3>Maven</h3> <pre lang="xml"><code><dependency> <groupId>com.google.guava</groupId> <artifactId>guava</artifactId> <version>29.0-jre</version> <!-- or, for Android: --> <version>29.0-android</version> </dependency> </code></pre> <h3>Javadoc</h3> <ul> <li><a href="http://guava.dev/releases/29.0-jre/api/docs/">29.0-jre</a></li> <li><a href="http://guava.dev/releases/29.0-android/api/docs/">29.0-android</a></li> </ul> <h3>JDiff</h3> <ul> <li><a href="http://guava.dev/releases/29.0-jre/api/diffs/">29.0-jre vs. 28.2-jre</a></li> <li><a href="http://guava.dev/releases/29.0-android/api/diffs/">29.0-android vs. 28.2-android</a></li> <li><a href="http://guava.dev/releases/29.0-android/api/androiddiffs/">29.0-android vs. 29.0-jre</a></li> </ul> <h3>Changelog</h3> <ul> <li><a href="https://groups.google.com/d/msg/guava-announce/zHZTFg7YF3o/rQNnwdHeEwAJ">Guava types can no longer be sent over GWT-RPC.</a> To <em>temporarily</em> reenable support, set the <code>guava.gwt.emergency_reenable_rpc</code> system property to <code>true</code>. (5214a10b1e) <ul> <li>This is the only breaking change in this release, and it affects only users of the <code>guava-gwt</code> artifact, not people who use only the <code>guava</code> artifact. This release contains no changes that break <em>binary compatibility</em> for any users.</li> </ul> </li> <li>API documentation for Guava classes is now easier to reach. For example, for <code>ImmutableList</code>, visit <a href="https://guava.dev/ImmutableList">guava.dev/ImmutableList</a>. Also, more easily access the index at <a href="https://guava.dev/api">guava.dev/api</a>.</li> <li><code>collect</code>: Annotated <code>FluentIterable.from(FluentIterable)</code> with <code>@DoNotCall</code>. (b1c77b7df3)</li> <li><code>collect</code>: Made <code>ceiling</code>, <code>floor</code>, <code>headSet(E, boolean)</code>, and <code>tailSet(E, boolean)</code> methods available in the GWT-emulated <code>ImmutableSortedSet</code>. (7e0fe90ca8, 5f2fbf27b2)</li> <li><code>graph</code>: Made it possible to set a stable incident edge order by calling the newly added method <code>[Value]Graph.Builder.incidentEdgeOrder(ElementOrder.stable())</code>. (70164025a8)</li> <li><code>graph</code>: Added <code>incidentEdgeOrder()</code> to the <code>[Value]Graph</code> interfaces. (cde576ec00)</li> <li><code>util.concurrent</code>: Added <code>Duration</code>-based <code>default</code> methods to <code>ListeningScheduledExecutorService</code>. (931e83f969)</li> <li><code>util.concurrent</code>: Added <code>immediateVoidFuture</code>. (9f3bae5853)</li> <li><code>util.concurrent</code>: Removed <code>@Beta</code> from <code>Service</code> and related classes. (dc46627fea)</li> <li><code>util.concurrent</code>: Deprecated the 1-arg overload of <code>ServiceManager.addListener</code>. (86e3620125)</li> <li><code>util.concurrent</code>: Changed the return type of <code>ServiceManager.servicesByState()</code> to <code>ImmutableSetMultimap</code> (but also retained a method with the old signature for binary compatibility). (31999ae6f5)</li> <li><code>util.concurrent</code>: Made it safe to load the <code>AbstractFuture</code> class from a <code>ForkJoinPool</code> thread under a security manager. (6e0c5b5d50)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/google/guava/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

pull request commentspotify/dns-java

Make tests compatible with jdk 8

That's totally fine! I was wondering if the backport of completedFuture is something that previously existed in this repo or if it is new code.

fdfzcq

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentspotify/dns-java

Use LookupSession for async lookups

                     <autoReleaseAfterClose>true</autoReleaseAfterClose>                 </configuration>             </plugin>+            <plugin>+                <groupId>org.apache.maven.plugins</groupId>+                <artifactId>maven-compiler-plugin</artifactId>+                <configuration>+                    <source>10</source>+                    <target>10</target>+                </configuration>+            </plugin>

Why is that?

fdfzcq

comment created time in 3 months

more