profile
viewpoint

akanjain/CS108QuizWebProject 0

Repository for CS108 Web Project

calvinstudebaker/trainingcsinstructors 0

Online Learning Module to help CS instructors teach recursion and get students to talk and participate

danXyu/dazzle 0

Fostering Creativity App @ Stanford University - CS147 Fall Quarter

lenahong/fluentui-react-native 0

A react-native control library aligned with office-ui-fabric-react

lenahong/open-ui 0

A place to play around a little bit with controls to see if there is a better path forward

lenahong/react-native-windows 0

A framework for building native Windows apps with React.

ntindall/reference_games 0

Conventions in iterated reference games

issue closedmicrosoft/react-native-windows

Split UIManager into a separate VS project

The UIManager module is currently built along with the rest of RNWCPP. This task is tracking separating this module into a separate project so we can build other solutions that just bring this component in.

closed time in 2 hours

harinikmsft

issue closedmicrosoft/react-native-windows

Bundled images assets in appxs aren't found

Right now, we hardcode ReactUWP to expect packaged bundles to be in ms-appx://Bundle/{filename}.bundle

The developer passes in {filename}.

So if you run react-native bundle --platform uwp--entry-file index.js --bundle-output Bundle\index.uwp.bundle --assets-dest Bundle to get:

Bundle\
- index.uwp.bundle
  assets\
    - asset1.png
    - asset2.png

However, when loading images, we translate the path file://assets/asset1.png to ms-appx:///assets/asset1.png

closed time in 2 hours

jonthysell

issue closedmicrosoft/react-native-windows

RNW CLI assumes App.windows.js entry point, ignoring existing code

Environment

  1. react-native -v:
react-native-cli: 2.0.1
react-native: 0.59.8
  1. npm ls rnpm-plugin-windows:
`-- rnpm-plugin-windows@0.2.11
  1. npm ls react-native-windows:
`-- react-native-windows@0.59.0-vnext.95
  1. node -v:
v10.15.3
  1. npm -v:
6.10.1

Then, specify:

  • Target Platform Version(s): 10.0.18362

  • Target Device(s): Desktop

  • Visual Studio Version: 2017

  • Build Configuration: Debug

Steps to Reproduce

I reprored with when using the expo-cli but it should be a problem with any existing app. I want add a RNW vnext target using rnpm-plugin-windows.

  1. expo eject
  2. Select "plain" RN project
  3. As per #2808 , I add the missing "name" entry
  4. react-native windows --template vnext
  5. react-native run-windows

Expected Behavior

The new project builds and launches my existing app. It should be smart enough to identify (and refer) any existing entry point:

  • The "main" key in package.json
  • The "entryPoint" key in app.json

Actual Behavior

The generated project both creates an App.windows.js and hardcodes the entry-point to it in the native code.

closed time in 2 hours

jonthysell

issue closedmicrosoft/react-native-windows

Playground app crashes on re-load

  • Native Animation example
  • click on any animation and quickly click the Load button to reload we crash because:
  • we destroy the native module list
  • but then callbacks from javascript come in and are processed. these callbacks have one of their arguments bound to a native module that got destroyed. Arguably at the point where the callbacks bind the module, they should be using a smart pointer to make sure that either the module stays in memory or better yet when it goes away, we know and don't do anything when the callback is triggered.

closed time in 2 hours

asklar

issue closedmicrosoft/react-native-windows

How to handle bundled assets

In the bundle command, there is –bundle-output and also –asserts-dest parameters. Even if I redirect –asserts-dest to Asserts folder, it may still has problem to access the resource. Because the link is file://assets/abc in the bundled file, and the app expect it to be msappx://Assets/abc.

Andrew suggested It's possible to fork the logic in AssetSourceResolver to have it generate the right urls.

I also found an internal commit on this topic: https://github.com/Microsoft/react-native-windows/commit/2812a4506322917709fc6f27ac82f053c2414c4b

closed time in 2 hours

licanhua

issue closedmicrosoft/react-native-windows

Work out how to use XAML codegen in MS.RN

Currently there are a couple of places where we are using XAML markup in MS.RN. In particular the devmenu and redbox. In both these cases we are using markup in a string and calling XamlReader::Load. It would be great if we could use a more normal XAML dev experience with markup, x:Bind etc. However, the normal winrt dev experience requires the XAML file have an idl file, which would add the control to the public interface of the dll. We dont want to add these to the public interface.

closed time in 2 hours

acoates-ms

issue closedmicrosoft/react-native-windows

Re-write Effects.idl using modern IDL

@marlenecota You don't have to do it in this PR, but it looks like Effects.idl is the last file to still use the old IDL style (with HRESULTS, property get / set methods, etc.) which is a pain to parse. Please open an issue to track re-writing the file with modern idl (which of course will mean some changes to the code-behind).

Originally posted by @jonthysell in https://github.com/microsoft/react-native-windows/pull/5521#issuecomment-658964307

closed time in 2 hours

marlenecota

issue closedmicrosoft/react-native-windows

metro complains about missing msedge but msedge is there

image

Edge launches after dismissing the error message

closed time in 2 hours

asklar

pull request commentmicrosoft/react-native-windows

Adding support for politeFocus

@samuelfreiberg looks like a bad merge (1077 changed files / 284 commits) - can you please rebase/resolve?

samuelfreiberg

comment created time in 3 hours

push eventmicrosoft/VerifiableCredential-SDK-Android

beejones

commit sha 52f56536b17eec1caddde06998b741a48527ff9b

Test performance of sign/verify primitives - reference data EllipticCurveSubtleCryptoPerformanceTest TokenSignerPerformanceTest 0 End sign 16182 End verify 89218 End sign 699976 1 End sign 2824 End verify 13399 End sign 594409 2 End sign 3182 End verify 11185 End sign 598249 3 End sign 3827 End verify 12607 End sign 579835 4 End sign 2387 End verify 7474 End sign 525478 5 End sign 2908 End verify 9780 End sign 579169 6 End sign 2721 End verify 7205 End sign 547622 7 End sign 2204 End verify 6016 End sign 531888 8 End sign 1833 End verify 6166 End sign 537859 9 End sign 991 End verify 5266 End sign 568293

view details

push time in 5 hours

push eventmicrosoft/react-native-windows

Ryan Fowler

commit sha 7baf74ec48b7d8d7ab78d9349f95a13272311eb2

Fix second oncreate (#6099) * Don't reload the ReactNativeHost multiple times When OnActivate is called on an already-running instance, the Host should not be reloaded so we don't lose the native modules. * Change files

view details

dependabot-preview[bot]

commit sha 8b851927f5109533d7051aea238d94fe3a260f16

Bump @types/react-native from 0.63.20 to 0.63.22 (#6105) Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.63.20 to 0.63.22. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Nick Gerleman

commit sha f2794dc80cdaf4a83ed782d4d10ec1aad4c05c9e

Rethread After Resuming Timeout Coroutine (#6109) * Rethread After Resuming Timeout Coroutine Fixes #6108 We added thread checks to TestHostHarness which has UI thread affinity. This led to crashes on test timeout instead of a graceful error message, stemmed from our timeout coroutine being resumed on a different thread. The semantics around awaiting a cppwinrt timespan doing a thread jump aren't currently documented. Filed https://github.com/microsoft/cppwinrt/issues/754 since this seems like a sharp edge * Slightly more legible * Do it the cppwinrt way

view details

Nick Gerleman

commit sha 31563b93287b3a5849f956cce73019a36ee4a1e6

Reduce Microsoft.ReactNative PCH By 155MB-260MB (#6114) * Reduce Microsoft.ReactNative PCH By 155MB-260MB We see frequent OOM issues compiling our PCH due to its size. This change removes some of the heavier headers that are included in the PCH to get around XAML codegen issues and instead injects forced header inclusion into the CLCompile items used by XAML codegen. This is quite dirty, but should significantly reduce the increased OOM issues seen since adding these headers. Goes from 1024MB to 869MB for normal builds Goes from 1006 to 740MB for WinUI3 builds * Change files * Remove test code * Remove message * typo

view details

Nick Gerleman

commit sha e18989e41d5daa4fa4cce0e595f79c0526aeb8aa

Free Up Some Memory for react-native-init CI Jobs (#6111) * Free Up Some Memory for react-native-init CI Jobs For the integration test job I discovered we get more reliable builds if we do build-work when daemons are not active. For react-native-init tests, we don't need Verdaccio by the time we're ready to build, so we can kill it to reclaim a bit of memory. Testing locally, Verdaccio without any packages seems to use ~50MB while idle, which is enough to be worth reclaiming, but less than I had hoped for. Not sure if the number would be different when packages are present. * Reconcile with later task

view details

Nick Gerleman

commit sha 89b37d236af1c9d5db7af2d28c2d14d1c3189992

Fix run-windows Warnings Using Node 14 (#6116) * Fix run-windows Warnings Using Node 14 run-windows prints out a large number of warnings on Node 14: ``` $ react-native run-windows √ Auto-linking... Success: No auto-linking changes necessary. (181ms) (node:10936) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (Use `node --trace-warnings ...` to show where the warning was created) (node:10936) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency ``` These come from shelljs, and are fixed in [shelljs 0.8.4](https://github.com/shelljs/shelljs/releases/tag/v0.8.4) * Change files

view details

Nick Gerleman

commit sha 3a41737a788f7ded7e4675d4539ebf619e500156

Remove Special UI When Debugger Attached (#6112) * Remove Special UI When Debugger Attached When discussed internally, we thought this was confusing. These were carryovers from legacy, with the back button espcially odd since we had it before we have a BackHandler. Removing both the debugger only back button, and debugger only frame counter that are automatically added. * Change files

view details

Julio César Rocha

commit sha c10720bde2f53ba3ed50ab93048a585a8377e46b

Use MakeJSQueueThread() for tests. (#6119) * Move Threading types into Shared project. * Use MessageDispatchQueue in DesktopTestRunner. * Remove TestMessageQueueThread. * clang format * Change files * Remove using statements for std:: methods * yarn format * Revert namespace decoration.

view details

React-Native-Windows Bot

commit sha adea129d9420d56902c1a599386fa30615bde0fb

applying package updates ***NO_CI***

view details

dannyvv

commit sha df4cb47be1fcec7b5dc23ec032c0a75b19907d7f

Add integration test for C# Interop (#6118)

view details

dependabot-preview[bot]

commit sha 29d0333424a3e7e174b38e07b4c14fcefd5f845f

Bump @types/react-native from 0.63.22 to 0.63.23 (#6123)

view details

dependabot-preview[bot]

commit sha 192f5353761952005fdadbd98f0a5d76b9350539

Bump beachball from 1.36.1 to 1.36.2 (#6121)

view details

dependabot-preview[bot]

commit sha c5196d191e42d93e01a3a2b5cef069e95e1e2920

Bump @types/ws from 7.2.6 to 7.2.7 (#6122)

view details

Igor Klemenski

commit sha eb13b4761acb4df37b02d75f4296b8a8033db2ec

Integrate RN 7/7 nightly build. (#6120) * integrate RN 7/7 build * Change files Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

Vladimir Morozov

commit sha c2001a2f1caec259a5bcdd81cffa1e524e121f92

Simplify react::uwp::IReactInstance (#5373) * Simplify react::uwp::IReactInstance * Change files * Fix Desktop build break * Format files * Fix RN for Desktop compilation * Fix crash at startup

view details

Vladimir Morozov

commit sha b377a77f3eac4baaa20e738d3f7f80653ddf06ea

Initial ABI-safe JSI implementation (#5461) * Initial ABI-safe JSI implementation * Change files * Format code * Implement strongly typed approach for JSI values * Use strongly type JSI ABI types * Rename IJsiBuffer and JsiDataHandler to IJsiByteBuffer and JsiByteArrayUser * Enable JSI unit tests (most of them fail) * Pass all JSI unit tests * Fix ReactWindows-Desktop.sln compilation * Fix sample project compilation * Fix compilation warnings * Make jsi.cpp not use precompiled header * Fix Microsoft.ReactNative.Cxx project * Fix Playground compilation issues * Fix Microsoft.ReactNative.Cxx compilation in new projects * Remove unnecessary changes * Reduce PCH size to try to avoid out of heap issue * Address PR feedback and update DLL-based deployment * Format code * Fix build breaks after merge

view details

Nick Gerleman

commit sha 64c111f645e82bb4d867d16254c3f6cf48e6dcc1

Add macOS Support to react-native-platform-override (#6117) * Get tests passing * Platform Insensitive Filename Hashing * Allow arbitrary platform extensions in manifest generation script * macOS Tests? * Change files * Add macos-tests-job * Revert rename * Try adding extra indent * Alternate variable syntax * Fix paths * Fix another path * Remove space from name * Add test colors * Print scratch repository info * AZP doesn't like env vars in working directories * Add status logging * Set autocrlf input * Normalize line endings on compare and work around rate limiting * Address feedback and allow token as CLI param * Fix typo

view details

React-Native-Windows Bot

commit sha 2ea78adf523023bb24abaf18653f0d599385bc3e

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha ebb3e4f5c93fd08fd02b7051de8f302d77df5003

Fix issues that cause fast refresh issues in playground app (#6127)

view details

dependabot-preview[bot]

commit sha 1f3ba53c87b68876767a0051e09d023665f4ad0b

Bump @microsoft/api-documenter from 7.8.56 to 7.9.0 (#6133)

view details

push time in 14 hours

push eventmicrosoft/react-native-windows

push time in 14 hours

push eventmicrosoft/react-native-windows

Nick Gerleman

commit sha c9b8c21323575e97fcd51d3748d2974c5acec215

Enable Spellchecker in VSCode

view details

push time in 14 hours

issue closedmicrosoft/react-native-windows

Monorepo page not found when reading the docs

Environment

Not applicable as the issue is with docs source.

Steps To Reproduce

  1. Enter the building-rnw.md page in docs
  2. Try to enter the this page link to read more about Monorepo

Expected Results

Monorepo details for RNW page is open.


404 is received, but the monorepo.md page is available in the docs directory.

closed time in 17 hours

BartoszKlonowski

push eventmicrosoft/react-native-windows

Bartosz Klonowski

commit sha 26eac15f92dca279f78e9280ebe0aa4db9d81749

Fix: monorepo page not found (#6626) When entering the 'building-rnw.md' page, Monorepo is mentioned as a type of RNW. The issue is that when clicking on the "this page" link, 404 is returned instead of redirecting to the monorepo.md page. The root cause of that issue is the capital letter originally used in the link code, while the page itself has a name as: "monorepo.md". This commit provides the fix for that by changing the letter to the correct one, so there's no confusion for newcommers.

view details

push time in 19 hours

PR merged microsoft/react-native-windows

Monorepo page capital letter fix in building-rnw page

This pull request fixes the issue #6625 with monorepo page not found.


The monorepo details page for RNW leads currently to the 404 result, while the monorepo.md page is available in the docs. Changes provided in this PR fix this issue by converting the capital letter used for the monorepo.md page in the building-rnw.md page source code.

Please see the commit message for more details in case of any doubts or questions.


Change has been tested and verified locally.

Microsoft Reviewers: Open in CodeFlow
+1 -1

0 comment

1 changed file

BartoszKlonowski

pr closed time in 19 hours

issue commentmicrosoft/react-native-windows

Support react-native-sketch-canvas

@chrisglein The main repo (terrylinla) is unfortunately not really maintained anymore.

I have a repo that is 2 commits ahead and fixes 2 serious problems on iOS (memory leaks and a fix for onPathChange not being fired on iOS): https://github.com/creambyemute/react-native-sketch-canvas

If this gets implemented for windows, would you either mind doing it on top of my fork (I know, unlikely), grab my 2 commits for iOS, or would there be a chance I'm allowed to grab the windows implementation into my repo?

We're currently re-setting up our RN-Windows platform since VNext came out 💯, there are not many missing parts anymore, this is one of them.

Keep up the fantastic work on RN & RN-Windows 👍, love it!

syedibrahimt

comment created time in 19 hours

issue commentmicrosoft/react-native-windows

run-windows Failed to restore the NuGet packages

@BartoszKlonowski My fault not including my steps in the reply. I did delete node_modules and installed packages with npm install then npx react-native run-windows. Same error.

nerocui

comment created time in 20 hours

issue commentmicrosoft/react-native-windows

run-windows Failed to restore the NuGet packages

@nerocui It's not about Yarn being installed on the machine or not, but about which tool is used as a package installer. Looking at the Steps to reproduce part of your issue, I can see you did not install packages at all, as you are making a new project, but packages are installed by default. What you can do, according to my findings, is:

  • delete all the node_modules (they are downloaded by default when creating the project, but it looks like they should be reinstalled using npm)
  • use npm to install packages npm install
  • build and run the app like always npx react-native run-windows

Please give it a try and share the result, it did solve the same issue on my side.

nerocui

comment created time in 20 hours

issue commentmicrosoft/react-native-windows

run-windows Failed to restore the NuGet packages

@BartoszKlonowski So I do have yarn install on my machine. But I did not use yarn install for installing the packages. I then uninstalled yarn and tried again, still with the same error. So I don't think my issue specifically has anything to do with yarn.

nerocui

comment created time in 21 hours

PR opened microsoft/azuredevopslabs

Change trigger from main to master

The calculator repository has been changed and now uses main instead of master. Update the lab to make the build trigger correctly

+2 -0

0 comment

1 changed file

pr created time in a day

PR opened microsoft/react-native-windows

Monorepo page capital letter fix in building-rnw page

This pull request fixes the issue #6625 with monorepo page not found.


The monorepo details page for RNW leads currently to the 404 result, while the monorepo.md page is available in the docs. Changes provided in this PR fix this issue by converting the capital letter used for the monorepo.md page in the building-rnw.md page source code.

Please see the commit message for more details in case of any doubts or questions.


Change has been tested and verified locally.

+1 -1

0 comment

1 changed file

pr created time in a day

issue openedmicrosoft/react-native-windows

Monorepo page not found when reading the docs

Environment

Not applicable as the issue is with docs source.

Steps To Reproduce

  1. Enter the building-rnw.md page in docs
  2. Try to enter the this page link to read more about Monorepo

Expected Results

Monorepo details for RNW page is open.


404 is received, but the monorepo.md page is available in the docs directory.

created time in a day

push eventmicrosoft/react-native-windows

React-Native-Windows Bot

commit sha d3b7ecbb1c0d5acea17e413733fd22fc7fcce7de

applying package updates ***NO_CI***

view details

push time in a day

issue openedmicrosoft/react-native-windows

Adding react-native-windows to an existing react-native project with expo?

Like the title says, I have an expo app, and I would like to be able to add react-native-windows to it. Following the Get Started docs creates a new blank application, which is not what I am looking for in this case.

What are the proper steps of accomplishing this?

created time in 2 days

issue commentmicrosoft/react-native-windows

RNW 0.64 Release Discussion

If we're mentioning Text borders, let's also mention backgroundColor for it.

NickGerleman

comment created time in 2 days

push eventmicrosoft/react-native-windows

Vladimir Morozov

commit sha 37f158b2e193c0a562fa31665be636f866ceb2a5

Refactor ReactContext API (#6617) * Refactor ReactContext API * Fix playground project * Change files

view details

push time in 2 days

PR merged microsoft/react-native-windows

Reviewers
Refactor ReactContext API AutoMerge

In this PR we refactor changes that were introduced to ReactContext API during the 0.64 development. The goal is to simplify the ReactContext and to allow non-JSI based JS engine API to be used in future.

  • A number of new IReactContext properties were extracted into a new IReactSettingsSnapshot interface and added IReactContext::SettingsSnapshot property to reference them.
  • The IReactContext::JsiRuntime was replaced with IReactContext::JSRuntime that has type Object. It should allow us to replace the JS Engine API with a an IUnknown-based implementation and avoid a hard dependency on the experimental JSI ABI implementation which we plan to remove in favor of another interface.
  • The ReactContext::ExecuteJsi member function is removed and replaced with a standalone function ExecuteJsi in the new "JSI\JsiApi.h" header file.
  • Updated doc comments in the IReactContext.idl
Microsoft Reviewers: Open in CodeFlow
+382 -254

1 comment

19 changed files

vmoroz

pr closed time in 2 days

more