profile
viewpoint
Laura Mosher lauramosher http://lauramosher.com Full-stack software engineer with a passion for clean code and oxford commas.

lauramosher/wicked_pdf_dummy_app 1

Dummy App to test WickedPDF configuration

lauramosher/acme 0

Introducing Phoenix - ElixirConf US 2017 Training Application

lauramosher/centsible 0

Simple Budget App in Rails + React

lauramosher/daisy 0

Remote Starter Kit to bootstrap your day

lauramosher/daisy-slack 0

OAuth 2.0 handshake for Slack

lauramosher/devise_invitable 0

An invitation strategy for devise

lauramosher/faker 0

A library for generating fake data such as names, addresses, and phone numbers.

lauramosher/glsec-nametag-creation 0

Small web based utility to help with GLSEC 2013 name tag creation process.

lauramosher/grmakers-kiosk 0

Online form for members to sign in and store interests and demographic information.

lauramosher/interactor 0

Interactor provides a common interface for performing complex user interactions.

push eventTerrastories/terrastories

kayhide

commit sha 51fa08e69d638d7972e5c1c57a2654e1c1ca8409

Add awesomplete yarn package

view details

kayhide

commit sha d1fda58fdace82022b1e82ba30d65a09c14473d7

Create RegionField using awesomplete

view details

Laura Mosher

commit sha 210683b1c9ef3e45eb6dd4809d4c1943117e9137

Merge pull request #360 from kayhide/354-awesomplete #354 adds awesomplete to add typeahead on admin Places region field.

view details

push time in 5 days

PR merged Terrastories/terrastories

354 awesomplete

When inputing Region field of Place, it shows suggestions. This PR introduces awesomplete as suggested by https://github.com/Terrastories/terrastories/issues/354#issuecomment-544772698 .

It will look like: 5881c82bb3293dc790494ae9cfe7b303

Close #354

+71 -1

2 comments

9 changed files

kayhide

pr closed time in 5 days

issue closedTerrastories/terrastories

Add typeahead fields to admin dashboard for region

On the Place model, we have a String field called "Region".

Currently the admin dashboard for Place allows you to type in any String for that field.

Let's update the UI so that when you start typing into the field, you see a drop down list of matching options that already exist on other Places in the dashboard.

Add an event listener that checks for matches on each keystroke.

If there are no matches, display an option that says "Create new region: <what is being typed>".

Selecting the option should fill the text box, and that should be what is saved to the Place when you submit the form.

For example, if there is a Place with a region Region1, when I create a new Place and start typing in the region field, R should cause a drop down where I will see Region1 as an option. It will stay there until I type Region2 in which case, no matches will show and instead the option will say "Create new region: Region2".

closed time in 5 days

mirandawang

pull request commentTerrastories/terrastories

Fix users search on admin page

Thank you so much for making those updates!!

kayhide

comment created time in 13 days

push eventTerrastories/terrastories

kayhide

commit sha ce220667fe0d8cef6e7838b0a21e05ea8830469a

Fix users search on admin page

view details

Hideaki KAWAI

commit sha 8204aa15b2f0491ecf76b9508ed422fabf1850c4

Update app/dashboards/user_dashboard.rb Co-Authored-By: Laura Mosher <laura.trevisan@gmail.com>

view details

Laura Mosher

commit sha a922ae6d53adffd837227b42b8fb46b34acd0c89

Merge pull request #361 from kayhide/358-fix-users-search Fix users search on admin page

view details

push time in 13 days

PR merged Terrastories/terrastories

Fix users search on admin page

Excluded password field from searching targets.

Fix #358

+1 -1

1 comment

1 changed file

kayhide

pr closed time in 13 days

issue closedTerrastories/terrastories

Users search at admin page is broken

When trying to search users at the admin page, it raises an error.

Searching users with xxxx gives:

ActiveRecord::StatementInvalid at /admin
PG::UndefinedColumn: ERROR:  column users.password does not exist
LINE 1: ...email" AS CHAR(256))) LIKE '%xxxx%' OR LOWER(CAST("users"."p...
                                                             ^
: SELECT  "users".* FROM "users" WHERE (LOWER(CAST("users"."email" AS CHAR(256))) LIKE '%xxxx%' OR LOWER(CAST("users"."password" AS CHAR(256))) LIKE '%xxxx%') LIMIT $1 OFFSET $2

closed time in 13 days

kayhide

Pull request review commentTerrastories/terrastories

354 awesomplete

 {-  "application.js": "/packs/application-af486f9da2bd03b2f827.js",-  "application.js.map": "/packs/application-af486f9da2bd03b2f827.js.map",-  "hello_react.js": "/packs/hello_react-92059456b735f947ccc3.js",-  "hello_react.js.map": "/packs/hello_react-92059456b735f947ccc3.js.map",-  "server_rendering.js": "/packs/server_rendering-9351fec2985378f80fc4.js",-  "server_rendering.js.map": "/packs/server_rendering-9351fec2985378f80fc4.js.map"+  "admin.css": "/packs/admin-09b1baaa93d7b5b11a46c4c3e14dd5ed.css",+  "admin.css.map": "/packs/admin-09b1baaa93d7b5b11a46c4c3e14dd5ed.css.map",+  "admin.js": "/packs/admin-5f957660e60e811c2606.js",+  "admin.js.map": "/packs/admin-5f957660e60e811c2606.js.map",+  "application.js": "/packs/application-7eae212e761099a7bf9c.js",+  "application.js.map": "/packs/application-7eae212e761099a7bf9c.js.map",+  "hello_react.js": "/packs/hello_react-eef241111f0ba15994b0.js",+  "hello_react.js.map": "/packs/hello_react-eef241111f0ba15994b0.js.map",+  "server_rendering.js": "/packs/server_rendering-82fcbc40241baa90e44c.js",+  "server_rendering.js.map": "/packs/server_rendering-82fcbc40241baa90e44c.js.map"

Could you please remove this file entirely? It is blocking a merge (conflict) since we have deleted this file from master as webpack will always generate this for us during deployment (see #380). Apologize for the inconvenience with it 🙈

kayhide

comment created time in 21 days

Pull request review commentTerrastories/terrastories

Fix users search on admin page

 class UserDashboard < Administrate::BaseDashboard     id: Field::Number,     email: Field::String,     role: EnumField,-    password: Field::String,+    password: Field::String.with_options(searchable: false),

Instead of specifying searchable false here, lets take advantage of Administrate's Field::Password type which will do the searchable false configuration by default and be more descriptive of the field attribute type.

    password: Field::Password,
kayhide

comment created time in 21 days

pull request commentTerrastories/terrastories

[#342] Setup 'bundler-audit' gem and fix vulnerabilities

I have reopened these changes in 387. They can be merged as-is with no modification.

Per @MxOliver's issue: I was able to reproduce by doing the following:

  1. Creating container from master.
  2. Shutting container down
  3. Checking out new branch from the revert PR
  4. Restarting the old/existing container before the gem was added
  5. Verified: Container crashed on boot.

However, the Heroku deploy was successful with no build issues.

Since the docker builds the container via the script and it does not automatically take on changes from configuration changes, such as new gems, the error that was encountered is expected and resolved locally using the docker-compose build command. This error is also documented in the FAQ linked from the SETUP guide && common errors & gotchas section.

rgenchev

comment created time in 21 days

pull request commentTerrastories/terrastories

Revert "Revert "[#342] Setup 'bundler-audit' gem and fix vulnerabilities""

This is a revert undoing the change in #386 and redoing the changes in #363.

I've verified that the changes were successfully deploying to heroku && work locally after running a new build to persist the new gem to the containers on the local environment. See the document linked on common errors in https://github.com/Terrastories/terrastories/blob/master/SETUP.md#having-troubles-check-our-common-errors--gotchas

lauramosher

comment created time in 21 days

PR opened Terrastories/terrastories

Revert "Revert "[#342] Setup 'bundler-audit' gem and fix vulnerabilities""

Reverts Terrastories/terrastories#386 && Reopens original PR #342

It looks like the build on Heroku succeeded so I will test this change locally and see if I can reproduce the issue that @MxOliver was having.

+6 -1

0 comment

2 changed files

pr created time in 21 days

delete branch Terrastories/terrastories

delete branch : revert-363-342-setup-bundler-audit-gem-and-fix-vulnerabilities

delete time in 21 days

push eventTerrastories/terrastories

Oliver

commit sha a35f85fe687c1401aca5d467a157ebf1b6317bd5

Revert "[#342] Setup 'bundler-audit' gem and fix vulnerabilities"

view details

Laura Mosher

commit sha 93c4d03515a3e91be5144be1f09be2dc81c24e3e

Merge pull request #386 from Terrastories/revert-363-342-setup-bundler-audit-gem-and-fix-vulnerabilities Revert "[#342] Setup 'bundler-audit' gem and fix vulnerabilities"

view details

push time in 21 days

PR merged Terrastories/terrastories

Revert "[#342] Setup 'bundler-audit' gem and fix vulnerabilities"

Reverts Terrastories/terrastories#363

I merged this PR without checking it locally because it had already been approved (..oops), but it seems like it is causing the terrastories_web_1 container to crash (I reverted to a previous commit locally and was able to run the container). It'd be best to revert this merge and then add the fix to the original PR

+1 -6

1 comment

2 changed files

MxOliver

pr closed time in 21 days

push eventlauramosher/lauramosher.github.io

Laura Mosher

commit sha 3218d3fae43d87ce3a7cd613e26fb3b35aa26472

bundle update

view details

Laura Mosher

commit sha 810c2dad3abd9a1eb065360d91eb7f5643bd291d

Blog Post: Into the Unknown

view details

push time in a month

pull request commentTerrastories/terrastories

Bump loofah from 2.2.3 to 2.3.1

@dependabot merge

dependabot[bot]

comment created time in a month

issue openedactiveadmin/activeadmin

Download Links showing up in Panel

Please follow the guidelines for creating a bug report.

The issue tracker is only for bugs and feature requests. If you need general help please post to StackOverflow.

Expected behavior

What do you think should happen?

When the following is set:

config.namespace :admin do |admin|
  admin.download_links = false
end 

I expect to see no download links anywhere in admin

Actual behavior

What actually happens?

Instead, download links are available with a paginated collection regardless of the disable everywhere configuration set.

How to reproduce

Your best chance of getting this bug looked at quickly is to provide an executable test case demonstrating the expected behavior that is not occurring.

Basic configuration in initializer and my registered resource

# config

ActiveAdmin.setup do |config|
  config.namespace :admin do |admin|
    admin.download_links = false
  end 
end

# admin model

ActiveAdmin.register MyModel do
  show do
    tabs do
      tab "MyTab" do
        paginated_collection do
          table_for collection { .. }
        end
      end
    end
  end
end

Specifying download_links: false when instantiating paginated_collection works as expected, though I would still expect that the component accepts / adheres to the global configuration.

created time in 3 months

push eventgoabstract/abstract-link-loader

Laura Mosher

commit sha a4050e0161108df325da770fbfcea56fb7eca7ac

chore: upgrade sdk upgrades SDK to latest (4.0.1) and updates how the SDK is instantiated also did a general upgrade

view details

Laura Mosher

commit sha 14128f56a3aedd525fe83aab7e7db52c670a57e1

chore: disable write by default sets disableWrite: true to avoid writing to disc by default

view details

push time in 3 months

more