profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/larskissel/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Lars Kissel larskissel @SAP Mainz

push eventSAP/ui5-builder

Lars Kissel

commit sha b5690568f4547ce8065ddf452b2eaa8095265494

[INTERNAL] Add integration test for build task replaceBuildtime

view details

push time in 2 hours

PR opened SAP/ui5-builder

[INTERNAL] Introduce build task replaceBuildtime

Introduce the build task 'replaceBuildtime' used in the LibraryBuilder. It replaces the placeholder ${buildtime} with a current timestamp in the format "YYYYMMDD-HHmm".

JIRA: CPOUI5FOUNDATION-327

+110 -0

0 comment

10 changed files

pr created time in a day

create barnchSAP/ui5-builder

branch : replaceBuildtime

created branch time in a day

push eventSAP/ui5-builder

Lars Kissel

commit sha ba2cb76561afce74a2c0b012c65530034e36af64

[INTERNAL] JSDoc generation: improve basename determination Improve the determination of 'basename' to also support the "module:Namespace/Entity" notation. Trim "module:Namespace/Entity" to "Entity" JIRA: CPOUI5FOUNDATION-386

view details

push time in 15 days

PR merged SAP/ui5-builder

Reviewers
[INTERNAL] JSDoc generation: improve basename determination

Improve the determination of 'basename' to also support the "module:Namespace/Entity" notation. Trim "module:Namespace/Entity" to "Entity"

JIRA: CPOUI5FOUNDATION-386

+4 -1

1 comment

1 changed file

larskissel

pr closed time in 15 days

delete branch SAP/ui5-builder

delete branch : jsdocGenerateBasename

delete time in 15 days

PR opened SAP/ui5-builder

[INTERNAL] JSDoc generation: improve basename determination

Improve the determination of 'basename' to also support the "module:Namespace/Entity" notation. Trim "module:Namespace/Entity" to "Entity"

JIRA: CPOUI5FOUNDATION-386

+4 -1

0 comment

1 changed file

pr created time in 15 days

create barnchSAP/ui5-builder

branch : jsdocGenerateBasename

created branch time in 15 days

PullRequestReviewEvent

push eventSAP/ui5-tooling

Lars Kissel

commit sha 186348ad71185fe1960dae63e41a127b63f5f360

[INTERNAL] Document specVersion 2.5

view details

Lars Kissel

commit sha 5d8368278e289e67be3d3e746e2936a02d75cb6c

[INTERNAL] Apply suggestions from code review - revert mistakenly removal of empty spaces

view details

Merlin Beutlberger

commit sha fff36d2ccb01ec9018f33e015465593096c46ecd

[INTERNAL] SpecVersion 2.5: Document now allowed server configuration for modules

view details

Merlin Beutlberger

commit sha 020c47303f0e7afd0e9657e67231fec160010b52

[INTERNAL] Apply remaining UA review feedback

view details

push time in 2 months

delete branch SAP/ui5-tooling

delete branch : specVersion-2.5

delete time in 2 months

PR merged SAP/ui5-tooling

Reviewers
[INTERNAL] Document specVersion 2.5

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

+79 -52

0 comment

8 changed files

larskissel

pr closed time in 2 months

push eventSAP/ui5-cli

Lars Kissel

commit sha 986368986f1d4f45c174aa9e2628f786bb6cddb6

[INTERNAL] init: Use specVersion 2.5 (#443)

view details

push time in 2 months

delete branch SAP/ui5-cli

delete branch : specVersion-2.5

delete time in 2 months

PR merged SAP/ui5-cli

Reviewers
[INTERNAL] init: Use specVersion 2.5

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

+3 -3

1 comment

2 changed files

larskissel

pr closed time in 2 months

delete branch SAP/ui5-builder

delete branch : specVersion-2.5

delete time in 2 months

push eventSAP/ui5-builder

Lars Kissel

commit sha b471eedbd2b79a10ac87a34cdb321ef22db0dfca

[INTERNAL] TaskUtil: Support specVersion 2.5 (#626)

view details

push time in 2 months

PR merged SAP/ui5-builder

Reviewers
[INTERNAL] TaskUtil: Support specVersion 2.5

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

+27 -0

1 comment

2 changed files

larskissel

pr closed time in 2 months

push eventSAP/ui5-server

Lars Kissel

commit sha c8c98fce225a60d884301a9f046891d7b016465e

[INTERNAL] MiddlewareUtil: Support specVersion 2.5 (#410)

view details

push time in 2 months

delete branch SAP/ui5-server

delete branch : specVersion-2.5

delete time in 2 months

PR merged SAP/ui5-server

Reviewers
[INTERNAL] MiddlewareUtil: Support specVersion 2.5

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

+16 -1

1 comment

3 changed files

larskissel

pr closed time in 2 months

push eventSAP/ui5-project

Lars Kissel

commit sha 3008dace09109ba0fac49f0ddfc79255038f192c

[FEATURE] specVersion 2.5 Adds support for build configuration includeDependency JIRA: CPOUI5FOUNDATION-208

view details

Merlin Beutlberger

commit sha 161dd65c9af2b89eacd8f9d09097e77a2f2e3219

[INTERNAL] Schema: Allow server configuration for type module Resolves: https://github.com/SAP/ui5-tooling/issues/536 JIRA: CPOUI5FOUNDATION-376

view details

push time in 2 months

issue closedSAP/ui5-tooling

Allow `server` configuration with type `module`

Is your feature request related to a problem? Please describe.

I want to use the ui5 cli to serve multiple UI5 apps at once, ideally in a fiori launchpad, with live reload. With type: module, I can mount my apps like this:

resources:
  configuration:
    paths:
      /app1/: app1/webapp
      /app2/: app2/webapp

I try to configure the community live reload extension like this:

server:
  customMiddleware:
  - name: ui5-middleware-livereload
    afterMiddleware: compression
    configuration:
      debug: true
      extraExts: "xml,json,properties"
      port: 35729
      watchPath:
        - app1/webapp
        - app2/webapp

However, this fails the schema validation. However, I can start a server if I don't try to configure it, which makes me feel that either ui5 serve should fail for modules, or I should be able to configure it.

I went ahead and just added the definition in the schema definition in node modules. With this, validation passed and the server came up with the middleware running (and working fine)

Describe the solution you'd like

Please add the server options for type: module.

Describe alternatives you've considered

I've tried to switch to type application, but then I wasn't allowed the path configuration I needed.

Maybe this is beyond the current scope and requires a new module type in the long run, but as a shorter-term solution allowing the middleware would already be great.

Thank you for considering this requeset! Kind regards Lukas

closed time in 2 months

LukasHeimann

delete branch SAP/ui5-project

delete branch : specVersion-2.5

delete time in 2 months

PR merged SAP/ui5-project

Reviewers
[FEATURE] specVersion 2.5

Adds support for build configuration includeDependency

JIRA: CPOUI5FOUNDATION-208

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

+1196 -144

1 comment

26 changed files

larskissel

pr closed time in 2 months

push eventSAP/ui5-cli

Lars Kissel

commit sha 5f941f1e5d3041fc94f2e9e9eed14ad44add78aa

[FEATURE] Support to only build certain dependencies (#442) * [FEATURE] Support to only build certain dependencies Projects can be built with a selection of dependencies that have to be included into the build result. The following CLI parameters can be used flexibly to configure the selection of the dependencies to be built: --include-dependency, --include-dependency-regexp, --include-dependency-tree, --exclude-dependency, --exclude-dependency-regexp, --exclude-dependency-tree JIRA: CPOUI5FOUNDATION-208 * [INTERNAL] Apply suggestions from code review * [INTERNAL] Fix ESlint issue * [INTERNAL] Improve creation of dependency lists, enhance documentation * [INTERNAL] Fix broken test * [INTERNAL] Apply suggestions from code review * [INTERNAL] Improve build command description for option "include-dependency" * [INTERNAL] Improve JSDoc param types * [INTERNAL] Fix JSDoc return types

view details

push time in 2 months

delete branch SAP/ui5-cli

delete branch : buildWithSelectedDependencies

delete time in 2 months

PR merged SAP/ui5-cli

Reviewers
[FEATURE] Support to only build certain dependencies

Projects can be built with a selection of dependencies that have to be included into the build result. The following CLI parameters can be used flexibly to configure the selection of the dependencies to be built: --include-dependency, --include-dependency-regexp, --include-dependency-tree, --exclude-dependency, --exclude-dependency-regexp, --exclude-dependency-tree

JIRA: CPOUI5FOUNDATION-208 Resolves: https://github.com/SAP/ui5-tooling/issues/494

+917 -23

5 comments

4 changed files

larskissel

pr closed time in 2 months

issue closedSAP/ui5-tooling

Option to only build certain dependencies

Expected Behavior

There sould be an posibility to build only certen Dependencies and not onyl all

Current Behavior

it is only possible to ignore some dependencies in dev mode

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 1.2.1

Affected components (if known)

<!-- Check affected components by writing an "X" into the brackets -->

The originated problem is that we have a shim for @babel/polyfill

specVersion: "1.0"
kind: extension
type: project-shim
metadata:
    name: babel-polyfills
shims:
    configurations:
        "@babel/polyfill": # name as defined in package.json
            specVersion: "1.0"
            type: module # Use module type
            metadata:
                name: "babel-polyfills"
            resources:
                configuration:
                    paths:
                        /lib/babel/: "dist"

when building we want to build this shim but not all other dependencies. that way we could just zip the dist folder and upload that to the SAP Gateway

closed time in 2 months

sebbi08

Pull request review commentSAP/ui5-cli

[FEATURE] Support to only build certain dependencies

+const log = require("@ui5/logger").getLogger("cli:utils:buildHelper");++/**+ * Creates an object containing the flattened project dependency tree. Each dependency is defined as an object key while+ * its value is an array of all of its transitive dependencies.+ *+ * @param {object} tree Project tree as generated by the [@ui5/project.normalizer]{@link module:@ui5/project.normalizer}+ * @returns {object<string, string[]>} An object with dependency names as key and each with an array of its transitive+ *   dependencies as value+ */+function getFlattenedDependencyTree(tree) {+	const dependencyInfo = {};++	function _getTransitiveDependencies(project, dependencies) {+		project.dependencies.forEach((dep) => {+			if (!dependencies.includes(dep.metadata.name)) {+				dependencies.push(dep.metadata.name);+				_getTransitiveDependencies(dep, dependencies);+			}+		});+		return dependencies;+	}+	function _processDependencies(project) {+		project.dependencies.forEach((dep) => {+			if (!dependencyInfo[dep.metadata.name]) {+				dependencyInfo[dep.metadata.name] = _getTransitiveDependencies(dep, []);+				_processDependencies(dep);+			}+		});+	}++	_processDependencies(tree);+	return dependencyInfo;+}++/**+ * Creates dependency lists for 'includedDependencies' and 'excludedDependencies'. Regular expressions are directly+ * applied to a list of all project dependencies so that they don't need to be evaluated in later processing steps.+ * Generally, includes are handled with a higher priority than excludes. Additionally, operations for processing+ * transitive dependencies are handled with a lower priority than explicitly mentioned dependencies. The default+ * dependencies set in the build settings are appended in the end.+ *+ * The priority of the various dependency lists is applied in the following order:+ * <ol>+ *   <li>includeDependency, includeDependencyRegExp</li>+ *   <li>excludeDependency, excludeDependencyRegExp</li>+ *   <li>includeDependencyTree</li>+ *   <li>excludeDependencyTree</li>+ *   <li>defaultIncludeDependency, defaultIncludeDependencyRegExp, defaultIncludeDependencyTree</li>+ * </ol>+ *+ * @param {object} parameters Parameters+ * @param {object} parameters.tree Project tree as generated by the+ *   [@ui5/project.normalizer]{@link module:@ui5/project.normalizer}+ * @param {Array.<string>} parameters.includeDependency The dependencies to be considered in 'includedDependencies'; the+ *   "*" character can be used as wildcard for all dependencies and is an alias for the CLI option "--all"+ * @param {Array.<string>} parameters.includeDependencyRegExp Strings which are interpreted as regular expressions+ *   to describe the selection of dependencies to be considered in 'includedDependencies'+ * @param {Array.<string>} parameters.includeDependencyTree The dependencies to be considered in 'includedDependencies';+ *   transitive dependencies are also appended+ * @param {Array.<string>} parameters.excludeDependency The dependencies to be considered in 'excludedDependencies'+ * @param {Array.<string>} parameters.excludeDependencyRegExp Strings which are interpreted as regular expressions+ *   to describe the selection of dependencies to be considered in 'excludedDependencies'+ * @param {Array.<string>} parameters.excludeDependencyTree The dependencies to be considered in 'excludedDependencies';+ *   transitive dependencies are also appended+ * @param {Array.<string>} parameters.defaultIncludeDependency Same as 'includeDependency' parameter; used for build+ *   settings+ * @param {Array.<string>} parameters.defaultIncludeDependencyRegExp Same as 'includeDependencyRegExp' parameter; used+ *   for build settings+ * @param {Array.<string>} parameters.defaultIncludeDependencyTree Same as 'includeDependencyTree' parameter; used for+ *   build settings+ * @returns {object<string, string[]>} An object containing the 'includedDependencies' and 'excludedDependencies'

I just had to revert to the lowercase style because the UI5 Tooling eslint rules doesn't allow the uppercase notation.

larskissel

comment created time in 2 months