profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/lanza/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Nathan Lanza lanza Facebook Menlo Park, California Compiler Engineer @ Facebook, former Theoretical Physicist

apple/swift 55746

The Swift Programming Language

apple/swift-package-manager 8243

The Package Manager for the Swift Programming Language

apple/swift-corelibs-foundation 4246

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-corelibs-xctest 892

The XCTest Project, A Swift core library for providing unit test support

apple/llvm-project 356

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Apple’s stable releases of Clang as well as support the Swift project.

knsamuels/Readr 1

Book Club App

lanza/CMake 1

Mirror of CMake upstream repository

lanza/.config 0

How I like things.

issue commentTimUntersberger/neogit

Neogit doesn't use the user's configured .gitmessages file

I'll add this comment here (since I believe this may be related to the parent issue), but sometimes the message showing which files have been staged for commit doesn't update to reflect which files are actually going to be committed. I don't have a repro for this, but I have noticed in using Neogit over the past few days that if you mix committing using the CLI and with Neogit it will not update the status message.

For example, it will say that I am committing file Foo.rs (which was committed previously) when I am actually committing Bar.rs. It will also the old list of unstaged files from the previous commit, as well. Doesn't seem to consistently happen, but it does once in a while.

I think fixing whatever issue this is might also fix that one, since it's all touching similar code (if I have read this issue correctly).

akinsho

comment created time in 17 hours

issue commentTimUntersberger/neogit

Does rebase feature exist?

Rebasing is planned, but not implemented yet.

Artawower

comment created time in 2 days

issue openedTimUntersberger/neogit

Does rebase feature exist?

Hi! Thanks for your plugin, its very helpfull after magit using. Does rebase from log tree exist/planed?

created time in 2 days

Pull request review commentTimUntersberger/neogit

Split diff

 function M.reduce(tbl, func, ...) end  function M.find(tbl, func)

This probably belongs in a seperate PR, because this was introduced before this PR.

TimUntersberger

comment created time in 2 days

Pull request review commentTimUntersberger/neogit

Split diff

 function M.reduce(tbl, func, ...) end  function M.find(tbl, func)

I don't think we need this module, we can just use plenary/iterators.lua. It is more general because it works on iterators and not tables which is probably faster too.

TimUntersberger

comment created time in 2 days

issue commentTimUntersberger/neogit

Bug on pushing with email&password

Screenshot 2021-04-18 102931

I get this too. I cloned my own repo to another machine over HTTPS, which requires me to enter my github username and password to be able to push.

Setup:

  • NVIM v0.5.0-dev+1260-ga6504ec33
  • WSL2 Linux Ubuntu 20.04

Steps:

  • :Neogit
  • stage all, commit, write commit message, :wq
  • choose push with P, then u for upstream
  • hit the bug

Ty

timsofteng

comment created time in 2 days

pull request commentTimUntersberger/neogit

typo

thanks :grin:

kabouzeid

comment created time in 3 days

push eventTimUntersberger/neogit

Karim Abou Zeid

commit sha 0f5846c6b8c698d5392ce817e4d8580e37a8ebcc

typo

view details

Florian Proksch

commit sha e49801be0a76f8bcc17fc76d41963dd9a0da05f1

Merge pull request #113 from kabouzeid/patch-1 typo

view details

push time in 3 days

PR merged TimUntersberger/neogit

typo
+1 -1

0 comment

1 changed file

kabouzeid

pr closed time in 3 days

PR opened TimUntersberger/neogit

typo
+1 -1

0 comment

1 changed file

pr created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 local cmd_func_map = function ()         status_buffer:close()       end, 0)     end,-    ["Depth1"] = function()-      set_folds({ true, true, false })-    end,-    ["Depth2"] = function()-      set_folds({ false, true, false })-    end,-    ["Depth3"] = function()-      set_folds({ false, false, true })-    end,-    ["Depth4"] = function()-      set_folds({ false, false, false })-    end,+    ["Depth1"] = void(async(function()+      await(set_folds({ true, true, false }))+    end)),+    ["Depth2"] = void(async(function()+      await(set_folds({ false, true, false }))+    end)),+    ["Depth3"] = void(async(function()+      await(set_folds({ false, false, true }))+    end)),+    ["Depth4"] = void(async(function()+      await(set_folds({ false, false, false }))+    end)),

Aaah and it needs to be async because i made the refresh async and forgot to make the set_folds method async too. I was missing something quite big, apparently :sweat_smile:

TimUntersberger

comment created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 function M.reduce(tbl, func, ...) end  function M.find(tbl, func)-  for _, item in ipairs(tbl) do-    if func(item) then return item end+  for i, item in ipairs(tbl) do+    if func(item, i) then return item, i end+  end+  return nil+end++function M.at(tbl, idx)+  for i, item in ipairs(tbl) do+    if i == idx then return item end   end   return nil end

true

TimUntersberger

comment created time in 3 days

push eventTimUntersberger/neogit

TimUntersberger

commit sha 025fbd47517e676fcfa3209c419e6a284430b291

fix: @RianFuro comments

view details

push time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 local cmd_func_map = function ()         status_buffer:close()       end, 0)     end,-    ["Depth1"] = function()-      set_folds({ true, true, false })-    end,-    ["Depth2"] = function()-      set_folds({ false, true, false })-    end,-    ["Depth3"] = function()-      set_folds({ false, false, true })-    end,-    ["Depth4"] = function()-      set_folds({ false, false, false })-    end,+    ["Depth1"] = void(async(function()+      await(set_folds({ true, true, false }))+    end)),+    ["Depth2"] = void(async(function()+      await(set_folds({ false, true, false }))+    end)),+    ["Depth3"] = void(async(function()+      await(set_folds({ false, false, true }))+    end)),+    ["Depth4"] = void(async(function()+      await(set_folds({ false, false, false }))+    end)),

If I don't wrap these functions in async I get the c-bound error.

TimUntersberger

comment created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 local cli = setmetatable({     local calls = {...}     return new_parallel_builder(calls)   end,-  git_root = git_root+  git_root = git_root,+  git_root_sync = void(git_root)

Ah whoops.

TimUntersberger

comment created time in 3 days

issue commentTimUntersberger/neogit

possible to integrate delta?

I'm guessing the feature alok really wants, which I think would be nice as well, is syntax highlighting of the content of diffs. Whether delta is the best tool to provide this within neovim is another question, and I don't know the answer.

The obvious challenge there that I can think of is that the neogit buffer in which you can expand diffs can have any number of various different languages in it.

alok

comment created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 function M.reduce(tbl, func, ...) end  function M.find(tbl, func)-  for _, item in ipairs(tbl) do-    if func(item) then return item end+  for i, item in ipairs(tbl) do+    if func(item, i) then return item, i end+  end+  return nil+end++function M.at(tbl, idx)+  for i, item in ipairs(tbl) do+    if i == idx then return item end   end   return nil end

Is this any different from just doing tbl[idx]? :sweat_smile:

TimUntersberger

comment created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 local cli = setmetatable({     local calls = {...}     return new_parallel_builder(calls)   end,-  git_root = git_root+  git_root = git_root,+  git_root_sync = void(git_root)

This doesn't do anything. void doesn't block until the future completes, it just makes sure it's running to completion sometime in the future. Because of that, it's also not actually returning the result of git_root like that.

TimUntersberger

comment created time in 3 days

Pull request review commentTimUntersberger/neogit

Split diff

 local cmd_func_map = function ()         status_buffer:close()       end, 0)     end,-    ["Depth1"] = function()-      set_folds({ true, true, false })-    end,-    ["Depth2"] = function()-      set_folds({ false, true, false })-    end,-    ["Depth3"] = function()-      set_folds({ false, false, true })-    end,-    ["Depth4"] = function()-      set_folds({ false, false, false })-    end,+    ["Depth1"] = void(async(function()+      await(set_folds({ true, true, false }))+    end)),+    ["Depth2"] = void(async(function()+      await(set_folds({ false, true, false }))+    end)),+    ["Depth3"] = void(async(function()+      await(set_folds({ false, false, true }))+    end)),+    ["Depth4"] = void(async(function()+      await(set_folds({ false, false, false }))+    end)),

This shouldn't change anything afaik. Am I missing something?

TimUntersberger

comment created time in 3 days

push eventTimUntersberger/neogit

TimUntersberger

commit sha 342e5ae937e5c2e93127fa875b140ace342bd482

feat: support custom keybinding for diff view Also adds documentation to README.md

view details

TimUntersberger

commit sha 8dae221b2686192bb8486a99ef608f06439c36c7

fix: make set_folds function async

view details

push time in 3 days

issue commentTimUntersberger/neogit

NeoGitStatus does not respect number

@bigjazzsound is this fixed for you?

bigjazzsound

comment created time in 3 days

push eventTimUntersberger/neogit

TimUntersberger

commit sha dfbf6debef29f9efd9a0b9b9d52affdda92d3a84

feat: support custom keybinding for diff view Also adds documentation to README.md

view details

push time in 3 days

push eventTimUntersberger/neogit

TimUntersberger

commit sha ebbf1d633120aeb6863df6d4aeb7ca2498d05625

feat: export sync version of git_root

view details

TimUntersberger

commit sha 342e5ae937e5c2e93127fa875b140ace342bd482

feat: support custom keybinding for diff view Also adds documentation to README.md

view details

push time in 3 days

push eventTimUntersberger/neogit

TimUntersberger

commit sha 2085b0c588c3b9fcd382d396826892c39708c52e

change: Don't close diff view on save

view details

push time in 3 days

PR opened MaskRay/ccls

v1.1 semantic highlight feature, introduced in specification 3.16.0

Continuation of https://github.com/MaskRay/ccls/pull/740 (fixed TODOs, sprinkled some using and lexicographical comparisons)

I originally sent this as a PR to @jlahoda, but they seem to have lost interest? anyway, I'm willing to take care of this until merged to main branch

+341 -9

0 comment

7 changed files

pr created time in 3 days

push eventTimUntersberger/neogit

Florian Proksch

commit sha dccce0f56d1f9c7e0e7a39da1f34d8b6c3af4255

fix: branching logic in discard operation Renamed the section name checks in discard function to adhere to new structure. Add tests for discard logic to assert current behavior. Closes #112

view details

push time in 3 days

issue closedTimUntersberger/neogit

Unable to discard changes on the whole file

Steps to reproduce:

  1. Make changes in any file. изображение
  2. Press x with cursor on the file изображение.
  3. Confirm: изображение

Expected behavior

File discarded.

Current behavior

File not discarded.

изображение

Additional notes

Discard works on hunks, just fails on the whole files.

closed time in 3 days

Shatur95

issue openedMaskRay/ccls

Using NeoVim LSP with ccls. Is there a way to enable parsing of .ino files?

Using NeoVim LSP with ccls. Is there a way to enable parsing of .ino files? .. whether that's in a .ccls file or via options passed in by neovim/nvim-lspconfig.

created time in 4 days

startedflashlight/flashlight

started time in 4 days

issue openedTimUntersberger/neogit

Unable to discard changes on the whole file

Steps to reproduce:

  1. Make changes in any file. изображение
  2. Press x with cursor on the file изображение.
  3. Confirm: изображение

Expected behavior

File discarded.

Current behavior

File not discarded.

изображение

Additional notes

Discard works on hunks, just fails on the whole files.

created time in 4 days