profile
viewpoint

lame-nickname/comm 0

Communication primitives

lame-nickname/gorm 0

The fantastic ORM library for Golang, aims to be developer friendly.

lame-nickname/hyper 0

An HTTP library for Rust

lame-nickname/pulse 0

A composable wait system.

pull request commentiron/iron

Fix 'examples' and their warnings

hmm, let's ping @phlmn ;)

berlincount

comment created time in 25 days

PR opened iron/iron

A bunch of formatting and getting rid of warnings + updated route-recognizer

This docs.rs issue is due to a bug in the route-recognizer library 0.1 which is still used by router version 0.6. Before I updated the dependency I got rid of a bunch of compiler warnings (description is deprecated), applied clippy suggestions, applied cargo fmt, and reverted the change in #620 which caused the test case added in that PR to fail.

In the commit updating the dependency I also bumped the version of router since some types of the dep are reexported and the behavior regarding route specificity has changed, see https://github.com/http-rs/route-recognizer/issues/20 and https://github.com/http-rs/route-recognizer/issues/21 .

I think this project would benefit from working CI. The current CI seems to be misconfigured (https://app.circleci.com/pipelines/github/iron/iron/1/workflows/275e0a6f-7d53-4250-9b94-873edd7d977b/jobs/311). If there is interest I could have a go at setting up a Github actions based CI.

+564 -346

0 comment

35 changed files

pr created time in 3 months

pull request commentiron/iron

Put query string into request URL

This code seems to be broken. On the current master the added test case fails with:

thread 'request::test::test_request_with_query_string' panicked at 'assertion failed: `(left == right)`
  left: `Some("param=value?param=value")`,
 right: `Some("param=value")`', iron/src/request/mod.rs:238:9
renannprado

comment created time in 3 months

more