profile
viewpoint
OJ Kwon kwonoj Bay Area https://kwonoj.github.io https://twitter.com/_ojkwon

felixrieseberg/electron-windows-notifications 192

:zap: Send native Windows WinRT notifications from Electron

kwonoj/hunspell-asm 41

WebAssembly based Javascript bindings for hunspell spellchecker

kwonoj/electron-hunspell 23

Providing hunspell based spellchecker for Electron applications

kwonoj/cld3-asm 20

WebAssembly based Javascript bindings for google Compact Language Detector v3

anaisbetts/trickline 10

A Fucking Fast Slack Data Model

kwonoj/coveralls-overlay 9

Chrome extension overlay for coveralls

kwonoj/jest-typescript-coverage 9

Manual coverage remapping example for typescript code using jest

kwonoj/hunspell-dict-downloader 6

Hunspell based dictionary downloader for node.js

kwonoj/comlink-electron-adapter 5

Comlink endpoint adapter for Electron's IPC

issue commentReactiveX/rxjs

Executing a cancelled action

I think it's still thing? Haven't checked it recently though.

haf

comment created time in 17 hours

issue openedfullstack-build/tslog

[Question]: disable all colors in `

Description / Use Case for a Feature

lorem ipsum

created time in 2 days

startedKeypirinha/Keypirinha

started time in 4 days

release kwonoj/rx-sandbox

v2.0.0-beta.2

released time in 7 days

created tagkwonoj/rx-sandbox

tagv2.0.0-beta.2

Marble diagram DSL based test suite for RxJS 6

created time in 7 days

delete branch kwonoj/rx-sandbox

delete branch : release-2-b2

delete time in 7 days

push eventkwonoj/rx-sandbox

OJ Kwon

commit sha 8880d2dc7e0748eb7191616628db7ef8ca881b21

build(package): bump up version - BREAKING CHANGES: requires rxjs@7.0.0-beta.8 and above

view details

OJ Kwon

commit sha 595246c4d954eb6d757b175630686679eedda04c

build(release): release 2.0.0-beta.2

view details

OJ Kwon

commit sha 47c25b144aa65091cef6d50826c72cab4b880d6c

Merge pull request #512 from kwonoj/release-2-b2

view details

push time in 7 days

PR merged kwonoj/rx-sandbox

build(release): release 2.0.0-beta.2
+15 -3

1 comment

3 changed files

kwonoj

pr closed time in 7 days

PR opened kwonoj/rx-sandbox

build(release): release 2.0.0-beta.2
+15 -3

0 comment

3 changed files

pr created time in 7 days

create barnchkwonoj/rx-sandbox

branch : release-2-b2

created branch time in 7 days

delete branch kwonoj/rx-sandbox

delete branch : bump-deps

delete time in 7 days

push eventkwonoj/rx-sandbox

OJ Kwon

commit sha fb79bab06436b7475b0d5e7943366b68424697c8

build(package): bump up devdependencies

view details

OJ Kwon

commit sha f23cf4d49afd72fe4b870b57adec9f8c6152ba49

fix(testmessage): update types, rx@7 support

view details

OJ Kwon

commit sha 0b7ecfc33354dbd36b5bd2389d7b27299da1b5cb

build(package): bump up jest-matcher to latest expect pkg

view details

OJ Kwon

commit sha fc6dd382806906265adc5c2b2c8ce30a3f503efa

build(package): bump up devdependencies

view details

OJ Kwon

commit sha ea0eb773d158682634b45a01a6f1e93453a47707

Merge pull request #511 from kwonoj/bump-deps

view details

push time in 7 days

PR merged kwonoj/rx-sandbox

fix(testmessage): update types, rx@7 support

This'll support latest rxjs@7 beta. Note previous versions of rxjs@beta won't be compatible.

+15686 -9078

1 comment

8 changed files

kwonoj

pr closed time in 7 days

PR opened kwonoj/rx-sandbox

fix(testmessage): update types, rx@7 support

This'll support latest rxjs@7 beta. Note previous versions of rxjs@beta won't be compatible.

+15686 -9078

0 comment

8 changed files

pr created time in 7 days

push eventkwonoj/rx-sandbox

OJ Kwon

commit sha fc6dd382806906265adc5c2b2c8ce30a3f503efa

build(package): bump up devdependencies

view details

push time in 7 days

push eventkwonoj/rx-sandbox

OJ Kwon

commit sha 0b7ecfc33354dbd36b5bd2389d7b27299da1b5cb

build(package): bump up jest-matcher to latest expect pkg

view details

OJ Kwon

commit sha 759bb814d80e6444d3751d847425822830d30ef3

build(package): bump up devdependencies

view details

push time in 7 days

create barnchkwonoj/rx-sandbox

branch : bump-deps

created branch time in 7 days

issue closedReactiveX/rxjs

Remove politics from RxJS

Hey. What if we removed politics from RxJS? Wouldn't that be nice? I think so. That would mean removing all the political stuff (BLM front page, etc) and any other political campaign from project.

closed time in 7 days

superherointj

push eventkwonoj/spell-test

OJ Kwon

commit sha 8ae819476bdc0e3288c1ca4c0d20673e5dbad66c

chore(package): initial repro

view details

push time in 8 days

create barnchkwonoj/spell-test

branch : master

created branch time in 8 days

created repositorykwonoj/spell-test

created time in 8 days

push eventkwonoj/rxjs

OJ Kwon

commit sha adbe65e659bbf17f6ab20a9b30fcca0e4d76af9a

fix(withlatestfrom): allow synchronous source (#5828)

view details

Mladen Jakovljević

commit sha f35e622c24445ac9d5631538e2abd748e9c3bbb5

test(TestScheduler): add createTime tests (#5833) * test(TestScheduler): add createTime tests * chore: remove unneeded tests

view details

push time in 11 days

issue commentReactiveX/rxjs

Export an operator subscriber for user-land operators and refine Observable ctor

Some months ago core team meeting had discussed similar to this - make Observable itself as strongly public interfaced one which can create operators, and all of rxjs operator itself try to utilize it to create operators instead of rely on some internals. Discussion concluded we'd like to setup monorepo-ish (yes, again) to make rxjs/Observable itself as explicitly seperated import site operators can import.

In my opinion, regardless of publishing rxjs/observable or not - it may worth to explore these paths in a long run. I wanted to try this after we get concluded how to organize our repo for separated packages. (then we can make observable as internal packages to all operator enforced to follow its public interfaces)

Not directly related, but I guess this is somewhat related topics.

cartant

comment created time in 11 days

issue closedReactiveX/rxjs

Can't read documentation from mobile

When I open site https://rxjs-dev.firebaseapp.com on Android phone I just see non closable BLM screen. wtf? I appreciate your desire to help somebody, but I'm from Ukraine we're here don't care about black or white in the US (we're here don't care about skin colot at all) and I'm sure as well as people in the Russia, or China, or Turkie, or in the many of the Africa countries. To me, BLM it is the local US issue. So why I can not open the documentation on the mobile?

closed time in 13 days

real-artswan

issue commentReactiveX/rxjs

Can't read documentation from mobile

Screenshot_20201017-123421_Chrome Please use menu button. Even before blm banner we had front page and there was menu to access document.

real-artswan

comment created time in 13 days

issue commentReactiveX/rxjs

Standard compliant ES Modules format

We have internal goals to make this happen indeed, but we can't guarantee to align with node 14's LTS or provide specific timeframe. There were couple of attempt to make pkg isomorphic to provide cjs / esm compliant both but it was way tricker with how rxjs is currently packaged.

Draccoz

comment created time in 15 days

delete branch kwonoj/rxjs

delete branch : fix-withlatestfrom-sync

delete time in 15 days

PR opened ReactiveX/rxjs

fix(withlatestfrom): allow synchronous source

<!-- Thank you very much for your pull request!

If your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:

  • [ ] Add the operator to Rx
  • [ ] It must have a -spec.ts tests file covering the canonical corner cases, with marble diagram tests
  • [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases
  • [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image
  • [ ] The operator should be listed in docs_app/content/guide/operators.md in a category of operators
  • [ ] The operator should also be documented. See Documentation Guidelines.
  • [ ] You may need to update MIGRATION.md if the operator differs from the corresponding one in RxJS v4 -->

Description: Attempt to fix #5827 by adjusting subscription order, let source does not complete even before subscribe into other sources.

Related issue (if exists):

+23 -11

0 comment

2 changed files

pr created time in 15 days

create barnchkwonoj/rxjs

branch : fix-withlatestfrom-sync

created branch time in 15 days

issue openedReactiveX/rxjs

withLatestFrom does not emit with synchronous source

Bug Report

https://stackblitz.com/edit/rxjs-bavruf?file=index.ts

of(1, 2, 3)
  .pipe(withLatestFrom(of(4, 5)))
  .subscribe(x => {
    console.log(x);
  });

does not emit anything. Looks like refactored implementation's control flag https://github.com/ReactiveX/rxjs/blob/0b12f1a8f86fa544f4e169f576ae583437de2b96/src/internal/operators/withLatestFrom.ts#L160 and others preventing subscribing into sync sources.

Current Behavior A clear and concise description of the behavior.

Reproduction

  • REPL or Repo link: (you can use https://stackblitz.com/ to create one to attach here)
var your => (code) => here;

Expected behavior A clear and concise description of what you expected to happen (or code).

Environment

  • Runtime: [e.g. Node v${x}, Chrome v${x}]
  • RxJS version:
  • (If bug is related) Loader, build configuration: [e.g webpack, angular-cli version, config]

Possible Solution <!--- Only if you have suggestions on a fix for the bug -->

Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

created time in 15 days

push eventkwonoj/rxjs

OJ Kwon

commit sha 40e7de5494be20ce4e554f9b3d69ed7d429a4931

Merge pull request #5747 from kwonoj/timeout-sync-observable-fix fix(timeout): allow synchronous observable as source

view details

OJ Kwon

commit sha 2d5e4d5bd7b684a912485e1c1583ba3d41c8308e

test(timeout): enable skipped test (#5748)

view details

Jan-Niklas W

commit sha d52c76663201a5d5a160e128dd4ece08ee1a171e

[docs]: Create Deprecation page per deprecation group (#5426) * docs(deprecation): init deprecation section * docs(deprecations): add scheduler deprecation page and adjust deprecation messages * docs(deprecations): remove jsdoc style from deprecation message * chore: fix typos * chore: make changes to address my comments Co-authored-by: Jan-Niklas Wortmann <6104311+JWO719@users.noreply.github.com> Co-authored-by: Nicholas Jamieson <nicholas@cartant.com>

view details

Jan-Niklas W

commit sha 207b704b67cb58137d4148e3f2e61e97eec4f1fb

test: add test to take with passed string as parameter (#5751) Closes #5741 Co-authored-by: Jan-Niklas Wortmann <jan-niklas.wortmann@evorait.com>

view details

Ben Lesh

commit sha d5fd69c123d2232335563eea95c69c07576d079d

fix(throttle): trailing values will now emit after source completes

view details

Ben Lesh

commit sha f80ce894603021777b7b913ca768dc062e2e9e8b

refactor(throttleTime): based off of throttle

view details

Ben Lesh

commit sha e8bf0c23e2e7354768adcf3a8303bd36fff4d74c

refactor(debounceTime): based off of debounce

view details

Ben Lesh

commit sha 66e2de43d646a8736cf2f92391ea86621108c603

refactor(throttleTime): small clean up

view details

Ben Lesh

commit sha 7351587c5ec24447fcf1d3bb927380550c4d57dc

chore: fix lint

view details

Ben Lesh

commit sha 1dab0447a6194606928f67306d3cf5d48d307e3f

chore: update golden files

view details

Nicholas Jamieson

commit sha 985905934e7355b45c531096690ff0a5be86f373

chore: update lint-staged config (#5758)

view details

Ben Lesh

commit sha c2bce754d0779506c1ae1fe6121a6dbece894f44

refactor(mergeMap/mergeScan): unify logic Creates a new `mergeInternals` function that can be used to create a merge-strategy operator, with extensiblity points for accommodating the nuances of each operator. In theory, we could use this in `concatMap`, etc, directly.

view details

Ben Lesh

commit sha 2e057afd3c0dd8447f78a4d909347a4e7ec6047a

chore: remove obvious comment

view details

Ben Lesh

commit sha d10ac7b6cc6d74ed3f480566ade18dcda2fc80da

refactor: remove unnecessary if statement. Co-authored-by: Toni Villena <tonivj5@Gmail.com>

view details

Ben Lesh

commit sha 9ba2b154f1d1fe4856afd0e561c7b1eba16ebf6a

refactor: Unify code that runs `scan` and `reduce`, make reduce a little smaller and more efficient - Creates `scanInternals`, which is a shared operator setup between both operators.

view details

Ben Lesh

commit sha 98a6d0991df2a28366ab8f34098109a67257c235

refactor(count): Base off of `reduce`. BREAKING CHANGE: No longer passes `source` observable as a third argument to the predicate. That feature was rarely used, and of limited value. The workaround is to simply close over the source inside of the function if you need to access it in there.

view details

Ben Lesh

commit sha b3f5cf8d80b2a0e6666d3c017d9e0f3bba753892

refactor(toArray): reduce complexity a little. There was a situation where the `toArray` implementation was relying on a quirk of `reduce` and a trick with the `index` in order to ensure that two subscriptions to the same `toArray`-ed observable would not mutate the same underlying array. This change gets around that problem in a more straight-forward manner, if at the cost of a few bytes.

view details

Ben Lesh

commit sha 3123b670cca9b77919845333952ef70275ed6e90

fix(zip): zip now accepts an array of arguments like its counterparts `forkJoin` and `combineLatest` both allow an array of arguments to be passed to it like so: `forkJoin([a$, b$, c$])`. Now `zip` does the same: `zip([a$, b$, c$])` BREAKING CHANGE: Zipping a single array will now have a different result. This is an extreme corner-case, because it is very unlikely that anyone would want to zip an array with nothing at all.

view details

Ben Lesh

commit sha 076516ef0065cb14196af56cf97e881b7261aed7

refactor: `combineAll` and `zipAll` use shared logic

view details

Ben Lesh

commit sha e0407d3aa0ce494a10a74fc709093a6d1d6da1bf

chore: update golden files

view details

push time in 15 days

created repositorykwonoj/webpack-5-test

created time in 18 days

push eventkwonoj/qmk_firmware

OJ Kwon

commit sha fc3646ed66bdb204e45326d211a2c83c0cedcae3

feat(ergodox): custom layout for ergodox

view details

push time in 18 days

push eventkwonoj/qmk_firmware

MakotoKurauchi

commit sha 2d4ae0fe7b099344b3eca8e1e5506d177f915568

Fix configurator layout helix/rev3_4rows (#10618) Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>

view details

Jan-Frederick Musiol

commit sha 49abff90710a19e1b049ff335efc1073e4732c0d

changed type of process_combo_event argument in tutorial (#10621) in tutorial for combos feature, changed type of compo_index argument of process_combo_event form uint8_t to uint16_t

view details

Takeshi ISHII

commit sha f7e5d712c2adb4ccf16ec52889da41b95d80c6aa

[Docs] Japanese translation of docs/isp_flashing_guide.md (#9896) * start translation docs/ja/isp_flashing_guide.md * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * update docs/ja/isp_flashing_guide.md * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> Co-authored-by: shela <shelaf@users.noreply.github.com> Co-authored-by: Takuya Urakawa <urkwtky@gmail.com>

view details

shela

commit sha c66d65df5824510fd56081def55377415b8e136f

Update Japanese document (#10603)

view details

shela

commit sha 216f9ed2c147b64b0134e33668121f681969aba9

Update Japanese document. (#10589)

view details

shela

commit sha 96ac448a0f9247bf527264b59e624209bfa41ec8

Update feature_bluetooth.md of Japanese document. (#10594) * Update Japanese document. * Left justified. * Update docs/ja/feature_bluetooth.md Co-authored-by: s-show <s1shimz@gmail.com> * Update docs/ja/feature_bluetooth.md Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> Co-authored-by: s-show <s1shimz@gmail.com> Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

view details

shela

commit sha a4efb55a39a882920eb5ff7a2fa94058b1f242d4

Update Japanese document. (#10599)

view details

shela

commit sha 975c2422f34d96270c32d2f13714e5a6aa95a022

Update Japanese document (#10601)

view details

shela

commit sha 3d9fff1d28c892aa906e3f2c7deded19f448ae72

Update Japanese document (#10605)

view details

Ryan

commit sha 6c78f80fa1f56d89ef05e9ba04a6f8f5d3b1e4a2

Partial fix for sendstring_french.h (#10623)

view details

Ryan

commit sha adc06c5b3b537f551557dbbd62f43458f6771db0

Remove bootloader_defs.h for some F072 boards (#10582)

view details

OJ Kwon

commit sha 50b8e898cd712a64ccedaa126e0c7f32233c8b4b

feat(ergodox): custom layout for ergodox

view details

push time in 18 days

push eventkwonoj/qmk_firmware

MakotoKurauchi

commit sha 2d4ae0fe7b099344b3eca8e1e5506d177f915568

Fix configurator layout helix/rev3_4rows (#10618) Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>

view details

Jan-Frederick Musiol

commit sha 49abff90710a19e1b049ff335efc1073e4732c0d

changed type of process_combo_event argument in tutorial (#10621) in tutorial for combos feature, changed type of compo_index argument of process_combo_event form uint8_t to uint16_t

view details

Takeshi ISHII

commit sha f7e5d712c2adb4ccf16ec52889da41b95d80c6aa

[Docs] Japanese translation of docs/isp_flashing_guide.md (#9896) * start translation docs/ja/isp_flashing_guide.md * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * Japanese translation is in progress. * update docs/ja/isp_flashing_guide.md * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md * Update docs/ja/isp_flashing_guide.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> * Update docs/ja/isp_flashing_guide.md Co-authored-by: Takuya Urakawa <urkwtky@gmail.com> Co-authored-by: shela <shelaf@users.noreply.github.com> Co-authored-by: Takuya Urakawa <urkwtky@gmail.com>

view details

shela

commit sha c66d65df5824510fd56081def55377415b8e136f

Update Japanese document (#10603)

view details

shela

commit sha 216f9ed2c147b64b0134e33668121f681969aba9

Update Japanese document. (#10589)

view details

shela

commit sha 96ac448a0f9247bf527264b59e624209bfa41ec8

Update feature_bluetooth.md of Japanese document. (#10594) * Update Japanese document. * Left justified. * Update docs/ja/feature_bluetooth.md Co-authored-by: s-show <s1shimz@gmail.com> * Update docs/ja/feature_bluetooth.md Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> Co-authored-by: s-show <s1shimz@gmail.com> Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

view details

shela

commit sha a4efb55a39a882920eb5ff7a2fa94058b1f242d4

Update Japanese document. (#10599)

view details

shela

commit sha 975c2422f34d96270c32d2f13714e5a6aa95a022

Update Japanese document (#10601)

view details

shela

commit sha 3d9fff1d28c892aa906e3f2c7deded19f448ae72

Update Japanese document (#10605)

view details

Ryan

commit sha 6c78f80fa1f56d89ef05e9ba04a6f8f5d3b1e4a2

Partial fix for sendstring_french.h (#10623)

view details

Ryan

commit sha adc06c5b3b537f551557dbbd62f43458f6771db0

Remove bootloader_defs.h for some F072 boards (#10582)

view details

push time in 18 days

push eventkwonoj/qmk_firmware

Josef Adamčík

commit sha 178649099328b5f40ac4f58c6116a98ba1abf4c3

Fix a typo in README.md Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha ac3d2a3810ad600b1d7909f32fd75bbdaaaec318

Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2f5521cd48f692366d04679357c0f92b4bb36442

Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2a43989d30818feae5e71c505fda721afa8bf19d

Apply suggestions from code review Remove unneeded breaks. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2651edc24347c52093f15a83603515c3d215dca1

Apply suggestions from code review Remove unneeded breaks (few more forgotten ones). Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha f6cec668c7ad623043b0c7796fb599602b41eb75

Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com>

view details

Josef Adamčík

commit sha 22ad35b22575b1ff4a1b68d86a01a25c4a39fa5f

Remove TAPPING_FORCE_HOLD from default keymap.

view details

Josef Adamcik

commit sha fb9425df827400f040c6760eff11c4b980a76a99

Add TAP_CODE_DELAY 10. Fix a typo (compilation error)

view details

Drashna Jaelre

commit sha d0e0202b272a28d6a1e7f0d059396067bb861272

Add query functions for RGB Light and RGB Matrix (#8960) * Add additional query functions for RGBLIGHT * Add additional query functions for RGB Matrix * Change names of enable check functions * Fix macro for rgb matrix takeover of rgblight functions * Add documentation for rgb_matrix_get_hsv() * Add *_get_hsv function to rgblight

view details

Drashna Jaelre

commit sha 4adf4d5a8913d95de638bed52f41686a80145a89

Add SofleKeyboard support to QMK firmware. (#8970) * Add SofleKeyboard support to QMK firmware. * Sofle: Remove LAYOUT_kc macro for default layout. Remove unnecessary code. * Fix mistake in the latest commit * Remove duplicated layers for MAC/WIN support * Improve according to suggestion in PR * Add more improvements from PR * Fix a typo in README.md Co-authored-by: Nick Brassel <nick@tzarc.org> * Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org> * Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Remove unneeded breaks. Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Remove unneeded breaks (few more forgotten ones). Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com> * Remove TAPPING_FORCE_HOLD from default keymap. * Add TAP_CODE_DELAY 10. Fix a typo (compilation error) Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Drashna Jaelre <drashna@live.com>

view details

QMK Bot

commit sha 010c5b12bd0bc4a53abda6d8f9d77de8a7ef1e8f

format code according to conventions [skip ci]

view details

AlisGraveNil

commit sha 4604c70c4c1a0cb2cebc010dba34b04e902bd982

[Keyboard] Add Bookerboard support (#9097) * 5/14/20 first push for bookerboard * Update rules.mk * Update keyboards/clawsome/bookerboard/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/clawsome/bookerboard/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/bookerboard.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/bookerboard.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * 5/15/20 * 2 * 3 * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>

view details

Nick Brassel

commit sha 54b04d96651a166088477ccf513fa534b30b2132

Add SPI 25xx EEPROM support. (#8780)

view details

umi

commit sha f689f043b19ebc8e1d20158b70dac9b64282d736

[Docs] Japanese translation of docs/feature_leader_key.md (#8950) * add feature_leader_key.md translation * update based on comment * set link as lang dir * update based on comment * update based on comment * update based on comment

view details

umi

commit sha b9675d21065b382b4f5652ed17d3c1e7c2e176cb

[Docs] Japanese translation of docs/feature_velocikey.md (#9035) * add feature_velocikey.md translation * update based on comment * update based on comment

view details

umi

commit sha be69dd22e8903b9e2f2d14e7c5bdfd3b912ef29e

[Docs] Japanese translation of docs/feature_thermal_printer.md (#9034) * add feature_thermal_printer.md translation

view details

umi

commit sha 0bece1d44275abe5522eab396efd3acbf2117b44

[Docs] Japanese translation of docs/feature_layouts.md (#8949) * add feature_layouts.md translation * update based on comment * update based on comment

view details

umi

commit sha ee2eb01653a8ba886e75971e710dcc52199935a3

[Docs] Japanese translation of docs/feature_led_matrix.md (#8991) * add feature_led_matrix.md translation * update based on comment * update based on comment

view details

skullY

commit sha fcf150bd820195a169a5de2699cfa1f2d4d3d5a3

Streamline the macos install process

view details

Eric Lau

commit sha 2afb29e095eddfab91dcf1fc06be5fb151d2a5f5

[Keyboard] Add NumDiscipline Keyboard - Modified Version of Discipline With Numpad (#9112) * NumDiscipline firmware compiled * renamed folder, deleted config.h from default * deleted commented out code * fix readme make example for lowercase foldername * Update keyboards/ericrlau/numdiscipline/rev1/rules.mk * Update product name * Apply suggestions from code review - layout naming and key object ordering

view details

push time in 18 days

push eventkwonoj/qmk_firmware

Josef Adamčík

commit sha ac3d2a3810ad600b1d7909f32fd75bbdaaaec318

Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2f5521cd48f692366d04679357c0f92b4bb36442

Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2a43989d30818feae5e71c505fda721afa8bf19d

Apply suggestions from code review Remove unneeded breaks. Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha 2651edc24347c52093f15a83603515c3d215dca1

Apply suggestions from code review Remove unneeded breaks (few more forgotten ones). Co-authored-by: Nick Brassel <nick@tzarc.org>

view details

Josef Adamčík

commit sha f6cec668c7ad623043b0c7796fb599602b41eb75

Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com>

view details

Josef Adamčík

commit sha 22ad35b22575b1ff4a1b68d86a01a25c4a39fa5f

Remove TAPPING_FORCE_HOLD from default keymap.

view details

Josef Adamcik

commit sha fb9425df827400f040c6760eff11c4b980a76a99

Add TAP_CODE_DELAY 10. Fix a typo (compilation error)

view details

Drashna Jaelre

commit sha d0e0202b272a28d6a1e7f0d059396067bb861272

Add query functions for RGB Light and RGB Matrix (#8960) * Add additional query functions for RGBLIGHT * Add additional query functions for RGB Matrix * Change names of enable check functions * Fix macro for rgb matrix takeover of rgblight functions * Add documentation for rgb_matrix_get_hsv() * Add *_get_hsv function to rgblight

view details

Drashna Jaelre

commit sha 4adf4d5a8913d95de638bed52f41686a80145a89

Add SofleKeyboard support to QMK firmware. (#8970) * Add SofleKeyboard support to QMK firmware. * Sofle: Remove LAYOUT_kc macro for default layout. Remove unnecessary code. * Fix mistake in the latest commit * Remove duplicated layers for MAC/WIN support * Improve according to suggestion in PR * Add more improvements from PR * Fix a typo in README.md Co-authored-by: Nick Brassel <nick@tzarc.org> * Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org> * Remove unneeded break. Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Remove unneeded breaks. Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Remove unneeded breaks (few more forgotten ones). Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com> * Remove TAPPING_FORCE_HOLD from default keymap. * Add TAP_CODE_DELAY 10. Fix a typo (compilation error) Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Drashna Jaelre <drashna@live.com>

view details

QMK Bot

commit sha 010c5b12bd0bc4a53abda6d8f9d77de8a7ef1e8f

format code according to conventions [skip ci]

view details

AlisGraveNil

commit sha 4604c70c4c1a0cb2cebc010dba34b04e902bd982

[Keyboard] Add Bookerboard support (#9097) * 5/14/20 first push for bookerboard * Update rules.mk * Update keyboards/clawsome/bookerboard/rules.mk Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/clawsome/bookerboard/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/bookerboard.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/bookerboard.h Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> * 5/15/20 * 2 * 3 * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/clawsome/bookerboard/readme.md Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>

view details

Nick Brassel

commit sha 54b04d96651a166088477ccf513fa534b30b2132

Add SPI 25xx EEPROM support. (#8780)

view details

umi

commit sha f689f043b19ebc8e1d20158b70dac9b64282d736

[Docs] Japanese translation of docs/feature_leader_key.md (#8950) * add feature_leader_key.md translation * update based on comment * set link as lang dir * update based on comment * update based on comment * update based on comment

view details

umi

commit sha b9675d21065b382b4f5652ed17d3c1e7c2e176cb

[Docs] Japanese translation of docs/feature_velocikey.md (#9035) * add feature_velocikey.md translation * update based on comment * update based on comment

view details

umi

commit sha be69dd22e8903b9e2f2d14e7c5bdfd3b912ef29e

[Docs] Japanese translation of docs/feature_thermal_printer.md (#9034) * add feature_thermal_printer.md translation

view details

umi

commit sha 0bece1d44275abe5522eab396efd3acbf2117b44

[Docs] Japanese translation of docs/feature_layouts.md (#8949) * add feature_layouts.md translation * update based on comment * update based on comment

view details

umi

commit sha ee2eb01653a8ba886e75971e710dcc52199935a3

[Docs] Japanese translation of docs/feature_led_matrix.md (#8991) * add feature_led_matrix.md translation * update based on comment * update based on comment

view details

skullY

commit sha fcf150bd820195a169a5de2699cfa1f2d4d3d5a3

Streamline the macos install process

view details

Eric Lau

commit sha 2afb29e095eddfab91dcf1fc06be5fb151d2a5f5

[Keyboard] Add NumDiscipline Keyboard - Modified Version of Discipline With Numpad (#9112) * NumDiscipline firmware compiled * renamed folder, deleted config.h from default * deleted commented out code * fix readme make example for lowercase foldername * Update keyboards/ericrlau/numdiscipline/rev1/rules.mk * Update product name * Apply suggestions from code review - layout naming and key object ordering

view details

moyi4681

commit sha c9d396dd47a1cbecefc45f104a2e7c0ebe2a813e

[Keyboard] add kbdfans/maja rgb keyboard (#9114) * add kbd67 rev2 via support, kbd67mkiirgb small change add kbd67 rev2 via support, kbd67mkiirgb small change * Update keyboards/kbdfans/kbd67/rev2/keymaps/via/keymap.c * Update keyboards/kbdfans/kbd67/rev2/keymaps/via/keymap.c * define DYNAMIC_KEYMAP_LAYER_COUNT 2 * add kbdfans/maja rgb keyboard * Update keyboards/kbdfans/maja/maja.c * Update keyboards/kbdfans/maja/readme.md * Update keyboards/kbdfans/maja/keymaps/default/keymap.c * Update keyboards/kbdfans/maja/maja.h * Update keyboards/kbdfans/maja/maja.c * Update keyboards/kbdfans/maja/keymaps/default/keymap.c * Update keyboards/kbdfans/maja/keymaps/via/keymap.c * Update keyboards/kbdfans/maja/maja.c * Update keyboards/kbdfans/maja/keymaps/via/keymap.c * Update readme.md * Update readme.md * Update keyboards/kbdfans/maja/rules.mk * Update keyboards/kbdfans/maja/keymaps/via/keymap.c * Update keyboards/kbdfans/maja/rules.mk * Update keyboards/kbdfans/maja/rules.mk * Update keyboards/kbdfans/maja/keymaps/default/keymap.c * Update keyboards/kbdfans/maja/keymaps/via/keymap.c * Update keyboards/kbdfans/maja/config.h * Update keyboards/kbdfans/maja/readme.md

view details

push time in 18 days

issue commentReactiveX/rxjs

.d.ts files in dist have .d.ts.map files

I have intentionally included it for better dev experience: with declaration map, tsc server can navigate into source code when user clicks definition. Without it, it'll show d.ts directly with interface only.

cartant

comment created time in 22 days

startedchriswalz/bit

started time in 23 days

startedkbrsh/moon

started time in 23 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch kwonoj/rxjs

delete branch : enable-timeout-skip-test

delete time in a month

push eventkwonoj/rxjs

Ben Lesh

commit sha dad5627fe2f222f2c27c7854275b952f6ce7ef66

refactor: Create new `operate` internal operator creation function resolves #5739

view details

Ben Lesh

commit sha bde8eda09310463b05c5ec7d8a1dd1bafe9dba6f

fix(multicast): and other publish variants will handle errors thrown in a selector appropriately - Also refactors multicast to use the new `operate` mechanism.

view details

Ben Lesh

commit sha cea0caed0f6454aed05b6d9b79e8669456378078

refactor: remove last uses of `wrappedLift`

view details

Ben Lesh

commit sha 7fe82f77ce50d8586acd3bf45a066a324ed6b21d

refactor: remove unused `lift` and `wrappedLift` functions.

view details

Ben Lesh

commit sha b76c734b2b867f39fff03345938fb1899e5184de

refactor(onErrorResumeNext): use OperatorSubscriber, don't return subscription in operate.

view details

Ben Lesh

commit sha 5995e1e1d5121a9355a77d6a5fa9b7665cd2711d

refactor(repeat): Use `OperatorSubscriber`, don't return subscription in `operate`

view details

Ben Lesh

commit sha 68fe1741b0d7e0487ea09d8e432040d51d37c3d9

refactor(retry): Use `OperatorSubscriber`, don't return subscription in `operate`.

view details

Ben Lesh

commit sha 769a29832eef85d03b706f05c72c22bfe208df52

refactor: Don't return subscriber or subscription in `operate` unnecessarily.

view details

Ben Lesh

commit sha 910ac5b8c12189c61236e7e6ca5c25c81636da88

refactor: use optional chaining

view details

Ben Lesh

commit sha 19c5fbbc3136740c82884b820015952fed4e4b7a

refactor(operate): Tweak init return type so Subscribers and Subscriptions can no longer be returned This will help force us to make sure we are using the subscriber and subscription chaining in the most efficient way possible. Although it could result in anti-patterns where users return a function that calls unsubscribe on a subscription if we release this to the public.

view details

Ben Lesh

commit sha 74e500be83382fa4d59f5594855c1a3f6da0fb15

refactor(bufferToggle): rename `liftedSource` to `source`.

view details

Ben Lesh

commit sha 31fd513410c3297b06bf4ea37503627efa0b5b83

chore: fix lint

view details

Ben Lesh

commit sha a0ea0f71543af90285247593998257a9a0c10934

chore(Subscriber): format code

view details

Ben Lesh

commit sha 1b07686a1f79bb5b994ea85795fe3af868f07a4b

refactor(SafeSubscriber): smaller implementation - Also removes unnecessary check to see if the observer was a Subscriber. Subscribers are never passed to SafeSubscriber, so it was unnecessary.

view details

Ben Lesh

commit sha 1222d5a68faa9d3f3c9ad8f8d5db1440971502bd

refactor(tap): Smaller implementation Also optimizes dynamic calls of tap that might not pass any handlers or observers.

view details

Ben Lesh

commit sha 07902ca99ee828521ce238826f10b55e25fbf554

refactor(Subscriber): Massively untangle Subscriber and SafeSubscriber 1. `Subscriber` is just a `Subscriber` now. It doesn't do anything magical to wrap the destination it is handed in a `SafeSubscriber`. 2. `Subscriber.create` returns `SafeSubscriber`. 3. Simplifies logic in `Subscriber` significantly. 4. Adds comments outlining code to be removed when the deprecated next context code is removed. 5. Completely removes `toSubscriber` and related complexity. BREAKING CHANGE: `new Subscriber` no longer takes 0-3 arguments. To create a `Subscriber` with 0-3 arguments, use `Subscriber.create`. However, please note that there is little to no reason that you should be creating `Subscriber` references directly, and `Subscriber.create` and `new Subscriber` are both deprecated.

view details

Ben Lesh

commit sha 0e52a5758696aaaaa9f26f1d5118622a951dfacf

chore: update golden files

view details

Ben Lesh

commit sha 27b6f8f756534ef63be9cfe6fb446abfb5c9cc28

refactor: remove unnecessary else clause. Addresses comment: https://github.com/ReactiveX/rxjs/pull/5745/files/362b0493a7cb36e14d1e2a4bc77d8bcce3db47e1\#r493764091

view details

Ben Lesh

commit sha 02c026ba2a577514d1bc6b128fe3cfe78a8e259a

refactor: Stramline EMPTY_OBSERVER use

view details

Ben Lesh

commit sha f2025d91f22a59f34770bd5faa49bb054eb82986

refactor: update comments and internal names a bit

view details

push time in a month

PR opened ReactiveX/rxjs

test(timeout): enable skipped test

<!-- Thank you very much for your pull request!

If your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:

  • [ ] Add the operator to Rx
  • [ ] It must have a -spec.ts tests file covering the canonical corner cases, with marble diagram tests
  • [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases
  • [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image
  • [ ] The operator should be listed in docs_app/content/guide/operators.md in a category of operators
  • [ ] The operator should also be documented. See Documentation Guidelines.
  • [ ] You may need to update MIGRATION.md if the operator differs from the corresponding one in RxJS v4 -->

Description:

Looks like this test is now passing?

Related issue (if exists):

+1 -2

0 comment

1 changed file

pr created time in a month

create barnchkwonoj/rxjs

branch : enable-timeout-skip-test

created branch time in a month

push eventReactiveX/rxjs

OJ Kwon

commit sha 84c5c0b9d9e0d1791ac2f066c26e462e822d73e1

fix(timeout): allow synchronous observable as source - closes #5746

view details

OJ Kwon

commit sha 40e7de5494be20ce4e554f9b3d69ed7d429a4931

Merge pull request #5747 from kwonoj/timeout-sync-observable-fix fix(timeout): allow synchronous observable as source

view details

push time in a month

delete branch kwonoj/rxjs

delete branch : timeout-sync-observable-fix

delete time in a month

PR merged ReactiveX/rxjs

fix(timeout): allow synchronous observable as source
  • closes #5746

let synchronous subscription do not try to unsubscribe from not yet assigned timer subscription.

<!-- Thank you very much for your pull request!

If your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:

  • [ ] Add the operator to Rx
  • [ ] It must have a -spec.ts tests file covering the canonical corner cases, with marble diagram tests
  • [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases
  • [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image
  • [ ] The operator should be listed in docs_app/content/guide/operators.md in a category of operators
  • [ ] The operator should also be documented. See Documentation Guidelines.
  • [ ] You may need to update MIGRATION.md if the operator differs from the corresponding one in RxJS v4 -->

Description:

Related issue (if exists):

+22 -9

0 comment

4 changed files

kwonoj

pr closed time in a month

issue closedReactiveX/rxjs

timeout() throws exception when source is synchronous

Bug Report

Current Behavior A clear and concise description of the behavior.

Reproduction

  • REPL or Repo link: (you can use https://stackblitz.com/ to create one to attach here)
import {of} from 'rxjs';
import {timeout} from 'rxjs/operators';

of(1).pipe(timeout(100)).subscribe((x) => console.log(x));

This raises

Cannot read property 'unsubscribe' of undefined 

now, previously handled.

Expected behavior A clear and concise description of what you expected to happen (or code).

Environment

  • Runtime: [e.g. Node v${x}, Chrome v${x}]
  • RxJS version:
  • (If bug is related) Loader, build configuration: [e.g webpack, angular-cli version, config]

Possible Solution <!--- Only if you have suggestions on a fix for the bug -->

Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

closed time in a month

kwonoj

push eventkwonoj/rxjs

Ben Lesh

commit sha dad5627fe2f222f2c27c7854275b952f6ce7ef66

refactor: Create new `operate` internal operator creation function resolves #5739

view details

Ben Lesh

commit sha bde8eda09310463b05c5ec7d8a1dd1bafe9dba6f

fix(multicast): and other publish variants will handle errors thrown in a selector appropriately - Also refactors multicast to use the new `operate` mechanism.

view details

Ben Lesh

commit sha cea0caed0f6454aed05b6d9b79e8669456378078

refactor: remove last uses of `wrappedLift`

view details

Ben Lesh

commit sha 7fe82f77ce50d8586acd3bf45a066a324ed6b21d

refactor: remove unused `lift` and `wrappedLift` functions.

view details

Ben Lesh

commit sha b76c734b2b867f39fff03345938fb1899e5184de

refactor(onErrorResumeNext): use OperatorSubscriber, don't return subscription in operate.

view details

Ben Lesh

commit sha 5995e1e1d5121a9355a77d6a5fa9b7665cd2711d

refactor(repeat): Use `OperatorSubscriber`, don't return subscription in `operate`

view details

Ben Lesh

commit sha 68fe1741b0d7e0487ea09d8e432040d51d37c3d9

refactor(retry): Use `OperatorSubscriber`, don't return subscription in `operate`.

view details

Ben Lesh

commit sha 769a29832eef85d03b706f05c72c22bfe208df52

refactor: Don't return subscriber or subscription in `operate` unnecessarily.

view details

Ben Lesh

commit sha 910ac5b8c12189c61236e7e6ca5c25c81636da88

refactor: use optional chaining

view details

Ben Lesh

commit sha 19c5fbbc3136740c82884b820015952fed4e4b7a

refactor(operate): Tweak init return type so Subscribers and Subscriptions can no longer be returned This will help force us to make sure we are using the subscriber and subscription chaining in the most efficient way possible. Although it could result in anti-patterns where users return a function that calls unsubscribe on a subscription if we release this to the public.

view details

Ben Lesh

commit sha 74e500be83382fa4d59f5594855c1a3f6da0fb15

refactor(bufferToggle): rename `liftedSource` to `source`.

view details

Ben Lesh

commit sha 31fd513410c3297b06bf4ea37503627efa0b5b83

chore: fix lint

view details

Ben Lesh

commit sha a0ea0f71543af90285247593998257a9a0c10934

chore(Subscriber): format code

view details

Ben Lesh

commit sha 1b07686a1f79bb5b994ea85795fe3af868f07a4b

refactor(SafeSubscriber): smaller implementation - Also removes unnecessary check to see if the observer was a Subscriber. Subscribers are never passed to SafeSubscriber, so it was unnecessary.

view details

Ben Lesh

commit sha 1222d5a68faa9d3f3c9ad8f8d5db1440971502bd

refactor(tap): Smaller implementation Also optimizes dynamic calls of tap that might not pass any handlers or observers.

view details

Ben Lesh

commit sha 07902ca99ee828521ce238826f10b55e25fbf554

refactor(Subscriber): Massively untangle Subscriber and SafeSubscriber 1. `Subscriber` is just a `Subscriber` now. It doesn't do anything magical to wrap the destination it is handed in a `SafeSubscriber`. 2. `Subscriber.create` returns `SafeSubscriber`. 3. Simplifies logic in `Subscriber` significantly. 4. Adds comments outlining code to be removed when the deprecated next context code is removed. 5. Completely removes `toSubscriber` and related complexity. BREAKING CHANGE: `new Subscriber` no longer takes 0-3 arguments. To create a `Subscriber` with 0-3 arguments, use `Subscriber.create`. However, please note that there is little to no reason that you should be creating `Subscriber` references directly, and `Subscriber.create` and `new Subscriber` are both deprecated.

view details

Ben Lesh

commit sha 0e52a5758696aaaaa9f26f1d5118622a951dfacf

chore: update golden files

view details

Ben Lesh

commit sha 27b6f8f756534ef63be9cfe6fb446abfb5c9cc28

refactor: remove unnecessary else clause. Addresses comment: https://github.com/ReactiveX/rxjs/pull/5745/files/362b0493a7cb36e14d1e2a4bc77d8bcce3db47e1\#r493764091

view details

Ben Lesh

commit sha 02c026ba2a577514d1bc6b128fe3cfe78a8e259a

refactor: Stramline EMPTY_OBSERVER use

view details

Ben Lesh

commit sha f2025d91f22a59f34770bd5faa49bb054eb82986

refactor: update comments and internal names a bit

view details

push time in a month

push eventkwonoj/rxjs

OJ Kwon

commit sha 86c5d2c848ef55374414e4ce59464d4912a10d81

fix(timeout): allow synchronous observable as source - closes #5746

view details

push time in a month

PR opened ReactiveX/rxjs

fix(timeout): allow synchronous observable as source
  • closes #5746

let synchronous subscription do not try to unsubscribe from not yet assigned timer subscription.

<!-- Thank you very much for your pull request!

If your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:

  • [ ] Add the operator to Rx
  • [ ] It must have a -spec.ts tests file covering the canonical corner cases, with marble diagram tests
  • [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases
  • [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image
  • [ ] The operator should be listed in docs_app/content/guide/operators.md in a category of operators
  • [ ] The operator should also be documented. See Documentation Guidelines.
  • [ ] You may need to update MIGRATION.md if the operator differs from the corresponding one in RxJS v4 -->

Description:

Related issue (if exists):

+19 -9

0 comment

4 changed files

pr created time in a month

create barnchkwonoj/rxjs

branch : timeout-sync-observable-fix

created branch time in a month

push eventkwonoj/rxjs

Ben Lesh

commit sha c570750b7856e31eeae6122437cc44863d6d07be

refactor(Observable): simplify subscription and subscriber code (#5703) * refactor(Observable): simplify subscription and subscriber code - Gets rid of weirdness with syncErrorThrowable, et al * chore: update golden files

view details

Ben Lesh

commit sha 09c5605fd009428b7dab6bf2e231cb9d065044d7

Refactor isArray usage (#5709) * refactor: remove isArray utility It is no longer needed in these modern times, and it was a bit of overkill * refactor: centralize common array arg manipulation - Adds utilities for parsing arguments and passing arguments to result selectors that recur throughout the library. * chore: update golden files * chore: address comments

view details

Ben Lesh

commit sha 6416935ab03b38d7048d0641c8826ba5311eae8c

refactor(Subscription): minor size reduction (#5707) - Reduces the size of `Subscription` slightly. - Moves back to a single property for single parent, many parents, scenarios - Updates the type of `Teardown` to not be so loose. `Function` shouldn't be used.

view details

Ben Lesh

commit sha f93fb9c1fb7434c97e1d156370756159c5f2b077

fix(scan): proper indexes when seed is not supplied - Smaller implementation - Improved docs - Adds comments - Adds a test - Fixes weird adjustment in `reduce`. Closes #4348 Closes #3879

view details

Ben Lesh

commit sha 99c7d967f8e278e66432942141705102eb3f06be

refactor(tap): slight size reduction (#5704) * refactor(tap): Slightly reduce the size of tap. - Reduce the size of the tap implementation - Adds more comprehensive documentation (this means more "lines of code" in the PR, but not in the bundle output) - Updates lint rules so null check expressions can be used standalone - Moves chai-related lint rule to the actual spec linting. * refactor: Second pass to further reduce the size and add comments * refactor: even smaller, less nonsense, more comments

view details

Ben Lesh

commit sha 4f210b2fb750f77df506784cbaa372d8efeff676

refactor(combineLatest): remove stankyLift, make smaller (#5711) * refactor(combineLatest): remove stankyLift, make smaller - Refactors one test to make it easier to debug - Removes the use of `stankyLift` for `combineLatestWith`. - Builds `combineAll` from `toArray` and `combineLatest`. I think this has the added benefit if making it more obvious what the operator does for those that read the source. - Refactors implementation of static `combineLatest` to be smaller. I'm hopeful that this refactor will serve as the basis for refactoring other operators with similar issues. * refactor: Use result selector map utility * chore: Address comments

view details

Ben Lesh

commit sha ff1edcf53f020194c045ceddbda8784cac8ce6a1

refactor(bufferTime): reduce the size of the implementation (#5712) * refactor(bufferTime): reduce the size of the implementation - Complete rewrite of `bufferTime` - Adds some comments - Formats a couple of tests for readability during debugging. * fix(bufferTime): ensure proper behavior for buffer creation intervals of 0 - adds a test with comments

view details

Ben Lesh

commit sha 4d8a01b11d16fbba06a46c03f47ee756e1107557

refactor(sequenceEqual): reduce the size of the implementation (#5718) * refactor(sequenceEqual): reduce the size of the implementation - Refactor and comments. - If two sequences are compared in the forest, and no one subscribes, does it make a sound? * chore: address comments

view details

Ben Lesh

commit sha 4d3fc23347f77d11ce6920e24e3bf782a9db4585

refactor(map): reduce the size of the implementation (#5720) - Refactor and add comments BREAKING CHANGE: `thisArg` will now default to `undefined`. The previous default of `MapSubscriber` never made any sense. This will only affect code that calls map with a `function` and references `this` like so: `source.pipe(map(function () { console.log(this); }))`. There wasn't anything useful about doing this, so the breakage is expected to be very minimal. If anything we're no longer leaking an implementation detail.

view details

Ben Lesh

commit sha d50f479dc1399dffde3d331c3ef0e27ec0b853f9

refactor(mergeMap): reduce the size of the implementation (#5715) - Refactor with comments

view details

Nicholas Jamieson

commit sha 6349804352af789704ee0a91d5f2672913459373

chore(fromEvent): add dtslint tests (#5724)

view details

Ben Lesh

commit sha da733775a96d7e6d814edb5e81891f7c0c7b8b10

refactor(groupBy): reduce the size of the implementation - Refactor to make it smaller - Replaced a faulty test with a test that tests the same thing. Verified the behavior has not changed since 6.x.

view details

Ben Lesh

commit sha dc79c3af094f9eb1e5790924d5a249065671810d

refactor: fix up the name, remove the 2

view details

Ben Lesh

commit sha de589fbc257dd1eac49d4660f0b94f06542dc4e1

refactor(throttleTime): reduce the size of the implementation (#5714) * refactor(throttleTime): reduce the size of the implementation - Just a rewrite of the implementation and some comments. * chore: remove unused deps * chore: address comments

view details

Ben Lesh

commit sha ed841b40927f4df522ddb50d1bf6999f9364d829

refactor: smaller still - Centralize all try/catching for next calls.

view details

Nicholas Jamieson

commit sha 7ef0e5e796d0f778543b0d5a6ed5936efb48f559

chore(fromEvent): use more accurate jQuery types (#5726)

view details

Ben Lesh

commit sha 32f961981bec9a32dfa49d2244ab3e4d6e0e4800

refactor: Add OperatorSubscriber, update map - map is smaller

view details

Ben Lesh

commit sha 5a49c1d3e856f5ac07310816b45c47fc3daa6bb9

refactor(filter): smaller - Uses OperatorSubscriber - Much smaller

view details

Ben Lesh

commit sha df84881b57caace794aea5c7d980b2694a80b0cd

refactor(skip): Make implementation smaller - Smaller implementation - Uses OperatorSubscriber

view details

Ben Lesh

commit sha 38739ea710f159efe8e12a25b5f76b9163806ab6

refactor(take): smaller implementation - Removes runtime assertions

view details

push time in a month

issue openedReactiveX/rxjs

timeout() throws exception when source is synchronous

Bug Report

Current Behavior A clear and concise description of the behavior.

Reproduction

  • REPL or Repo link: (you can use https://stackblitz.com/ to create one to attach here)
import {of} from 'rxjs';
import {timeout} from 'rxjs/operators';

of(1).pipe(timeout(100)).subscribe((x) => console.log(x));

This raises

Cannot read property 'unsubscribe' of undefined 

now, previously handled.

Expected behavior A clear and concise description of what you expected to happen (or code).

Environment

  • Runtime: [e.g. Node v${x}, Chrome v${x}]
  • RxJS version:
  • (If bug is related) Loader, build configuration: [e.g webpack, angular-cli version, config]

Possible Solution <!--- Only if you have suggestions on a fix for the bug -->

Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

created time in a month

issue commentReactiveX/rxjs

Take operator not completing if count is a string

I'm not sure if I understood issue correctly, take explicitly requires to supply number https://github.com/ReactiveX/rxjs/blob/master/src/internal/operators/take.ts#L53 . Are you saying it should try to parse given argument as number if string is provided and it's number?

christophbuehler

comment created time in a month

issue commentkwonoj/cld3-asm

Unhandled rejection shut down my service

I don't rethrow: it's runtime behavior in emscripten https://github.com/emscripten-core/emscripten/blob/b1a78891c216c98d90057a358731424ab609f22c/src/shell.js#L190 by default. This seems bit interesting since emscripten sets global handler to any rejection, I may try to see and change behavior but can't promise when / or if I'll do this. My main usecase was using browser env, which this didn't affect.

raphaelboukara

comment created time in a month

delete branch kwonoj/vscode-neovim

delete branch : tree-shaking

delete time in a month

push eventkwonoj/vscode-neovim

OJ Kwon

commit sha cc247eb376d982642499993673e49145f5d28223

build(webpack): enable tree shaking

view details

push time in a month

pull request commentasvetliakov/vscode-neovim

build(webpack): enable tree shaking

Fyi, installing https://www.bundle-analyzer.com/ will allow to check size of bundler per-PR basis.

kwonoj

comment created time in a month

PR opened asvetliakov/vscode-neovim

build(webpack): enable tree shaking

This PR attempts to improve #377 by enablind tree shaking.

To utilize proper tree shaking, PR replaces lodash to esm exports lodash (lodash-es) and updates ts-loader config to webpack properly analyze tree shaking imports.

Size comparison of bundle looks like below:

Previous image

After image

Total bundle size went down from 415 -> 341, among those lodash now takes ~3KB only.

+26 -9

0 comment

5 changed files

pr created time in a month

create barnchkwonoj/vscode-neovim

branch : tree-shaking

created branch time in a month

push eventkwonoj/vscode-neovim

Alexey Svetlyakov

commit sha da5ac3fb7af655bb90e07893912bc812e1b7744d

Fix #153

view details

Alexey Svetlyakov

commit sha 9b09013f20f54e4413e44faef577fd8f9c80c9ff

v0.0.50

view details

Alexey Svetliakov

commit sha 2dce88ebaba0fc4c45559f68a6aed08dabaef513

Create FUNDING.yml

view details

Alexey Svetliakov

commit sha f88479b2c40eec6e3817979dd97cc5f4e1f21663

Update FUNDING.yml

view details

Alexey Svetlyakov

commit sha c585ca4b047efafec9e382610454e51ea38ab155

Force off cursorline, refs #153

view details

Alexey Svetlyakov

commit sha 87314441e3aba082577d811b229c3ffaa97d2150

Merge branch 'master' of https://github.com/asvetliakov/vscode-neovim

view details

Alexey Svetlyakov

commit sha 401642b37af08edcc0bf94feb235546d84e82b4b

Workaround dot-repeat by replaying last changes in separate buffer

view details

Alexey Svetlyakov

commit sha bb047894b895cb1f4b02f41fd0246fab1868db04

Clean some stuff

view details

Tristan Koch

commit sha 4f03f609b3e0e9faa13e58516fe4671775cc64c0

Fix missing <C-w>c mapping Change duplicated mapping presumably caused by typo.

view details

Alexey Svetliakov

commit sha 46692297f6b444b45bc7b2d9ec7e6625497230dc

Merge pull request #180 from trkoch/fix-ctrl-w-c Fix missing <C-w>c mapping

view details

Alexey Svetlyakov

commit sha b3580744c3d20e8ab8267b242c285c673159f5ff

Tests

view details

Alexey Svetliakov

commit sha ba29e88a42a89c7c383ebb9adeac44dea98202a5

Merge pull request #173 from asvetliakov/workaround-dot-repeat-2 Workaround dot-repeat by replaying last changes in separate buffer

view details

Yuxin Wu

commit sha fe443b1bff52bb4ff1cdf623199543e5c66043a8

support completion for basic commands

view details

Alexey Svetliakov

commit sha 15b828f6863c223e8af5639fbd5b5efd7c440ec7

Merge pull request #193 from ppwwyyxx/master support completion for basic commands

view details

Alexey Svetlyakov

commit sha a563847641e4d2cd7003cd5a26c60069be3ca716

Increase neovim viewport width to 1000, make it configurable, refs #187

view details

Alexey Svetlyakov

commit sha 68f056b4c9cb6b2559baa917f8c02166abd86f11

Add abort directive to functions which are using blocking VSCodeCall

view details

Artur Tagisow

commit sha e964601555f41be04d4ec2b9d22c52f5223b54b1

is137 Add settings for operating system specific paths

view details

Artur Tagisow

commit sha 6d489fe7b3bbbb41827f3c3e941fec1dcb5fa9ce

Fix neovim executable path edge case where OSX users used WSL path If isWSL is true, linux path should be used Before this commit, the extension would return a Linux path for an OSX user if useWSL is true Which doesn't makes sense. The useWSL setting should be ignored on OSX

view details

Artur Tagisow

commit sha 3f46884c6c21c1830c1e714cb34e8467716c247f

Fix WSL path being triggered during wrong condition To be honest the behavior of the function is going to be the same, just the condition is more logical

view details

Artur Tagisow

commit sha 1b3db01ad2ddace3a496eec6a9a7010f5122417f

Fix too verbose TypeScript typedefs

view details

push time in a month

startedviebel/klipse

started time in a month

issue closedReactiveX/rxjs

Can we remove the politics from the docs website please?

Documentation Related To Component:

<!-- Type name of component here (e.g. "Contribution.md", or "mergeMap" or "Subject") -->

Please check those that apply

  • [ ] typo
  • [ ] documentation doesn't exist
  • [ ] documentation needs clarification
  • [ ] error(s) in example
  • [ ] needs example

Description Of The Issue

<!-- Describe the issue in detail here -->

closed time in 2 months

aliene-ctrl
PullRequestReviewEvent
PullRequestReviewEvent

push eventkwonoj/rxjs

Valentin Hăloiu

commit sha e1a671cbd7f5a6ce547ed9ee6ce98c22264500f4

fix(WebSocketSubject): close websocket connection attempt on unsubscribe Fix closing the underlying WebSocket when a WebSocketSubject is unsubscribed while the WebSocket is in the `CONNECTING` state. Initial support for closing a WebSocket before it was opened was added in #4446. However, that pull-request still waits for the connection to eventually become open before attempting to close it. This pull-request takes it a step further by closing the websocket as soon as the subject is unsubscribed.

view details

OJ Kwon

commit sha 2ab143f2ff337a2d0cda99a09539ac1f85f57cf7

build(package): move devdeps properly - closes #5565

view details

OJ Kwon

commit sha 45702bf6cd1b4a150f47b2a1d273f1ee31ca2482

Merge pull request #5566 from kwonoj/fix-devdeps build(package): move devdeps properly

view details

OJ Kwon

commit sha 99bd9b939dab7ce908bbb175841f4e393bc3874a

test(type): deprecate legacy type test

view details

OJ Kwon

commit sha 7fc531277390801ee37e6e4b7fb480563c658933

Merge pull request #5567 from kwonoj/deprecate-old-type-test test(type): deprecate legacy type test

view details

Ben Lesh

commit sha 875ba483fcf795fd4b32d497233798ab705a81b8

Prettier (#5552) * chore: add prettier * chore: start using prettier * chore(lint): update tslint to work with prettier This is just to get everything to work as-it-was, I really want to remove most of these rule overrides ASAP, and also move to eslint * chore: prettify Observable as a test

view details

Ben Lesh

commit sha 9adaa94a72b16f24e1814a0434224630855e895b

chore(publish): 7.0.0-beta.2

view details

Ben Lesh

commit sha 76cfca2505bb2c9c23fc6268770a5d51bfa707fa

Merge branch 'master' of github.com:ReactiveX/rxjs

view details

Ben Lesh

commit sha 356bbd6e881e983101f69848b5a6d9ae9658dfa4

test(Observable): add skipped test for edge case (#5563) * test(Observable): add skipped test for edge case related #5370 * chore: fix lint

view details

Ben Lesh

commit sha 82fc5993d4404b987d77f216bd2f7c592e4de952

docs: Add the start of a glossary (#5564) * docs: Add the start of a glossary * docs(glossary): add streaming, and address comments

view details

Ben Lesh

commit sha 12d75e14831af7bc5a9de14fd322d96b7b18c87f

docs: fix broken link

view details

Ben Lesh

commit sha d36ab15e7f610cf535dfb3deb06c0219619b6aab

docs: fix broken link

view details

Ben Lesh

commit sha 255ef7abd3fa21b70e6653cc5b6ff6a3bb65c173

docs(glossary): Add table of contents

view details

Ben Lesh

commit sha f1d59727af1bafff950c9b4f6edb52be85cb4b8d

docs(glossary): add pull and push

view details

Ben Lesh

commit sha 144b626c3905640b4adeb2b97e722912eff1b264

refactor(Observable): Update property and method types (#5572) - Removes `_isScalar` as it was unused - makes `lift` `protected`. This is an internal implementation detail. - makes `source` `protected`, this is an internal implementation detail. - Refactors operators to use new utility functions that do the lift or provide a reasonable error if the observable someone is trying to use with the operator does not have a lift method. Adds documentation. BREAKING CHANGE: `lift` no longer exposed. It was _NEVER_ documented that end users of the library should be creating operators using `lift`. Lift has a [variety of issues](https://github.com/ReactiveX/rxjs/issues/5431) and was always an internal implementation detail of rxjs that might have been used by a few power users in the early days when it had the most value. The value of `lift`, originally, was that subclassed `Observable`s would compose through all operators that implemented lift. The reality is that feature is not widely known, used, or supported, and it was never documented as it was very experimental when it was first added. Until the end of v7, `lift` will remain on Observable. Standard JavaScript users will notice no difference. However, TypeScript users might see complaints about `lift` not being a member of observable. To workaround this issue there are two things you can do: 1. Rewrite your operators as [outlined in the documentation](https://rxjs.dev/guide/operators), such that they return `new Observable`. or 2. cast your observable as `any` and access `lift` that way. Method 1 is recommended if you do not want things to break when we move to version 8.

view details

OJ Kwon

commit sha 3be98404fafd5a8de758deb4e0d103a7b60aa31e

fix(timeout): defer error creation until timeout occurs (#5497) - closes #5491

view details

Ben Lesh

commit sha bb39c3c1bdd3ce0561ac616b5fcee4a14aa300ab

Run mode updates 1 (#5551) * chore: Update to run mode tests * chore: run mode tests for Notification * chore: update Observable spec to run mode * chore: update Subject tests to run mode * chore: update combineLatest tests to run mode

view details

Ben Lesh

commit sha db92866259ca4f688f6c01f277d7e8f97307e0ff

Run mode updates 2 (#5562) * chore: static concat tests updated to run mode * chore: update defer tests to run mode * chore: update empty tests to use run mode * chore: update forkJoin tests to run mode

view details

OJ Kwon

commit sha e0494901d105ea8b8a110c6e3b222a67ff061af6

ci(circle): deprecate circle ci (#5498)

view details

Ben Lesh

commit sha 65e4d2d661c1d4e77adda07fe49903dbeb7e598d

chore: Add Github Actions status badge - Removes Circle CI badge.

view details

push time in 2 months

startedhahnlee/hwp.js

started time in 2 months

pull request commentReactiveX/rxjs

test(import): introduce import site integration test

@benlesh PR's rebased and added top-level comment for quick explanations.

kwonoj

comment created time in 2 months

push eventReactiveX/rxjs

Valentin Hăloiu

commit sha e1a671cbd7f5a6ce547ed9ee6ce98c22264500f4

fix(WebSocketSubject): close websocket connection attempt on unsubscribe Fix closing the underlying WebSocket when a WebSocketSubject is unsubscribed while the WebSocket is in the `CONNECTING` state. Initial support for closing a WebSocket before it was opened was added in #4446. However, that pull-request still waits for the connection to eventually become open before attempting to close it. This pull-request takes it a step further by closing the websocket as soon as the subject is unsubscribed.

view details

OJ Kwon

commit sha 13d87da69d4b4d3d132ef10b79825effc37801cd

build(ci): add node.js 14 into matrix

view details

Ben Lesh

commit sha 8ae3f5c5b9e08b8f1f401cc85379677a72a0fae9

Timer fix unhappy numbers (#5501) * fix(VirtualTimeScheduler/TestScheduler): Correctly handle scheduling at `Infinity` Resolves an issue where scheduling at non-finite numbers would result in marbles showing up in tests that had a `frame` of `null`. * fix(timer): passing non-finite and negative numbers now behaves correctly - Adds tests for cases where `Infinity` could be passed - Adds a test for dueTime `Date` objects in the past - Completely rewrites and improves documentation and updates examples - Renames internal utility function `isDate` to `isValidDate` to better convey what it is doing and why

view details

Ben Lesh

commit sha 31c010629aab3683615701aab6e85346d05b9134

Add ts-api-guardian (#5493) * add ts-api-guardian * chore: add api guardian check to CI. * chore: add important checks to prepublishOnly * chore: address comments

view details

萧文

commit sha 3eacd6522379503787b9b419daac23e9ede276b7

chore(refCount): remove unnecessary reference of object (#4720) * perf(refCount): optimize the implementation of class RefCounterOperator * Update ConnectableObservable.ts revert private to protected * refactor: Minor typings change This was mostly just to get CI to kick off again. * refactor: Changing the types back Again, I was really only doing this to kick off CI. LOL... My silly change in the dark from the GitHub UI didn't work. :) * chore: oops. Really I'm just kicking CI again. (and I made a dumb mistake on the last one) Co-authored-by: Ben Lesh <ben@benlesh.com>

view details

Nicholas Jamieson

commit sha edde63b164780524d65757479c48c93a69995bdb

chore: type repeatWhen notifier as void (#5496)

view details

Nicholas Jamieson

commit sha e65696e2f7f7338659a873f6653026b33b9011a9

fix: support empty subscription marbles (#5502) * test: add failing subscription marble tests * fix: support empty subscription marbles Closes #5499

view details

Ivan Tham

commit sha 0f74358cc168acee14e3701b5cc6e677d6e72f1d

docs(index): fix EMPTY link (#5508)

view details

OJ Kwon

commit sha 82bcc2179b8aefc08342a419ccc549080c358a64

Merge pull request #5507 from kwonoj/ci-node14 build(ci): add node.js 14 into matrix

view details

Ben Lesh

commit sha 96868ac754c0147a9aa61182185f27224eb7f11a

fix: fix up notification types (#5478) * fix: fix up notification types - Ensures Notification methods only accept appropriate arguments - Ensures Arbitrary objects of the proper shape my be passed through dematerialized - Utilizes hot path functions to create lightweight objects for internal notification use - Deprecates the Notification class - Adds a deprecation message for materialize to notify users that soon the emitted object type will change to not have all of the same methods as Notification - Updates a few tests that were relying on the shape of Notification instances to pass, as we are now using POJOs internally in the TestScheduler - Adds dtslint tests for notifications - Adds dtslint tests to enforce types on dematerialize BREAKING CHANGE: Notification.createNext(undefined) will no longer return the exact same reference everytime. BREAKING CHANGE: Type signatures tightened up around Notification and dematerialize * chore: address comments

view details

Josh Ribakoff

commit sha 289d5e86062ebdf62506b5cc1babf5d4062a836c

Add https://rxjs.xyz/ (#5539) Continuing the discussion from https://github.com/ReactiveX/rxjs/issues/5538 which was closed, I feel like there is a fragmentation problem where important context for making good use of RxJs is missing from the docs. This attempts to bridge the gap, and implements the suggestion I was trying to discuss before 5538 was abruptly closed, it takes a step in the right direction by making these 3rd party packages actually visible, so readers of the docs are actually aware there is more to the ecosystem than just what is shown on the official docs.

view details

Anirudh Varma

commit sha c5f65508505cf1f90560e6be76425e09c455bec3

fix(pluck): operator breaks with null/undefined inputs. (#5524) * test(pluck): add failing test case for using null value. * fix(pluck): check for null/undefined object before attempting to access prop * Remove null coalescing when checking values to prevent null values being converted to undefined

view details

Josep M Sobrepere

commit sha 92452cc20021141aa0f047c7e5af569a413143e5

fix(shareReplay): no longer misses synchronous values from source * fix(shareReplay): subscribe to subject before source subscription happens * test(shareReplay): improve test on sync source subscription Co-authored-by: Víctor Oliva <olivarra1@gmail.com>

view details

HaoLi

commit sha ea8ef13ed7f8c8ae8b8882f6b105fcd027b7d217

Example code is wrong. (#5544) operator map and the first example are wrong.

view details

Nicholas Jamieson

commit sha 6d185faf095c686ab74615334bd9f4bf61acc960

fix: revert #5458 (#5549) * test: add failing test * Revert "chore(shareReplay): remove redundant variable `isComplete` (#5458)" This reverts commit 9efc3d50f67ac1dac8c0440b28d0f6bae07bd5f7.

view details

Moshe Kolodny

commit sha 5fc904d3d9e6b014441b7a97541e0b216bfee42c

fix(defer) allow passing () => any to observableFactory (#5513) * fix(defer) allow passing () => any to observableFactory * fix(defer) revert to old declaration without void Co-authored-by: Moshe Kolodny <kolodny@github.com>

view details

Ben Lesh

commit sha d8439a66d6e7a06563858eef5f780c18df412124

chore: fix prepublish script

view details

Ben Lesh

commit sha 322a3304648acd28171458858756273d6eefa2b3

chore: update golden files

view details

Ben Lesh

commit sha 38408957a336f212e5112cfd3884f79e74cde93f

chore(publish): 7.0.0-beta.1

view details

Ben Lesh

commit sha fd66c2937ef73172d512f56b4c868e75a78635ab

chore(publish): 7.0.0-beta.1 update changelog and package-lock oops

view details

push time in 2 months

issue closedReactiveX/rxjs

Timer operator does not work correctly on certain dates

Bug Report

Current Behavior The timer operator is emit value immediately when we pass the current date(now) with adding from 75 to 99 days

Reproduction https://stackblitz.com/edit/angular-ivy-uuf9za?file=src/app/app.component.ts

closed time in 2 months

bretbas

issue commentReactiveX/rxjs

Timer operator does not work correctly on certain dates

closing as dupe.

bretbas

comment created time in 2 months

issue commentReactiveX/rxjs

Timer operator does not work correctly on certain dates

then why does it work with dates adding days more than 99?

it does not. If you only subscribe to date(100) for example,

const {timer} = require('rxjs');
const {mapTo} = require('rxjs/operators');

const addDays = (date, days) => {
  const d = new Date(date);
  d.setDate(d.getDate() + days);
  return d;
}

const now = new Date(Date.now());

const days = [
  timer(addDays(now, 74))
    .pipe(mapTo(74)),
  timer(addDays(now, 75))
    .pipe(mapTo(75)),
  timer(addDays(now, 99))
    .pipe(mapTo(99)),
  timer(addDays(now, 100))
    .pipe(mapTo(100))
]

days[3].subscribe((x) => console.log(x));

it emits warning

(node:13908) TimeoutOverflowWarning: 8643599998 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.
(Use `node --trace-warnings ...` to show where the warning was created)
100

and duration falls back to default but not sync, so it emits asynchronously. If it correctly works, opening up page should not write any output since date due is set to more than one month.

bretbas

comment created time in 2 months

startedsamizdatco/skia-canvas

started time in 2 months

issue commentReactiveX/rxjs

Timer operator does not work correctly on certain dates

I believe this is dupe of https://github.com/ReactiveX/rxjs/issues/3015.

bretbas

comment created time in 2 months

issue commentfullstack-build/tslog

Feature Request: [Feature] [Question] masking dynamic values, such as regex pattern matching

Thanks for the confirmation. So theoritically feature I would like to have is maskAny + regex (or predicate function).

kwonoj

comment created time in 2 months

issue commentReactiveX/rxjs

Limitation is marble testing use cases due to grouping semantics

(Since rx-sandbox is still using frame-based virtual time approach)

joshribakoff

comment created time in 2 months

issue commentReactiveX/rxjs

Limitation is marble testing use cases due to grouping semantics

@benlesh those reasoning is actually reason why we did decide to not upstream my rx-sandbox.

joshribakoff

comment created time in 2 months

startedmodulz/stitches

started time in 2 months

issue commentfullstack-build/tslog

Feature Request: [Feature] [Question] masking dynamic values, such as regex pattern matching

The way I use it personally is by leveraging maskAny to hide any known key

Yes, I agree with those design decision in general. I would say my usecase is more edge, aggressive cases if someone wants aggressive scanning even with cost of pattern matching since we can't leak either PII or tokens for security reasons.

So I believe a plausible solution could be an additional method maskAnyRegex, where you could simply provide a RegEx that would be used for masking.

Yes, I think that could work.

Still, if I recall correctly this doesn't apply to message itself: is there way to enable matching against messages itself? as mentioned above, the way we currently do is via custom formatted - but doesn't seem like tslog provides way to override formatted for those usecase.

kwonoj

comment created time in 2 months

issue commentfullstack-build/tslog

Feature Request: [Feature] [Question] masking dynamic values, such as regex pattern matching

Our application has extensive redaction for any possible token logging point. We have some dynamic object payload, rough illustration like

{
 ...state,
 auth_token: 'token_prefix_...'
}

the important part is we don't have deterministic key to filter things out. above example, it was included in auth_token, but it could be other forms, including logger message itself. The only thing we can guarantee is token follows a specific form of pattern.

Currently in our Winston, we do recursively traverse all input message& payload by overriding default formatted. Curious if there's similar way, or specify patterns other then known maskKey.

kwonoj

comment created time in 2 months

issue commentReactiveX/rxjs

Black Lives Matter banner geotargeting

We don't consider region-based offering at this moment. Core team will internally discuss, this thread is locked to prevent other comments meanwhile.

egorvinogradov

comment created time in 2 months

issue closedReactiveX/rxjs

Black Lives Matter banner geotargeting

Hello,

Is there an option to show the Black Lives Matter banner based on the location? E.g. show it only in the U.S. or other related countries? This can be achieved by using a free IP API e.g. http://ip-api.com/json/

Here in Russia, it just looks ridiculous, as there has never been a history of black slavery. It's like if you were advocating Rwanda's Tutsis minority here - while this itself might be a tough issue, it's not a priority for most of the local population, and most people don't know much about it.

I don't understand why the historical problem of a particular country should interfere with the daily routine of developers across the rest of the world.

Thank you

closed time in 2 months

egorvinogradov

issue openedfullstack-build/tslog

Feature Request: [Feature] [Question] masking dynamic values, such as regex pattern matching

Description / Use Case for a Feature

I may misunderstand docs and this is already supported, labeled question to clarify it.

There are some cases we would like to traverse all object payload recursively to detect a certain patterns of strings matching regex, such as prefix-based auth token and vice versa. Is there way to specify it via current mask* configuration values?

created time in 2 months

pull request commentReactiveX/rxjs

test(import): introduce import site integration test

yeah sorry, bit swamped with personal issues. Trying to get back soon.

kwonoj

comment created time in 2 months

startedreHackable/awesome-reMarkable

started time in 2 months

pull request commentReactiveX/rxjs

fix: handle synchronous back pressure during subscribing the inner sub

As you said we may visit per each cases: but if fix is limited to synchronous reentrant, it's likely not able to be picked up. That's reason I was sugesting in 2 if test case can be replaced doesn't involve synchronous reentrant.

naiweizheng

comment created time in 2 months

pull request commentReactiveX/rxjs

fix: handle synchronous back pressure during subscribing the inner sub

for 3, not specifically for this operator but https://github.com/ReactiveX/rxjs/issues/1759#issuecomment-227575178 explains early decision why we did it:

Protecting against re-entrency without throwing errors or dropping values would necessitate introducing unbounded buffers, which was a conscious design trade-off we made in the early days.

Until (if) we make other breaking design decisions, I doubt we'll offer official support for reentrant for all edge cases.

naiweizheng

comment created time in 2 months

pull request commentReactiveX/rxjs

fix: handle synchronous back pressure during subscribing the inner sub

  1. I agree we may need some documentation about reentrant behavior. This was brought up couple of times.

  2. If this behavior can happen without reentrant, I'd like to see and example and I believe this should be included as test case instead.

  3. Whole rxjs v5, and beyond by design to not honor synchronous reentrant. I do not agree with core we should able to support all possible cases of synchronous reentrant. Scheduling reentrant is not a workaround, it is intended per current design of core behaves. Moreover, core team generally recommend avoiding reentrant itself: not only for this synchronous behavior, there are a lot of possible catch around reentrant behavior can cause unexpected behavior: it's due to several reasons that rx core does not support some / does not define some / and possible some unexpected bug lastly.

naiweizheng

comment created time in 2 months

pull request commentReactiveX/rxjs

fix: handle synchronous back pressure during subscribing the inner sub

ref: https://github.com/ReactiveX/rxjs/issues/5174#issuecomment-561303690 / https://github.com/ReactiveX/rxjs/issues/5173 etcs.

naiweizheng

comment created time in 2 months

pull request commentReactiveX/rxjs

fix: handle synchronous back pressure during subscribing the inner sub

For me added test cases

const e = new BehaviorSubject(1);
const results: Array<number> = [];

e.pipe(
      take(3),
      exhaustMap(value => new Observable<number>(subscriber => {
        e.next(value+1);

are a direct example of synchronous reentrant, which is known to not supported and caller should schedule appropriately. Any specific reason do you think this is a bug to be fixed?

naiweizheng

comment created time in 2 months

issue commentkwonoj/rx-sandbox

Jest matcher import is breaking webpack projects.

I think this is due to nature of jest itself which is not intended to be used in browser environment. Same goes for this pkg, it is intended to be used as test suite without any bundler support.

I am unsure if this can be fixed in viable timeframe as I do not have any env attempt to bundle this pkg. If you have quick fix to suggest, welcome to have PR.

baremaximum

comment created time in 2 months

PullRequestReviewEvent

startedmalrev/ABD

started time in 2 months

issue closedReactiveX/rxjs

Allow using Typescript 4.0 RC for more type info

As you can see, such as forkJoin can only support full type deduction when the number of args less then 6.

Using typescript 4.0 can allow type deduction for infinity args.

closed time in 2 months

Zcating
more