profile
viewpoint

kubamracek/adoftp 4

A simple portable one-file anonymous read-only FTP server written in C.

kubamracek/discourse 1

A platform for community discussion. Free, open, simple.

kubamracek/llvm 0

Mirror of official llvm git repository located at http://llvm.org/git/llvm. Updated hourly.

kubamracek/mobos-ios 0

www.romobos.com iOS workshop demo projects

kubamracek/swift 0

The Swift Programming Language

kubamracek/swift-lldb 0

This is the version of LLDB that supports the Swift programming language & REPL.

pull request commentapple/swift

Introduce SWIFT_FREESTANDING_FLAVOR to select whether the FREESTANDING stdlib should be built/tested using an Apple SDK, or another SDK (e.g. Linux, not implemented yet)

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test @swift-ci please test with toolchain and preset

kubamracek

comment created time in 2 days

push eventkubamracek/swift

Kuba (Brecka) Mracek

commit sha deeef7e42a16bcaec65d12e3c84bacb4942e2c0e

Fixup TARGET_SDKS in CMakeLists.txt

view details

push time in 2 days

create barnchkubamracek/swift

branch : freestanding-flavor

created branch time in 3 days

delete branch kubamracek/swift

delete branch : freestanding-test-suite

delete time in 3 days

push eventapple/swift

Kuba (Brecka) Mracek

commit sha d7dfa3e942dbab243e56af96ff08fdcc1cfd2c16

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset (#34386)

view details

push time in 3 days

PR merged apple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

This PR enables testing for the 'freestanding' build and the standalone_minimal preset. Multiple things needed to achieve that:

  • Start building StdlibUnittest and other test-support modules (done via the SWIFT_BUILD_TEST_SUPPORT_MODULES CMake flag).
  • Fix up several tests to avoid assuming Darwin == Obj-C interop enabled.
  • Autolink libc++ to avoid the need for each user of the static stdlib to add -lc++ on their link lines.
  • In lit.cfg, fix up available_features and set up a resource dir with the right content (freestanding-built modules).
  • New standalone_minimal preset that actually runs the tests.
+125 -26

6 comments

29 changed files

kubamracek

pr closed time in 3 days

Pull request review commentapple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

 else()   set(SWIFT_STDLIB_STABLE_ABI_default FALSE) endif() +if(SWIFT_BUILD_SDK_OVERLAY OR SWIFT_INCLUDE_TESTS)

This is a very good point. I think the situation as it is today is like this: cmake/modules/StandaloneOverlay.cmake is a hack that's trying to avoid invoking the top-level CMakeLists.txt, but it's already full of problems and fragility. I certainly don't want to break it, but I don't think we should be actively adding support for this type of build either. In this particular case, I believe this means we're "okay" because cmake/modules/StandaloneOverlay.cmake isn't used to build any of the modules that are involved in the new SWIFT_BUILD_TEST_SUPPORT_MODULES flag. And even if they were, notice that the changes around SWIFT_BUILD_TEST_SUPPORT_MODULES I'm making are purely inclusive, i.e. when we build the modules in all the existing cases + also if SWIFT_BUILD_TEST_SUPPORT_MODULES is set.

So in terms of making sure we don't break cmake/modules/StandaloneOverlay.cmake I think we're good.

The more longer-term strategy, though, should actually be to make stdlib/CMakeLists.txt standalone and not depending on the top-level CMakeLists.txt. But AFAIK, today, stdlib/CMakeLists.txt doesn't work separately, yet. I think that definitions of CMake variables and options that are only affecting the runtime/stdlib and not tools (swiftc) should eventually be moved to stdlib/CMakeLists.txt or perhaps elsewhere inside stdlib/. But that doesn't belong in this PR — let me try to move the directly affected ones here (SWIFT_BUILD_DYNAMIC_SDK_OVERLAY, SWIFT_BUILD_SDK_OVERLAY) as a separate PR.

kubamracek

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

 else()   set(SWIFT_STDLIB_STABLE_ABI_default FALSE) endif() +if(SWIFT_BUILD_SDK_OVERLAY OR SWIFT_INCLUDE_TESTS)+  set(SWIFT_BUILD_TEST_SUPPORT_MODULES_default TRUE)+else()+  set(SWIFT_BUILD_TEST_SUPPORT_MODULES_default FALSE)+endif()

I don't think CMake supports this syntax. And actually just looking over the existing CMake code we have, we seem to always be using the longer expanded variant, so let's keep it this way here, too.

kubamracek

comment created time in 3 days

PullRequestReviewEvent

pull request commentapple/swift

When building standalone stdlib, use Clang resource dir from the toolchain, not the system default

Can you describe what actual problem are you seeing that's caused by this change? It's been merged in for 2 months, so I'm not sure reverting is a good option. But it depends on what kind of regression are you seeing.

I guess the important point is "What exactly is native-clang-tools-path supposed to mean?" I would argue that it's technically supposed to mean something like "When set, use this path for clang/clang++ for all C/C++ compilations, avoid using any other compilers". Given that, this PR is actually fixing an important bug, which has nothing to do with the other flags or with the preset.

Let's also get @compnerd's take on this.

kubamracek

comment created time in 3 days

pull request commentapple/swift

Add a -emit-dead-strippable-symbols flag that emits functions/variable/metadata in a dead_strip-friendly way.

@jckarter @airspeedswift any more feedback or this good to go in?

kubamracek

comment created time in 6 days

Pull request review commentapple/swift

Add an end-to-end test for ThinLTO (-lto=llvm-thin flag), fix compiler crashes

 static void embedBitcode(llvm::Module *M, const IRGenOptions &Opts)   llvm::Constant *CmdConstant =     llvm::ConstantDataArray::get(M->getContext(), CmdData);   GV = new llvm::GlobalVariable(*M, CmdConstant->getType(), true,-                                llvm::GlobalValue::PrivateLinkage,-                                CmdConstant);+                                llvm::GlobalValue::PrivateLinkage, CmdConstant,+                                ".cmdconstant");

See @compnerd's comment above — I think he's suggesting to go the opposite way (drop "swift" from the names)?

kubamracek

comment created time in 6 days

PullRequestReviewEvent

pull request commentapple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

This may not always be true (considered free standing on Linux will want Glibc here and on windows would want CRT and WinSDK). I imagine that instead the right thing to do is make this a cmake variable. Maybe the way to do this is to create a notion of if freestanding is "apple" flavored. If it is apple flavored it is part of ALL_APPLE_PLATFORMS and if not. Or we could define a sort of "base" sdk for the freestanding sdk with the idea that it would try to emit these libraries. Just some thoughts.

This makes sense, and I think it's the right thing to do. Let me try to pursue a generalization like this in a follow up PR, ok?

kubamracek

comment created time in 7 days

Pull request review commentapple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

 foreach(SDK ${SWIFT_SDKS})     set(test_dependencies)     get_test_dependencies("${SDK}" test_dependencies) -    if(SWIFT_BUILD_STDLIB AND SWIFT_INCLUDE_TESTS)+    if(SWIFT_BUILD_DYNAMIC_STDLIB AND SWIFT_INCLUDE_TESTS)

Added comment.

kubamracek

comment created time in 7 days

PullRequestReviewEvent

push eventkubamracek/swift

Kuba Mracek

commit sha 666a9965b839ffc4979de87bf0790ff947fb2e74

Add explaining comment to stdlib/tools/CMakeLists.txt and test/CMakeLists.txt

view details

push time in 7 days

PR opened apple/swift

Reviewers
Add an end-to-end test for ThinLTO (-lto=llvm-thin flag), fix compiler crashes
  • Add lit.cfg support to add the right path to the just-built LTO library on Darwin
  • Add an end-to-end ThinLTO test
  • Fix discovered compiler crash 1: ThinLTO probihits unnamed global variables, let's name them all. This part of the PR is authored by @gottesmm, thx!!!
  • Fix discovered compiler crash 2: Stop marking llvm.used as disableAddressSanitizer, which causes ThinLTO's global variable merging logic to fail, and it's not really needed to let's stop doing that. (At first I considered this a bug in the merging logic, but on a second thought, it's highly unusual to reference llvm.used from any other variables/metadata that I actually think it's a mistake on the swiftc side to do that.)
+60 -15

0 comment

6 changed files

pr created time in 7 days

create barnchapple/swift

branch : thinlto-fixes

created branch time in 7 days

push eventkubamracek/swift

Kuba (Brecka) Mracek

commit sha df6ea248693f2a7bba86c9d6937a84880a5e58bf

Drop "UNSUPPORTED" from DispatchData.swift

view details

push time in 7 days

push eventkubamracek/swift

Kuba (Brecka) Mracek

commit sha 40b7e31120b65845e5a9e9c16d3edf2817ce7d0a

Drop quotes

view details

push time in 7 days

push eventkubamracek/swift

Kuba (Brecka) Mracek

commit sha d24022c236dd5cefa79893fa46245d0513632516

Simplify if

view details

push time in 7 days

Pull request review commentapple/swift

Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

 else()   set(SWIFT_STDLIB_STABLE_ABI_default FALSE) endif() +if("${SWIFT_BUILD_SDK_OVERLAY}")+  set(SWIFT_BUILD_TEST_SUPPORT_MODULES_default TRUE)+elseif("${SWIFT_INCLUDE_TESTS}")

No reason. Let me fix that.

kubamracek

comment created time in 7 days

PullRequestReviewEvent

delete branch apple/swift

delete branch : dead_strip1

delete time in 8 days

push eventkubamracek/swift

Kuba Mracek

commit sha 3817fcbb0b6cc4caa9b2332cb6032e62cdd85006

Mark the tests as requiring macosx

view details

push time in 8 days

create barnchapple/swift

branch : dead_strip1

created branch time in 8 days

push eventkubamracek/swift

Butta

commit sha 69d04aad08da3245f87c6a2df35869126d48b55e

[linux] remove absolute rpath of /usr/lib/swift/linux added to many shared libraries This was presumably added as a backup, in case the libraries in a toolchain couldn't be found, but will not work well, so take it out.

view details

Alexey Komnin

commit sha 4fa17bf59774ae6543a33b1a29f01320705f4dfe

SR-12022: refactor LiteralExpr to combine common initializer code

view details

Michael Gottesman

commit sha d3e6ffdbad9ed2af857508891a4530b7f11d4c6e

[lldb-toolbox] Add the ability to disassemble-to-file a specific function from a target without running the target. The routine already supports dumping the assembly to file if we are at a breakpoint using the current frame. This adds a -n option so one can without running just dump the assembly to a file of a specific function in a binary.

view details

Dave Lee

commit sha 27330f169df5d2dcb018ab2c6615d66be91d04e2

[build] Remove unused lldb cmake

view details

Anthony Latsis

commit sha 8f43d888b8fd88540c5ba3d770a857928ac0b3a7

Sema: Disallow usage of settable Self-returning storage requirements on existential base

view details

Keith Smiley

commit sha ae0c380f1b0f37e11b111a06634dd4c64e67b96c

Improve -*prefix-map help text Before: ``` -coverage-prefix-map <value> -debug-prefix-map <value> ``` After: ``` -coverage-prefix-map <prefix=replacement> -debug-prefix-map <prefix=replacement> ```

view details

Mike Ash

commit sha 630aff7b19b80f29445b645424e20fd1bb6bd551

[Runtime] Change SimpleGlobalCache to use ConcurrentReadableHashMap instead of ConcurrentMap. This gives us faster lookups and a small advantage in memory usage. Most of these maps need stable addresses for their entries, so we add a level of indirection to ConcurrentReadableHashMap for these cases to accommodate that. This costs some extra memory, but it's still a net win. A new StableAddressConcurrentReadableHashMap type handles this indirection and adds a convenience getOrInsert to take advantage of it. ConcurrentReadableHashMap is tweaked to avoid any global constructors or destructors when using it as a global variable. ForeignWitnessTables does not need stable addresses and it now uses ConcurrentReadableHashMap directly. rdar://problem/70056398

view details

Alexis Laferrière

commit sha e61ffea42c943044fe4fc8c35d5040bc8815e420

[Sema] Check availability in inlinable code using the explicit version Inlinable functions can be inlined in clients with a lower OS target version than the framework defining the function. For this reason, the availability in inlinable functions should always be checked using the explicit introduction OS version as lower bound and not the minimum deployment version. rdar://problem/67975153

view details

Alexis Laferrière

commit sha 53e04cb39db86d890ff674b775a5dbda47e9d599

[Sema] Test explicit versions in TypeRefinementContext

view details

Alexis Laferrière

commit sha 2f182c2b785f5f7b68ee756d1474f21f3050ba67

[Sema] Consider unavailable functions as being unreachable This has the effect of rejecting unavailable overrides to available methods in a similar way as overrides that are less available than the introduction are rejected.

view details

Alexis Laferrière

commit sha 39ee5916bd656cf56c75ddf45a47e628d0ff1db1

[SIL] Don't print availability for unreachable/unavailable functions

view details

Martin Boehme

commit sha a5e953b69009b59541420d06496206a26961a976

Add support for calling C++ constructors. Because C++ constructors always take a `this` pointer to the object to be initialized, we mark the SIL function return type with the `@out` attribute. On the IRGen side, we retrofit support for formal indirect return values as well as thin metatypes.

view details

Martin Boehme

commit sha 7ad2eef26508ad92d8d92f2d5546913c0ced3bbd

Only import constructors marked `noexcept`.

view details

Martin Boehme

commit sha 384854810a60a69c8df8a8c0248e209adc28c295

Revert "Only import constructors marked `noexcept`." This reverts commit 29650d8c1f302708a32304d49c703c9ddbf30b75. As discussed here, we want to import all constructors (whether they are marked `noexcept` or not) as non-throwing initializers; https://forums.swift.org/t/handling-c-exceptions/34823/50

view details

Martin Boehme

commit sha fd00bc1f01357ecd264b8216373c23014771c124

Move tests from `CXXInterop` to `Interop/Cxx`. This is the canonical location that we've agreed on.

view details

Martin Boehme

commit sha e6067275a6659cfab8640e68e93a5bba36ddca20

Duplicate changes to GenClangType in ClangTypeConverter. See discussion here: https://github.com/apple/swift/pull/30630#discussion_r398967412

view details

Martin Boehme

commit sha b2c5a3eeed4e0d80c819f98c816481fbedc49526

Add a constructor thunk if required to add additional constructor arguments. Also add more IR tests and make various other changes.

view details

Martin Boehme

commit sha 3066e16c37e26a5fea370877409b4d0bd1c0fea6

Remove redundant "cxx" from test names.

view details

Martin Boehme

commit sha 5644137ea0696164c5b5835179b1ec450d508c88

Eliminate duplication of code for adding empty argument names.

view details

Martin Boehme

commit sha bed26039446c189a82c453126e0a622e43c6256d

Various changes after merging master: - Adapt tests to changes that have happened in the meantime (e.g. `HasVirtualBase` is rightly no longer considered loadable) - Don't import copy or move constructors (noticed this because references are now imported correctly, so copy and move constructors suddenly started showing up in the SIL test) - Don't try to define an implicitly-deleted default constructor (this previously broke loadable-types-silgen.swift)

view details

push time in 8 days

PR opened apple/swift

Reviewers
Bring up tests + validation tests for the 'freestanding' build and the standalone_minimal preset

This PR enables testing for the 'freestanding' build and the standalone_minimal preset. Multiple things needed to achieve that:

  • Start building StdlibUnittest and other test-support modules (done via the SWIFT_BUILD_TEST_SUPPORT_MODULES CMake flag).
  • Fix up several tests to avoid assuming Darwin == Obj-C interop enabled.
  • Autolink libc++ to avoid the need for each user of the static stdlib to add -lc++ on their link lines.
  • In lit.cfg, fix up available_features and set up a resource dir with the right content (freestanding-built modules).
  • New standalone_minimal preset that actually runs the tests.
+122 -24

0 comment

29 changed files

pr created time in 8 days

create barnchkubamracek/swift

branch : freestanding-test-suite

created branch time in 8 days

pull request commentapple/swift

Add a -emit-dead-strippable-symbols flag that emits functions/variable/metadata in a dead_strip-friendly way.

Updated the PR, added more tests.

What happens if we remove even the llvm.compiler.used annotation?

Good point. I realized it's not needed for this purpose. I originally thought that it might be needed for LTO/ThinLTO, but it turns out it's not needed for that either. I dropped those changes.

kubamracek

comment created time in 8 days

push eventkubamracek/swift

Kuba Mracek

commit sha 30fa52b3ab634eb6d6aafb5c93d4e04503caa1ef

Add a -emit-dead-strippable-symbols flag that emits functions/variable/metadata in a dead_strip-friendly way. This enables static linking to remove unused functions and classes even across modules.

view details

push time in 8 days

PR opened apple/swift

Reviewers
Add a -emit-dead-strippable-symbols flag that emits functions/variable/metadata in a dead_strip-friendly way.

Add a -emit-dead-strippable-symbols flag that emits functions/variable/metadata in a dead_strip-friendly way. This enables static linking to remove unused functions and classes even across modules. For now, I'm adding the flag as an opt-in experimental mode, but the goal is to eventually be able to emit symbols this way for everything. This way we could see nice code size savings when e.g. including a lot of package dependencies where not everything is actually used.

+207 -20

0 comment

7 changed files

pr created time in 17 days

create barnchkubamracek/swift

branch : dead_strip1

created branch time in 17 days

pull request commentapple/swift

[experiment] Don't mark functions as used in irgen::createFunction

@swift-ci please test

kubamracek

comment created time in 25 days

push eventkubamracek/swift

Kuba Mracek

commit sha 8da8f9822d07f045ede9ca772eb7b1c2282e33d0

fix tests

view details

push time in 25 days

pull request commentapple/swift

[experiment] Don't mark functions as used in irgen::createFunction

@swift-ci please test

kubamracek

comment created time in a month

create barnchkubamracek/swift

branch : dead-strip1

created branch time in a month

push eventapple/swift

Kuba (Brecka) Mracek

commit sha 6b40a092b9c059873d0fd8713988aee5ca41db0e

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file (#34025)

view details

push time in a month

delete branch kubamracek/swift

delete branch : objc-into-separate-file

delete time in a month

PR merged apple/swift

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file.

+53 -21

10 comments

4 changed files

kubamracek

pr closed time in a month

pull request commentapple/swift

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

@swift-ci please test Linux platform

kubamracek

comment created time in a month

pull request commentapple/swift

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

@swift-ci please test Linux platform

kubamracek

comment created time in a month

create barnchkubamracek/swift

branch : larger-stack-for-mib

created branch time in a month

pull request commentapple/swift

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

@swift-ci please test Linux platform

kubamracek

comment created time in a month

push eventapple/swift

Kuba (Brecka) Mracek

commit sha e6da0c2eea45e37178df32d5fa7e17349cadc0c4

Make MinSizeRel builds of stdlib (but not the compiler) produce debug info (#33787)

view details

push time in a month

delete branch kubamracek/swift

delete branch : debug-minsizerel

delete time in a month

PR merged apple/swift

Reviewers
Make MinSizeRel builds produce debug info

MinSizeRel in CMake doesn't produce debug info by default, and there's no such thing as MinSizeRelWithDebInfo... So let's just make MinSizeRel produce debug info.

+6 -0

8 comments

2 changed files

kubamracek

pr closed time in a month

pull request commentapple/swift

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

@swift-ci please test Linux platform

kubamracek

comment created time in a month

push eventapple/swift

Kuba (Brecka) Mracek

commit sha 41f91d5365719ed9bb38ea2055743fb89e02e04c

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option (#34018)

view details

push time in a month

delete branch kubamracek/swift

delete branch : freestanding-module-name

delete time in a month

PR merged apple/swift

Reviewers
Add a SWIFT_FREESTANDING_MODULE_NAME CMake option

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option to be able to select the last part of a .swiftmodule filename when building the "freestanding" variant of stdlib. This is needed to bringup building and testing infrastructure for "freestanding".

Eventually, these flags (SWIFT_FREESTANDING_MODULE_NAME, SWIFT_FREESTANDING_TRIPLE_NAME) should go away, but that can only happen once Clang and Swift actually accept "freestanding" or "none" as a target triple.

+13 -1

1 comment

3 changed files

kubamracek

pr closed time in a month

PR opened apple/swift

Reviewers
Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file

Move the actual Obj-C parts of ReflectionMirror.mm into a separate file, make ReflectionMirror.mm a .cpp file.

+53 -21

0 comment

4 changed files

pr created time in a month

create barnchkubamracek/swift

branch : objc-into-separate-file

created branch time in a month

pull request commentapple/swift

For standalone stdlib, fully skip building LLVM if we're skipping testing

@swift-ci please test Windows platform

kubamracek

comment created time in a month

push eventapple/swift

Kuba (Brecka) Mracek

commit sha ed96cf43f4b5fb855748005c6b86a5535eb28584

Avoid using extra-cmake-options in the stdlib standalone presets (#34020)

view details

push time in a month

delete branch kubamracek/swift

delete branch : stdlib-standalone-no-extra-cflags

delete time in a month

PR merged apple/swift

Reviewers
Avoid using extra-cmake-options in the stdlib standalone presets

NFC. We have these flags exposed in build-script, no need to use extra-cmake-options.

+3 -2

2 comments

1 changed file

kubamracek

pr closed time in a month

pull request commentapple/swift

For standalone stdlib, fully skip building LLVM if we're skipping testing

@swift-ci please test

kubamracek

comment created time in a month

pull request commentapple/swift

For standalone stdlib, fully skip building LLVM if we're skipping testing

And in https://github.com/apple/swift/pull/34020, I've promoted the stdlib_standalone preset to use the build-script-impl flags instead of --extra-cmake-options. That means we can reliably detect the stdlib standalone build now.

kubamracek

comment created time in a month

pull request commentapple/swift

For standalone stdlib, fully skip building LLVM if we're skipping testing

build_targets=(clean) seemed to be a way to just use a target that doesn't do anything valuable. I've replaced it with an explicit check for empty build_targets and skipping the build step in that case.

kubamracek

comment created time in a month

push eventkubamracek/swift

Anthony Latsis

commit sha efa8f86193ca934ecd939308fb7b6866467b8725

[NFC] FuncDecl: Strip factory constructors out of TypeLocs

view details

Slava Pestov

commit sha e05a7326f31f237c26f3357701bc8ca4228d51e1

Sema: Fix crash-on-invalid on protocol requirements with 'where' clause constraints RequirementEnvironment wasn't prepared to handle a protocol requirement with additional 'where' clause constraints but no generic parameters. Since such a requirement necessarily runs afoul of the existing "protocol requirements cannot constrain Self" rule, it suffices to ignore such requirements when matching witnesses and let the declaration checker diagnose this situation later. Fixes <rdar://problem/61876053>.

view details

NevinBR

commit sha a62bf48e68956adc9b423fc03c6faac283512d36

[stdlib] [NFC] FloatingPointRandom.swift created (#33463) * Moved `random` methods out of FloatingPoint.swift * Added `random` methods to FloatingPointRandom.swift * Added FloatingPointRandom.swift to CMakeLists.txt * Added FloatingPointRandom.swift to GroupInfo.json * Moved filename within CMakeLists.txt

view details

Slava Pestov

commit sha d50e3b00bf2a185635c2914a14e1a5b0bba3287b

Add regression test for rdar://problem/62268062

view details

swift_jenkins

commit sha 84805cc53723be8d681719471aae071d5b6ca385

Merge remote-tracking branch 'origin/master' into master-rebranch

view details

Arnold Schwaighofer

commit sha db46d04cb24939788319714e5c71f55562c814e3

Merge pull request #33536 from aschwaighofer/fix_abitypes_test_bytes Fix test abitypes.swift for recent i1 to i8 store change

view details

swift_jenkins

commit sha 231d5da2fd67283579b6c981a6ecbfa48f9d1e78

Merge remote-tracking branch 'origin/master' into master-rebranch

view details

Robert Widmann

commit sha 3d6c6b4a59f239f670d2ddbe2771a66a3a07f62f

Revert "Sema: Don't need to derive CaseIterable's AllCases associated type" This reverts commit 3ae31d5173053e76764ac386150cd4dd2276219c.

view details

Michael Gottesman

commit sha ac5016bc945feed7d62a7108bcff2ada7ca670be

[opt-remark] Skip implicit top level functions and autogenerated compiler functions. This eliminates opt-remarks on initializers/friends, e.x.: ``` struct KlassPair { var lhs: Klass // expected-remark {{retain of type 'Klass'}} // expected-note @-1 {{of 'self.lhs'}} // expected-remark @-2 {{release of type 'Klass'}} // expected-note @-3 {{of 'self.lhs'}} var rhs: Klass // expected-remark {{retain of type 'Klass'}} // expected-note @-1 {{of 'self.rhs'}} // expected-remark @-2 {{release of type 'Klass'}} // expected-note @-3 {{of 'self.rhs'}} } ``` becomes: ``` struct KlassPair { var lhs: Klass var rhs: Klass } ``` I also added an -Xllvm option (-optremarkgen-visit-implicit-autogen-funcs) that will force these to be emitted as a compiler knob for compiler developers. There is a test that validates the behavior.

view details

Saleem Abdulrasool

commit sha 9ecd2a00226078d5392b20bc8f69b27c90e4c920

build: switch to `cl` instead of `clang-cl` for lldb clang has a bug where the template handling triggers an assertion. This switches the compiler to MSVC's compiler as a temporary workaround.

view details

Mishal Shah

commit sha 0bd7bbf64956286d503ac3c8c13d894c3372ed9c

Merge pull request #33546 from compnerd/msvc-not-clang build: switch to `cl` instead of `clang-cl` for lldb

view details

Michael Gottesman

commit sha c8c807f349f34bfbebeca7fc5adaf80b57c51570

Consistently use toggle_true instead of store_true when selected projects. This allows for child cascading presets to mixin a parent preset and then selectively turn off these projects. store_true in contrast can not be overwritten making cascading impossible.

view details

Luciano Almeida

commit sha 713ca60a53556a11153fc8063e11dcc2c238906c

Merge pull request #33519 from LucianoPAlmeida/assing-through-partial-keypath-diagnostic [CSDiagnostics] Also consider PartialKeyPath a non-writable keypath on AssignmentFailure diagnostics

view details

Anthony Latsis

commit sha 6700077344ea802de2b7c482897f3b347d2ec049

Merge pull request #33498 from AnthonyLatsis/type-locura-3 AST: Abstract away the use of TypeLoc for function and subscript result types

view details

Robert Widmann

commit sha e42037a8c2835f3d25ac272f51bf45d5cde4fa60

Restore AllCases Default While we cannot yet remove the synthesis of AllCases without some extra coordination with the SDKs, we can at least leave the default behind since it is always going to be correct, if a little duplicative.

view details

swift_jenkins

commit sha b1cc1ae5aea2145635a3fcfb42676bce15a3504f

Merge remote-tracking branch 'origin/master' into master-rebranch

view details

Robert Widmann

commit sha 57f2944aad1d08d9bbd530a8534e52895c783eb1

Add A Reproducer For rdar://48443680 The ModuleManager in Clang maintains a mapping from FileEntry nodes to ModuleFile data. Because FileEntry nodes are unique'd by underlying inode number, an attacker can craft a collision by ensuring that two different PCMs share an inode number. This failure can be encountered with some regularity in a highly concurrent compilation session on filesystems that use Orlov's Algorithm to allocate inode numbers (like ext4 on Linux). Here, we use a much simpler algorithm that forgets that PCMs have distinct inode numbers. A future version of clang will increase the entropy of the key value to take into account the mod time and size, which we also conveniently map to 0 to throw it off our trail.

view details

Slava Pestov

commit sha 87498cec90c80058b72a6181a667630a4ef0df82

Merge pull request #33538 from slavapestov/regression-test-rdar62268062 Add regression test for rdar://problem/62268062

view details

Slava Pestov

commit sha 44d438669fde15c1aba9a0f18f3ffabcf8a6ae7a

Merge pull request #33537 from slavapestov/protocol-requirement-self-where-clause Sema: Fix crash-on-invalid on protocol requirements with 'where' clause constraints

view details

swift_jenkins

commit sha 6ace447f978bb6b460443bd57b2f196fa6330112

Merge remote-tracking branch 'origin/master' into master-rebranch

view details

push time in a month

pull request commentapple/swift

Avoid using extra-cmake-options in the stdlib standalone presets

@swift-ci please test stdlib with toolchain

kubamracek

comment created time in a month

pull request commentapple/swift

Avoid using extra-cmake-options in the stdlib standalone presets

@swift-ci please test

kubamracek

comment created time in a month

PR opened apple/swift

Reviewers
Avoid using extra-cmake-options in the stdlib standalone presets

NFC. We have these flags exposes in build-script, no need to use extra-cmake-options.

+3 -2

0 comment

1 changed file

pr created time in a month

create barnchkubamracek/swift

branch : stdlib-standalone-no-extra-cflags

created branch time in a month

pull request commentapple/swift

Make MinSizeRel builds produce debug info

@swift-ci please test stdlib with toolchain

kubamracek

comment created time in a month

pull request commentapple/swift

Make MinSizeRel builds produce debug info

@swift-ci please test

kubamracek

comment created time in a month

push eventkubamracek/swift

Kuba (Brecka) Mracek

commit sha 7ca29b4ad261fe6a1cc1bd4c7a9b3b1377158c7a

Update comment

view details

push time in a month

pull request commentapple/swift

Make MinSizeRel builds produce debug info

@swift-ci please test stdlib with toolchain

kubamracek

comment created time in a month

pull request commentapple/swift

Make MinSizeRel builds produce debug info

@swift-ci please test

kubamracek

comment created time in a month

push eventkubamracek/swift

Brian Gontowski

commit sha 3425a6dbb16e5fa7ad4b735eff4533c279d61442

Added protocol to support CVarArg objects that need to be retained

view details

Brian Gontowski

commit sha 0e7749bcde5eb1bc9fec82ef0eb3896ec8d6de6f

Fixed comment

view details

Yuta Saito

commit sha d6cddaabb59958737e048ff1a5dd4d283c555661

[LTO] Support LLVM LTO for driver This commit adds LTO support for handling linker options and LLVM BC emission. Even for ELF, swift-autolink-extract is unnecessary because linker options are embeded in LLVM BC content when LTO.

view details

Saleem Abdulrasool

commit sha 85d6f51743edf4fbd7470400ace2a90ee3ed4831

build: add additional search paths for Foundation artifacts This allows us to homogenise the foundation build artifacts with swift-tools-support-core, swift-driver, swift-package-manager, swift-numerics, swift-argument-parser.

view details

Brian Gontowski

commit sha 17c77ba703b32c11e127573d414d31c9ec635188

Only use _CVarArgObject on non-ObjC platforms

view details

Brian Gontowski

commit sha 515c371be434ff49debfd145ebd9047bd148d47f

Avoid a warning when not modifying arg

view details

Owen Voorhees

commit sha 970824706513f8a62c5f8ca01837ddc499f8583e

[SE-0284] Lift the 1-vararg-per-function restriction [SE-0284] Add round_trip_parse_gen tests [SE-0284] Add missing test cases

view details

Dan Zheng

commit sha 8102d9194189760be7eb5512584cc8cbf0366ed8

[AutoDiff] Make `DifferentiableActivityInfo::dump` print an end marker. End markers are useful for FileCheck.

view details

Dan Zheng

commit sha 48c048f34d3e28743f2c7b88a013a22b76d79bf3

[AutoDiff] Fix PullbackCloner tangent value category mismatch issues. Fix SIL pullback function type calculation: remap original `unowned` results to the correct pullback parameter convention depending on the `TangentVector` type lowering. Make `PullbackCloner` visitors for the following instructions check and handle tangent value categories: `struct`, `struct_extract`, `tuple`, `destructure_tuple`. Add differentiation tests for `Optional` struct and class stored properties, exercising the instruction visitors above. Resolves SR-13430.

view details

Adrian Prantl

commit sha 4b9cf31ba0dd8cc00aa9385507f6269e65230fe6

Add a callback to swift::reflection::MemoryReader that allows LLDB to provide swift::reflection::TypeInfo for (Clang-)imported non-Objective-C types. This is needed to reflect on the size mixed Swift / Clang types, when no type metadata is available for the C types. This is a necessary ingredient for the TypeRef-based Swift context in LLDB. Because we do not have reflection metadata for pure C types in Swift, reflection cannot compute TypeInfo for NominalTypeRefs for those types. By providing this callback, LLDB can supply this information for DWARF, and reflection can compute TypeInfos for mixed Swift/C types.

view details

Adrian Prantl

commit sha 961dc59cf5ff026ab3de174a44c915daf7dc9941

Thread Labels through TupleTypeRef.

view details

Adrian Prantl

commit sha 9287707520b1266b23bc625a18e6075204f81e90

Support generic parent contexts in DemanglingForTypeRef.

view details

Adrian Prantl

commit sha 9b5b265306a90cf1f3809c729b3ce803318d77f9

Take TypeInfoProvider into account when caching TypeInfos.

view details

Adrian Prantl

commit sha 56b2e906da8c844b5746bbfd752f3504fd936290

Support MetatypeTypeRefs in DemanglingForTypeRef.

view details

Yuta Saito

commit sha 43fb346b6795b0885b82d7c943e33566bb4923f6

[Frontend] Set up output file .swiftmodule.summary This patch focus on teaching frontend and driver to emit this file. The actual serialization and deserialization implementation will come later.

view details

Nathan Hawes

commit sha cf60b2fe610616dd8f3dd7838a0cee7f0090eee7

[CodeCompletion] Pass the CodeCompletionExpr rather than just the base expression to the DotExpr completion callback.

view details

Nathan Hawes

commit sha fe9df72d554aa15d2d0ccc933c213938953c1c79

[CodeCompletion] Add initial implementation of solver-based member completion. This hooks up member completion to the new typeCheckForCodeCompletion API to generate completions from all solutions the constraint solver produces (include ones requiring fixes) rather than relying purely the single solution being applied to the AST (if any). This lets us still give completion results in ambiguous and invalid code.

view details

Pavel Yaskevich

commit sha a49404d593c36056158cded398f97aeb3b37c8e6

[CodeCompletion] Adjust `DotExprLookup::sawSolution` to use new `Solution` APIs

view details

Pavel Yaskevich

commit sha 5bd19d28ac82b137d266909cdf90946fa02ae738

[CSSolver] add debug logging to `solveForCodeCompletion`

view details

Pavel Yaskevich

commit sha 53de10fd3cb7d10eb7d2845e922029867b24da60

[CSSolver] Update expression after constraint generation while solving for code completion

view details

push time in a month

push eventapple/swift

Kuba (Brecka) Mracek

commit sha 58f2ae695b69226df9086d10006574d12165cf0c

Add a SWIFT_STDLIB_STABLE_ABI flag to be able to build the stdlib without -enable-library-evolution (#33443)

view details

push time in a month

delete branch kubamracek/swift

delete branch : stdlib-stable-abi

delete time in a month

pull request commentapple/swift

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option

@swift-ci please test

kubamracek

comment created time in a month

PR opened apple/swift

Reviewers
Add a SWIFT_FREESTANDING_MODULE_NAME CMake option

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option to be able to select the last part of a .swiftmodule filename when building the "freestanding" variant of stdlib. This is needed to bringup building and testing infrastructure for "freestanding".

Eventually, these flags (SWIFT_FREESTANDING_MODULE_NAME, SWIFT_FREESTANDING_TRIPLE_NAME) should go away, but that can only happen once Clang and Swift actually accept "freestanding" or "none" as a target triple.

+13 -1

0 comment

3 changed files

pr created time in a month

create barnchkubamracek/swift

branch : freestanding-module-name

created branch time in a month

pull request commentapple/swift

Add a SWIFT_STDLIB_STABLE_ABI flag to be able to build the stdlib without -enable-library-evolution

@harlanhaskins @jckarter @gottesmm looks good now?

kubamracek

comment created time in a month

pull request commentapple/swift

Add a SWIFT_STDLIB_STABLE_ABI flag to be able to build the stdlib without -enable-library-evolution

@swift-ci please test Windows platform

kubamracek

comment created time in 2 months

delete branch kubamracek/swift

delete branch : revert-28a2826

delete time in 2 months

push eventapple/swift

Kuba (Brecka) Mracek

commit sha d9d929a59454ba9476092e575663cf8f31926918

Revert "Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} (#33388)" (#33924)

view details

push time in 2 months

PR merged apple/swift

Reviewers
Revert "Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE} (#33388)"

Reverting because of https://github.com/apple/swift/pull/33896 which is a big oversight. Better re-try landing the whole thing.

+60 -34

2 comments

4 changed files

kubamracek

pr closed time in 2 months

more