profile
viewpoint
Nikolay Kondratyev kondratyev-nv Moscow, Russia https://linkedin.com/in/kondratyevnv Software developer with strong desire to learn and interest in large-scale software systems, web services, software design and architecture.

mfvanek/pg-index-health 40

pg-index-health is a Java library for analyzing and maintaining indexes health in Postgresql databases.

kondratyev-nv/vscode-python-test-adapter 28

Python Test Adapter for the VS Code Test Explorer

kondratyev-nv/training 1

Solutions to various programming challenges in Java, C++ and Python

kondratyev-nv/awesome-browser-extensions-for-github 0

A collection of awesome browser extensions for GitHub.

kondratyev-nv/awesome-github-extensions 0

A curated list of awesome browser extensions for GitHub. Inspired by awesome-python, which is inspired by awesome-php.

kondratyev-nv/easy-markdown-to-github-pages 0

Convert Markdown files in Github to a full website using Github Pages

kondratyev-nv/hof 0

Higher-order functions for c++

kondratyev-nv/jekyll-theme-littlefox 0

A simple theme for Jekyll based on whiteglass and minima

kondratyev-nv/kondratyev-nv.github.io 0

Personal resume in markdown

kondratyev-nv/latex-template 0

LaTeX templates for PhD thesis and beamer

push eventkondratyev-nv/sdk

Nikolay Kondratyev

commit sha 961a19848a5f8d57d7511c03bc85ea3ed391b633

Fix SDK version parsing from global.json in install script on macOS

view details

push time in 2 days

PR opened dotnet/sdk

Fix SDK version parsing from global.json in install script on macOS

Running install script scripts/obtain/dotnet-install.sh with jsonfile argument works on macOS only when sdk section has a single property version. When sdk section has multiple properties, for example,

"sdk": {
    "version":  "5.0.100-preview.6.20310.4",
    "allowPrerelease": true,
    "rollForward": "major"
  }

a version is detected as 5.0.100-preview.6.20310.4allowPrerelease:truerollForward:major. Also, in a case when version is not the first property in sdk a version can not be detected returning an error dotnet_install: Error: Unable to find the SDK:version node in `global.json`.

The problem seems to be in line:

sdk_list="$(echo -e "${sdk_list}" | tr -d '[[:space:]]')"

On macOS, echo does not have a -e argument, and all lines of key-value pairs in sdk_list are merged into a single line. So, removing it seems to fix it. I don't have a Linux to test the changes, but I hope CI will catch any issues on Linux.

+20 -8

0 comment

5 changed files

pr created time in 2 days

push eventkondratyev-nv/sdk

dotnet-maestro[bot]

commit sha e394ef008a2c11f7719bf25ecdf1c98bcfc75e43

Update dependencies from https://github.com/dotnet/aspnetcore build 20200705.1 (#12336) Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers From Version 5.0.0-preview.8.20354.1 -> To Version 5.0.0-preview.8.20355.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

view details

dotnet-maestro[bot]

commit sha 1b83a735061bc2486607fc95c01bd6996c4c20fe

Update dependencies from https://github.com/dotnet/aspnetcore build 20200705.2 (#12337) Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers From Version 5.0.0-preview.8.20355.1 -> To Version 5.0.0-preview.8.20355.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

view details

Nikolay Kondratyev

commit sha 0a471645b0b79ecff4e2714fb01766005ff6713e

Fix SDK version parsing from global.json in install script on macOS

view details

push time in 2 days

push eventkondratyev-nv/sdk

push time in 2 days

create barnchkondratyev-nv/sdk

branch : fix_install_script_macos

created branch time in 2 days

push eventkondratyev-nv/sdk

Nikolay

commit sha 8c4f53fe5f8eb756351275a51f2182228f0e12f9

Fix SDK version parsing from global.json in install script on macOS

view details

push time in 2 days

fork kondratyev-nv/sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI

https://dot.net/core

fork in 2 days

issue commentkondratyev-nv/vscode-python-test-adapter

Not marking django unittest as passed

@mishagin-tim There was an issue not marking unitttest tests as failed if an error occurred during setUp or setUpClass methods. I've released a version 0.4.4 with a fix. You should see an error now during test execution.

mishagin-tim

comment created time in 3 days

created tagkondratyev-nv/vscode-python-test-adapter

tagv0.4.4

Python Test Adapter for the VS Code Test Explorer

created time in 3 days

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha b1178154c601ecdc267b56b8b41a781a979047df

Changelog for a new version

view details

Nikolay Kondratyev

commit sha a413e9d870f1166be6ed643fbef9925c3d821805

0.4.4

view details

push time in 3 days

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : handle_unittest_setup_errors

delete time in 5 days

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha cb42fcf672c1dd7499fa791a85f28d19cca5e76d

Handle errors during setup for unittest

view details

Nikolay Kondratyev

commit sha 93de471767c23ea0baff6c6d3e2508fc81f0856f

Fix tests

view details

Nikolay Kondratyev

commit sha e4ef138a7a02dec6ae738414c8b4c361911f3ccb

Merge pull request #165 from kondratyev-nv/handle_unittest_setup_errors Handle unittest setup errors

view details

push time in 5 days

issue commentkondratyev-nv/vscode-python-test-adapter

Not marking django unittest as passed

@mishagin-tim Thank you for the issue! Unfortunately, https://github.com/mishagin-tim/tdd-django.git gives me 404, is that ok? I'll try to look through other Django tutorials to reproduce the issue.

mishagin-tim

comment created time in 6 days

issue commentkondratyev-nv/vscode-python-test-adapter

Extension issue

@smarteMBG Thank you for the issue! Unfortunately, I don't see any information to understand what is wrong. Can you please describe what is not working for you? Also, additional information about what Python and what test framework you're using would be of help.

smarteMBG

comment created time in 6 days

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : additional_configuration

delete time in 13 days

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha a98b26b46305796e7b4f0d49324c9a4a1581e104

Add section on Test Explorer UI configuration

view details

Nikolay Kondratyev

commit sha cfc3f1d3dbea39ac716e65f33824118de43c1bd9

Merge pull request #162 from kondratyev-nv/additional_configuration Add section on Test Explorer UI configuration

view details

push time in 13 days

issue commentkondratyev-nv/vscode-python-test-adapter

Colorful output of Sklearn misrepresented

@DanielAtKrypton Thank you for the issue! Python Test Log is provided by the Python extension. So if you're using the Python extension to run your tests, you should report this issue to https://github.com/microsoft/vscode-python. Unfortunately, Python Test Explorer does not show any output during test execution (only after test was completed), so I can't confirm the issue. I will take a look at how output can be shown during test execution and whether Output panel supports colored output.

DanielAtKrypton

comment created time in 16 days

issue commentkondratyev-nv/vscode-python-test-adapter

Panel hides when test passed successfully

@mishagin-tim Thank you for the issue! Have you found a solution to your problem? Just in case, this is Test Explorer UI default behavior, and it can be configured with testExplorer.hideEmptyLog setting. Setting it to false should help.

mishagin-tim

comment created time in 16 days

push eventkondratyev-nv/minesweeper

Deployment Bot (from Travis CI)

commit sha c9d9327b38168bcfdbb48a55bc91ad4d911bfe64

Deploy kondratyev-nv/minesweeper to github.com/kondratyev-nv/minesweeper.git:gh-pages

view details

push time in 18 days

delete branch kondratyev-nv/minesweeper

delete branch : update_dependencies

delete time in 18 days

push eventkondratyev-nv/minesweeper

Nikolay Kondratyev

commit sha 77d9525be23a25168054fe529188baac2fc752d5

Update dependencies

view details

Nikolay Kondratyev

commit sha f0e592b04d72918a84171e66a24bca8bda96b59d

Merge pull request #16 from kondratyev-nv/update_dependencies Update dependencies

view details

push time in 18 days

push eventkondratyev-nv/minesweeper

Nikolay Kondratyev

commit sha 77d9525be23a25168054fe529188baac2fc752d5

Update dependencies

view details

push time in 18 days

PR opened kondratyev-nv/minesweeper

Update dependencies
+2695 -2444

0 comment

2 changed files

pr created time in 18 days

create barnchkondratyev-nv/minesweeper

branch : update_dependencies

created branch time in 18 days

created tagkondratyev-nv/name-genarator-extension

tagv0.1.4

Chrome extension to generate fake names and save them for later use

created time in 20 days

push eventkondratyev-nv/name-genarator-extension

Nikolay Kondratyev

commit sha fb3c2a93f5b18afeb32df207be90040f890dae57

Version bump

view details

Nikolay Kondratyev

commit sha fa4753387f9ff82fb3c1d08a645fcf767a482fb0

0.1.4

view details

push time in 20 days

push eventkondratyev-nv/name-genarator-extension

Nikolay Kondratyev

commit sha e0cd6db99d814eea14decd1b3042913186122330

Version bump

view details

Nikolay Kondratyev

commit sha 5e44faeb0bcd6e2a9403bdf6b51b3bc30f9ed661

0.1.4

view details

push time in 20 days

delete branch kondratyev-nv/name-genarator-extension

delete branch : update_dependencies

delete time in 22 days

push eventkondratyev-nv/name-genarator-extension

Nikolay Kondratyev

commit sha c083ac59d45293e2e70c80e1693969fcc4a17d71

Update dependencies

view details

Nikolay Kondratyev

commit sha 2d4809a25b5f6aed430a5c4d5a5baa51497f72c5

Fix initialization, fix lint error

view details

Nikolay Kondratyev

commit sha c5d7082480d55b4954326f2dab16820032678518

Drop Node.js 8 build

view details

Nikolay Kondratyev

commit sha 057b063e8c905f1c4eca794aa7e0d3be72eaf817

Merge pull request #9 from kondratyev-nv/update_dependencies Update dependencies

view details

push time in 22 days

push eventkondratyev-nv/name-genarator-extension

Nikolay Kondratyev

commit sha c5d7082480d55b4954326f2dab16820032678518

Drop Node.js 8 build

view details

push time in 22 days

push eventkondratyev-nv/name-genarator-extension

Nikolay Kondratyev

commit sha 2d4809a25b5f6aed430a5c4d5a5baa51497f72c5

Fix initialization, fix lint error

view details

push time in 22 days

issue closedkondratyev-nv/vscode-python-test-adapter

Fix python.testing.cwd resolution

Settings:

{
   "python.pythonPath": "python",
   "python.testing.pytestEnabled": true,
   "python.testing.cwd": "test"
}

Error during discovery:

2020-06-09T10:30:35.956Z info at 'pytest' [pytest runner]: Discovering tests using python path 'python' in test
2020-06-09T10:30:35.957Z info at 'pytest' [pytest runner]: Running pytest wrapper with arguments: --collect-only,--doctest-modules
2020-06-09T10:30:35.961Z crit at 'pytest' [pytest runner]: Test loading failed: Error occurred during process execution: Error: spawn python ENOENT

Changing python.testing.cwd to ./test or an absolute path fixes the problem.

closed time in 22 days

kondratyev-nv

issue commentkondratyev-nv/vscode-python-test-adapter

Fix python.testing.cwd resolution

Fixed in release 0.4.3.

kondratyev-nv

comment created time in 22 days

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@pchomik I've published a new version 0.4.3 with the fix regarding cwd path (#158). Please, update and let me know if the problem persists.

pchomik

comment created time in 22 days

create barnchkondratyev-nv/name-genarator-extension

branch : update_dependencies

created branch time in 23 days

created tagkondratyev-nv/vscode-python-test-adapter

tagv0.4.3

Python Test Adapter for the VS Code Test Explorer

created time in 25 days

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha c7675bcb62232319ba9e6aad9c9f15cca2331d62

Changelog for a new version

view details

Nikolay Kondratyev

commit sha 5d84b8c222ccf2d646f66ea6eb871e5425931b69

0.4.3

view details

push time in 25 days

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : fix_cwd_resolution

delete time in a month

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 394ae053cf930658b42b3d70392a4b63fa1de116

Fix cwd resolution

view details

Nikolay Kondratyev

commit sha 14b8e5fec8fac29ff4fbcc926e14506302381521

Merge pull request #159 from kondratyev-nv/fix_cwd_resolution Fix cwd resolution

view details

push time in a month

create barnchkondratyev-nv/vscode-python-test-adapter

branch : fix_cwd_resolution

created branch time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@pchomik Yeah, it looks like there is some problem with resolving cwd path (absolute and ./test pathes works fine). I've created an issue to fix it - https://github.com/kondratyev-nv/vscode-python-test-adapter/issues/158.

pchomik

comment created time in a month

issue openedkondratyev-nv/vscode-python-test-adapter

Fix python.testing.cwd resolution

Settings:

{
   "python.pythonPath": "python",
   "python.testing.pytestEnabled": true,
   "python.testing.cwd": "test"
}

Error during discovery:

2020-06-09T10:30:35.956Z info at 'pytest' [pytest runner]: Discovering tests using python path 'python' in test
2020-06-09T10:30:35.957Z info at 'pytest' [pytest runner]: Running pytest wrapper with arguments: --collect-only,--doctest-modules
2020-06-09T10:30:35.961Z crit at 'pytest' [pytest runner]: Test loading failed: Error occurred during process execution: Error: spawn python ENOENT

Changing python.testing.cwd to ./test or an absolute path fixes the problem.

created time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@pchomik Glad that you've got it working! I think I've got an idea of what is going wrong. One of the parts that differ in logs is the current working directory. Discovering tests using python path '...' in test vs Discovering tests using python path '...' in /home/user/Repos/github/test I've tried to set python.testing.cwd to a non-existing path and got the same error - ENOENT. So changing python.testing.cwd might help. And just to make sure, can you describe your folder structure? What folder is opened in VSCode and does test folder exists under the folder you've opened?

pchomik

comment created time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@pchomik Well, I've checked how the extension works with virtualenv, and don't see any issues. Usually, ENOENT error means that an executable not found. Does file /home/user/Repos/github/test/venv/bin/python exist? I've also tried to install version 0.3.4 and test discovery works fine (execution, however, fails). Do you have any other values in settings? Like python.testing.pytestArgs, for example.

pchomik

comment created time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@Hanspagh Yeah, I've looked through the Python extension documentation and it looks like python.pythonPath can be set to a folder. I'll try to support it as well, but it looks like this issue does not have a lot in common with the original one, so I've created another - https://github.com/kondratyev-nv/vscode-python-test-adapter/issues/157.

pchomik

comment created time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@Hanspagh I'm new to poetry, but following their example and setting python.pythonPath to /Users/<username>/Library/Caches/pypoetry/virtualenvs/poetry-demo-U7oW9SQj-py2.7/bin/python worked for me just fine. As I can see in your log messages your python.pythonPath is set to /Users/hanspagh/Library/Caches/pypoetry/virtualenvs/caf-TOl5zFmu-py3.7 which in my case is a folder. Python executable should be a little bit further in /Users/hanspagh/Library/Caches/pypoetry/virtualenvs/caf-TOl5zFmu-py3.7/bin/python and python.pythonPath expects a path to an executable. (However, I'm not sure setting python.pythonPath to some hidden path to a cache is a good idea).

Please, try to set python.pythonPath to a path to a Python executable.

pchomik

comment created time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Test discovery failing from 0.3.5

@pchomik Thank you for the issue! From the logs it looks like you're using different Python executables (just python in the first log and /home/test/.pyenv/versions/testvscode/bin/python in the second). Can you try to use python executable from virtualenv or from your system? Just to check if it works, maybe there are some incompatibility with pyenv. I will also try to reproduce the problem with pyenv.

I checked the script embedded in the plugin and it is working if executed from separate file. I added some logging to plugin but looks like script is not executed at all because I don't see any debug logs (I wrote them into file).

Are you talking about pytest-describe plugin?

@Hanspagh Do you have the same problem? Do you use pyenv as well?

pchomik

comment created time in a month

delete branch kondratyev-nv/minesweeper

delete branch : dependabot/npm_and_yarn/websocket-extensions-0.1.4

delete time in a month

push eventkondratyev-nv/minesweeper

dependabot[bot]

commit sha 5da0ec03cf59060708666d9081d93cf344fe7385

Bump websocket-extensions from 0.1.3 to 0.1.4 Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nikolay Kondratyev

commit sha 02f147df31e29b22b76c4f30b39d9670ea1421bb

Merge pull request #15 from kondratyev-nv/dependabot/npm_and_yarn/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4

view details

push time in a month

PR merged kondratyev-nv/minesweeper

Bump websocket-extensions from 0.1.3 to 0.1.4 dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

issue commentkondratyev-nv/vscode-python-test-adapter

Hierarchical grouping

@TommasoBendinelli Thank you for the issue! I will consider some options, but I believe, it can lead to a lot of unnecessary levels. What kind of framework are you using? And if it is possible, please, provide an example of your directory structure.

TommasoBendinelli

comment created time in a month

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : update_dependencies

delete time in a month

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 7b060470f83ac328d04a33c6f4b7d9d00a3f060a

Update dependencies

view details

Nikolay Kondratyev

commit sha 89b91b92546b1357127bfc70d9e14e42ed340d09

Merge pull request #154 from kondratyev-nv/update_dependencies Update dependencies

view details

push time in a month

create barnchkondratyev-nv/vscode-python-test-adapter

branch : update_dependencies

created branch time in a month

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : refactor_errored_suites

delete time in a month

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha da8aaa09cc42b2e2a5fa630d53ce1700d24afa07

Refactor errored suites reporting to new API

view details

Nikolay Kondratyev

commit sha 1a2beeba0a90cc9c4640f203992664b281d3c324

Fix test explorer API version

view details

Nikolay Kondratyev

commit sha dd5fbf5f95dde89eb9a4b39e1274141b0f9afb23

Merge pull request #153 from kondratyev-nv/refactor_errored_suites Refactor errored suites reporting to new API

view details

push time in a month

PR merged kondratyev-nv/vscode-python-test-adapter

Refactor errored suites reporting to new API

Adapting changes from https://github.com/hbenl/vscode-test-explorer/issues/130.

+145 -219

0 comment

16 changed files

kondratyev-nv

pr closed time in a month

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 1a2beeba0a90cc9c4640f203992664b281d3c324

Fix test explorer API version

view details

push time in a month

PR opened kondratyev-nv/vscode-python-test-adapter

Refactor errored suites reporting to new API

Adapting changes from https://github.com/hbenl/vscode-test-explorer/issues/130.

+141 -215

0 comment

14 changed files

pr created time in a month

issue commenthbenl/vscode-test-explorer

Allow test suites to report errors like tests

What you describe is a good workaround, but there shouldn't be a need for adapter authors to come up with workarounds. And since the ability to mark a suite as "errored" keeps coming up, I guess it's time to support it.

Sorry, I did not mean that doing nothing is the way. It would be amazing if tests and suites can be conveniently marked as errored.

However, I believe that suites should not be in errored state by themselves. Suites should always aggregate children states, this behavior is expected and already works. For example, errored suite makes no sense if all children in it can pass. So, IMO view and behavior should be similar to what is now achieved with workarounds. If there would be a more straightforward way to do so - awesome!

rossknudsen

comment created time in 2 months

issue commenthbenl/vscode-test-explorer

Allow test suites to report errors like tests

In Python Test Explorer, I create nodes for tests/files that have invalid tests (for example, file parsing issues), and I also fire a test event with errored state and a stacktrace in message for them just after finished event. By clicking on such test full stacktrace is shown in Output panel. Parent nodes are already maked errored as well in this case. image

IMO, there is no need to have anything special for such cases. Tooltips are inconvenient for errors and showing errors from all invalid tests by clicking on a suite would look messy in the Output.

rossknudsen

comment created time in 2 months

issue commenthbenl/vscode-test-explorer

[Question] are there any plans to support c#(dotnet)?

@arnotes A couple of days ago a .Net Core Test Explorer was added to the list of test explorers. You may want to check it out.

arnotes

comment created time in 2 months

issue commentkondratyev-nv/vscode-python-test-adapter

Run py File in Debug Mode

@Anti-Distinctlyminty Thank you for the issue! Can you please check if any of the extensions are not up-to-date? Also, what Python version and what test framework are you using? I'm asking this because it looks like this feature was implemented in Test Explorer UI a couple of days ago - https://github.com/hbenl/vscode-test-explorer/issues/138. And right now I can see debug button for my test suites image

Anti-Distinctlyminty

comment created time in 2 months

issue commentkondratyev-nv/vscode-python-test-adapter

Link to files from line references in test log

@tclose Thank you for the issue! Sorry for the late reply. I've looked through the options on implementing this. As I understood you, there are cases when VSCode doesn't detect that there are paths to test files in the Output. I can see it is the case with the pytest

assert (2 + 2) == 5
def test_two_plus_two_is_five_failed():
>       assert (2 + 2) == 5
E       assert (2 + 2) == 5

test/other_tests/add_test.py:9: AssertionError

test/other_tests/add_test.py is not clickable.

As I understood, VSCode detects file path in the Output by itself and there is no way to change its behavior. Also, at the moment, Python Test Explorer dumps the output that is written by unittest/pytest without any modifications to it, so it is pretty much the same you might expect from a test execution in a command line.

I can suggest adding something like Test failed at <absolute path>:<test function line number> as the first line in the output. Such a link should be detected correctly by the VSCode. Would it help you? I have some doubts about this solution because you've probably got the output from the Test Explorer panel, and it has a "Go to source" button on a test.

tclose

comment created time in 2 months

issue commentkondratyev-nv/vscode-python-test-adapter

Extension Does Not Uninstall Correctly

@Anti-Distinctlyminty Thank you for the issue! This extension consists of two parts - Python Test Explorer itself and its dependency Test Explorer UI. Test Explorer UI provides side panel and common functionality so it can be used by other test explorers (for example, to discover and run C++ tests). Unfortunately, because of that uninstalling Python Test Explorer won't remove Test Explorer UI from your VSCode. Test Explorer panel and Test Explorer log in the Output are provided by Test Explorer UI extension. If you don't have any other Test Explorers and want to remove the side panel, just remove Test Explorer UI extension.

Anti-Distinctlyminty

comment created time in 2 months

issue closedkondratyev-nv/vscode-python-test-adapter

Missing CHANGELOG.md

Could you add a CHANGELOG.md file for that we can see difference between version?

closed time in 2 months

CodeTroopers

issue commentkondratyev-nv/vscode-python-test-adapter

Missing CHANGELOG.md

@CodeTroopers I've just published a new version 0.4.2 with the CHANGELOG.md.

CodeTroopers

comment created time in 2 months

issue commentkondratyev-nv/vscode-python-test-adapter

Test state not saved

@Manouchka94 I've just published a new version 0.4.2 with the fix for this issue. Please, update and let me know if the problem persists.

Manouchka94

comment created time in 2 months

created tagkondratyev-nv/vscode-python-test-adapter

tagv0.4.2

Python Test Adapter for the VS Code Test Explorer

created time in 2 months

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 4785807ca249df8d820786456d6fa1f9ad2cb164

0.4.2

view details

push time in 2 months

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : update_dependencies

delete time in 2 months

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 72b421e451cfd12246cc2d8384fcedb9a67081ae

Upadate dependencies, add CHANGELOG

view details

Nikolay Kondratyev

commit sha 78ceee5acd247a2d7923437255fadfc6e1e344dc

Merge pull request #150 from kondratyev-nv/update_dependencies Upadate dependencies, add CHANGELOG

view details

push time in 2 months

create barnchkondratyev-nv/vscode-python-test-adapter

branch : update_dependencies

created branch time in 2 months

delete branch kondratyev-nv/vscode-python-test-adapter

delete branch : force_xunit_version

delete time in 2 months

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha 7d90e8b3f1e09a5fb5578f954c273a8f44808dae

Force pytest to use xunit1 report

view details

Nikolay Kondratyev

commit sha d5078b8572453878d4ad2fd46092b6745a4a0f37

Change order of arguments to correctly override junit_family

view details

Nikolay Kondratyev

commit sha ebdbb6c88aa743c2e57d93b00a1ae7c2ff58ebe4

Merge pull request #149 from kondratyev-nv/force_xunit_version Force pytest to use xunit1 report

view details

push time in 2 months

push eventkondratyev-nv/vscode-python-test-adapter

Nikolay Kondratyev

commit sha d5078b8572453878d4ad2fd46092b6745a4a0f37

Change order of arguments to correctly override junit_family

view details

push time in 2 months

create barnchkondratyev-nv/vscode-python-test-adapter

branch : force_xunit_version

created branch time in 2 months

issue commentkondratyev-nv/vscode-python-test-adapter

Extension issue

@MHKamel Thank you for the issue! Unfortunately, I don't see any information to understand what is wrong. Can you please describe what is not working for you? Also, additional information about what Python and what test framework you're using would be of help.

MHKamel

comment created time in 2 months

more