profile
viewpoint
Jakub Naskręski kleyu Wrocław 👋

gatsbyjs/gatsby 47977

Build blazing fast, modern apps and websites with React

kleyu/ac3-state-management-examples 0

✨ Learn Apollo Client 3's state management best practices

kleyu/blogApp 0

crud-rest blog app

kleyu/carbon-components-react 0

React components for the Carbon Design System

kleyu/carbon-tutorial 0

An app for the Carbon Design System tutorial

kleyu/carbon-website 0

The website for the Carbon Design System.

kleyu/clientPanel 0

⚛ React Client Panel with Firebase and Redux integration

kleyu/contactManager 0

⚛ React contact manager with context and redux

kleyu/contribute-to-open-source 0

Learn the GitHub workflow by contributing code in a fun simulation project

release simonhaenisch/md-to-pdf

v3.1.2

released time in 21 days

issue commentsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

Wow, that was fast! Thanks!

petergardfjall

comment created time in 21 days

issue commentsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

3.1.2 is published on npm now 🤓 cheers 🎉

petergardfjall

comment created time in 21 days

release simonhaenisch/md-to-pdf

v3.1.1

released time in 21 days

push eventsimonhaenisch/md-to-pdf

simonhaenisch

commit sha 77e91cda6749f444bed996b24e186fd92dbac1f5

chore: satisfy linter

view details

push time in 21 days

issue closedsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

Context:

  • version (md-to-pdf -v): 3.1.1
  • platform (Unix, macOS, Windows): Linux
  • node version: v12.19.0

Describe the bug:

It seems like the used version of marked (v1.1.1) has a problem in rendering emphasis with asterisks (https://github.com/markedjs/marked/issues/1754).

For example, the following example

$ echo "*A pigeon*: a  type of *bird*" | md-to-pdf --as-html

I would expect to result in HTML such as

<body class="">
<p><em>A pigeon</em>: a  type of <em>bird</em></p>
</body></html>

Actually results in:

<body class="">
<p><em>A pigeon*: a  type of *bird</em></p>
</body></html>

The fix appears to be fixed in marked v1.1.2 (https://github.com/markedjs/marked/issues/1754#issuecomment-713628483) so please consider upgrading.

closed time in 21 days

petergardfjall

created tagsimonhaenisch/md-to-pdf

tagv3.1.2

Hackable CLI tool for converting Markdown files to PDF using Node.js and headless Chrome.

created time in 21 days

push eventsimonhaenisch/md-to-pdf

simonhaenisch

commit sha 4e9de494acfb48786b389616bbf93cc9f6ac5dca

chore: update dependencies

view details

simonhaenisch

commit sha 566b901985b8f9d66a3b565a1ba78faadb2aab74

fix: update marked because of bugs with asterisk emphasis Fixes #78.

view details

simonhaenisch

commit sha d9d1dc851a1105bbc33b5019630fd0a2d4248f08

chore(release): 3.1.2

view details

push time in 21 days

PR closed simonhaenisch/md-to-pdf

fix asterisk emphasis rendering by upgrading marked library

marked v1.1.1 has a problem in rendering emphasis with asterisks (see https://github.com/markedjs/marked/issues/1754).

For example,

echo "*A pigeon*: a  type of *bird*" | md-to-pdf --as-html

renders as

<body class="">
<p><em>A pigeon</em>: a  type of <em>bird</em></p>
</body></html>

instead of the expected:

<body class="">
<p><em>A pigeon*: a  type of *bird</em></p>
</body></html>

Version 1.1.2 resolves this issue (see https://github.com/markedjs/marked/issues/1754#issuecomment-713628483).

+4 -4

1 comment

2 changed files

petergardfjall

pr closed time in 21 days

pull request commentsimonhaenisch/md-to-pdf

fix asterisk emphasis rendering by upgrading marked library

Thanks however I'd rather update to the latest version (1.2.3) which I've already done, plus I've also updated all the other dependencies :nerd_face:

Thanks for the PR though!

petergardfjall

comment created time in 21 days

issue commentsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

@simonhaenisch I just submitted a PR: https://github.com/simonhaenisch/md-to-pdf/pull/79

petergardfjall

comment created time in 21 days

PR opened simonhaenisch/md-to-pdf

fix asterisk emphasis rendering by upgrading marked library

marked v1.1.1 has a problem in rendering emphasis with asterisks (see https://github.com/markedjs/marked/issues/1754).

For example,

echo "*A pigeon*: a  type of *bird*" | md-to-pdf --as-html

renders as

<body class="">
<p><em>A pigeon</em>: a  type of <em>bird</em></p>
</body></html>

instead of the expected:

<body class="">
<p><em>A pigeon*: a  type of *bird</em></p>
</body></html>

Version 1.1.2 resolves this issue (see https://github.com/markedjs/marked/issues/1754#issuecomment-713628483).

+4 -4

0 comment

2 changed files

pr created time in 21 days

issue commentsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

Thanks for the issue, yeah i'll upgrade now!

petergardfjall

comment created time in 21 days

issue openedsimonhaenisch/md-to-pdf

bug: Wrong rendering of emphasis using asterisks

Context:

  • version (md-to-pdf -v): 3.1.1
  • platform (Unix, macOS, Windows): Linux
  • node version: v12.19.0

Describe the bug:

It seems like the used version of marked (v1.11.1) has a problem in rendering emphasis with asterisks (https://github.com/markedjs/marked/issues/1754).

For example, the following example

$ echo "*A pigeon*: a  type of *bird*" | md-to-pdf --as-html

I would expect to result in HTML such as

<body class="">
<p><em>A pigeon</em>: a  type of <em>bird</em></p>
</body></html>

Actually results in:

<body class="">
<p><em>A pigeon*: a  type of *bird</em></p>
</body></html>

The fix appears to be fixed in marked v1.11.2 (https://github.com/markedjs/marked/issues/1754#issuecomment-713628483) so please consider upgrading.

created time in 21 days

startedrabbitmq/ra

started time in a month

create barnchkleyu/next.js

branch : master

created branch time in 2 months

issue commentsimonhaenisch/md-to-pdf

feature: Render Markdown with inline PlantUML

No I don't think it's exposed yet (only options which includes the renderer) but I'm open to PRs for that 🤓 (I don't have much free time at the moment)

hantatsang

comment created time in 2 months

issue commentsimonhaenisch/md-to-pdf

Auto numbering for headings

I also prefer the "with a custom renderer" way of accomplishing it, this feature would be awesome :heart:.

simonhaenisch

comment created time in 2 months

issue commentsimonhaenisch/md-to-pdf

feature: Render Markdown with inline PlantUML

@simonhaenisch is the parser exposed? Can you provide an example on how to extend it? This sounds very interesting! :heart_eyes:

hantatsang

comment created time in 2 months

pull request commentsimonhaenisch/md-to-pdf

WIP - Add table of content option and generation

--toc-depth=0 will only makes links to not be generated. But the wrapper's title of the TOC will still be generated.

I can just add a check for toc-depth=0 in this condition if (html.includes('<!-- TOC -->') && toc.length !== 0) { to fix this or add another parameter as suggested by @MangelMaxime.

scandinave

comment created time in 2 months

push eventsimonhaenisch/md-to-pdf

simonhaenisch

commit sha f9bd305247d94e21e56efafe8837d3d7947401ae

chore: update dependencies

view details

push time in 3 months

pull request commentsimonhaenisch/md-to-pdf

WIP - Add table of content option and generation

Could just use --toc-depth=0 to disable it, I guess.

scandinave

comment created time in 3 months

issue closedsimonhaenisch/md-to-pdf

bug: Got error while installing

Context:

  • version (md-to-pdf -v): 3.1.0
  • platform (Unix, macOS, Windows): Windows
  • node version: 10.9.0

Describe the bug:

Got error while installing package

C:\>npm i -g md-to-pdf
C:\Users\Albert\AppData\Roaming\npm\md2pdf -> C:\Users\Albert\AppData\Roaming\np
m\node_modules\md-to-pdf\dist\cli.js
C:\Users\Albert\AppData\Roaming\npm\md-to-pdf -> C:\Users\Albert\AppData\Roaming
\npm\node_modules\md-to-pdf\dist\cli.js

> puppeteer@5.2.1 install C:\Users\Albert\AppData\Roaming\npm\node_modules\md-to
-pdf\node_modules\puppeteer
> node install.js

(node:9192) ExperimentalWarning: The fs.promises API is experimental
Downloading Chromium r782078 - 149.7 Mb [====================] 100% 0.0s
ERROR: Failed to set up Chromium r782078! Set "PUPPETEER_SKIP_DOWNLOAD" env vari
able to skip download.
{ [Error: EEXIST: file already exists, mkdir 'C:\Users\Albert\AppData\Roaming\np
m\node_modules\md-to-pdf\node_modules\puppeteer\.local-chromium\win64-782078']
  errno: -4075,
  code: 'EEXIST',
  syscall: 'mkdir',
  path:
   'C:\\Users\\Albert\\AppData\\Roaming\\npm\\node_modules\\md-to-pdf\\node_modu
les\\puppeteer\\.local-chromium\\win64-782078' }
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.2 (node_modules\md
-to-pdf\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@
2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}
)
npm WARN ws@7.3.1 requires a peer of bufferutil@^4.0.1 but none is installed. Yo
u must install peer dependencies yourself.
npm WARN ws@7.3.1 requires a peer of utf-8-validate@^5.0.2 but none is installed
. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! puppeteer@5.2.1 install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the puppeteer@5.2.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Albert\AppData\Roaming\npm-cache\_logs\2020-09-01T03_05_35
_042Z-debug.log

But I successfully installed version 3.0.0

closed time in 3 months

AlSharp

issue commentsimonhaenisch/md-to-pdf

bug: Got error while installing

Well the relevant part of the error message is

{ [Error: EEXIST: file already exists, mkdir 'C:\Users\Albert\AppData\Roaming\np
m\node_modules\md-to-pdf\node_modules\puppeteer\.local-chromium\win64-782078']
  errno: -4075,
  code: 'EEXIST',
  syscall: 'mkdir',
  path:
   'C:\\Users\\Albert\\AppData\\Roaming\\npm\\node_modules\\md-to-pdf\\node_modu
les\\puppeteer\\.local-chromium\\win64-782078' }

Try deleting the folder C:\Users\Albert\AppData\Roaming\npm\node_modules\md-to-pdf\node_modules\puppeteer\.local-chromium\win64-782078 first. Not sure why the chromium installer fails to overwrite it but this is most likely a bug with puppeteer.

AlSharp

comment created time in 3 months

issue openedsimonhaenisch/md-to-pdf

bug:

Context:

  • version (md-to-pdf -v): 3.1.0
  • platform (Unix, macOS, Windows): Windows
  • node version: 10.9.0

Describe the bug:

Got error while installing package

C:\>npm i -g md-to-pdf
C:\Users\Albert\AppData\Roaming\npm\md2pdf -> C:\Users\Albert\AppData\Roaming\np
m\node_modules\md-to-pdf\dist\cli.js
C:\Users\Albert\AppData\Roaming\npm\md-to-pdf -> C:\Users\Albert\AppData\Roaming
\npm\node_modules\md-to-pdf\dist\cli.js

> puppeteer@5.2.1 install C:\Users\Albert\AppData\Roaming\npm\node_modules\md-to
-pdf\node_modules\puppeteer
> node install.js

(node:9192) ExperimentalWarning: The fs.promises API is experimental
Downloading Chromium r782078 - 149.7 Mb [====================] 100% 0.0s
ERROR: Failed to set up Chromium r782078! Set "PUPPETEER_SKIP_DOWNLOAD" env vari
able to skip download.
{ [Error: EEXIST: file already exists, mkdir 'C:\Users\Albert\AppData\Roaming\np
m\node_modules\md-to-pdf\node_modules\puppeteer\.local-chromium\win64-782078']
  errno: -4075,
  code: 'EEXIST',
  syscall: 'mkdir',
  path:
   'C:\\Users\\Albert\\AppData\\Roaming\\npm\\node_modules\\md-to-pdf\\node_modu
les\\puppeteer\\.local-chromium\\win64-782078' }
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.2 (node_modules\md
-to-pdf\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@
2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}
)
npm WARN ws@7.3.1 requires a peer of bufferutil@^4.0.1 but none is installed. Yo
u must install peer dependencies yourself.
npm WARN ws@7.3.1 requires a peer of utf-8-validate@^5.0.2 but none is installed
. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! puppeteer@5.2.1 install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the puppeteer@5.2.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Albert\AppData\Roaming\npm-cache\_logs\2020-09-01T03_05_35
_042Z-debug.log

But I successfully installed version 3.0.0

created time in 3 months

pull request commentsimonhaenisch/md-to-pdf

WIP - Add table of content option and generation

Hello,

I wonder what will happen for people using an extension to manage their TOC.

Like Markdown TOC in VSCode.

<!-- TOC -->

- [Title 1](#title-1)
    - [Title 1.1](#title-11)
- [Title 2](#title-2)
- [Title 2.2](#title-22)

<!-- /TOC -->

# Title 1

## Title 1.1

# Title 2

# Title 2.2

I suppose you are using <!-- TOC --> presence to trigger the TOC generation and so in this case the output file with have 2 TOC in it.

If that's the case, I think it would be nice to add a new options to control if TOC should be generated or not and use <!-- TOC --> to know the position where the TOC should be placed in the file.

scandinave

comment created time in 3 months

more