profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kjin/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Kelvin Jin kjin Sunnyvale, CA JavaScript & Node.js @ Google

google/closure-library 4201

Google's common JavaScript library

google/gts 3597

☂️ TypeScript style guide, formatter, and linter.

jleyba/js-dossier 136

A JavaScript documentation generation tool.

kjin/ansi-styles 0

ANSI escape codes for styling strings in the terminal

kjin/ansi-to-svg 0

😹 convert ANSI Escaped CLI strings to SVGs

kjin/ascomposer 0

🎵 Write MIDI sequences in plaintext

pull request commentlibuv/libuv

linux: support hierarchies and cgroup2 for mem constraint lookup

If this PR remains stuck on the change-requested flag even after a third reviewer, I'd be inclined to open a new one, but I'd like to get blessing for that by an owner of libuv first.

kjin

comment created time in 2 days

pull request commentlibuv/libuv

linux: support hierarchies and cgroup2 for mem constraint lookup

Hi @bnoordhuis, do you mind reviewing this PR, or at least resolving the change request? It seems like quite a few people have been hoping to seeing this land. If you're busy, it would be good to perhaps assign a different reviewer to help move this forward? Thanks!

kjin

comment created time in 7 days

issue commentgoogle/closure-library

Include `webkitFullscreenEnabled` in `goog.dom.fullscreen.isSupported`

The PR is merged, so I think we can close this!

camador-lucid

comment created time in 9 days

issue closedgoogle/closure-library

Include `webkitFullscreenEnabled` in `goog.dom.fullscreen.isSupported`

https://github.com/google/closure-library/blob/d760c8461a57f41cea6f191138bc457b42226322/closure/goog/dom/fullscreen.js#L76

This line is causing some issues in our applications. Should it be (body.webkitRequestFullscreen && doc.webkitFullscreenEnabled) ||? Following https://developer.apple.com/documentation/webkitjs/document/1630333-webkitfullscreenenabled

closed time in 9 days

camador-lucid

pull request commentlibuv/libuv

linux: support hierarchies and cgroup2 for mem constraint lookup

Ok, I've rebased and resolved the conflict -- which occurred due to part of uv__read_cgroups_uint64 being refactored into a common uv__slurp function in 1a890036351897967a77849f4709a98b70c461ef. If CI passes I believe this should be ready to go!

kjin

comment created time in 9 days

push eventkjin/libuv

Kelvin Jin

commit sha 1dc3cc17eaed4820f5c7399bdf861175b0594752

linux: support hierarchies and cgroup2 for mem constraint lookup

view details

push time in 9 days

push eventkjin/libuv

Jameson Nash

commit sha 8763476155c4a2a496e9134af25b2b8b87a07ccb

Add SHA to ChangeLog

view details

Jameson Nash

commit sha 574c49f07fd4142aadf7657affbf73ad322da752

Now working on version 1.42.1 Fixes: https://github.com/libuv/libuv/issues/3202

view details

Jameson Nash

commit sha bd7fcf1bfc411c4a57141002f97a163d6a00a925

run test named ip6_sin6_len This appears to have been missed in the original PR. Refs: https://github.com/libuv/libuv/pull/2492 Refs: https://github.com/libuv/libuv/issues/2655 (fixes one issue listed) PR-URL: https://github.com/libuv/libuv/pull/3246 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

Mohamed Edrah

commit sha 84c057a357bcf5f67ba3fdfde3e8e22e1693074f

docs: fix wrong information about scheduling Fixes: https://github.com/libuv/libuv/issues/3252 PR-URL: https://github.com/libuv/libuv/pull/3253 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jameson Nash <vtjnash@gmail.com>

view details

Jameson Nash

commit sha 04289fa326b790c1a4abb236d1f9d913bacfc8c6

unix: protect fork in uv_spawn from signals Years ago, we found that various kernels (linux, macOS) were known to fail if they try to deliver a signal during this syscall, so we prevent that from happening. They may have fixed those issues, but it is generally just a bad time for signals to arrive (glibc blocks them here, for example, including some more internal ones that it won't let us touch here). We try to be a bit conservative, and leave many signals unblocked which could happen during normal execution and should terminate the process if they do. There is a small race window after the child starts before we clear the old handlers, if the user was to send an fake signal from elsewhere, but that should be quite unlikely. PR-URL: https://github.com/libuv/libuv/pull/3251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Supragya Raj

commit sha 6530ea2ff243161b4208aed9549fe2e4c6acc563

drop only successfully sent packets post sendmmsg sendmmsg returns with number of packets sent which can be less than number of packets requested to be sent. Do not flush entire write queue and use the returned info to partially clear the write queue. Refs: https://github.com/libuv/libuv/issues/3129 (fixes one issue listed) PR-URL: https://github.com/libuv/libuv/pull/3265 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

Ikko Ashimine

commit sha 50c337a0b177669410efef83541e6f17c63ff5b0

test: fix typo in test-tty-escape-sequence-processing.c postion -> position in several comments PR-URL: https://github.com/libuv/libuv/pull/3284 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jameson Nash <vtjnash@gmail.com>

view details

Sylvain Corlay

commit sha 66a3053e70496f2bad851aa0643032e5e98147bb

cmake: use standard installation layout always Fixes: https://github.com/libuv/libuv/issues/3074 PR-URL: https://github.com/libuv/libuv/pull/3084 Reviewed-By: Jameson Nash <vtjnash@gmail.com>

view details

earnal

commit sha 7024f8b2422880568150b2605d9035fa2a597346

win,spawn: allow UNC path with forward slash Fixes: https://github.com/libuv/libuv/issues/3159 PR-URL: https://github.com/libuv/libuv/pull/3167 Reviewed-By: Jameson Nash <vtjnash@gmail.com>

view details

Ben Noordhuis

commit sha a39009a5a9252a566ca0704d02df8dabc4ce328f

win,fsevent: fix uv_fs_event_stop() assert Fix a logic error where calling uv_fs_event_stop() from the event callback tripped on a `handle->dir_handle != INVALID_HANDLE_VALUE` assert in uv_fs_event_queue_readdirchanges(). Fixes: https://github.com/libuv/libuv/issues/3258 PR-URL: https://github.com/libuv/libuv/pull/3259 Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

Kelvin Jin

commit sha 029132c55790f579dc181e7f8d9cec20b2de038c

linux: support hierarchies and cgroup2 for mem constraint lookup

view details

push time in 9 days

push eventkjin/libuv

mattn

commit sha 49cb40c47902dd04c7787e6543e9e13368dc1840

windows: remove duplicated field Fixes build

view details

Saúl Ibarra Corretgé

commit sha a4f88760be1838603fe2eae89a651066cc42eedd

Merge branch 'v1.x'

view details

Elijah Andrews

commit sha 89bc09808f91e170e2486ee63f5a7b1cf0ac28bc

readme: remove Rust from users Closes #1572

view details

Saúl Ibarra Corretgé

commit sha 52ae456b0d666f6f4dbb7f52675f4f131855bd22

Merge branch 'v1.x'

view details

Bert Belder

commit sha 3fd4e1c5eab3933888065059f6f5804e3b0f8a06

win: replace non-ansi characters in source file Closes: joyent/libuv#1581

view details

Bert Belder

commit sha 96d9028107090f70b89923d398ca2ebfeeb7821d

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha ebe495ed02c73e3ddec4a7d3409686ee3659c47f

Merge branch 'v1.x'

view details

Bert Belder

commit sha aa67925fb2eaf6b493822cd252ced9bec48abdbc

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha 182411e98bf650256c9c4789d49df878a321473e

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha c74fe1903c609e6df93183190d78f5e332969dd2

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha db0624a465493931c790445c22227660b88c5a8e

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha 3d1b044968b9d3cbb4cb13ceae6b28d3e2b59ca7

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha 568524397b0bc5efe0101887df9a22c4265f7a51

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha d766e54bcad9c72e3194358af480e7a2d5f842c8

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha b3f9b01c3dcf8a30882ca21ae6df76c03b3f076a

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha d85d606db2e819c6b7549b695d99b662b296a14c

Now working on version 2.0.0

view details

Kári Tristan Helgason

commit sha c82eedd0a76233f0894098853b5a0c307af27064

unix: remove 1.x-compat code from fallback barrier PR-URL: https://github.com/libuv/libuv/pull/875 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Saúl Ibarra Corretgé

commit sha 99438cf020a367fb6b27070a211bf75682ba7b01

Merge branch 'v1.x'

view details

Saúl Ibarra Corretgé

commit sha d7f65293c05a1328307a13787eddeacc0fbd3367

core: add reserved fields to uv_loop_t Same as we do for uv_handle_t and uv_req_t, they may come useful if we need to get creative to keep ABI compatibility. PR-URL: https://github.com/libuv/libuv/pull/967 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Saúl Ibarra Corretgé

commit sha 46dbdd0f9710eaa04a8767a454b9298879d41fa9

macOS: drop support for macOS < 10.9 PR-URL: https://github.com/libuv/libuv/pull/966 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>

view details

push time in 9 days

create barnchkjin/libuv

branch : cgroups-2-prebase

created branch time in 9 days

pull request commentlibuv/libuv

linux: support hierarchies and cgroup2 for mem constraint lookup

Let me give it a try!

kjin

comment created time in 9 days

PullRequestReviewEvent

issue commentgoogle/closure-library

Include `webkitFullscreenEnabled` in `goog.dom.fullscreen.isSupported`

I don't see why not -- would you like to send a PR?

camador-lucid

comment created time in 16 days

push eventkjin/libphonenumber

kkeshava

commit sha 2404172ef485399cd6e13a3016a3287c793d3f60

Metadata updates for release 8.12.25 (#2628)

view details

penmetsaa

commit sha 272b8fc4dfddc262852a8775e9fef651dacce394

Penmetsaa maven update (#2629) * [maven-release-plugin] prepare release v8.12.25 * [maven-release-plugin] prepare for next development iteration

view details

penmetsaa

commit sha 55eafcca0cc5c1a55a7e401e2c3ba2652f58e3ee

Update README.md (#2630)

view details

rohininidhi

commit sha 6b32af1a9fb9db702640fe6cacb8cbb1c3283cff

Metadata updates for release 8.12.26 (#2632)

view details

rohininidhi

commit sha 6193c4fe018bfd19197d919c490064001d6a0d1d

Rnidhi maven update (#2633) * [maven-release-plugin] prepare release v8.12.26 * [maven-release-plugin] prepare for next development iteration

view details

rohininidhi

commit sha 332e0465bed1c32d4e863e6616e469884ed7f882

Update README.md (#2634)

view details

kkeshava

commit sha 326b1a575f776cfbe0be319d15cf4ac9123a0983

Metadata updates for release 8.12.27 (#2637)

view details

kkeshava

commit sha 9953b517e29c1e16ef1e129366cf5e7d75300fb5

Kkeshava maven update (#2638) * [maven-release-plugin] prepare release v8.12.27 * [maven-release-plugin] prepare for next development iteration

view details

kkeshava

commit sha 4359fe263fca8f935ff8b40974fa2323dd659b65

Update README.md (#2639)

view details

rohininidhi

commit sha fee601c60f9d22a50d4e973501c407032cdffcdd

Metadata updates for release 8.12.28 (#2641)

view details

rohininidhi

commit sha dc3749604e8a4625b1426fb7b23b3c16382eec02

Rnidhi maven update (#2642) * [maven-release-plugin] prepare release v8.12.28 * [maven-release-plugin] prepare for next development iteration

view details

rohininidhi

commit sha bda2a5bc54ff37df046b487769defd7f41ca0235

Update README.md (#2643)

view details

penmetsaa

commit sha 5dce00b40bbb4efa44dcd2dc13dd71a0b9284880

Fix AYTF to not format when input numbers are lost in the result. (#2636) Earlier, AYTF is adding additional CC when returning unformatted result - for cases where the input digits are dropped for formatting. Eg: MX case: "+5213314010666" => "+52 +5213314010666". b/183053929 Now we. are proactively ensuring that no formatting is applied, where a format is chosen that would otherwise have led to some digits being dropped. Why the input digits are dropped: - In MX, the mobile token (1) is no more used, so when it is present in input, the formatted result should not contain it. - However when AYTF, we should not be removing the input digits on the fly. - More details in cl/373115460 and b/183053929

view details

penmetsaa

commit sha 041b641b01baf0b8f2a6322445d51648f247fec7

Metadata updates for release 8.12.29 (#2645)

view details

penmetsaa

commit sha 15e96afaad587a778b87216cdad48746c3c63b60

Penmetsaa maven update 8.12.29 (#2646) * [maven-release-plugin] prepare release v8.12.29 * [maven-release-plugin] prepare for next development iteration

view details

penmetsaa

commit sha e831ec21b530c0f54f227142fcff447087a58a97

Update README.md (#2647)

view details

kkeshava

commit sha c0c63d4068eb3b644ac1c14ccf56e99c595e9ee7

Metadata updates for release 8.12.30 (#2649)

view details

kkeshava

commit sha 9a3c49cf48cda7f9ab953e8d1b0c5545cb8665d3

Kkeshava maven update (#2650) * [maven-release-plugin] prepare release v8.12.30 * [maven-release-plugin] prepare for next development iteration

view details

kkeshava

commit sha 9c10e2fb5e8c0c4499bd9d2cc0474b6388c38974

Update README.md (#2651)

view details

rohininidhi

commit sha 20ff76630858f8574466f968c61e430e57be355b

Metadata updates for release 8.12.31 (#2652)

view details

push time in 16 days

pull request commentgoogle/libphonenumber

Replace goog.array API calls with native API equivalents.

Hi @penmetsaa -- can you take a look at this? Thanks!

kjin

comment created time in 16 days

pull request commentfirebase/firebase-js-sdk

Use google-closure-deps instead of depswriter.py.

Ping @sam-gc -- anything else that needs to be done here?

kjin

comment created time in a month

issue commentgoogle/closure-library

`goog.window.open` with "no-referrer" should stop using `document.write`, because of `COOP:same-origin-allow-popup`.

Is there an alternative we can use to accomplish the same thing as calling document.write? I'm not super familiar with the code, but it looks like it's fairly central to what window.open is supposed to do.

ArthurSonzogni

comment created time in a month

push eventgoogle/closure-library

Closure Team

commit sha 5d49bd0bfce837ca002dd987b40b4411da7dfea6

RELNOTES[INC]: Remove the fourth parameter passed to window.open. PiperOrigin-RevId: 388466253 Change-Id: I4d9af2be5d074d8a4994d822fe4293538f2a9f02

view details

Closure Team

commit sha 9b798ef3003913c5314f7679526f2c6578e737e4

Automated rollback of commit 0c7b0687c80bdb742c62cd913c6acb4f488d681d. PiperOrigin-RevId: 388470615 Change-Id: I1f6797c5fb63cfc91c31f5bf28ba139e0fb9392b

view details

Kelvin Jin

commit sha 24820b0e2e0b3551e29a1c72f8dcecb63113fca9

Turn gauge.js into a goog.module and ES6 class. RELNOTES[INC]: Removed 'goog.ui.GaugeColoredRange' as a namespace. PiperOrigin-RevId: 388472393 Change-Id: I675d065c7a18ac041918f7094d8ae69e61efc3d3

view details

push time in 2 months

issue commentgoogle/closure-library

current state

Hi @jt3k -- yes, this library is still alive, though it's mostly developed internally within Google.

jt3k

comment created time in 2 months

push eventgoogle/closure-library

Closure Team

commit sha 1ba22498b9cdcfe989fbc7a6b4b713742fa76563

Add `var` css function name to safestyle allowlist. https://developer.mozilla.org/en-US/docs/Web/CSS/var() Note that safestyle doesn't currently allow nested function calls in the args list. RELNOTES: Add `var` css function name to safestyle allowlist. PiperOrigin-RevId: 385539515 Change-Id: If05e81d6bc6bff516960a41b1530869ae75913ae

view details

Closure Team

commit sha 92bb1650862661a2df6e8db95f9679edf0839428

Add a mention of NativeResolver in the comment of goog.Promise.withResolver. RELNOTES: n/a PiperOrigin-RevId: 385689007 Change-Id: Id7216f10e08dbbe273e75fa0351dbe4029f1a629

view details

John Lenz

commit sha 317f6d17dcebd453dce2f64659eda8abb5ea72c1

Remove unnecessarily suppressions from test files. RELNOTES: n/a PiperOrigin-RevId: 385902582 Change-Id: I4be156896a759a6eb4b4d9314a1e242f72300753

view details

John Lenz

commit sha ee9687c6852d6b25ea276d9918a2170e991ab3fb

Remove unused user agent checks from unit tests RELNOTES: n/a PiperOrigin-RevId: 386268900 Change-Id: Id3e0bf2e6feb990d8f5bb01cae023eaf13015196

view details

John Lenz

commit sha e7d2e82643b2b72eec43461c496a8fdd920fc4cd

RELNOTES: Remove missingRequire suppressions PiperOrigin-RevId: 386291290 Change-Id: I439ec45b0684f5425f1f6fa784f236828f3fea48

view details

Closure Team

commit sha a009a5e8c83331462ef3618c4ab8833ae88389fe

Change failure message for assertHeightWithinTolerance to use "height" instead of "width". RELNOTES: One-line summary of change for external release notes. PiperOrigin-RevId: 386325391 Change-Id: I30c9bb30abafb282e0c5e5b56b4d1f9921408b94

view details

John Lenz

commit sha 4f0bf18a3200403b53944b338f80dda307714833

Remove unused user agent checks from unit tests RELNOTES: n/a PiperOrigin-RevId: 386348372 Change-Id: I583fad9f26bca92a94e89feed458c7aa219c1edf

view details

Closure Team

commit sha f645408e88a87d48414b3d23a2a684d0a7abf550

Use string comparison for Trusted Types in goog.testing.asserts RELNOTES: n/a PiperOrigin-RevId: 386352828 Change-Id: Idbceb24397c65946e4d24423cbcefc9a231b9121

view details

Closure Team

commit sha 183f1a91265414aec511ab7c428dd673766007a7

Remove unnecessary empty string test vectors for html sanitizer tests. RELNOTES: n/a PiperOrigin-RevId: 386369459 Change-Id: Icead07bb3233fd8266701aa1500ae8d9162bf8ec

view details

John Lenz

commit sha 0bc21defc6d35a0de4c02c887416fdc8e9b0fc56

Strip isVersionOrHigher checks for old browser versions RELNOTES: Remove support for IE8 and before, Gecko 3.x and before, and Safari 5.1 and before. PiperOrigin-RevId: 386457038 Change-Id: I1ab223c9adf9c96ee45d13a4611b6705f0c4b7bf

view details

John Lenz

commit sha d53f6fd565bf198bd5ec6afd8ecb41571f3ca728

Strip isVersionOrHigher checks for old browser versions RELNOTES: Remove support for IE8 and before, Gecko 3.x and before, and Safari 5.1 and before. PiperOrigin-RevId: 386469121 Change-Id: I352458f9caa778e7e2c54231f4842ad90da8ab21

view details

John Lenz

commit sha 3d5f4bc81bc6e9240b627a85957a5a4c1a6b68f1

Add a few suppressions to allow tightening checks. RELNOTES:n/a PiperOrigin-RevId: 386532353 Change-Id: I134d84a39d87f87197dfe6b2f8a29066574d417c

view details

push time in 2 months

push eventgoogle/closure-library

Closure Team

commit sha c7762aad52a72cb45697fc5322390e02956eedf3

Updates html test vectors to ensure iframes get dropped completely. RELNOTES: n/a PiperOrigin-RevId: 383807235 Change-Id: I4b9ae1e236f8b70be88b263e678f1853e84302e3

view details

Closure Team

commit sha 97fb8d28a7b158699b79ae28780b16bb349032ca

Moves SafeStyle to goog.module RELNOTES: n/a PiperOrigin-RevId: 383826244 Change-Id: I5d4148eed861dc2eb0ae233a0291efd9d2588205

view details

nickreid

commit sha 8782d8ba16ef2dd4a508d2081a6938f054fc60e8

Internal change PiperOrigin-RevId: 383911783 Change-Id: I63219c61416f79435c5afb36aaf45f4037f84b68

view details

push time in 2 months

push eventgoogle/closure-library

Kelvin Jin

commit sha ed02aa9f2c6b41394d33fb64cfbea5014000775f

RELNOTES[INC]: Delete goog.date.formatMonthAndYear. This API has been deprecated since 2018. Use goog.i18n.DateTimeFormat with goog.i18n.DateTimeFormat.Format.YEAR_MONTH_ABBR or goog.i18n.DateTimeFormat.Format.YEAR_MONTH_FULL instead. PiperOrigin-RevId: 382664517 Change-Id: Idff85b988125449122571483aa0c5e210c03898e

view details

push time in 3 months

issue closedbazelbuild/rules_closure

Delete closure_js_deps

Hi -- in Closure Library we are planning to remove the depswriter.py script, which is deprecated and superceded by the closure-make-deps binary that is part of the google-closure-deps npm package.

The closure_js_deps rule here depends on depswriter, using it to output a deps.js file. I'd like to reimplement this to use the aforementioned closure-make-deps binary instead. This will involve either

(1) checking in google-closure-deps (which is authored by Google) into this repo, or (2) using some npm rule to load google-closure-deps in at compile time.

I'm not very familiar with the landscape of Bazel rules that have to do with npm, but my inclination given that Closure library and the compiler are already checked in here, is to also check in closure-deps.

closed time in 3 months

kjin

issue commentbazelbuild/rules_closure

Delete closure_js_deps

Thank you!

I think this particular issue is resolved -- I (or someone on my team) will circle back in a few months to get it deleted.

kjin

comment created time in 3 months

push eventgoogle/closure-library

Laura Harker

commit sha fc26060da25c49fdc4bdbf675b615f79899c9a4e

Delete unnecessary nested goog.provide RELNOTES[INC]: Deleted goog.provide for goog.net.streams.JsonStreamParser.Options PiperOrigin-RevId: 380042159 Change-Id: Ic1cff7813f415e6a825096cd24aa570a41b14bc3

view details

Closure Team

commit sha 72ca4df39f6130d20b98c20f6e77c50a74e3d9e2

Automated rollback of commit a8dc3fe52174f6f0837f0f0320490c1af9a4955b. PiperOrigin-RevId: 380114764 Change-Id: I3a0f0c3998c32cc9fee73dbabd7fe24eda242062

view details

Kelvin Jin

commit sha 749634639af6b04bfe1d9d890bb037811e390b61

RELNOTES: Delete open-sourced Python helper scripts. See https://github.com/google/closure-library/wiki/Migrating-off-Closure-Python-Scripts for information on migrating off of these scripts. PiperOrigin-RevId: 380652546 Change-Id: I4ffcf7add875a2e4d5e0335236e567d4da4f5e6f

view details

Closure Team

commit sha 1422c2542c30d415c05d3f2b689f302756598087

RELNOTES: Return the correct singleton when using goog.singleton with subclassed classes. PiperOrigin-RevId: 380687393 Change-Id: I86ba984914ccde705d6bb87eb930eec9cb66ce9a

view details

James Wright

commit sha 035b3d5c3abe4d508764144dbe1c237fa7c70b0e

RELNOTES: Delete goog.userAgent.IsX11. PiperOrigin-RevId: 380689161 Change-Id: I9b8eb758e4c0e87220e721e06f61b6ecc9e5bfc6

view details

Closure Team

commit sha 5199bb20365f602af8534555a05a21b28cc62e46

Automated rollback of commit 035b3d5c3abe4d508764144dbe1c237fa7c70b0e. PiperOrigin-RevId: 380817583 Change-Id: I20dc90a395fe5379540b28f65f08be3f1c737b47

view details

Closure Team

commit sha 9d24a6c1809a671c2e54c328897ebeae15a6d172

RELNOTES: Small type safety fix. PiperOrigin-RevId: 380953331 Change-Id: I78b88e4bfb4bb9d4e4bc40136cc6c33918f56f70

view details

push time in 3 months

issue commentbazelbuild/rules_closure

Delete closure_js_deps

@gkdn Hey Goktug -- is there an upcoming release for rules_closure planned? It would be great to have a release deprecating this rule first, and a subsequent one deleting it.

kjin

comment created time in 3 months