profile
viewpoint
Kitson Kelly kitsonk @ThoughtWorksInc Melbourne, Australia https://kitsonkelly.com/ Principal Technologist @ThoughtWorksInc, contributing to @denoland and author of @oakserver

csnover/dojo-boilerplate 375

A starting point for developing with Dojo

kitsonk/colors 38

Console colors for Deno

kitsonk/app-example 8

An example Dojo 2 Application

kitsonk/controller 8

Commands and Action Abstractions for Dojo

h-o-t/nocuous 7

A static code analysis tool for JavaScript and TypeScript.

kitsonk/choak 7

An example chat application using Deno and Oak

kitsonk/d2-proto 4

Dojo 2.0 Prototypes and Experiments

kitsonk/bubba 3

A GitHub bot, making Eric's life easier

kitsonk/core-js 2

Prototype Core of Dojo 2

kitsonk/api-doc 1

A TypeScript API Documentation Generator

pull request commentdenoland/deno

[WIP] Refactor the compiler

It is getting closer and closer. Still to do:

  • [ ] Bundle needs to be refactored use Graph.
  • [ ] bring in the swc type stripping/transpiling
  • [ ] The diagnostics refactor needs to be completed.
  • [ ] import-map could use some cleanup and refactoring, maybe after this PR?
  • [ ] integrate with cli...
  • [ ] question: are redirects handled properly?
  • [ ] provide runtime APIs, likely will just go with the refactor proposed in #4752 instead of trying to re-implement existing ones

Also, this will provide even more fixes:

Fixes #7005 Fixes #6176 Fixes #6995

kitsonk

comment created time in 9 hours

push eventkitsonk/deno

Kitson Kelly

commit sha 34ca1d3cd38d9f74c48792f55dc10d4881fb5b64

linting

view details

push time in 9 hours

push eventkitsonk/deno

Kitson Kelly

commit sha a3723213f5dd4b5aa8a22b299d4814ab44f60c04

WIP

view details

push time in 9 hours

push eventkitsonk/deno

Kitson Kelly

commit sha ae36a3a9415305a281167b30d85faa93c4d9ddf0

fix test

view details

push time in 13 hours

push eventkitsonk/deno

Kitson Kelly

commit sha 118ed0987594abba65df665344cba45b8af71499

WIP

view details

push time in 17 hours

push eventkitsonk/deno

Kitson Kelly

commit sha 77c2ede3f360d3c0eddcbbe8dfef603e2e887ac6

resolve extension in rust

view details

push time in 17 hours

push eventkitsonk/deno

Kitson Kelly

commit sha 27d896984726d12bdec1007bd998731f08dc86ff

chore: nightly clippy refactor in lint.rs (#7045)

view details

Connor Peet

commit sha fbee85b1ae497202b97f8de0ca48a4ea69751985

docs: update VS Code debugging options for 1.47 (#6767)

view details

Moritz Gunz

commit sha a17ea9150d08312ecd2779324fff09ee7cd99037

Add missing export of HeapLimits (#7047) Currently this blocks using the ::with_heap_limits constructor of CoreIsolate, because you cannot access the struct.

view details

Casper Beyer

commit sha 238816d62fcc1cfe16414751902fa5a924b14703

refactor(cli/rt): inline single line single use open helper functions (#7046)

view details

Jarrett Helton

commit sha ac56512ba45714e7520019a2f8983434381c2d05

fix: Dash Value Treated As Arg (#7039)

view details

Casper Beyer

commit sha 4b3a3d9d0f84df8997d466d009da9fffdfbdcbe1

Enable WebAssembly.instantiateStreaming (#7043)

view details

tokiedokie

commit sha b9adfe53d386aa670ae2e40732e711d2b76877a4

typo (#7029)

view details

Kitson Kelly

commit sha 3fd14f0208d45dfe2624bcecb148a803a5da4863

WIP

view details

push time in 18 hours

push eventkitsonk/deno

Kitson Kelly

commit sha ea84031f72423ed5a4bac3788b5d4eb10c068add

WIP

view details

push time in a day

push eventkitsonk/deno

Jarrett Helton

commit sha 514cbc2808754369f52c9f4baef97c16345d654b

fix: remove @ts-expect-error directives (#7024)

view details

Bartek Iwańczuk

commit sha 08ab4d46ca1860da16b5250fe3872cefbe682637

upgrade: swc, deno_lint, dprint (#7040)

view details

souldzin

commit sha d6cee706955f300086f41f9318d23631f64f036b

feat: Add "--json" flag to deno lint (#6940) Co-authored-by: JackSkylark <jdslaughter44@gmail.com>

view details

Bartek Iwańczuk

commit sha b38c3132768e0f5132763db9c8fdc2a4a9490bde

v1.3.0

view details

Kitson Kelly

commit sha 17d29d80c635b1df46dea3fc3118f03c38b28f80

WIP

view details

Kitson Kelly

commit sha acd8d12fb20e8418c775b9350f3e2ba6706b6ddd

WIP

view details

Kitson Kelly

commit sha a94ed5340d986907482967a931e95638311db438

WIP

view details

Kitson Kelly

commit sha a0cc4cde223bd0a14d786267ce5f4daa8716f0a2

WIP

view details

Kitson Kelly

commit sha 895c429f84070aef65bccdc3fdbba2fed86fe4a1

WIP

view details

Kitson Kelly

commit sha ed1eccd2de71d7bbc20cc186889c1ebb7c429131

WIP

view details

Kitson Kelly

commit sha 4868c5c96b3fde050f446988a711893ef24fea93

WIP

view details

Kitson Kelly

commit sha ed01574e85d94462ffbe53df93d43e5016d4e3c7

WIP

view details

Kitson Kelly

commit sha eae9b1f43e6cbd811242ee7d88545e5d70e480d6

WIP

view details

Kitson Kelly

commit sha fe232f87db210b3a16117a2b5a2d7483040079da

WIP

view details

Kitson Kelly

commit sha 24412cd817d99241e56c8aaf87b35cae9a37af03

WIP

view details

Kitson Kelly

commit sha 641755bea6c72b7dc553dfc2e619c45febb97de0

WIP

view details

Kitson Kelly

commit sha 5eac7a218e61ba149107e64842731fa854fe6f43

WIP

view details

Kitson Kelly

commit sha 7781112feb6f1e61dcee1bbb95dde7889e9a33f6

fixup

view details

push time in a day

PR opened denoland/deno

chore: nightly clippy refactor in lint.rs

Nightly clippy flags a bit of code in master that can be optimised.

+1 -3

0 comment

1 changed file

pr created time in a day

create barnchkitsonk/deno

branch : nightly_clippy_fix

created branch time in a day

push eventkitsonk/deno

Kitson Kelly

commit sha 076547fbbb52b1df9d6db36dd72353bffa9e4a8b

chore: use matches macro for bool matches (#6904)

view details

Ryan Dahl

commit sha b7942bf0f6f151e172db9b1e08cf4436e8365e8b

Change release build flags to optimize for size (#6907)

view details

Bartek Iwańczuk

commit sha 315efbc0e86d9d848efa4b889aefbc665508598a

fix: downcast from SwcDiagnosticBuffer to OpError (#6909)

view details

Bartek Iwańczuk

commit sha c6917133942c791480cd2aec7297b2a2ee623059

refactor: Use SWC to strip types for "--no-check" flag (#6895)

view details

Luca Casonato

commit sha 1b60840f286bc0203a3bd2900f67557a8ff2c3f6

feat(std/async): add pooledMap utility (#6898)

view details

Nayeem Rahman

commit sha 6afe7bbd395eb34febd25bda48c5cd82f0a4f8b3

fix(std/path): Percent-decode in fromFileUrl() (#6913)

view details

Kid

commit sha 391088c6ff531ac6714e9076eb62f2294793ccdd

docs(std/encoding): Fix TOML docs (#6912)

view details

zfx

commit sha 95597fc6e2ed9975c26eae77ba68ae42ca2c331a

fix(std/tar): directory type bug (#6905)

view details

Divy Srivastava

commit sha 0da4779b178a0c97925c1ef5589d0f24a37f4501

feat(unstable): add "--ignore" flag to deno fmt (#6890)

view details

Nayeem Rahman

commit sha 6e7208bec2911ac0d1729f334fc90bc50b8f9203

fix(cli/rt): Fix file URL to path conversion on Windows (#6920)

view details

Luca Casonato

commit sha 4afb4b6e46de2ed536a3c9828d70d7799b5b6d03

feat: add $STD_VERSION replacement variable in docs (#6922)

view details

Bartek Iwańczuk

commit sha b718e6ff53156a0aae486e570ce7c9cb8a3b822a

upgrade: deno_lint, dprint, swc (#6928) This commit upgrades: deno_lint 0.1.20 dprint-plugin-typescript 0.25.0 swc_ecmascript 0.1.0 SWC is no longer reexported from dprint nor deno_lint.

view details

Ryan Dahl

commit sha 7446230e6b39a0d3ce70b8fffbed3ebc63e8c762

v1.2.2

view details

Bartek Iwańczuk

commit sha d54d4d21bddf0fe80a6f534ec945c655595c5f71

upgrade: swc_ecmascript (#6943)

view details

Luca Casonato

commit sha 9d50c5c1a6fbe6895b6a63dadcba7bacaf9dd578

feat: hash file names in gen cache (#6911)

view details

Ben Stolovitz

commit sha 39693094f14ecba128c8fe9c6a1b8c0aba82fdec

Fix grammatical error in Linter documentation (#6939)

view details

Chayim Refael Friedman

commit sha e9d713c007afd31e22c9edf2b256197ed12336f2

typo (#6937)

view details

Jarrett Helton

commit sha d615ebefe2e306f2877afb40dc603f71263407d6

fix(std/toml): parser error with inline comments (#6942)

view details

Maayan Hanin

commit sha 5fc5e7b54a9fba421dfc473016625a4f592403ed

fix(cli): add support for non-UTF8 source files (#6789) Fixes: #5542

view details

Rauf Islam

commit sha 40ead6cc98ab1d02c8ca0587d24c218e81aa47b7

fix(std/encoding/toml): Add boolean support to stringify (#6941)

view details

push time in a day

issue commentdenoland/deno

std crypto module in WebAssembly?

Yes, I still feel this is a duplicate of #1891

chiefbiiko

comment created time in 2 days

push eventkitsonk/deno

Kitson Kelly

commit sha 85162fd6d8f6edd2ca2b7c3830482273e72961af

WIP

view details

push time in 2 days

push eventkitsonk/deno

Bartek Iwańczuk

commit sha 6fcf06306ed2ea52031a97b918f1e929d7209250

feat(doc): handle imports (#6987) This commit adds additional objects to JSON output of "deno doc" command to facilitate linking between types in different modules.

view details

Nayeem Rahman

commit sha 52c1017a74059655f9424f7ceb3f0c74dcc7f3be

feat: Stabilize Deno.mainModule (#6993)

view details

Ryan Dahl

commit sha 7d01fcbb77169d446d58a5d8c1aa113a925092a0

Remove unnecessary drop calls (#7007)

view details

Luca Casonato

commit sha da98f9e3a174a304b0a83391fa61fcfdba0fc668

fix(unstable): add missing globals to diagnostics (#6988)

view details

迷渡

commit sha dad74c3706f5454288ccead85cbc28430d635850

remove unnecessary await in docs (#7012)

view details

迷渡

commit sha 8c0140e1e40faffd83d47c01b3766caa13d1310d

remove unused git attributes (#7011)

view details

Jesse Jackson

commit sha f32d28019d1ef56454137d49046cf1587c2245a4

test(std): fs/writeJson add test for append option (#6889) Co-authored-by: Ryan Dahl <ry@tinyclouds.org> Co-authored-by: Nayeem Rahman <nayeemrmn99@gmail.com>

view details

Valentin Anger

commit sha d7077b9073dec6fb1f4b07d5575ef416997c19a9

doc: Remove detailed / summary distinction (#6818)

view details

Paul Thompson

commit sha eed77aa0208e603dac908a240dd66ece422e9dd7

feat(web): FileReader API (#6673)

view details

Marcus Weiner

commit sha f425b51419da496011424f6259dad5ac11d433cd

core: memory limits & callbacks (#6914)

view details

Marcus Weiner

commit sha 58f86e063ab4d3e022b94f8f3c6a6a796ee9f749

Remove previous heap limit callback when registering (#7025)

view details

Nayeem Rahman

commit sha 81ce4499e7da7baf421b85b4a188d1a63569cab4

fix: Make std work with isolatedModules (#7016)

view details

Prabhanjan

commit sha b344a7f81fa00d1611212cac82b631f9d1dffdf0

fix: URLSearchParams.toString() behaviour is different from browsers (#7017)

view details

Alberto Ricart

commit sha 91ff91093dba45c9696d71e74323487cfa4ce406

feat(std): added TLS serve abilities to file_server (#6962)

view details

Nayeem Rahman

commit sha fed70c9903e616702241725e82a7d633f2a9b05d

feat: deno info --reload (#7009)

view details

Divy Srivastava

commit sha 6706eb551532ee6c84ad013377ac2cd91681424a

feat: add "--ignore" to deno lint (#6934)

view details

Ryan Dahl

commit sha f5a4f1fdc04b24cdfbef83842b9c42b5032c4059

Undo JsonOpDispatcher and OpDispatcher traits (#7023) This reverts commit f83d672ffad7afb1473bd4f9b9c645539064c620. This reverts commit d51972377c1325076704d9faec2eee6f0e024496.

view details

Jarrett Helton

commit sha c4edd09816b3cc6ab992f85602388f2f344fcf0e

feat(bundle): add support for --reload flag (#6996)

view details

木杉

commit sha 988790834e9611b45663e48a7bea49219da7511f

feat(std/http): add --no-dir-listing flag to file_server (#6808)

view details

Bert Belder

commit sha 3d70a2b94eac4d4032b8b11039efe6d070fa114f

upgrade: Rust crates The following crates were _not_ upgraded to avoid having multiple versions of the same crate in the dependency tree: * tokio-tungstenite v0.10.1 -> v0.11.0 * swc_common v0. 8.0 -> v0. 9.1 * swc_ecmascript v0. 1.0 -> v0. 3.0 * webpki-roots v0.19.0 -> v0.20.0 * nix v0.17.0 -> v0.18.0

view details

push time in 3 days

issue commentdenoland/deno

gRPC in Deno?

IMO, this is something that should start external to Deno/std and move into std. It should either be a native module or Web Assembly.

jwulf

comment created time in 3 days

issue commentdenoland/deno

missing transfer argument for postMessage

Ref #3557

nabezokodaikon

comment created time in 4 days

issue commentdenoland/deno

Test std with "isolatedModules" on

Are there things that conversely only work with "isolatedModules" rules?

Not that I am aware of.

We only would need to modify: https://github.com/denoland/deno/blob/master/std/tsconfig_test.json

nayeemrmn

comment created time in 4 days

issue commentdenoland/deno

Rename --importmap to --import-map

We shouldn't remove import map support. I think it got stalled for a lot of other reasons than stability. Mostly because there was a bit of wider push back from non-Chromium world and how fast it and other things (like built in modules) were going. Clearly it solves a problem that needs to be solved.

As far as renaming... 🤷 but I do like --import-map better.

nayeemrmn

comment created time in 4 days

issue commentdenoland/deno

onunhandledrejection for globalThis?

We should have it, it is part of the HTML Living Standard: https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onunhandledrejection

nzakas

comment created time in 4 days

issue commentdenoland/deno

@ts-expect-error breaking app.

We should just stop using that directive IMO.

But we shouldn't replace it with @ts-ignore either though. It is only for the very very very rare instance where we can't coerce the type system any other way, and we should use @ts-expect-error in those cases.

andreespirela

comment created time in 4 days

issue commentdenoland/deno

Deno.compile doesn't rename imports

Correct, duplicate of #4538.

leonelv

comment created time in 5 days

push eventkitsonk/deno

Nayeem Rahman

commit sha 6afe7bbd395eb34febd25bda48c5cd82f0a4f8b3

fix(std/path): Percent-decode in fromFileUrl() (#6913)

view details

Kid

commit sha 391088c6ff531ac6714e9076eb62f2294793ccdd

docs(std/encoding): Fix TOML docs (#6912)

view details

zfx

commit sha 95597fc6e2ed9975c26eae77ba68ae42ca2c331a

fix(std/tar): directory type bug (#6905)

view details

Divy Srivastava

commit sha 0da4779b178a0c97925c1ef5589d0f24a37f4501

feat(unstable): add "--ignore" flag to deno fmt (#6890)

view details

Nayeem Rahman

commit sha 6e7208bec2911ac0d1729f334fc90bc50b8f9203

fix(cli/rt): Fix file URL to path conversion on Windows (#6920)

view details

Luca Casonato

commit sha 4afb4b6e46de2ed536a3c9828d70d7799b5b6d03

feat: add $STD_VERSION replacement variable in docs (#6922)

view details

Bartek Iwańczuk

commit sha b718e6ff53156a0aae486e570ce7c9cb8a3b822a

upgrade: deno_lint, dprint, swc (#6928) This commit upgrades: deno_lint 0.1.20 dprint-plugin-typescript 0.25.0 swc_ecmascript 0.1.0 SWC is no longer reexported from dprint nor deno_lint.

view details

Ryan Dahl

commit sha 7446230e6b39a0d3ce70b8fffbed3ebc63e8c762

v1.2.2

view details

Bartek Iwańczuk

commit sha d54d4d21bddf0fe80a6f534ec945c655595c5f71

upgrade: swc_ecmascript (#6943)

view details

Luca Casonato

commit sha 9d50c5c1a6fbe6895b6a63dadcba7bacaf9dd578

feat: hash file names in gen cache (#6911)

view details

Ben Stolovitz

commit sha 39693094f14ecba128c8fe9c6a1b8c0aba82fdec

Fix grammatical error in Linter documentation (#6939)

view details

Chayim Refael Friedman

commit sha e9d713c007afd31e22c9edf2b256197ed12336f2

typo (#6937)

view details

Jarrett Helton

commit sha d615ebefe2e306f2877afb40dc603f71263407d6

fix(std/toml): parser error with inline comments (#6942)

view details

Maayan Hanin

commit sha 5fc5e7b54a9fba421dfc473016625a4f592403ed

fix(cli): add support for non-UTF8 source files (#6789) Fixes: #5542

view details

Rauf Islam

commit sha 40ead6cc98ab1d02c8ca0587d24c218e81aa47b7

fix(std/encoding/toml): Add boolean support to stringify (#6941)

view details

Arseny Kruglikov

commit sha bda9f619728d2b795d5a449f5a4feb9a1e0ed14c

docs: fix some grammar mistakes in permissions.md (#6949)

view details

josephrocca

commit sha 8bacd710dbf8976c41d230b9f65c466b9fb3a488

docs: Removed unnecessary `await` (#6951)

view details

josephrocca

commit sha 2cd1fe8edf1b9ce89f12e70738b5bcae8b177d0b

Fixed benchmarks url (#6952)

view details

Bartek Iwańczuk

commit sha 55ea9c7e856cae5471fea309d9dc40444581c3ae

refactor: remove repeated code in main.rs (#6954)

view details

Luca Casonato

commit sha 91ed614aa80f5a08669be3fe5031a95e6e75f194

fix(cli/dts): MDN attribution in JSDoc for Console.dirxml (#6961)

view details

push time in 5 days

issue commentdenoland/deno

cjs conflict with https://deno.land/std@0.63.0/hash/mod.ts

Duplicate of #6176

aaronwlee

comment created time in 6 days

issue closeddenoland/deno_website2

Registry packages should only refer to relative URLs or `deno.land/x/`

We should vet packages that are part of the registry to make sure that they don't refer to other hosts, outside of deno.land/x/. We have had reports of some packages referring to denopkg.com, which is potentially a useful community feature but we should either include that capability (ability to refer easily to repos on GitHub) into deno.land/x/ for the use such packages, or we expect everything to only leverage other packages on deno.land/x/.

closed time in 6 days

kitsonk

issue commentoakserver/oak

passing data from middleware to controller

Since this has come up a few times, adding an FAQ: https://oakserver.github.io/oak/FAQ#how-do-i-pass-custom-propertiesstate-around

moncefplastin07

comment created time in 9 days

push eventoakserver/oak

Kitson Kelly

commit sha 7d238b4f2324f45083c4c257b197528bd0cfec1c

Add FAQ regarding state

view details

push time in 9 days

issue closedoakserver/oak

passing data from middleware to controller

can i pass data from the middleware to controller ?!

like this node

function middleware(req, res, next){
     req.user = {user:"incoming data"}
    next()
}

function controller(req, res){
     console.log(req.user) // {user:"incoming data"}
}

closed time in 9 days

moncefplastin07

issue commentoakserver/oak

passing data from middleware to controller

This is what ctx.state is for. Ref: https://github.com/oakserver/oak#context

moncefplastin07

comment created time in 9 days

issue closedoakserver/oak

v6.+ request value always show 'Promise { <pending> }'

When I write a request api, post a json value and log the value in console. Its always print Promise { <pending> } const login = async (ctx: RouterContext) => { const body = await ctx.request.body(); console.log(body.value); ctx.response.body = 'success'; };

Listening on port: 4000... Promise { <pending> }

closed time in 9 days

chioio

issue commentoakserver/oak

v6.+ request value always show 'Promise { <pending> }'

As mentioned, this was a breaking change introduced in #201 and released in v6. The README makes it clear how the body is to be consumed in v6+.

chioio

comment created time in 9 days

issue commentdenoland/deno

Support Rust-style triple slash comments for "deno doc"

Ref: https://github.com/microsoft/TypeScript/pull/39930

ry

comment created time in 9 days

issue commentdenoland/deno_website2

Possible ePrivacy breach?

[From their support pages](https://support.cloudflare.com/hc/en-us/articles/200170156-Understanding-the-Cloudflare-Cookies#12345682:

The _cfduid cookie can only be disabled for Enterprise customers.

Enterprise customers may request to disable the _cfduid cookie by contacting Cloudflare Support, but Cloudflare’s ability to detect and mitigate the impact of malicious visitors to a Customer’s website will be significantly impacted. While some speed recommendations suggest eliminating cookies for static resources, the performance implications are minimal.

crowlKats

comment created time in 10 days

issue commentdenoland/deno

Add a way to dynamically import the same module multiple times

If we've already ripped V8 out of its intended environment to use JS on the server side, what's wrong with making some changes to its set of rules

https://deno.land/manual#goals

lem0nify

comment created time in 10 days

issue commentdenoland/vscode_deno

Roadmap

There is quite a lot of documentation regarding language servers and how language servers work with VSCode. But a word of caution, you need either good experience with the language service protocol, monaco/vscode, or Deno. It isn't specifically a "good first issue" and there are lots of other ways to contribute to Deno.

bartlomieju

comment created time in 10 days

push eventoakserver/oak

Kitson Kelly

commit sha c368d30885a1c799fc21676940f899170e5963ab

Test for body parsing invalid content

view details

push time in 11 days

issue commentdenoland/deno

Deno CLI - allow ts-ignore comments

This should be moved to https://github.com/denoland/deno_lint/

Keimeno

comment created time in 11 days

issue closedoakserver/oak

Sending Raw text - Server Crush

If we try to use this code, and we send raw text via postman decode will fail.

app.use(async (ctx) => {
  const result = ctx.request.body(); // content type automatically detected
  if (result.type === "json") {
    const value = await result.value; // an object of parsed JSON
  }


here is the error :

error: Uncaught SyntaxError: Unexpected token a in JSON at position 0
          JSON.parse(decoder.decode(await this.#valuePromise()));

    at JSON.parse (<anonymous>)
    at value (body.ts:202:16)

we need internal handling to solve this issue.

closed time in 11 days

gungunfebrianza

issue commentoakserver/oak

Sending Raw text - Server Crush

The only time the result.type would be set to JSON is when the Content-Type is set to application/json. If you set that content type and then send a body that is invalid JSON, the behaviour you are seeing is to be expected (that an error throws).

If there is a risk that someone might try to send invalid JSON in the payload, you should write the code to handle that properly, in a way that is meaningful to your application. For example:

app.use(async (ctx) => {
  const result = ctx.request.body(); // content type automatically detected
  if (result.type === "json") {
    try {
      const value = await result.value;
    } catch (e) {
      if (e instanceof SyntaxError) {
        ctx.throw(Status.BadRequest, e.message);
      } else {
        ctx.throw(Status.InternalServerError);
      }
    }
  }
});
gungunfebrianza

comment created time in 11 days

push eventoakserver/oak

Kitson Kelly

commit sha 877785fa1f1cd4ad20d90baac2aa91a28860e467

Update links in docs

view details

push time in 11 days

issue closedoakserver/oak

Main page shows wrong version as latest, and no changelog

oak

I see that Oak is very much maintained and up-to-date, but on casual inspection, the latest version was released in May. With Deno's rapid development this is very discouraging for potential users. It is very misleading, can it be corrected?

Also, I can't find a changelog, is there one? Cheers.

closed time in 11 days

David-Else

issue commentoakserver/oak

Main page shows wrong version as latest, and no changelog

That is a behaviour of "releases" in GitHub and it cannot be controlled (like a lot of things on GitHub). Please refer to the tags to determine the latest release. I may "release" every tag in the future, but I am not sure.

There is no change log at this point. Something I will consider in the future.

David-Else

comment created time in 11 days

issue commentdenoland/deno

Add a way to dynamically import the same module multiple times

Basically what you are asking for is hot module reloading... That is problematic in a lot of ways. ES Modules and their exports are immutable by design. As stated in #5548 we should find better ways to do this to support things like development. There is discussion in #6694 about this as well.

Instead of asking for a specific feature, what use case are you trying to solve?

lem0nify

comment created time in 11 days

issue commentdenoland/deno

Consider "release" branch of std

It solves enough of this problem to close the issue, certainly.

kitsonk

comment created time in 11 days

issue closeddenoland/deno

Consider "release" branch of std

We currently committed code to master for std to be compatible with the version of the cli in master, and that flushed out a whole set of people complaining about the breaking changes and code not running. People are either ignoring the warning message, not understanding what it means, or depending on code that depends on master. All which lead to 😠 😭 😖.

Maybe we should introduce a release branch for the purposes of std which is created at the same time as the cli release, and point https://deno.land/std/ at that branch by default instead of master. We can then eliminate the warning code in the cli as well. I believe it is reasonable to expect https://deno.land/std/ to be compatible with the current release of the cli, even though people should still depend on specific versions as a matter of best practice.

closed time in 11 days

kitsonk

push eventoakserver/oak

Kitson Kelly

commit sha d1e1e69bb0298849b467a0347acf02ad65897de3

Repoint docs at github.io

view details

push time in 11 days

delete branch oakserver/oak

delete branch : master

delete time in 11 days

push eventh-o-t/nocuous

Kitson Kelly

commit sha c9e3041deec4ba56ec6c0f3489026d42d5eee9a5

Create codeql-analysis.yml Experiment with code scanning.

view details

push time in 11 days

issue closedoakserver/oak

Oak website returning 404

Link is in the repo description: https://oakserver.github.io/oak/

closed time in 11 days

captDaylight

issue commentoakserver/oak

Oak website returning 404

GitHub can now be published of any branch.

captDaylight

comment created time in 11 days

issue commentdenoland/deno

Add a way to dynamically import the same module multiple times

Why do we even have to store dynamically imported modules in cache?

Because that is very similar to the way browsers work. Clearly dynamic implies something to you that it doesn't actually mean to imply, it means "allow me to conditionally run this code in the current execution context", but all the rules to how modules are fetched, compiled and imported apply whether it be static or dynamic.

Ultimately this is a duplicate of #5548 and #6694

lem0nify

comment created time in 12 days

pull request commentdenoland/deno

feat(std): add deno_shim for browsers

Yeah, I need to rework it. Certainly possible to do as a seperate package as well.

kitsonk

comment created time in 12 days

issue commentdenoland/deno

Deno info should not type check

Just for context, there is a small amount of dependencies that not type checking would not catch currently, that would be caught under type checking.

For example:

const a = "./a.ts";
const a_mod = await import(a);

Would be caught under type checking, as the TypeScript compiler realises that value being passed to the dynamic import is statically determinable at call point, and would then make "./a.ts" a dependency of the module.

ry

comment created time in 13 days

issue commentdenoland/deno

SyntaxError on deno info

@bartlomieju looks like the type stripping isn't stripping types. 😭

dangry

comment created time in 14 days

fork kitsonk/deno_lint

Blazing fast linter for JavaScript and TypeScript written in Rust

fork in 15 days

issue closedoakserver/oak

Typing Error with deno latest version 1.2.1 | 'string | URL' is not assignable to parameter of type 'string'.

Code:

import { Application } from "https://deno.land/x/oak/mod.ts";

const body = "Hello World"
const app = new Application();

app.use((ctx) => {
  ctx.response.body = `<!DOCTYPE html>
  <html lang="en">
  <head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
  </head>
  <body>
    ${body}
  </body>
  </html>`;
});

await app.listen({ port: 8000 });

deno --version

Output:

deno 1.2.1
v8 8.5.216
typescript 3.9.2

Error:

error: TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname
                 ~~~
    at https://deno.land/std@0.56.0/path/win32.ts:917:18

TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname;
                 ~~~
    at https://deno.land/std@0.56.0/path/posix.ts:438:18

Note: It is working file with deno@1.1.3

closed time in 15 days

deepakshrma

issue commentoakserver/oak

Typing Error with deno latest version 1.2.1 | 'string | URL' is not assignable to parameter of type 'string'.

You need to reload your cache deno run --reload whatever.ts.

Please don't use an unpinned version of oak, as it will lead to this very specific issue and is clearly mentioned in the README:

Warning The examples in this README pull from main, which may not make sense to do when you are looking to actually deploy a workload. You would want to "pin" to a particular version which is compatible with the version of Deno you are using and has a fixed set of APIs you would expect. https://deno.land/x/ supports using git tags in the URL to direct you at a particular version. So to use version 3.0.0 of oak, you would want to import https://deno.land/x/oak@v3.0.0/mod.ts.

Currently you should use https://deno.land/x/oak@v6.0.1/mod.ts which is the latest release.

deepakshrma

comment created time in 15 days

issue commentdenoland/deno

Collect and share Deno code coverage

Blocked by #106, we are not going to introduce an external library to instrument the code, we are going to get it directly from V8 and built it into the test harness. There are other solutions for the Rust code, we just need to integrate them into the CI process.

I don't think the lack of code coverage is a big factor in people making a decision about contributing or not, personally.

trivikr

comment created time in 15 days

issue commentdenoland/deno

`deno test` fails to load `Deno` when a tsconfig.json file is present

If you supply a lib attribute in your compiler options, it will always override the defaults, and you need to include deno.ns. What happens when you omit a lib attribute in your tsconfig.json?

matsko

comment created time in 15 days

issue commentdenoland/deno

bundle output contains top-level await.

It should read "some bundles can also be loaded in the web browser". There are all sorts of things that can make bundles incompatible with browsers.

Top level await is already in V8 and being implemented in Chromium, so it will eventually end up in Chrome and Edge.

zhengxiaoyao0716

comment created time in 15 days

issue commentdenoland/vscode_deno

Has this project been abandoned?

We have a close relationship with the TypeScript core team. The problem here is that the main maintainer doesn't have the time to maintain it and so @ry is trying to pick up the challenge as mentioned above. I would personally take it up, but I have limited time to dedicate to Deno at the moment and I've been buried in another thing. We will get it sorted out for sure, but it will take a bit of time.

promethyttrium

comment created time in 15 days

issue commentdenoland/deno

[Discussion]: std/cli

In my opinion, that feels like an highly opinionated "framework" that should start life outside std and only come into std if it become a de facto.

timreichen

comment created time in 16 days

issue commentdenoland/deno

[Discussion]: std/cli

In my opinion, that feels like an highly opinionated "framework" that should start life outside std and only come into std if it become a de facto.

timreichen

comment created time in 16 days

issue commentdenoland/deno

Support access token authorisation for remote files

@pomke the tokens are tied to users, not repos... it would be a limitation that the same user has to have read access to all the repos. That is a limitation that seems reasonable.

kitsonk

comment created time in 16 days

issue commentdenoland/deno

Using Deno bundle programmatically requires the --unstable flag

In fact we will be breaking those APIs: #4752

shardyMBAI

comment created time in 16 days

issue commentdenoland/deno

Support access token authorisation for remote files

We need to get it implemented on the command line and with environment variables first, and iterate from there. We don't need to solve every problem at the start.

kitsonk

comment created time in 16 days

issue commentdenoland/deno

[Feature Request] Public API for TTYs

I don't see how this issue is unique/different from #6706 you opened, which is far more specific about what capabilities you would like to see... For the sake of everyone's sanity, could we try to keep the discussion in one issue, up until there is something actionable that warrants creating multiple issues?

AZMCode

comment created time in 16 days

pull request commentdenoland/deno

BREAKING refactor(std/path): Rename some symbols

This would have no effect without explicitly upgrading std and there's no transitive effect from an intermediary dependency updating its version of std.

That is the residual issue. When we merged with master, we had a load of people up in arms, because they were on 1.1.3 and their dependency was using std from master, which then was breaking. The fix of not serving the main branch, but the latest release with a "bare" specifier wouldn't fix it either, because as soon as we release that version of standard, we would break a lot of libraries that exist out there that are using the latest release of std that would need to be updated. I know it would break the main branch of oak, and the fact that this required changes in 20+ files indicates how pervasive this API. Mostly because there really isn't anything in the browser standards that comes close to providing the functionality, so we have no choice.

I am all for breaking things, but as pointed out, this is 6 of one, half dozen of another. For every argument on this API there is an equal counter argument against. In my mind, the APIs in std are JavaScript convention first, Go Lang second, then other prior art. There is a strong convention with Node.js in this space, and Go Lang is semi-aligned to that. Sadly, Rust is the outlier here.

In my mind, a breaking change that doesn't have a strong compelling argument coupled with wide 3rd party adoption, is a challenge.

nayeemrmn

comment created time in 16 days

pull request commentdenoland/deno

BREAKING refactor(std/path): Rename some symbols

While dirname() is non sensical to some, parent() is non sensical to others.

Go Lang, which is the "default" for std APIs:

  • basename() -> base()
  • dirname() -> dir()
  • extname() -> ext()
  • sep -> separator

Also, this wouldn't be a minor breaking change, it would have significant impacts, and we originally thought correcting URL | string was a good idea and look at the impact that had. If this was a year ago, I would have thought it would be a good conversation to debate, but sadly, I think the cowpath is already paved.

nayeemrmn

comment created time in 16 days

issue commentdenoland/deno

[Feature Request] Public API for TTYs

Duplicate of #6706 and #3456 which was closed by #6520.

AZMCode

comment created time in 16 days

issue commentdenoland/deno

TypeScript compiler in Rust

Possibly... We were talking about introducing a top level option of --isolated in addition to the existing --no-check which would set the config to "isolateModules": true without needing to use a --config tsconfig.json. We could use the code paths then to just do the type checking with no emit and then use the swc type stripping, even before we could do the AST transform. That would be a stepping stone to making that the default in a future version.

kitsonk

comment created time in 17 days

issue commentdenoland/deno

TypeScript compiler in Rust

@bartlomieju after the compiler refactor, my opinion is that we need to investigate the swc AST -> TypeScript AST and feed the compiler pre-parsed AST (this in theory would also open the door to just using tsc for type checking as well, but as we discussed, we can't do that without a significant breaking change, because Deno would only work effectively with "isolatedModules": true).

kitsonk

comment created time in 17 days

push eventkitsonk/deno

Kitson Kelly

commit sha 076547fbbb52b1df9d6db36dd72353bffa9e4a8b

chore: use matches macro for bool matches (#6904)

view details

Ryan Dahl

commit sha b7942bf0f6f151e172db9b1e08cf4436e8365e8b

Change release build flags to optimize for size (#6907)

view details

Bartek Iwańczuk

commit sha 315efbc0e86d9d848efa4b889aefbc665508598a

fix: downcast from SwcDiagnosticBuffer to OpError (#6909)

view details

Bartek Iwańczuk

commit sha c6917133942c791480cd2aec7297b2a2ee623059

refactor: Use SWC to strip types for "--no-check" flag (#6895)

view details

Luca Casonato

commit sha 1b60840f286bc0203a3bd2900f67557a8ff2c3f6

feat(std/async): add pooledMap utility (#6898)

view details

Kitson Kelly

commit sha 97252ece754feb5c09ac07cd38594f5c13f14c67

WIP

view details

push time in 17 days

push eventkitsonk/deno

Kitson Kelly

commit sha ead32a680b28f7462da2d77e70310949b1b2575f

WIP

view details

push time in 17 days

push eventkitsonk/deno

Kitson Kelly

commit sha 070ff0dbe1c783fa932278610215c181b62300a7

bump ci

view details

push time in 18 days

issue commentdenoland/deno_website2

example fails when trying to run

Ref denoland/deno#6723 there are changes afoot so that documentation doesn't have to be updated on every release.

apopiak

comment created time in 18 days

pull request commentdenoland/deno

chore(ci): update actions to run on ubuntu-18.04

Everyone had to re-sign the CLA, as the terms were changed.

ry

comment created time in 18 days

push eventkitsonk/deno

Kitson Kelly

commit sha 700f1d922cf9e78875baf4371d53c294b41e978d

chore: use matches macro for bool matches

view details

push time in 18 days

PR opened denoland/deno

chore: use matches macro for bool matches

Nightly clippy flags these up as errors, but there appears to issue with adopting this style prematurely.

+8 -24

0 comment

3 changed files

pr created time in 18 days

create barnchkitsonk/deno

branch : matches_macro

created branch time in 18 days

push eventkitsonk/deno

Bartek Iwańczuk

commit sha 98e0ed54db5bbd8befcb5afbb1d63f2b80677f51

fix: ModuleSpecifier removes relative path parts (#6762)

view details

Ryan Dahl

commit sha 6c637f04bf70b631c363ef9c87303e7d7dcdc633

refactor(cli): Remove dead code (#6765)

view details

Casper Beyer

commit sha de3416689175214f33b226d4c510da63737c0db9

fix(std/wasi): remove number overload from rights in path_open (#6768)

view details

JohannLai

commit sha d60f9c2549c7dfb0fbd6c9c8984c215f5dd75e76

fix(cli/js/web): IPv6 hostname should be compressed (#6772)

view details

David Sherret

commit sha 2d58fee8071987567a25f26b14e29cdcca9cb5ab

Update dprint. Also ignore gh-pages dir. (#6778)

view details

uki00a

commit sha 121eaa4efcaa5c8a4cab25eed15de07642e0407d

fix(std/encoding/toml): could not parse strings with apostrophes/semicolons (#6781)

view details

Bartek Iwańczuk

commit sha 6e34f6a7cca11ba245f0b55c3b956b59948b37b7

fix: providing empty source code for missing compiled files (#6760) This commit adds a fallback mechanism for absent compiled source file. Because imported type declaration files are not emitted by TS compiler and their imports are not elided users often hit "No such file or directory" error. With this commit in such situation an empty source file will be provided to V8 with a warning to the user suggesting using "import type"/ "export type" syntax instead.

view details

Bartek Iwańczuk

commit sha da48fa42d309e32684210a8d30ec3fc7ef7079df

chore: update Rust to 1.45.0 (#6791)

view details

Luca Casonato

commit sha 071a6e284aaaa26d40300b82d9f4cbb15a4dd6f5

Share reqwest client between fetch calls (#6792)

view details

sonota88

commit sha aebea6bd24dc1788c6db2f58204177af1c5d2dd6

doc(std/bytes): Fix wrong import in the example code (copyBytes) (#6787)

view details

Bert Belder

commit sha faa64edaf409757549a7df85812f6ea4f368051c

Upgrade to rusty_v8 0.7.0 (#6801)

view details

Jason Miller

commit sha c587450cd458514d8ae17d1fb649b1d36bb4649e

typo (#6800)

view details

木杉

commit sha 53adde866dd399aa2509d14508642fce37afb8f5

refactor(std/path): enrich the types in parse_format_test (#6803)

view details

Bartek Iwańczuk

commit sha fa61956f03491101b6ef64423ea2f1f73af26a73

Port internal TS code to JS (#6793) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

Ryan Dahl

commit sha 628c10b55259f9d2b215b4203c2228062da189dc

fix benchmark_test (#6814)

view details

crowlKats

commit sha 903d28f872b90a800c64339dea058806cde0be67

Remove duplicate code and allow filename overwrite for DomFile (#6817)

view details

Ryan Dahl

commit sha 2460689b1a9582ef6ab8c5fa429e281c88bc14d1

Remove deno_typescript (#6813)

view details

木杉

commit sha f34a441a7d3e3e5c1517207a1ee2ed2a0eaee0c9

fix(tools/lint): don't exceed max command line length on windows (#6804)

view details

crowlKats

commit sha 9d13b539b5dfc96e2b5a0e89fc8e0312d6500fff

Fix lastModified for DomFile in FormData (#6830)

view details

Ryan Dahl

commit sha bf9930066d3a5d26baad22fb1766de26be49c2ae

Reduce size of TypeScript Compiler snapshot (#6809) This PR is intentionally ugly. It duplicates all of the code in cli/js2/ into cli/tsc/ ... because it's very important that we all understand that this code is unnecessarily duplicated in our binary. I hope this ugliness provides the motivation to clean it up. The typescript git submodule is removed, because it's a very large repo and contains all sorts of stuff we don't need. Instead the necessary files are copied directly into the deno repo. Hence +200k lines. COMPILER_SNAPSHOT.bin size ``` master 3448139 this branch 3320972 ``` Fixes #6812

view details

push time in 18 days

push eventkitsonk/deno

Kitson Kelly

commit sha 204c4f2179f7ecba3427750d506aa7480205b2f5

WIP

view details

push time in 18 days

issue commentmicrosoft/TypeScript

Symbols disallowed as object keys

Duplicate of #1863

00ff0000red

comment created time in 18 days

pull request commentdenoland/deno

[WIP] Refactor the compiler

Can you git mv the various typescript files so the diff was easier to look at?

If I did that right now, it would break CLI, so I have simply hacked around it for now.

kitsonk

comment created time in 19 days

push eventkitsonk/deno

Kitson Kelly

commit sha 6294ebb5abf9fe746937551c4ffa4879571f74b3

WIP

view details

push time in 19 days

push eventoakserver/oak

Kitson Kelly

commit sha 0bcffbb05e772ae2e7a598dfac83de1efece79b8

Fix CI configuration

view details

push time in 19 days

issue commentoakserver/oak

Add Eslint

deno lint was added in 59782a5917c58187b27c490d0a3cb69b1a3aa7ac.

cktang88

comment created time in 19 days

push eventoakserver/oak

Kitson Kelly

commit sha 59782a5917c58187b27c490d0a3cb69b1a3aa7ac

Lint code and add deno lint to pipeline

view details

push time in 19 days

issue openeddenoland/deno_lint

False positive on no-this-alias

The following code triggers the rule no-this-alias inappropriately:

const { value } = this;

The rule should be catching only things like this:

const self = this;

created time in 19 days

push eventoakserver/media_types

Kitson Kelly

commit sha 0167e1bcfba6ff2f0c62034cf7d8e667728cdebf

Add deno lint to CI

view details

push time in 19 days

Pull request review commentdenoland/deno

Use SWC to strip types for "--no-check" flag

 mod tests {     let source_code = compiled_file.code;     assert!(source_code       .as_bytes()-      .starts_with(b"console.log(\"Hello World\");"));+      .starts_with(b"console.log('Hello World');"));

Super yucky! It really shouldn't be doing that.

bartlomieju

comment created time in 19 days

issue commentoakserver/oak

Sharing state between middlewares using the context

The context is the same, trust me.

Why you don't think it is the same is that .cookies.get() only looks at cookie values in the request and not anything in the response. Because of the support for verified keys, I am not too keen on changing the behaviour, it would make it appear that the cookie is actually part of the request, when it isn't.

I would simply have the middleware move the session state in and out of the context.state... So something like this:

let sessionId = context.cookies.get(SESSION_ID);
let state;
if (!sessionId) {
  sessionId = // new guid
  context.cookies.set(SESSION_ID, sessionId);
  // init state
}
context.state.session = // get state 
await next();
// whatever other cleanup, persistence, whatever
delete context.state.session;

That way, consumers of your middleware don't have to even think about it, they will simply use:

context.state.session.whatever
domenichelfenstein

comment created time in 19 days

issue commentdenoland/deno

Question: install scripts with external assets

npm install -g with a postinstall hook ~can add~ has added your computer to a crypto-mining farm (in the past)

swwind

comment created time in 19 days

issue commentdenoland/deno

`deno bundle <file> -m` (minifier)

We already use swc in Deno. Again this is still a long term goal, as there are a load of other things we need to do (including ones related to bundling, see: #4549) before this became a priority, some of which would block this (source maps for example).

Zacharys-Hackery

comment created time in 19 days

pull request commentdenoland/deno

Use SWC to strip types for "--no-check" flag

I agree that compiler refactor is important, I don't suggest trying to hook SWC up to type checking process in this PR. Are you ok with landing change just for --no-check?

Yeah, I hadn't actually looked at the changes... straight forwards and should be easy to integrate. 👍

Thinking more, we might want to help people make the transition. I know we have avoided it, but if we surfaced --isolated as an option for run and check, then people would be able to easily run their code in type check and get back errors that are more meaningful to what they need to fix in order to support just type stripping. It would make the introduction of the breaking change easier.

bartlomieju

comment created time in 19 days

issue commentdenoland/deno

`deno bundle <file> -m` (minifier)

This would be a long term goal.

We couldn't use uglify as it doesn't work with modern JavaScript, uglify-es is no longer maintained, terser is the successor to uglify. Even then we wouldn't use it. We would look to swc though its minification likely needs improvement.

Zacharys-Hackery

comment created time in 19 days

issue commentdenoland/deno

Deno with Hermes?

Also, Hermes is significantly slower than V8 as well (34 times slower based on that benchmark). I am afraid there are a lot better paths to #986 than using Hermes.

randallb

comment created time in 19 days

pull request commentdenoland/deno

Use SWC to strip types for "--no-check" flag

Couple thoughts... I know we are eager to do this, but I think the refactor of the compiler is important (#6894). This should be even easier to implement when that is redone.

Second, we can't use it for the type checking without breaking a lot of code in the wild, especially code that doesn't use export type and import type plus const enum and potentially other code. (You want to run it with "isolatedModules": true so that the type checking is as close to just type stripping as possible). Honestly we wouldn't be able to do that until 2.0 IMO.

bartlomieju

comment created time in 19 days

push eventkitsonk/deno

Kitson Kelly

commit sha 5d1bccfe5eed699bcb34aa13d7363d389ab23e8f

WIP

view details

push time in 19 days

more