profile
viewpoint
Kitson Kelly kitsonk @denoland Melbourne, Australia https://kitsonkelly.com/ Doing stuff @denoland, author of @oakserver, @denoify, and @h-o-t

csnover/dojo-boilerplate 375

A starting point for developing with Dojo

kitsonk/colors 38

Console colors for Deno

h-o-t/nocuous 16

A static code analysis tool for JavaScript and TypeScript.

kitsonk/app-example 8

An example Dojo 2 Application

kitsonk/controller 8

Commands and Action Abstractions for Dojo

kitsonk/choak 7

An example chat application using Deno and Oak

kitsonk/d2-proto 4

Dojo 2.0 Prototypes and Experiments

kitsonk/bubba 3

A GitHub bot, making Eric's life easier

kitsonk/core-js 2

Prototype Core of Dojo 2

kitsonk/api-doc 1

A TypeScript API Documentation Generator

PR opened oakserver/oak

Fix the checking of If-Modified-Since header

This PR fix two problems in #266. The condition of 304 was inverse... and it didn't handle a precision problem (the UTC string precision is 1 second or 1000 ms), which made the test false positive.

+37 -6

0 comment

2 changed files

pr created time in 16 minutes

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

it feels like swc's testing strategy is a good issue potential discussion for swc

@kitsonk I agree, although the issue title might not be appropriately named. The issue is actually about testing swc as deno's bundler. In consideration of that, how will this be tracked within denoland?

jsejcksn

comment created time in 2 hours

Pull request review commentdenoland/deno

BREAKING(coverage): move reporting into subcommand

 impl PrettyCoverageReporter {   } } -pub fn filter_script_coverages(-  coverages: Vec<Coverage>,-  test_file_url: Url,-  test_modules: Vec<Url>,-) -> Vec<Coverage> {-  coverages+fn collect_coverages(+  dir: &PathBuf,+  _ignore: Vec<PathBuf>,+) -> Result<Vec<Coverage>, AnyError> {+  let mut coverages: Vec<Coverage> = Vec::new();++  let entries = fs::read_dir(dir)?;+  for entry in entries {+    let json = fs::read_to_string(entry.unwrap().path())?;+    let coverage: Coverage = serde_json::from_str(&json)?;++    coverages.push(coverage);+  }++  coverages = coverages     .into_iter()-    .filter(|e| {-      if let Ok(url) = Url::parse(&e.script_coverage.url) {-        if url.path().ends_with("__anonymous__") {-          return false;-        }+    .filter(|e| !e.script_coverage.url.ends_with("__anonymous__"))+    .collect::<Vec<Coverage>>();

Reverted to a simpler filter for the time being.

caspervonb

comment created time in 2 hours

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

@kitsonk Does denoland use issues to track things like this?

If so, will you please reopen this issue?

If not, how are they tracked?

jsejcksn

comment created time in 3 hours

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

No. Not yet.

jsejcksn

comment created time in 3 hours

issue commentdenoland/deno

More deno bundle errors: Improve swc testing strategy

@kdy1 It's been a while since I've looked at this. Has there been a new testing strategy implemented for swc?

jsejcksn

comment created time in 4 hours

issue openeddenoland/deno

Publish on NPM?

So this is going to seem really dumb but I think it would be pretty cool if you published Deno binaries on NPM. It would be nice for projects that publish to Deno and NPM because then it would be easier to have one consistent version used by contributors and maintainers. Kind of like hugo-bin I guess. Also maybe make sure it has a different command in that (deno-bin?).

created time in 4 hours

issue commentdenoland/vscode_deno

The img src links in the extension page are broken

Perhaps consider updating to links like these: https://github.com/denoland/vscode_deno/blob/v2/screenshot/screenshot.gif

Khobalt

comment created time in 5 hours

issue openeddenoland/vscode_deno

The img src links in the extension page are broken

The images are missing on the extension's landing page: https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno image

It seems as though they used to be hosted in this repository in the v2 branch: https://github.com/denoland/vscode_deno/raw/master/screenshot/screenshot.gif

created time in 5 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

I'll note that I'd have no clue where to start so it may well be i'm ill equipped to do so

ebebbington

comment created time in 6 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

@kitsonk If this is something you (or the core team) decide to go with, i'm happy to try implement it as I of course have my own reasons for the issue to be fixed - it sounds simple enough, depending on if rust will be used ;)

ebebbington

comment created time in 6 hours

issue commentdenoland/deno

Enable Deno namespace by default in Workers

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

nayeemrmn

comment created time in 6 hours

issue openedswc-project/swc

@swc/wasm delaying process shutdown

Describe the bug

@swc/wasm appears to delay the graceful shutdown of a node process once it's loaded.

Input code

node -e 'require("@swc/wasm"); console.log("done.  Should ideally terminate immediately but is somehow delayed by @swc/wasm")'

The node process remains running for about 5 seconds after the log statement. I'm not sure if @swc/wasm is setting some sort of timer or why the process is staying up.

Expected behavior

node process gracefully terminates immediately after the log statement.

Version The version of @swc/wasm: 1.2.45 OS: Ubuntu Linux node: v14.15.3

created time in 7 hours

issue closeddenoland/deno

Add Node.js native module polyfills to std/node

Many Node.js native module polyfills are needed in std/node, to support loading npm packages (such that we are able to leverage some of the tools while Deno specific versions are not available yet).

Note some of the modules might not yet have a corresponding Deno API available. In that case, adding a new native binding for Deno or adding a new module in std modules might be reasonable.

#3382 is an example how to inject a polyfill for require().

Some of the polyfill tasks can be Good First Issue.

  • [x] buffer
  • [ ] child_process
  • [ ] cluster (maybe low priority?)
  • [ ] crypto
  • [ ] dns
  • [x] events
  • [ ] fs (partially, high priority)
  • [ ] http/https/http2/dgram/net/tls (maybe low priority?)
  • [x] modules
  • [x] os (more bindings needed, #3802)
  • [x] path
  • [x] querystring #4370
  • [ ] readline
  • [ ] repl
  • [ ] stream
  • [ ] tty
  • [ ] url
  • [ ] util (partially)

closed time in 9 hours

kevinkassimo

issue commentdenoland/deno

Q1 2021 roadmap

Server-side rendering (SSR) native support

bartlomieju

comment created time in 10 hours

issue closeddenoland/deno

suggestion(std/examples): import from URL instead of relative path

New users use examples as tutorial. They change scripts to understand how deno works. However present scripts use import from relative path therefore they have to change it to import from URL before they modify script.

I suggest to use import from URL instead of relative path for easy to start

closed time in 11 hours

tokiedokie

issue closeddenoland/deno

http/file_server close with Uncaught Error: Short write

Not every time an exception is thrown, but most are

$ file_server
Compile https://deno.land/std/http/file_server.ts
HTTP server listening on http://0.0.0.0:4500/
[2019-12-10 02:51:41] "GET /bin/dvm_windows_amd64.tar.gz HTTP/1.1" 200
error: Uncaught Error: Short write
► https://deno.land/std/io/bufio.ts:458:18

458       this.err = new Error("Short write");
                     ^

    at flush (https://deno.land/std/io/bufio.ts:458:18)

closed time in 11 hours

axetroy

pull request commentdenoland/deno

[WIP] ffi support

I think the big effort of Wasm and Wasi is keeping js away from ISA dependent binary code, why bring FFI back to make it complex again? I think someone could argue that they need FFI for low level hardware access, but it think it could provide by the runtime(browser or deno) itself for standardisation. Have a look of the new Web Serial API and Web NFC API in Chrome 89. A restricted but "run everywhere" is unique and is its strength for deno comparing to go and rust.

manyuanrong

comment created time in 11 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

@lucacasonato Should i log an issue with them instead then?

ebebbington

comment created time in 11 hours

issue commentdenoland/deno

Building for arm64

I'm honestly not sure where the problem is. I don't believe the build V8 from source option has ever worked for me on a Raspberry Pi platform. It's possible, the the pre-compiled V8 code simply doesn't have all of the files we need for the ARM64 process inside of our Raspberry Pi 64-bit OS. It certainly helps to link to these already compiled object files, but I think a few are missing. I just don't really know where the compile pulls them from or expects to find them for me to be able to trouble shoot this correctly. I'm going to read the source code and hopefully I can figure it out.

@LukeChannings The compile V8 option actually doesn't work either.

   Compiling rustyline v7.1.0
     Running `CARGO=/home/pi/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/bin/cargo CARGO_CRATE_NAME=rustyline CARGO_MANIFEST_DIR=/home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rustyline-7.1.0 CARGO_PKG_AUTHORS='Katsu Kawakami <kkawa1570@gmail.com>' CARGO_PKG_DESCRIPTION='Rustyline, a readline implementation based on Antirez'\''s Linenoise' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MIT CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=rustyline CARGO_PKG_REPOSITORY='https://github.com/kkawakam/rustyline' CARGO_PKG_VERSION=7.1.0 CARGO_PKG_VERSION_MAJOR=7 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/home/pi/deno_v8/target/debug/deps:/home/pi/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib:/home/pi/.rustup/toolchains/stable-aarch64-unknown-linux-gnu/lib' rustc --crate-name rustyline --edition=2018 /home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rustyline-7.1.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 -C metadata=a63972f04dd793a5 -C extra-filename=-a63972f04dd793a5 --out-dir /home/pi/deno_v8/target/debug/deps -L dependency=/home/pi/deno_v8/target/debug/deps --extern bitflags=/home/pi/deno_v8/target/debug/deps/libbitflags-8697a9bfe9f801d9.rmeta --extern cfg_if=/home/pi/deno_v8/target/debug/deps/libcfg_if-f839896df4fc84b3.rmeta --extern fs2=/home/pi/deno_v8/target/debug/deps/libfs2-9436ff614a97209b.rmeta --extern libc=/home/pi/deno_v8/target/debug/deps/liblibc-8a7be3f7c7d71dd5.rmeta --extern log=/home/pi/deno_v8/target/debug/deps/liblog-3d420c83767f3cbd.rmeta --extern memchr=/home/pi/deno_v8/target/debug/deps/libmemchr-88d44ab3a3ad53b8.rmeta --extern nix=/home/pi/deno_v8/target/debug/deps/libnix-d06e9adb446c0b6b.rmeta --extern unicode_segmentation=/home/pi/deno_v8/target/debug/deps/libunicode_segmentation-0eb7ef3dc88bb3d6.rmeta --extern unicode_width=/home/pi/deno_v8/target/debug/deps/libunicode_width-fbbe897f9c536b45.rmeta --extern utf8parse=/home/pi/deno_v8/target/debug/deps/libutf8parse-501eca5af2b9d42a.rmeta --cap-lints warn`
[rusty_v8 0.16.0] Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-llvmorg-12-init-11060-g118c3f3c-1.tgz .......... Done.
[rusty_v8 0.16.0] cargo:warning=Not using sccache or ccache
[rusty_v8 0.16.0] The current directory is /home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0
[rusty_v8 0.16.0] gn gen --root=/home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0 /home/pi/deno_v8/target/debug/gn_out
[rusty_v8 0.16.0] running: "/home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn" "--root=/home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0" "gen" "/home/pi/deno_v8/target/debug/gn_out" "--args=is_debug=true clang_base_path=\"/home/pi/deno_v8/target/debug/clang\""
[rusty_v8 0.16.0] /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: 1: /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: t:t:Q�td��: not found
[rusty_v8 0.16.0] /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: 2: /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: Syntax error: ")" unexpected
[rusty_v8 0.16.0] thread 'main' panicked at '
[rusty_v8 0.16.0] command did not execute successfully, got: exit code: 2
[rusty_v8 0.16.0] 
[rusty_v8 0.16.0] build script failed, must exit now', /home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo_gn-0.0.15/src/lib.rs:203:3
[rusty_v8 0.16.0] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[rusty_v8 0.16.0] /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: 1: /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: �A: not found
[rusty_v8 0.16.0] /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: 1: /home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn: ELF: not found
The following warnings were emitted during compilation:

warning: Not using sccache or ccache

error: failed to run custom build command for `rusty_v8 v0.16.0`

Caused by:
  process didn't exit successfully: `/home/pi/deno_v8/target/debug/build/rusty_v8-11a5972bc80a798f/build-script-build` (exit code: 101)
  --- stdout
  Downloading https://github.com/denoland/ninja_gn_binaries/archive/20210101.tar.gz... Done.
  using Chromiums clang
  clang_base_path /home/pi/deno_v8/target/debug/clang
  Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-llvmorg-12-init-11060-g118c3f3c-1.tgz .......... Done.
  cargo:warning=Not using sccache or ccache
  The current directory is /home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0
  gn gen --root=/home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0 /home/pi/deno_v8/target/debug/gn_out
  running: "/home/pi/deno_v8/target/debug/ninja_gn_binaries-20210101/linux64/gn" "--root=/home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.16.0" "gen" "/home/pi/deno_v8/target/debug/gn_out" "--args=is_debug=true clang_base_path=\"/home/pi/deno_v8/target/debug/clang\""
warning: build failed, waiting for other jobs to finish...
error: build failed
afinch7

comment created time in 11 hours

issue commentdenoland/deno

Worker MessageChannel

@lucacasonato Do you think that https://github.com/denoland/deno/issues/9006 should be closed in favor of this?

rracariu

comment created time in 12 hours

issue commentdenoland/deno

Type Error With std/async/pool & a TSConfig

This is an upstream Typescript issue. They should add typings for ReadableStream being an async iterator to lib.dom.

ebebbington

comment created time in 12 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

@Brooooooklyn same result:

C:\Users\xyz\projects\swc-win32> del .\node_modules\

Confirm
The item at C:\Users\xyz\projects\swc-win32\node_modules\ has children and the Recurse parameter was not specified. If you continue, all children will be removed with the item. Are you sure you want to continue?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
PS C:\Users\xyz\projects\swc-win32> del .\yarn.lock
PS C:\Users\xyz\projects\swc-win32> yarn
yarn install v1.22.5
warning package.json: No license field
info No lockfile found.
warning No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
info @swc/core-linux-x64-gnu@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-linux-x64-gnu@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-linux-arm-gnueabihf@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-linux-arm-gnueabihf@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-linux-arm-gnueabihf@1.2.45: The CPU architecture "x64" is incompatible with this module.
info @swc/core-linux-arm64-gnu@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-linux-arm64-gnu@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-linux-arm64-gnu@1.2.45: The CPU architecture "x64" is incompatible with this module.
info @swc/core-darwin-x64@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-darwin-x64@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-darwin-arm64@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-darwin-arm64@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-darwin-arm64@1.2.45: The CPU architecture "x64" is incompatible with this module.
info @swc/core-linux-x64-musl@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-linux-x64-musl@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-android-arm64@1.2.45: The platform "win32" is incompatible with this module.
info "@swc/core-android-arm64@1.2.45" is an optional dependency and failed compatibility check. Excluding it from installation.
info @swc/core-android-arm64@1.2.45: The CPU architecture "x64" is incompatible with this module.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
Done in 4.89s.
PS C:\Users\xyz\projects\swc-win32> yarn swc
yarn run v1.22.5
warning package.json: No license field
$ C:\Users\xyz\projects\swc-win32\node_modules\.bin\swc
C:\Users\xyz\projects\swc-win32\node_modules\@node-rs\helper\lib\loader.js:27
    throw new TypeError(errorMsg);
    ^

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc and C:\Users\xyz\projects\swc-win32\node_modules\@swc\core\swc.win32-x64-gnu.node, C:\Users\xyz\projects\swc-win32\node_modules\@swc\core\swc.win32-x64-msvc.node
    at Object.loadBinding (C:\Users\xyz\projects\swc-win32\node_modules\@node-rs\helper\lib\loader.js:27:11)
    at Object.<anonymous> (C:\Users\xyz\projects\swc-win32\node_modules\@swc\core\index.js:26:27)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (C:\Users\xyz\projects\swc-win32\node_modules\@swc\cli\lib\src\swc\util.js:35:26)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
tw-360vier

comment created time in 14 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

@tw-360vier delete node_modules and yarn.lock and reinstall, then try again

tw-360vier

comment created time in 14 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

@Brooooooklyn yes it's there:

 ls .\node_modules\@swc\core-win32-x64-msvc\


    Directory: C:\Users\xyz\projects\swc-win32\node_modules\@swc\core-win32-x64-msvc


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         1/22/2021  12:43 PM            773 package.json
-a----         1/22/2021  12:43 PM             92 README.md
-a----         1/22/2021  12:43 PM       31024128 swc.win32-x64-msvc.node
tw-360vier

comment created time in 14 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

@tw-360vier I could not reproduce on my windows virtual machine, does swc.win32-x64-msvc.node existed in node_modules/@swc/core-win32-x64-msvc folder ?

tw-360vier

comment created time in 14 hours

issue openeddenoland/deno

Error from eval when adding -p flag

The command

deno eval 'let i=3;1+i'

works as expected returning no error code and if we print the last statement it returns 4 as expected:

deno eval 'let i=3;1+i;console.log(1+i)'

However, if you add the -p flag to automaticly print the output it returns an error

deno eval -p 'let i=3;1+i'
> error: Expected ,, got i at file:///.../$deno$eval.ts:1:16

I was expecting it to print out 4 as that is the result of the last statement.

created time in 14 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

Oh i did not copy the project. I created this minimal project on the windows machine:

yarn init
yarn add -d @swc/core @swc/cli
tw-360vier

comment created time in 15 hours

issue commentswc-project/swc

TypeError: Can not find node binding files from @swc/core-win32-x64-gnu, @swc/core-win32-x64-msvc...

Did you run npm install after copying?

cc @Brooooooklyn

tw-360vier

comment created time in 15 hours

issue commentdenoland/deno

Refactor ResourceTable tracking issue

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

bartlomieju

comment created time in 15 hours

more