profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kinow/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Bruno P. Kinoshita kinow @niwa Auckland, New Zealand https://kinoshita.eti.br From Casa Verde, São Paulo . Now in CBD, Auckland . Working with @niwa on @cylc

jenkinsci/testlink-plugin 45

Jenkins testlink plugin

jenkinsci/nunit-plugin 41

Jenkins nunit plugin

jenkinsci/tap-plugin 23

Jenkins TAP Plug-in

imoutsatsos/uno-choice-plugin 9

a.k.a. Active-Choices: A Jenkins dynamic parameter/UI plugin for highly interactive Jenkins build forms

jenkinsci/ccm-plugin 4

Jenkins ccm plugin

darkrift/selenium-plugin 3

Jenkins selenium plugin

kinow/aboriginal-flag-cv-model 1

A tutorial and trained model that can identify Aboriginal flags in images using PyTorch and Detecto

kinow/angularjs-typeahead-dropdown 1

AngularJS Typeahead Dropdown

startedAriaMinaei/theatre

started time in 5 hours

push eventapache/commons-release-plugin

dependabot[bot]

commit sha 2a539d22145039623af67e5d9b73cfad25205490

Bump maven-scm.version from 1.11.3 to 1.12.0 Bumps `maven-scm.version` from 1.11.3 to 1.12.0. Updates `maven-scm-api` from 1.11.3 to 1.12.0 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.11.3...maven-scm-1.12.0) Updates `maven-scm-provider-svnexe` from 1.11.3 to 1.12.0 Updates `maven-scm-provider-svn-commons` from 1.11.3 to 1.12.0 --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-api dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.scm:maven-scm-provider-svnexe dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.scm:maven-scm-provider-svn-commons dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 11 hours

PR merged apache/commons-release-plugin

Bump maven-scm.version from 1.11.3 to 1.12.0 dependencies java

Bumps maven-scm.version from 1.11.3 to 1.12.0. Updates maven-scm-api from 1.11.3 to 1.12.0 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/maven-scm/commit/50e8c04561383789aef1a70a8d70569ad7d0efe6"><code>50e8c04</code></a> [maven-release-plugin] prepare release maven-scm-1.12.0</li> <li><a href="https://github.com/apache/maven-scm/commit/6eb3e719e630aac7683fc5b2d6b5bc8de4e24f1a"><code>6eb3e71</code></a> [SCM-968] Reduce standard providers to non-deprecated ones</li> <li><a href="https://github.com/apache/maven-scm/commit/e5b41e5459270094eb27ad28fe71c1339139cd1e"><code>e5b41e5</code></a> [SCM-967] MavenScmCli requires at least three args not less</li> <li><a href="https://github.com/apache/maven-scm/commit/9b27fddeeeb386512949d87876945fef595cf47f"><code>9b27fdd</code></a> [SCM-966] Deprecate maven-scm-provider-synergy</li> <li><a href="https://github.com/apache/maven-scm/commit/2ce895fed0d54beb753b654360803c940f14766a"><code>2ce895f</code></a> [SCM-965] Deprecate maven-scm-providers-cvs</li> <li><a href="https://github.com/apache/maven-scm/commit/3bb58b54250f9bd55c84e0456d251c33d44db86c"><code>3bb58b5</code></a> [SCM-964] Deprecate maven-scm-provider-vss</li> <li><a href="https://github.com/apache/maven-scm/commit/8bdb711005024c55600ce0dd5476d607124f4903"><code>8bdb711</code></a> [SCM-963] Deprecate maven-scm-provider-tfs</li> <li><a href="https://github.com/apache/maven-scm/commit/864c9b1d6db95ca0aac6fd8ea2f7f81c866c0b69"><code>864c9b1</code></a> [SCM-962] Deprecate maven-scm-provider-starteam</li> <li><a href="https://github.com/apache/maven-scm/commit/bb405b02d2b17f3b3a87856d76207f34c3ff371a"><code>bb405b0</code></a> [SCM-961] Deprecate maven-scm-provider-perforce</li> <li><a href="https://github.com/apache/maven-scm/commit/878d7172ad98401345eb1e364a1788e75f990706"><code>878d717</code></a> [SCM-960] Deprecate maven-scm-provider-jazz</li> <li>Additional commits viewable in <a href="https://github.com/apache/maven-scm/compare/maven-scm-1.11.3...maven-scm-1.12.0">compare view</a></li> </ul> </details> <br />

Updates maven-scm-provider-svnexe from 1.11.3 to 1.12.0

Updates maven-scm-provider-svn-commons from 1.11.3 to 1.12.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+2 -2

0 comment

2 changed files

dependabot[bot]

pr closed time in 11 hours

push eventapache/commons-release-plugin

dependabot[bot]

commit sha 647998a0e020d1cf0dd2dade3b86f2861df3e04f

Bump maven-scm.version from 1.11.3 to 1.12.0 Bumps `maven-scm.version` from 1.11.3 to 1.12.0. Updates `maven-scm-api` from 1.11.3 to 1.12.0 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.11.3...maven-scm-1.12.0) Updates `maven-scm-provider-svnexe` from 1.11.3 to 1.12.0 Updates `maven-scm-provider-svn-commons` from 1.11.3 to 1.12.0 --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-api dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.scm:maven-scm-provider-svnexe dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.scm:maven-scm-provider-svn-commons dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 11 hours

push eventkinow/jena-tests

dependabot[bot]

commit sha a9639359768dc453e5b6f78d5a9e9059652fe10f

Bump jena-core from 3.10.0-SNAPSHOT to 4.2.0 Bumps jena-core from 3.10.0-SNAPSHOT to 4.2.0. --- updated-dependencies: - dependency-name: org.apache.jena:jena-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Bruno P. Kinoshita

commit sha 84834a198d7b5dbf5675061a4a51359015c43cfe

Merge pull request #11 from kinow/dependabot/maven/org.apache.jena-jena-core-4.2.0 Bump jena-core from 3.10.0-SNAPSHOT to 4.2.0

view details

push time in 12 hours

PR merged kinow/jena-tests

Bump jena-core from 3.10.0-SNAPSHOT to 4.2.0 dependencies

Bumps jena-core from 3.10.0-SNAPSHOT to 4.2.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 hours

PullRequestReviewEvent
GollumEvent
GollumEvent
GollumEvent

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

@hjoliver sent me a workflow that shows errors due to missing parents. It happens when a task cannot find the parent family proxy, and also when a job cannot find the parent task.

I've created a gist with the deltas collected, the diff used to fire the debugger and to log more info, and also to remove GScan to have one less subscription to filter: https://gist.github.com/kinow/817205bbbef7684722fce5cce1939764

One parent task only appears as updated, skipping the added status. But I'm still investigating it that's the cause of the errors with that workflow.

kinow

comment created time in 12 hours

push eventkinow/kinoshita.eti.br

kinow

commit sha 454abbb2c73b89bc6e8f5c40631aa2d25095da34

deploy: 2b66a843cbcfe16c9145157289e4f72f1ef14925

view details

push time in 12 hours

push eventkinow/kinoshita.eti.br

Bruno P. Kinoshita

commit sha 2b66a843cbcfe16c9145157289e4f72f1ef14925

Update short-stories.yml

view details

push time in 12 hours

pull request commentcylc/cylc-ui

Merge lists using a Set/unique

To review:

  1. Go to master, build it for development
  2. Open a tree view
  3. Add a second tree view, watch either Network tab for the stop/start messages, or see if the UI clears the views and re-populates them

Then switch to this branch and try that again.

kinow

comment created time in 13 hours

Pull request review commentcylc/cylc-ui

Merge lists using a Set/unique

 describe('mergeQueries', () => {         })       })       describe('Values', () => {-      })-      it('should merge arguments', () => {-        const queryA = gql`query A {-          jobs (sort: true, name: "a", keys: ["a", "b"], expired: 100, flag: $flag, test: null) { id }-        }`-        const queryB = gql`query B {-          jobs (keys: ["c"], age: 10, expired: 100, flag: $flag, test: null) { name }-        }`-        const merged = mergeQueries(queryA, queryB)-        const expected = gql`query A {-          jobs (sort: true, name: "a", keys: ["a", "b", "c"], expired: 100, flag: $flag, test: null, age: 10) { id name }-        }`-        assertQueriesAreEqual(merged, expected)-      })-      it('should merge arguments with objects', () => {-        // Objects tests are a bit longer, so breaking into two basic tests-        const queryA = gql`query A {-          jobs (user: { id: 1, name: "cylc" }) {-            id-          }-        }`-        const queryB = gql`query B {-          jobs (user: { id: 1, name: "cylc" }) {-            name-          }-        }`-        const merged = mergeQueries(queryA, queryB)-        const expected = gql`query A {-          jobs (user: { id: 1, name: "cylc" }) {-            id-            name-          }-        }`-        assertQueriesAreEqual(merged, expected)+        it('should merge arguments', () => {+          const queryA = gql`query A {+            jobs (sort: true, name: "a", keys: ["a", "b"], expired: 100, flag: $flag, test: null) { id }+          }`+          const queryB = gql`query B {+            jobs (keys: ["c"], age: 10, expired: 100, flag: $flag, test: null) { name }+          }`+          const merged = mergeQueries(queryA, queryB)+          const expected = gql`query A {+            jobs (sort: true, name: "a", keys: ["a", "b", "c"], expired: 100, flag: $flag, test: null, age: 10) { id name }+          }`+          assertQueriesAreEqual(merged, expected)+        })+        it('should merge arguments with objects', () => {+          // Objects tests are a bit longer, so breaking into two basic tests+          const queryA = gql`query A {+            jobs (user: { id: 1, name: "cylc" }) {+              id+            }+          }`+          const queryB = gql`query B {+            jobs (user: { id: 1, name: "cylc" }) {+              name+            }+          }`+          const merged = mergeQueries(queryA, queryB)+          const expected = gql`query A {+            jobs (user: { id: 1, name: "cylc" }) {+              id+              name+            }+          }`+          assertQueriesAreEqual(merged, expected)+        })+        it('should merge arguments with lists', () => {+          const queryA = gql`query A {+            jobs (workflows: ["root", "test"]) {+              id+            }+          }`+          const queryB = gql`query B {+            jobs (workflows: ["root", "airplane"]) {+              name+            }+          }`+          const merged = mergeQueries(queryA, queryB)+          const expected = gql`query A {+            jobs (workflows: ["root", "test", "airplane"]) {

This is essentially what was happening when merging the subscriptions; see linked issue for the complete diff.

kinow

comment created time in 13 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventkinow/cylc-ui

Bruno P. Kinoshita

commit sha 6899398857988c4bf55c566567af51208730d64b

Merge lists using a Set/unique

view details

push time in 13 hours

push eventkinow/cylc-ui

Bruno P. Kinoshita

commit sha 317c280d31ef76785b4f3cf7350ec8c13f4e3794

Replace unionBy by for-loop

view details

push time in 15 hours

PR opened cylc/cylc-ui

Merge lists using a Set/unique

These changes close #778

Requirements check-list

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [ ] Appropriate tests are included (unit and/or functional).
  • [x] No change log entry required (why? e.g. invisible to users, not released yet).
  • [x] No documentation update required.
+1 -1

0 comment

1 changed file

pr created time in 16 hours

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

@hjoliver shared his screen showing what this PR looks like.

  1. yarn run build
  2. start UIS + five
  3. add a second Tree View

Now the tree views are both frozen, not being updated. The network tab shows 2 GraphQL subscriptions, 1 being GScan as always, and 3 the tree views. Normally the ID for the tree view would be 2, so I guess the subscription was reloaded but then the UI got confused somehow.

We tested on Chrome and Firefox on Linux.

kinow

comment created time in 16 hours

create barnchkinow/cylc-ui

branch : merge-unique-list-values

created branch time in 16 hours

issue openedcylc/cylc-ui

Subscription being reloaded unnecessarily

Describe the bug <!-- A clear and concise description of the bug. -->

Found this while testing a PR with @hjoliver https://github.com/cylc/cylc-ui/pull/749#issuecomment-923317099

Copied the initialQuery and finalQuery, and realized it's a bug caused by

The diff shows that some values were incorrectly merged.

Release version(s) and/or repository branch(es) affected? <!-- Have you checked that the bug is not already fixed in newer versions? -->

master

Steps to reproduce the bug <!-- Give sufficient details so that others can quickly verify the problem. -->

  1. Add a Tree view
  2. Add a second Tree view
  3. Either observe in Network tab or see if the components are cleared, leaving a blank view, then reloaded

Expected behavior <!-- A clear and concise description of what you expected to happen. -->

Since both views use the same query, nothing must change in the UI, except for a new view added.

Screenshots <!-- If applicable, add screenshots to help explain your problem. -->

Additional context <!-- Add other useful information here. -->

kinow@ranma:/tmp$ diff initial final
2c2
<   deltas(workflows: [$workflowId], stripNull: true) {
---
>   deltas(workflows: [$workflowId, $workflowId], stripNull: true) {
24c24
<   cyclePoints: familyProxies(ids: ["root"], ghosts: true) {
---
>   cyclePoints: familyProxies(ids: ["root", "root"], ghosts: true) {
27c27
<   familyProxies(exids: ["root"], sort: {keys: ["name"]}, ghosts: true) {
---
>   familyProxies(exids: ["root", "root"], sort: {keys: ["name"]}, ghosts: true) {
45c45
<   familyProxies(exids: ["root"], ghosts: true) {
---
>   familyProxies(exids: ["root", "root"], ghosts: true) {
65c65
<     states: ["failed", "preparing", "submit-failed", "submitted", "running"]
---
>     states: ["failed", "preparing", "submit-failed", "submitted", "running", "failed", "preparing", "submit-failed", "submitted", "running"]

Pull requests welcome! This is an Open Source project - please consider contributing a bug fix yourself (please read CONTRIBUTING.md before starting any work though).

created time in 16 hours

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

In case it helps, heres five

[scheduling]
  cycling mode = integer
  initial cycle point = 1
  [[queues]]
     [[[default]]]
       limit = 1
  [[graph]]
    R1 = "prep => foo"
    P1 = "foo[-P1] => foo => bar"

[runtime]
  [[root]]
      script="sleep 5"
  [[prep]]
  [[foo]]
  [[bar]]

kinow

comment created time in 17 hours

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

If you would like I can try with the same workflow you are using and see if it works?

kinow

comment created time in 17 hours

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

Looks good. Does it carry on to the next cycle points though, with multiple tabs open?

I think so. Two trees, CP 180.

image

Some seconds later, CP 182.

image

I found why it's restarting the subscription, but that's a bug in master too. Will create an issue for that one and start preparing a fix and an e2e test to prevent that regression :+1:

kinow

comment created time in 17 hours

pull request commentcylc/cylc-ui

Create delta callbacks, control execution order of added, updated, pruned

Working OK for me @hjoliver

  1. checked out branch (double-checked it was up to date)
  2. yarn install
  3. yarn run build:watch
  4. Started UIS & five

GIFrecord_2021-09-21_091324

kinow

comment created time in 17 hours

push eventkinow/jena-arq-filter

dependabot[bot]

commit sha cdf31ed247fa2cabd8832c055522622e28da077a

Bump jena-core from 3.3.0-SNAPSHOT to 4.2.0 Bumps jena-core from 3.3.0-SNAPSHOT to 4.2.0. --- updated-dependencies: - dependency-name: org.apache.jena:jena-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Bruno P. Kinoshita

commit sha dd473f107ced0de5c279af12e0662f8b93312145

Merge pull request #3 from kinow/dependabot/maven/org.apache.jena-jena-core-4.2.0 Bump jena-core from 3.3.0-SNAPSHOT to 4.2.0

view details

push time in 18 hours

PR merged kinow/jena-arq-filter

Bump jena-core from 3.3.0-SNAPSHOT to 4.2.0 dependencies

Bumps jena-core from 3.3.0-SNAPSHOT to 4.2.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 18 hours

PullRequestReviewEvent