profile
viewpoint
kiloreux kiloreux Master's graduate in Robotics and AI. C, C++, ROS, Tensorflow.

transloadit/uppy 23100

The next open source file uploader for web browsers :dog:

kiloreux/awesome-robotics 1915

A list of awesome Robotics resources

tus/tusd 1747

Reference server implementation in Go of tus: the open protocol for resumable file uploads

kiloreux/lazy_tools 7

Linux tools for the lazy

transloadit/TransloaditKit 7

An iOS and macOS integration for Transloadit's file uploading and encoding service

kiloreux/AGITR 2

Going my way through the examples in A Gentle Introduction to ROS

kiloreux/BloodBank 2

This is a small web application for blood bank so that people can contact blood donors when they need some .

kiloreux/robot_joystick_control 2

Simple page to control pioneer robot using websocket

PullRequestReviewEvent
PullRequestReviewEvent

push eventkiloreux/awesome-robotics

Adrián Matejov

commit sha 712a974a317653d922ee14035cd8dda84b42ca5a

add First Lego League to the competitions (#51)

view details

push time in 2 months

pull request commentkiloreux/awesome-robotics

add First Lego League to the competitions

Thank you so much for adding this.

Adman

comment created time in 2 months

push eventkiloreux/awesome-robotics

Marek Šuppa

commit sha e1c71513a71a2e80cff4f61f4e88aa1d40c1fe48

Update README.md (#49) Add RoboCupJunior Soccer (link to competition as well as the `awesome` list).

view details

push time in 3 months

PR merged kiloreux/awesome-robotics

Update README.md

Add RoboCupJunior Soccer (link to competition as well as the awesome list).

+2 -0

0 comment

1 changed file

mrshu

pr closed time in 3 months

delete branch transloadit/uppy

delete branch : revert-2348-master

delete time in 3 months

CommitCommentEvent

create barnchtransloadit/uppy

branch : revert-2348-master

created branch time in 3 months

push eventtransloadit/uppy

Matthew Hartstonge

commit sha 0367074d92c2c59d565494ff69a5cab090ca497c

companion: fixes docker version tagging. fixes #1579.

view details

kiloreux

commit sha 59eb9118a3d8c237d88ab3b3938da3cdd0e2ff66

Merge pull request #2348 from matthewhartstonge/master companion: fixes docker version tagging. fixes #1579.

view details

push time in 3 months

PR merged transloadit/uppy

companion: fixes docker version tagging. fixes #1579.

So, turns out I never checked in on the code fix for this.. Currently what happens:

docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;

# `docker images` returns:
# REPOSITORY              TAG                 IMAGE ID            CREATED             SIZE
# transloadit/companion   latest              123456789           2020-06-30          5MB
# transloadit/companion   d33db33f            123456789           2020-06-30          5MB

if [[ -z "${TRAVIS_TAG}" ]]; then
  # Pushes up the image ONLY if tag is empty
  docker push transloadit/companion:$TRAVIS_COMMIT;
else
  # 💥 docker can't find version tagged image, as it was never tagged...
  docker push transloadit/companion:$TRAVIS_TAG;
fi

So now, we have:

docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;

# `docker images` returns:
# REPOSITORY              TAG                 IMAGE ID            CREATED             SIZE
# transloadit/companion   latest              123456789           2020-06-30          5MB
# transloadit/companion   d33db33f            123456789           2020-06-30          5MB

# If tag is not empty; then....
if [[ ! -z "${TRAVIS_TAG}" ]]; then
  # Tag the image with the git tag...
  # Refer: https://docs.docker.com/engine/reference/commandline/tag/
  docker tag transloadit/companion:$TRAVIS_COMMIT transloadit/companion:$TRAVIS_TAG;

# `docker images` returns:
# REPOSITORY              TAG                 IMAGE ID            CREATED             SIZE
# transloadit/companion   latest              123456789           2020-06-30          5MB
# transloadit/companion   d33db33f            123456789           2020-06-30          5MB
# transloadit/companion   vL.0.L              123456789           2020-06-30          5MB
  
  # Docker can now find and successfully push up the version tagged image 🐳🎉
  docker push transloadit/companion:$TRAVIS_TAG;
fi
+8 -4

0 comment

1 changed file

matthewhartstonge

pr closed time in 3 months

Pull request review commenttransloadit/uppy

companion: fixes docker version tagging. fixes #1579.

 mv ./kubectl ${HOME}/.local/bin/ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion; docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"; -if [[ -z "${TRAVIS_TAG}" ]]; then-  docker push transloadit/companion:$TRAVIS_COMMIT;-else+# Push the commit tagged docker image.+docker push transloadit/companion:$TRAVIS_COMMIT;++# If this build includes a git tag, tag the image with the git version tag and push the version.+if [[ ! -z "${TRAVIS_TAG}" ]]; then+  docker tag transloadit/companion:$TRAVIS_COMMIT transloadit/companion:$TRAVIS_TAG;   docker push transloadit/companion:$TRAVIS_TAG; fi +# Lastly, update the pointer to latest.

Thank you for the extra comment.

matthewhartstonge

comment created time in 3 months

Pull request review commenttransloadit/uppy

companion: fixes docker version tagging. fixes #1579.

 mv ./kubectl ${HOME}/.local/bin/ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion; docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"; -if [[ -z "${TRAVIS_TAG}" ]]; then-  docker push transloadit/companion:$TRAVIS_COMMIT;-else+# Push the commit tagged docker image.+docker push transloadit/companion:$TRAVIS_COMMIT;

This looks great, Thank you.

matthewhartstonge

comment created time in 3 months

Pull request review commenttransloadit/uppy

companion: fixes docker version tagging. fixes #1579.

 mv ./kubectl ${HOME}/.local/bin/ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion; docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"; -if [[ -z "${TRAVIS_TAG}" ]]; then-  docker push transloadit/companion:$TRAVIS_COMMIT;-else+# Push the commit tagged docker image.+docker push transloadit/companion:$TRAVIS_COMMIT;++# If this build includes a git tag, tag the image with the git version tag and push the version.+if [[ ! -z "${TRAVIS_TAG}" ]]; then+  docker tag transloadit/companion:$TRAVIS_COMMIT transloadit/companion:$TRAVIS_TAG;

This one looks great, thanks.

matthewhartstonge

comment created time in 3 months

more