profile
viewpoint
Kevin Burke kevinburke https://burke.services Alamo, CA https://kevin.burke.dev Formerly engineering at Twilio and Shyp. Now doing consulting, possibly for you. Get in touch!

golang/dep 13251

Go dependency management tool

inconshreveable/log15 975

Structured, composable logging for Go

kevinburke/2013 10

Flat UI website redesign

kevinburke/autoenv 1

Directory-based environments.

kevinburke/bigtext 1

Go library to display text really big using Quicksilver on a Mac

kevinburke/1915-berryman 0

Application documents for the 1915 Berryman project

kevinburke/2013.cascadiajs.com 0

This is the official repo for the CascadiaJS 2013 conference.

kevinburke/2014.cascadiajs.com 0

This is the official repo for the CascadiaJS 2014 conference.

kevinburke/2015.cascadiajs.com 0

The official repo for the CascadiaJS 2015 conference

issue commentgolang/go

x/build/cmd/gopherbot: -2 any CLs with large binary blobs unless declared in commit message

At the very least, if you had the bot post a comment ("hi you have a very large file in here, please confirm that you really wanted to do this"), it would probably get the human reviewers to spend an extra second or two reviewing the patch contents before submit

josharian

comment created time in 9 hours

issue closedgithub-release/github-release

error: could not find the release corresponding to tag v1.3

github-release v0.8.1

  • run
export GITHUB_TOKEN=XXXXX
export HASH=$(git rev-parse HEAD)
export BRANCH=$(basename $(git branch -r --contains ${HASH}))
export tag=$(basename $(git describe --all --exact-match ${HASH}))

echo "HASH: $HASH"
echo "BRANCH: $BRANCH"
echo "TAG: $tag"
VERSION=${tag//v/}
echo "VERSION: $VERSION"

true||./github-release release \
  --user QingYanL  \
  --repo mavendemo  \
  --tag ${tag} \
  --name ${tag}  \
  --relaese

./github-release upload  \
  --user QingYanL \
  --repo mavendemo \
  --tag ${tag} \
  --name cita_sm2_sm3-${VERSION}.tar.gz \
  --file ./cita_sm2_sm3.tar.gz -R

error: could not find the release corresponding to tag v1.3 image

I confirm the existence tag for v1.3 (https://github.com/QingYanL/mavendemo/releases/tag/v1.3)

Please help me. What should I do ?

closed time in 3 days

QingYanL

created tagkevinburke/twilio-go

tag2.4

Twilio Go library

created time in 3 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha 320748330fac2e8e3b5ce1772cbd9cdf557dbac6

2.4

view details

push time in 3 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha c7fc57e2ec34424d16c0148d3eec18192f9cf15b

CHANGELOG: prepare for 2.4 release

view details

push time in 3 days

push eventkevinburke/twilio-go

Joey Lee

commit sha cb4dae50b902031237a28ca201cd8463aca2bd02

twilio: add Voice Insights API Added all three [Twilio Voice Insights API](https://www.twilio.com/docs/voice/insights/api) resources: - Summary - Events - Metrics How to use it: ``` t.client.Insights.VoiceInsights(callSID).Metrics.GetPage(ctx, params) t.client.Insights.VoiceInsights(callSID).Events.GetPage(ctx, params) t.client.Insights.VoiceInsights(callSID).Summary.Get(ctx) t.client.Insights.VoiceInsights(callSID).Summary.GetPartial(ctx) ```

view details

push time in 3 days

create barnchkevinburke/twilio-go

branch : yeoji-voice-insights

created branch time in 3 days

create barnchkevinburke/1915-berryman

branch : master

created branch time in 7 days

created repositorykevinburke/1915-berryman

Application documents for the 1915 Berryman project

created time in 7 days

push eventkevinburke/weirdfortune

Kevin Burke

commit sha 472be8088b691bc1403aa5e5300c6b59d6cac3b1

lib: avoid duplicates

view details

Kevin Burke

commit sha 5b106c5734312d41df7a78d02551ea34e8702118

games/weirdfortunes: edit fortunes

view details

push time in 7 days

pull request commentkevinburke/twilio-go

Add Voice Insights API

OK, just the one change to Cleanup and then I can merge - please leave a comment when you've pushed the change, thanks!

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

 type ToFrom struct { 	NumberPrefix string `json:"number_prefix"` } +// Gets a call summary resource from the Voice Insights API.+// See https://www.twilio.com/docs/voice/insights/api/call-summary-resource#get-call-summary func (s *CallSummaryService) Get(ctx context.Context) (*CallSummary, error) { 	summary := new(CallSummary) 	err := s.client.ListResource(ctx, fmt.Sprintf("Voice/%s/%s", s.callSid, SummaryPathPart), url.Values{}, summary) 	return summary, err } +// Gets a partial call summary resource from the Voice Insights API.+// A completed call summary may take up to a half hour to generate,+// but a partial summary record will be available within ten minutes of a call ending.+// See https://www.twilio.com/docs/voice/insights/api/call-summary-resource#get-call-summary

Thanks for adding these.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

 func TestGetCallEventsPage(t *testing.T) { 	if page.Events[0].Edge != "client_edge" { 		t.Errorf("expected Edge to be 'client_edge', got %s", page.Events[0].Edge) 	}++	t.Cleanup(s.Close)

Ah... if anything in the test panics, we won't run the cleanup if it's declared at the end, so it's ideal to put this up where we create s. Basically I think use it like a defer.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`+	Rtt       MetricsSummary    `json:"rtt"`+	Tags      map[string]string `json:"tags"`+	AudioOut  MetricsSummary    `json:"audio_out"`+	AudioIn   MetricsSummary    `json:"audio_in"`+}++type SdkEdgeProperties struct {+	Direction string `json:"direction"`+	Settings  struct {+		DSCP              bool     `json:"dscp"`+		ICERestartEnabled bool     `json:"ice_restart_enabled"`+		Edge              string   `json:"edge"`+		SelectedEdges     []string `json:"selected_edges"`+	} `json:"settings"`+}++type SdkEdgeEvents struct {+	Levels map[string]int `json:"levels"`+	Groups map[string]int `json:"groups"`+	Errors map[string]int `json:"errors"`+}++type MetricsSummary struct {+	Max float64 `json:"max"`+	Avg float64 `json:"avg"`+	Min float64 `json:"min"`+}++type CallProperties struct {+	Direction          Direction `json:"direction"`+	DisconnectedBy     string    `json:"disconnected_by"`+	PostDialDelay      int       `json:"pdd_ms"`+	LastSIPResponseNum int       `json:"last_sip_response_num"`+}++type ToFrom struct {

Sure, that works.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const MetricsPathPart = "Metrics"++type CallMetricsService struct {+	callSid string+	client  *Client+}++type CallMetricsPage struct {+	Metrics []CallMetric `json:"metrics"`+	Meta    Meta         `json:"meta"`+}++type CallMetric struct {+	AccountSid  string       `json:"account_sid"`+	CallSid     string       `json:"call_sid"`+	CarrierEdge *EdgeMetrics `json:"carrier_edge,omitempty"`+	ClientEdge  *EdgeMetrics `json:"client_edge,omitempty"`+	Direction   string       `json:"direction"`+	Edge        string       `json:"edge"`+	SdkEdge     *EdgeMetrics `json:"sdk_edge,omitempty"`

Oh, right, this is more about people going from the struct to JSON, then the reverse. OK, I'm fine either way.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`

I think this should be MOS and RTT, they are both abbreviations, right?

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {

Not thrilled about having Attributes as a top level global that refers specifically to the VoiceInsights... how about CallSummaryAttributes?

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`+	Rtt       MetricsSummary    `json:"rtt"`+	Tags      map[string]string `json:"tags"`+	AudioOut  MetricsSummary    `json:"audio_out"`+	AudioIn   MetricsSummary    `json:"audio_in"`+}++type SdkEdgeProperties struct {+	Direction string `json:"direction"`+	Settings  struct {+		DSCP              bool     `json:"dscp"`+		ICERestartEnabled bool     `json:"ice_restart_enabled"`+		Edge              string   `json:"edge"`+		SelectedEdges     []string `json:"selected_edges"`+	} `json:"settings"`+}++type SdkEdgeEvents struct {+	Levels map[string]int `json:"levels"`+	Groups map[string]int `json:"groups"`+	Errors map[string]int `json:"errors"`+}++type MetricsSummary struct {+	Max float64 `json:"max"`+	Avg float64 `json:"avg"`+	Min float64 `json:"min"`+}++type CallProperties struct {+	Direction          Direction `json:"direction"`+	DisconnectedBy     string    `json:"disconnected_by"`+	PostDialDelay      int       `json:"pdd_ms"`+	LastSIPResponseNum int       `json:"last_sip_response_num"`+}++type ToFrom struct {

I'm not thrilled about having this type be global, since it's kind of a global name. But I don't think it's a big problem.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`+	Rtt       MetricsSummary    `json:"rtt"`+	Tags      map[string]string `json:"tags"`+	AudioOut  MetricsSummary    `json:"audio_out"`+	AudioIn   MetricsSummary    `json:"audio_in"`+}++type SdkEdgeProperties struct {+	Direction string `json:"direction"`+	Settings  struct {+		DSCP              bool     `json:"dscp"`+		ICERestartEnabled bool     `json:"ice_restart_enabled"`+		Edge              string   `json:"edge"`+		SelectedEdges     []string `json:"selected_edges"`+	} `json:"settings"`+}++type SdkEdgeEvents struct {+	Levels map[string]int `json:"levels"`+	Groups map[string]int `json:"groups"`+	Errors map[string]int `json:"errors"`+}++type MetricsSummary struct {+	Max float64 `json:"max"`+	Avg float64 `json:"avg"`+	Min float64 `json:"min"`+}++type CallProperties struct {+	Direction          Direction `json:"direction"`+	DisconnectedBy     string    `json:"disconnected_by"`+	PostDialDelay      int       `json:"pdd_ms"`+	LastSIPResponseNum int       `json:"last_sip_response_num"`

We should be consistent about SIP vs. Sip.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {

Could we put a link to API docs somewhere, either here, or on the structs?

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`+	Rtt       MetricsSummary    `json:"rtt"`+	Tags      map[string]string `json:"tags"`+	AudioOut  MetricsSummary    `json:"audio_out"`+	AudioIn   MetricsSummary    `json:"audio_in"`+}++type SdkEdgeProperties struct {

SDKEdgeProperties, please.

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const MetricsPathPart = "Metrics"++type CallMetricsService struct {+	callSid string+	client  *Client+}++type CallMetricsPage struct {+	Metrics []CallMetric `json:"metrics"`+	Meta    Meta         `json:"meta"`+}++type CallMetric struct {+	AccountSid  string       `json:"account_sid"`+	CallSid     string       `json:"call_sid"`+	CarrierEdge *EdgeMetrics `json:"carrier_edge,omitempty"`+	ClientEdge  *EdgeMetrics `json:"client_edge,omitempty"`+	Direction   string       `json:"direction"`+	Edge        string       `json:"edge"`+	SdkEdge     *EdgeMetrics `json:"sdk_edge,omitempty"`

Should be SDKEdge.

Also we haven't used omitempty anywhere else in the API... is there something about this that we should be using it for the first time ?

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

 var videoRecordingResponse = []byte(` } `) +var insightsCallSummaryResponse = []byte(`

Thank you for adding these!

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

 func NewTaskRouterClient(accountSid string, authToken string, httpClient *http.C 	return c } +func NewInsightsClient(accountSid string, authToken string, httpClient *http.Client) *Client {+	c := newNewClient(accountSid, authToken, InsightsBaseUrl, httpClient)+	c.APIVersion = InsightsVersion+	c.VoiceInsights = func(sid string) *VoiceInsightsService {

If we're going to assign this to callSid could we call it callSid here as well

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"net/url"+	"testing"+)++func TestGetCallEventsPage(t *testing.T) {+	t.Parallel()+	client, s := getServer(insightsCallEventsResponse)+	defer s.Close()

I meant to change the other tests, but for new ones, maybe we could do t.Cleanup(func() { s.Close() }) instead of defer() ?

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

+package twilio++import (+	"context"+	"fmt"+	"net/url"+)++const SummaryPathPart = "Summary"++type CallSummaryService struct {+	callSid string+	client  *Client+}++type CallSummary struct {+	AccountSid      string            `json:"account_sid"`+	Attributes      Attributes        `json:"attributes"`+	CallSid         string            `json:"call_sid"`+	CallState       Status            `json:"call_state"`+	CallType        string            `json:"call_type"`+	CarrierEdge     *Edge             `json:"carrier_edge,omitempty"`+	ClientEdge      *Edge             `json:"client_edge,omitempty"`+	ConnectDuration int               `json:"connect_duration"`+	Duration        int               `json:"duration"`+	EndTime         TwilioTime        `json:"end_time"`+	From            ToFrom            `json:"from"`+	ProcessingState string            `json:"processing_state"`+	Properties      CallProperties    `json:"properties"`+	SdkEdge         *SdkEdge          `json:"sdk_edge,omitempty"`+	SipEdge         *Edge             `json:"sip_edge,omitempty"`+	StartTime       TwilioTime        `json:"start_time"`+	Tags            map[string]string `json:"tags"`+	To              ToFrom            `json:"to"`+	URL             string            `json:"url"`+}++type Attributes struct {+	ConferenceParticipant bool `json:"conference_participant"`+}++type Edge struct {+	Metrics struct {+		Inbound  EdgeSummary `json:"inbound"`+		Outbound EdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties EdgeProperties `json:"properties"`+}++type EdgeSummary struct {+	Codec                 int            `json:"codec"`+	CodecName             string         `json:"codec_name"`+	PacketsReceived       int            `json:"packets_received"`+	PacketsSent           int            `json:"packets_sent"`+	PacketsLost           int            `json:"packets_lost"`+	PacketsLossPercentage float64        `json:"packets_loss_percentage"`+	Jitter                MetricsSummary `json:"jitter"`+	Latency               MetricsSummary `json:"latency"`+	PacketDelayVariation  map[string]int `json:"packet_delay_variation"`+}++type EdgeProperties struct {+	Direction           string `json:"direction"`+	MediaRegion         string `json:"media_region"`+	SignalingRegion     string `json:"signaling_region"`+	TwilioMediaIP       string `json:"twilio_media_ip"`+	TwilioSignalingIP   string `json:"twilio_signaling_ip"`+	ExternalMediaIP     string `json:"external_media_ip"`+	ExternalSignalingIP string `json:"external_signaling_ip"`+	SIPCallID           string `json:"sip_call_id"`+	UserAgent           string `json:"user_agent"`+	SelectedRegion      string `json:"selected_region"`+	Region              string `json:"region"`+	DisconnectedBy      string `json:"disconnected_by"`+	TrunkSID            string `json:"trunk_sid"`+}++type SdkEdge struct {+	Metrics struct {+		Inbound  SdkEdgeSummary `json:"inbound"`+		Outbound SdkEdgeSummary `json:"outbound"`+	} `json:"metrics"`+	Properties SdkEdgeProperties `json:"properties"`+	Events     SdkEdgeEvents     `json:"events"`+}++type SdkEdgeSummary struct {+	EdgeSummary+	Mos       MetricsSummary    `json:"mos"`+	Rtt       MetricsSummary    `json:"rtt"`+	Tags      map[string]string `json:"tags"`+	AudioOut  MetricsSummary    `json:"audio_out"`+	AudioIn   MetricsSummary    `json:"audio_in"`+}++type SdkEdgeProperties struct {+	Direction string `json:"direction"`+	Settings  struct {+		DSCP              bool     `json:"dscp"`+		ICERestartEnabled bool     `json:"ice_restart_enabled"`+		Edge              string   `json:"edge"`+		SelectedEdges     []string `json:"selected_edges"`+	} `json:"settings"`+}++type SdkEdgeEvents struct {+	Levels map[string]int `json:"levels"`+	Groups map[string]int `json:"groups"`+	Errors map[string]int `json:"errors"`+}++type MetricsSummary struct {+	Max float64 `json:"max"`+	Avg float64 `json:"avg"`+	Min float64 `json:"min"`+}++type CallProperties struct {+	Direction          Direction `json:"direction"`+	DisconnectedBy     string    `json:"disconnected_by"`+	PostDialDelay      int       `json:"pdd_ms"`

Can we keep the unit? Or convert to a time.Duration (the latter is more work, though, I don't know that it is necessary.)

yeoji

comment created time in 9 days

Pull request review commentkevinburke/twilio-go

Add Voice Insights API

 var videoRecordingResponse = []byte(` } `) +var insightsCallSummaryResponse = []byte(`+{+    "sdk_edge": {+        "metrics": {+            "inbound": {+                "audio_out": {+                    "max": 5611.0,+                    "avg": 89.2+                },+                "jitter": {+                    "max": 3.0,+                    "avg": 0.17+                },+                "packets_loss_percentage": 0.010012015,+                "mos": {+                    "max": 4.43,+                    "avg": 4.43,+                    "min": 4.33+                },+                "packets_received": 9987,+                "rtt": {+                    "max": 98.0,+                    "avg": 85.8,+                    "min": 80.0+                },+                "audio_in": {+                    "max": 11268.0,+                    "avg": 1881.28+                },+                "packets_lost": 1+            },+            "outbound": {+                "codec": 111,+                "packets_sent": 9997,+                "codec_name": "opus"+            }+        },+        "properties": {+            "direction": "outbound",+            "disconnected_by": "remote",+            "settings": {+                "dscp": true,+                "ice_restart_enabled": true+            }+        },+        "events": {+            "levels": {+                "INFO": 13,+                "DEBUG": 6+            },+            "groups": {+                "get_user_media": 1,+                "signaling_state": 3,+                "ice_gathering_state": 2,+                "connection": 4,+                "ice_connection_state": 1,+                "network_information": 8+            }+        }+    },+    "processing_state": "complete",+    "from": {+        "number_prefix": "1256",+        "caller": "+1256...",+        "connection": "voip",+        "carrier": "Twilio",+        "location": {+            "lat": 34.418243,+            "lon": -86.63888+        },+        "country_code": "US"+    },+    "tags": null,+    "url": "https://insights.twilio.com/v1/Voice/CA.../Summary",

Can you generate a random UUID instead of using dots? You can use https://www.uuidgenerator.net/version4 and strip the hyphens.

yeoji

comment created time in 9 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha bc580f944739388510263ee17b23dd5aadd40e11

Makefile: run differ on go fmt in CI This ensures that all code has been gofmt'd correctly.

view details

push time in 9 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha bc580f944739388510263ee17b23dd5aadd40e11

Makefile: run differ on go fmt in CI This ensures that all code has been gofmt'd correctly.

view details

push time in 9 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha c5a92dad51fb36b07b2a306a6f9eee6a359d9df9

Makefile: run differ on go fmt all

view details

push time in 9 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha b50566a9b3eac5837c07f2790056e596c6d27e9c

Makefile: run differ on go fmt all

view details

push time in 9 days

push eventkevinburke/twilio-go

Kevin Burke

commit sha c3a3e7255c87419b81d1996748abe71e4cfb2d78

Makefile: run differ on go fmt all

view details

push time in 9 days

create barnchkevinburke/twilio-go

branch : differ-go-fmt

created branch time in 9 days

startedHopkinsIDD/ncov_incubation

started time in 10 days

pull request commentrbenv/ruby-build

bin/ruby-build: support DESTDIR setting

The 2.7.1 issue should be fixed now.

kevinburkemeter

comment created time in 10 days

push eventkevinburke/goose

Kevin Burke

commit sha 1397e80c4202e61de78bf7a6352299f18fc1ec19

Gopkg.lock,vendor: latest dependency versions

view details

push time in 13 days

issue closed99designs/aws-vault

Can't vendor this repo

I am trying to vendor the aws-vault command. As I understand it it's impossible to vendor the v5.x line of Git tags.

If I add

	github.com/99designs/aws-vault v5.4.4

to my go.mod file and then run go mod vendor, I get this error:

require github.com/99designs/aws-vault: version "v5.4.4" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v5

This error message is rather unhelpfully explained here: https://github.com/golang/go/issues/35732

The error message is correct. See https://golang.org/cmd/go/#hdr-Module_compatibility_and_semantic_versioning.

The v1.9.1-0.[…] version string is a pseudo-version generated from the requested commit.

From the perspective of the go command, this is working as designed.

So it seems like you're supposed to put the source code in a folder labeled "v5", I think? I don't really know how this is supposed to work, but I'd like to be able to vendor the project at the latest version...

closed time in 16 days

kevinburke

issue comment99designs/aws-vault

Can't vendor this repo

Never mind, got it sorted... needed this

	github.com/99designs/aws-vault/v6 v6.0.0-beta5

and then also update code references to "aws-vault/v6".

kevinburke

comment created time in 16 days

issue opened99designs/aws-vault

Can't vendor this repo

I am trying to vendor the aws-vault command. As I understand it it's impossible to vendor the v5.x line of Git tags.

If I add

	github.com/99designs/aws-vault v5.4.4

to my go.mod file and then run go mod vendor, I get this error:

require github.com/99designs/aws-vault: version "v5.4.4" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v5

This error message is rather unhelpfully explained here: https://github.com/golang/go/issues/35732

The error message is correct. See https://golang.org/cmd/go/#hdr-Module_compatibility_and_semantic_versioning.

The v1.9.1-0.[…] version string is a pseudo-version generated from the requested commit.

From the perspective of the go command, this is working as designed.

So it seems like you're supposed to put the source code in a folder labeled "v5", I think? I don't really know how this is supposed to work, but I'd like to be able to vendor the project at the latest version...

created time in 16 days

issue commentgolang/go

os/user: LookupGroup does not identify all cases of UnknownGroupError

Odd... I copied the contents of os/user to a third party package so I could add print statements to it, and when I do that, it compiles and runs successfully.

$ docker run --tty -v $(PWD)/tmp:/go --interactive meterup/ubuntu-golang:latest /usr/local/go/bin/go build -ldflags '-extldflags "-static"' -o /go/test/test-program ./
# _/go
/tmp/go-link-139166518/000002.o: In function `mygetgrouplist':
/go/user2/getgrouplist_unix.go:16: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-139166518/000001.o: In function `mygetgrgid_r':
/go/user2/cgo_lookup_unix.go:38: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-139166518/000001.o: In function `mygetgrnam_r':
/go/user2/cgo_lookup_unix.go:43: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-139166518/000001.o: In function `mygetpwnam_r':
/go/user2/cgo_lookup_unix.go:33: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-139166518/000001.o: In function `mygetpwuid_r':
/go/user2/cgo_lookup_unix.go:28: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
# chroot /go/test /test-program
calling lookup Group using mygetgrnam_r
lookup err: <nil>
"thisdoesnotexist"
successful error handling
anonymouse64

comment created time in 17 days

issue commentgolang/go

os/user: LookupGroup does not identify all cases of UnknownGroupError

I'm having trouble reproducing. I am running the same program you are:

package main

import (
	"fmt"
	"os/user"
)

func main() {
	_, err := user.LookupGroup("thisdoesnotexist")
	fmt.Printf("%#v\n", err)
	switch err.(type) {
	case user.UnknownGroupError:
		fmt.Println("successful error handling")
	default:
		fmt.Printf("error, not matchable (type %T), %v\n", err, err)
	}
}

in tmp/test.go, then compiling the Go binary in a Linux container:

$ docker run --tty -v $(PWD)/tmp:/go --interactive meterup/ubuntu-golang:latest /usr/local/go/bin/go build -ldflags '-extldflags "-static"' -o /go/test/test-program ./

then sharing the compiled binary into a Docker container:

$ docker run --tty -v $(PWD)/tmp:/go --interactive meterup/ubuntu-golang:latest /bin/bash --login

running ldd to find remaining links in the binary:

$ ldd /go/test/test-program
	linux-vdso.so.1 (0x00007ffe801af000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007feed8a62000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007feed8671000)
	/lib64/ld-linux-x86-64.so.2 (0x00007feed8c81000)

copying these files into the chroot:

# mkdir /go/test/lib/x86_64-linux-gnu 
# cp -r --dereference /lib/x86_64-linux-gnu/* /go/test/lib/x86_64-linux-gnu

(and similar for the other files)

then, finally, running the program:

chroot /go/test /test-program
&errors.errorString{s:"user: lookup groupname thisdoesnotexist: no such file or directory"}
error, not matchable (type *errors.errorString), user: lookup groupname thisdoesnotexist: no such file or directory

Running with strace (you have to install it into that container):

[pid   456] openat(AT_FDCWD, "/etc/group", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   456] futex(0x55f6b8, FUTEX_WAKE_PRIVATE, 1) = 1
[pid   457] <... futex resumed> )       = 0
[pid   457] clock_gettime(CLOCK_MONOTONIC, {tv_sec=2321, tv_nsec=911496659}) = 0
[pid   457] clock_gettime(CLOCK_MONOTONIC, {tv_sec=2321, tv_nsec=911587159}) = 0
[pid   456] write(1, "&errors.errorString{s:\"user: loo"..., 92 <unfinished ...>
[pid   457] futex(0xc00003e948, FUTEX_WAKE_PRIVATE, 1&errors.errorString{s:"user: lookup groupname thisdoesnotexist: no such file or directory"}

So it looks like my program is trying to read /etc/group and failing (a failure I would expect in the chroot). My understanding is /etc/group parse is fallback logic if cgo is not enabled, though I am compiling on Linux with a linux target, so cgo should be enabled... I don't know strace well enough to determine whether getgrnam_r is the one that is trying and failing to read /etc/group, ie. cgo is enabled but it's still failing to read the file, though I am concerned that I am getting different output than you got.

anonymouse64

comment created time in 18 days

issue commentgolang/go

os/user: LookupGroup does not identify all cases of UnknownGroupError

Interesting... I'll try to take a look later this week. I don't think this is important enough to get through the code freeze so we'd be targeting 1.15.1 or 1.16 (another way of saying that the fix will not show up in a public release for a while).

anonymouse64

comment created time in 21 days

issue commentmattn/goreman

Cut v1.0.0?

I don't think it's likely to change much, seems fine to me.

drnic

comment created time in 23 days

issue commentkevinburke/twilio-go

Question about exporting Client struct properties

Hey! Yes... I think the idea is if you wanted to only interact with the Notify API, you could build a client just for that specific resource and avoid the memory usage of the everything client.

Sorry about that. Can you describe what happened a little more, or paste a code snippet?

I suppose I could add a circular reference - Notify points to itself - but I'm not super happy with that idea either.

chartpath

comment created time in a month

push eventkevinburke/twilio-go

Kevin Burke

commit sha ff84c3703a294e016b9c3e3186f18db30589e089

add more fields to Conference struct Fixes #60.

view details

push time in a month

issue closedkevinburke/twilio-go

Expand Conference struct

Hi,

I need more fields from the Conference struct to unmarshal a more complete json.

Current struct

type Conference struct {
	Sid string `json:"sid"`
	// Call status, StatusInProgress or StatusCompleted
	Status       Status `json:"status"`
	FriendlyName string `json:"friendly_name"`
	// The conference region, probably "us1"
	Region      string     `json:"region"`
	DateCreated TwilioTime `json:"date_created"`
	AccountSid  string     `json:"account_sid"`
	APIVersion  string     `json:"api_version"`
	DateUpdated TwilioTime `json:"date_updated"`
	URI         string     `json:"uri"`
}

Desired struct

type Conference struct {
	Sid string `json:"sid"`
	// Call status, StatusInProgress or StatusCompleted
	Status       Status `json:"status"`
	FriendlyName string `json:"friendly_name"`
	// The conference region, probably "us1"
	Region      string     `json:"region"`
	DateCreated TwilioTime `json:"date_created"`
	AccountSid  string     `json:"account_sid"`
	APIVersion  string     `json:"api_version"`
	DateUpdated TwilioTime `json:"date_updated"`
	URI         string     `json:"uri"`
        SubresourceUris SubresourceUris `json:"subresource_uris"`
}

type SubresourceUris struct {
	Participants string `json:"participants"`
	Recordings   string `json:"recordings"`
}

closed time in a month

zmei95

push eventkevinburke/goose

Kevin Burke

commit sha ffc9b821d29a1c94d45772e9c1c8a6ff238a0253

vendor: latest dependency versions

view details

push time in a month

push eventkevinburke/ira-money

Kevin Burke

commit sha 24159e2c042ad9f09676253ed1cded4f33b9f861

update code to make sense

view details

Kevin Burke

commit sha 171c6979947d0181aeafdaa474e7343dda990618

vendor deps and add price fetcher

view details

Kevin Burke

commit sha 348e7f8676d4a235681fa7079df5d40625571507

add better error handling and note csv mode

view details

push time in a month

push eventkevinburke/twilio-go

Kevin Burke

commit sha 67b0a1ea51ac79fbe0f212ff9dd0013ee2977969

all: fix lint errors

view details

Kevin Burke

commit sha ac4e42b98b94bc2395d0ac67bcbbb8bc257f9ac1

.github: run the linter when running Github tests

view details

push time in a month

push eventkevinburke/twilio-go

Kelmer Perez

commit sha c9619868c55759ed11c7a2cfeae1297704aa5ea3

token: add Programmable Chat grant type

view details

Kevin Burke

commit sha 50f1e7df1b0ed6f6c06802d97cc6d6daaf8af73c

calls: ordering is now by StartTime Update the tests and the code to match the new ordering. Tests now require Go 1.14 to run (I think I am the only one who can run all of the tests).

view details

Kevin Burke

commit sha 3c7c0d6b31de45d9f1333f31d95d4dea66e95ca4

2.3

view details

Kevin Burke

commit sha 32862522b76303a242b84ffd6bdc536894567a14

CHANGELOG: add credits in 2.2/2.3 release notes

view details

Kevin Burke

commit sha 67b0a1ea51ac79fbe0f212ff9dd0013ee2977969

all: fix lint errors

view details

Kevin Burke

commit sha ac4e42b98b94bc2395d0ac67bcbbb8bc257f9ac1

.github: run the linter when running Github tests

view details

push time in a month

issue commentkevinburke/2013

does this repo have the latest source code?

I've just moved the HTML files into the "drafts" folder.

maryamklabib

comment created time in 2 months

push eventkevinburke/2013

Kevin Burke

commit sha 9a0e89ea85c95d9b2286821934eeb3c2efd5c2c9

all: move *.html files into "drafts" See #1, some confusion arose from the fact that these were also in the same directory as the .php files.

view details

push time in 2 months

issue commentkevinburke/2013

does this repo have the latest source code?

Ohhh... I figured it out. "index.html" was my static file I used for designing and is the reason that it's out of date. If you actually load it as a Wordpress theme - put in wp-content/themes - it should load index.php, which has the "new" theme.

I don't really think there's a way to view it outside of that context - otherwise you might want to scrape the HTML off of the live site and use that as the base. Really sorry about that!

maryamklabib

comment created time in 2 months

push eventkevinburke/ynab-go

Kevin Burke

commit sha 62884eacc2fc81ca272498e016e1755f275c5636

ynab-largest-inputs-outputs: improve formatting

view details

push time in 2 months

push eventkevinburke/goose

Kevin Burke

commit sha a63dc1759648a3a27c756e0f924c02a3ae752fa4

Gopkg.lock: use latest lib/pq dependency

view details

push time in 2 months

push eventkevinburke/twilio-go

Kevin Burke

commit sha 32862522b76303a242b84ffd6bdc536894567a14

CHANGELOG: add credits in 2.2/2.3 release notes

view details

push time in 2 months

startedBayAreaMetro/bayarea_urbansim

started time in 2 months

issue openedkevinburke/twilio-go

Twilio changed the sort order for calls

The tests broke because the sort order changed when retrieving calls from the API. Note that calls (at least, a subset of calls, on my account, I did not test all of them) are now returned in StartTime order, not DateCreated order.

The 2.3 release is updated to use StartTime as the key for ordering.

created time in 2 months

created tagkevinburke/twilio-go

tag2.3

Twilio Go library

created time in 2 months

push eventkevinburke/twilio-go

Kevin Burke

commit sha 3c7c0d6b31de45d9f1333f31d95d4dea66e95ca4

2.3

view details

push time in 2 months

push eventkevinburke/twilio-go

Kevin Burke

commit sha 50f1e7df1b0ed6f6c06802d97cc6d6daaf8af73c

calls: ordering is now by StartTime Update the tests and the code to match the new ordering. Tests now require Go 1.14 to run (I think I am the only one who can run all of the tests).

view details

push time in 2 months

push eventkevinburke/twilio-go

Kevin Burke

commit sha 50f1e7df1b0ed6f6c06802d97cc6d6daaf8af73c

calls: ordering is now by StartTime Update the tests and the code to match the new ordering. Tests now require Go 1.14 to run (I think I am the only one who can run all of the tests).

view details

push time in 2 months

create barnchkevinburke/twilio-go

branch : call-time-filtering

created branch time in 2 months

push eventkevinburke/differ

Kevin Burke

commit sha b9105feafc75eecdc508b271f1d985e6d66ab149

travis.yml: add Go 1.14

view details

push time in 2 months

push eventkevinburke/twilio-go

Kelmer Perez

commit sha c9619868c55759ed11c7a2cfeae1297704aa5ea3

token: add Programmable Chat grant type

view details

push time in 2 months

create barnchkevinburke/twilio-go

branch : kelmerp-add-programmable-chat

created branch time in 2 months

issue commentkevinburke/2013

does this repo have the latest source code?

Eek, okay. Thanks For following up. Let me take a look later today, I am away from my computer at the moment.

On Sat, Jun 13, 2020 at 16:36 Maryam Labib notifications@github.com wrote:

It looks like this: [image: Screen Shot 2020-06-13 at 4 31 16 PM] https://user-images.githubusercontent.com/4147717/84581197-6f75a480-ad93-11ea-8828-804dc2b70e24.png When it should look like this: [image: Screen Shot 2020-06-13 at 4 31 27 PM] https://user-images.githubusercontent.com/4147717/84581194-6d134a80-ad93-11ea-932b-cb56679856f5.png

Seems like I was missing the WordPress part. Do I need to pay for WordPress in order to do this?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/kevinburke/2013/issues/1#issuecomment-643693186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZEI2DBRKAHNAAX6G4DD3RWQEOXANCNFSM4N47NWNQ .

-- Kevin Burke phone: 925-271-7005 | kevin.burke.dev

maryamklabib

comment created time in 2 months

issue commentkevinburke/2013

does this repo have the latest source code?

Hey! It should... how different does it look? Did you go to the "Themes" page in the admin and switch from "Twenty Twenty" (or whatever the default is) to this theme?

maryamklabib

comment created time in 2 months

push eventkevinburke/talks

Kevin Burke

commit sha cfa0edfeaa89dbfec14e75e6d766b615ac906501

update Gophercon caching description

view details

push time in 2 months

issue commentgithub-release/github-release

error: could not find the release corresponding to tag v1.3

I think this is an issue with the Github UI. It shows Git tags on the "releases" page, but you need to explicitly click on 'Draft a release' and associate it with the tag.

Try running:

github-release release --tag v1.3 ...

before you run:

github-release upload ...
QingYanL

comment created time in 2 months

Pull request review commentgo-bindata/go-bindata

Make generated file be clean by go fmt

 func Translate(c *Config) error { 	defer bfd.Flush()  	// Write the header. This makes e.g. Github ignore diffs in generated files.-	if _, err = fmt.Fprintf(bfd, "// Code generated by go-bindata. (@generated) DO NOT EDIT.\n\n //Package %s generated by go-bindata.", c.Package); err != nil {+	if _, err = fmt.Fprintf(bfd, "// Code generated by go-bindata. (@generated) DO NOT EDIT.\n\n//Package %s generated by go-bindata.", c.Package); err != nil {

If you're gonna persist with this, a better approach is going to be to call format.Source on the generated byte output, since the output of that is guaranteed to be correct.

Alternatively, you'll want to run go fmt ./... and check whether it generates a Git diff. See github.com/kevinburke/differ for a tool that can help enforce this rule.

roopakv

comment created time in 2 months

pull request commentgo-bindata/go-bindata

Make generated file be clean by go fmt

Fyi, these are fixed in my fork, which runs format.Source on the raw bytes before writing them to disk. https://github.com/kevinburke/go-bindata.

roopakv

comment created time in 2 months

push eventgithub-release/github-release

Kevin Burke

commit sha a2845f06c59c7a3ff01a7c1971f17ef6ca060451

cmd: use github.Client for release command Also add a note about why `--auth-user` is unnecessary/misleading for the release command. Fixes #106.

view details

push time in 2 months

issue closedgithub-release/github-release

`release` verb does not have `--auth-user` option

I'm running github-release v0.8.1. I'm trying to authenticate using the continuous integration user xxxx-ci, trying to create a release for myOrg/automation_sandbox. Here's the command line:

C:\github-release\github-release.exe release --security-token xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx --auth-user xxxx-ci --user myOrg --repo automation_sandbox --tag build-8.0.0.17

Here's the error that I'm getting:

Error: Invalid trailing arguments: [--auth-user xxxx-ci --user myOrg --repo automation_sandbox --tag build-8.0.0.17]

... with the relevant usage section:

Usage: github-release.exe [global options] <verb> [verb options]
...
Verbs:
...
    release:
        -s, --security-token Github token (required if $GITHUB_TOKEN not set)
        -u, --user           Github repo user or organisation (required if $GITHUB_USERnot set)
        -r, --repo           Github repo (required if $GITHUB_REPO not set)
        -t, --tag            Git tag to create a release from (*)
        -n, --name           Name of the release (defaults to tag)
        -d, --description    Release description, use - for reading a description from stdin (defaults to tag)
        -c, --target         Commit SHA or branch to create release of (defaults to the repository default branch)
            --draft          The release is a draft
        -p, --pre-release    The release is a pre-release

The release verb does not seem to accept --auth-user as an option, which means that the continuous integraton user xxxx-ci can't create a release under the user myOrg.

closed time in 2 months

JAVS-CI

push eventgithub-release/github-release

Kevin Burke

commit sha a2845f06c59c7a3ff01a7c1971f17ef6ca060451

cmd: use github.Client for release command Also add a note about why `--auth-user` is unnecessary/misleading for the release command. Fixes #106.

view details

push time in 2 months

push eventgithub-release/github-release

Kevin Burke

commit sha fdf470cf40ad5c4f7ef6dfe2b952b9bb89da7c6f

cmd: use github.Client for release command Also add a note about why `--auth-user` is unnecessary/misleading for the release command. Fixes #106.

view details

push time in 2 months

create barnchgithub-release/github-release

branch : add-release-auth-user

created branch time in 2 months

created tagkevinburke/github-release

tagrelease-testing-4

Commandline app to create and edit releases on Github (and upload artifacts)

created time in 2 months

release kevinburke/github-release

release-testing-4

released time in 2 months

created tagkevinburke/github-release

tagrelease-testing-3

Commandline app to create and edit releases on Github (and upload artifacts)

created time in 2 months

release kevinburke/github-release

release-testing-3

released time in 2 months

created tagkevinburke/github-release

tagrelease-testing-2

Commandline app to create and edit releases on Github (and upload artifacts)

created time in 2 months

release kevinburke/github-release

release-testing-2

released time in 2 months

issue commentgo-bindata/go-bindata

zsh: command not found: go-bindata

“go get” any other popular Go project in the same manner.

I’d also recommend the materials on the Go website for setting up your $PATH variable and getting started.

On Sun, May 24, 2020 at 12:37 Anh Dung Le notifications@github.com wrote:

@kevinburke https://github.com/kevinburke Thanks for your reply. What other Go binary command can I test with? I am beginning with Go.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/go-bindata/go-bindata/issues/60#issuecomment-633284288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZEI6QV7ILMMB3TDDBW23RTFZPJANCNFSM4NJAABUA .

-- Kevin Burke phone: 925-271-7005 | kevin.burke.dev

anhdungle93

comment created time in 3 months

issue commentgo-bindata/go-bindata

zsh: command not found: go-bindata

Do you get the same results if you try the same command with any other Go binary? My guess would be Go is installing the compiled binary to a location that is not on your $PATH.

anhdungle93

comment created time in 3 months

issue commentkevinburke/twilio-go

Support API Key Auth

I understand what's going on now but the change is going to be slightly more involved and as a result it's gonna take me a little bit of time.

threez

comment created time in 3 months

push eventkevinburke/twilio-go

Kevin Burke

commit sha 95fde50846da87272852053d5810560a4121707b

.github: run the linter when running Github tests

view details

push time in 3 months

create barnchkevinburke/twilio-go

branch : fix-tests

created branch time in 3 months

issue commentkevinburke/twilio-go

Support API Key Auth

Thanks, this is a new feature, I tried to make heads or tails of it and can't figure out how it's integrated with Twilio's existing tools.

The trick is to use the API key for authentication but keep the account SID in the URL. I want to see how the current client libraries manage this before adding support for it and I can't figure out how they currently do it.

threez

comment created time in 3 months

release kevinburke/go-bindata

v3.21.0

released time in 3 months

created tagkevinburke/go-bindata

tagv3.21.0

A small utility which generates Go code from any file. Useful for embedding binary data in a Go program.

created time in 3 months

push eventkevinburke/go-bindata

Kevin Burke

commit sha a606d617e1d1546a2342de6fc4ed95c78e171d68

v3.21.0

view details

push time in 3 months

push eventkevinburke/go-bindata

Kevin Burke

commit sha 226e947fff6b6e9ecdbee5d9d8af27a72e7e3f39

all: replace "Debug" with "AssetDebug" Josh Bleecher Snyder made the point that if this file is compiled in with other files in a package, "Debug" is a very generic word. "AssetDebug" is less likely to have conflicts with existing packages. This is a breaking change, which I'm not happy about, but it's a new one, so hopefully very few people are relying on the behavior that was recently added. Add a "CHANGELOG" to helpfully make this change more clear to people.

view details

push time in 3 months

push eventkevinburke/goose

Kevin Burke

commit sha 6e00c90692311b35a6769654c8c8f337801f965c

vendor: use latest go-mysql-driver A recent blog post by Github makes me want to ensure we have the latest version of the driver.

view details

push time in 3 months

issue openeddeniszholob/factorio-cheat-sheet

website currently 404's

If I visit https://factoriocheatsheet.com right now, I get:

404

There isn't a GitHub Pages site here.

If you're trying to publish one, read the full documentation to learn how to set up GitHub Pages for your repository, organization, or user account.

created time in 3 months

issue openedkevinburke/go-bindata

[please vote]: Do you put other Go source code in the pkg generated by go-bindata?

Do you embed the go-bindata program into a standalone package, or do you embed it with other Go source code?

Respond with thumbs up emoji if you embed into a standalone package. Thumbs down if you put other Go source files in the compiled package.

This will help inform library design. Thanks!

created time in 3 months

issue commentkevinburke/go-bindata

expose whether build in debug mode

Ohhh.. you don’t use this as a standalone package you embed it into a package that has other files along with it.

Let me think about it.

On Mon, May 18, 2020 at 09:56 Kevin Burke kevin@burke.dev wrote:

It would be guarded by the package import path right? I don’t think it’s possible to create arbitrary Upper case variable names right now by getting creative with file names... maybe I’m not understanding

On Mon, May 18, 2020 at 09:12 Josh Bleecher Snyder < notifications@github.com> wrote:

Thanks for the fix! I was going to send a PR but delighted you beat me to it.

One thought: should it be called AssetDebug or the like? Debug might conflict with existing identifiers in peoples packages.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/kevinburke/go-bindata/issues/31#issuecomment-630286515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZEI6FTFUXHLX7FEUR5N3RSFM5HANCNFSM4NDOJZGA .

-- Kevin Burke phone: 925-271-7005 | kevin.burke.dev

-- Kevin Burke phone: 925-271-7005 | kevin.burke.dev

josharian

comment created time in 3 months

issue commentkevinburke/go-bindata

expose whether build in debug mode

It would be guarded by the package import path right? I don’t think it’s possible to create arbitrary Upper case variable names right now by getting creative with file names... maybe I’m not understanding

On Mon, May 18, 2020 at 09:12 Josh Bleecher Snyder notifications@github.com wrote:

Thanks for the fix! I was going to send a PR but delighted you beat me to it.

One thought: should it be called AssetDebug or the like? Debug might conflict with existing identifiers in peoples packages.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/kevinburke/go-bindata/issues/31#issuecomment-630286515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZEI6FTFUXHLX7FEUR5N3RSFM5HANCNFSM4NDOJZGA .

-- Kevin Burke phone: 925-271-7005 | kevin.burke.dev

josharian

comment created time in 3 months

push eventkevinburke/go-bindata

Kevin Burke

commit sha b8002fcc482e575fafb64e501152a11be0a0e508

v3.20.0 Add a "Debug" constant to generated asset files.

view details

push time in 3 months

push eventkevinburke/go-bindata

Kevin Burke

commit sha 9c3a92130a0c6ed1b28f1bcc3c2d2bdf39c57a4c

all: report whether built with the debug flag enabled Fixes #31.

view details

push time in 3 months

more