profile
viewpoint
Yusuke Sakurai keroxp @loilo-inc Fujisawa, Japan https://keroxp.me/ Software Engineer in Japan

denolib/deno-redis 227

🦕 Redis client for Deno 🍕

keroxp/deno-couchdb 64

🦕CouchDB client for Deno built top of fetch 🛋

keroxp/deno-ws 23

[Deprecated] Now deno-ws are part of https://github.com/denoland/deno_std, use it.

keroxp/denode 23

Deno polyfill for Node.js

keroxp/deno-streams 21

WHATWG streams API for deno

keroxp/deno-imaging 16

Imaging utility for Deno

keroxp/deno-request 10

[Deprecated] integrated into https://github.com/keroxp/servest

keroxp/BullBones 6

Research on computer-supported sketch drawing systems.

keroxp/deno-fetch 3

WHATWG fetch for deno, based on dial and WHATWG streams

keroxp/blender-mechanim-rig 2

UnityのMechanimに対応した、最小構成のblenderリグファイルです

push eventkeroxp/servest

Yusuke Sakurai

commit sha e321633a1b0c15ce6351830089916cbd676dfe7c

bump: deno@v1.2.2

view details

push time in 8 days

push eventkeroxp/dink

Yusuke Sakurai

commit sha ccee32c3b49414703d944254a159f3a1b866fcf6

bump: deno@v1.2.2 (#32)

view details

push time in 8 days

PR merged keroxp/dink

bump: deno@v1.2.2
+18 -18

0 comment

18 changed files

keroxp

pr closed time in 8 days

delete branch keroxp/dink

delete branch : bump-deno@v1.2.2

delete time in 8 days

PR opened keroxp/dink

bump: deno@v1.2.2
+18 -18

0 comment

18 changed files

pr created time in 8 days

create barnchkeroxp/dink

branch : bump-deno@v1.2.2

created branch time in 8 days

push eventkeroxp/servest

Yusuke Sakurai

commit sha aff6778d5bde48239897221dd3599ee48950b608

Update Dockerfile

view details

push time in 23 days

push eventkeroxp/servest

Yusuke Sakurai

commit sha 966ce6cf4ffdc45f8337cd26df4d538a0bebd38d

fix: Makefile

view details

push time in 24 days

created tagkeroxp/servest

tagv1.1.1

🌾A progressive http server for Deno🌾

created time in 24 days

release keroxp/servest

v1.1.1

released time in 24 days

pull request commentkeroxp/servest

std@v0.58.0 → std@0.61.0 for Deno 1.2.0

Thanks for PR. Deno was bumped at #135

taisukef

comment created time in 24 days

PR closed keroxp/servest

std@v0.58.0 → std@0.61.0 for Deno 1.2.0 CI start
+19 -19

1 comment

19 changed files

taisukef

pr closed time in 24 days

push eventkeroxp/servest

Yusuke Sakurai

commit sha bb7c152fab28b96deb77b4c876a9bc358de301d6

bump: deno@v1.2.0 (#135)

view details

push time in 24 days

delete branch keroxp/servest

delete branch : bump-deno@v1.2.0

delete time in 24 days

PR merged keroxp/servest

bump: deno@v1.2.0
+23 -23

0 comment

23 changed files

keroxp

pr closed time in 24 days

PR opened keroxp/servest

bump: deno@v1.2.0
+23 -23

0 comment

23 changed files

pr created time in 24 days

push eventkeroxp/servest

Yusuke Sakurai

commit sha b305968bfe90198bba80a7ca251f2710f065e7cb

Update _version.ts

view details

push time in 24 days

create barnchkeroxp/servest

branch : bump-deno@v1.2.0

created branch time in 24 days

push eventkeroxp/dink

uki00a

commit sha 5646af06cc800025c4331fdaee507c7d7f0de651

bump: deno@v1.2.0 (#31)

view details

push time in 24 days

PR merged keroxp/dink

bump: deno@v1.2.0
+12 -12

1 comment

11 changed files

uki00a

pr closed time in 24 days

pull request commentkeroxp/dink

bump: deno@v1.2.0

@uki00a Thanks!

uki00a

comment created time in 24 days

pull request commentmozilla/pdf.js

fix: added fallback when no data passed to message handler

@Snuffleupagus Yes, we use minified pdf worker, and I don't think the case is minifying. I think the case is that message event without data is sent from worker by some reason. It is obvious that error occurred at comparison between data.targetName and this.sourceName (Source mapping is working correctly).

keroxp

comment created time in a month

pull request commentmozilla/pdf.js

fix: added fallback when no data passed to message handler

@Snuffleupagus Year I'd like believe this never happen. But actually this occurred in our project few times (not many). I couldn't reproduce it and determine what is the case. It might begin to occur from pdfjs-dist@2.4.456

Here is actual bug report from bugsnag (bug tracker).

Screenshot from Gyazo

Most errors occurred on Chrome on android.

Most likely the actual problem is elsewhere in the code-base

This code seems to not be available from public api and we don't use it directly. Do you have any idea about the case? Thanks.

keroxp

comment created time in a month

PR opened mozilla/pdf.js

fix: added fallback when no data passed to message handler

Sometimes event.data seems to get null.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchloilo-inc/pdf.js

branch : fix-null-data

created branch time in a month

created tagkeroxp/deno-couchdb

tagv0.4.1

🦕CouchDB client for Deno built top of fetch 🛋

created time in a month

release keroxp/deno-couchdb

v0.4.1

released time in a month

push eventkeroxp/deno-couchdb

₳ЯṬ

commit sha 0eb26fc6e8bffbae9f4ff5603a9a2ca901a683b9

fix: switching atob for btoa (#30)

view details

push time in a month

PR merged keroxp/deno-couchdb

switching atob for btoa

Hello sir thanks for starting porting couchdb to deno but I think there is a slight mistaking around adding credentials it should be btoa instead of atob the core atob function includes a regexp if there is something different than 0-9 a-z then the ":" will return the following error

throw new DOMException(
      "The string to be decoded is not correctly encoded",
      "DataDecodeError"
    );

by the way i have already done that process client sided and its slightly different

const token = btoa(`${user}:${password}`, 'binary').toString('base64');

I have made a fork, made the change, import my fork in my deno script and tested and it works

+1 -1

1 comment

1 changed file

chisNaN

pr closed time in a month

pull request commentkeroxp/deno-couchdb

switching atob for btoa

LGTM, thanks!

chisNaN

comment created time in a month

issue commentevanw/esbuild

Source map for minified file not working in Safari

@evanw Thanks!

keroxp

comment created time in a month

issue commentevanw/esbuild

Source map for minified file not working in Safari

I realized that rest stack traces are not correctly mapped (in all browsers). I think source maps for minified file are (partially) incorrect, isn't it?

keroxp

comment created time in a month

issue openedevanw/esbuild

Source map for minified file not working in Safari

Source mapping for minified file may not be working in Safari.

  • esbuild: 0.5.16
  • typescript: 3.9.5

index.ts

import React from "react"
import { render } from "react-dom"
import { log } from  "./other"
const str = "esbuild"
log(str)
render(React.createElement("div"), document.body)

other.ts

export function log(a: any) {
  console.trace(a);
}

When building bare and minified version of index.ts, source mapping for minified version not working in Safari. Those screenshots show how mapping is wrong (Above is bare, below is minified version).

Correct line number is other.ts:2.

Safari スクリーンショット 2020-07-01 10 42 51

Chrome スクリーンショット 2020-07-01 10 42 58

I don't understand what happened. Have any idea? 🤔

created time in a month

issue commentkeroxp/servest

renderToString is not typed, gives squiggles in VSCode

@Ciantic Yeah it is issue of deno-vscode. So no way to fix it by us. Would you close the issue?

Ciantic

comment created time in 2 months

issue commentkeroxp/servest

renderToString is not typed, gives squiggles in VSCode

@Ciantic Hmm... latest react-dom-server may have breaking change? Could you try to remove deno-types annotation for react-domserver and check it works?

Ciantic

comment created time in 2 months

push eventkeroxp/servest

Yusuke Sakurai

commit sha 8f3ba8387ea807d0b07e72a55654cede52a02b09

bump: deno@v1.1.1 (#132)

view details

push time in 2 months

delete branch keroxp/servest

delete branch : bump-deno@v1.1.1

delete time in 2 months

PR merged keroxp/servest

bump: deno@v1.1.1
+22 -22

0 comment

22 changed files

keroxp

pr closed time in 2 months

PR opened keroxp/servest

bump: deno@v1.1.1
+22 -22

0 comment

22 changed files

pr created time in 2 months

create barnchkeroxp/servest

branch : bump-deno@v1.1.1

created branch time in 2 months

push eventkeroxp/servest

Dmitry Romanenko

commit sha 0495ff23b40fbccfe88f36d9a7de1130cd397ed5

fix: Fix typo in README (#131)

view details

push time in 2 months

PR merged keroxp/servest

Fix typo in README
+1 -1

1 comment

1 changed file

dimon222

pr closed time in 2 months

pull request commentkeroxp/servest

Fix typo in README

Thanks!

dimon222

comment created time in 2 months

pull request commentkeroxp/servest

fix: Avoid setting content-length on event-stream

@Monchi Good news.

Should BlockingBuffer be provided by servest, or not?

Not. That utility is out of scope. std may accept that.

Monchi

comment created time in 2 months

issue commentdenolib/deno-redis

Port to org and core-maintainer switch

Done. Now deno-redis is part of denolib!

keroxp

comment created time in 2 months

pull request commentkeroxp/servest

fix: Avoid setting content-length on event-stream

@Monchi Hmm... Buffer seems to not be suitable for blocked stream. You should implement dedicated Deno.Reader for SSE. Anyway I think it's possible to send SSE events without modifying writeResponse

Monchi

comment created time in 2 months

pull request commentkeroxp/servest

fix: Avoid setting content-length on event-stream

Different from WebSocket, SSE's body stream must be valid http response. So I recommend you to use body to send SSE to client, instead of using req.bufWriter.

const app: App = createApp();
app.handle("/", async (req) => {
  const body = new Deno.Buffer();
  await req.respond({
    status: 200,
    headers: new Headers({
      Connection: "keep-alive",
      "Cache-Control": "no-cache",
      "Content-Type": "text/event-stream; charset=utf-8",
      "Transfer-Encoding": "chunkd"     
    }),
    body,
  });

  setInterval(() => {
    const encoded = encode("data: exampleexampleexample\n\n");
    await body.write(encoded)
  }, 1000);
});

Does it work?

Monchi

comment created time in 2 months

issue openedkeroxp/deno-redis

Port to org and core-maintainer switch

I'm sorry for delayed response for issues/PR. I'm busy for other work and no times for see them now. I'm going to delegate core-maintainer to @uki00a soon and repository will be ported to somewhere. Thanks.

created time in 2 months

pull request commentkeroxp/servest

fix: Avoid setting content-length on event-stream

@Monchi Thanks.

Transfer-Encoding: chunked instead of Content-Length

chunked without body stream makes infinite stream for clients. This is also strange response for normal http client. I think there are no way to send response message after req.respond() called. If you let response as SSE stream, you must pass arbitrary stream to body, don't you?

Monchi

comment created time in 2 months

Pull request review commentkeroxp/deno-redis

🚧 Implement new server commands from Redis 6 🚧

+import { makeTest } from "./test_util.ts";+import {+  assertEquals,+} from "../vendor/https/deno.land/std/testing/asserts.ts";++const { test, client } = await makeTest("acl_cmd");+

nice tests!

Xirui

comment created time in 2 months

Pull request review commentkeroxp/deno-redis

🚧 Implement new server commands from Redis 6 🚧

 class RedisImpl implements RedisCommands {     return reply as Status | BulkNil;   } +  acl_auth(username: string, passwd: string) {+    return this.execStatusReply("AUTH", username, passwd);+  }++  acl_cat(categoryname?: string) {+    if (categoryname) {+      return this.execArrayReply<BulkString>("ACL", "CAT", categoryname);+    } else {+      return this.execArrayReply<BulkString>("ACL", "CAT");+    }+  }++  acl_deluser(username: string) {+    return this.execIntegerReply("ACL", "DELUSER", username);+  }++  acl_genpass(bits?: Integer) {+    if (bits) {+      return this.execStatusReply("ACL", "GENPASS", bits);+    } else {+      return this.execStatusReply("ACL", "GENPASS");+    }+  }++  acl_getuser(username: string) {+    return this.execArrayReply<BulkString>("ACL", "GETUSER", username);+  }++  acl_help() {+    return this.execArrayReply<BulkString>("ACL", "HELP");+  }++  acl_list() {+    return this.execArrayReply<BulkString>("ACL", "LIST");+  }++  acl_load() {+    return this.execStatusReply("ACL", "LOAD");+  }++  acl_log(param: string|number) {+    if (param === "RESET" || param === "reset") {+      return this.execStatusReply("ACL", "LOG", "RESET");+    }+    // if (typeof param == "number") {

Please remove comment out

Xirui

comment created time in 2 months

issue commentkeroxp/servest

Cookie for Agent

@hoangpq Thanks. Simply I planed to store cookie in memory for each agent and send set cookies to specified domain while agent is alive. Is OK?

keroxp

comment created time in 2 months

pull request commentkeroxp/servest

fix: Avoid setting content-length on event-stream

@Monchi I'm not familiar with SSE spec, but I can't believe response without body and content-length:0 is valid. Is valid spec for http/1.1?

Monchi

comment created time in 2 months

created tagkeroxp/deno-redis

tagv0.10.2

🦕 Redis client for Deno 🍕

created time in 2 months

release keroxp/deno-redis

v0.10.2

released time in 2 months

delete branch keroxp/deno-redis

delete branch : bump-deno@v1.0.5

delete time in 2 months

push eventkeroxp/deno-redis

Yusuke Sakurai

commit sha 57bf2b21269be44acb09cfa73bb15215cd879072

bump: deno@v1.0.5 (#87)

view details

push time in 2 months

PR merged keroxp/deno-redis

bump: deno@v1.0.5
+7 -7

0 comment

7 changed files

keroxp

pr closed time in 2 months

PR opened keroxp/deno-redis

bump: deno@v1.0.5
+7 -7

0 comment

7 changed files

pr created time in 2 months

delete branch keroxp/servest

delete branch : bump-deno@v1.0.5

delete time in 2 months

push eventkeroxp/servest

Yusuke Sakurai

commit sha 3fd56a98f321f6b6c9b85a392b7182b7652f214f

bump: deno@v1.0.5 (#129)

view details

push time in 2 months

PR merged keroxp/servest

bump: deno@v1.0.5
+23 -22

0 comment

23 changed files

keroxp

pr closed time in 2 months

PR opened keroxp/servest

bump: deno@v1.0.5
+23 -22

0 comment

23 changed files

pr created time in 2 months

create barnchkeroxp/deno-redis

branch : bump-deno@v1.0.5

created branch time in 2 months

create barnchkeroxp/servest

branch : bump-deno@v1.0.5

created branch time in 2 months

issue commentkeroxp/servest

Help: Stream Large Files

@hoangpq I see. Currently servest has no support for http range request. That feature is planned to be implemented #108

sspilleman

comment created time in 2 months

issue commentkeroxp/servest

Help: Stream Large Files

@sspilleman Thanks for using servest!

stream a large file (mp4) to the browser?

Do you talk about simple video tag usage? serveStatic middleware may help you (https://servestjs.org/use-serve-static)

Or just opening file and pass it to req.respond()

const file = await Deno.open("video.mp4")
try {
  await req.respond({status: 200, body: file})
} finally {
  file.close();
}
sspilleman

comment created time in 2 months

push eventkeroxp/servest

Yusuke Sakurai

commit sha ef0bf141bdc4036da13ee8c2cc7901e0235dfb19

bump: deno@v1.0.3 (#127)

view details

push time in 2 months

delete branch keroxp/servest

delete branch : bump-deno@v1.0.3

delete time in 2 months

PR merged keroxp/servest

bump: deno@v1.0.3
+25 -25

0 comment

24 changed files

keroxp

pr closed time in 2 months

create barnchkeroxp/deno-redis

branch : bump-deno@v1.0.3

created branch time in 2 months

PR opened keroxp/servest

bump: deno@v1.0.3
+25 -25

0 comment

24 changed files

pr created time in 2 months

create barnchkeroxp/servest

branch : bump-deno@v1.0.3

created branch time in 2 months

PR closed denoland/deno

Reviewers
feat: [std/http] Handle keep-alive timeout std
  • Server closes connection when read promise is timed out after keep-alive timeout.
  • Added readTimeout options for serve() serveTLS() listenAndServe() listenAndServeTLS Server
    • readTimeout is keep-alive timeout from server-side. Reading headers and body can be timed out.
    • No timeout specified by default.
  • Made Server less hacky.
  • Added letTimeout in util/async: function that let promise possible to be timed out.
  • BREAKING CHANGE: readRequest' signature changed.
  • BREAKING CHANGE: listenAndServe() listenAndServeTLS() now return Server instance and promise of serve routine.
  • Added writeRequest and readResponse in http/io
  • Added TimeUnits enum in datetime/mod
  • fix: BufReader.readLineSlice() should throw OS error.
  • renaemd: http/mock.ts -> http/testing.ts
  • renamed: Response -> ServerResponse

  • [x] Adding more tests...
+955 -165

15 comments

23 changed files

keroxp

pr closed time in 2 months

pull request commentdenoland/deno

feat: [std/http] Handle keep-alive timeout

splitting this PR into 2 separate PRs:

@bartlomieju Yeah I agree to abandon this PR. I'll try to submit new PRs later.

keroxp

comment created time in 2 months

Pull request review commentdenoland/deno

feat: [std/http] Handle keep-alive timeout

 async function wsHandler(ws: WebSocket): Promise<void> {   } } -listenAndServe({ port: 8080 }, async (req) => {+const port = parseInt(Deno.args[0] ?? "4601");+listenAndServe({ port }, async (req) => {

@bartlomieju Example tests are flaky and this patch might fixes the issue. It is not related to this PR, but sometimes bothered CI.

keroxp

comment created time in 2 months

push eventkeroxp/deno

Andrew Mitchell

commit sha 4ca0d6e2d37ce2be029269be498c76922e30944b

Re-enable several fetch tests (#5803)

view details

Bartek Iwańczuk

commit sha e934df5f7dd7ebc52e8c74033d478c88fa638224

fix: create HTTP cache lazily (#5795)

view details

Bert Belder

commit sha ee0b5bb89ec33acc5dafb876de1f9fda5bcfa236

test: add utility function for assigning unique port to inspector (#5822)

view details

Bert Belder

commit sha 131f2a5f0cdcdbebe3e17c447869f92c99a7c051

fix: BorrowMutError when evaluating expression in inspector console (#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: #5807

view details

Marcos Casagrande

commit sha 20bf04dc7e046e8191443e75be451ec81523a86a

Move getHeaderValueParams & hasHeaderValueOf to util.ts (#5824)

view details

Martin Suchanek

commit sha fbbb9f1c36db526edc136fa2ecc4e6aba022099b

Add missing async delay import to code sample (#5837)

view details

Marcos Casagrande

commit sha c9f0e34e294241541ba59c3a7eb52f42df7ff993

Improve bufferFromStream (#5826)

view details

Marcos Casagrande

commit sha 1c4a9665e2a2ff85ccb8060f168dafafa4d2194b

fix: Allow ArrayBuffer as Fetch request body (#5831)

view details

Rares Folea

commit sha aef9f22462d287a5d18e517aabd8f03210d159b8

Fix typo (#5834)

view details

Marcos Casagrande

commit sha 08f74e1f6a180e83e13f5570811b8b7fcec90e9f

fix(cli/web/fetch): Make Response constructor standard (#5787)

view details

Nayeem Rahman

commit sha 4ebd24342368adbb99582b87dc6c4b8cb6f44c87

fix(std/testing/asserts): Support browsers (#5847)

view details

Marcos Casagrande

commit sha 4e92ef7dc9e1d223d9f3099b94579c2b17e4ef9e

Add more tests for fetch response body (#5852)

view details

Chris Knight

commit sha 9090023c33de7b64ae41425db71c9ab4d5b1237f

docs: "Getting started" manual updates (#5835)

view details

Bartek Iwańczuk

commit sha f462f7fe54d59b2d56ffbb03ca8467ce93096817

fix: parsing of JSX and TSX in SWC (#5870)

view details

zfx

commit sha 24c36fd8625df6b276108109478a62b4661a0b3f

fix(std/log): use writeAllSync instead of writeSync (#5868) Deno.writeSync: Returns the number of bytes written. It is not guaranteed that the full buffer will be written in a single call.

view details

Kitson Kelly

commit sha 228f9c207f8320908325a553c96e465da08fc617

Use ts-expect-error instead of ts-ignore. (#5869)

view details

Robin Wieruch

commit sha 44477596eda3ca50ea6597d4af1fd809a01e2bdc

improve docs (#5872)

view details

Robin Wieruch

commit sha 845bc443da6026903aefa7a6556ecc7c0de371fe

improve docs (#5873)

view details

crowlKats

commit sha d4711feba86ce26044ebffd625b9b9ee872e0f1a

docs: update JetBrains environment support (#5877)

view details

Ryan Dahl

commit sha f7b4523178b01a7e485e98443f03a6973df3e376

Add sponsor button (#5880)

view details

push time in 2 months

push eventkeroxp/deno

Ali Hasani

commit sha 3b86552d669b44c13f8dcf72e1147f79e9f680c6

refactor: remove duplicated code in std/node/module (#5778)

view details

Luca Casonato

commit sha 6feca0ef8bec69f4940c28a9ac0b6a0eeb6884ba

Fix Deno.dir and Diagnostics being present at stable runtime (#5750)

view details

guzhongren

commit sha 94f1de5f805638b7bc06ac36b7fb8adb568c7a25

Fix example (#5775)

view details

Bartek Iwańczuk

commit sha c3c16f025ca6f30f3faaa70481a125494ddcea87

fix: TSX analysis in module graph loader (#5785)

view details

Umar Bolatov

commit sha 2bbe475dbbd46c505cdb2a5e511caadbd63dd1fd

docs: update permissions example (#5809)

view details

skdltmxn

commit sha f6e31603563bad38c663494ddec6a363989b5786

feat(std/encoding): add base64 (#5811)

view details

Valentin Anger

commit sha b7f0b073bb7585ea932a5783ff4ea88843a46b1b

Add unstable checks for unix transport (#5818) Also remove the unix example from the stable documentation to stay in line with the `Deno.listen` one

view details

Andrew Mitchell

commit sha 4ca0d6e2d37ce2be029269be498c76922e30944b

Re-enable several fetch tests (#5803)

view details

Bartek Iwańczuk

commit sha e934df5f7dd7ebc52e8c74033d478c88fa638224

fix: create HTTP cache lazily (#5795)

view details

Bert Belder

commit sha ee0b5bb89ec33acc5dafb876de1f9fda5bcfa236

test: add utility function for assigning unique port to inspector (#5822)

view details

Bert Belder

commit sha 131f2a5f0cdcdbebe3e17c447869f92c99a7c051

fix: BorrowMutError when evaluating expression in inspector console (#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: #5807

view details

Marcos Casagrande

commit sha 20bf04dc7e046e8191443e75be451ec81523a86a

Move getHeaderValueParams & hasHeaderValueOf to util.ts (#5824)

view details

Martin Suchanek

commit sha fbbb9f1c36db526edc136fa2ecc4e6aba022099b

Add missing async delay import to code sample (#5837)

view details

Marcos Casagrande

commit sha c9f0e34e294241541ba59c3a7eb52f42df7ff993

Improve bufferFromStream (#5826)

view details

Marcos Casagrande

commit sha 1c4a9665e2a2ff85ccb8060f168dafafa4d2194b

fix: Allow ArrayBuffer as Fetch request body (#5831)

view details

Rares Folea

commit sha aef9f22462d287a5d18e517aabd8f03210d159b8

Fix typo (#5834)

view details

Marcos Casagrande

commit sha 08f74e1f6a180e83e13f5570811b8b7fcec90e9f

fix(cli/web/fetch): Make Response constructor standard (#5787)

view details

Nayeem Rahman

commit sha 4ebd24342368adbb99582b87dc6c4b8cb6f44c87

fix(std/testing/asserts): Support browsers (#5847)

view details

Marcos Casagrande

commit sha 4e92ef7dc9e1d223d9f3099b94579c2b17e4ef9e

Add more tests for fetch response body (#5852)

view details

Chris Knight

commit sha 9090023c33de7b64ae41425db71c9ab4d5b1237f

docs: "Getting started" manual updates (#5835)

view details

push time in 2 months

created tagkeroxp/deno-redis

tagv0.10.1

🦕 Redis client for Deno 🍕

created time in 2 months

release keroxp/deno-redis

v0.10.1

released time in 2 months

push eventkeroxp/deno-redis

uki00a

commit sha 599720e9d78a475f2537b50e20fac32eb5c3833f

feat: password authentication (#82)

view details

push time in 2 months

PR merged keroxp/deno-redis

feat: password authentication

This PR resolves #81. Please review @keroxp 🙏, cc @devalexqt.

  • Added the password property to RedisConnectOptions.
  • AUTH command is now executed automatically when password is specified.
+31 -0

3 comments

2 changed files

uki00a

pr closed time in 2 months

issue closedkeroxp/deno-redis

Is it possible to connect with password to redis db?

Is it authorization supported?

closed time in 2 months

devalexqt

Pull request review commentkeroxp/deno-redis

feat: password authentication

 export async function connect({   const bufw = new BufWriter(conn);   const exec = muxExecutor(bufr, bufw);   const client = await create(conn, conn, conn, exec);+  if (password) {

Is empty string acceptable? I don't know redis support empty password for authentication, I think we should use != null operator.

uki00a

comment created time in 2 months

Pull request review commentkeroxp/deno-redis

feat: password authentication

 export async function connect({   const bufw = new BufWriter(conn);   const exec = muxExecutor(bufr, bufw);   const client = await create(conn, conn, conn, exec);+  if (password) {+    try {+      await client.auth(password);+    } catch (err) {+      client.close();+      return Promise.reject(err);

throw is natural IMO

uki00a

comment created time in 2 months

Pull request review commentkeroxp/deno-redis

feat: password authentication

 test("db0", async function testDb0Option() {   client2.close(); }); +test("connect with wrong password", async function testConnectWithPassword() {

Could you add test case for empty string password?

uki00a

comment created time in 2 months

issue commentkeroxp/servest

file.content is always undefined

@Almoullim See https://doc.deno.land/https/deno.land/std/mime/multipart.ts. file.content won't be set if sent file is bigger than max memory size. File data is saved in file located at file.tempfile.

Almoullim

comment created time in 2 months

pull request commentloilo-inc/canarycage

misc: bump aws-sdk version to 1.31.5

@YutoUrakami Could you remove mockmake.sh and related files? They no longer work.

YutoUrakami

comment created time in 2 months

push eventloilo-inc/actions-deploy-cage

Yuto Urakami

commit sha 4767be3580d86236ad4d89dbe0d2c09bffdaa562

misc: bump default cage version 3.3.1 (#5)

view details

push time in 3 months

PR merged loilo-inc/actions-deploy-cage

Reviewers
misc: bump default cage version 3.3.1

Updated the default version of canarycage to 3.3.1

+2 -2

0 comment

1 changed file

YutoUrakami

pr closed time in 3 months

push eventloilo-inc/canarycage

Yuto Urakami

commit sha 4cb41ba0f6eb8648e061cd989f11130b0ff6cbc3

fix: Aligning the platform version of canarytask with the service (#45)

view details

push time in 3 months

PR merged loilo-inc/canarycage

fix: Aligning the FARGATE platform version of canarytask with the service

There was a case that the canary task could not be started with a service that uses a version other than the "LATEST" platform version, so I changed to use the same platform version as the service.

+1 -0

0 comment

1 changed file

YutoUrakami

pr closed time in 3 months

push eventkeroxp/servest

Yusuke Sakurai

commit sha 4b18f3df86358001d5f6aed0d9aca179ad20781d

site: add comparisons (#126)

view details

push time in 3 months

delete branch keroxp/servest

delete branch : site-0526

delete time in 3 months

PR merged keroxp/servest

site: add comparisons
+138 -7

0 comment

8 changed files

keroxp

pr closed time in 3 months

push eventkeroxp/servest

Yusuke Sakurai

commit sha c52158bbd7d58444cea5f358983addd43caef086

Update index.tsx

view details

push time in 3 months

PR opened keroxp/servest

site: add comparisons
+76 -2

0 comment

7 changed files

pr created time in 3 months

create barnchkeroxp/servest

branch : site-0526

created branch time in 3 months

issue commentkeroxp/servest

file.content is always undefined

@Almoullim bodyForm.removeAll() removes all temporal multipart files stored in fs. In your code, they will have been gone on responding. So you have to call it after responding. See https://servestjs.org/reading-body

Almoullim

comment created time in 3 months

push eventloilo-inc/actions-deploy-cage

kbinani

commit sha 05ad85015a721b3d53f4ef26f5ba1e16265fbf07

Fixed typo of input variable name in action.yml (#4)

view details

push time in 3 months

more