profile
viewpoint
Keith Smiley keith Lyft San Francisco, CA https://smileykeith.com iOS @Lyft

christoomey/vim-tmux-navigator 3254

Seamless navigation between tmux panes and vim splits

CocoaPods/Rome 643

Makes it easy to build a list of frameworks.

bazelbuild/tulsi 343

An Xcode Project Generator For Bazel

bazelbuild/rules_apple 198

Bazel rules to build apps for Apple platforms.

bazelbuild/rules_swift 134

Bazel rules to build Swift on Apple and Linux platforms

bazel-ios/rules_ios 86

Bazel rules for building iOS applications and frameworks

keith/contacts-cli 40

Query macOS contacts from the command line

kattrali/webkitten 33

A command-driven web browser toolkit inspired by luakit and Vim.

bazelbuild/apple_support 19

Apple support for Bazel rules

keith/conductor 19

A lightweight OS X window manager for hackers

pull request commentapple/swift

[ownership] Implement Interior Pointer handling API for RAUWing addresses

Build failed Swift Test Linux Platform Git Sha - fb994e99da151c3bbcd6c11cf7f5b4b42c6b4ed2

gottesmm

comment created time in 8 minutes

pull request commentapple/swift

[ConstraintSystem] Implement heuristics for pruning the generic operator overload search space

Summary for main full

Unexpected test results, excluded stats for RxCocoa

Regressions found (see below)

<a name="debug-batch-5640a1515ebb7998">

Debug-batch

<a name="debug-batch-brief-5640a1515ebb7998">

debug-batch brief

<details> <summary>Regressed (0)</summary>

name old new delta delta_pct

</details> <details> <summary>Improved (0)</summary>

name old new delta delta_pct

</details> <details> <summary>Unchanged (delta < 1.0% or delta < 100.0ms) (3)</summary>

name old new delta delta_pct
Frontend.NumInstructionsExecuted 142,701,778,677,621 142,287,242,364,310 -414,536,313,311 -0.29%
LLVM.NumLLVMBytesOutput 2,494,534,824 2,494,538,238 3,414 0.0%
time.swift-driver.wall 10519.3s 10562.3s 43.1s 0.41%

</details>

<a name="debug-batch-detailed-5640a1515ebb7998">

debug-batch detailed

<details> <summary>Regressed (4)</summary>

name old new delta delta_pct
Sema.InheritedProtocolsRequest 914,966 927,897 12,931 1.41% :no_entry:
Sema.LookupConformanceInModuleRequest 47,974,855 50,769,921 2,795,066 5.83% :no_entry:
Sema.NumConstraintScopes 33,981,176 34,638,419 657,243 1.93% :no_entry:
Sema.NumConstraintsConsideredForEdgeContraction 95,375,135 98,388,725 3,013,590 3.16% :no_entry:

</details> <details> <summary>Improved (3)</summary>

name old new delta delta_pct
Sema.CompareDeclSpecializationRequest 711,289 697,648 -13,641 -1.92% :white_check_mark:
Sema.HasDynamicMemberLookupAttributeRequest 878,293 864,478 -13,815 -1.57% :white_check_mark:
Sema.NumLeafScopes 21,855,299 21,541,435 -313,864 -1.44% :white_check_mark:

</details> <details> <summary>Unchanged (delta < 1.0% or delta < 100.0ms) (247)</summary>

name old new delta delta_pct
AST.ImportSetCacheHit 2,856,828 2,857,150 322 0.01%
AST.ImportSetCacheMiss 769,314 769,308 -6 -0.0%
AST.ImportSetFoldHit 238,877 238,872 -5 -0.0%
AST.ImportSetFoldMiss 530,437 530,436 -1 -0.0%
AST.ModuleShadowCacheHit 5,504 5,504 0 0.0%
AST.ModuleShadowCacheMiss 2,534 2,534 0 0.0%
AST.ModuleVisibilityCacheHit 56,499 56,499 0 0.0%
AST.ModuleVisibilityCacheMiss 12,015 12,015 0 0.0%
AST.NumASTBytesAllocated 76,463,299,924 76,724,107,804 260,807,880 0.34%
AST.NumASTScopeExpansions 8,635,921 8,636,325 404 0.0%
AST.NumASTScopeLookups 8,103,695 8,105,257 1,562 0.02%
AST.NumDecls 188,708 188,708 0 0.0%
AST.NumDependencies 629,318 629,336 18 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 485,564 485,564 0 0.0%
AST.NumLocalTypeDecls 317 317 0 0.0%
AST.NumModuleLookupClassMember 8,186 8,186 0 0.0%
AST.NumModuleLookupValue 78,757,769 78,771,609 13,840 0.02%
AST.NumObjCMethods 29,667 29,667 0 0.0%
AST.NumOperators 806 806 0 0.0%
AST.NumPrecedenceGroups 132 132 0 0.0%
AST.NumReferencedDynamicNames 204 204 0 0.0%
AST.NumReferencedMemberNames 12,308,863 12,354,582 45,719 0.37%
AST.NumReferencedTopLevelNames 1,409,525 1,410,125 600 0.04%
AST.NumSourceBuffers 739,422 739,420 -2 -0.0%
AST.NumSourceLines 6,511,929 6,511,929 0 0.0%
AST.NumSourceLinesPerSecond 2,868,321 2,859,121 -9,200 -0.32%
AST.NumTotalClangImportedEntities 4,024,621 4,022,848 -1,773 -0.04%
Driver.ChildrenMaxRSS 381,852,989,440 383,556,354,048 1,703,364,608 0.45%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 36,057 36,057 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 90,944 90,725 -219 -0.24%
Driver.NumDriverPipeReads 74,438 74,195 -243 -0.33%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 2,354,425,449,784 2,358,271,960,904 3,846,511,120 0.16%
Frontend.NumInstructionsExecuted 142,701,778,677,621 142,287,242,364,310 -414,536,313,311 -0.29%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 34,383 34,383 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 316,097 316,097 0 0.0%
IRModule.NumIRAliases 263,004 263,004 0 0.0%
IRModule.NumIRBasicBlocks 9,546,900 9,546,900 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 4,749,799 4,749,799 0 0.0%
IRModule.NumIRGlobals 4,852,372 4,852,372 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 116,765,425 116,765,425 0 0.0%
IRModule.NumIRNamedMetaData 174,135 174,135 0 0.0%
IRModule.NumIRValueSymbols 8,815,973 8,815,973 0 0.0%
LLVM.NumLLVMBytesOutput 2,494,534,824 2,494,538,238 3,414 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 373,862 373,862 0 0.0%
Parse.NumIterableDeclContextParsed 1,085,201 1,085,254 53 0.0%
Parse.ParseAbstractFunctionBodyRequest 343,700 343,700 0 0.0%
Parse.ParseMembersRequest 963,585 963,638 53 0.01%
Parse.ParseSourceFileRequest 735,028 735,028 0 0.0%
SILGen.ASTLoweringRequest 36,018 36,018 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 3,011,218 3,011,218 0 0.0%
SILModule.NumSILGenGlobalVariables 86,873 86,873 0 0.0%
SILModule.NumSILGenVtables 40,243 40,243 0 0.0%
SILModule.NumSILGenWitnessTables 179,724 179,724 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 3,859,283 3,859,283 0 0.0%
SILModule.NumSILOptGlobalVariables 89,195 89,195 0 0.0%
SILModule.NumSILOptVtables 40,384 40,384 0 0.0%
SILModule.NumSILOptWitnessTables 242,091 242,091 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 139,233 139,233 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.AbstractGenericSignatureRequest 53,742 53,742 0 0.0%
Sema.AccessLevelRequest 22,052,858 22,071,546 18,688 0.08%
Sema.ActorIsolationRequest 1,116,752 1,116,752 0 0.0%
Sema.AnyObjectLookupRequest 300 300 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 30,608 30,608 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 783,661 783,661 0 0.0%
Sema.AttachedPropertyWrappersRequest 3,825,279 3,825,280 1 0.0%
Sema.AttachedResultBuilderRequest 953,251 953,251 0 0.0%
Sema.BodyInitKindRequest 65,040 65,040 0 0.0%
Sema.CallerSideDefaultArgExprRequest 122,930 122,930 0 0.0%
Sema.CanBeAsyncHandlerRequest 325,102 325,102 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 16,570 16,570 0 0.0%
Sema.CheckRedeclarationRequest 1,340,997 1,340,997 0 0.0%
Sema.ClassAncestryFlagsRequest 154,892 154,892 0 0.0%
Sema.ClosureHasExplicitResultRequest 124,630 124,630 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 14,230,998 14,235,212 4,214 0.03%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 1,434 1,434 0 0.0%
Sema.CustomAttrTypeRequest 833 833 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 83,979 83,979 0 0.0%
Sema.DefaultArgumentExprRequest 50,966 50,966 0 0.0%
Sema.DefaultArgumentInitContextRequest 358 358 0 0.0%
Sema.DefaultDefinitionTypeRequest 9,148 9,148 0 0.0%
Sema.DefaultTypeRequest 370,441 370,363 -78 -0.02%
Sema.DerivativeAttrOriginalDeclRequest 16 16 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 49,579,996 49,379,961 -200,035 -0.4%
Sema.DirectOperatorLookupRequest 2,972,644 2,973,011 367 0.01%
Sema.DirectPrecedenceGroupLookupRequest 798,976 798,976 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,556,244 1,556,244 0 0.0%
Sema.EnumRawTypeRequest 36,808 36,819 11 0.03%
Sema.EnumRawValuesRequest 15,059 15,059 0 0.0%
Sema.ExistentialConformsToSelfRequest 18,226 18,377 151 0.83%
Sema.ExistentialTypeSupportedRequest 23,049 23,049 0 0.0%
Sema.ExtendedNominalRequest 1,216,111 1,216,111 0 0.0%
Sema.ExtendedTypeRequest 111,869 111,868 -1 -0.0%
Sema.FragileFunctionKindRequest 2,156,766 2,156,766 0 0.0%
Sema.FunctionOperatorRequest 102,951 102,951 0 0.0%
Sema.GenericParamListRequest 7,193,149 7,191,955 -1,194 -0.02%
Sema.GenericSignatureRequest 3,826,447 3,826,026 -421 -0.01%
Sema.GetDestructorRequest 36,028 36,028 0 0.0%
Sema.GlobalActorAttributeRequest 1,234,344 1,234,344 0 0.0%
Sema.GlobalActorInstanceRequest 249 249 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 13,488 13,488 0 0.0%
Sema.HasCircularRawValueRequest 12,857 12,857 0 0.0%
Sema.HasDefaultInitRequest 77,664 77,664 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasImplementationOnlyImportsRequest 730,747 730,747 0 0.0%
Sema.HasMemberwiseInitRequest 30,965 30,965 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 34,362 34,362 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 77,676 77,676 0 0.0%
Sema.InferredGenericSignatureRequest 235,149 235,148 -1 -0.0%
Sema.InheritedDeclsReferencedRequest 9,041,852 9,081,363 39,511 0.44%
Sema.InheritedTypeRequest 375,747 375,656 -91 -0.02%
Sema.InheritsSuperclassInitializersRequest 37,373 37,373 0 0.0%
Sema.InitKindRequest 131,930 131,930 0 0.0%
Sema.InterfaceTypeRequest 22,592,057 22,603,879 11,822 0.05%
Sema.IsABICompatibleOverrideRequest 184,955 184,955 0 0.0%
Sema.IsAccessorTransparentRequest 448,086 448,086 0 0.0%
Sema.IsActorRequest 434,343 434,337 -6 -0.0%
Sema.IsAsyncHandlerRequest 2,198,084 2,189,380 -8,704 -0.4%
Sema.IsCallableNominalTypeRequest 3,394 3,394 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDefaultActorRequest 60,056 60,056 0 0.0%
Sema.IsDynamicRequest 2,445,762 2,445,762 0 0.0%
Sema.IsFinalRequest 4,216,675 4,217,181 506 0.01%
Sema.IsGetterMutatingRequest 595,259 595,259 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 3,449,325 3,448,183 -1,142 -0.03%
Sema.IsObjCRequest 2,209,263 2,209,440 177 0.01%
Sema.IsSetterMutatingRequest 466,183 466,183 0 0.0%
Sema.IsStaticRequest 1,878,366 1,878,393 27 0.0%
Sema.LazyStoragePropertyRequest 3,400 3,400 0 0.0%
Sema.LookupAllConformancesInContextRequest 162,054 162,054 0 0.0%
Sema.LookupInModuleRequest 10,306,787 10,305,762 -1,025 -0.01%
Sema.LookupInfixOperatorRequest 127,752 127,752 0 0.0%
Sema.LookupPostfixOperatorRequest 218 218 0 0.0%
Sema.LookupPrecedenceGroupRequest 35,039 35,039 0 0.0%
Sema.LookupPrefixOperatorRequest 1,151 1,151 0 0.0%
Sema.MangleLocalTypeDeclRequest 634 634 0 0.0%
Sema.ModuleImplicitImportsRequest 18,183 18,183 0 0.0%
Sema.ModuleQualifiedLookupRequest 4,828,684 4,826,096 -2,588 -0.05%
Sema.NamedLazyMemberLoadSuccessCount 30,639,872 30,435,887 -203,985 -0.67%
Sema.NamingPatternRequest 347,118 347,119 1 0.0%
Sema.NeedsNewVTableEntryRequest 966,095 966,095 0 0.0%
Sema.NumAccessorBodiesSynthesized 263,993 263,993 0 0.0%
Sema.NumAccessorsSynthesized 416,501 416,501 0 0.0%
Sema.NumConformancesDeserialized 15,494,534 15,507,511 12,977 0.08%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 566 566 0 0.0%
Sema.NumDeclsDeserialized 122,780,901 123,710,942 930,041 0.76%
Sema.NumDeclsTypechecked 1,929,769 1,929,769 0 0.0%
Sema.NumGenericSignatureBuilders 1,860,069 1,865,606 5,537 0.3%
Sema.NumLazyIterableDeclContexts 14,294,644 14,335,441 40,797 0.29%
Sema.NumLazyRequirementSignatures 1,421,438 1,422,261 823 0.06%
Sema.NumLazyRequirementSignaturesLoaded 941,493 942,741 1,248 0.13%
Sema.NumTypesDeserialized 37,782,982 37,934,388 151,406 0.4%
Sema.NumUnloadedLazyIterableDeclContexts 8,842,436 8,833,432 -9,004 -0.1%
Sema.OpaqueReadOwnershipRequest 399,195 399,195 0 0.0%
Sema.OpaqueResultTypeRequest 428 428 0 0.0%
Sema.OperatorPrecedenceGroupRequest 921 921 0 0.0%
Sema.OverriddenDeclsRequest 4,153,625 4,152,601 -1,024 -0.02%
Sema.ParamSpecifierRequest 1,786,327 1,786,326 -1 -0.0%
Sema.PatternBindingEntryRequest 688,183 688,184 1 0.0%
Sema.PatternTypeRequest 794,381 794,382 1 0.0%
Sema.PreCheckResultBuilderRequest 962 962 0 0.0%
Sema.PrimarySourceFilesRequest 18,183 18,183 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 774,914 774,914 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 783,661 783,661 0 0.0%
Sema.PropertyWrapperLValuenessRequest 640 640 0 0.0%
Sema.PropertyWrapperMutabilityRequest 827,253 827,253 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 251 251 0 0.0%
Sema.ProtocolRequiresClassRequest 53,906 53,837 -69 -0.13%
Sema.ProvideDefaultImplForRequest 14,230,998 14,235,212 4,214 0.03%
Sema.QualifiedLookupRequest 8,404,709 8,392,659 -12,050 -0.14%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 139,152 139,151 -1 -0.0%
Sema.RequirementSignatureRequest 1,031,839 1,032,997 1,158 0.11%
Sema.RequiresOpaqueAccessorsRequest 1,762,333 1,762,333 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 381,731 381,731 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 576,351 576,516 165 0.03%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 4,740,629 4,740,524 -105 -0.0%
Sema.ResultBuilderTypeRequest 496,064 496,064 0 0.0%
Sema.ResultTypeRequest 958,638 958,637 -1 -0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 24,322,539 24,329,833 7,294 0.03%
Sema.ScopedImportLookupRequest 1,137 1,137 0 0.0%
Sema.SelfAccessKindRequest 979,196 979,220 24 0.0%
Sema.SelfBoundsFromWhereClauseRequest 2,552,328 2,551,825 -503 -0.02%
Sema.SemanticMembersRequest 36,321 36,321 0 0.0%
Sema.SetterAccessLevelRequest 209,087 209,087 0 0.0%
Sema.SimpleDidSetRequest 4,099,062 4,099,901 839 0.02%
Sema.SpecializeAttrTargetDeclRequest 5,116 5,116 0 0.0%
Sema.StorageImplInfoRequest 2,051,280 2,051,280 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 85,722 85,722 0 0.0%
Sema.StoredPropertiesRequest 523,018 523,018 0 0.0%
Sema.StructuralTypeRequest 2,732 2,732 0 0.0%
Sema.SuperclassDeclRequest 701,519 701,446 -73 -0.01%
Sema.SuperclassTypeRequest 76,359 76,359 0 0.0%
Sema.SynthesizeAccessorRequest 416,501 416,501 0 0.0%
Sema.SynthesizeDefaultInitRequest 7,629 7,629 0 0.0%
Sema.SynthesizeMainFunctionRequest 33,999 33,999 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 5,519 5,519 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 708,015 708,015 0 0.0%
Sema.TypeCheckSourceFileRequest 34,827 34,827 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 38,330 38,330 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 12,266 12,265 -1 -0.01%
Sema.USRGenerationRequest 16,197,924 16,202,652 4,728 0.03%
Sema.UnderlyingTypeDeclsReferencedRequest 465,116 467,809 2,693 0.58%
Sema.UnderlyingTypeRequest 53,536 53,537 1 0.0%
Sema.UnqualifiedLookupRequest 6,533,128 6,534,690 1,562 0.02%
Sema.ValidatePrecedenceGroupRequest 243,248 243,248 0 0.0%
Sema.ValueWitnessRequest 93,459 93,459 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 34,405 34,405 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

</details>

<a name="release-5640a1515ebb7998">

Release

<a name="release-brief-5640a1515ebb7998">

release brief

<details> <summary>Regressed (0)</summary>

name old new delta delta_pct

</details> <details> <summary>Improved (0)</summary>

name old new delta delta_pct

</details> <details> <summary>Unchanged (delta < 1.0% or delta < 100.0ms) (3)</summary>

name old new delta delta_pct
Frontend.NumInstructionsExecuted 73,636,053,287,847 73,698,923,995,433 62,870,707,586 0.09%
LLVM.NumLLVMBytesOutput 2,462,278,526 2,462,286,758 8,232 0.0%
time.swift-driver.wall 14538.2s 14576.0s 37.8s 0.26%

</details>

<a name="release-detailed-5640a1515ebb7998">

release detailed

<details> <summary>Regressed (7)</summary>

name old new delta delta_pct
AST.NumReferencedMemberNames 3,424 3,488 64 1.87% :no_entry:
Sema.InheritedProtocolsRequest 124,090 126,668 2,578 2.08% :no_entry:
Sema.LookupConformanceInModuleRequest 76,979,482 79,764,782 2,785,300 3.62% :no_entry:
Sema.NumConstraintScopes 32,580,441 33,249,771 669,330 2.05% :no_entry:
Sema.NumConstraintsConsideredForEdgeContraction 94,202,539 97,332,266 3,129,727 3.32% :no_entry:
Sema.NumDeclsDeserialized 14,609,068 14,905,116 296,048 2.03% :no_entry:
Sema.UnderlyingTypeDeclsReferencedRequest 71,164 72,032 868 1.22% :no_entry:

</details> <details> <summary>Improved (4)</summary>

name old new delta delta_pct
Sema.CompareDeclSpecializationRequest 526,824 513,454 -13,370 -2.54% :white_check_mark:
Sema.HasDynamicMemberLookupAttributeRequest 352,297 338,501 -13,796 -3.92% :white_check_mark:
Sema.NamedLazyMemberLoadSuccessCount 11,102,818 10,928,828 -173,990 -1.57% :white_check_mark:
Sema.NumLeafScopes 20,768,031 20,458,455 -309,576 -1.49% :white_check_mark:

</details> <details> <summary>Unchanged (delta < 1.0% or delta < 100.0ms) (243)</summary>

name old new delta delta_pct
AST.ImportSetCacheHit 1,699,048 1,699,052 4 0.0%
AST.ImportSetCacheMiss 80,865 80,865 0 0.0%
AST.ImportSetFoldHit 35,829 35,829 0 0.0%
AST.ImportSetFoldMiss 45,036 45,036 0 0.0%
AST.ModuleShadowCacheHit 4,552 4,552 0 0.0%
AST.ModuleShadowCacheMiss 1,734 1,734 0 0.0%
AST.ModuleVisibilityCacheHit 31,873 31,873 0 0.0%
AST.ModuleVisibilityCacheMiss 4,409 4,409 0 0.0%
AST.NumASTBytesAllocated 12,754,697,427 12,827,275,371 72,577,944 0.57%
AST.NumASTScopeExpansions 3,895,290 3,895,290 0 0.0%
AST.NumASTScopeLookups 5,644,668 5,644,674 6 0.0%
AST.NumDecls 191,360 191,360 0 0.0%
AST.NumDependencies 71,263 71,260 -3 -0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 36,966 36,966 0 0.0%
AST.NumLocalTypeDecls 317 317 0 0.0%
AST.NumModuleLookupClassMember 7,886 7,886 0 0.0%
AST.NumModuleLookupValue 37,117,256 37,117,408 152 0.0%
AST.NumObjCMethods 29,403 29,403 0 0.0%
AST.NumOperators 806 806 0 0.0%
AST.NumPrecedenceGroups 132 132 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedTopLevelNames 352 352 0 0.0%
AST.NumSourceBuffers 36,957 36,957 0 0.0%
AST.NumSourceLines 6,598,872 6,598,872 0 0.0%
AST.NumSourceLinesPerSecond 395,329 396,432 1,103 0.28%
AST.NumTotalClangImportedEntities 613,081 613,082 1 0.0%
Driver.ChildrenMaxRSS 465,226,328,064 465,110,011,904 -116,316,160 -0.03%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 1,934 1,934 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 95,852 96,415 563 0.59%
Driver.NumDriverPipeReads 93,918 94,481 563 0.6%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 363,490,270,032 363,167,505,048 -322,764,984 -0.09%
Frontend.NumInstructionsExecuted 73,636,053,287,847 73,698,923,995,433 62,870,707,586 0.09%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 12 12 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 306,863 306,863 0 0.0%
IRModule.NumIRAliases 205,077 205,077 0 0.0%
IRModule.NumIRBasicBlocks 6,498,263 6,498,263 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,751,265 3,751,265 0 0.0%
IRModule.NumIRGlobals 4,419,347 4,419,347 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 64,419,325 64,419,325 0 0.0%
IRModule.NumIRNamedMetaData 177,325 177,325 0 0.0%
IRModule.NumIRValueSymbols 7,761,209 7,761,209 0 0.0%
LLVM.NumLLVMBytesOutput 2,462,278,526 2,462,286,758 8,232 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 378,900 378,900 0 0.0%
Parse.NumIterableDeclContextParsed 127,137 127,137 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 345,659 345,659 0 0.0%
Parse.ParseMembersRequest 426 426 0 0.0%
Parse.ParseSourceFileRequest 35,489 35,489 0 0.0%
SILGen.ASTLoweringRequest 1,660 1,660 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,670,301 1,670,301 0 0.0%
SILModule.NumSILGenGlobalVariables 86,847 86,847 0 0.0%
SILModule.NumSILGenVtables 24,385 24,385 0 0.0%
SILModule.NumSILGenWitnessTables 94,973 94,973 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,393,718 1,393,718 0 0.0%
SILModule.NumSILOptGlobalVariables 126,170 126,170 0 0.0%
SILModule.NumSILOptVtables 27,768 27,768 0 0.0%
SILModule.NumSILOptWitnessTables 97,317 97,317 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 6,628 6,628 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.AbstractGenericSignatureRequest 34,998 34,998 0 0.0%
Sema.AccessLevelRequest 2,128,138 2,128,138 0 0.0%
Sema.ActorIsolationRequest 677,364 677,364 0 0.0%
Sema.AnyObjectLookupRequest 300 300 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 18,414 18,414 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 515,721 515,721 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,683,621 2,683,621 0 0.0%
Sema.AttachedResultBuilderRequest 919,922 919,922 0 0.0%
Sema.BodyInitKindRequest 63,764 63,764 0 0.0%
Sema.CallerSideDefaultArgExprRequest 122,909 122,909 0 0.0%
Sema.CanBeAsyncHandlerRequest 250,611 250,611 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 1,656 1,656 0 0.0%
Sema.CheckRedeclarationRequest 1,363,107 1,363,107 0 0.0%
Sema.ClassAncestryFlagsRequest 64,854 64,854 0 0.0%
Sema.ClosureHasExplicitResultRequest 123,646 123,646 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 461 461 0 0.0%
Sema.CustomAttrTypeRequest 367 367 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 54,271 54,271 0 0.0%
Sema.DefaultArgumentExprRequest 51,377 51,377 0 0.0%
Sema.DefaultArgumentInitContextRequest 126 126 0 0.0%
Sema.DefaultDefinitionTypeRequest 3,957 3,957 0 0.0%
Sema.DefaultTypeRequest 354,582 354,504 -78 -0.02%
Sema.DerivativeAttrOriginalDeclRequest 8 8 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 41,875,676 41,656,586 -219,090 -0.52%
Sema.DirectOperatorLookupRequest 1,559,004 1,559,076 72 0.0%
Sema.DirectPrecedenceGroupLookupRequest 750,213 750,213 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,082,191 1,082,191 0 0.0%
Sema.EnumRawTypeRequest 12,936 12,936 0 0.0%
Sema.EnumRawValuesRequest 13,802 13,802 0 0.0%
Sema.ExistentialConformsToSelfRequest 4,703 4,745 42 0.89%
Sema.ExistentialTypeSupportedRequest 10,715 10,715 0 0.0%
Sema.ExtendedNominalRequest 59,090 59,090 0 0.0%
Sema.ExtendedTypeRequest 59,062 59,062 0 0.0%
Sema.FragileFunctionKindRequest 1,371,226 1,371,226 0 0.0%
Sema.FunctionOperatorRequest 12,196 12,196 0 0.0%
Sema.GenericParamListRequest 1,607,129 1,606,379 -750 -0.05%
Sema.GenericSignatureRequest 1,366,228 1,366,214 -14 -0.0%
Sema.GetDestructorRequest 25,394 25,394 0 0.0%
Sema.GlobalActorAttributeRequest 766,673 766,673 0 0.0%
Sema.GlobalActorInstanceRequest 54 54 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 11,030 11,030 0 0.0%
Sema.HasCircularRawValueRequest 12,935 12,935 0 0.0%
Sema.HasDefaultInitRequest 41,515 41,515 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasImplementationOnlyImportsRequest 35,344 35,344 0 0.0%
Sema.HasMemberwiseInitRequest 17,138 17,138 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 26,239 26,239 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 41,515 41,515 0 0.0%
Sema.InferredGenericSignatureRequest 88,956 88,956 0 0.0%
Sema.InheritedDeclsReferencedRequest 1,396,351 1,402,675 6,324 0.45%
Sema.InheritedTypeRequest 202,957 202,957 0 0.0%
Sema.InheritsSuperclassInitializersRequest 18,159 18,159 0 0.0%
Sema.InitKindRequest 79,041 79,041 0 0.0%
Sema.InterfaceTypeRequest 4,308,905 4,309,808 903 0.02%
Sema.IsABICompatibleOverrideRequest 183,651 183,651 0 0.0%
Sema.IsAccessorTransparentRequest 361,376 361,376 0 0.0%
Sema.IsActorRequest 71,945 71,946 1 0.0%
Sema.IsAsyncHandlerRequest 952,999 950,905 -2,094 -0.22%
Sema.IsCallableNominalTypeRequest 2,830 2,830 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDefaultActorRequest 34,864 34,864 0 0.0%
Sema.IsDynamicRequest 1,677,755 1,677,755 0 0.0%
Sema.IsFinalRequest 1,338,395 1,338,395 0 0.0%
Sema.IsGetterMutatingRequest 441,381 441,381 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,555,493 2,555,493 0 0.0%
Sema.IsObjCRequest 1,466,438 1,466,438 0 0.0%
Sema.IsSetterMutatingRequest 423,811 423,811 0 0.0%
Sema.IsStaticRequest 754,248 754,248 0 0.0%
Sema.LazyStoragePropertyRequest 849 849 0 0.0%
Sema.LookupAllConformancesInContextRequest 113,496 113,496 0 0.0%
Sema.LookupInModuleRequest 2,966,918 2,966,902 -16 -0.0%
Sema.LookupInfixOperatorRequest 73,507 73,507 0 0.0%
Sema.LookupPostfixOperatorRequest 47 47 0 0.0%
Sema.LookupPrecedenceGroupRequest 34,104 34,104 0 0.0%
Sema.LookupPrefixOperatorRequest 190 190 0 0.0%
Sema.MangleLocalTypeDeclRequest 337 337 0 0.0%
Sema.ModuleImplicitImportsRequest 1,660 1,660 0 0.0%
Sema.ModuleQualifiedLookupRequest 527,962 527,940 -22 -0.0%
Sema.NamingPatternRequest 92,829 92,829 0 0.0%
Sema.NeedsNewVTableEntryRequest 736,967 736,967 0 0.0%
Sema.NumAccessorBodiesSynthesized 268,321 268,321 0 0.0%
Sema.NumAccessorsSynthesized 272,681 272,681 0 0.0%
Sema.NumConformancesDeserialized 3,922,456 3,922,377 -79 -0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 566 566 0 0.0%
Sema.NumDeclsTypechecked 1,960,447 1,960,447 0 0.0%
Sema.NumGenericSignatureBuilders 298,186 299,163 977 0.33%
Sema.NumLazyIterableDeclContexts 1,778,166 1,789,389 11,223 0.63%
Sema.NumLazyRequirementSignatures 152,240 152,246 6 0.0%
Sema.NumLazyRequirementSignaturesLoaded 116,213 116,192 -21 -0.02%
Sema.NumTypesDeserialized 6,675,495 6,724,862 49,367 0.74%
Sema.NumUnloadedLazyIterableDeclContexts 1,154,363 1,150,439 -3,924 -0.34%
Sema.OpaqueReadOwnershipRequest 251,699 251,699 0 0.0%
Sema.OpaqueResultTypeRequest 356 356 0 0.0%
Sema.OperatorPrecedenceGroupRequest 716 716 0 0.0%
Sema.OverriddenDeclsRequest 1,362,332 1,362,332 0 0.0%
Sema.ParamSpecifierRequest 1,047,618 1,047,618 0 0.0%
Sema.PatternBindingEntryRequest 413,934 413,934 0 0.0%
Sema.PatternTypeRequest 517,809 517,809 0 0.0%
Sema.PreCheckResultBuilderRequest 888 888 0 0.0%
Sema.PrimarySourceFilesRequest 1,660 1,660 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 510,900 510,900 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 515,721 515,721 0 0.0%
Sema.PropertyWrapperLValuenessRequest 640 640 0 0.0%
Sema.PropertyWrapperMutabilityRequest 669,052 669,052 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 53 53 0 0.0%
Sema.ProtocolRequiresClassRequest 11,620 11,620 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 5,143,273 5,129,871 -13,402 -0.26%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 88,885 88,885 0 0.0%
Sema.RequirementSignatureRequest 129,834 129,813 -21 -0.02%
Sema.RequiresOpaqueAccessorsRequest 1,540,611 1,540,611 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 247,955 247,955 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 394,054 394,054 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 2,493,106 2,492,998 -108 -0.0%
Sema.ResultBuilderTypeRequest 456,892 456,892 0 0.0%
Sema.ResultTypeRequest 551,296 551,296 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 2,692,370 2,692,411 41 0.0%
Sema.ScopedImportLookupRequest 1,231 1,231 0 0.0%
Sema.SelfAccessKindRequest 430,290 430,290 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 575,281 575,239 -42 -0.01%
Sema.SemanticMembersRequest 25,414 25,414 0 0.0%
Sema.SetterAccessLevelRequest 173,673 173,673 0 0.0%
Sema.SimpleDidSetRequest 449,813 449,813 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 2,864 2,864 0 0.0%
Sema.StorageImplInfoRequest 1,686,969 1,686,969 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 55,605 55,605 0 0.0%
Sema.StoredPropertiesRequest 190,484 190,484 0 0.0%
Sema.StructuralTypeRequest 679 679 0 0.0%
Sema.SuperclassDeclRequest 130,560 130,518 -42 -0.03%
Sema.SuperclassTypeRequest 32,971 32,971 0 0.0%
Sema.SynthesizeAccessorRequest 272,681 272,681 0 0.0%
Sema.SynthesizeDefaultInitRequest 4,004 4,004 0 0.0%
Sema.SynthesizeMainFunctionRequest 24,377 24,377 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,482 3,482 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 716,092 716,092 0 0.0%
Sema.TypeCheckSourceFileRequest 35,465 35,465 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 28,037 28,037 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 5,071 5,071 0 0.0%
Sema.USRGenerationRequest 508,520 508,520 0 0.0%
Sema.UnderlyingTypeRequest 25,365 25,365 0 0.0%
Sema.UnqualifiedLookupRequest 2,944,420 2,944,426 6 0.0%
Sema.ValidatePrecedenceGroupRequest 243,267 243,267 0 0.0%
Sema.ValueWitnessRequest 45,161 45,161 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 1,656 1,656 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

</details>

hborla

comment created time in 9 minutes

push eventapple/swift

Becca Royal-Gordon

commit sha 3dc38ebc516c9fc7d14e90bc04fd383a574f1f3c

[NFC] Correct contributor’s name

view details

swift-ci

commit sha a6b85522f5d24a85c2dba89ff17566fb823fb8d1

Merge pull request #35460 from beccadax/im-going-to-enjoy-watching-you-die-mr-anderson

view details

push time in 19 minutes

PR merged apple/swift

[NFC] Correct contributor’s name

@brentdax is now @beccadax. More to come on this.

+1 -1

1 comment

1 changed file

beccadax

pr closed time in 19 minutes

pull request commentapple/swift

[ownership] Implement Interior Pointer handling API for RAUWing addresses

Build failed Swift Test OS X Platform Git Sha - fb994e99da151c3bbcd6c11cf7f5b4b42c6b4ed2

gottesmm

comment created time in 41 minutes

issue commentbazelbuild/bazel

Support Python/C++ interoperability (native Python modules)

OK, here goes: https://github.com/quval/rules_native_python/commit/f8eaecd9b124b433ec083fd71e0bef044cb04c6c Got it to work on both Linux and Mac, but only with a toy setup, so I'd still consider this a draft. More importantly, I'm not sure I like the hack I did to work around the circular dependency (native deps -- compiled into native module -- linked against native deps). Any thoughts and suggestions are welcome.

davidzchen

comment created time in an hour

pull request commentapple/swift

[ownership] Implement Interior Pointer handling API for RAUWing addresses

@swift-ci test

gottesmm

comment created time in an hour

Pull request review commentapple/swift

[ownership] Implement Interior Pointer handling API for RAUWing addresses

-// RUN: %target-sil-opt -enable-objc-interop -enforce-exclusivity=none -enable-sil-verify-all %s -sil-combine | %FileCheck %s+// RUN: %target-sil-opt -enable-objc-interop -enforce-exclusivity=none -enable-sil-verify-all %s -sil-combine -semantic-arc-opts | %FileCheck %s

Hmm... This shouldn't be here.

gottesmm

comment created time in an hour

pull request commentapple/swift

[ownership] Implement Interior Pointer handling API for RAUWing addresses

@swift-ci test

gottesmm

comment created time in an hour

PR opened apple/swift

Reviewers
[ownership] Implement Interior Pointer handling API for RAUWing addresses

This PR contains 4 commits all in service of one goal: allowing us to eliminate address_to_pointer, pointer_to_address round trips. This is an important problem to solve since the stdlib uses this pattern to reinterpret cast addresses that point into COW containers. Our emission strategy of small scopes generally makes it so that when we get the underlying address, we create a borrow scope, then address_to_pointer a pointer derived from a ref_element_addr. Later we then cast the pointer to the new address type and then use it for whatever purpose the author intended.

It is important that we be able to convert these to addresses for memory promotion/alias analysis/etc on the stdlib, so this PR introduces a new utility that if necessary will extend the lifetime of the base value that the interior pointer operand is derived from and produce a new access path into the base value that is valid over all uses of the new value. Later passes (CopyPropagation/SemanticARCOpts) will then clean up the ARC and intervening passes can now actually use these addresses without being stymied by the escaping nature of pointer_to_address.


Now in terms of the 4 commits themselves, lets go through each:

  1. The first is hiding simplifyInstruction and changing all callers of it to use a simplifyAndReplace variant instead. Already there was a hidden assumption that simplifyInstruction's result would be passed to replaceAllUsesAndErase, this just eliminates that bug. It also prepares the
  2. OwnershipFixupContext has grown a bit and I want to convert it back to a more context struct that various utilities use. So, I extracted the RAUW methods onto a new helper class called OwnershipRAUWHelper that composes with OwnershipFixupContext.
  3. In this PR, I implemented the actual RAUW API and got everything in place.
  4. In this final API, I let InstSimplify fold identity address_to_pointer/pointer_to_address using this new utility. I also added a bunch of tests that exercise the new API with various CFG patterns (diamonds, loops, etc). Once this lands, I am going to use this to implement other optimizations like this (e.x.: non-identity reinterpret casts).
+755 -169

0 comment

14 changed files

pr created time in an hour

PR closed apple/swift

Reviewers
[inst-simplify] Hide simplifyInstruction in favor of using simplifyAndReplaceAllSimplifiedUsesAndErase

Currently all of these places in the code base perform simplifyInstruction and then a replaceAllSimplifiedUsesAndErase(...). This is a bad pattern since:

  1. simplifyInstruction assumes its result will be passed to replaceAllSimplifiedUsesAndErase. So by leaving these as separate things, we allow for users to pointlessly make this mistake.

  2. I am going to implement in a subsequent commit a utility that lifetime extends interior pointer bases when replacing an address with an interior pointer derived address. To do this efficiently, I want to reuse state I compute during simplifyInstruction during the actual RAUW meaning that if the two operations are split, that is difficult without extending the API. So by removing this, I can make the transform and eliminate mistakes at the same time.

IOW, this is just an NFC in preparation for other changes.

+755 -169

2 comments

14 changed files

gottesmm

pr closed time in 2 hours

pull request commentapple/swift

[inst-simplify] Hide simplifyInstruction in favor of using simplifyAndReplaceAllSimplifiedUsesAndErase

I am actually going to close this and create a new PR since the content has changed a bit.

gottesmm

comment created time in 2 hours

push eventapple/swift

Minhyuk Kim

commit sha 7eaabe1996de119af8c1095ac3028e2b8d0b6b07

Simplify unused lvalue warning wording

view details

David Ungar

commit sha 2ffa369c0d89adaddb1830cf61fff3d089736a5d

Catch conversion failure in Fingerprint

view details

David Ungar

commit sha 7f36ab171b09eee45607f1db8fe6c1e179e1921d

Allow Fingerprint::fromString to fail, returning None on bad input.

view details

David Ungar

commit sha 4c03e67f0b4f163981be4b6db7675b843a607249

fix inputs

view details

David Ungar

commit sha a094afec5413ac4036e2cd8a81318c4cd192d3bf

handle conversion failure differently

view details

David Ungar

commit sha 604978859d1b7afde585feaead663d54d3ea68c1

Show bad fingerprint.

view details

David Ungar

commit sha 2f7fc65a2e6f3468e829fdf37c78690b67665697

mutual runs

view details

David Ungar

commit sha 37e663a3412a2aab588d675d574b3d9ee92cc247

fail-with-bad-deps-fine

view details

David Ungar

commit sha 762e0ea95b341f5edfb5468e17b0ad99016d72b4

chained-private-after-fine

view details

David Ungar

commit sha 3547b3873db252762d7e477cc1a22219b5b5e83c

fail-on-interface-hash-file

view details

David Ungar

commit sha 760d43b8096a20dfe6bc439f4e931b6e4b55ea2a

mutual fine

view details

David Ungar

commit sha d1e6f886d58d573017728736d529cd6caf128fb5

Adapt only-skip-once.swift to work with Swift Driver, too.

view details

David Ungar

commit sha a78cfad40286f7f2a7ee21a31d495e340ba5da6f

Fix the driver unittests

view details

David Ungar

commit sha d913dfe9ac7ad2e94ba090c10c1b7f8f194dc3ce

Check for fromString failure in ModuleFile.cpp

view details

David Ungar

commit sha a64f3f297d46097dfc7e59266eb42845f025b911

Fix Mocking code.

view details

David Ungar

commit sha c9e12d36f77a5251d0aa5567455acf0bee43421c

XFAIL only-skip-once on Windows

view details

David Ungar

commit sha f17ad10cc74de0f257c390fa9ebed13122609360

Fix fingerprint formation for unit driver tests

view details

David Ungar

commit sha dbe4b6df43c3edca0494581515f1ddfa5ed7c88a

Fix fingerprints in unit tests of driver.

view details

Varun Gandhi

commit sha b263e99d718006fbeef0756b1254a5a20f4911bc

Merge pull request #35367 from mininny/simplify-unused-lvalue-wording [Diagnostics] Simplify unused lvalue warning wording

view details

David Ungar

commit sha 0c99379185bcf72560f36a65704175046ac183f7

Merge pull request #35405 from davidungar/fingerprint-assert

view details

push time in 2 hours

push eventapple/swift

David Ungar

commit sha 2ffa369c0d89adaddb1830cf61fff3d089736a5d

Catch conversion failure in Fingerprint

view details

David Ungar

commit sha 7f36ab171b09eee45607f1db8fe6c1e179e1921d

Allow Fingerprint::fromString to fail, returning None on bad input.

view details

David Ungar

commit sha 4c03e67f0b4f163981be4b6db7675b843a607249

fix inputs

view details

David Ungar

commit sha a094afec5413ac4036e2cd8a81318c4cd192d3bf

handle conversion failure differently

view details

David Ungar

commit sha 604978859d1b7afde585feaead663d54d3ea68c1

Show bad fingerprint.

view details

David Ungar

commit sha 2f7fc65a2e6f3468e829fdf37c78690b67665697

mutual runs

view details

David Ungar

commit sha 37e663a3412a2aab588d675d574b3d9ee92cc247

fail-with-bad-deps-fine

view details

David Ungar

commit sha 762e0ea95b341f5edfb5468e17b0ad99016d72b4

chained-private-after-fine

view details

David Ungar

commit sha 3547b3873db252762d7e477cc1a22219b5b5e83c

fail-on-interface-hash-file

view details

David Ungar

commit sha 760d43b8096a20dfe6bc439f4e931b6e4b55ea2a

mutual fine

view details

David Ungar

commit sha d1e6f886d58d573017728736d529cd6caf128fb5

Adapt only-skip-once.swift to work with Swift Driver, too.

view details

David Ungar

commit sha a78cfad40286f7f2a7ee21a31d495e340ba5da6f

Fix the driver unittests

view details

David Ungar

commit sha d913dfe9ac7ad2e94ba090c10c1b7f8f194dc3ce

Check for fromString failure in ModuleFile.cpp

view details

David Ungar

commit sha a64f3f297d46097dfc7e59266eb42845f025b911

Fix Mocking code.

view details

David Ungar

commit sha c9e12d36f77a5251d0aa5567455acf0bee43421c

XFAIL only-skip-once on Windows

view details

David Ungar

commit sha f17ad10cc74de0f257c390fa9ebed13122609360

Fix fingerprint formation for unit driver tests

view details

David Ungar

commit sha dbe4b6df43c3edca0494581515f1ddfa5ed7c88a

Fix fingerprints in unit tests of driver.

view details

David Ungar

commit sha 0c99379185bcf72560f36a65704175046ac183f7

Merge pull request #35405 from davidungar/fingerprint-assert

view details

swift-ci

commit sha b5748f255b7d27742746157d0f6966c8823b34bf

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 2 hours

push eventapple/swift

David Ungar

commit sha 2ffa369c0d89adaddb1830cf61fff3d089736a5d

Catch conversion failure in Fingerprint

view details

David Ungar

commit sha 7f36ab171b09eee45607f1db8fe6c1e179e1921d

Allow Fingerprint::fromString to fail, returning None on bad input.

view details

David Ungar

commit sha 4c03e67f0b4f163981be4b6db7675b843a607249

fix inputs

view details

David Ungar

commit sha a094afec5413ac4036e2cd8a81318c4cd192d3bf

handle conversion failure differently

view details

David Ungar

commit sha 604978859d1b7afde585feaead663d54d3ea68c1

Show bad fingerprint.

view details

David Ungar

commit sha 2f7fc65a2e6f3468e829fdf37c78690b67665697

mutual runs

view details

David Ungar

commit sha 37e663a3412a2aab588d675d574b3d9ee92cc247

fail-with-bad-deps-fine

view details

David Ungar

commit sha 762e0ea95b341f5edfb5468e17b0ad99016d72b4

chained-private-after-fine

view details

David Ungar

commit sha 3547b3873db252762d7e477cc1a22219b5b5e83c

fail-on-interface-hash-file

view details

David Ungar

commit sha 760d43b8096a20dfe6bc439f4e931b6e4b55ea2a

mutual fine

view details

David Ungar

commit sha d1e6f886d58d573017728736d529cd6caf128fb5

Adapt only-skip-once.swift to work with Swift Driver, too.

view details

David Ungar

commit sha a78cfad40286f7f2a7ee21a31d495e340ba5da6f

Fix the driver unittests

view details

David Ungar

commit sha d913dfe9ac7ad2e94ba090c10c1b7f8f194dc3ce

Check for fromString failure in ModuleFile.cpp

view details

David Ungar

commit sha a64f3f297d46097dfc7e59266eb42845f025b911

Fix Mocking code.

view details

David Ungar

commit sha c9e12d36f77a5251d0aa5567455acf0bee43421c

XFAIL only-skip-once on Windows

view details

David Ungar

commit sha f17ad10cc74de0f257c390fa9ebed13122609360

Fix fingerprint formation for unit driver tests

view details

David Ungar

commit sha dbe4b6df43c3edca0494581515f1ddfa5ed7c88a

Fix fingerprints in unit tests of driver.

view details

David Ungar

commit sha 0c99379185bcf72560f36a65704175046ac183f7

Merge pull request #35405 from davidungar/fingerprint-assert

view details

push time in 3 hours

PR merged apple/swift

[Incremental] Catch conversion failure in Fingerprint

When creating a Fingerprint from a string, if the string is not valid hex, information is lost, creating the potential for miscompilation. However, I believe this situation only happens in some tests, for example, Driver/Dependencies/mutual-interface-hash-fine.swift. This change checks for that failure, but it cannot be merged as-is because some tests will (rightly) fail. Before the advent of Fingerprint the swift-dependency-tool would write out the whole string, and thus the tests worked correctly.

To see the failure, try converting the .swift files from before this PR in Driver/Dependencies/Inputs/mutual-interface-hash-fine from yaml to binary and back.

+109 -69

17 comments

34 changed files

davidungar

pr closed time in 3 hours

pull request commentapple/swift

[NFC] Correct contributor’s name

@swift-ci please smoke test and merge

beccadax

comment created time in 3 hours

push eventapple/swift

Minhyuk Kim

commit sha 7eaabe1996de119af8c1095ac3028e2b8d0b6b07

Simplify unused lvalue warning wording

view details

Varun Gandhi

commit sha b263e99d718006fbeef0756b1254a5a20f4911bc

Merge pull request #35367 from mininny/simplify-unused-lvalue-wording [Diagnostics] Simplify unused lvalue warning wording

view details

swift-ci

commit sha fa8155cf4cab79f276237328f2216667247ed4d3

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 3 hours

PR opened apple/swift

[NFC] Correct contributor’s name

@brentdax is now @beccadax. More to come on this.

+1 -1

0 comment

1 changed file

pr created time in 3 hours

push eventapple/swift

Minhyuk Kim

commit sha 7eaabe1996de119af8c1095ac3028e2b8d0b6b07

Simplify unused lvalue warning wording

view details

Varun Gandhi

commit sha b263e99d718006fbeef0756b1254a5a20f4911bc

Merge pull request #35367 from mininny/simplify-unused-lvalue-wording [Diagnostics] Simplify unused lvalue warning wording

view details

push time in 3 hours

PR merged apple/swift

[Diagnostics] Simplify unused lvalue warning wording

<!-- What's in this pull request? --> Cases like

func f() {
  var a: Int = 1
  a // warning: expression resolves to an unused variable
}

currently (on main) it produces a "expression resolves to an unused variable" diagnostic which as discussed here is a bit jargon-heavy. So the idea is to improve the wording for this diagnostic expression_unused_lvalue

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-14022.

I changed it to: function is unused, result of variable/property/subscript is unused to match other diagnostics.

Please let me know if you think there are more suitable alternatives to this one 😄

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+33 -28

1 comment

11 changed files

mininny

pr closed time in 3 hours

issue commentbazelbuild/bazel

bazel links program using clang rather than clang++, incompatible with -fsanitize=undefined (UBSan)

bazel currently compiles through the base clang/gcc driver and doesn't support the c++ drivers of these commands, bazel c++ toolchains generally have to be explicit about any implicit c++ stuff that would otherwise happen when you use the c++ drivers for clang/gcc.

if you run -v on your invocation with clang++ you'll probably see something like --whole-archive /usr/lib/clang/11.0.0/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.a --no-whole-archive --dynamic-list=/usr/lib/clang/11.0.0/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.a.syms

you effectively need to do this manually in your toolchain (or via --linkopts, or via the linkopts rule attributes), afaik this is a known limitation of the toolchain design, the link invocation is also always assumed to be c++ which isn't great but is typically benign because c code won't emit any references to c++ symbols.

trittweiler

comment created time in 3 hours

startednetworkimprov/mnm

started time in 3 hours

startednetworkimprov/mnm-hammer

started time in 3 hours

startedAnnex-Engineering/Sherpa_Mini-Extruder

started time in 3 hours

Pull request review commentapple/swift

[DiagnosticsQol] Restore optionality in IUO redeclared functions

 ERROR(reserved_member_name,none,       "type member must not be named %0, since it would conflict with the"       " 'foo.%1' expression", (DeclName, StringRef)) -ERROR(invalid_redecl_by_optionality,none,-      "invalid redeclaration of %0 which differs only by the kind of optional passed as an inout argument (%1 vs. %2)",-      (DeclName, Type, Type))+NOTE(invalid_redecl_by_optionality_note,none,+      "parameter with %select{implicitly unwrapped |}0optional type is not different "

Ah yeah, that totally makes sense, I thought this message would totally need to be replaced by something even more simpler. Thanks for the suggestion, so the new message then would be: parameter with implicitly unwrapped optional is same as original optional parameter @xwu

so5462

comment created time in 4 hours

PR opened apple/swift-tools-support-core

[PkgConfig] Add checks for circular dependencies

Some libraries form dependency cycles such as freetype and harfbuzz on Arch Linux. This PR tries to avoid cycles by tracking pkg-config packages dependencies and detecting two occurences of a same library in the same branch.

+25 -3

0 comment

1 changed file

pr created time in 4 hours

fork msanders/homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries

https://brew.sh

fork in 5 hours

startedFlank/flank

started time in 5 hours

startedsindresorhus/Preferences

started time in 5 hours

more