profile
viewpoint
Karthik Nadig karthiknadig @Microsoft Redmond Developer at Microsoft, working on VS Code Python and Python Debugger.

karthiknadig/ArduinoFIS 2

Matlab FIS files to *.c converter.

karthiknadig/corefx 0

This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.

karthiknadig/cpython 0

The Python programming language

karthiknadig/debugpy 0

An implementation of the Debug Adapter Protocol for Python

karthiknadig/DirectXMath 0

DirectXMath is an all inline SIMD C++ linear algebra library for use in games and graphics apps

karthiknadig/django_barcode_sample 0

Sample Django app that generates SVG barcode images using EAN13 or EAN8 format.

karthiknadig/FileMeta 0

Enable Explorer in Vista, Windows 7 and later to see, edit and search on tags and other metadata for any file type

push eventkarthiknadig/vscode-python

Eric Snow

commit sha 37b83bea0b039a5d78dc64c410535d1f797f6178

Implement the high-level component API. (#13853) This is where we define the top-level interface for the component. We also stub out our use of the component in the legacy IOC code. This is a prerequisite for using the injected component adapter in the extension.

view details

Kim-Adeline Miguel

commit sha b21b2e1cf46586605a5ab1da49452b2fcea11df6

Virtualenv locator (#13893) * Add virtualenv locator * Tests * Use stub.resolves() instead of stub.callsFake()

view details

Kartik Raj

commit sha 40bc21cb025d6e12ed5a4f73428cc32cadbeeb7f

Add API to identify pipenv (#13762) * Add helpers for pipenv * Add error message * oOpS * Reverting regex approach

view details

Eric Snow

commit sha bc9cd8bc8982981342740631c57fd222c2a62890

Add an optional onUpdated event to the iterator returned by ILocator.iterEnvs(). (#13950) In order to ensure that ILocator.iterEnvs() can finish as fast as possible, we add a side-channel event for each iteration. This event fires any time an already-yielded env info object is updated (e.g. reduced/merged or resolved/completed). The update only relates to operations triggered by that particular iteration. ILocator.onChanged remains separate and only relates to when the locators finds a new env, notices one was removed, or that one was otherwise fundamentally changed. There are two similar approaches we could take for this update event. Either we added the event as a property of IPythonEnvsIterator or we change the return value of ILocator.iterEnvs() to be a 2-tuple ([PythonEnvsIterator, Event<PythonEnvUpdatedEvent>]). We took the property approach since most of the time callers won't need to worry about the update events.

view details

Ian Huff

commit sha f687921060f62f7aa868a7cfd406650a35e4185c

fully bump raw kernel (#13941) Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com>

view details

Kim-Adeline Miguel

commit sha 64c852694bbd52045e9cff8b1bf9d151222dd951

Virtualenvwrapper locator (#13895) * virtualenvwrapper locator * skip os-specific tests * Test getDefaultVirtualenvwrapperDir * Update src/client/pythonEnvironments/discovery/locators/services/virtualenvwrapperLocator.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * add pathExists check to WORKON_HOME dir * Change how the locator works + move util func out * Fix functional tests * utils unit tests * Update locator tests * Stub getUserHomeDir instead of getDefaultetc Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

view details

Karthik Nadig

commit sha a9b560369d79fd375eb9413f42ec1166ee3ca73c

Clean up eslint errors (#13951) * Clean up eslint errors * Fix linting and address comments.

view details

Eric Snow

commit sha 016cce8b78485f196735af4a2547d4a02c404b7b

Add a legacy DI adapter for the Python envs component. (#13858) This allows us to start using the new discovery code in the extension.

view details

Don Jayamanne

commit sha 7b3b5414825b52ad7e561e64ac6972cd10922cc5

Extension api for DataScience (#13923) * Extension API * Api for DS

view details

Ian Huff

commit sha a7c3b7f4be500344cfc3e3ab02ac4a0a7bf1e817

Fix installing ipykernel into interpreters for raw kernel (#13959)

view details

Rich Chiodo

commit sha 89b47a06d617dc8e5582c21e5ebb0e9eae615787

Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry

view details

Don Jayamanne

commit sha 7a86cf0ebbd43fed810381dd3356819be9cb92b0

Extension API to return path to debugpy for DS (#13973)

view details

push time in 12 hours

push eventkarthiknadig/vscode-python

Karthik Nadig

commit sha d9a290aafe007330cea60e05eacf4057a41e85e7

Use some instead of find

view details

push time in 12 hours

issue closedmicrosoft/vscode-python

Conda env defined $PYTHONPATH is ignored - breaks pylint, refactoring,...

Issue Type: <b>Bug</b>

I set up Code Studio to use a conda environment called LMCrypto for my project.

Here is the content from settings.json that was generated by selecting the environment from the bottom left blue status line:

(LMCrypto)# cat ../.vscode/settings.json { "python.pythonPath": "/Users/fdetienn/anaconda3/envs/LMCrypto/bin/python" }

This environment contains a PYTHONPATH:

(LMCrypto)# echo $PYTHONPATH /Users/fdetienn/Documents/Programming/LazyMaestro/standalone/lmcrypto

When CodeStudio runs pylint (upon saving the file), all the import for my own modules are underlined in red with a pylint-import error .

When I run pylint from a terminal (including in code studio's terminal), pylint properly detects the import path from PYTHONPATH.

I.e. the problem only appears when Code Studio runs pylint on its own.

Seemingly, code refactoring is also broken.

This was working nicely before my vacation and seems to have appeared with the latest upgrade.

Extension version: 2020.8.109390 VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T17:39:53.251Z) OS version: Darwin x64 19.6.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: enabled<br>opengl: enabled_on<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.10GB free)
Process Argv
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 13 hours

TotallyFred

issue commentmicrosoft/vscode-python

Conda env defined $PYTHONPATH is ignored - breaks pylint, refactoring,...

We have not changed those settings or added new ones. So i am not sure what went wring there. You can see the issues with conda and terminal here: #5344 #4568

TotallyFred

comment created time in 13 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue closedmicrosoft/vscode-python

Debugging starts before conda environment is activated

Issue Type: <b>Bug</b>

VSCode starts debugging before activating the conda environment on the Python Debug console, which breaks the code.

Extension version: 2020.8.109390 VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z) OS version: Windows_NT x64 10.0.18363

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 15.92GB (8.35GB free)
Process Argv --folder-uri file:///d%3A/Dev/easypallet-ai/easypallet_ai
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 15 hours

lbaiao

Pull request review commentmicrosoft/vscode-python

Extension API to return path to debugpy for DS

 export class JupyterExtensionIntegration {                 product: Product,                 resource?: InterpreterUri,                 cancel?: CancellationToken-            ): Promise<InstallerResponse> => this.installer.install(product, resource, cancel)+            ): Promise<InstallerResponse> => this.installer.install(product, resource, cancel),+            getDebuggerPath: async () => join(EXTENSION_ROOT_DIR, 'pythonFiles', 'lib', 'python')
            getDebuggerPath: async () => dirname(getDebugpyPackagePath())

Just a suggestion, since this will ensure you get the parent directory of where debugpy is. This way if we do move it as we decide to support more wheels types (this was in the some discussions) this will continue to work across the DS split.

DonJayamanne

comment created time in 15 hours

PullRequestReviewEvent

issue commentmicrosoft/vscode-python

Conda env defined $PYTHONPATH is ignored - breaks pylint, refactoring,...

Try these steps when working with conda. We have some know issues with conda due to limitation in conda itself and VS Code:

  1. Turn off auto activation. To do this, disable these two settings, ideally only for the project you are working on: image
  2. Exit VS Code.
  3. Open Anaconda Prompt, navigate to your project.
  4. Activate the environment that you want.
  5. Run code . or code project.code-workspace to launch VS Code.

This will give you an activate environment, and the extension will not have to try and activate every time a terminal is created.

TotallyFred

comment created time in 17 hours

issue commentmicrosoft/vscode-python

Debug problem

This is a known issue with activating conda. This occurs due to some limitation we have with the VS Code and conda activation. Here is a workaround for this:

  1. Turn of auto activation. To do this, disable these two settings, ideally only for the project you are working on: image
  2. Exit VS Code.
  3. Open Anaconda Prompt, navigate to your project.
  4. Activate the environment that you want.
  5. Run code . or code project.code-workspace to launch VS Code.

This will give you an activate environment, and the extension will not have to try and activate every time a terminal is created.

lbaiao

comment created time in 17 hours

issue closedmicrosoft/vscode-python

Use Python Poetry for package management and virtualenv management

Since pipenv is able to be used, I would also like to have the ability to use poetry as a virtualenv management and package management tool.

  • https://python-poetry.org

closed time in 17 hours

FilBot3

issue commentmicrosoft/vscode-python

Use Python Poetry for package management and virtualenv management

Duplicate of #8372

FilBot3

comment created time in 17 hours

issue closedmicrosoft/vscode-python

${workspaceFolder} does not work in .env file

Environment data

  • VS Code version: 1.49.0
  • Extension version (available under the Extensions sidebar): 2020.8.109390
  • OS and version: Ubuntu 20.04 LTS running on WSL2 under Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): Vanialla Python 3.8.2 64 bit from Ubuntu repo
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): none
  • Value of the python.languageServer setting: Jedi

Expected behaviour

I have set the PYTHONPATH environment variable in the .env file located in the root of my project workspace. That is working fine in the editor, all Python packages that should be found in the folders specified via PYTHONPATH can be found. One of these folders is a sub directory under my project root, so I replaced that part with ${workspaceFolder} in the .env file. As soon as I do so and restart VS Code the Python packages in that folder are not found in the editor any more.

I double-checked the value that I set for the PYTHONPATH variable, in fact I use the very same value I also use in the launch config, where ${workspaceFolder} works just fine. It's just not working in the .env file. I have expected this variable would work there as well.

Actual behaviour

As described above, using ${workspaceFolder} in the .env file does not work. Is this a bug or a feature?

closed time in 17 hours

haimat

issue commentmicrosoft/vscode-python

${workspaceFolder} does not work in .env file

@haimat This is by design. ${workspaceFolder} is not an environment variable, it is supported only by VS Code in the json files that it works with. .env files are meant to work outside of VS Code.

haimat

comment created time in 17 hours

issue commentmicrosoft/vscode-python

Interpreter path shows Windows path in a Remote-WSL workspace

@Tyriar is there a settings.json with python.pythonPath in it?

Tyriar

comment created time in 17 hours

Pull request review commentmicrosoft/vscode-python

Clean up eslint errors

 export class WorkspaceLocators extends Locator {  * or the URI must be a parent of one of the candidates.  */ function matchURI(uri: Uri, ...candidates: Uri[]): boolean {-    const uriPath = uri.path.endsWith('/') ? uri.path : `{uri.path}/`;-    for (const candidate of candidates) {+    const uriPath = uri.path.endsWith('/') ? uri.path : '{uri.path}/';+    const matchedUri = candidates.find((candidate) => {         if (candidate.scheme === uri.scheme) {             if (candidate.path === uri.path) {                 return true;-            } else if (candidate.path.startsWith(uriPath)) {+            } if (candidate.path.startsWith(uriPath)) {                 return true;             }         }-    }-    return false;+        return false;+    });+    return matchedUri !== undefined;

Will make this change in the next eslint PR.

karthiknadig

comment created time in 17 hours

PullRequestReviewEvent

push eventmicrosoft/vscode-python

Karthik Nadig

commit sha a9b560369d79fd375eb9413f42ec1166ee3ca73c

Clean up eslint errors (#13951) * Clean up eslint errors * Fix linting and address comments.

view details

push time in a day

PR merged microsoft/vscode-python

Clean up eslint errors skip news
+145 -124

2 comments

7 changed files

karthiknadig

pr closed time in a day

PullRequestReviewEvent

push eventkarthiknadig/vscode-python

Kartik Raj

commit sha 40bc21cb025d6e12ed5a4f73428cc32cadbeeb7f

Add API to identify pipenv (#13762) * Add helpers for pipenv * Add error message * oOpS * Reverting regex approach

view details

Eric Snow

commit sha bc9cd8bc8982981342740631c57fd222c2a62890

Add an optional onUpdated event to the iterator returned by ILocator.iterEnvs(). (#13950) In order to ensure that ILocator.iterEnvs() can finish as fast as possible, we add a side-channel event for each iteration. This event fires any time an already-yielded env info object is updated (e.g. reduced/merged or resolved/completed). The update only relates to operations triggered by that particular iteration. ILocator.onChanged remains separate and only relates to when the locators finds a new env, notices one was removed, or that one was otherwise fundamentally changed. There are two similar approaches we could take for this update event. Either we added the event as a property of IPythonEnvsIterator or we change the return value of ILocator.iterEnvs() to be a 2-tuple ([PythonEnvsIterator, Event<PythonEnvUpdatedEvent>]). We took the property approach since most of the time callers won't need to worry about the update events.

view details

Ian Huff

commit sha f687921060f62f7aa868a7cfd406650a35e4185c

fully bump raw kernel (#13941) Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com>

view details

Karthik Nadig

commit sha bb22b9acebc6a12f1741516b50401dab355e7560

Clean up eslint errors

view details

Karthik Nadig

commit sha 4f2c975206c528621466ea1843a84185cc14ec65

Fix linting and address comments.

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-python

Clean up eslint errors

 export class WorkspaceLocators extends Locator {  * or the URI must be a parent of one of the candidates.  */ function matchURI(uri: Uri, ...candidates: Uri[]): boolean {-    const uriPath = uri.path.endsWith('/') ? uri.path : `{uri.path}/`;-    for (const candidate of candidates) {+    const uriPath = uri.path.endsWith('/') ? uri.path : '{uri.path}/';+    const matchedUri = candidates.find((candidate) => {         if (candidate.scheme === uri.scheme) {             if (candidate.path === uri.path) {                 return true;-            } else if (candidate.path.startsWith(uriPath)) {+            } if (candidate.path.startsWith(uriPath)) {                 return true;             }         }-    }-    return false;+        return false;+    });+    return matchedUri !== undefined;

@kimadeline can help with that 😊.

karthiknadig

comment created time in 2 days

PullRequestReviewEvent

PR opened microsoft/vscode-python

Reviewers
Clean up eslint errors
+149 -119

0 comment

7 changed files

pr created time in 2 days

push eventkarthiknadig/vscode-python

Karthik Nadig

commit sha ffffb6ddf48e733bd4179f6eb1dd793285d173f6

Clean up eslint errors

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-python

Add a legacy DI adapter for the Python envs component.

 import {     WorkspaceVirtualEnvService, } from './discovery/locators/services/workspaceVirtualEnvService'; import { WorkspaceVirtualEnvWatcherService } from './discovery/locators/services/workspaceVirtualEnvWatcherService';+import { GetInterpreterLocatorOptions } from './discovery/locators/types';+import { EnvironmentType, PythonEnvironment } from './info'; import { EnvironmentInfoService, IEnvironmentInfoService } from './info/environmentInfoService'; -import { PythonEnvironments } from '.';+function convertEnvInfo(info: PythonEnvInfo): PythonEnvironment {+    const {+        name,+        location,+        executable,+        arch,+        kind,+        searchLocation,+        version,+        distro,+    } = info;+    const { filename, sysPrefix } = executable;+    const env: PythonEnvironment = {+        sysPrefix,+        envType: EnvironmentType.Unknown,+        envName: name,+        envPath: location,+        path: filename,+        architecture: arch,+    }; -export const IComponentAdapter = Symbol('IComponentAdapter');-export interface IComponentAdapter {-    // We will fill in the API separately.+    if (kind === PythonEnvKind.System) {+        env.envType = EnvironmentType.System;

We need a task to clean up these, we have too many intermediate types like EnvironmentType and PythonEnvKind. We just need one.

Also, instead of a if-ladder this could be done with a map for a cleaner approach.

ericsnowcurrently

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentmicrosoft/vscode-python

Isolate script removes wrong entry from sys.path

remove both these entries while isolating:

'', 
'C:\\Users\\Karthik Nadig\\.vscode\\extensions\\ms-python.python-2020.8.109390\\pythonFiles', 
karthiknadig

comment created time in 2 days

issue closedmicrosoft/debugpy

Conditional breakpoint is still triggered when expression value is false

<!-- Please search existing issues to avoid creating duplicates. -->

Environment data

  • VS Code version: 1.48.2
  • Extension version (available under the Extensions sidebar): python v2020.8.106424
  • OS and version: windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): python 3.8.5-64bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Value of the python.languageServer setting: pylance

Expected behaviour

when the expression value is false, debug will skip the breakpoint and it won't be triggered

Actual behaviour

even though the expression value is false, the breakpoint is still triggered image

Steps to reproduce:

I have following two python files in the same directory: main.py

from module import f1
f1()

module.py

import traceback
def f1():
    print('f1')
    print(traceback.extract_stack()[-1].filename)
    print(traceback.extract_stack()[-2].filename)
    f2()

def f2():
    print('f2')
    print(traceback.extract_stack()[-1].filename)
    print(traceback.extract_stack()[-2].filename)

I started VSCode in the directory and set conditional breakpoints with following expression : traceback.extract_stack()[-2].filename != traceback.extract_stack()[-1].filename on the first print statement in f1() and f2().

Logs

The running of main.py printed out :

f1
c:\Users\...\tmp\pythonTest-breakpoint\module.py
c:\Users\...\tmp\pythonTest-breakpoint\main.py
f2
c:\Users\...\tmp\pythonTest-breakpoint\module.py
c:\Users\...\tmp\pythonTest-breakpoint\module.py

Both breakpoints are triggerred. Why the breakpoint in f2() get triggerred whereas the condition is not met ?

closed time in 2 days

molly-w

issue commentmicrosoft/debugpy

Conditional breakpoint is still triggered when expression value is false

Every time you call traceback.evaluate_stack() is called stack that it returns is re-built based on the location where it is called. So, the print wont change because the context of calling traceback.evaluate_stack() is the f1/f2 function module.py file. When you use traceback.evalaute_stack() in a condition, it is evaluated in the context of this file https://github.com/microsoft/debugpy/blob/44b01c81657f21ed12632317e15bd368e6d516ab/src/debugpy/_vendored/pydevd/pydevd.py#L733-L742 . Think about it like this, when a condition is tested, traceback.evaluate_stack() will be called in handle_breakpoint_condition inside pydevd.py. So the stack you get when doing condition evaluations is different from when it is called in module.py.

The change I recommended was to do stack = traceback.evaluate_stack() in module.py and use 'stack' (local variable) in the condition. This way, when testing for condition we don't re-evaluate the stack, and will use the stack value as it would be in the context where you expect it to be.

If this does not answer your question, I recommend asking this on stackoverflow.

molly-w

comment created time in 2 days

issue openedmicrosoft/vscode-python

Isolate script removes wrong entry from sys.path

In some cases sys.path looks like this:

[
'C:\\opt\\ros\\noetic\\x64\\python38.zip',  // we remove this entry
'C:\\opt\\ros\\noetic\\x64', 
'C:\\Users\\Karthik Nadig\\AppData\\Roaming\\Python\\Python38\\site-packages', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages', 
'', 
'C:\\Users\\Karthik Nadig\\.vscode\\extensions\\ms-python.python-2020.8.109390\\pythonFiles',
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\win32', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\win32\\lib', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\Pythonwin'
]

After isolation it looks like this:

[
'c:\\Users\\Karthik Nadig\\.vscode\\extensions\\ms-python.python-2020.8.109390\\pythonFiles\\.does-not-exist',
'C:\\opt\\ros\\noetic\\x64', 
'C:\\Users\\Karthik Nadig\\AppData\\Roaming\\Python\\Python38\\site-packages', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages', 
'', 
'C:\\Users\\Karthik Nadig\\.vscode\\extensions\\ms-python.python-2020.8.109390\\pythonFiles', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\win32', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\win32\\lib', 
'C:\\opt\\ros\\noetic\\x64\\lib\\site-packages\\Pythonwin'
]

When really it should be:

[ 'c:\Users\Karthik Nadig\.vscode\extensions\ms-python.python-2020.8.109390\pythonFiles\.does-not-exist', 'C:\opt\ros\noetic\x64\python38.zip', 'C:\opt\ros\noetic\x64', 'C:\Users\Karthik Nadig\AppData\Roaming\Python\Python38\site-packages', 'C:\opt\ros\noetic\x64\lib\site-packages', '', 'C:\opt\ros\noetic\x64\lib\site-packages\win32', 'C:\opt\ros\noetic\x64\lib\site-packages\win32\lib', 'C:\opt\ros\noetic\x64\lib\site-packages\Pythonwin' ]

created time in 2 days

issue commentmicrosoft/debugpy

Conditional breakpoint is still triggered when expression value is false

This is because when the condition is evaluated, it is evaluated in the debugger, so the value of traceback.extract_stack() will be different there. But when you call print(traceback.extract_stack()). The stack trace would be calculated at the point where print is called. The location where that traceback.extract_stack() gets called is why you get different answers. To make this work right you could do this:

import traceback
def f1():
    stack = traceback.extract_stack()
    print('f1')
    print(traceback.extract_stack()[-1].filename)
    print(traceback.extract_stack()[-2].filename)
    f2()

def f2():
    stack = traceback.extract_stack()
    print('f2')
    print(traceback.extract_stack()[-1].filename)
    print(traceback.extract_stack()[-2].filename)

Use this as the condition: stack[-2].filename != stack[-1].filename

molly-w

comment created time in 2 days

issue commentmicrosoft/debugpy

Conditional breakpoint is still triggered when expression value is false

Using traceback.extract_stack() as a breakpoint condition might lead to this. At the point where we evaluate breakpoint condition, the stacks will show debugger internal frames. So you will get different results there. image

molly-w

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Virtualenvwrapper locator

 suite('Environment Identifier', () => {             assert.deepEqual(envType, EnvironmentType.Venv);         });     });++    suite('Virtualenvwrapper', () => {+        const homeDir = platformApis.getUserHomeDir() || path.join('path', 'to', 'home');++        let getEnvVarStub: sinon.SinonStub;+        let getOsTypeStub: sinon.SinonStub;+        let pathExistsStub:sinon.SinonStub;++        suiteSetup(() => {+            getEnvVarStub = sinon.stub(platformApis, 'getEnvironmentVariable');+            getOsTypeStub = sinon.stub(platformApis, 'getOSType');+            pathExistsStub = sinon.stub(fileApis, 'pathExists');

I think stubbing the environment variable code is fine. The high level logic is about searching for various locations. Those locations are based on user defined environment settings. Those settings will be exposed to the extension via environment variables. So it is ok to make them return a different answer. Ideally, we would be changing the environment variable itself when we launch the test, The next best thing is stubbing getEnvironmentVariable.

kimadeline

comment created time in 3 days

PullRequestReviewEvent

issue commentmicrosoft/debugpy

Debug runs thru breakpoint

@ZenonH Please share the logs. You can turn on logging by setting logToFile: true.

ZenonH

comment created time in 3 days

issue commentmicrosoft/debugpy

Debugger works with one Python interpreter, but not with another?

@ZenonH Please share the logs if possible. You can do this by setting logToFile: true in the launch.json.

ZenonH

comment created time in 3 days

issue commentmicrosoft/vscode-python

Rope refactoring is failing after reading third party files from `node_modules`

When you use rope for the first time in a project, it will create this folder. This is where you would put any configuration for rope. image

amw

comment created time in 3 days

push eventkarthiknadig/vscode-python

Don Jayamanne

commit sha 9169202f6bb84954c4e3acbd64c203b8c7b7c98d

Provide an id for native notebook kernels returned to VSCode (#13742)

view details

Kartik Raj

commit sha 648952899d5f067f2156e9ce8b8a003e5bc26c7e

Show a general warning prompt pointing to the upgrade guide when users attempt to run isort5 using deprecated settings (#13717) * Show a general warning prompt pointing to the upgrade guide when users attempt to run isort5 using deprecated settings * Code reviews

view details

Ian Huff

commit sha 2b007d1331e45d4c7e4a9813b666bbf60566bb53

remove unused imports from test files (#13743) Co-authored-by: Ian Huff <ianhuff@AAULMER-DT1.redmond.corp.microsoft.com>

view details

Rich Chiodo

commit sha 04e9a9c7d275ce223191ea489814c93760e6ff47

Up idle timeout to match launch timeout (nightly flake failure) (#13753) * Up idle timeout to match launch timeout. Test was really close to 30 secs so it failed * Up launch time out

view details

Kim-Adeline Miguel

commit sha 6b2fd3238342a3a40c78e4e33538d9be3f6dd7a4

ESLint update: Add new files to eslintignore + rename file (#13746) * Add new files to eslintignore + rename file * Why didn't it delete this file ugh * 🐢🐢🐢🐢

view details

Eric Snow

commit sha 6a3db719c847a955fbb7e293c0afd6d3925925de

Add the base Python environments "watchers". (#13735) Watchers are the event-based part of locators.

view details

Don Jayamanne

commit sha ff7517985332bdf280c2428e6fe28dca3a2e1db6

Ignore dependency check when finding a kernel spec (#13761) * Ignore dependency check when finding a kernel spec * Fix tests

view details

Don Jayamanne

commit sha 9d466bc61144413ac8f96a329c10e9d95b777c8d

Fixes to preferred kernels in Native Notebooks (#13765)

view details

Don Jayamanne

commit sha 687363d9d193e6012f4f29956a3051dfed18c249

Hide Interpreter status bar when opening a Jupyter notebook (#13767)

view details

Don Jayamanne

commit sha f5ab6989048481c835c84dc7c6e638b1b900a45c

Replace `newNotebook` with `notebookEditor` in commands (#13772)

view details

Mojtaba Samimi

commit sha 0b466784af4e8e3a82a19f6a7acd85bed533cb83

bump plotly.js-dist at v1.55.1 (#13774)

view details

Ian Huff

commit sha 88c2708d9120c8a3209aada4c43f22445a918bbc

WebViewHost => WebviewPanelHost WebView => WebviewPanel refactor (#13773)

view details

Karthik Nadig

commit sha 37ff6cb08dca3ab5482a276c239232a69c2b5539

Fix Eslint in legacyIOc (#13757)

view details

Eric Snow

commit sha 329292c120490bdef69eaa6bc0997b4fd00beba8

Add the base Python envs locators. (#13764)

view details

Eric Snow

commit sha 2acf014c49ccd1261f45169a77c797aa4ae406ec

Disable the "Interpreters - Workspace VirtualEnv Service" standard tests. (#13784)

view details

Brett Cannon

commit sha fb797a3ae5d4c14603c53e311ad182b657dc93dd

Remove uses of "master" (#13646)

view details

Karthik Nadig

commit sha f41bef94451cb78a4d0eb01664d6c88e3eb762b8

Add APIs needed by windows store locator (#13740) * Initial commit * Add tests

view details

Don Jayamanne

commit sha 49f160af087a995223c4856deb730fa1c0747b96

All languages in native notebooks, default Python (#13786) * All languages in native notebooks, default Python * Fix tests

view details

Ian Huff

commit sha 23725abd4249811f24475e215c2d78ed5e508e79

IPyKernel install issue with windows paths (#13667) * Both changes * remove args change * Remove logging message * Add news * remove logMessage imports * Update python.ts * Fix unit tests * Actually fix the unit tests Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com>

view details

Don Jayamanne

commit sha f1e4fed3aedcbaa2932928f03a11b5c77cd9536c

Store kernel info into ipynb only when saving (#13787)

view details

push time in 3 days

pull request commentmicrosoft/debugpy

Fix issues in bytecode generation on frame eval mode. Fixes #346

This can be merged. bytecode has been approved. Once this is check in we need to update the TPN with:

---------------------------------------------------------

vstinner/bytecode e3e77fb690ed05ac171e15694e1c5d0e0dc34e86 - MIT


Copyright (c) 2016 Red Hat.

The MIT License (MIT)
Copyright (c) 2016 Red Hat.

Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.


---------------------------------------------------------
fabioz

comment created time in 3 days

issue commentmicrosoft/vscode-python

Rope refactoring is failing after reading third party files from `node_modules`

@amw This might be something that should be filed on rope. We invoke rope directly, so we don't control how rope looks at the files in the workspace.

amw

comment created time in 3 days

issue commentmicrosoft/vscode-python

Unresponsive

@LuciferSamuelMoringstar Looks like this was from javascript extension, and not python based on the extension ID. This repo is for python extension.

LuciferSamuelMoringstar

comment created time in 3 days

issue closedmicrosoft/vscode-python

Unresponsive

  • Issue Type: Bug
  • Extension Name: python
  • Extension Version: 2020.8.108011
  • OS Version: Windows_NT x64 10.0.19042
  • VSCode version: 1.49.0

:warning: We have written the needed data into your clipboard. Please paste! :warning:

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 624,
		"activateCallTime": 41,
		"activateResolvedTime": 1,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "ms-vscode.js-debug",
				"_lower": "ms-vscode.js-debug"
			},
			"activationEvent": "onDebugInitialConfigurations"
		}
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": "Can't find Node.js binary \"node\": path does not exist. Make sure Node.js is installed and in your PATH, or set the \"runtimeExecutable\" in your launch.json"
		},
		{
			"name": "Error",
			"message": "Can't find Node.js binary \"node\": path does not exist. Make sure Node.js is installed and in your PATH, or set the \"runtimeExecutable\" in your launch.json"
		},
		{
			"name": "Error",
			"message": "Can't find Node.js binary \"node\": path does not exist. Make sure Node.js is installed and in your PATH, or set the \"runtimeExecutable\" in your launch.json"
		},
		{
			"name": "Error",
			"message": "Can't find Node.js binary \"node\": path does not exist. Make sure Node.js is installed and in your PATH, or set the \"runtimeExecutable\" in your launch.json"
		}
	]
}

closed time in 3 days

LuciferSamuelMoringstar

fork karthiknadig/FileMeta

Enable Explorer in Vista, Windows 7 and later to see, edit and search on tags and other metadata for any file type

fork in 3 days

push eventkarthiknadig/vscode-python

Brett Cannon

commit sha a1c40781ff1a9f37726c84ad2095bcbbcde605e4

Add the "skip news" entry for some dependabot PRs (#13897)

view details

David Kutugata

commit sha ea59b9f7f8fa68336cbc7dccd50dfeb5284d5a87

removed experiment code and extra setting (#13900) * removed experiment code and extra setting * display the kernel picker if the kernel is not local

view details

Karthik Nadig

commit sha a62890cd032baf0dd64da06b8f9dc8db2ec4640f

Merge back from release (#13925) * Port gather survey and icon getting disabled while gathering (#13296) * Add gather status bar and update survey link (#13225) * add status bar * add localization * Added news file * add a 2 second timeout * updated the gather survey link * Change the gather icon while gathering * moved the gathering redux function to interactive common added a constant * move css to common.css * removed the status bar message * changed noop import * update changelog * Disable test (#13346) (#13350) Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348) * Add Goto Prev/Next Cell * Add goto previous cell * Remove unneeded changes * Add default keybindings for cell commands * Goto should be Go to Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Jim Griesmer <jimg@live.com> * Autoscroll when extending cell select (#13353) (#13354) Code change can only affect new keyboard shortcut operations * Update Release branch for August Release (#13401) * update version number and npm install to update package-lock.json * update changelog version and date * update news for changelog.md * update generated TPN Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> * Update version and change log for bug fix release (#13537) * Update LSP to latest to resolve problems with LS settings (#13511) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Update LSP to fix issue with settings in MPLS v1 * Add telemetry for `switch to Pylance` acceptance (#13526) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Initial * Add test * PR feedback * Rename property * Rename constant * Define property * Moar rename * casing * Update version and changelogs * Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544) * Update change log with more cherry picks Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> * Update changelog and version for point release. (#13610) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Change date. * Format using latest black (#13625) Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Skip flaky virtual env tests (#13650) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Skip workspace virtual env service tests * Add link to issue for skipping Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Cherry picks, change log, and version update for point release. (#13666) * Add install telemetry (#13653) * Add extension install telemetry. * Add tests. * Fix typo * Fix tests. * Update comment to reflect what the installed actually does. * Update change log and version for point release. * Cherry pick history bug for Azure ML CI && Make Jupyter server clickable (#13712) * Fix: Getting an error on selecting an existing CI which has a display name from the historical CI's in the quick picks (#13642) * Make Jupyter Server name clickale to select Jupyter server (#13657) * Update Changelog and remove news files * Update package version. (#13748) * Update and pin LSP libraries for new APIs (#13725) (#13756) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * PORT showStartPage setting fix (#13706) (#13758) * fix showStartPage setting on configSettings.ts (#13706) * fix showStartPage setting on configSettings.ts * add news file * Fix unit tests * oops * update changelog * Fixes for point release (#13841) * Use 'main' branch for experiments. * Update changelog and versions * Update CHANGELOG.md * Replace 'master' with 'main' in readme (#13845) Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

view details

David Kutugata

commit sha 411aae964b0ccce1d05d845fed389f9c0e1a7933

RC (#13929)

view details

David Kutugata

commit sha 68253d0f4334a4d8b8f48314ddd3ef07a6f981a9

update version (#13931)

view details

push time in 3 days

pull request commentmicrosoft/vscode-python

Up release version for new release

You still have to edit the release manually. We will b fixing that after we migrate the release to github actions

rchiodo

comment created time in 3 days

PullRequestReviewEvent

pull request commentmicrosoft/vscode-python

Up release version for new release

Just update the change log with a news entry saying this:

2020.8.6 (14 September 2020)

Fixes

  1. Update version number to force a re-download of experiments file.
rchiodo

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Add API to identify pipenv

+import * as assert from 'assert';
+import * as path from 'path';
+import * as sinon from 'sinon';
+import * as platformApis from '../../../../client/common/utils/platform';
+import * as externalDependencies from '../../../../client/pythonEnvironments/common/externalDependencies';
+import { _getAssociatedPipfile, isPipenvEnvironment, isPipenvEnvironmentRelatedToFolder } from '../../../../client/pythonEnvironments/discovery/locators/services/pipEnvHelper';
+
+suite('Pipenv helper', () => {
+    suite('Method isPipenvEnvironmentRelatedToFolder()', async () => {
+        let readFile: sinon.SinonStub;
+        let getEnvVar: sinon.SinonStub;
+        let pathExists: sinon.SinonStub;
+        let arePathsSame: sinon.SinonStub;

This makes assumptions about how path is used internally. We don't care about that. The test itself lets say use pathModule.posix, in the actual function (say running on windows) uses path that deals with it like pathModule.win32. How does that help? In either case, why should the test case what behavior the function has. It should only care about the state. If the behavior is different between OS'es then our runs on different OS'es will catch that.

karrtikr

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-python

Virtualenv locator

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++import * as assert from 'assert';+import * as fsapi from 'fs-extra';+import * as path from 'path';+import * as sinon from 'sinon';+import { isVirtualenvEnvironment } from '../../../../client/pythonEnvironments/discovery/locators/services/virtualenvLocator';++suite('Virtualenv Locator Tests', () => {+    const envRoot = path.join('path', 'to', 'env');+    const interpreter = path.join(envRoot, 'python');

I don't see how this test depends on the behavior of the path module. If in the rest of the code we let path do what ever it does, then in the test we should let path do whatever it does. we are not testing path here, and the fact that path gets used anywhere at all is an internal implementation detail that this test should not care about.

kimadeline

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-python

Virtualenvwrapper locator

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++import * as path from 'path';+import {+    getEnvironmentVariable, getOSType, getUserHomeDir, OSType,+} from '../../../../common/utils/platform';++export function getDefaultVirtualenvwrapperDir(): string {+    const homeDir = getUserHomeDir() || '';++    // In Windows, the default path for WORKON_HOME is %USERPROFILE%\Envs.+    if (getOSType() === OSType.Windows) {+        return path.join(homeDir, 'Envs');+    }+    return path.join(homeDir, '.virtualenvs');+}++/**+ * Checks if the given interpreter belongs to a virtualenvWrapper based environment.+ * @param {string} interpreterPath: Absolute path to the python interpreter.+ * @returns {boolean} : Returns true if the interpreter belongs to a virtualenvWrapper environment.+ */+export function isVirtualenvwrapperEnvironment(interpreterPath:string): boolean {+    // The WORKON_HOME variable contains the path to the root directory of all virtualenvwrapper environments.+    // If the interpreter path belongs to one of them then it is a virtualenvwrapper type of environment.++    const workonHomeFolder = getEnvironmentVariable('WORKON_HOME') || getDefaultVirtualenvwrapperDir();++    return interpreterPath.startsWith(workonHomeFolder);
    return interpreterPath.toUpperCase().startsWith(workonHomeFolder.toUpperCase());
kimadeline

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventmicrosoft/vscode-python

Karthik Nadig

commit sha a62890cd032baf0dd64da06b8f9dc8db2ec4640f

Merge back from release (#13925) * Port gather survey and icon getting disabled while gathering (#13296) * Add gather status bar and update survey link (#13225) * add status bar * add localization * Added news file * add a 2 second timeout * updated the gather survey link * Change the gather icon while gathering * moved the gathering redux function to interactive common added a constant * move css to common.css * removed the status bar message * changed noop import * update changelog * Disable test (#13346) (#13350) Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348) * Add Goto Prev/Next Cell * Add goto previous cell * Remove unneeded changes * Add default keybindings for cell commands * Goto should be Go to Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Jim Griesmer <jimg@live.com> * Autoscroll when extending cell select (#13353) (#13354) Code change can only affect new keyboard shortcut operations * Update Release branch for August Release (#13401) * update version number and npm install to update package-lock.json * update changelog version and date * update news for changelog.md * update generated TPN Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> * Update version and change log for bug fix release (#13537) * Update LSP to latest to resolve problems with LS settings (#13511) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Update LSP to fix issue with settings in MPLS v1 * Add telemetry for `switch to Pylance` acceptance (#13526) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Initial * Add test * PR feedback * Rename property * Rename constant * Define property * Moar rename * casing * Update version and changelogs * Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544) * Update change log with more cherry picks Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> * Update changelog and version for point release. (#13610) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Change date. * Format using latest black (#13625) Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Skip flaky virtual env tests (#13650) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Skip workspace virtual env service tests * Add link to issue for skipping Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Cherry picks, change log, and version update for point release. (#13666) * Add install telemetry (#13653) * Add extension install telemetry. * Add tests. * Fix typo * Fix tests. * Update comment to reflect what the installed actually does. * Update change log and version for point release. * Cherry pick history bug for Azure ML CI && Make Jupyter server clickable (#13712) * Fix: Getting an error on selecting an existing CI which has a display name from the historical CI's in the quick picks (#13642) * Make Jupyter Server name clickale to select Jupyter server (#13657) * Update Changelog and remove news files * Update package version. (#13748) * Update and pin LSP libraries for new APIs (#13725) (#13756) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * PORT showStartPage setting fix (#13706) (#13758) * fix showStartPage setting on configSettings.ts (#13706) * fix showStartPage setting on configSettings.ts * add news file * Fix unit tests * oops * update changelog * Fixes for point release (#13841) * Use 'main' branch for experiments. * Update changelog and versions * Update CHANGELOG.md * Replace 'master' with 'main' in readme (#13845) Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

view details

push time in 4 days

PR merged microsoft/vscode-python

Reviewers
Merge back from release skip news
+61 -0

1 comment

1 changed file

karthiknadig

pr closed time in 4 days

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

/cc @fabioz

bSolt

comment created time in 4 days

IssuesEvent

PR opened microsoft/vscode-python

Merge back from release skip news
+61 -0

0 comment

1 changed file

pr created time in 4 days

push eventkarthiknadig/vscode-python

Karthik Nadig

commit sha eb693f4b322dd1fd1755ef710a2725df70dc4dae

Merge back from release

view details

push time in 4 days

push eventkarthiknadig/vscode-python

Karthik Nadig

commit sha 8caa4f5a6dd29d9bb366a05286e603a694073579

Merge back from release

view details

push time in 4 days

create barnchkarthiknadig/vscode-python

branch : mergeback2

created branch time in 4 days

issue commentmicrosoft/vscode-python

Release plan for 2020.8

Not from the latest release (last week). I am preparing a merge back PR right now.

brettcannon

comment created time in 4 days

push eventkarthiknadig/vscode-python

Karthik Nadig

commit sha d53650cff5daeb4ef5061ccdd5467fa0a3af8543

Merge back from release to master (#13825) * Port gather survey and icon getting disabled while gathering (#13296) * Add gather status bar and update survey link (#13225) * add status bar * add localization * Added news file * add a 2 second timeout * updated the gather survey link * Change the gather icon while gathering * moved the gathering redux function to interactive common added a constant * move css to common.css * removed the status bar message * changed noop import * update changelog * Disable test (#13346) (#13350) Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348) * Add Goto Prev/Next Cell * Add goto previous cell * Remove unneeded changes * Add default keybindings for cell commands * Goto should be Go to Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Jim Griesmer <jimg@live.com> * Autoscroll when extending cell select (#13353) (#13354) Code change can only affect new keyboard shortcut operations * Update Release branch for August Release (#13401) * update version number and npm install to update package-lock.json * update changelog version and date * update news for changelog.md * update generated TPN Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> * Update version and change log for bug fix release (#13537) * Update LSP to latest to resolve problems with LS settings (#13511) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Update LSP to fix issue with settings in MPLS v1 * Add telemetry for `switch to Pylance` acceptance (#13526) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Initial * Add test * PR feedback * Rename property * Rename constant * Define property * Moar rename * casing * Update version and changelogs * Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544) * Update change log with more cherry picks Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> * Update changelog and version for point release. (#13610) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Change date. * Format using latest black (#13625) Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Skip flaky virtual env tests (#13650) * Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) * Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments * Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests * Update changelog and version for point release. * Skip workspace virtual env service tests * Add link to issue for skipping Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> * Cherry picks, change log, and version update for point release. (#13666) * Add install telemetry (#13653) * Add extension install telemetry. * Add tests. * Fix typo * Fix tests. * Update comment to reflect what the installed actually does. * Update change log and version for point release. * Cherry pick history bug for Azure ML CI && Make Jupyter server clickable (#13712) * Fix: Getting an error on selecting an existing CI which has a display name from the historical CI's in the quick picks (#13642) * Make Jupyter Server name clickale to select Jupyter server (#13657) * Update Changelog and remove news files * Update package version. (#13748) * Update and pin LSP libraries for new APIs (#13725) (#13756) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * PORT showStartPage setting fix (#13706) (#13758) * fix showStartPage setting on configSettings.ts (#13706) * fix showStartPage setting on configSettings.ts * add news file * Fix unit tests * oops * update changelog * Fix merge issues * Clean up news Co-authored-by: David Kutugata <dakutuga@microsoft.com> Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Jim Griesmer <jimgries@microsoft.com> Co-authored-by: Jim Griesmer <jimg@live.com> Co-authored-by: Ian Huff <ianhuff@ravikun-dev2.redmond.corp.microsoft.com> Co-authored-by: Mikhail Arkhipov <mikhaila@microsoft.com> Co-authored-by: Shantnu Suman <shsuman@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

view details

Karthik Nadig

commit sha ef5f4dfc498e5a07e9b96def552807b0057c13b2

Disabel flaky file system tests (#13817)

view details

Kim-Adeline Miguel

commit sha c4e65e3b47572f8b2675942d48fae92b01f02e6e

Update to typescript 4.0 (#13777) * Update typescript, types, eslint, tslint * Re-generate package-lock.json * Update proposed.d.ts, fix/ignore errors & warnings * Compiler fixes * Undo deps changes other than TS 4.0 * Revert "Compiler fixes" This reverts commit ca07ff98b82b36ccc63c07c4356d575783f30b76. * Revert "Update proposed.d.ts, fix/ignore errors & warnings" This reverts commit 6dd0ff8bf3d919f4ff17031ff3b73841a4ec13b3. * Fix compiler errors * Fix TSLint warning * Remove tslint disable comment * ignore ipywidgets property accessor error * Add link to error announcement

view details

Brett Cannon

commit sha 83c97776ad68c67ce68efebd06d243fc3a48573f

Fix tests for pytest 5 (#13775)

view details

Mojtaba Samimi

commit sha 09bd946dcfcce58ff0d62af4ded68c006e41dc6e

bump plotly.js-dist at v1.55.2 (#13828)

view details

Karthik Nadig

commit sha d061ed898fba6dbd4b07e0612c131e8c12747db6

Add join mailing list prompt (#13798) * Add join mailing list prompt * Clean up

view details

Don Jayamanne

commit sha c8266b6c444fa21421e5d308433ed429f585d205

Update notebook API with latest changes (#13836)

view details

Rich Chiodo

commit sha 674116217f1d544edc22036e69d40ddc156a8da7

Fix nyc compile errors (#13840) * Fix nyc unit test failure * Add comment about failure

view details

Eric Snow

commit sha b6ee6c61d11a5305463b523afcf59a890f37b943

Add an extension-specific locator that will wrap the low-level locators. (#13780)

view details

Eric Snow

commit sha 6bad0ef3fa233b477f6a9300c90a37a4eaa2ae8d

Initialize/activate the `ExtensionLocators` when the extension activates. (#13498) This finishes up work on "interfaces and scaffolding needed for locators". At this point we can plug this "locator manager" into the discovery component API, as well as plug the low-level locators in here.

view details

Joyce Er

commit sha 44d9c808c45d52167bc0eeaad44a25059bb77d21

Fix git diff detection code (#13851)

view details

Kim-Adeline Miguel

commit sha d24e2fa3f20168d723105e96603b52418e3cb07b

Add compiler support for ES2020 (#13834)

view details

Karthik Nadig

commit sha ff4881526eb5730001f106dd19de7e1b316fc7bd

Static analysis cleanup (#13852) * Clean up language * Remove unsed static analysis settings and yaml

view details

Kartik Raj

commit sha 0bcc807c0fd0b7b43778bf0a1ab775d443973a6e

Upgrade isort to 5.5.2 (#13832) * Upgrade isort to 5.5.1 * Upgrade to 5.5.2 * Update news entry

view details

Kim-Adeline Miguel

commit sha 07732969c6f4d45542eb1f4c13f670f28c7142ec

ESLint fixes for unrelated files in pythonEnvironments/discovery (#13857) * Fix ESLint errors and warnings. * Add resolution for other envs * Remove try/catch * remove another try/catch * Disable eslint warnigns for for-of + await in loop * Undo changes in subenv.unit.test.ts as well * Add return value * Use generic TypeFinderFunc

view details

Karthik Nadig

commit sha 2a0fa40ab8e958d844826267a405be85d6e43b62

Venv identifier (#13844) * Venv identifier * Add unit tests * Test tweaks * More tests * Fix linting errors * Address comments..

view details

Rich Chiodo

commit sha f805585813d8e4d1f012f9a7d5a2cda6d9b89b7e

PDF with zero bytes should show an error (#13870) * Output generic export error and put more information in output panel * Add news entry

view details

Rich Chiodo

commit sha 5a0ef97c3aaa51c440a09891bd0be02a9b1ed9d8

Make uri expiration test more robust (#13872)

view details

Rich Chiodo

commit sha ed3f29f261100190f0dc1bea10ddf85f5b82e8d1

Make it possible to use the LSP to talk to Jedi (#13855) * Ship language server too * Remove all jedi code and make copy of LS activation * Compiling but not working * Working with intellisense * Enable the experiment in order to switch * Fix up registration so LSP works * Fix version reading * Write test wrapper to try out lsp * Let experiments be in a workspace * Support installing jedi-language-server from custom fork * Fix sonar problems * More sonar fixes - dupe code * Put back the package json changes * Skip dupe checking for language server proxy classes

view details

David Kutugata

commit sha c9f2d9c28b60cfb22fccc26d9d4834f73f546c86

Draft for gather extensibility point (#13672) * draft for gather extensibility point * fix compiler errors * add event on extension api * added an event to the api * oops * remove old implementation * fix activation errors * use 3 events instead of 1 * create a class for the execution logger events - part 1 * put the logger into a class * rename logger to notebook extensibility and made it a singleton * oops * fix functional tests * fix more functional tests * remove onNotebookOpened, especify event name as post execute * moved to the datascience part of the API * add news

view details

push time in 4 days

PullRequestReviewEvent

issue commentmicrosoft/vscode-python

Support hiding "private" variables/attributes

Can you clarify if this is in completions or debugger or both?

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

Marsfan

comment created time in 4 days

issue commentmicrosoft/vscode-python

pylint in vscode does not behave the same as command line

Do you have this setting checked or unchecked?: image

craighurley

comment created time in 5 days

issue commentmicrosoft/vscode-python

Error when starting process: The terminal process failed to launch: Starting directory (cwd)

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template.

Does this occur if you try to open a terminal from: image

If Yes, then does this occur if you disable python extension?

rhollins

comment created time in 6 days

issue commentmicrosoft/vscode-python

pylint in vscode does not behave the same as command line

@craighurley Try providing absolute path to rcfile.

"python.linting.pylintArgs": [
    "--rcfile=${workspaceFolder}/setup.cfg"
  ],
craighurley

comment created time in 6 days

issue closedmicrosoft/debugpy

Breakpoints not hit in unit tests

Issue Type: <b>Bug</b>

The python debugger used to work for debugging pytest unit tests, but now will not stop on breakpoints, exceptions, or when using "stopOnEntry"

I have the following entry in my launch.json:

{
    "name": "Python: Test",
    "type": "python",
    "request": "test",
    "console": "integratedTerminal",
    "envFile": "${workspaceFolder}/.env",
    "justMyCode": false,
    "stopOnEntry": false,
    "env": {
        "DEBUG": "true",
        "CF_DIET": "dev"
    }
}

And these settings:

 "python.testing.pytestArgs": [],
 "python.testing.unittestEnabled": false,
 "python.testing.nosetestsEnabled": false,
 "python.testing.pytestEnabled": true,

Extension version: 2020.8.105045 VS Code version: Code 1.48.2 (a0479759d6e9ea56afa657e454193f72aef85bd0, 2020-08-25T10:56:10.074Z) OS version: Linux x64 3.10.0-1127.13.1.el7.x86_64

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz (4 x 2399)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off_ok<br>video_decode: unavailable_off<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 15.51GB (0.58GB free)
Process Argv . --no-sandbox
Screen Reader no
VM 50%
DESKTOP_SESSION mate
XDG_CURRENT_DESKTOP MATE
XDG_SESSION_DESKTOP mate
XDG_SESSION_TYPE x11

</details> <!-- generated by issue reporter -->

closed time in 7 days

bSolt

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

Closing this against user-unhandled, since this is closely related: https://github.com/microsoft/debugpy/issues/275 https://github.com/microsoft/debugpy/issues/364

bSolt

comment created time in 7 days

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

Looks like it does not get to the breakpoint at all. Seems like you hit this error, before it gets to the breakpoint.

AttributeError: <module 'lodges.jobs.task_classes.orchestration' from '/home/bsolt/repos/loadable-orchestration/lodges/jobs/task_classes/orchestration.py'> does not have the attribute 'get_job_by_id'

You might have to use the Raised exception to catch these at the moment. uncaught is not enough because pytest catches all exceptions (so we can identify the above exception as uncaught). image

Note: The debugger has a feature that detects these scenarios (user uncaught), but we have not enabled that yet.

bSolt

comment created time in 7 days

PR opened microsoft/debugpy

Reviewers
Update nuget packages.
+4 -4

0 comment

1 changed file

pr created time in 7 days

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

Also, Share the list of extensions installed. Just do ls in the ~/.vscode/extensions folder.

bSolt

comment created time in 7 days

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

I see. Try this:

{
    "name": "Python: Test",
    "type": "python",
    "request": "test",
    "console": "integratedTerminal",
    "envFile": "${workspaceFolder}/.env",
    "justMyCode": false,
    "stopOnEntry": false,
    "env": {
        "DEBUG": "true",
        "CF_DIET": "dev"
    },
    "logToFile": true  // <--- this will enable logging.
}

You should be able to find logs in the extension folder: ~/.vscode/extensions/ms-python.python*. You should find files named debugpy-.log and pydevd.log. there will be multiple. Share them all.

bSolt

comment created time in 7 days

issue closedmicrosoft/vscode-python

Extension issue

  • Issue Type: Bug
  • Extension Name: python
  • Extension Version: 2020.8.108011
  • OS Version: Windows_NT x64 10.0.18362
  • VSCode version: 1.49.0

:warning: We have written the needed data into your clipboard. Please paste! :warning:

closed time in 7 days

jahnavi-sachdeva

issue commentmicrosoft/vscode-python

Extension issue

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template. Once you are done please leave a comment to that effect.

jahnavi-sachdeva

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentmicrosoft/debugpy

Breakpoints not hit in unit tests

@bSolt Here is an example of calling breakpoint() function:

def foo():
    breakpoint()
    print('here')        # Debugger stops here

foo()

This assumes you are using Python 3.7 or greater.

For older versions of python, you can do this, and it is compatible with all versions of python (including 3.7 or greater).

import debugpy
def foo():
    debugpy.breakpoint()
    print('here')        # Debugger stops here

foo()

Note: you don;t have to install debugpy if you are running locally (on the same machine as the python-extension).

bSolt

comment created time in 7 days

issue closedmicrosoft/vscode-python

outline-no symbols found in document for python 32 bits

Issue Type: <b>Bug</b>

outline issue: no symbols found in document for python 32 bits (works well with python 64 bits)

Extension version: 2020.8.108011 VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.19041

<!-- generated by issue reporter -->

closed time in 7 days

JonnyQuest233

push eventkarthiknadig/debugpy

Karthik Nadig

commit sha b81ca97d966fe058d078f31db6b0b89e51155cfe

Update nuget packages.

view details

push time in 7 days

issue commentmicrosoft/vscode-python

outline-no symbols found in document for python 32 bits

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template.

JonnyQuest233

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-python

Make it possible to use the LSP to talk to Jedi

+import re+import sys+import os++# Add the lib path to our sys path so jedi_language_server can find its references+EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))+sys.path.append(os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python"))++from jedi_language_server.cli import cli++# Trick language server into thinking it started from 'jedi-language-server.exe'+sys.argv[0] = "jedi-language-server.exe"+sys.exit(cli())

I know we don;t install for every environment. My point was that the package is designed in a way where it expects that. Hence you had to add this script to run it. But really it should not require installation nor should it require this script. The problem is with the packaging.

rchiodo

comment created time in 7 days

Pull request review commentmicrosoft/vscode-python

Make it possible to use the LSP to talk to Jedi

+import re+import sys+import os++# Add the lib path to our sys path so jedi_language_server can find its references+EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))+sys.path.append(os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python"))++from jedi_language_server.cli import cli++# Trick language server into thinking it started from 'jedi-language-server.exe'+sys.argv[0] = "jedi-language-server.exe"+sys.exit(cli())

Yep, it is a simple enough fix. We can take that later. For now lets get this working.

rchiodo

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-python

Make it possible to use the LSP to talk to Jedi

+import re+import sys+import os++# Add the lib path to our sys path so jedi_language_server can find its references+EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))+sys.path.append(os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python"))++from jedi_language_server.cli import cli++# Trick language server into thinking it started from 'jedi-language-server.exe'+sys.argv[0] = "jedi-language-server.exe"+sys.exit(cli())

This script does not restrict running this only to windows. So argv[0] will be wrong for linux/mac. The problem is in the package itself. You should be able to just run via __main__.py in that package. This is a fairly small change, and it preservers existing functionality. Secondly, the package itself won;t require installation to run. since we don;t want to install this for each python environment.

rchiodo

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-python

Make it possible to use the LSP to talk to Jedi

+import re+import sys+import os++# Add the lib path to our sys path so jedi_language_server can find its references+EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))+sys.path.append(os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python"))++from jedi_language_server.cli import cli++# Trick language server into thinking it started from 'jedi-language-server.exe'+sys.argv[0] = "jedi-language-server.exe"+sys.exit(cli())

We should file this as a bug. We should be able to run this python EXTENSION_ROOT/pythonFiles/lib/python the same way we run debugpy. We won't need this file.

rchiodo

comment created time in 7 days

PullRequestReviewEvent

push eventmicrosoft/debugpy

Karthik Nadig

commit sha 78bd26571e6b68d313e6db33e4132f0b8ea666c9

More compiler tweaks

view details

Karthik Nadig

commit sha c0716868794c70bd97be98e54b7c22c4980fd5cc

Update src/debugpy/_vendored/pydevd/pydevd_attach_to_process/windows/run_code_on_dllmain.cpp

view details

Karthik Nadig

commit sha d3cb68f21ab671985e936e4670df60542a4f5900

Merge pull request #406 from karthiknadig/bin1 More compiler tweaks

view details

push time in 7 days

more