profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/karras/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Michael Hofer karras @adfinis-sygroup Ahoi!

adfinis-sygroup/sbb-fallblatt 29

Code and documentation for SBB split flap displays

karras/flatpak-xchat 2

📦 Flatpak manifest and patches to build XChat IRC client.

adfinis-sygroup/packer-cloud-images 1

Build your own AWS and Azure Packer images from scratch within minutes.

hashicorp/is-consul-health-agent 1

Lightweight agent to monitor the status of Consul Enterprise autopilot upgrades

adfinis-sygroup/ansible-role-azure_linux_image 0

Ansible role azure_linux_image

karras/bootly 0

bootly roles

karras/dotfiles 0

My dotfiles

karras/flatpak-claws-mail 0

📦 Flatpak manifest to build Claws Mail.

karras/karras 0

All my knowledge condensed

swisscom/consul-helm 0

Helm chart to install Consul and other associated components.

push eventkarras/dotfiles

Michael Hofer

commit sha f4abc85c544cffe1dc16dfc1f7b0f9b85f9d079d

Add ssh-agent initialization to ZSH

view details

push time in 18 days

push eventkarras/dotfiles

Michael Hofer

commit sha cfcc1d8f061a1af29cf19f35459d927ff2410d8d

Switch Terminator font to Source Code Pro and increase size to 11

view details

push time in 18 days

push eventkarras/dotfiles

Michael Hofer

commit sha bc7f45337090695f90a31b3285d3c0e1d62696d7

Add colored ruler to nvim

view details

push time in 21 days

push eventkarras/dotfiles

Michael Hofer

commit sha 7c5f33545786b29c18224606a1f5c70e6311b348

Update README

view details

push time in 21 days

push eventkarras/dotfiles

Michael Hofer

commit sha d339c587f1203e8bec1b59e36dd51af8beca9886

Add wordchar handling and fancy VCS git prompt to ZSH

view details

push time in 21 days

push eventkarras/dotfiles

Michael Hofer

commit sha c81615e3dcfb542a9af2573893b7c5eca191b66b

Move lesshistfile export to .zshenv

view details

push time in 21 days

push eventkarras/dotfiles

Michael Hofer

commit sha be31622b88cd4b1f20c137c02ec321f1f89e6558

Add Terminator config, replace Gnome Terminal with Terminator in Wayfire config

view details

Michael Hofer

commit sha 930a2f839e6175f671ef2738d80b92e0aebb5b4e

Update Waybar Ethernet status message

view details

push time in a month

push eventkarras/dotfiles

Michael Hofer

commit sha ab6551c033e2c1346e35041d270d6e0c794d1023

Switch git standard editor to vi for compatibility

view details

Michael Hofer

commit sha 675242e346e2e29dd74cd971b30eeb8864b54b67

Add remaining XDG dirs to user-dirs.dirs

view details

Michael Hofer

commit sha f0d775740a6e9cee5609de38c07543f571f31934

Add zsh configuration

view details

push time in a month

create barnchkarras/dotfiles

branch : master

created branch time in a month

created repositorykarras/dotfiles

My dotfiles

created time in a month

issue closedWayfireWM/wayfire

Commands with hashtags fail (e.g. bemenu-run)

Describe the bug I configured a command to launch bemenu-run, which seems to fail due to the color coding parameters that contain a hashtag. Unless I overlooked something obvious or made a configuration mistake, this seems to fail currently.

To Reproduce

  1. Install bemenu, configure the command below to execute bemenu-run:
[command]
binding_launcher = <super> KEY_E
command_launcher = /usr/bin/bemenu-run -i -p $ -b --nb '#2e3440'
  1. Launching the command with the color code (#2e3440) will fail, if one removes the --nb '#2e3440 parameter it works again

I have also tried to escape the whole command and/or individual parameters with ', ", \ without success.

Expected behavior Be able to run launch commands such as bemenu-run with parameters which include hashtags

Screenshots or stacktrace n/a

Wayfire version 0.7.2-1 (Archlinux)

closed time in a month

karras
GollumEvent

issue commentWayfireWM/wayfire

Commands with hashtags fail (e.g. bemenu-run)

Added a small note here: https://github.com/WayfireWM/wayfire/wiki/Configuration#syntax

karras

comment created time in a month

GollumEvent

fork karras/wayfire

3D wayland compositor

https://wayfire.org/

fork in a month

issue commentWayfireWM/wayfire

Commands with hashtags fail (e.g. bemenu-run)

I must have tested it wrongly somehow, it works now. Thanks a lot! I'll open a small PR to add a note to the docs.

karras

comment created time in a month

issue openedWayfireWM/wayfire

Commands with hashtags fail (e.g. bemenu)

Describe the bug I configured a command to launch bemenu-run, which seems to fails due to the color coding parameters that contain a hashtag. Unless I overlooked something obvious or made another configuration mistake, this seems to fail currently.

To Reproduce

  1. Install bemenu, configure the command below to execute bemenu-run:
[command]
binding_launcher     = <super> KEY_E
command_launcher = /usr/bin/bemenu-run -i -p $ -b --nb '#2e3440'
  1. Launching the command with the color code (#2e3440) will fail, if one removes the --nb '#2e3440 parameter it works again

I have also tried to escape the whole command and/or individual parameters with ', ", \ without success.

Expected behavior Be able to run launch commands such as bemenu with parameters which include hashtags

Screenshots or stacktrace n/a

Wayfire version 0.7.2-1 (Archlinux)

created time in a month

startedadammck/terraform-inventory

started time in 2 months

startedGNOME/gnome-initial-setup

started time in 2 months

startedmgeb/mediawiki-drawio-editor

started time in 2 months

startedkremers/charts-vmware-exporter

started time in 2 months

startedmozilla/DeepSpeech

started time in 2 months

startedservicemeshinterface/smi-adapter-istio

started time in 2 months

startedvmware/hamlet

started time in 2 months

startedbeemesh/beemesh

started time in 2 months

issue closedhashicorp/consul-k8s

Make Consul client ports customizable for connect-inject init container

Feature Description

This feature request is related to what is described in the consul-helm issue #997. Basically in certain environments hostPorts are not available and thus the currently only feasible replacement are nodePorts. By using topologyKeys (K8s < 1.21) or Topology Aware Hints (K8s 1.21+) the nodePort loadbalancing can be prevent in order to enforce that the inject sidecars establish connectivity to their node-local Consul client.

In order to avoid having to extend the service-node-port-range to include the 85XY ports, the hardcoded Consul client ports in consul-k8s should be customizable.

Use Case(s)

  • Environments where hostPorts are not available, make it possible to evade to nodePorts
  • Provide more flexibility by making the hardcoded ports customizable

Contributions

We (@flavioaiello, @pree & @karras) are already working on a PR.

closed time in 2 months

karras

issue commenthashicorp/consul-k8s

Make Consul client ports customizable for connect-inject init container

Thanks for the review and additional inputs, much appreciated! As discussed it can't be merged. Thus I'm closing this and the other related PRs and issues to prevent cluttering and prepare for the upcoming repo consolidation into consul-k8s.

karras

comment created time in 2 months

PR closed hashicorp/consul-k8s

Enable custom consul-client ports (HTTP, HTTPS & GRPC) for connect-inject

Changes proposed in this PR:

  • This PR makes it possible to customize the hardcoded Consul client ports for the connect-inject init container by providing optional parameters. If the parameters are not specified the default Consul client ports are used.
  • As the parameters are optional, backwards compatibility should be guaranteed, i.e. we'll open another PR for consul-helm to allow configuring these new port parameters.
  • See https://github.com/hashicorp/consul-helm/pull/1004 for the consul-helm counterpart
  • Fixes #544

How I've tested this PR:

  • Built a consul-k8s container image based on this PR and uploaded it to Dockerhub. Then adjusted the image flag in consul-helm to deploy it accordingly. Finally tested the inject workflow by deploying a simple NGINX hello world app and scaling the replicas to a higher number. All Pods were correctly registered.
  • Do the same as above but this time adjust the parameters and check in the connect-inject deployment if the parameters are there. When deploying an example NGINX app check the logs if they now try to connect to the Consul client with the specified ports (this will of course fail unless the client ports were adjusted as well).

How I expect reviewers to test this PR:

  • Deploy connect-inject based on this PR, check if everything is still working
  • Deploy connect-inject based on this PR, then configure the new parameters but with default ports and check if everything is still working
  • Deploy connect-inject based on this PR, then configure the new parameters but with custom ports and check if everything is still working

Checklist:

  • [ ] Tests added
  • [n/a] CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)
+138 -8

4 comments

4 changed files

karras

pr closed time in 2 months

pull request commenthashicorp/consul-k8s

Enable custom consul-client ports (HTTP, HTTPS & GRPC) for connect-inject

@ishustava Thanks for the review and additional inputs, much appreciated! As discussed in the issue with David it can't be merged. Thus I'm closing this and the other related PRs and issues to prevent cluttering and prepare for the upcoming repo consolidation into consul-k8s.

karras

comment created time in 2 months

issue closedhashicorp/consul-helm

Allow Consul client daemonset connectivity via nodePort (instead of only hostPort)

Feature Description

Currently the Consul deployment on K8s relies on Kubernetes hostPorts to provide connectivity to the Consul clients as well as ensuring each app pod talks to its "K8s worker-local" Consul client. The design decision is well described in the Consul docs below:

  • https://www.consul.io/docs/k8s/installation/install#client-agents

This causes various problems in organizations and environments where hostPort is not available, for example when running TKGI (previously known as PKS) < 1.11 or simply when security requirements do not allow you to use it.

Therefore we (@flavioaiello, @pree & @karras) investigated various scenarios how the Consul deployment could be adjusted to avoid the hostPort option. This would not only solve the problem but also improve security related requirements in certain environments.

We managed to successfully make the switch to nodePorts via 2-3 additional modifications:

  • Adjust the K8s --service-node-port-range option to include the ports 8501 and 8502 (e.g. 8500-32767)
  • Activate the ServiceTopology feature gate (or TopologyAwareHints on K8s 1.21+)
  • Create a nodePort service for the Consul clients with topologyKeys configured to avoid traffic loadbalancing and route everything to the local worker node (or EndpointSlice on K8s 1.21+)

Note: The adjustment of the service-node-port-range is only required due to the hardcoded ports in consul-k8s and consul-helm. We'll track this in separate PRs. See also: https://github.com/hashicorp/consul-k8s/issues/544

Most likely making nodePorts the default deployment option would be desirable but I guess it's not possible because it would mean that every organization would need to enable the K8s feature gates. These are still in an alpha state and also disabled by default in vanilla K8s.

Additional references:

  • https://kubernetes.io/docs/concepts/services-networking/service-topology/#only-node-local-endpoints
  • https://kubernetes.io/docs/concepts/services-networking/topology-aware-hints/
  • https://docs.pivotal.io/tkgi/1-11/release-notes.html

Use Case(s)

  • Make it possible to deploy Consul in environments, organizations and K8s distributions where hostPorts are not an option
  • Be closer aligned with K8s best practices

Contributions

We anticipate to open a PR soon with a new consul-helm flag/variable to allow this kind of deployment option.

closed time in 2 months

karras