profile
viewpoint
Karl Horky karlhorky @upleveled Vienna https://twitter.com/karlhorky Founder, Teacher. Canadian/Austrian. he/him

PR merged karlhorky/awesome-speakers

Added myself (@tshemsedinov)

Here is about 90 lectures in Kiev Polytechnic University and dozens speeches at conferences

+6 -0

1 comment

1 changed file

tshemsedinov

pr closed time in 3 hours

push eventkarlhorky/awesome-speakers

Timur Shemsedinov

commit sha de0e26a27c37e7d44b7d259aebf52308f57866ad

Added myself (@tshemsedinov) (#176)

view details

push time in 3 hours

pull request commentkarlhorky/awesome-speakers

Added myself (@tshemsedinov)

Thanks, looks good! Merging.

tshemsedinov

comment created time in 3 hours

startedcancerberoSgx/typescript-in-the-browser

started time in 5 hours

starteddsherret/ts-ast-viewer

started time in 13 hours

startedcancerberoSgx/typescript-api-playground

started time in 13 hours

issue commentaioutecism/amVim-for-VSCode

p doesn't paste from system clipboard

Bump @aioutecism just ran into this today, would be cool to have @jleclanche help out on implementation!

pfmoore

comment created time in 14 hours

startedcevek/ttypescript

started time in 15 hours

startedSupernaviX/typescript-type-provider-poc

started time in 15 hours

issue commentmicrosoft/TypeScript

Playground Header Obscures Error

Awesome, thanks @orta! As per https://github.com/microsoft/TypeScript/issues/23266#issuecomment-505611112 I guess it's living here for now:

Repo: https://github.com/orta/typescript-play/tree/old-site-integration Live: https://www.typescriptlang.org/play

karlhorky

comment created time in 16 hours

issue commentmicrosoft/TypeScript

Better playground

Really cool, looks great! 💯 Thanks!

agentcooper

comment created time in 16 hours

issue commentmicrosoft/TypeScript

Better playground

Really cool, looks great!

agentcooper

comment created time in 16 hours

startedorta/typescript-play

started time in 16 hours

issue commentmicrosoft/TypeScript

How can I get js code by createProgram?

@sheetalkamat or anyone else, do you have an idea of how to get the simple solution above working inside a create-react-app context? I seem to get errors with properties on ts.sys being undefined, such as:

Cannot read property 'useCaseSensitiveFileNames' of undefined

at this line: https://github.com/microsoft/TypeScript/blob/1cbace6eee8257309e5e8dc5a2389a20077a5c08/src/compiler/program.ts#L77

<br>

Here's an example on CodeSandbox:

https://codesandbox.io/s/create-react-app-v3-with-tscreatecompilerhost-cielb

<br>

I have a hunch that this is because running ts.createProgram in the create-react-app context is not exactly the same as running in the Node context, from this Stack Overflow question/answer:

https://stackoverflow.com/questions/52969177/typescript-createprogram-throwing-ts-sys-is-undefined


By playing around a little bit, I got something working today (by declaring the compilerHost as an object instead):

https://github.com/codesandbox/codesandbox-client/issues/2090#issuecomment-505500573

10229428

comment created time in a day

issue commentcodesandbox/codesandbox-client

create-react-app v3 doesn't show TypeScript errors in overlay

Well, after trolling around with the TypeScript compiler today, I've found a hacky way to show the errors in the browser.

Kapture 2019-06-25 at 17 29 22

I've got it running here:

https://codesandbox.io/s/create-react-app-v3-with-typescript-overlay-errors-colix

References for what I was trying to do (type checking TypeScript code in create-react-app and Jest tests):

https://github.com/microsoft/TypeScript/wiki/Using-the-Compiler-API#a-minimal-compiler

https://github.com/Microsoft/TypeScript/issues/29226#issuecomment-450965141

https://gist.github.com/teppeis/6e0f2d823a94de4ae442

https://github.com/dsherret/ts-morph/issues/358#issuecomment-404028498

https://stackoverflow.com/questions/52969177/typescript-createprogram-throwing-ts-sys-is-undefined (with the error "Cannot read property 'useCaseSensitiveFileNames' of undefined")


Note that there are still significant problems with this approach:

  • If not filtered out, all the errors with the DOM APIs appear: Cannot find global type 'Array'. Cannot find global type 'Boolean'. Cannot find name 'console'. Do you need to change your target library? Try changing thelibcompiler option to include 'dom'. etc..
karlhorky

comment created time in a day

startedAlCalzone/virtual-tsc

started time in a day

starteddsherret/ts-morph

started time in a day

issue commentcodesandbox/codesandbox-client

Hotkey defaults that work in the browser (for common actions)

Hm, just realized that installing CodeSandbox as a desktop PWA allows for use of some of these shortcuts! This is a great workaround for now! Maybe even good enough to supersede this issue...

karlhorky

comment created time in 2 days

starteddequelabs/axe-puppeteer

started time in 2 days

issue commentcodesandbox/codesandbox-client

Hotkey defaults that work in the browser (for common actions)

Cool, I've started to compile a list above in the description, maybe we can put the "help wanted" label on this. It's going to be a bit of a job, especially for a cross-platform list.

karlhorky

comment created time in 2 days

PR opened samuelgoto/proposal-block-params

Fix link

Thanks for this proposal, looks interesting.

Quick PR to fix the HTML link.

+2 -2

0 comment

1 changed file

pr created time in 2 days

push eventkarlhorky/proposal-block-params

Karl Horky

commit sha b73098cb3da4f88485f432a51bf4bdedd6b88dae

Fix link

view details

push time in 2 days

fork karlhorky/proposal-block-params

A syntactical simplification in JS to enable DSLs

fork in 2 days

issue closedmicrosoft/TypeScript-Handbook

Add section on object literals

Although object literals are mentioned throughout the docs and release notes in various places (ex. pages/Type Compatibility.md, pages/Type Checking JavaScript Files.md), they are not explicitly documented anywhere (such as Object Types from the Flow documentation).

Would the TypeScript team be open to having these documented explicitly somewhere? Such as on the Basic Types page in the Object section?

Actually, come to think of it, it would be good to have a section on type aliases too... they are also mentioned often without their own area in the beginners material...

closed time in 2 days

karlhorky

issue commentmicrosoft/TypeScript-Handbook

Add section on object literals

Ah wow, cool! The new docs are looking great. I'll use these as a reference for the course material I'm writing.

I suppose we can probably close this, since these are now both being documented:

karlhorky

comment created time in 2 days

startedmicrosoft/TypeScript-New-Handbook

started time in 2 days

delete branch karlhorky/TypeScript-Handbook

delete branch : patch-1

delete time in 2 days

pull request commentmicrosoft/TypeScript-Handbook

Fix documentation on --strictNullChecks

No problem, thanks for merging!

karlhorky

comment created time in 2 days

issue openedcodesandbox/codesandbox-client

create-react-app v3 doesn't show TypeScript errors in overlay

🐛 bug report

Description of the problem

TypeScript errors in a create-react-app sandbox are not displayed in the browser in the error overlay:

Screen Shot 2019-06-24 at 18 43 49

As a counter-example, the CRA errors in the overlay displayed locally:

Screen Shot 2019-06-24 at 18 37 50

I didn't find the original PR introducing this in CRA, but I found this PR discussing the feature: https://github.com/facebook/create-react-app/pull/7091

How has this issue affected you? What are you trying to accomplish?

If possible, I would like to see TypeScript error messages in the error overlay in the browser (like in normal CRA locally).

Link to sandbox: link

Your Environment

Software Name/Version
Сodesandbox PROD-1561199685-a102c8493
Browser Chrome 75.0.3770.100
Operating System macOS 10.14.5

created time in 2 days

issue openedcodesandbox/codesandbox-client

Hotkey defaults that work in the browser (for common actions)

🌈 Feature

Would the CodeSandbox team be interested in implementing hotkey defaults that work in browsers for common actions such as switching between tabs (VS Code Settings "View: Open Next Editor" and "View: Open Previous Editor").

For example, I would like to be able to switch to the next and previous tabs, but they are currently set to hotkeys like <kbd>cmd</kbd>-<kbd>option</kbd>-<kbd>left/right</kbd>, which collide with Chrome's bindings:

Screen Shot 2019-06-24 at 17 30 08

Since Chrome won't allow rebinding these keys, it would be cool if CodeSandbox had a binding for this out-of-the-box.

I know that I can just bind them myself, but I am suggesting to do this for all users to avoid having to do this.

Prior Art: https://github.com/codesandbox/codesandbox-client/issues/1044#issuecomment-413623912

I wish we could have native behaviour here, but Chrome doesn't allow us to override CMD + W. This is frustrating for me, for now I 'fixed' it by implementing CTRL + W for Mac as alternative...

created time in 2 days

issue commentcodesandbox/codesandbox-client

Switching privacy back to public results in error

No problem, thanks for the quick fix!

karlhorky

comment created time in 2 days

issue commentbabel/babel

[Feature Request] Add "preserveConstEnums" option to transform-typescript

Prior art (sucrase): https://github.com/alangpierce/sucrase/issues/423#issuecomment-467085280

For example, TypeScript const enums are treated as regular enums rather than inlining across files.

ForbesLindesay

comment created time in 2 days

issue openedmicrosoft/TypeScript-Handbook

Add section on object literals

Although object literals are mentioned throughout the docs and release notes in various places (ex. pages/Type Compatibility.md, pages/Type Checking JavaScript Files.md), they are not explicitly documented anywhere (such as Object Types from the Flow documentation).

Would the TypeScript team be open to having these documented explicitly somewhere? Such as on the Basic Types page in the Object section?

Actually, come to think of it, it would be good to have a section on type aliases too... they are also mentioned often without their own area in the beginners material...

created time in 2 days

startedmicrosoft/TypeScript-Handbook

started time in 2 days

issue openedagentcooper/typescript-play

Unreponsive after user inactivity

First of all, thanks for the playground! Really nice design and features.

After I have had the website open and idle in the background for some time and I switch back to it, it is no longer responsive:

  • input is no longer checked
  • if I refresh the website, it shows an error that the website can no longer be reached:

Screen Shot 2019-06-24 at 13 59 19

After refreshing and waiting for long enough (1-2 minutes), the site eventually loads again.

Sorry there's not a more clear definition of what the problem could be - could be anything from the hosting to problems with the connection (although other websites load... 🤔). If this is not clear enough and you cannot reproduce, then not sure what next steps we can take 😕

created time in 3 days

startedfabiandev/typescript-playground

started time in 3 days

issue commentmicrosoft/TypeScript

Better playground

Would the TypeScript team be open to making this into the official editor? It would help with a lot of these points, as well as other issues with the official Playground, such as https://github.com/microsoft/TypeScript/issues/32058

agentcooper

comment created time in 3 days

issue openedmicrosoft/TypeScript

Playground Header Obscures Error

The playground header obscures error messages displayed in the tooltips from the Monaco editor:

Screen Shot 2019-06-24 at 13 12 18

<br> <br>

This is due to the z-index of 1030 on the nav element...

Screen Shot 2019-06-24 at 13 29 49

<br> <br>

...which outranks the z-index: 6 in the Monaco tooltip:

Screen Shot 2019-06-24 at 13 29 14

I believe the playground website is not open source, if this comment from @RyanCavanaugh is still accurate:

Bad news: The website currently isn't OSS.

Search Terms:

playground header fixed overlap overlapping z-index

Expected behavior:

The full error message is visible.

Actual behavior:

The header obscures the error message and the user cannot read it.

Playground Link:

https://www.typescriptlang.org/play/#src=let%20list%3A%20Array%3Cnumber%20%7C%20string%3E%20%3D%20%5B1%2C%20%22asdf%22%2C%203%5D%3B%0D%0Alet%20obj%3A%20%7B%20%5Bkey%3A%20number%5D%3A%20'AA'%20%7D%20%3D%20%7B%20'asdf'%3A%20'AA'%20%7D%3B%0D%0A%0D%0Aobj%5B2%5D%20%3D%20'AA'%3B%0D%0A

Related Issues: https://github.com/microsoft/TypeScript/issues/23266

Code: Not really relevant here. TypeScript Version: Not really relevant, pertains to website.

created time in 3 days

push eventkarlhorky/TypeScript-Handbook

Karl Horky

commit sha fdd6ba424778d6e7598cb1a38c2912ff86cefe20

Add undefined / void exception

view details

push time in 3 days

PR opened microsoft/TypeScript-Handbook

Fix documentation on --strictNullChecks

Ref (documentation): https://www.typescriptlang.org/docs/handbook/compiler-options.html Ref (issue in TypeScript repo): https://github.com/microsoft/TypeScript/issues/16075#issuecomment-304763298

cc @RyanCavanaugh

Closes microsoft/TypeScript#16075 Closes microsoft/TypeScript#11758

+1 -1

0 comment

1 changed file

pr created time in 3 days

push eventkarlhorky/TypeScript-Handbook

Karl Horky

commit sha 98618cad158ae8e0b1a8226b6e8ba7fe4e45eada

Fix documentation on --strictNullChecks Ref (documentation): https://www.typescriptlang.org/docs/handbook/compiler-options.html Ref (issue in TypeScript repo): https://github.com/microsoft/TypeScript/issues/16075#issuecomment-304763298

view details

push time in 3 days

fork karlhorky/TypeScript-Handbook

The TypeScript Handbook is a comprehensive guide to the TypeScript language

fork in 3 days

issue commentmicrosoft/TypeScript

null is not assignable to void when strictNullChecks are enabled

Ah, I guess the docs are in the TypeScript-Handbook repo. I suppose in this file:

https://github.com/microsoft/TypeScript-Handbook/blob/master/pages/Basic%20Types.md#null-and-undefined

Gozala

comment created time in 3 days

issue commentmicrosoft/TypeScript

Documentation misleading on void encompassing null?

Just found a similar issue #16075, will do a PR to fix the docs.

aseemk

comment created time in 3 days

issue commentmicrosoft/TypeScript

null is not assignable to void when strictNullChecks are enabled

Not sure why the docs say that (maybe there was some confusion with function return types). Should edit to fix.

@RyanCavanaugh I would do a PR to fix this. Can't find where in the repo I should do this though.

Similar issue here: #11758, would probably also close that issue.

Gozala

comment created time in 3 days

startedagentcooper/typescript-play

started time in 3 days

issue commentaioutecism/amVim-for-VSCode

Screen Line/Character movement support

Yes, this is a caveat of this approach, motions like dj or 10j do not work. I would include this in the documentation.

rebornix

comment created time in 3 days

issue commentaioutecism/amVim-for-VSCode

Screen Line/Character movement support

@aioutecism I will test this for a while and if it continues to work well, I would open a pull request documenting this in the readme, if you'd be open to that.

rebornix

comment created time in 3 days

issue openedcodesandbox/codesandbox-client

Switching privacy back to public results in error

🐛 bug report

Description of the problem

Switching the privacy of a sandbox back to Public after it has been Private or Unlisted results in an error:

Screen Shot 2019-06-24 at 11 30 00 Screen Shot 2019-06-24 at 11 30 05 Screen Shot 2019-06-24 at 11 30 34 Screen Shot 2019-06-24 at 11 30 39

Setting the privacy works without errors when using the options in the context menu on the dashboard:

Screen Shot 2019-06-24 at 11 28 27

How has this issue affected you? What are you trying to accomplish?

My aim of trying to set the privacy of a sandbox back to Public from Private or Unlisted does not work.

Your Environment

Software Name/Version
Сodesandbox PROD-1561199685-a102c8493
Browser Chrome 75.0.3770.100
Operating System macOS 10.14.5

created time in 3 days

startedaioutecism/amVim-for-VSCode

started time in 3 days

issue commentaioutecism/amVim-for-VSCode

Screen Line/Character movement support

The keybindings below seem to work for amVim normal mode for moving among displayed lines in word wrapping mode (similar behavior to gj and gk).

Ref: My pull request to VSCodeVim https://github.com/VSCodeVim/Vim/pull/3623

  {
    "key": "up",
    "command": "cursorUp",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "down",
    "command": "cursorDown",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "k",
    "command": "cursorUp",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "j",
    "command": "cursorDown",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  }
rebornix

comment created time in 3 days

issue commentaioutecism/amVim-for-VSCode

j doesn't go to next "virtual" line like down-arrow does

The keybindings below seem to work for amVim normal mode for moving among displayed lines in word wrapping mode (similar behavior to gj and gk).

Ref: My pull request to VSCodeVim https://github.com/VSCodeVim/Vim/pull/3623

  {
    "key": "up",
    "command": "cursorUp",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "down",
    "command": "cursorDown",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "k",
    "command": "cursorUp",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "j",
    "command": "cursorDown",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl && !suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  }
lf94

comment created time in 3 days

pull request commentVSCodeVim/Vim

Document display line movement best practices

Yep, can confirm that this is happening for me too.

Not sure about a good workaround here... I tried adding the code at the bottom in settings.json, but it is pretty buggy in the first few minutes using it:

  • once the selection extends through an empty line, <kbd>k</kbd> cannot move upwards through that line again
  • the first time pressing <kbd>j</kbd> or <kbd>k</kbd> after entering visual mode, it moves down/up a full line

Kapture 2019-06-24 at 10 29 29

These issues may be related to #1323.

  // Caution: Buggy!
  "vim.visualModeKeyBindingsNonRecursive": [
    { "before": ["j"], "after": ["g", "j"] },
    { "before": ["k"], "after": ["g", "k"] }
  ],
karlhorky

comment created time in 3 days

pull request commentVSCodeVim/Vim

Document display line movement best practices

Ah I understand now, ok... I believe this is also happening for me in visual mode - will test in the next few hours.

I wonder if this is actually possible with these key bindings. Maybe the less performant option would work here:

https://github.com/VSCodeVim/Vim/issues/2924#issuecomment-476121848

karlhorky

comment created time in 3 days

startedjxnblk/contrast-swatch

started time in 3 days

startedWICG/layout-instability

started time in 3 days

pull request commentpalmerhq/tsdx

Update React template with ESM and type

Was https://github.com/jaredpalmer/formik/issues/625 the issue in Formik?

karlhorky

comment created time in 5 days

pull request commentpalmerhq/tsdx

Update React template with ESM and type

Either way it is a decision made by tsdx and recommended to users, also currently.

you force this decision onto all users of your library

I agree this is an unacceptable problem, and would like to know more about it. Maybe there's a way around it. And if not, maybe it should be reported as a bug.

karlhorky

comment created time in 5 days

pull request commentbasarat/typescript-book

Fix correctness and grammar

I agree, open source is great! No problem, glad to help!

karlhorky

comment created time in 5 days

PR opened JakeCooper/JakeCooper.me

Fix Twitter link

Hey, nice simple site! Another Victoria native, cool 🇨🇦

Quick PR to fix the Twitter URL.

+1 -1

0 comment

1 changed file

pr created time in 5 days

push eventkarlhorky/JakeCooper.me

Karl Horky

commit sha 262d8d39c2572500cf62073ad0d9cd119124302c

Fix Twitter link

view details

push time in 5 days

startedgiuseppeg/wai-aria-practices-tests

started time in 5 days

pull request commentpalmerhq/tsdx

Update React template with ESM and type

Hm, this is all news to me, so thanks for the link.

However, I think your interpretation of the sentiment is different than mine - the discussion in that thread isn't exactly ringing praise for this syntax:

Should we encourage people to import * for better tree shaking?

I guess this is not too bad, even if a bit odd:

And from your facebook/react#13080 PR:

Wouldn't we want to support import React from 'react' in an ESM environment too? While not ideal, not doing this could be pretty bad for all the tutorials and examples out there.

The last part is what I'm focusing on.

It may be better in the future to change this syntax in tutorials, examples and scaffolders, but that change should probably be done then, when (and if) it ever becomes standard/idiomatic.

karlhorky

comment created time in 5 days

issue commentzeit/next.js

[RFC] Dynamic Routes

Yeah this also happens for me with zsh. And since zsh will become default shell in macOS Catalina, maybe something should be done about this after all...

Timer

comment created time in 5 days

issue commentmicrosoft/TypeScript-React-Starter

Please abandon this repo

Maybe archiving the repo would also be a good idea.

chriskuech

comment created time in 5 days

pull request commentpalmerhq/tsdx

Update React template with ESM and type

anyone using tsdx will well be able to tweak that file on their own project-by-project decision

Both true.

However I would argue that since you are making a zero-config scaffolder for new projects, you are in the unique position of teaching people that are new to a language or framework what the common defaults are in the ecosystem with your choices of default templates. Some users (both beginners and not) will want and place weight in the suggestion from you, and starting with a suggestion that doesn't match the majority of React teaching materials is confusing.

As a further reference, scaffolding out a TS app with create-react-app does the thing that I did in this PR.

IIRC from Formik if you do this in your lib, you force ppl consuming it to do it as well

This would potentially be an issue, do you have a reference for this?

karlhorky

comment created time in 5 days

startednearform/sql

started time in 5 days

startedniieani/typescript-vs-flowtype

started time in 5 days

issue commentjxnblk/mdx-deck

Slide styling

For those who cannot upgrade to v2 yet (such as users of code-surfer), here's an ugly temporary workaround / hack for styling Slides with a provider (haven't tested this extensively yet):

Provider.js

import React from 'react';

export default function Provider({ children }) {
  return (
    <>
      {/*
        Hack to give Slide components a relative
        position (for absolute positioning further
        down)
      */}
      <style
        dangerouslySetInnerHTML={{
          __html: `
            [class^="Slide__Root-"] {
              // Your styles here
            }
          `,
        }}
      />
      {children}
    </>
  );
}

theme.js

import { default as theme } from 'mdx-deck/themes';
import Provider from './Provider';

export default {
  ...theme,
  Provider,
};
signalwerk

comment created time in 6 days

delete branch karlhorky/electrode-scoped-archetypes-demo

delete branch : scope-modules

delete time in 6 days

PR closed karlhorky/electrode-scoped-archetypes-demo

Scope modules

Example PR to show archetype forking process for electrode-io/electrode#254

+51 -42

0 comment

30 changed files

karlhorky

pr closed time in 6 days

delete branch karlhorky/react-malarkey

delete branch : dependabot/npm_and_yarn/eslint-4.18.2

delete time in 6 days

push eventkarlhorky/react-malarkey

dependabot[bot]

commit sha 3b48f0ea52b26521ec481a0ce5dc0e69d701e2af

Bump eslint from 1.10.3 to 4.18.2 Bumps [eslint](https://github.com/eslint/eslint) from 1.10.3 to 4.18.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v1.10.3...v4.18.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Karl Horky

commit sha cbd4fef934ebbaa2d6dab80b7edc7f63c241324c

Bump eslint from 1.10.3 to 4.18.2 (#5) Bump eslint from 1.10.3 to 4.18.2

view details

push time in 6 days

PR merged karlhorky/react-malarkey

Bump eslint from 1.10.3 to 4.18.2 dependencies

Bumps eslint from 1.10.3 to 4.18.2. <details> <summary>Release notes</summary>

Sourced from eslint's releases.

v4.18.2

  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)
  • 33177cd Chore: make library files non-executable (#10021) (Teddy Katz)
  • 558ccba Chore: refactor directive comment processing (#10007) (Teddy Katz)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)

v4.18.1

  • f417506 Fix: ensure no-await-in-loop reports the correct node (fixes #9992) (#9993) (Teddy Katz)
  • 3e99363 Docs: Fixed typo in key-spacing rule doc (#9987) (Jaid)
  • 7c2cd70 Docs: deprecate experimentalObjectRestSpread (#9986) (Toru Nagashima)

v4.18.0

  • 70f22f3 Chore: Apply memoization to config creation within glob utils (#9944) (Kenton Jacobsen)
  • 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951) (Teddy Katz)
  • 47ac478 Update: add named imports and exports for object-curly-newline (#9876) (Nicholas Chua)
  • e8efdd0 Fix: support Rest/Spread Properties (fixes #9885) (#9943) (Toru Nagashima)
  • f012b8c Fix: support Async iteration (fixes #9891) (#9957) (Toru Nagashima)
  • 74fa253 Docs: Clarify no-mixed-operators options (fixes #9962) (#9964) (Ivan Hayes)
  • 426868f Docs: clean up key-spacing docs (fixes #9900) (#9963) (Abid Uzair)
  • 4a6f22e Update: support eslint-disable-* block comments (fixes #8781) (#9745) (Erin)
  • 777283b Docs: Propose fix typo for function (#9965) (John Eismeier)
  • bf3d494 Docs: Fix typo in max-len ignorePattern example. (#9956) (Tim Martin)
  • d64fbb4 Docs: fix typo in prefer-destructuring.md example (#9930) (Vse Mozhet Byt)
  • f8d343f Chore: Fix default issue template (#9946) (Kai Cataldo)

v4.17.0

  • 1da1ada Update: Add "multiline" type to padding-line-between-statements (#8668) (Matthew Bennett)
  • bb213dc Chore: Use messageIds in some of the core rules (#9648) (Jed Fox)
  • 1aa1970 Docs: remove outdated rule naming convention (#9925) (Teddy Katz)
  • 3afaff6 Docs: Add prefer-destructuring variable reassignment example (#9873) (LePirlouit)
  • d20f6b4 Fix: Typo in error message when running npm (#9866) (Maciej Kasprzyk)
  • 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (#9911) (Kai Cataldo)
  • dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) (#9906) (Kevin Partington)
  • 084351b Docs: Fix the messageId example (fixes #9889) (#9892) (Jed Fox)
  • 9cbb487 Docs: Mention the globals key in the no-undef docs (#9867) (Dan Dascalescu)

v4.16.0

  • e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)
  • af043eb Update: Add NewExpression support to comma-style (#9591) (Frazer McLean)
  • 4f898c7 Build: Fix JSDoc syntax errors (#9813) (Matija Marohnić)
  • 13bcf3c Fix: Removing curly quotes in no-eq-null report message (#9852) (Kevin Partington)
  • b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes #9526) (#9855) (PiIsFour)
  • 8ccbdda Docs: Clarify that -c configs merge with .eslintrc.* (fixes #9535) (#9847) (Kevin Partington)
  • 978574f Docs: Fix examples for no-useless-escape (#9853) (Toru Kobayashi) </tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from eslint's changelog.

v4.18.2 - March 2, 2018

  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)
  • 33177cd Chore: make library files non-executable (#10021) (Teddy Katz)
  • 558ccba Chore: refactor directive comment processing (#10007) (Teddy Katz)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)

v4.18.1 - February 20, 2018

  • f417506 Fix: ensure no-await-in-loop reports the correct node (fixes #9992) (#9993) (Teddy Katz)
  • 3e99363 Docs: Fixed typo in key-spacing rule doc (#9987) (Jaid)
  • 7c2cd70 Docs: deprecate experimentalObjectRestSpread (#9986) (Toru Nagashima)

v4.18.0 - February 16, 2018

  • 70f22f3 Chore: Apply memoization to config creation within glob utils (#9944) (Kenton Jacobsen)
  • 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951) (Teddy Katz)
  • 47ac478 Update: add named imports and exports for object-curly-newline (#9876) (Nicholas Chua)
  • e8efdd0 Fix: support Rest/Spread Properties (fixes #9885) (#9943) (Toru Nagashima)
  • f012b8c Fix: support Async iteration (fixes #9891) (#9957) (Toru Nagashima)
  • 74fa253 Docs: Clarify no-mixed-operators options (fixes #9962) (#9964) (Ivan Hayes)
  • 426868f Docs: clean up key-spacing docs (fixes #9900) (#9963) (Abid Uzair)
  • 4a6f22e Update: support eslint-disable-* block comments (fixes #8781) (#9745) (Erin)
  • 777283b Docs: Propose fix typo for function (#9965) (John Eismeier)
  • bf3d494 Docs: Fix typo in max-len ignorePattern example. (#9956) (Tim Martin)
  • d64fbb4 Docs: fix typo in prefer-destructuring.md example (#9930) (Vse Mozhet Byt)
  • f8d343f Chore: Fix default issue template (#9946) (Kai Cataldo)

v4.17.0 - February 2, 2018

  • 1da1ada Update: Add "multiline" type to padding-line-between-statements (#8668) (Matthew Bennett)
  • bb213dc Chore: Use messageIds in some of the core rules (#9648) (Jed Fox)
  • 1aa1970 Docs: remove outdated rule naming convention (#9925) (Teddy Katz)
  • 3afaff6 Docs: Add prefer-destructuring variable reassignment example (#9873) (LePirlouit)
  • d20f6b4 Fix: Typo in error message when running npm (#9866) (Maciej Kasprzyk)
  • 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (#9911) (Kai Cataldo)
  • dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) (#9906) (Kevin Partington)
  • 084351b Docs: Fix the messageId example (fixes #9889) (#9892) (Jed Fox)
  • 9cbb487 Docs: Mention the globals key in the no-undef docs (#9867) (Dan Dascalescu)

v4.16.0 - January 19, 2018

  • e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)
  • af043eb Update: Add NewExpression support to comma-style (#9591) (Frazer McLean) </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • 22ff6f3 4.18.2
  • 817b84b Build: changelog update for 4.18.2
  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020)
  • 33177cd Chore: make library files non-executable (#10021)
  • 558ccba Chore: refactor directive comment processing (#10007)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010)
  • Additional commits viewable in compare view </details> <details> <summary>Maintainer changes</summary>

This version was pushed to npm by eslint, a new releaser for eslint since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+478 -1143

0 comment

2 changed files

dependabot[bot]

pr closed time in 6 days

delete branch karlhorky/menubar-time-tracker

delete branch : dependabot/npm_and_yarn/eslint-4.18.2

delete time in 6 days

push eventkarlhorky/menubar-time-tracker

dependabot[bot]

commit sha 9241c1254463fb51e8ed129dedfeeeb956b5f3bf

Bump eslint from 3.19.0 to 4.18.2 Bumps [eslint](https://github.com/eslint/eslint) from 3.19.0 to 4.18.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v3.19.0...v4.18.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Karl Horky

commit sha 94ea984ba0583b7ac841bd9a8606223c2cd031a9

Bump eslint from 3.19.0 to 4.18.2 (#1) Bump eslint from 3.19.0 to 4.18.2

view details

push time in 6 days

PR merged karlhorky/menubar-time-tracker

Bump eslint from 3.19.0 to 4.18.2 dependencies

Bumps eslint from 3.19.0 to 4.18.2. <details> <summary>Release notes</summary>

Sourced from eslint's releases.

v4.18.2

  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)
  • 33177cd Chore: make library files non-executable (#10021) (Teddy Katz)
  • 558ccba Chore: refactor directive comment processing (#10007) (Teddy Katz)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)

v4.18.1

  • f417506 Fix: ensure no-await-in-loop reports the correct node (fixes #9992) (#9993) (Teddy Katz)
  • 3e99363 Docs: Fixed typo in key-spacing rule doc (#9987) (Jaid)
  • 7c2cd70 Docs: deprecate experimentalObjectRestSpread (#9986) (Toru Nagashima)

v4.18.0

  • 70f22f3 Chore: Apply memoization to config creation within glob utils (#9944) (Kenton Jacobsen)
  • 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951) (Teddy Katz)
  • 47ac478 Update: add named imports and exports for object-curly-newline (#9876) (Nicholas Chua)
  • e8efdd0 Fix: support Rest/Spread Properties (fixes #9885) (#9943) (Toru Nagashima)
  • f012b8c Fix: support Async iteration (fixes #9891) (#9957) (Toru Nagashima)
  • 74fa253 Docs: Clarify no-mixed-operators options (fixes #9962) (#9964) (Ivan Hayes)
  • 426868f Docs: clean up key-spacing docs (fixes #9900) (#9963) (Abid Uzair)
  • 4a6f22e Update: support eslint-disable-* block comments (fixes #8781) (#9745) (Erin)
  • 777283b Docs: Propose fix typo for function (#9965) (John Eismeier)
  • bf3d494 Docs: Fix typo in max-len ignorePattern example. (#9956) (Tim Martin)
  • d64fbb4 Docs: fix typo in prefer-destructuring.md example (#9930) (Vse Mozhet Byt)
  • f8d343f Chore: Fix default issue template (#9946) (Kai Cataldo)

v4.17.0

  • 1da1ada Update: Add "multiline" type to padding-line-between-statements (#8668) (Matthew Bennett)
  • bb213dc Chore: Use messageIds in some of the core rules (#9648) (Jed Fox)
  • 1aa1970 Docs: remove outdated rule naming convention (#9925) (Teddy Katz)
  • 3afaff6 Docs: Add prefer-destructuring variable reassignment example (#9873) (LePirlouit)
  • d20f6b4 Fix: Typo in error message when running npm (#9866) (Maciej Kasprzyk)
  • 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (#9911) (Kai Cataldo)
  • dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) (#9906) (Kevin Partington)
  • 084351b Docs: Fix the messageId example (fixes #9889) (#9892) (Jed Fox)
  • 9cbb487 Docs: Mention the globals key in the no-undef docs (#9867) (Dan Dascalescu)

v4.16.0

  • e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)
  • af043eb Update: Add NewExpression support to comma-style (#9591) (Frazer McLean)
  • 4f898c7 Build: Fix JSDoc syntax errors (#9813) (Matija Marohnić)
  • 13bcf3c Fix: Removing curly quotes in no-eq-null report message (#9852) (Kevin Partington)
  • b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes #9526) (#9855) (PiIsFour)
  • 8ccbdda Docs: Clarify that -c configs merge with .eslintrc.* (fixes #9535) (#9847) (Kevin Partington)
  • 978574f Docs: Fix examples for no-useless-escape (#9853) (Toru Kobayashi) </tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from eslint's changelog.

v4.18.2 - March 2, 2018

  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)
  • 33177cd Chore: make library files non-executable (#10021) (Teddy Katz)
  • 558ccba Chore: refactor directive comment processing (#10007) (Teddy Katz)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)

v4.18.1 - February 20, 2018

  • f417506 Fix: ensure no-await-in-loop reports the correct node (fixes #9992) (#9993) (Teddy Katz)
  • 3e99363 Docs: Fixed typo in key-spacing rule doc (#9987) (Jaid)
  • 7c2cd70 Docs: deprecate experimentalObjectRestSpread (#9986) (Toru Nagashima)

v4.18.0 - February 16, 2018

  • 70f22f3 Chore: Apply memoization to config creation within glob utils (#9944) (Kenton Jacobsen)
  • 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951) (Teddy Katz)
  • 47ac478 Update: add named imports and exports for object-curly-newline (#9876) (Nicholas Chua)
  • e8efdd0 Fix: support Rest/Spread Properties (fixes #9885) (#9943) (Toru Nagashima)
  • f012b8c Fix: support Async iteration (fixes #9891) (#9957) (Toru Nagashima)
  • 74fa253 Docs: Clarify no-mixed-operators options (fixes #9962) (#9964) (Ivan Hayes)
  • 426868f Docs: clean up key-spacing docs (fixes #9900) (#9963) (Abid Uzair)
  • 4a6f22e Update: support eslint-disable-* block comments (fixes #8781) (#9745) (Erin)
  • 777283b Docs: Propose fix typo for function (#9965) (John Eismeier)
  • bf3d494 Docs: Fix typo in max-len ignorePattern example. (#9956) (Tim Martin)
  • d64fbb4 Docs: fix typo in prefer-destructuring.md example (#9930) (Vse Mozhet Byt)
  • f8d343f Chore: Fix default issue template (#9946) (Kai Cataldo)

v4.17.0 - February 2, 2018

  • 1da1ada Update: Add "multiline" type to padding-line-between-statements (#8668) (Matthew Bennett)
  • bb213dc Chore: Use messageIds in some of the core rules (#9648) (Jed Fox)
  • 1aa1970 Docs: remove outdated rule naming convention (#9925) (Teddy Katz)
  • 3afaff6 Docs: Add prefer-destructuring variable reassignment example (#9873) (LePirlouit)
  • d20f6b4 Fix: Typo in error message when running npm (#9866) (Maciej Kasprzyk)
  • 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (#9911) (Kai Cataldo)
  • dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) (#9906) (Kevin Partington)
  • 084351b Docs: Fix the messageId example (fixes #9889) (#9892) (Jed Fox)
  • 9cbb487 Docs: Mention the globals key in the no-undef docs (#9867) (Dan Dascalescu)

v4.16.0 - January 19, 2018

  • e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)
  • af043eb Update: Add NewExpression support to comma-style (#9591) (Frazer McLean) </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • 22ff6f3 4.18.2
  • 817b84b Build: changelog update for 4.18.2
  • 6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020)
  • 33177cd Chore: make library files non-executable (#10021)
  • 558ccba Chore: refactor directive comment processing (#10007)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010)
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+308 -209

0 comment

2 changed files

dependabot[bot]

pr closed time in 6 days

issue commentbasarat/typescript-book

TypeScript venn diagram on “Your JS is TS” page is misleading

@basarat thanks! Just fixed some correctness, spelling and grammar errors: #506

The original commit mentioned "TypeScript does add support for proposals till they reach stage-3", which is actually the opposite of what is correct :)

j-f1

comment created time in 6 days

PR opened basarat/typescript-book

Fix correctness and grammar

Thanks for this project!

Fixes some correctness, spelling and grammar errors from 0dd1e6bace619de125a37a0664380c1ea2adc75f.

+1 -1

0 comment

1 changed file

pr created time in 6 days

push eventkarlhorky/typescript-book

Karl Horky

commit sha 3f52b72580a059aa7b5cc229d9e15a2cd1aa1a59

Fix correctness and grammar

view details

push time in 6 days

fork karlhorky/typescript-book

:books: The definitive guide to TypeScript and possibly the best TypeScript book :book:. Free and Open Source 🌹

http://basarat.gitbooks.io/typescript/content/docs/getting-started.html

fork in 6 days

delete branch karlhorky/tsdx

delete branch : patch-1

delete time in 6 days

issue commentcodesandbox/codesandbox-client

Accept folders with upload button

Hm, there was originally a Chrome-only polyfill from WICG, but that was for a previous version of the spec.

I guess the latest advice (from makandra dev) is to use webkitdirectory along with the multiple attribute for older browsers:

Although the property is called webkitdirectory and not directory, it is supported by Chrome, Firefox, Edge 14+, and Safari 11.1+. Older browsers support multiple, so you should offer that as a fallback.

Your event handler needs to handle event.target.files just like for a multiple input.

I've seen examples using directory but there are no indications this attribute will become standard soon.

So maybe something like this?

<input type="file" multiple webkitdirectory>
karlhorky

comment created time in 6 days

startedWICG/directory-upload

started time in 6 days

issue commentcodesandbox/codesandbox-client

Accept folders with upload button

Ah TIL too! Cool :) wonder if there's a polyfill for it...

karlhorky

comment created time in 6 days

issue commentbasarat/typescript-book

TypeScript venn diagram on “Your JS is TS” page is misleading

Yeah I would like to see some mention of the support (and philosophy behind it).

It seems like the current standard is Stage 3 of the TC39 process:

https://github.com/Microsoft/TypeScript/issues/2103#issuecomment-182195915

https://www.reddit.com/r/typescript/comments/72k0x7/when_does_typescript_generally_support_new_js/

j-f1

comment created time in 7 days

pull request commentpalmerhq/tsdx

Update React template with ESM and type

Actually it will be the only way to import react in a few years

Hm, interesting to hear this, what's your source? Haven't seen anything pointing to that in the ecosystem...

But that notwithstanding, the idiomatic way to import React currently in the official documentation and any non-TypeScript tutorial is currently import React from 'react'; so it seems like we should stick with this for now.

karlhorky

comment created time in 7 days

issue commentpalmerhq/tsdx

[feature?] run `yarn init` right after to initialize package.json details. possibly git init too.

FWIW was just thinking this same thing, was going to submit an issue :)

Just leaving this here on the closed issue then!

sw-yx

comment created time in 8 days

PR opened palmerhq/tsdx

Update React template with ESM and type

Hey, thanks for this project, really great work!

Because we have compilerOptions.esModuleInterop set to true in tsconfig.json, we can add the normal ES Modules syntax for importing React, or am I missing something? And we can use the React.FC type for the dummy component.

+2 -2

0 comment

1 changed file

pr created time in 8 days

push eventkarlhorky/tsdx

Karl Horky

commit sha b13a1e19b126ce98ff3cb57b529aada20aebca74

Update React template with ESM and type

view details

push time in 8 days

fork karlhorky/tsdx

Zero-config CLI for TypeScript package development

https://npm.im/tsdx

fork in 8 days

issue commentpalmerhq/tsdx

Use Babel 7 TS compilation and forked checker?

Ah it looks like there is an issue in the rollup-plugin-typescript2 repo that is asking for this feature: https://github.com/ezolenko/rollup-plugin-typescript2/issues/113

So that may be a possible solution, in case that gets implemented.

karlhorky

comment created time in 8 days

issue openedpalmerhq/tsdx

Use Babel 7 TS compilation and forked checker?

Current Behavior

TypeScript is both compiled and checked by rollup-plugin-typescript2.

Desired Behavior / Suggested Solution / Alternatives

What are your thoughts on adding something to run type-checking code in a separate process, like fork-ts-checker-webpack-plugin?

Looks like this would either require moving away from Rollup or finding a plugin that does this.

Who does this impact? Who is this for?

tsdx users

created time in 8 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Update readme to indicate that the official version is the most current

@johnnyreilly The commit 2d0c11c95f13cb7d80ee57db685765f5b24e9699 somehow got lost in the git history (maybe due to a force push?).

The message was only online from April 6 to April 17.

I also had this issue today and was also confused.

Can this message be added back? Maybe in a heading?

aaronjensen

comment created time in 8 days

issue commentsindresorhus/refined-github

Layout Jumping During Fetching of Latest Commit

@jerone macOS Chrome 75.0.3770.90 (Official Build) (64-bit)

Note: it doesn't always happen - just when the "Fetching latest commit..." message appears.

karlhorky

comment created time in 8 days

startedprecious/bash_minifier

started time in 8 days

startedkefranabg/readme-md-generator

started time in 8 days

push eventkarlhorky/github-tricks

Karl Horky

commit sha 97d37e36cc0e17923a36d95d3e69959199ca9154

Add example of README symlink

view details

push time in 8 days

more