Karl Horky karlhorky @upleveled Vienna https://twitter.com/karlhorky Founder, Teacher. Canadian/Austrian. he/him

pull request commentWICG/focus-visible

Any focus proceeded by a keypress should trigger focus-visible.

Ah cool, you're on it already! Nice 🙌. Watching now.

robdodson

comment created time in 10 hours

pull request commentWICG/focus-visible

Any focus proceeded by a keypress should trigger focus-visible.

I can also open this as a new issue, if that would be more appropriate.

robdodson

comment created time in 17 hours

pull request commentWICG/focus-visible

Any focus proceeded by a keypress should trigger focus-visible.

First of all, thanks for this library. Really liking the polyfill efforts from standards orgs.

What issue does this pull request solve? It seems to be the cause of unusual behavior when using <kbd>cmd</kbd>-<kbd>tab</kbd> to switch away from browser windows:

  1. User has used the mouse to select elements. No focus styles applied.
  2. User hits the <kbd>cmd</kbd> key for a fraction of a second before hitting <kbd>tab</kbd> to switch to another window.
  3. Focus styles appear for this fraction of a second, causing a confusing flash of styles before the window switches.

A simple reproduction can be seen on the demo page, where a press on the <kbd>cmd</kbd> key after mouse-only selection causes the focus style to be applied:

Kapture 2019-04-24 at 11 56 07

The flashing of styles while using <kbd>cmd</kbd>-<kbd>tab</kbd> does not appear in version 4.0.1 of the library.


If there's a very important reason that the changes from this pull request were made, maybe there can be a smaller blacklist of modifier keys (window and tab switching keys, for example) that it won't trigger on?

robdodson

comment created time in 17 hours

pull request commentFormidableLabs/prism-react-renderer

Fix token aliases and upgrade Prism

Approach sounds pretty good to me! What does the support for token aliases enable?

kitten

comment created time in 17 hours

startedmikolajdobrucki/ikonate

started time in a day

push eventkarlhorky/dotfiles

Karl Horky

commit sha 5d2fd97b54dd688e79c38e2f83076c16c50dadee

Add Automator workflows readme

view details

push time in a day

push eventkarlhorky/dotfiles

Karl Horky

commit sha 9120ee5470f433cfd93e0304a282983bb2653d73

Fix cask name

view details

Karl Horky

commit sha 1e001f9b2b7c98790fcab797d476aef2bc561ab0

Comment out unused software

view details

Karl Horky

commit sha 4a0af0e349e67da8ef21bb25724e40d713139797

Add new Automator workflows

view details

push time in a day

issue commentImageOptim/ImageOptim

Automator action

Here's an Automator workflow that worked for me:

ImageOptim.workflow.zip

Screen Shot 2019-04-23 at 19 53 07

Screen Shot 2019-04-23 at 19 54 56

pathawks

comment created time in a day

startedreach/reach-ui

started time in a day

startedImageOptim/ImageOptim

started time in a day

push eventkarlhorky/dotfiles

Karl Horky

commit sha cf6dd7e8d27c2ac3d2a29dc5d3cd99e406f2dfef

Make current line background solid

view details

Karl Horky

commit sha 4d32b4b0868798cddbc1a00ca515a58cc506bed1

Fix missing second arg

view details

Karl Horky

commit sha cfe194886c07774b42cacb78d0299edac1b46c28

Add ImageOptim-CLI and related software

view details

Karl Horky

commit sha c6fa995f58b15ebea5b955df1bd8b31438aae8ff

Add Optimage

view details

push time in a day

startedJamieMason/ImageOptim-CLI

started time in a day

issue commentJamieMason/ImageOptim-CLI

Dismiss JPEGmini Welcome Panel

I'm assuming both of these problems are known issues with version 2.0.4?

The current workaround that I am using (didn't find this documented anywhere in the readme) is to manually open JPEGmini Lite before using the CLI and manually click on the "Use JPEGmini Lite" button.

Would it be a good idea to document this somewhere?

JamieMason

comment created time in a day

issue commentJamieMason/ImageOptim-CLI

Dismiss JPEGmini Welcome Panel

This seems to also be similar to the JPEGmini Lite welcome screen, which also needs to be manually dismissed:

Screen Shot 2019-04-23 at 18 10 08

Or should I submit this as a separate issue?

JamieMason

comment created time in a day

issue commentjxnblk/mdx-deck

Mobile layout & touchscreen UI

@appsforartists Seems like #69 added invisible Previous and Next buttons to the UI already.

Screen Shot 2019-04-20 at 15 02 46

Example here:

https://relay-modern-course.now.sh/packages/01-setup/#0

If you want the buttons to be visible, it seems like a good bet to build a custom provider: https://github.com/jxnblk/mdx-deck/blob/master/docs/advanced.md#custom-provider-component

jxnblk

comment created time in 5 days

PR opened jxnblk/mdx-deck

Fix link syntax
+1 -1

0 comment

1 changed file

pr created time in 5 days

push eventkarlhorky/mdx-deck

Karl Horky

commit sha 72ce69f93f782ba5329345fbdfdbc79100a1a5ad

Fix link syntax

view details

push time in 5 days

fork karlhorky/mdx-deck

:spades: MDX-based presentation decks

https://mdx-deck.jxnblk.com

fork in 5 days

startedjkelleyrtp/notionapi

started time in 7 days

push eventkarlhorky/dotfiles

Karl Horky

commit sha 41d89a082585b4d613a91c7929b678ef6dab30cb

Add Flume

view details

push time in 8 days

issue closedrebassjs/rebass

Favicon for docs?

Hi, first of all, thanks for this project!

It would be nice to have a favicon to identify the tabs when no titles are shown (see screenshot below). It looks like the docs are being built with gx, but I didn't see on first glance where a PR would be made for a favicon.

Screen Shot 2019-04-09 at 11 00 30

Maybe an option would be a monochrome / adapted version of the logo image?

<img width=250 src=https://camo.githubusercontent.com/4f6ca9438a3e45f9b409158503f3deebc86a793d/68747470733a2f2f7265626173736a732e6f72672f6c6f676f2e737667>

closed time in 9 days

karlhorky

issue commentrebassjs/rebass

Favicon for docs?

Ok this sounds like a plan. I took a look through the project (I've filed this issue in the wrong repo) and found the files that will be probably interesting to me.

I've documented these decisions in rebassjs/rebassjs.org#15. Closing this.

karlhorky

comment created time in 9 days

issue openedrebassjs/rebassjs.org

Favicon for docs

Continuing the discussion from rebassjs/rebass#584:


I will use a combination of repng, scrs --svg and potentially other libraries such as png-to-ico to generate the necessary files. For the start, we can probably stick with:

  1. a 48x48 or 32x32 ico
  2. a larger png
  3. an Apple Touch icon (need to automate editing the icon for this?)

Original text for clarity and searchability:

Hi, first of all, thanks for this project!

It would be nice to have a favicon to identify the tabs when no titles are shown (see screenshot below). It looks like the docs are being built with gx, but I didn't see on first glance where a PR would be made for a favicon.

Screen Shot 2019-04-09 at 11 00 30

Maybe an option would be a monochrome / adapted version of the logo image?

<img width=250 src=https://camo.githubusercontent.com/4f6ca9438a3e45f9b409158503f3deebc86a793d/68747470733a2f2f7265626173736a732e6f72672f6c6f676f2e737667>

created time in 9 days

startedachael/eht-imaging

started time in 9 days

startedlukeed/dimport

started time in 9 days

startedreactrewind/react-rewind

started time in 9 days

startedpelotom/use-methods

started time in 9 days

issue commentrebassjs/rebass

Favicon for docs?

Cool, I'll do that then when I get a chance.

Do you have a vector non-animated version of the logo handy?

karlhorky

comment created time in 10 days

push eventupleveled/md2pdf

Karl Horky

commit sha 2f76e3f5543ba4c3c47e8e0e62d893e27c19d79a

Link to md-to-pdf as alternative

view details

push time in 13 days

push eventupleveled/md2pdf

Karl Horky

commit sha e6595905d8d2a98e091f70ab4484e630e269a4e4

Add npx link

view details

push time in 13 days

push eventupleveled/md2pdf

Karl Horky

commit sha 854b2d26c61391cb466dcd97f8c67374052aafa4

Add section about style

view details

push time in 13 days

pull request commentVSCodeVim/Vim

Add note about unsupported motions

Okay, seems like you have some pretty strong opinions. Since you're the sole maintainer at the moment, if we don't find another way, then it seems like it's that is the way to go.

Some responses (TLDR: maybe we can get more maintainers instead?):

People won't need to go through the whole fork/PR flow to edit docs. Hopefully in removing that barrier we'll have more people contributing.

I would propose that forking + PR + review + approval is such standard practice and no less well-known than editing the Wiki (which may or may not exist for a GitHub project - readmes are almost always present).

Time. I'm the only active maintainer of this project at the moment and with a several month old 👶+ my day job, I have limited time to keep up-to-date and respond to PRs and issues

Totally get this. Maybe the solution is not a new tool, but another maintainer? I'm sure there are a lot of passionate people that would like to get involved here (myself included). Maybe open a call for co-maintainers?

If angular/react are able to do solve this, why can't we?

Angular.js is the old pre-v2 Angular. The new Angular does not use GitHub wikis.

And React is not using a wiki, they have their own docs site:

Screen Shot 2019-04-12 at 10 10 38

I have not seen GitHub wikis effectively implemented in open source projects except for a few academic project exceptions. And even then, it was confusing to have them separate from the other documentation in the project (which was in code).

Portability? Not sure I see your argument there. Forking the repo will also fork the wiki AFAIK.

Portability is not just about forking. Cloning the project does not clone the wiki (you have to use a separate URL for this, which again, may or may not exist). And once forked, the wiki doesn't follow the normal PR flow.

With a wiki, folks can share their own settings.json files with the community at large

This is the first use case that I would agree justifies a new tool. But I would suggest to do this separately and only for community discussions. And now that GitHub has acquired and integrated Spectrum, maybe that would be a better option for a community platform.

Organization. The Readme is a hella verbose to the point it's getting hard to find things unless you know where to look. A wiki will help us put these into sections and such.

Interesting, I actually see this as a plus. I like going to one page and being able to use the super-fast Find in Page in my browser to find the information that I need. For example, I like the Ramda docs. create-react-app also had their docs in one markdown page for a bit (now they are fairly established and can support a full docs site).

karlhorky

comment created time in 13 days

startedkitten/sweetsour

started time in 13 days

startedxtuc/webassembly-feature

started time in 13 days

issue commentGoogleChrome/chromium-dashboard

Make 'Doc link(s)' field and 'Explainer link(s)' field optional.

Good idea, I've added the link to the original description too!

karlhorky

comment created time in 14 days

issue commentrebassjs/rebass

Issues with "as" vs "is" props in V3

Maybe this should be either documented in the rebass docs or the as change reverted until styled-components fixes their issue?

trying to solve it in user land has historically caused a lot of other issues

Or do the other issues with providing as in the API again outweigh this? What are the issues @jxnblk?

ntaylor89

comment created time in 14 days

pull request commentVSCodeVim/Vim

Add note about unsupported motions

I would suggest against GitHub wikis.

It moves the documentation out of code into a proprietary system (which first of all means, one more thing to maintain, one more system to have to configure).

I have found that it decreases visibility of the documentation too, leading to confusing situations and splintered SEO.

Having the documentation in code allows for portability and also interesting other features, such as updating the documentation for features as part of their pull requests.

I don't see any positives from moving to a GitHub wiki.


If the VSCodeVim team decides to nevertheless go for a GitHub wiki after consideration, I will update the wiki.

karlhorky

comment created time in 14 days

Pull request review commentstyled-system/styled-system

Add website icon

 const Page = props => {     <>       <Helmet>         <title>{title}</title>+        <link rel='shortcut icon' type='image/x-icon' href='/favicon.ico'/>

Maybe one of the following npm packages? I just did a quick search for "svg to ico npm" on Google:

  • https://www.npmjs.com/package/favicons
  • https://www.npmjs.com/package/icon-gen
mukeshmandiwal

comment created time in 14 days

issue commentGoogleChrome/chromium-dashboard

SVG Favicons: broken Documentation/samples link

Ah looks like there was just a huge delay opening it on the blink-dev group:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ArW2aAZJOnI

Feel free to close this if GitHub is not the right place.

karlhorky

comment created time in 14 days

push eventkarlhorky/Vim

Karl Horky

commit sha b814f720de147f6f40a1ba1394d537d801a35d29

Remove extra whitespace

view details

push time in 15 days

push eventkarlhorky/Vim

Karl Horky

commit sha 265182e1ad0ebb0c031b730a97a025994d8f58c9

Remove extra line

view details

push time in 15 days

pull request commentVSCodeVim/Vim

Document display line movement best practices

@AlexPattison ah that's no good. I've opened #3670 to document this and reword the note about the less-performant alternatives.

karlhorky

comment created time in 15 days

PR opened VSCodeVim/Vim

Add note about unsupported motions

What this PR does / why we need it:

As @AlexPattison mentions in https://github.com/VSCodeVim/Vim/pull/3623#issuecomment-481473981, there is a caveat that causes motions involving <kbd>j</kbd> and <kbd>k</kbd> to not work with the performant line-wrapping solution.

Which issue(s) this PR fixes

This documents the issue as well as linking to a solution if this caveat is unacceptable to users.

cc @jpoon @AlexPattison

+4 -1

0 comment

1 changed file

pr created time in 15 days

push eventkarlhorky/Vim

Karl Horky

commit sha bb69004a4cca62160a1b5e3d8a0ac3b81ba0cc27

Add note about unsupported motions

view details

push time in 15 days

fork karlhorky/Vim

:star: Vim for Visual Studio Code

http://aka.ms/vscodevim

fork in 15 days

issue openedGoogleChrome/chromium-dashboard

SVG Favicons: broken Documentation/samples link

Before I start, I want to mention that I tried submitting this to the "File a content issue" link 3 times, but it didn't work (it said "successfully posted" but then did not show up in the list of topics).

So I'm submitting here.


Thanks for this resource, first of all! It's super helpful for looking at the progress of features on the web.

I clicked on the "Link 1" link in the Support for SVG in favicons section, but it appears to go to https://www.chromestatus.com/features/No%20design%20doc , which doesn't exist.

Screen Shot 2019-04-10 at 15 00 19

I wanted to open a pull request here on GitHub, but I couldn't find the content that I was supposed to edit there (or even if it was on GitHub at all).

created time in 15 days

startedbeverloo/contact-api

started time in 15 days

issue commentjxnblk/mdx-deck

Support for building multiple presentations or custom export filenames

One further use case for building multiple slideshow decks would be to enable quick switching between them during a longer course.

For example, if I have 5 different presentations that I would like to present over the course of a day (but not deploy online), it would be nice to be able to switch between them in an easy way. To achieve this, I could imagine the following workflow:

  1. building all presentations ...and...
  2. building a list page linking to all presentations (like this list from this repo)
chrisjpatty

comment created time in 16 days

pull request commentstyled-system/styled-system

Add website icon

You may also want to consider generating some other versions of the favicon with something like RealFaviconGenerator (you could take a look at my PR here: keepassxreboot/keepassxreboot.github.io#54)

mukeshmandiwal

comment created time in 16 days

pull request commentstyled-system/styled-system

Add website icon

Hm, that will have problems on non-dark mode tabs, wouldn't it?

I guess my suggestion would be to fill in the transparent parts as well as a 2 pixel margin around it with white (2 pixels when it's shrunk to favicon size).

Something that would look like this:

mukeshmandiwal

comment created time in 16 days

pull request commentstyled-system/styled-system

Add website icon

Maybe we should have a background color for dark mode? So that the favicon doesn't show black on dark gray like GitHub?

Screen Shot 2019-04-09 at 11 17 07

mukeshmandiwal

comment created time in 16 days

startedrebassjs/rebass

started time in 16 days

issue openedrebassjs/rebass

Favicon for docs?

Hi, first of all, thanks for this project!

As in TBD, it would be nice to have a favicon to identify the tabs when no titles are shown (see screenshot below). It looks like the docs are being built with gx, but I didn't see on first glance where a PR would be made for a favicon.

Screen Shot 2019-04-09 at 11 00 30

Maybe an option would be a monochrome / adapted version of the logo image?

<img width=250 src=https://camo.githubusercontent.com/4f6ca9438a3e45f9b409158503f3deebc86a793d/68747470733a2f2f7265626173736a732e6f72672f6c6f676f2e737667>

created time in 16 days

startedpicturepan2/devices.css

started time in 16 days

delete branch karlhorky/lazyload

delete branch : patch-1

delete time in 16 days

PR opened scott-little/lazyload

Add TAG design review link

Thanks for this repo and proposal! This has the potential of removing an incredible amount of shipped JS for newer browsers.

Just a quick PR to add the link to the TAG design review.

+1 -0

0 comment

1 changed file

pr created time in 18 days

push eventkarlhorky/lazyload

Karl Horky

commit sha 4c2308cfce7598365f7f47b7c743f34aa22398f0

Add TAG design review link

view details

push time in 18 days

startedscott-little/lazyload

started time in 18 days

startedlukejacksonn/csz

started time in 18 days

startedbevacqua/prop-tc39

started time in 19 days

delete branch karlhorky/keepassxreboot.github.io

delete branch : fix-windows-download-layout

delete time in 19 days

startedprettier/plugin-ruby

started time in 19 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

Maybe it was 0f6a30379757e779c96ff23256909454beba56bd that introduced this issue?

karlhorky

comment created time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

Hm, just tried with Jekyll on my machine locally and it's serving the images correctly:

Screen Shot 2019-04-05 at 16 17 28

karlhorky

comment created time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Add Chocolatey download source

Opened #55 for this. cc @phoerious @droidmonkey

karlhorky

comment created time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

But if this is just served by GitHub Pages, I suppose .htaccess doesn't actually get used...

karlhorky

comment created time in 20 days

create barnchkarlhorky/keepassxreboot.github.io

branch : fix-windows-download-layout

created branch time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

@droidmonkey Looks like this broke the favicon.

Screen Shot 2019-04-05 at 15 54 43

Weirdly enough if I try accessing the new files, they are redirected with a slash at the end.

Screen Shot 2019-04-05 at 15 54 35 Screen Shot 2019-04-05 at 15 54 39

It seems like there's a rewrite in the .htaccess that is putting slashes at the end of requests, could that be the problem?

https://github.com/keepassxreboot/keepassxreboot.github.io/blob/0f6a30379757e779c96ff23256909454beba56bd/.htaccess#L18

karlhorky

comment created time in 20 days

delete branch karlhorky/keepassxreboot.github.io

delete branch : improve-favicon

delete time in 20 days

startedgribnoysup/wunderbar

started time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

Yep, intended. The icon will appear in a rounded rectangle with a white background on iOS.

karlhorky

comment created time in 20 days

delete branch karlhorky/keepassxreboot.github.io

delete branch : add-chocolatey-download-source

delete time in 20 days

pull request commentkeepassxreboot/keepassxreboot.github.io

Add Chocolatey download source

Should I do another PR for this?

karlhorky

comment created time in 20 days

PR opened keepassxreboot/keepassxreboot.github.io

Improve resolution and compatibility of favicon

Improve the resolution of and compatibility of the favicon, which is currently quite small and blurry:

Screen Shot 2019-04-04 at 16 16 16

+43 -1

0 comment

6 changed files

pr created time in 21 days

create barnchkarlhorky/keepassxreboot.github.io

branch : improve-favicon

created branch time in 21 days

push eventkarlhorky/dotfiles

Karl Horky

commit sha 79b32c65ce54eec5867c5ce00540f3585bafb151

Add git-lfs https://help.github.com/en/articles/installing-git-large-file-storage

view details

Karl Horky

commit sha 608456d1168d692ca6d20fc6234b4c259fd4fa47

Add Activitus Bar

view details

Karl Horky

commit sha 2ad442ce4ccbe5dec794ef9765bb11baf8831e49

Add KeePassXC

view details

push time in 21 days

startedkeepassxreboot/keepassxreboot.github.io

started time in 21 days

PR opened keepassxreboot/keepassxreboot.github.io

Add Chocolatey download source

Hi there, thanks for this project!

Just a quick PR to add the Chocolatey package as a download source for Windows (similar to Homebrew on macOS).

+21 -3

0 comment

1 changed file

pr created time in 21 days

starteddbcli/mycli

started time in 21 days

pull request commentCompuIves/codesandbox-client

Added alert when saving frozen sandbox

Work continuing in #1716 for those who want to follow along :)

JonShort

comment created time in 21 days

issue commentVSCodeVim/Vim

[Feature Request] Treat lines with soft wrap the same way as non-broken lines when using j,k

It's possible to move among display lines with <kbd>j</kbd>, <kbd>k</kbd>, <kbd>↓</kbd> or <kbd>↑</kbd> by remapping key bindings as I documented in #3623.

elmewo

comment created time in 22 days

pull request commentVSCodeVim/Vim

Document display line movement best practices

Hm, not really, Prettier doesn't work like ESLint in disabling certain rules - it's low-configuration by philosophy.

So unless we want to disable all of the Markdown formatting everywhere (*.md in .prettierignore or removing .md here), there's not many options in between as far as granularity goes.

karlhorky

comment created time in 22 days

push eventkarlhorky/Vim

Karl Horky

commit sha 2d34a562b572180465e3dbe0714daf0e4abdf4c0

Disable Prettier formatting on code block

view details

push time in 22 days

issue commentbevacqua/prop-tc39

Titles <= Stage 3 Displayed as Champion Names

Hm, has #11 been deployed already? The issue is still present on https://prop-tc39.now.sh/

karlhorky

comment created time in 22 days

started996icu/996.ICU

started time in 22 days

startedformulahendry/955.WLB

started time in 22 days

startedchrisdickinson/git-rs

started time in 22 days

startedthieman/better-search

started time in 22 days

pull request commentVSCodeVim/Vim

Document display line movement best practices

Seems reasonable.

Great, cheers for the feedback.

Feel free to disable it for all MD files; it'd be harder to maintain special casing specific blocks.

I'm not sure I understand here... Won't this also be needed for visual line movement across word wrapped Markdown files?

karlhorky

comment created time in 23 days

startedmikeal/bent

started time in 25 days

startedamzn/sketch-constructor

started time in a month

startedamzn/sketch-constructor

started time in a month

startednektos/act

started time in a month

push eventkarlhorky/awesome-speakers

Karl Horky

commit sha 22262aedae21db70c5b6e3a197c57cb9069510d2

Fix Twitter username

view details

push time in a month

push eventkarlhorky/awesome-speakers

Karl Horky

commit sha 42c09879793ae9a0b5fc8059d0365dd72d77f826

Fix topics, ordering

view details

push time in a month

pull request commentkarlhorky/awesome-speakers

Added myself to the list of speakers

Thanks!

StefanNieuwenhuis

comment created time in a month

more