profile
viewpoint

nhn/toast-ui.vue-image-editor 150

Toast UI Image Editor for Vue

jungeun-cho/js-patterns-study 4

Javascript Patterns 책을 보며 정리한 내용입니다.

jungeun-cho/storybook 2

Interactive UI component dev & test: React, React Native, Vue, Angular, Ember

jungeun-cho/js-definitive-guide-6e 1

자바스크립트 완벽가이드 6 edition 내용 정리 및 샘플 코드

jungeun-cho/awesome-vue 0

🎉 A curated list of awesome things related to Vue.js

jungeun-cho/common-tags 0

🔖 Useful template literal tags for dealing with strings in ES2015+

PR opened nhn/tui.chart

feat: show series labels API

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [ ] It's submitted to right branch according to our branching model
  • [ ] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

chart.hideSeriesLabel();
chart.showSeriesLabel();
  • only for
  • area
  • bar
  • bullet
  • column
  • column-line
  • heatmap
  • line-area
  • line
  • pie
  • nestedPie
  • treemap

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+151 -17

0 comment

17 changed files

pr created time in 12 hours

push eventnhn/tui.chart

jung-han

commit sha 4264be2c1560c86b73171982deb6a7541d4f99c0

fix: change data Labels options

view details

jung-han

commit sha 125cb9fd9b6247dd5ffce59db39a3e062dc20bc4

feat: area chart show, hide series label

view details

jung-han

commit sha d59a93f705ac0c63107314bd5a3578ee8975e0d7

feat: line, line-area, bar, column chart showDataLabels, hideDataLabels API

view details

jung-han

commit sha 18c4bf25aa98950d7d908c09e9003a96f8b60a05

feat: column-line, heatmap, nestedPie, pie, treemap show, hide data labels API

view details

jung-han

commit sha 2762471e2125573a3a1d9231e3c4fe79a4146f36

chore: add type

view details

push time in 12 hours

create barnchnhn/tui.chart

branch : feat/api/showSeriesLabels

created branch time in 12 hours

issue commentnhn/tui.calendar

Posting data that ends up in calendar.

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

dadweiss

comment created time in 14 hours

issue commentnhn/tui.calendar

dayGrid click event problem When don't use popup.

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

sjpark0513

comment created time in 14 hours

PR opened nhn/tui.chart

feat: destroy API

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [ ] It's submitted to right branch according to our branching model
  • [ ] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

chart.destroy();

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+28 -6

0 comment

3 changed files

pr created time in 16 hours

create barnchnhn/tui.chart

branch : feat/api/destroy

created branch time in 16 hours

Pull request review commentnhn/tui.chart

feat: setData API

 export default abstract class Component {     return models;   } +  private getCurrentModelWithDifferentModel(+    models,+    currentModels,+    targetModels,+    modelNames,+    targetNames+  ) {+    if (currentModels.length > targetModels.length) {+      const newModels = models.filter(({ name }) => includes(targetNames, name));++      return newModels.length !== targetModels.length ? targetModels : newModels;+    }++    if (currentModels.length < targetModels.length) {

currentModelstargetModels의 length를 빼서 쓰면 어떨까요?

jung-han

comment created time in 16 hours

PR opened nhn/tui.chart

feat: add resize api

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [ ] It's submitted to right branch according to our branching model
  • [ ] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

chart.resize({
  width: number;
});

chart.resize({
  height: number;
});

chart.resize({
  width: number;
  height: number;
});

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+18 -4

0 comment

3 changed files

pr created time in 17 hours

create barnchnhn/tui.chart

branch : feat/api/resize

created branch time in 17 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 export default class Plot extends Component {     size?: number,     startPosistion?: number   ): LineModel[] {+    const {

115번 줄 오타네요 ㅎㅎ

startPosistion -> startPosition

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 export function exportMenuButton(   ctx: CanvasRenderingContext2D,   exportMenuButtonModel: ExportMenuButtonModel ) {-  const { opened, x, y } = exportMenuButtonModel;-+  const { opened, x, y, theme } = exportMenuButtonModel;+  const {+    borderColor,+    backgroundColor,+    borderWidth,+    borderRadius,+    color,+    xIconLineWidth,+  } = theme as Required<ExportMenuButtonTheme>;   pathRect(ctx, {     type: 'pathRect',     x,     y,-    fill: '#f4f4f4',-    stroke: '#f4f4f4',+    fill: borderColor,+    stroke: backgroundColor,

이것 두개 바뀐것 아닌가요?_?

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 function drawMoreIcon(ctx: CanvasRenderingContext2D, point: Point) {     rect(ctx, {       type: 'rect',       ...p,-      color: '#555555',+      color: color,

color로 작성하면 될 것 같습니다.

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 import { line, rect, pathRect } from '@src/brushes/basic'; import { Point } from '@t/options'; import { ExportMenuButtonModel } from '@t/components/exportMenu'; import { BUTTON_RECT_SIZE } from '@src/component/exportMenu';+import { ExportMenuButtonTheme } from '@t/theme'; -function drawXIcon(ctx: CanvasRenderingContext2D, point: Point) {-  const { x: startX, y: startY } = point;+type IconModel = {+  color: string;+  xIconLineWidth?: number;+} & Point;++function drawXIcon(ctx: CanvasRenderingContext2D, icon: IconModel) {+  const { x: startX, y: startY, color, xIconLineWidth } = icon;   const offset = BUTTON_RECT_SIZE / 3;-  const strokeStyle = '#555555';+  const strokeStyle = color;

const { x: startX, y: startY, color: strokeStyle, xIconLineWidth } = icon; 로 선언해서 쓰는게 좋을 것 같습니다.

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 export default class ExportMenu extends Component {         type: 'rect',         width: BUTTON_RECT_SIZE,         height: BUTTON_RECT_SIZE,-        x: this.rect.x,-        y: this.rect.y,+        x: 0,+        y: 0,       },     ];   }++  makePanelBorderStyle() {+    const { borderRadius, borderWidth, borderColor } = this.theme.panel;++    return `border: ${borderWidth}px solid ${borderColor}; border-radius: ${borderRadius}px;`;+  }++  makePanelStyle(type: 'header' | 'body') {+    const sectionTheme = this.theme.panel![type];+    const direction = type === 'header' ? 'top' : 'bottom';+    const { borderRadius, borderWidth } = this.theme.panel as Required<ExportMenuPanelTheme>;+    const borderRadiusPx = `${borderRadius - borderWidth}px`;++    return [+      `${getFontStyleString(sectionTheme as FontTheme)}`,+      `border-${direction}-left-radius: ${borderRadiusPx};`,+      `border-${direction}-right-radius: ${borderRadiusPx};`,+      `background-color: ${sectionTheme!.backgroundColor};`,+    ].join();

스타일이 제대로 지정되지 않고 있습니다. ].join('');가 되어야 할 것 같습니다.

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 button:focus {   font-family: Arial, sans-serif;   position: absolute;   background: #fff;-  border: 1px solid #bab9ba;   user-select: none;   box-sizing: border-box; }  .export-menu-title {   height: 34px;   width: 140px;-  background: #f4f4f4;+  /* background: #f4f4f4; */   margin: 0;-  font-size: 11px;+  /*  font-size: 11px; */

주석 제거 부탁드립니다

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 export const defaultTheme = {       color: '#ffffff',     },   },+  plot: {+    lineColor: 'rgba(0, 0, 0, 0.05)',+    backgroundColor: '#ffffff',+  },+  exportMenu: {+    button: {+      backgroundColor: '#f4f4f4',+      borderRadius: 5,+      borderWidth: 1,+      borderColor: '#f4f4f4',+      color: '#555555',+      xIconLineWidth: 2,+    },+    panel: {+      borderWidth: 1,+      borderRadius: 0,+      borderColor: '#bab9ba',+      header: {+        fontFamily: 'Arial',+        color: '#333333',+        fontSize: 11,+        fontWeight: 400,

여기도 묶을수 있는것은 묶어서 디폴트 스타일을 관리하면 좋을 것 같습니다.

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 type TooltipTheme = {   body?: FontTheme; }; +type PlotTheme = {+  lineColor?: string;+  vertical?: {+    lineColor?: string;+  };+  horizontal?: {+    lineColor?: string;+  };+  backgroundColor?: string;+};++type ExportMenuButtonTheme = {+  backgroundColor?: string;+  borderRadius?: number;+  borderWidth?: number;+  borderColor?: string;+  color?: string;+  xIconLineWidth?: number;

icon의 색을 변경하는 것이 color라면 아래처럼 iconColor 로 명칭을 명확하게 나타내는게 필요할 것 같습니다. 또한, 색상은 하나로 받는데 아이콘의 너비는 x 아이콘만 지정할 수 있어서.. 어색한것 같습니다. iconLineWidth 로 한번에 받아서 둘 다 지정되거나

xIcon: {
  color: string;
  width: number;
},
dotIcon: {
  color: string;
  width: number;
}

가 되어야 하지 않을까요?

jungeun-cho

comment created time in 18 hours

Pull request review commentnhn/tui.chart

Feat : plot and data exporter menu theme options

 type TooltipTheme = {   body?: FontTheme; }; +type PlotTheme = {+  lineColor?: string;

line width나 dash segments정도는 더 받을 수 있으면 좋을 것 같습니다. 시간 괜찮으시면 고려 부탁드릴게요

jungeun-cho

comment created time in 18 hours

PR opened nhn/tui.chart

feat: setData API

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [ ] It's submitted to right branch according to our branching model
  • [ ] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

chart.setData(data);

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+181 -59

0 comment

24 changed files

pr created time in 19 hours

push eventnhn/tui.chart

jung-han

commit sha 12c9cfa03a3612965aa4cbb5f10ce1d4c4237d31

feat: add treemap series setData api

view details

jung-han

commit sha 378ccb36ea76abac74deb7ca8867e719222a83ce

feat: add setData API for combo chart except for nested chart

view details

jung-han

commit sha 871db71ea1c2a01596ee2f64ae0f38003a7e5017

feat: add setData for nest pie chart

view details

push time in 19 hours

push eventnhn/tui.chart

jung-han

commit sha 34ec7e2b62ec9319f0572f0c7f69b08b53e54833

feat: radar chart setData

view details

push time in 20 hours

push eventnhn/tui.chart

jung-han

commit sha 2563944ccec7a23a81663e02426fdbc4adfc678b

feat: heatmap chart setData

view details

jung-han

commit sha cdb09ae7fb8ad40b4a89f8efdf29fd5df3fdfc97

feat: pie chart set data

view details

push time in 20 hours

issue openednhn/tui.calendar

Posibility to set maximum schedule duration

Hello, the issue is that I need to disable the ability to create a schedule that spans across multiple days.

Version

The demo in https://ui.toast.com/tui-calendar

Current Behavior

Right now the user is able to create a schedule that spans across multiple days: image

Expected Behavior

The user can only pick one day and set the starting hour and end hour. For example, the user would pick the day of the schedule to be 2020-12-02 and then be able to select start hours (i.e. 10:00) and end hours (i.e. 15:00)

created time in a day

Pull request review commentnhn/tui.chart

feat: apply datalabel theme options

 function getSeriesTheme(seriesName: string, isNestedPieChart = false) {           },           areaOpacity: 1,         },+        dataLabels: {+          fontFamily: 'Arial',+          fontSize: 16,+          fontWeight: 600,+          color: hasOuterAnchor ? '#333333' : '#ffffff',+          useSeriesColor: !!hasOuterAnchor,

hasOuterAnchor는 boolean이라 그냥 사용해도 되지 않을까요?

jungeun-cho

comment created time in a day

Pull request review commentnhn/tui.chart

feat: apply datalabel theme options

 function getSeriesTheme(seriesName: string, isNestedPieChart = false) {           },           areaOpacity: 1,         },+        dataLabels: {+          fontFamily: 'Arial',+          fontSize: 16,+          fontWeight: 600,+          color: hasOuterAnchor ? '#333333' : '#ffffff',+          useSeriesColor: !!hasOuterAnchor,+          textBubble: { ...makeDefaultTextBubbleTheme(false, 0) },+          callout: {+            lineWidth: 1,+            useSeriesColor: true,+            lineColor: '#e9e9e9',+          },+          pieSeriesName: {+            ...DEFAULT_DATA_LABEL,+            useSeriesColor: !!hasOuterAnchorPieSeriesName,

여기도 마찬가지입니다!

jungeun-cho

comment created time in a day

push eventnhn/tui.chart

jung-han

commit sha 7f258494bb01fdfbdee2a0272f74d30b25cb0ab8

feat: add setData to bullet chart

view details

push time in a day

push eventnhn/tui.chart

jung-han

commit sha 7b80cb8c4cf49da82ca691afabadcb33e577e557

feat: add area chart setData API

view details

jung-han

commit sha 04402f4df6e9f52ad755780297c986537713346a

feat: add bar, column chart setData API

view details

jung-han

commit sha f2ba390cf49ce97c8b76d089f1ced3f66bf4cf7d

feat: boxplot setData API

view details

jung-han

commit sha 1858c113123df3a8c0ad48cb2a609ef6c06a991a

feat: add scatter, bubble chart setData API

view details

push time in a day

push eventnhn/tui.chart

한정

commit sha a0f559cdb344485abfce810ca0dd341ac86905b0

fix: add condition for heatmap chart (#447)

view details

jung-han

commit sha 9786f83cd33550ff2b8c4c0dc7545fbb52648222

feat: add line chart setData

view details

push time in 2 days

delete branch nhn/tui.chart

delete branch : fix/heatmap-legend-store

delete time in 2 days

more