profile
viewpoint

hanjungv/hanjungv.github.io 2

hanjungv.github.io New blog

jung-han/Auction_puppeteer 1

puppeteer로 My auction 크롤링하기

jung-han/modern_JS_bookreview 1

모던 자바스크립트_니콜라스자카스 저

jung-han/storybook 1

📓 UI component dev & test: React, Vue, Angular, React Native, Ember, Web Components & more!

jung-han/actionsss 0

lets go market!

jung-han/basic_JS_book_review 0

(프론트엔드 개발자를 위한) 자바스크립트 프로그래밍_니콜라스 C. 자카스

jung-han/data-structure-and-algorithm-js 0

Data Structure & Algorithm implemented in JS

jung-han/Developer-Interview-Questions 0

Developer Interview Question List👨‍💻👩‍💻

jung-han/dooray-googl 0

슬래시 커맨드

jung-han/doorayBot 0

토이프로젝트

issue commentnhn/tui.chart

🙋‍♂️ Chart 4.0 Beta is coming! 🙋‍♀️

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

jung-han

comment created time in 21 hours

MemberEvent

issue commentnhn/tui.grid

Question about roadmap

@jechaviz The plan has not yet been reviewed regarding the all new functionality. However, we have the top priority we are thinking as below.

  • DOM structure improvement(related issue: #1155)
  • support the custom filter and external filter
  • enhance the tree grid to use other functionality(sort, filter)
  • improve the performance with large column data
  • export CSV format data
  • context menu
  • enhance the custom header for using
jechaviz

comment created time in 2 days

issue closednhn/tui.grid

Error in deleting(removeCheckedRows()) new row in empty grid.

Describe the bug Error in deleting(removeCheckedRows()) new row in empty grid. However, if you add a new row with an existing row, the removeCheckedRows() will proceed normally.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on 'prependRow()'
  3. Click on 'removeCheckedRows()'
  4. See error

Screenshots If applicable, add screenshots to help explain your problem. #Error in deleting(removeCheckedRows()) new row in empty grid. image

# if you add a new row with an existing row, the removeCheckedRows() will proceed normally. image

Desktop (please complete the following information): OS: Windows 10 Browser chrome Version Chrome 85.0.4183.102

closed time in 2 days

caleb-donghun

PR opened nhn/tui.grid

feat : Added some hooks to decide to perform or don't internal work.

<!-- EDIT TITLE PLEASE --> <!-- It should be one of them <ISSUE TYPE>: Short Description (<CLOSING TYPE> #<ISSUE NUMBERS>) ex) feat: add new feature (close #111) fix: wrong behavior (fix #111) chore: change build tool (ref #111) -->

<!-- SPECIFY A ISSUE TYPE AT HEAD feat: A new feature fix: A bug fix docs: Documentation only changes style: Changes that do not affect the meaning of the code (white-space, formatting etc) refactor: A code change that neither fixes a bug or adds a feature perf: A code change that improves performance test: Adding missing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation -->

<!-- ADD CLOSING TYPE AND ISSUE NUMBER AT TAIL (<CLOSING TYPE> #<ISSUE NUMBERS>) close: resolve not a bug(feature, docs, etc) completely fix: resolve a bug completely ref: not fully resolved or related to -->

Please check if the PR fulfills these requirements

  • [*] It's submitted to right branch according to our branching model
  • [*] It's right issue type on title
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [*] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [*] Docs have been added/updated (for bug fixes/features)
  • [ ] It does not introduce a breaking change or has description for the breaking change

Description

Why this need hook feature is because some users may don't need some work internal. I added one of the hooks handle when Keydown on editing cell. We could add more hook for flexible userablity.

Thank you for your attention and read.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

+109 -3

0 comment

10 changed files

pr created time in 3 days

push eventnaver/fe-news

Jae Sung Park

commit sha 13e095437c17146cef678bb43cba3de0523c9215

네이버 Front-end 소개 링크 추가

view details

push time in 3 days

push eventnaver/fe-news

Jae Sung Park

commit sha 7e51ec326aaa5bbbfa921585ea8d3b32ce558a15

네이버 FE 소개

view details

push time in 3 days

create barnchnaver/fe-news

branch : fe-org

created branch time in 3 days

issue closednhn/tui.tree

The line is placed on the wrong edge in Draggable UI

<!-- Thank you for your contribution.

When it comes to write an issue, please, use the template below. To use the template is mandatory for submit new issue and we won't reply the issue that without the template.

And you can write template's contents in Korean also. -->

<!-- TEMPLATE -->

Version

<!-- Write the version of component you are currently using. --> v4.0.0

Development Environment

<!-- Write the browser type, OS and so on. --> Chrome, Safari

Current Behavior

<!-- Write a description of the current operation. You can add example code, 'CodePen' or 'jsfiddle' links. -->

tree-draggable-ui

  • Chrome: Wrong line for the edge between nodes
  • Safari: Wrong line for the edge between nodes and no hover effect

Expected Behavior

<!-- Write a description of the future action. --> The line should be placed on the edge between nodes that the moving node will be inserted.

closed time in 3 days

dotaitch

issue commentnhn/tui.tree

The line is placed on the wrong edge in Draggable UI

This issue was resolved in v4.0.4

dotaitch

comment created time in 3 days

push eventnhn/tui.tree

lja1018

commit sha c04ac9aa1f2f4a4bb1968f47a67b99a3cce9c430

4.0.4

view details

push time in 3 days

release nhn/tui.tree

v4.0.4

released time in 3 days

created tagnhn/tui.tree

tagv4.0.4

Component that displays data hierarchically.

created time in 3 days

push eventnhn/tui.tree

임재언

commit sha 59a87819000633997677d2e3153d77298f2cf5cb

fix: incorrectly draw a guideline (#56) (#74) * fix: incorrectly draw a guideline * fix: no hover effect in drag (#73) * fix: no hover effect in safari (#56) * test: fix a test correctly * chore: apply code review * chore: update version to 4.0.4

view details

lja1018

commit sha 3b7f2265ab1e3a17e96a9356fae4095da2331662

Merge branch 'master' into production

view details

lja1018

commit sha e6d799f3cb2cbf7d8b5017226c1b2673bf835c5f

4.0.4

view details

push time in 3 days

pull request commentnhn/tui.tree

chore(deps): bump dot-prop from 4.2.0 to 4.2.1

Can one of the admins verify this patch?

dependabot[bot]

comment created time in 3 days

PR opened nhn/tui.tree

chore(deps): bump dot-prop from 4.2.0 to 4.2.1

Bumps dot-prop from 4.2.0 to 4.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/dot-prop/releases">dot-prop's releases</a>.</em></p> <blockquote> <h2>v4.2.1</h2> <ul> <li>Backport <a href="https://github.com/sindresorhus/dot-prop/commit/3039c8c07f6fdaa8b595ec869ae0895686a7a0f2">https://github.com/sindresorhus/dot-prop/commit/3039c8c07f6fdaa8b595ec869ae0895686a7a0f2</a> to the v4.x release line.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sindresorhus/dot-prop/commit/c914124f418f55edea27928e89c94d931babe587"><code>c914124</code></a> feat: patch 4.2.0 with fixes for CVE-2020-8116</li> <li>See full diff in <a href="https://github.com/sindresorhus/dot-prop/compare/v4.2.0...v4.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+99 -37

0 comment

1 changed file

pr created time in 3 days

create barnchnhn/tui.tree

branch : dependabot/npm_and_yarn/dot-prop-4.2.1

created branch time in 3 days

pull request commentnhn/tui.tree

chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4

ok to test

dependabot[bot]

comment created time in 3 days

delete branch nhn/tui.tree

delete branch : fix/incorrectly-draw-guideline

delete time in 3 days

push eventnhn/tui.tree

임재언

commit sha 59a87819000633997677d2e3153d77298f2cf5cb

fix: incorrectly draw a guideline (#56) (#74) * fix: incorrectly draw a guideline * fix: no hover effect in drag (#73) * fix: no hover effect in safari (#56) * test: fix a test correctly * chore: apply code review * chore: update version to 4.0.4

view details

push time in 3 days

PR merged nhn/tui.tree

fix: incorrectly draw a guideline (#56)
  • 안내선이 잘못 그려지던 버그를 수정했습니다 (#56)

    • 버그를 수정하고 사이드이펙트로 발생한 정확히 안내선에 드랍 시 트리의 맨 위나 맨 아래로 이동하는 버그도 수정했습니다.
  • AS-IS 화면 기록 2020-11-20 오후 12 19 56

  • TO-BE 화면 기록 2020-11-20 오후 12 20 31

+118 -104

0 comment

7 changed files

lja1018

pr closed time in 3 days

push eventnhn/tui.tree

lja1018

commit sha a6461d3dba17cec6c6af5ad67b3d51a5b4a438c5

chore: update version to 4.0.4

view details

push time in 3 days

push eventnhn/tui.tree

lja1018

commit sha 834b794d21dc78ec8781d973c2a25e9a01afdc0a

chore: apply code review

view details

push time in 4 days

delete branch nhn/tui.tree

delete branch : fix/no-hover-effect-in-drag

delete time in 4 days

push eventnhn/tui.tree

임재언

commit sha 8cd840aae3c5edc9c05a3b0f8155df0fd20befe6

fix: no hover effect in drag (#73) * fix: no hover effect in safari (#56) * test: fix a test correctly

view details

push time in 4 days

PR merged nhn/tui.tree

fix: no hover effect in drag (#56)
  • Safari 브라우저에서 hover style이 먹히지 않는 버그를 수정했습니다! (#56)

    • example04-draggable.html, tree.css은 단순히 prettier 적용이라 스킵하셔도 됩니다
    • 원인은 mousePos의 0, 1 프로퍼티를 읽어야하는데 x, y 프로퍼티를 참조하여 발생한 버그였습니다.
  • AS-IS 화면-기록-2020-11-20-오후-12 01 17

  • TO-BE 화면-기록-2020-11-20-오후-12 03 17

+96 -96

1 comment

5 changed files

lja1018

pr closed time in 4 days

Pull request review commentnhn/tui.tree

fix: no hover effect in drag (#56)

 describe('draggable feature', function() {       currentElement = rootElement.querySelector('li');       nodeId = tree.getNodeIdFromElement(currentElement);       mousePos = {-        x: 10,-        y: 20+        0: 10,+        1: 20

배열로 수정했습니다~!

lja1018

comment created time in 4 days

Pull request review commentnhn/tui.tree

fix: incorrectly draw a guideline (#56)

 var Draggable = defineClass(           removeClass(dragItemElement, dragItemClassName);         }       }+    },++    /**+     * Check if an element is a movingLineElement+     * @param {HTMLElement} element - target element+     * @returns {boolean}+     * @private+     */+    _isMovingLineElement: function(element) {

_initMovingLine()에서 따오긴 했는데 this.lineElement로 사용을 하네요...

isGuideLineElement로 바꾸겠습니다!

lja1018

comment created time in 4 days

Pull request review commentnhn/tui.tree

fix: incorrectly draw a guideline (#56)

 var Draggable = defineClass(        */       this.timer = null; +      /**+       * Last mouse hovered nodeId+       * @type {string | null}+       */+      this.lastHoverNodeId = null;

초기화 시키겠습니다~!

영역밖에서 드랍시켰을 때 이동하는 건 TODO로 등록해놓겠습니다!

lja1018

comment created time in 4 days

Pull request review commentnhn/tui.tree

fix: incorrectly draw a guideline (#56)

 var Draggable = defineClass(        */       this.timer = null; +      /**+       * Last mouse hovered nodeId+       * @type {string | null}+       */+      this.lastHoverNodeId = null;

드래그 동작이 끝난 후, 이 값도 초기화 해주는게 좋을 것 같아요. 중간에 설정해서 사용하는 값이라서요. 드래그 동작이 끝나면 의미가 없어집니다.


트리 영역 밖에서 마우스업(드랍) 시켜도 트리 아이템이 이동하네요. 원래 스펙인가요?_? 동작이 조금 어색해서 여쭈어요.

lja1018

comment created time in 4 days

more