profile
viewpoint
Jonathan Underwood junderw Tokyo, Japan Chief Bitcoin Officer, Bitbank Inc.

push eventBlueWallet/BlueWallet

Overtorment

commit sha 97032e7c0d6d16a6423f8456793c00fb34d78e7f

FIX: 'Few seconds ago' -> 'pending'

view details

GLaDOS

commit sha 2448a15cac5d8a0d73d925a2a18a737008b50c3c

Merge pull request #2531 from BlueWallet/fix-2201 FIX: 'Few seconds ago' -> 'pending'

view details

push time in 2 hours

pull request commentBlueWallet/BlueWallet

FIX: 'Few seconds ago' -> 'pending'

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Overtorment

comment created time in 2 hours

delete branch BlueWallet/BlueWallet

delete branch : fix-2201

delete time in 2 hours

PR merged BlueWallet/BlueWallet

FIX: 'Few seconds ago' -> 'pending'

closes https://github.com/BlueWallet/BlueWallet/issues/2201

image

+5 -1

1 comment

2 changed files

Overtorment

pr closed time in 2 hours

issue closedBlueWallet/BlueWallet

Few seconds ago

There's still some "few seconds ago" left overs. Replace all to "Pending".

image

closed time in 2 hours

ncoelho

pull request commentBlueWallet/BlueWallet

FIX: Conf number reflects correct number.

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/9h6h800vvnhywyjqv6eyp99jv8

download apk

marcosrdz

comment created time in 4 hours

push eventBlueWallet/BlueWallet

marcosrdz

commit sha 95ea380e7f3c83c6cb8f25a232e1557777f51572

ADD: Do not show notification settings if device does not support it.

view details

Overtorment

commit sha a3d7f75ea73eabc4d45016e5fab45bc1eb4f1534

FIX: legacy wallet can now derive UTXO from transactions in case if fetching listUnspent from network is impossible (closes #2528)

view details

marcosrdz

commit sha 35f8b7c1e8eb1efc8ef06b305bc6c130f7965c92

Merge branch 'master' into notifcapable

view details

marcosrdz

commit sha aa905fa201a0ec04c0eb51fc1668ec7ed273b406

Update setup.js

view details

GLaDOS

commit sha 1d46e2aae925fba5e209d06f7959486bcf418a44

Merge pull request #2530 from BlueWallet/fix-2528 FIX: legacy wallet can now derive UTXO from transactions in case if f…

view details

GLaDOS

commit sha 9de0bc571f0189cafaa12e1041c02a7e2d3337eb

Merge pull request #2520 from BlueWallet/notifcapable ADD: Do not show notification settings if device does not support it.

view details

marcosrdz

commit sha 5652915881f4c3dee3af728d46fc01b6343172ff

Merge branch 'master' into ccfix

view details

push time in 4 hours

pull request commentBlueWallet/BlueWallet

FIX: 'Few seconds ago' -> 'pending'

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/44bpjkqebgnhhqtewrzbyj3r6c

download apk

Overtorment

comment created time in 4 hours

PR opened BlueWallet/BlueWallet

Reviewers
FIX: 'Few seconds ago' -> 'pending'
+5 -1

0 comment

2 changed files

pr created time in 5 hours

create barnchBlueWallet/BlueWallet

branch : fix-2201

created branch time in 5 hours

push eventkeybase/client

heronhaye

commit sha 2fce572e3bc422a1623332205f4fbd1a5d68c1bf

new aur keys tuxbot

view details

push time in 5 hours

Pull request review commentBlueWallet/BlueWallet

TST: e2e: watch-only -> receive (& receive with amount)

 describe('BlueWallet UI Tests', () => {     process.env.TRAVIS && require('fs').writeFileSync(lockFile, '1');   }); +  it('can import zpub as watch-only, go to transactions list, go into Receive modal, and set custom amount. Dismiss modal and go to WalletsList.', async () => {+    const lockFile = '/tmp/travislock.' + hashIt(jasmine.currentTest.fullName);+    if (process.env.TRAVIS) {+      if (require('fs').existsSync(lockFile))+        return console.warn('skipping', JSON.stringify(jasmine.currentTest.fullName), 'as it previously passed on Travis');+    }+    await helperImportWallet(+      'zpub6rDWXE4wbwefeCrHWehXJheXnti5F9PbpamDUeB5eFbqaY89x3jq86JADBuXpnJnSvRVwqkaTnyMaZERUg4BpxD9V4tSZfKeYh1ozPdL1xK',+      'Imported Watch-only',+      '0.00030666 BTC',+    );++    await element(by.id('ReceiveButton')).tap();+    await element(by.text(`No, and don't ask me again`)).tap();+    await yo('BitcoinAddressQRCodeContainer');+    await yo('BlueCopyTextToClipboard');+    await element(by.id('SetCustomAmountButton')).tap();+    await element(by.id('BitcoinAmountInput')).typeText('1');+    await element(by.id('CustomAmountDescription')).typeText('test');+    await element(by.id('CustomAmountSaveButton')).tap();+    await sup('1 BTC');+    await sup('test');+    await yo('BitcoinAddressQRCodeContainer');+    await yo('BlueCopyTextToClipboard');+    await device.pressBack();+    await device.pressBack();

this is only needed if after it comes another test in the same testcase

marcosrdz

comment created time in 6 hours

Pull request review commentBlueWallet/BlueWallet

TST: e2e: watch-only -> receive (& receive with amount)

 describe('BlueWallet UI Tests', () => {     process.env.TRAVIS && require('fs').writeFileSync(lockFile, '1');   }); +  it('can import zpub as watch-only, go to transactions list, go into Receive modal, and set custom amount. Dismiss modal and go to WalletsList.', async () => {

can it be a part of other testcase? every testcase and wallet import takes a lot of time on CI

marcosrdz

comment created time in 6 hours

Pull request review commentBlueWallet/BlueWallet

TST: e2e: watch-only -> receive (& receive with amount)

 describe('BlueWallet UI Tests', () => {     process.env.TRAVIS && require('fs').writeFileSync(lockFile, '1');   }); +  it('can import zpub as watch-only, go to transactions list, go into Receive modal, and set custom amount. Dismiss modal and go to WalletsList.', async () => {+    const lockFile = '/tmp/travislock.' + hashIt(jasmine.currentTest.fullName);+    if (process.env.TRAVIS) {+      if (require('fs').existsSync(lockFile))+        return console.warn('skipping', JSON.stringify(jasmine.currentTest.fullName), 'as it previously passed on Travis');+    }+    await helperImportWallet(+      'zpub6rDWXE4wbwefeCrHWehXJheXnti5F9PbpamDUeB5eFbqaY89x3jq86JADBuXpnJnSvRVwqkaTnyMaZERUg4BpxD9V4tSZfKeYh1ozPdL1xK',+      'Imported Watch-only',+      '0.00030666 BTC',+    );++    await element(by.id('ReceiveButton')).tap();+    await element(by.text(`No, and don't ask me again`)).tap();+    await yo('BitcoinAddressQRCodeContainer');+    await yo('BlueCopyTextToClipboard');+    await element(by.id('SetCustomAmountButton')).tap();+    await element(by.id('BitcoinAmountInput')).typeText('1');+    await element(by.id('CustomAmountDescription')).typeText('test');+    await element(by.id('CustomAmountSaveButton')).tap();+    await sup('1 BTC');+    await sup('test');+    await yo('BitcoinAddressQRCodeContainer');+    await yo('BlueCopyTextToClipboard');

get the resulting bip21 string and verify it as well

marcosrdz

comment created time in 6 hours

push eventBlueWallet/BlueWallet

marcosrdz

commit sha 95ea380e7f3c83c6cb8f25a232e1557777f51572

ADD: Do not show notification settings if device does not support it.

view details

marcosrdz

commit sha 35f8b7c1e8eb1efc8ef06b305bc6c130f7965c92

Merge branch 'master' into notifcapable

view details

marcosrdz

commit sha aa905fa201a0ec04c0eb51fc1668ec7ed273b406

Update setup.js

view details

GLaDOS

commit sha 9de0bc571f0189cafaa12e1041c02a7e2d3337eb

Merge pull request #2520 from BlueWallet/notifcapable ADD: Do not show notification settings if device does not support it.

view details

push time in 6 hours

pull request commentBlueWallet/BlueWallet

ADD: Do not show notification settings if device does not support it.

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

marcosrdz

comment created time in 6 hours

delete branch BlueWallet/BlueWallet

delete branch : notifcapable

delete time in 6 hours

release keybase/client

v5.6.1

released time in 6 hours

release keybase/client

v5.6.0

released time in 6 hours

created tagkeybase/client

tagv5.6.1

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron

created time in 6 hours

created tagkeybase/client

tagv5.6.0

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron

created time in 6 hours

push eventkeybase/client

Song Gao

commit sha 0152580fbbca35ae6da2bbec9aa3bd3f54c8b222

Revert "kbfuse 4.0.5 (#24378)" This reverts commit cd76ccb97183c2be78b869fab9aed4b6f5b11086.

view details

Song Gao

commit sha f50a180af74bd3fd523b409fea747d5c04694f0a

get rid of fuse in changelog for now

view details

heronhaye

commit sha f3b21527b9cdf62fa5fe5011f436c0de0101d1ad

e10 merge

view details

push time in 6 hours

pull request commentBlueWallet/BlueWallet

FIX: Conf number reflects correct number.

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/mxtrqhn8aryhr3fnbbavwmt4q4

download apk

marcosrdz

comment created time in 6 hours

push eventBlueWallet/BlueWallet

Overtorment

commit sha a3d7f75ea73eabc4d45016e5fab45bc1eb4f1534

FIX: legacy wallet can now derive UTXO from transactions in case if fetching listUnspent from network is impossible (closes #2528)

view details

GLaDOS

commit sha 1d46e2aae925fba5e209d06f7959486bcf418a44

Merge pull request #2530 from BlueWallet/fix-2528 FIX: legacy wallet can now derive UTXO from transactions in case if f…

view details

push time in 6 hours

pull request commentBlueWallet/BlueWallet

FIX: legacy wallet can now derive UTXO from transactions in case if f…

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Overtorment

comment created time in 6 hours

delete branch BlueWallet/BlueWallet

delete branch : fix-2528

delete time in 6 hours

PR merged BlueWallet/BlueWallet

FIX: legacy wallet can now derive UTXO from transactions in case if f…

…etching listUnspent from network is impossible (closes #2528)

+76 -5

1 comment

2 changed files

Overtorment

pr closed time in 6 hours

pull request commentBlueWallet/BlueWallet

ADD: Do not show notification settings if device does not support it.

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/73etrwc2nvmnx6gy4gx948du64

download apk

marcosrdz

comment created time in 6 hours

more