profile
viewpoint

fxbox/openzwave-rust 4

Rust wrapper for the open-zwave library

bocoup/gaia 3

Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing

julienw/calendar 2

This is a simple calendar made in PHP, centered around events instead of people.

fxbox/open-zwave 1

a C++ and DotNet library to control Z-Wave Networks via a Z-Wave Controller.

gnarf/gaia 1

Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing

julienw/capture 1

Simple WebRTC-based capture tool

fxbox/calendar 0

:calendar: Project Cue -Currently looking for a slogan-

Pull request review commentfirefox-devtools/profiler

Issue #1818 - When searching in the stack chart, the matched nodes should be highlighted

 class StackChartCanvasImpl extends React.PureComponent<Props> {             intW + BORDER_OPACITY,             intH           );++          if (searchStringsRegExp && searchStringsRegExp.test(text)) {+            ctx.strokeStyle = 'green';

I was thinking that the color could be somewhat softer. We can try the mozilla blue BLUE_60 for example. You can import it like this:

import { BLUE_60 } from 'photon-colors'

and use it directly.

js636f

comment created time in a day

PullRequestReviewEvent

pull request commentfirefox-devtools/profiler

Using mouseTimePosition in Selection.js and added tests for that

I have a limited understanding of the topic here, but my impression is that the local state isn't necessary anymore, because we now use the value coming from the redux state.

CipherGirl

comment created time in a day

issue closedfirefox-devtools/profiler

Change all CSS loads that use `require` to `import`

This will be needed for style-loader v2.0.0.

Here is the full list, grouped by directory:

  • [x] src/components/app/: claimed by @codifyit
    • FooterLinks.js: require('./FooterLinks.css');
    • Home.js: require('./Home.css');
    • MenuButtons/Publish.js: require('./Publish.css');
    • ProfileViewer.js:require('./ProfileViewer.css');
  • [x] src/components/flame-graph/: claimed by @jufajardini
    • Canvas.js: require('./Canvas.css');
    • FlameGraph.js: require('./FlameGraph.css');
    • MaybeFlameGraph.js: require('./MaybeFlameGraph.css');
  • [x] src/components/js-tracer/: claimed by @mariehposa
    • Chart.js: require('./index.css');
    • index.js: require('./index.css');
  • [x] src/components/shared/: claimed by @somaru-chan
    • Backtrace.js: require('./Backtrace.css');
    • CallNodeContextMenu.js: require('./CallNodeContextMenu.css');
    • chart/Canvas.js: require('./Canvas.css');
    • chart/Viewport.js: require('./Viewport.css');
  • [x] src/components/stack-chart/: claimed by @burianovata
    • Canvas.js: require('./Canvas.css');
    • index.js: require('./index.css');
  • [x] Others: claimed by @AyumiOsawa
    • src/components/marker-chart/index.js: require('./index.css');
    • src/components/network-chart/index.js: require('./index.css');
    • src/components/tooltip/Tooltip.js: require('./Tooltip.css');

Each require line needs to be changed to an import line. For example:

require('./FooterLinks.css');

will be changed to

import './FooterLinks.css';

Please claim only one group at once. For example only src/components/app/. Thanks!

closed time in a day

julienw

issue commentfirefox-devtools/profiler

Change all CSS loads that use `require` to `import`

Thanks all, all occurrences have been fixed!

julienw

comment created time in a day

pull request commentfirefox-devtools/profiler

Bug Fix: Renaming already uploaded profile #2810

hey @GrooChu , are you still interested in finishing this patch? thanks :-)

GrooChu

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentfirefox-devtools/profiler

New idle search field

Thanks for the patch!

The behavior doesn't seem completely correct, it seems like that I have to type letters twice, or that the first letter in a "session of typing" is always swallowed. I don't have time to look at it closer yet, but maybe you can try to debug yourself already? Ideally you can debug by adding logs to the new function, looking at the values of the state and props, so that maybe you'll understand what the problem is. For now I don't have a solution without looking more, sorry!

Thanks

qmya

comment created time in a day

PR closed firefox-devtools/profiler

Reviewers
Idle search field

Hi @gregchang and @julienw I created a pull request could you review :)

(Part of #1006)

+11 -8

4 comments

2 changed files

qmya

pr closed time in a day

pull request commentfirefox-devtools/profiler

Idle search field

Thanks for the notice, so I'm closing this PR in favor of #3006!

qmya

comment created time in a day

issue commentfirefox-devtools/profiler

GCMajor and other "nonexhaustive range" markers should be more clearly distinguished visually

If the problem is about the actual markers, maybe the markers should be replaced by something else? Maybe have 2 different GCMajor markers with different names that would show this difference ? Or a payload that would tell this?

On this profile it's not clear to me what we should change. Also I don't understand why the jank is that big but the markers don't span the full GC/CC operation.

hotsphink

comment created time in a day

Pull request review commentfirefox-devtools/profiler

Fix stacking context for overlays and permalink

 .dragAndDropArea {   display: inherit;   width: 100%;-  isolation: isolate;

I think this change makes a regression in the following STR:

  1. Load a profile (for example https://deploy-preview-2997--perf-html.netlify.app/public/d4e0b257c771dd7d4a7a6bd6c8c8cbb2d5dad40c/flame-graph/?globalTrackOrder=10-11-12-13-0-1-2-3-4-5-6-7-8-9&hiddenGlobalTracks=1-2-3-4-5-6-7-9&localTrackOrderByPid=1439-1-0~1449-0~1443-0~1447-0~1445-0~1446-0-1~1441-0~1442-0-1~1448-0~1444-0-1~&thread=9&v=5)
  2. try drag and drop a profile FILE to the browser window

=> The interface that's showing up should be on top of everything. I believe that this isolation property was making this correct, because with your patch we now have some elements that are going on top (for exemple the search input, but also other things).

Riju19

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Issue #1818 - When searching in the stack chart, the matched nodes should be highlighted

 class StackChartCanvasImpl extends React.PureComponent<Props> {             intW + BORDER_OPACITY,             intH           );++          if (searchStringsRegExp && searchStringsRegExp.test(text)) {

Because the searchStringsRegExp is shared, it needs to be "reset" when using it. I think this is the source of the bug I found. You can do this: https://github.com/firefox-devtools/profiler/blob/510a546b4f4903d5987c575ace0fb5a50adadaf2/src/components/shared/TreeView.js#L77-L78

js636f

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentfirefox-devtools/profiler

Issue #1818 - When searching in the stack chart, the matched nodes should be highlighted

Sorry it took so long to answer you.

TBH I like it this way :-) even for tiny nodes.

I think there may be a bug, see this example: I'm looking for "MessageLoop", and it looks like that only half of the matches have their border.

But otherwise I think we can move forward this way. What do you think @canova?

js636f

comment created time in 2 days

push eventfirefox-devtools/profiler

Julien Wajsberg

commit sha 510a546b4f4903d5987c575ace0fb5a50adadaf2

Add a shellcheck job to CircleCI (PR #2996)

view details

push time in 2 days

PR merged firefox-devtools/profiler

Add a shellcheck job to CircleCI

I double-checked that adding a mistake to the shell script will fail the build.

I considered adding it as a dependency to our project (there's a npm package to download it, although I'm a bit reluctant to use it) but decided this isn't worth it.

+18 -0

1 comment

1 changed file

julienw

pr closed time in 2 days

push eventjulienw/perf.html

Julien Wajsberg

commit sha 4199fc6c4c19829646d8ffbbc13fd11405510844

[Do not review, PR #3003] Extract the button from MetaInfo back to the index of menu buttons

view details

Julien Wajsberg

commit sha b6a3fe63f7771bb11b7d32b42a27b26b91a76d27

Move the CSS code specific to the Permalink component to its own file

view details

Julien Wajsberg

commit sha 0978a9eb83203ab7092411b0fe54038c4837c64b

Simplify the menu buttons bar further

view details

Julien Wajsberg

commit sha 440b7933094d02def42ae378c9728f8f3c8b3a1b

Remove unused CSS for metainfo panel

view details

Julien Wajsberg

commit sha 01a8d4dcc0d318410cbd8d9c5dd0433bd5d6c00e

Removed unused CSS for Publish panel

view details

push time in 2 days

Pull request review commentfirefox-devtools/profiler

Preload the stored uploaded profile data into the state when we load a profile

 import type { TransformStacksPerThread } from './transforms'; import type JSZip from 'jszip'; import type { IndexIntoZipFileTable } from '../profile-logic/zip-files'; import type { PathSet } from '../utils/path.js';+import type { ProfileData as ImportedProfileData } from 'firefox-profiler/app-logic/published-profiles-store';  export type Reducer<T> = (T | void, Action) => T; +// Reexport this type for easier access+export type ProfileData = ImportedProfileData;

I'll add more comment and, yeah, it's a good idea to rename the type But I think the type definition should stay where it is now. Indeed, the data in IndexedDB will persist across reloads, and therefore it's important that its typing is controlled strictly. On the other hand the data in the reducer is valid only during one run. So the concern I have is that if we define this type in the state there's a high probability we'll change it without doing any IDB check and upgrade.

julienw

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Preload the stored uploaded profile data into the state when we load a profile

 const eventDelayTracks: Reducer<boolean> = (state = false, action) => {   } }; +/**+ * Holds the state for whether the user has the local data to delete the+ * currently displayed profile.+ */+const cachedStoredProfileData: Reducer<ProfileData | null> = (

Currently it is managed by LoadStoredProfileDataManager only, therefore it's tied to a hash. It has no meaning outside of uploaded profiles anyway, so it has no meaning with zip files especially. When publishing a new profile especially the hash will change and therefore the component will load the new data into this state.

But I realize that I don't clear this state when the hash moves to a value that's not stored in the indexed db, I'll make sure this is fixed and tested. Also I'll add a few comments here to explain this a bit.

julienw

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Preload the stored uploaded profile data into the state when we load a profile

+/* This Source Code Form is subject to the terms of the Mozilla Public+ * License, v. 2.0. If a copy of the MPL was not distributed with this+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */++// @flow++// This component is responsible for caching the stored profile data in the+// redux state.  This will control whether we can delete this profile.++// Implementation note:+// This is done as a separate component than where the deletion button is+// rendered, so that the button doesn't flick, because the access to the stored+// profile data is asynchronous.+// Also this isn't in a thunk action to make it independent from any other+// change. It only depends on the current hash being changed.++import { PureComponent } from 'react';++import { getHash } from 'firefox-profiler/selectors/url-state';+import { cacheStoredProfileData } from 'firefox-profiler/actions/app';++import { retrieveProfileData } from 'firefox-profiler/app-logic/published-profiles-store';+import explicitConnect from 'firefox-profiler/utils/connect';++import type { ConnectedProps } from 'firefox-profiler/utils/connect';++type StateProps = {|+  +hash: string,+|};++type DispatchProps = {|+  +cacheStoredProfileData: typeof cacheStoredProfileData,+|};++type Props = ConnectedProps<{||}, StateProps, DispatchProps>;++class LoadStoredProfileDataManagerImpl extends PureComponent<Props> {

This is an entire component, but otherwise a simple one.

I think this is pretty standard React programming to trigger an action following a state change in an untied way.

julienw

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Extract the delete and profile info panels to their own components

 import { } from 'firefox-profiler/selectors/profile'; import { getDataSource } from 'firefox-profiler/selectors/url-state'; import { getIsNewlyPublished } from 'firefox-profiler/selectors/app';-import { MenuButtonsMetaInfo } from 'firefox-profiler/components/app/MenuButtons/MetaInfo';++/* Note: the order of import is important, from most general to most specific,+ * so that the CSS rules are in the correct order. */+import { ButtonWithPanel } from 'firefox-profiler/components/shared/ButtonWithPanel';

This change is made necessary because I removed the same import from MetaInfo.js => the CSS file for ButtonWithPanel was loaded after the one for MetaInfo, and was overriding some properties.

julienw

comment created time in 2 days

PullRequestReviewEvent

push eventjulienw/perf.html

Julien Wajsberg

commit sha 3b50406c58e83a9ca1ce0927f51f3116a249f902

Extract the button from MetaInfo back to the index of menu buttons

view details

push time in 2 days

push eventjulienw/perf.html

burianovata

commit sha 4bf219bb298060ff57e22b59a148b584805970d6

Expose profile.meta.logicalCPUs and profile.meta.physicalCPUs in the UI (PR #2927)

view details

Julien Wajsberg

commit sha 35836a62d08a2dac988d81cb2ba5e8526151ab2b

[PR #3001] Preload the stored uploaded profile data into the state when we load a profile

view details

Julien Wajsberg

commit sha 2aea12b917a55c50238220304e6b906f051b5b10

[PR #3003] Extract panels for ProfileDeleteButton and MetaInfo

view details

Julien Wajsberg

commit sha e5edd3300ed3b4cec2551621ce1b3616e6cde486

[PR #3004] Various CSS changes + menu buttons simplification

view details

Julien Wajsberg

commit sha fa315b24b357baa44746411ff934239a829a47b2

Change labels of the publish button

view details

Julien Wajsberg

commit sha dad06c841c36b3a640aa1dd901dd3c21af093e29

Reorganize the menu buttons bar

view details

Julien Wajsberg

commit sha fda2f434282123a196907723e9c741507c9535a1

Menu buttons refresh

view details

Julien Wajsberg

commit sha 9d443950508f0eea763c7b940f814c426bafce92

Use button for menu buttons

view details

Julien Wajsberg

commit sha 40c38d23f35bcf6fa717dc9761cee59b41a47f73

Add share icon to the permalink button

view details

Julien Wajsberg

commit sha 72140e447c2987f368c334f0b25cc0a42cb17180

Rework the Metainfo button

view details

Julien Wajsberg

commit sha f672facb4f1741628254f5005f1571a7ded1800b

uploading redesign

view details

push time in 2 days

push eventjulienw/perf.html

burianovata

commit sha 4bf219bb298060ff57e22b59a148b584805970d6

Expose profile.meta.logicalCPUs and profile.meta.physicalCPUs in the UI (PR #2927)

view details

Julien Wajsberg

commit sha a5c6bc3824cfe219b8bdccdd28018e3abb6d41b9

[Do not review, PR #3003] Extract the button from MetaInfo back to the index of menu buttons

view details

Julien Wajsberg

commit sha 9bf6dbbc334434111a38f0835dcd6ef1e1364a75

Move the CSS code specific to the Permalink component to its own file

view details

Julien Wajsberg

commit sha eb731cc67236417a830d37fc5a7bbc2d16ce0e34

Simplify the menu buttons bar further

view details

Julien Wajsberg

commit sha a94121e9f2e2cab1d21723f4ee9dbb0d128e6c32

Remove unused CSS for metainfo panel

view details

Julien Wajsberg

commit sha b2f467defddcd9afc41f5a2d56cd3c7faf4f513c

Removed unused CSS for Publish panel

view details

push time in 2 days

push eventfirefox-devtools/profiler

Segun Ogundipe

commit sha 1b1fef21c417f15454d5e5f52c96acfd2af98424

Move the code of the Tooltip component from componentWillReceiveProps to componentDidUpdate (PR #2961)

view details

push time in 2 days

PR merged firefox-devtools/profiler

Move tooltip's lifecycle to react 16.3

What is the purpose of the pull request

Update src/components/tooltip/Tooltip.js to use new lifecycle update from react 16.3 This fixes part of issue #1006

How to verify this PR

  • Clone the branch
  • cd into the directory
  • yarn i
  • yarn start
  • Capture/Load a profile with firefox profiler
  • Confirm the tooltip lays out correctly after switching from a wider tooltip to a smaller smaller one
+13 -22

3 comments

1 changed file

Segun-Ogundipe

pr closed time in 2 days

push eventjulienw/perf.html

burianovata

commit sha 4bf219bb298060ff57e22b59a148b584805970d6

Expose profile.meta.logicalCPUs and profile.meta.physicalCPUs in the UI (PR #2927)

view details

Julien Wajsberg

commit sha 8b2c5e7e0e6bf3c26bf1f7b016b0c822432886e0

Extract a panel from the ProfileDeleteButton

view details

Julien Wajsberg

commit sha 0034cd7e82c8a962030a49bebda4d0d29cdbc704

Extract the button from MetaInfo back to the index of menu buttons

view details

push time in 2 days

push eventjulienw/perf.html

burianovata

commit sha 4bf219bb298060ff57e22b59a148b584805970d6

Expose profile.meta.logicalCPUs and profile.meta.physicalCPUs in the UI (PR #2927)

view details

Julien Wajsberg

commit sha 87c26af4de49dd10d3f9096734d03d6c0c4a525f

Preload the stored uploaded profile data into the state when we load a profile Fixes #2445

view details

push time in 2 days

push eventSegun-Ogundipe/profiler

burianovata

commit sha 4bf219bb298060ff57e22b59a148b584805970d6

Expose profile.meta.logicalCPUs and profile.meta.physicalCPUs in the UI (PR #2927)

view details

Julien Wajsberg

commit sha 9f18b5118818ccbb9b07eb582682dac778bb0cd9

Merge branch 'main' into chore/tooltip-new-lifecycle

view details

push time in 2 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

2808 - Window Title - Uploaded Profiles

 import type { TransformType } from 'firefox-profiler/types';  * more readable.  */ export function assertExhaustiveCheck(-  notValid: empty,+  notValid: empty | string,

The problem in our case is that the variable dataSource we have as a prop is a string, not an enum. But I believe this is wrong, it should be the DataSource type. Indeed the selector getDataSource returns this type: https://github.com/firefox-devtools/profiler/blob/4bf219bb298060ff57e22b59a148b584805970d6/src/selectors/url-state.js#L48-L49 And this type is indeed an enum: https://github.com/firefox-devtools/profiler/blob/4bf219bb298060ff57e22b59a148b584805970d6/src/types/actions.js#L34-L42

So I think this would be our fix: change the type of the dataSource prop in WindowTitle, that's the bug :)

rlkeyer

comment created time in 2 days

Pull request review commentfirefox-devtools/profiler

2808 - Window Title - Uploaded Profiles

 import type { TransformType } from 'firefox-profiler/types';  * more readable.  */ export function assertExhaustiveCheck(-  notValid: empty,+  notValid: empty | string,

That's especially the empty type that makes the tool useful.

In short, we use it when we want to make sure we cased all possible values of an enum. In the default line, if all possible values have been checked, Flow types the variable as empty, which means this variable can't have any possible value. So if we can pass this variable to assertExhaustiveCheck this means that we checked everything.

Does that make sense?

rlkeyer

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventjulienw/perf.html

Julien Wajsberg

commit sha 0a457a8fe88cad0c3b303126e2edc74cecdf0d90

Use button for menu buttons

view details

Julien Wajsberg

commit sha b5c0960c9f3b91def270c441ee4c342821cb5d2a

Add share icon to the permalink button

view details

Julien Wajsberg

commit sha 0421886fdb08926ff3776586b6b561350a0b771a

Rework the Metainfo button

view details

Julien Wajsberg

commit sha e0d28617c64dd70e77445dd5be78c82c28af86bd

uploading redesign

view details

push time in 2 days

push eventjulienw/perf.html

Greg Tatum

commit sha 8e65efb76bc43dcfc2b573c711d799fa30b60546

Fix some minor styling issues with the context menu

view details

Greg Tatum

commit sha 33689d42f3dbc71b9463c228708d36cf1a7716d9

Add the redux action – handleCallNodeTransformShortcut

view details

Greg Tatum

commit sha 5b74518a91eb7367e38fd094e98f58d6a03316a5

Add a TransformMenuItem component that can use transform shortcuts

view details

Greg Tatum

commit sha 33af11730af8bcf2fff9fc9eb9875b1a366ec225

Teach the call tree how to use transform shortcuts

view details

Greg Tatum

commit sha 8c60b98b830c97fa729ac79009ea209344af93bb

Teach the flame graph how to use transform shortcuts

view details

Greg Tatum

commit sha dbd9db66104109b24cd3d2f986156018aa8e5c0a

Add a test for call tree transform keyboard shortcuts

view details

Greg Tatum

commit sha 755b7ad589bfedb666746dad792c71c7488ef988

Address review comments for call tree transforms

view details

Greg Tatum

commit sha 0eb7ab2e9a58f8941d6e82c61d125e95f7bff6a1

Add call tree transform shortcuts (PR #2842)

view details

depfu[bot]

commit sha 7ccf7ea99c7d001588adc7094be520cd5a43cd9a

Update all development Yarn dependencies (2020-10-26) (PR #2999) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

view details

Julien Wajsberg

commit sha 05071512a10149c86d14172ac7af4fc9c8ce91c3

[PR #3001] Preload the stored uploaded profile data into the state when we load a profile

view details

Julien Wajsberg

commit sha a7fc87acffd3e87674f82f9440700122aacc2560

[PR #3003] Extract panels for ProfileDeleteButton and MetaInfo

view details

Julien Wajsberg

commit sha d7ca1eb605327a2208a2aa6650b67a242c510dd1

[PR #3004] Various CSS changes + menu buttons simplification

view details

Julien Wajsberg

commit sha cad0786cc3be706ee060655f5fda9ebe9a2bc79f

Change labels of the publish button

view details

Julien Wajsberg

commit sha 7d456e5862905b16a48c2addbfc7fb4271f27c90

Reorganize the menu buttons bar

view details

Julien Wajsberg

commit sha 804b194e488e45aad3c449fe1cf3a98a1a77e97b

Menu buttons refresh

view details

Julien Wajsberg

commit sha 169ad7a19916a2b8dc9ca8773341fc2cccf20232

Fix IDB error in the tests for the ZipFileTree

view details

Julien Wajsberg

commit sha d1b88ba5c75431596832ec94c2cf3f100061b8e4

Use button for menu buttons

view details

Julien Wajsberg

commit sha ad08a31ba421c92ccc5e3d82413f5062f78afbf8

Add share icon to the permalink button

view details

Julien Wajsberg

commit sha 4937d22f4958dd158aac10f77e3ad3943f27e85b

Rework the Metainfo button

view details

Julien Wajsberg

commit sha 8c9910f3eb19f44e693f8dfb7f785c90315d1beb

uploading redesign

view details

push time in 2 days

Pull request review commentfirefox-devtools/profiler

Implement new animation for commiting selection range (Issue #1140)

 }  .filterNavigatorBarItem:not(.filterNavigatorBarLeafItem)::after {+  animation: fadein 700ms;   background-image: url(../../../res/img/svg/scope-bar-separator.svg);   background-position: -18px -12px;   background-repeat: no-repeat;   background-size: 24px 24px; } +@keyframes fadein {+  from {+    opacity: 0.1;+  }++  to {+    opacity: 1;+  }+}+

This looks right!

mariehposa

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentfirefox-devtools/profiler

Measure arbitrary time in the marker chart #2618

and now, let's move forward with some tests! thanks

Hey, @julienw We can write tests for:

* Clicking on the first two submenus in which we expect to give menu items.

* Then clicking on those menu items which will give us the selection range.

Is this looks right??

Yes this looks right. Doing the action of "clicking" using getFromText will make sure the menu items are here, and after that you can check that the selection changed.

km-js

comment created time in 2 days

Pull request review commentfirefox-devtools/profiler

Move tooltip's lifecycle to react 16.3

 export class Tooltip extends React.PureComponent<Props, State> {     this._isMounted = false;   } -  UNSAFE_componentWillReceiveProps(nextProps: Props) {-    if (nextProps.children !== this.props.children) {-      // If the children are different, allow them to do an initial lay out on the DOM.-      this.setState({ isNewContentLaidOut: false });-      this._forceUpdateAfterRAF();+  componentDidUpdate(prevProps: Props) {+    if (prevProps.mouseX !== this.props.mouseX) {

I'm not 100% sure that this won't bring bugs. What happens if the content changes but the user doesn't move the mouse? This may happen in some components in some cases, so I would say that we can have a glitch. I'd remove this check so that we have the same behavior as wit hthe previous patch.

Segun-Ogundipe

comment created time in 2 days

Pull request review commentfirefox-devtools/profiler

Move tooltip's lifecycle to react 16.3

 import * as React from 'react'; import ReactDOM from 'react-dom'; import type { CssPixels } from 'firefox-profiler/types'; -import { ensureExists } from 'firefox-profiler/utils/flow';+import { ensureExists } from '../../utils/flow';

Be careful, in some conflict fixing you changed this coming from a previous patch.

Segun-Ogundipe

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

   color: #fff; } -.menuButtonsUploadingButtonLabel {

I realized these 2 classes weren't used anymore.

julienw

comment created time in 3 days

PullRequestReviewEvent

push eventjulienw/perf.html

Julien Wajsberg

commit sha d12739e9e3e15fd971882947aeed6ab5b0a4f3af

Remove unused CSS for metainfo panel

view details

Julien Wajsberg

commit sha e266b6e4a2889df63a645084c15626cdec9e0d20

Removed unused CSS for Publish panel

view details

push time in 3 days

Pull request review commentfirefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

  * License, v. 2.0. If a copy of the MPL was not distributed with this  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -.menuButtonsMetaInfoButton {-  /* Let this box shrink down to the size of the three dots and a bit of text. */-  min-width: 75px;--  /* Shrink down twice as fast as the range selection labels. */-  flex-shrink: 2;-}--.menuButtonsMetaInfoButtonButton {-  overflow: hidden;-  text-overflow: ellipsis;-  white-space: nowrap;-}-

Nothing special about this button anymore.

julienw

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

 class MenuButtonsImpl extends React.PureComponent<Props> {   render() {     return (       <>-        {/* Place the info button outside of the menu buttons to allow it to shrink. */}

This is not true anymore, because the string is now fixed (or fairly fixed). So I removed this container menuButtons.

julienw

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

 }  .menuButtonsButton:hover {-  background-image: linear-gradient(rgba(0, 0, 0, 0.1), rgba(0, 0, 0, 0.1));+  background-color: rgba(0, 0, 0, 0.1); }  .buttonWithPanel.open > .menuButtonsButton, .menuButtonsButton:hover:active {-  background-image: linear-gradient(rgba(0, 0, 0, 0.2), rgba(0, 0, 0, 0.2));+  background-color: rgba(0, 0, 0, 0.2);+}++.menuButtonsLink {+  position: relative; /* This allows positioning the ::before element. */+  cursor: default;+  text-decoration: none;+}

I reused the class menuButtonsButton for the link too, and thats why it's much simpler now.

julienw

comment created time in 3 days

PullRequestReviewEvent

push eventjulienw/perf.html

Julien Wajsberg

commit sha 3f2229afb7a524d3bb50edc391d31b0b288ee4b3

Simplify the menu buttons bar further

view details

Julien Wajsberg

commit sha a02a1761f3dd53caa2a8c1b75e5ce2fc9218a304

Remove unused CSS for publish panel

view details

Julien Wajsberg

commit sha 4ce596c04e597280b3910db8de668d186da6d62e

Do some cleanup in Publish.css

view details

push time in 3 days

Pull request review commentfirefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

 }  .menuButtonsButton:hover {-  background-image: linear-gradient(rgba(0, 0, 0, 0.1), rgba(0, 0, 0, 0.1));

I believe we had a background-image because previously we had some real gradients in some cases. But that's legacy now.

julienw

comment created time in 3 days

PullRequestReviewEvent

PR opened firefox-devtools/profiler

Some more various CSS cleanups and simplifications around Menubutton

This PR has a few fairly independant commits that are gathered in this PR because they're on the same topic: CSS

+738 -838

0 comment

11 changed files

pr created time in 3 days

create barnchjulienw/perf.html

branch : menubutton-css-cleanup-simplification

created branch time in 3 days

Pull request review commentfirefox-devtools/profiler

Extract the delete and profile info panels to their own components

 // Jest Snapshot v1, https://goo.gl/fbAQLP

This snapshot change is easier to review without the whitespace changes.

julienw

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Extract the delete and profile info panels to their own components

 export class MenuButtonsMetaInfo extends React.PureComponent<Props> {     const platformInformation = formatPlatform(meta);      return (-      <ButtonWithPanel

This part is easier to review without the whitespace changes.

julienw

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentfirefox-devtools/profiler

Extract the delete and profile info panels to their own components

 describe('app/MenuButtons', function() {   }); }); -describe('<MenuButtonsMetaInfo>', function() {+describe('<MetaInfoPanel>', function() {   function setup(profile: Profile, symbolicationStatus = 'DONE') {-    jest.useFakeTimers();

Everything is so much simpler!

julienw

comment created time in 3 days

PullRequestReviewEvent

push eventjulienw/perf.html

Julien Wajsberg

commit sha d809d2f02718ec450698bd5e0c797be087148aca

Extract the button from MetaInfo back to the index of menu buttons

view details

push time in 3 days

push eventjulienw/perf.html

Julien Wajsberg

commit sha c4d4eecab61b60b7504d509cee46647b2f184bc8

Extract a panel from the ProfileDeleteButton

view details

Julien Wajsberg

commit sha d0d7834bbd41c3920513ac0c7f608a450499139a

Extract the button from MetaInfo back to the index of menu buttons

view details

Julien Wajsberg

commit sha 4a1f813bfaedadde46d59109f88775d8b3ef9b47

Remove unused CSS for publish panel

view details

Julien Wajsberg

commit sha d4115333cfecd223a3840ae78844bc8cad7e0cda

Move the CSS code specific to the Permalink component to its own file

view details

Julien Wajsberg

commit sha d9b623e20152e893c4cf1f7f49a393f81cbab070

Do some cleanup in Publish.css

view details

Julien Wajsberg

commit sha 786bdb584047e1099e1c4271f552a61f1394a1d1

Simplify the menu buttons bar further

view details

Julien Wajsberg

commit sha 15bf4205c59e124761ce5b3d7a13d2588adb9e93

Change labels of the publish button

view details

Julien Wajsberg

commit sha 736e26a6a048dbcf30e5b78af95fa800ad7c09d1

Reorganize the menu buttons bar

view details

Julien Wajsberg

commit sha ffa196424074882f88dcfb7a96715b95120165ae

Menu buttons refresh

view details

Julien Wajsberg

commit sha a4f813f68cd11e3a7bcf535eda7f2e8969550abf

Fix IDB error in the tests for the ZipFileTree

view details

Julien Wajsberg

commit sha 595bea5149908cb9a9283cb372838d6244213d3e

Use button for menu buttons

view details

Julien Wajsberg

commit sha 4d5f71a6bc40838fea7e4d861b4f56e507157a54

Add share icon to the permalink button

view details

Julien Wajsberg

commit sha d11cc9640116dc05b5d567296881f9b0402a8d88

Rework the Metainfo button

view details

Julien Wajsberg

commit sha d443b83a9593ecac9789f777e66fcf657431bf28

uploading redesign

view details

push time in 3 days

Pull request review commentfirefox-devtools/profiler

Extract the delete and profile info panels to their own components

 describe('ListOfPublishedProfiles', () => {        // Clicking elsewhere should make the successful message disappear.       fireFullClick((window: any));-      expect(queryByText(/successfully/i)).toBe(null);+      waitForElementToBeRemoved(queryByText(/successfully/i));

In the previous code, I believe the text was changed (because the "state" changed) to an invalid text, even though the panel was still visible for a short period of time (because the list refresh is asynchronous). With the new code, the text doesn't change until the element is removed from the DOM.

julienw

comment created time in 3 days

PullRequestReviewEvent

PR opened firefox-devtools/profiler

Extract the delete and profile info panels to their own components

In the current code, we extracted both the Button and the panels to one component. But for the "delete" operation I'll have to switch panels for the same button. Therefore in this PR I uncouple the panels from their buttons so that they can be independently reused.

+791 -821

0 comment

7 changed files

pr created time in 3 days

create barnchjulienw/perf.html

branch : extract-panel-delete

created branch time in 3 days

issue closedfirefox-devtools/profiler

Add a Delete button in the list of uploaded recordings

This issue is about adding the delete feature in the list of uploaded recordings. See spec at https://www.figma.com/file/1JlU42P3U5bZhcaZo8n5rq/Profiler-landing-page-2.0-%26-in-profile-delete-flow?node-id=300%3A2

  • [x] depends on #2445 (implement the backend work to call the delete endpoint)
  • [x] review the layout for the list, probably using grid layout (one per line)
  • [x] add the delete button and wire it on the work from #2445
  • [x] add a confirmation dialog
  • [x] display errors if present
  • [x] add tests

closed time in 3 days

julienw

issue commentfirefox-devtools/profiler

Add a Delete button in the list of uploaded recordings

This was done in various patches.

julienw

comment created time in 3 days

push eventjulienw/perf.html

Julien Wajsberg

commit sha d3a9798f406ab9cac831b480197066d228ed59b3

Preload the stored uploaded profile data into the state when we load a profile Fixes #2445

view details

push time in 3 days

PR opened firefox-devtools/profiler

Add a state to control when we can delete the current profile and a c…

…omponent to change it

Fixes #2445

+223 -5

0 comment

9 changed files

pr created time in 3 days

create barnchjulienw/perf.html

branch : preload-stored-published-state

created branch time in 3 days

issue commentfirefox-devtools/profiler

Move non-generic CSS out of res/style.css

Sorry @aintabb, this project isn't part of hacktoberfest this year because this conflicts with Outreachy. We wrote this clearly in https://github.com/firefox-devtools/profiler/blob/main/CONTRIBUTING.md. Hope this makes sense!

julienw

comment created time in 3 days

push eventfirefox-devtools/profiler

depfu[bot]

commit sha 7ccf7ea99c7d001588adc7094be520cd5a43cd9a

Update all development Yarn dependencies (2020-10-26) (PR #2999) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

view details

push time in 3 days

PR merged firefox-devtools/profiler

Update all development Yarn dependencies (2020-10-26) dependencies

This is your weekly update of all development Yarn dependencies. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @babel/cli (7.11.6 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/core (7.11.6 → 7.12.3, minor) · Repo · Changelog · Release · Diff

✳️ @babel/plugin-proposal-class-properties (7.10.4 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/plugin-proposal-object-rest-spread (7.11.0 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/polyfill (7.11.5 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-env (7.11.5 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-flow (7.10.4 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-react (7.10.4 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @testing-library/react (11.0.4 → 11.1.0, minor) · Repo · Changelog · Release · Diff


Depfu Status

Depfu will only send you the next scheduled PR once you merge or close this one.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu refresh</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> </dl></blockquote> </details>

+573 -399

2 comments

2 changed files

depfu[bot]

pr closed time in 3 days

PullRequestReviewEvent

push eventfirefox-devtools/profiler-server

depfu[bot]

commit sha 96ad1590deed521f7227fc4fdd500f769aa2a0c3

Update all development Yarn dependencies (2020-10-26) (PR #159) * Update all development Yarn dependencies (2020-10-26) * Update the flow type for koa * Improve typing of mocks to avoid a flow error Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Julien Wajsberg <felash@gmail.com>

view details

push time in 3 days

PR merged firefox-devtools/profiler-server

Update all development Yarn dependencies (2020-10-26) dependencies

This is your weekly update of all development Yarn dependencies. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ flow-bin (0.134.0 → 0.136.0, major) · Repo

✳️ @babel/cli (7.11.6 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/core (7.11.6 → 7.12.3, minor) · Repo · Changelog · Release · Diff

✳️ @babel/node (7.10.5 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/plugin-proposal-class-properties (7.10.4 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/plugin-proposal-object-rest-spread (7.11.0 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-env (7.11.5 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-flow (7.10.4 → 7.12.1, minor) · Repo · Changelog · Release · Diff

✳️ nodemon (2.0.4 → 2.0.6, patch) · Repo · Release · Diff


Depfu Status

Depfu will only send you the next scheduled PR once you merge or close this one.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu refresh</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> </dl></blockquote> </details>

+512 -412

0 comment

4 changed files

depfu[bot]

pr closed time in 3 days

PullRequestReviewEvent

pull request commentfirefox-devtools/profiler

Update all development Yarn dependencies (2020-10-26)

@depfu recreate

depfu[bot]

comment created time in 3 days

push eventfirefox-devtools/profiler-server

Julien Wajsberg

commit sha bc3aafbd5289bc90fb84cbcaa3212ee543b6dbb1

Update the flow type for koa

view details

Julien Wajsberg

commit sha 446bd859a9e40d574a0b84849fe687cbea5aa602

Improve typing of mocks to avoid a flow error

view details

push time in 3 days

pull request commentfirefox-devtools/profiler

Issue #1119 Move non-generic css out of res/style.css (Part-3 / Move for TreeView Component)

Yes, please clean up the pull request. Thanks !

aintabb

comment created time in 4 days

push eventjulienw/perf.html

Julien Wajsberg

commit sha 7e63ca48327a4a16b19df122712ac338b6659176

Menu buttons refresh

view details

Julien Wajsberg

commit sha 4935c4d80a7ef4ed9f16ea0c0e8d3a498752a743

Fix IDB error in the tests for the ZipFileTree

view details

Julien Wajsberg

commit sha 3ab22ca5419dec6e58244e876c608c639f586e68

Use button for menu buttons

view details

Julien Wajsberg

commit sha 78c4dc9985a885c61270dad430c806e8611c6358

Add share icon to the permalink button

view details

Julien Wajsberg

commit sha 91f7b9217259ee283bd915f7031ca6d6adf91d91

Rework the Metainfo button

view details

Julien Wajsberg

commit sha 6500e74bef72d62edf331ea83f3b2fd99e4a60bc

uploading redesign

view details

push time in 6 days

push eventjulienw/perf.html

Salma Taha

commit sha c1dc5d0ba62528e5d68851d094073add13b12114

Edited loading in profiles section

view details

Salma Taha

commit sha 6c818979d2d3d4db251e66b95380e88f8139636b

Re-phrased as requested by reviewer

view details

CipherGirl

commit sha 5b453988883a1473beaac7fa77f1850e8bb210ad

Added mouseTimePosition actions, reducer, selector and tests

view details

CipherGirl

commit sha c82b33fa8c7230540e9f4e6bae7864eca026c907

Removed todo comments

view details

CipherGirl

commit sha ed8d6ea298db0bc05f27cc69640f8e5fd6c56138

Small changes

view details

CipherGirl

commit sha 28640b3d7382521da391be2fecfcaecbaae53764

Fixed test

view details

CipherGirl

commit sha 038adcda266cc695c49a6f27242562981ecfbec7

Test fix

view details

CipherGirl

commit sha 9a26e038601d20d6b106b669405c8ebc403f0bb8

Minor Edits

view details

Yunus Emre Ozvarlik

commit sha 75ac93cc247f6fc538dbd328027e5d23e0ce8ed2

Move non-generic css out of res/style.css (Move for Root Component) (PR #2954) Co-authored-by: Nazım Can Altınova <466239+canova@users.noreply.github.com>

view details

Riju19

commit sha 74ad39cb21efc1cab1b790d5d5cf65969f270620

Copy index.js from the node-bisection library to a new utility file here - bisect.js

view details

Riju19

commit sha 9f980e230b2341ce0ab19998f5ecc3d138a8b148

Make cosmetic changes to bisect.js Export two functions using ES6 modules: bisectionLeft and bisectionRight. Add comments about the original source of this code and the description of the two functions. Add flow typing.

view details

Riju19

commit sha c87182cef65ee109b6ee6dfabb846041baded587

Replace all usages of the bisection library with bisectionLeft and bisectionRight

view details

Riju19

commit sha c3b81830483c921f84853287d6242559f23179cf

Remove bisection dependency

view details

Riju19

commit sha cfc2ba502aefe16f3d5e2b8efb412096441ce4e5

Fix the bug in bisectionLeft

view details

Riju19

commit sha 28e0d79d3f94782d357613f99f3f5fb16b6421c3

Add tests for bisectionLeft and bisectionRight

view details

Riju19

commit sha 6943c86fb7cfcf8c35ff485a37b52d0f76d6df01

Handle out of range scenarios in bisectionLeft and bisectionRight For the bisection functions, low and high values should lie within the range of the array. This commit adds a check to the bisection functions to throw TypeError in case the low or high values passed are negative or greater than the array length. This commit also adds relevant testcases to bisect.test.js to check these conditions.

view details

Hasna Hena Mow

commit sha 6f2213f552760dbee2371ad54900bcdbe305b7b7

Merge branch 'main' into issue#222

view details

Julien Wajsberg

commit sha 01ecd2001813050c7f6c5f74f3f9ef28b3eb6648

Import bisection under utils and remove the usage the node-bisection library (Merge PR #2971)

view details

Julien Wajsberg

commit sha a43b21a12fab82d34294ff9e692b1d10995a664e

Add a mention to take care about the HTTP scheme on localhost

view details

Julien Wajsberg

commit sha f51790e41e39b2286b03030fa7b9c14ed830f51e

Correct a problem in how to enable the button

view details

push time in 6 days

push eventjulienw/config-files

Julien Wajsberg

commit sha 9a45df8ebba84799eaa8be630a81b9f65bd878d0

show rebase status in prompt

view details

push time in 6 days

push eventjulienw/perf.html

Julien Wajsberg

commit sha 20cbe88069e9bc1d1ad50b6151ac7332fbfaf174

Add a shellcheck job to CircleCI

view details

push time in 6 days

more