profile
viewpoint

julianharty/app-store-reviews-app 3

Android App to analyse reviews and scripts to load historical reviews data into a SQLite database.

bugbash/selenium3 2

Selenium 3 Bug Bash

ISNIT0/AndroidCrashDummy 1

Exceptions, logs, more playing about (@julianharty)

ISNIT0/AndroidLogAssert 1

Log Assertion Library for use with Android Espresso tests

ISNIT0/kafka-testing-tools 1

Kafka Testing Tools

ISNIT0/logcat-filter 1

A logcat -> JSON tool with package filtering (along with log test coverage tool)

julianharty/andlytics 1

Google Play - Android Market statistics app

julianharty/android-accessibility 1

A working home for experiments with Android Accessibility apps

issue commentkiwix/kiwix-android

Kiwix fails to restore state of previously opened article on new launches

@kelson42 Is the issue title fine or needs to be changed? I believe we can fix the "Start with Reader" problem in a new ticket, the trickier part was to restore the previous position of the article in new launches, with the merge of the linked PR we'll be good to go with it. And for "Start with Reader" I've planned of creating a new ticket and then writing a fix for it, I think the fix for it should be easy enough to write. I'm waiting for a response from your end, on the green check I'll create one and will work on it.

daniels234

comment created time in 3 hours

pull request commentkiwix/kiwix-android

fix: Saved position of articles on new launches

Ah, in the last commit I removed my experimental work that I forgot to commit on another branch as I started on 2567 weeks back and earlier was trying things out locally so today while writing the real changes for 2567 my stupid experiments inadvertently crept in, apologies for that.

s-ayush2903

comment created time in 4 hours

pull request commentkiwix/kiwix-android

fix: Saved position of articles on new launches

Codecov Report

Merging #2581 (d8b5f24) into develop (b0c0b08) will decrease coverage by 0.16%. The diff coverage is 15.78%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2581      +/-   ##
=============================================
- Coverage      39.05%   38.88%   -0.17%     
  Complexity        31       31              
=============================================
  Files            287      286       -1     
  Lines           7325     7357      +32     
  Branches         894      901       +7     
=============================================
  Hits            2861     2861              
- Misses          4168     4193      +25     
- Partials         296      303       +7     
Impacted Files Coverage Δ Complexity Δ
...bile/nav/destination/reader/KiwixReaderFragment.kt 33.08% <6.25%> (-3.28%) 0.00 <0.00> (ø)
...iwix/kiwixmobile/core/main/CoreReaderFragment.java 24.21% <66.66%> (-0.49%) 0.00 <0.00> (ø)
...ixmobile/core/main/CompatFindActionModeCallback.kt 20.00% <0.00%> (-0.29%) 0.00% <0.00%> (ø%)
...ix/kiwixmobile/custom/main/CustomReaderFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...java/org/kiwix/kiwixmobile/core/main/FileReader.kt
...bile/custom/download/effects/FinishAndStartMain.kt
...ixmobile/custom/download/CustomDownloadActivity.kt
...ixmobile/custom/download/CustomDownloadFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../custom/download/effects/NavigateToCustomReader.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0c0b08...c82f557. Read the comment docs.

s-ayush2903

comment created time in 4 hours

issue commentkiwix/kiwix-android

Kiwix fails to restore state of previously opened article on new launches

@kelson42 Is the issue title fine or needs to be changed?

daniels234

comment created time in 5 hours

PR opened kiwix/kiwix-android

fix: Saved position of articles on new launches

<!--

  • Add the issue number here.

  • If you haven't solved the issue completely use "Linked issue #{issue_number}.

  • After solving the issue completely change it to "Fixes #{issue_number}. --> Fixes #2567

<!-- Add here what changes were made in this issue and if possible provide links. -->

Added required methods and corrected the method for restoring state of previously opened article

<!-- If possible, please add relevant screenshots / GIFs -->

Visuals Watch right here: https://youtu.be/zY0oXgWxgfw

+41 -8

0 comment

3 changed files

pr created time in 5 hours

issue openedopenzim/zim-requests

New ZIM request: www.ozbargain.com.au

  • Website URL: https://www.ozbargain.com.au/
  • Desired ZIM Title: OzBaragin
  • Desired ZIM Description: OzBargain is Australia's bargain hunting community.
  • Desired ZIM Icon – https://files.delvu.com/images/ozbargain/logo/Square%20Flat.png
  • Language (ISO 639-3): eng
  • Is this a MediaWiki?: no
  • API information: https://www.ozbargain.com.au/wiki/help:api

created time in 5 hours

startedniieani/typescript-vs-flowtype

started time in 8 hours

pull request commentopenzim/libzim

Move title indexes in a zim Entry.

@mgautierfr Why creating the “W” namespace and not using the “M”. To me, so far, the difference is pretty unclear/subtil. @rgaudin @veloman-yunkan Any opinion on this specific point?

If all content from the "M" namespace is public (i.e. makes sense for the users), then we better keep information about internals of the ZIM archive separately. With that point of view, it may make sense to keep the favicon path in the "M" namespace, and the path of the title indices in "W".

mgautierfr

comment created time in 10 hours

push eventSeleniumHQ/seleniumhq.github.io

Selenium CI Bot

commit sha fa09c9f4fc9588be51db4df681946411ec4e1063

Modifying waits page for other languages [deploy site] 9bf7212f04c0c15c6db2a197722ec45be9b0a315

view details

push time in 18 hours

push eventSeleniumHQ/seleniumhq.github.io

Diego Molina

commit sha 9bf7212f04c0c15c6db2a197722ec45be9b0a315

Modifying waits page for other languages [deploy site]

view details

push time in 18 hours

push eventSeleniumHQ/seleniumhq.github.io

Anton

commit sha 3bd7a00aeaba5d96536f7438d3dceaa6133abcc9

Update waits.en.md (#608) Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

view details

push time in 18 hours

PR merged SeleniumHQ/seleniumhq.github.io

Waits page: Removing comment about naming of WebDriver reference

<!--- Provide a general summary of your changes in the Title above -->

Description

"called d in the example" comment (about WebDriver reference) on Waits page is not correct

Motivation and Context

In the Java example, WebDriver reference name is driver. And the reference name in examples in the other programming languages is different.

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Change to the site (I am attaching a screenshot showing the before and after)
  • [ ] Code example added (and I also added the example to all translated languages)
  • [ ] Improved translation
  • [ ] Added new translation (and I also added a notice to each document missing translation)

Checklist

<!--- Go over all the following points, and put an x in all the boxes that apply. -->

  • [x] I have read the contributing document.
  • [ ] I have used hugo to render the site/docs locally and I am sure it works. <!--- Provide a general summary of your changes in the Title above -->
+1 -2

1 comment

1 changed file

fiveych

pr closed time in 18 hours

issue openedopenzim/zim-requests

New ZIM request:

Make a ZIM of http://api.plos.org/text-and-data-mining/

created time in 19 hours

pull request commentopenzim/libzim

Move title indexes in a zim Entry.

@mgautierfr Why creating the “W” namespace and not using the “M”. To me, so far, the difference is pretty unclear/subtil. @rgaudin @veloman-yunkan Any opinion on this specific point?

mgautierfr

comment created time in 21 hours

push eventsegmentio/analytics-android

Prayansh Srivastava

commit sha c07c43a134e011fdabac9ec8a74a1ec023a114b0

add setup method for plugins

view details

Prayansh Srivastava

commit sha 9c870f28c0ef6059eba4b7053890507eb80df9b3

add MixpanelPlugin.kt

view details

push time in a day

pull request commentopenzim/libzim

Move title indexes in a zim Entry.

Please review carefully, I'm pretty sure there is a lot of corner case.

This PR requires special review - one not only has to analyze individual changes, but also think about things that had to be addressed but weren't. I think we will have similar PRs in the future too. I propose to facilitate making and reviewing such changes by maintaining a complete and up-to-date list of features, requirements, assumptions, components, etc, related to libzim. Then one can iterate over all bullets in that list and ask oneself if that particular aspect is affected. This is a general approach applicable to any complex project. I think that libzim has grown large enough that it cannot safely evolve at the anticipated rate without adopting such a process.

Besides, the coverage of libzim by unit-tests must be significantly increased. Relying on review is good but proving that the code works is better.

mgautierfr

comment created time in a day

issue commentopenzim/zim-requests

zim file for meta.wikimedia.org

Concur.

godane

comment created time in a day

issue closedopenzim/zim-requests

zim file for meta.wikimedia.org

I would like to see a zim file of meta.wikimedia.org please?

closed time in a day

godane

issue commentopenzim/zim-requests

zim file for meta.wikimedia.org

I propose to close this ticket as wontfix

godane

comment created time in a day

issue commentopenzim/zim-requests

Make a ZIM file of Unencylopedia

Original website has been closed. It seems we have now two forks:

  • https://en.uncyclopedia.co/
  • https://uncyclopedia.ca/wiki/Main_Page
kelson42

comment created time in a day

issue commentopenzim/zim-requests

language links

This is definitly the wrong place.

kelson42

comment created time in a day

issue closedopenzim/zim-requests

Create a Zim file of https://proofwiki.org?

From @ScyllaHide on June 18, 2017 15:58

Proof Wiki seems to have a typical "wikipedia structure" so far i can see. I have used it a few times to learn proof methods and to look up things, but it would be nice to have an offline version as a zim file. Hope that is possible.

"ProofWiki is an online compendium of mathematical proofs! Our goal is the collection, collaboration and classification of mathematical proofs."

Copied from original issue: openzim/mwoffliner#92

closed time in a day

kelson42

issue commentopenzim/zim-requests

Create a Zim file of https://proofwiki.org?

https://farm.openzim.org/recipes/proofwiki

kelson42

comment created time in a day

issue closedopenzim/zim-requests

Create zim of https://zdoom.org/w/

From @Popolechien on May 30, 2017 6:11

Following popular request...

Copied from original issue: openzim/mwoffliner#86

closed time in a day

kelson42

issue commentopenzim/zim-requests

Create zim of https://zdoom.org/w/

Recipe https://farm.openzim.org/recipes/zdoom

kelson42

comment created time in a day

MemberEvent

issue openedkiwix/kiwix-android

Suggestion search fails on cutting-edge Wikispecies custom app

A few hours ago I have released a new Wikispecies custom app: https://play.google.com/store/apps/details?id=org.kiwix.kiwixcustomwikispecies

Yesterday I failed because of #2578 but this has been fixed and I change the CI of the Kiwix Android Custom Apps to deal with the develop branch instead of the usual official release branch master. See: https://github.com/kiwix/kiwix-android-custom/commit/b73f0b5c07b8775d84238b8c217e7b267a83362e

First all seemed first OK and I have put the Wikispecies app in production. Unfortunately I missed an important regression. The problem is that what ever the suggestion I choose in the proposed suggestions, it always load the welcome page. Which make the search/suggestion system useless.

Would be great to identify quickly the problem so I can fix the production release of the Wikispecies custom app (and later updated other app with 3.4.3+ code base).

created time in 2 days

push eventkiwix/kiwix-android

Emmanuel Engelhart

commit sha 807b50025486bd5b4d6b2589bcafd711fbd12efe

Bump-up NDK version to 22.0.7026061

view details

Kelson

commit sha 36c29b2d20e295c785eade3831263357e0b8857c

Merge pull request #2579 from kiwix/ndk-22.0.7026061 Bump-up NDK version to 22.0.7026061

view details

translatewiki.net

commit sha 4830c64e547039cf6298c53eb1ea6e2d9dbe57c8

Localisation updates from https://translatewiki.net.

view details

push time in 2 days

pull request commentkiwix/kiwix-android

#1447 Can't open zim from external download

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

macgills

comment created time in 2 days

issue commentopenzim/libzim

Test failure encountered when building using kiwix-build

@mgautierfr Might that be linked to new libzim 7.0.0 release?

automactic

comment created time in 2 days

more