profile
viewpoint

rubyforgood/diaper 182

Diaperbase is an inventory system for diaper banks, to aid them in tracking their inventory and providing statistics about their inventory flows.

rubyforgood/abalone 20

An data tracking and analytics app for abalone conservation efforts live at abalone-dev.herokuapp.com

jtu0/GasLog 0

ReactNative app to log tank fillups

jtu0/openfoodnetwork 0

Connect suppliers, distributors and consumers to trade local produce

jtu0/paperclip 0

Easy file attachment management for ActiveRecord

jtu0/rubyforgood.org 0

Ruby for Good Website

issue commentrubyforgood/diaper

Add `rubocop -a --safe` as a pre-commit hook

I think it's not just within scope, it's the question of the issue: how might we increase maintainability without sacrificing accessibility? Decreasing rubocop's opinionatedness by picking up a fork with a subset of rules seems like it'd be helpful to that.

I might be misunderstanding what Aaron's thinking of doing here though. And Aaron - I think anything you choose will be fine, and you can always revert or change if something else would be more supportive :)

On Sat, Jun 20, 2020 at 7:07 PM Keith Bennett notifications@github.com wrote:

@jtu0 https://github.com/jtu0 Those are forks of rubocop for the purpose of changing the gem name, and not for loosening the rules, right? If we are to deviate from use of the original rubocop, I think that's a different discussion that's outside the scope of this issue, no?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/diaper/issues/1710#issuecomment-647068292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA625NY3QVAITQKFJC7YYJDRXVTOHANCNFSM4ODPE5DQ .

armahillo

comment created time in a month

issue commentrubyforgood/diaper

Add `rubocop -a --safe` as a pre-commit hook

Maybe use one of the forks that does some filtering down on the standard rubocop rules, so that you're getting some one of the benefits?

My business partner Zee just made one recently:

https://github.com/zspencer/rbhint https://www.google.com/url?q=https://github.com/zspencer/rbhint&sa=D&source=hangouts&ust=1592788245532000&usg=AFQjCNGyAh-dEq1HmM4RiQZlBVMqJF7Yqw

There's also https://github.com/ruby-lint https://www.google.com/url?q=https://github.com/ruby-lint&sa=D&source=hangouts&ust=1592788344908000&usg=AFQjCNHQOivyMfOBbMXhYs-klz2KfI1w1g

On Sat, Jun 20, 2020, 11:54 Edwin Mak notifications@github.com wrote:

I'll be happy either way :). For me, it only happens a few times that I push up code with violations that CI catches. Not a major bummer but I see the appeal of having it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/diaper/issues/1710#issuecomment-647033063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA625NYMYJVERJ5SIDWFSZTRXUAV5ANCNFSM4ODPE5DQ .

armahillo

comment created time in a month

fork jtu0/openfoodnetwork

Connect suppliers, distributors and consumers to trade local produce

http://openfoodnetwork.org/

fork in 3 months

issue commentrubyforgood/abalone

Expand "operation" model to allow stateful actions on tanks/families

  • [ ] Operation doesn't automatically .perform - need to make that happen before closing this issue
mdworken

comment created time in 3 months

issue commentrubyforgood/abalone

Rename 'master' branch to 'primary' or 'production'

@mdworken

jtu0

comment created time in 3 months

issue closedrubyforgood/abalone

Can we automatically delete merged branches?

When I was working on this project, the large number of merged-but-still-existing branches made it a bit noisy when trying to switch between the main pranch and the WIP branch I was building on.

There's a handy-dandy setting which will automatically delete branches that are merged that may help with this.

closed time in 3 months

zspencer

issue commentrubyforgood/abalone

Can we automatically delete merged branches?

Done, thank you!

zspencer

comment created time in 3 months

push eventrubyforgood/abalone

jtu0

commit sha 01af135fcddf50d44b14a9824501747c8aa19325

Use checkboxes in the PR template

view details

push time in 3 months

MemberEvent

issue openedrubyforgood/abalone

Rename operations.operation_type

Rails sees _type and thinks that implies polymorphism Do we intend that here? if not we should rename the column to something without connotations to Rails.

created time in 3 months

issue openedrubyforgood/abalone

Upgrade to Rails 6

created time in 3 months

issue commentrubyforgood/abalone

Expand "operation" model to allow stateful actions on tanks/families

@mdworken Can a family ever be split across multiple tanks? Or will a family always be in the same tank together?

Similarly, can a tank have multiple families?

mdworken

comment created time in 3 months

more