profile
viewpoint
James Sumners jsumners @knockaway Douglasville, GA, USA http://james.sumners.info/ Just a guy that does far too many things. TZ: US/Eastern

jsumners/alfred-emoji 461

Alfred workflow for searching and copying emoji

davidmarkclements/fast-redact 176

very fast object redaction

fastify/fastify-cookie 122

A Fastify plugin to add cookies support

fastify/fastify-caching 103

A Fastify plugin to facilitate working with cache headers

fastify/fastify-formbody 85

A Fastify plugin to parse x-www-form-urlencoded bodies

fastify/fastify-bearer-auth 84

A Fastify plugin to require bearer Authorization headers

fastify/fastify-url-data 34

A plugin to provide access to the raw URL components

jsumners/abstract-logging 26

A noop logger interface for Node.js modules

pull request commentfastify/fastify

Merge Type-Provider.md to TypeScript.md

One thing to note: After the merge, we are missing documentation regarding how to use json-schema-to-typescript.

Why?

mitul45

comment created time in 9 hours

PullRequestReviewEvent

pull request commentfastify/fastify-cookie

refactor: prepare plugin for fastify 4.x

Should we remove Node.js 10 and 12 from the CI matrix following this discussion fastify/fastify#3482 ?

Yes, but probably another PR.

darkgl0w

comment created time in a day

Pull request review commentfastify/fastify-cookie

refactor: prepare plugin for fastify 4.x

 test('expires should not be overridden in clearCookie', (t) => { })  test('parses incoming cookies', (t) => {-  t.plan(6 + 3 * 3)+  t.plan(6 + 3 * 2)

Please do. It's far easier to read than an equation.

darkgl0w

comment created time in a day

PullRequestReviewEvent

Pull request review commentfastify/fastify-cookie

refactor: prepare plugin for fastify 4.x

 test('expires should not be overridden in clearCookie', (t) => { })  test('parses incoming cookies', (t) => {-  t.plan(6 + 3 * 3)+  t.plan(6 + 3 * 2)

Why is this not simply 12?

darkgl0w

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

issue commentfastify/help

Decorator with reference object / order of same type hooks

Use fastify.io/docs/latest/Decorators/#getters-and-setters

I thought it would raise the same reference type warning aswell.

No, it will not. The getter allows you to return a new object on every request, and thus avoid the problem the warning is telling you about.

adriano-tirloni

comment created time in a day

issue commentfastify/help

Decorator with reference object / order of same type hooks

Use https://www.fastify.io/docs/latest/Decorators/#getters-and-setters

adriano-tirloni

comment created time in a day

pull request commentfastify/fastify

Tests for http2 host constraint server

As I pointed out in the description, this PR depends on another PR in the find-my-way repo @jsumners

Ah, I missed that. Sorry.

luisorbaiceta

comment created time in a day

pull request commentfastify/fastify

Tests for http2 host constraint server

CI is failing.

luisorbaiceta

comment created time in a day

issue commentfastify/fastify

Alias preParsing to onRequest hook. Deprecate preParsing

@kerm1it that deprecation was about the signature of the preParsing hook. This issue is about deprecating the hook entirely. So @darkgl0w is correct about the course of action.

mcollina

comment created time in a day

push eventfastify/fastify

Lachlan Collins

commit sha 2dfafcfa1f95af77000190fec277e623a691f05e

Move docs into Guides or Reference folders (#3508)

view details

push time in a day

PR merged fastify/fastify

Move documentation into Guides or Reference subfolders on docs-reorg documentation

In this PR, I've done my best to move the markdown files into the subfolder which is most applicable to their topic. I wasn't 100% sure for some of them (e.g. I put Testing.md in Guides), so please let me know if you'd like any files moved into the other category!

Checklist

+87 -88

0 comment

29 changed files

lachlancollins

pr closed time in a day

PullRequestReviewEvent

pull request commentfastify/fastify

Start of docs reorganization

I know. I just wanted to highlight this to @lachlancollins so he can think about it when working in parallel in the other project. Didn't mean to discuss it here, sorry.

👍

To get back to my question: do we need to do anything to the current website to support this PR fully? I am willing to accept:

  • https://github.com/fastify/fastify/pull/3474#issuecomment-982943091
  • with https://github.com/fastify/fastify/pull/3474#issuecomment-982840295

if the rest of @fastify/core is.

jsumners

comment created time in a day

PullRequestReviewEvent

pull request commentfastify/fastify

Start of docs reorganization

I'll wait for the final migration decision to open a PR for this if we decide to stick with current website. If we migrate then we'll have to see how this is achievable with the new stack. @lachlancollins

This PR should not be blocked by the website-next project. I have tried above, repeatedly, to make that clear. This PR can feed into that project, but it is meant to be completely independent of it.

jsumners

comment created time in a day

issue closedpinojs/pino

Release Frequency

I totally appreciate all the effort that you folks spend on adding things, fixing things, and making Pino better.

I totally do NOT appreciate the number of different releases from Pino in the last few weeks. Anyone who has Dependabot alerts on their GitHub projects (like I do), for example, is getting totally inundated with notifications and pull requests. Any of them that might actually be applicable require testing before acceptance -- and it does not please me to have to do that five times on each project if I want to stay up to date.

closed time in 2 days

craigmcc

issue commentpinojs/pino

Release Frequency

Thank you for the input. You are welcome to track releases at your own cadence by tweaking the tools you use.

craigmcc

comment created time in 2 days

pull request commentfastify/fastify

Start of docs reorganization

If there is no section selected we could show the /docs/index.md you are suggesting with the toc sidebar. User can already select the version from the breadcrumb and we are defaulting to the latest version anyway. Doing this would simplify the user flow a lot.

I think this scenario is what I am expecting.

jsumners

comment created time in 2 days

Pull request review commentpinojs/pino

Remove deprecated API and options in v7 option.

 const warning = require('fastify-warning')() module.exports = warning -const warnName = 'PinoWarning'+// const warnName = 'PinoWarning' -warning.create(warnName, 'PINODEP008', 'prettyPrint is deprecated, look at https://github.com/pinojs/pino-pretty for alternatives.')--warning.create(warnName, 'PINODEP009', 'The use of pino.final is discouraged in Node.js v14+ and not required. It will be removed in the next major version')+// warning.create(warnName, 'PINODEP010', 'A new deprecation')

It's easier to keep it and update it as necessary.

mcollina

comment created time in 2 days

PullRequestReviewEvent

pull request commentfastify/fastify

Start of docs reorganization

awwwwwwww-excited

However, I'm not seeing the text of /docs/index.md rendered there?

jsumners

comment created time in 2 days

pull request commentpinojs/pino

Remove prettyPrint option.

🤣 https://github.com/pinojs/pino/issues/1106#issuecomment-907614629

mcollina

comment created time in 2 days

issue commentdavidmarkclements/brittle

Create a VS Code test provider

If this is meant to replicate https://node-tap.org/docs/watch/ then I would not want it to be a VSCode extension exclusively. I would want the test runner to support it natively.

voxpelli

comment created time in 2 days

issue commentfastify/fastify

Remove app.use()

I think they are useful plugins, we should keep having them but reduce their visibility.

Issues like https://github.com/fastify/fastify-express/issues/61 are why I think we should deprecate the middie and fastify-express modules. People are not using them to "migrate" to Fastify. They're keeping their old Express stuff around indefinitely because we continue to support it. This is going to continue to cause problems and maintenance burden as these users continue to try and add more and more new technologies on top.

In short: I think we have given enough lifecycles to facilitate migrating. It's time to move forward.

mcollina

comment created time in 2 days

startedzeldaret/oot

started time in 3 days

issue commentfastify/fastify

Visual Studio (VS) Code terminal not showing the pino logs to stdout.

You can use builtin console to fix that problem. My solution for typescript:

const server = fastify({
    logger: config('app.debug') ? new class Logger {
      private args;
      constructor(...args: never) { this.args = args }
      info = (msg: unknown) => console.info(msg);
      error = (msg: unknown) => console.error(msg);
      debug = (msg: unknown) => console.debug(msg);
      fatal = (msg: unknown) => console.error(msg);
      warn = (msg: unknown) => console.warn(msg);
      trace = (msg: unknown) => console.trace(msg);
      child = () => new Logger();
    } : false
  });

This is unnecessary. Set your VSCode debugger profile to use "outputCapture": "std" -- https://github.com/microsoft/vscode-docs/blob/56f5a65c45b509f648a4150b9fe1a5b9bb1afa57/docs/nodejs/nodejs-debugging.md?plain=1#L132

dbauszus-glx

comment created time in 3 days

more