profile
viewpoint

jsejcksn/audio-on-youtube 6

Convert an audio file to video for uploading to YouTube

jsejcksn/audio-player 1

A simple web audio player

js-hackers/discord-bot-search-games 0

A chat bot which scrapes online game marketplace search results and presents its findings

jsejcksn/Arduino-ADXL362 0

Arduino Library for ADXL362 Micropower 3-axis accelerometer

jsejcksn/asdf 0

Extendable version manager with support for Ruby, Node.js, Elixir, Erlang & more

jsejcksn/beat-sequencer-html5 0

My first JS project (I made it in 2010 when html5 audio was hot stuff)

jsejcksn/black-screen 0

A terminal emulator for the 21st century.

issue openednestdotland/eggs

[FEATURE] Extract API-related functionality to module with scoped-only permissions

@t8 requested that I post this as a separate issue (ref. original comment: https://github.com/nestdotland/nest.land/issues/89#issuecomment-655827011)

I propose that the nest.land API functionality of eggs be split into a separate Deno module that can be used exclusively with scoped permissions. (ref. https://github.com/nestdotland/nest.land/issues/170#issue-647844339)

Users can then provide the necessary scoped --allow-* permission arguments with specific values to deno run and retain sandbox control of their own environments, rather than giving unrestricted permission to the script using permissions like --allow-env, --allow-run, --allow-all. (Although --allow-env is likely going to get list support: https://github.com/denoland/deno/issues/3137, https://github.com/denoland/deno/issues/6683#issuecomment-655259075)


As an example, if the user wants to publish, and the API module needs access to a specific configuration file and a list of files to be published, the user could run the module with the following run options:

deno run --allow-read="./config.json","./mod.ts","./utils.ts" --allow-net="https://*.nest.land/*" https://...path/to/nestLandAPI.ts --publish

and could be sure that the module does not access any local data other than the files permitted in the --allow-read list, and also does not access network resources other than provided in the --allow-net list.

Deno is designed to be secure by default, and requiring users to provide unrestricted permissions forces them to abandon that controlled sandbox security model.

created time in 6 hours

issue commentWICG/native-file-system

Access parent directory

how is it possible that same file might have two different parents?

Hard links is one example, but I’m not exactly sure of the definition of file because I haven’t read that part of the spec yet either.

lukejagodzinski

comment created time in 12 hours

issue commentdenoland/deno

Limited Permission for --allow-env

Comma separated list is easy to break, as its commonplace for env variables to contain comma seperated lists.

Related: https://github.com/denoland/deno/issues/6553

keroxp

comment created time in a day

issue commentdenoland/deno

Limited Permission for --allow-env

If the format for --allow-env is changed to --env, it would break consistency with the other --allow-* permissions.

But keeping the comma-separated format doesn't preclude optional assignments using =.

keroxp

comment created time in a day

Pull request review commentrust-lang/rustlings

feat: add fake manifest for analyzers/IDEs (fixes #443)

+# This Cargo.toml is AUTOGENERATED, you shouldn't need to edit it.+# The `rustling` commands do not rely on this manifest at all, its only purpose+# is to help editors analyze your code.+# To regenerate it, run `cargo generate-manifest`.+[package]+name = 'exercises'+version = '0.1.0'+edition = '2018'+authors = ['The Rustlings Maintainers']+publish = false++[[bin]]

Errors are produced for each target without a main fn.

jrvidal

comment created time in a day

pull request commentrust-lang/rustlings

feat: add fake manifest for analyzers/IDEs (fixes #443)

I tried this:

  • Copied ./exercies/Cargo.toml to my own clone of the rustlings repo (checked out to 4.0.0)
  • Opened ./examples in VS Code
  • Opened an exercise file

The Rust extension began working for quite a while, processing all the binaries. Eventually, it resulted in in-editor intellisense linting for each of the exercise files.

However, all of the problems from all files appear in the Problems panel at once. This might be all that is possible (I'm not sure how the Rust extension handles problem reporting). In comparison, the TypeScript language server only reports problems for files which are currently open in editor tabs.

Is there a way to get problem reporting without actually running all the debug incremental builds? It would speed things up tremendously.


Aside: Interestingly, this was among the reported problems:

~/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/macros/mod.rs mod.rs[70, 17]: expected struct std::vec::Vec, found ()

mismatched types

expected struct `std::vec::Vec`, found `()`

note: expected struct `std::vec::Vec<std::string::String>`
      found unit type `()`rustc(E0308)
jrvidal

comment created time in a day

issue closedcli/cli

bash completions: bad option: -t

Describe the bug

After installing, every new terminal session (zsh) begins with this error:

/usr/local/etc/bash_completion.d/gh.sh:type:1456: bad option: -t

Version: gh version 0.10.1 (2020-06-24)

Steps to reproduce the behavior

  1. Use macOS + zsh (it's the default shell)
  2. brew install github/gh/gh
  3. Open a new terminal tab/window
  4. View error message

Fix

rm /usr/local/etc/bash_completion.d/gh.sh

closed time in a day

jsejcksn

issue commentcli/cli

bash completions: bad option: -t

I did some more digging and discovered that this wasn't caused by gh. I enabled homebrew shell completions before upgrading to macOS 10.15 Catalina, so I had the completions configuration for bash leftover in my .zshrc after the upgrade.

I guess gh was just the first to install one that actually used zsh-incompatible statements.

So I did the following:

  • .zshrc: removed the bash completion config and added the zsh completion config
  • brew uninstall gh
  • brew install gh
  • opened a new terminal tab

and no errors now

jsejcksn

comment created time in a day

issue commentdenoland/deno

Limited Permission for --allow-env

Escaped like this? --allow-env=“FOO”,”BAR”,”BAZ=$QUX”

keroxp

comment created time in 2 days

issue openednestdotland/nest.land

[FEATURE] Extract API-related functionality to module with scoped-only permissions

@t8 requested that I post this as a separate issue (ref. original comment: https://github.com/nestdotland/nest.land/issues/89#issuecomment-655827011)

I propose that the nest.land API functionality of eggs be split into a separate Deno module that can be used exclusively with scoped permissions. (ref. https://github.com/nestdotland/nest.land/issues/170#issue-647844339)

Users can then provide the necessary scoped --allow-* permission arguments with specific values to deno run and retain sandbox control of their own environments, rather than giving unrestricted permission to the script using permissions like --allow-env, --allow-run, --allow-all. (Although --allow-env is likely going to get list support: https://github.com/denoland/deno/issues/3137, https://github.com/denoland/deno/issues/6683#issuecomment-655259075)


As an example, if the user wants to publish, and the API module needs access to a specific configuration file and a list of files to be published, the user could run the module with the following run options:

deno run --allow-read="./config.json","./mod.ts","./utils.ts" --allow-net="https://*.nest.land/*" https://...path/to/nestLandAPI.ts --publish

and could be sure that the module does not access any local data other than the files permitted in the --allow-read list, and also does not access network resources other than provided in the --allow-net list.

Deno is designed to be secure by default, and requiring users to provide unrestricted permissions forces them to abandon that controlled sandbox security model.

created time in 2 days

issue commentdenoland/deno

Using shebang to tell deno the running flags;

Reference: https://github.com/BentoumiTech/denox

Wallacy

comment created time in 2 days

issue commentBentoumiTech/denox

Provide a meta-command to output interpolated deno command strings

@BentoumiTech Thoughts?

jsejcksn

comment created time in 2 days

startedrust-lang/rust

started time in 2 days

startedrust-lang/rustlings

started time in 2 days

issue openedcli/cli

bash completions: bad option: -t

Describe the bug

After installing, every new terminal session (zsh) begins with this error:

/usr/local/etc/bash_completion.d/gh.sh:type:1456: bad option: -t

Version: gh version 0.10.1 (2020-06-24)

Steps to reproduce the behavior

  1. Use macOS + zsh (it's the default shell)
  2. brew install github/gh/gh
  3. Open a new terminal tab/window
  4. View error message

Fix

rm /usr/local/etc/bash_completion.d/gh.sh

created time in 2 days

issue commentmanyuanrong/deno_mongo

Generate ObjectId

I’m still not sure whether to maintain an API similar to the Node.js client, which has some additional costs, not sure how much benefit this will have

That's ok. You are the author and you ultimately decide what goes in. I just think you can avoid some other issues similar to this one by setting more clear expectations about what it does and doesn't do. If you know you won't support certain parts, perhaps you can link to other deno packages in the readme so that people know where to get the functionality.

That being said, I think there are a lot of helpful parts that are provided by the Node driver which aren't provided here yet.

aliddy23

comment created time in 2 days

startedcli/cli

started time in 2 days

issue commentnestdotland/nest.land

[FEATURE] Scope permissions for eggs CLI installation

are you referring to building a sort of Deno API client for nest.land?

Exactly. And eggs would be the dogfood consumer

asos-craigmorten

comment created time in 2 days

issue commentnestdotland/nest.land

[FEATURE] Scope permissions for eggs CLI installation

@t8 I propose that the nest.land API functionality of eggs be split into a separate exported module that can be used exclusively with scoped permissions. (ref. https://github.com/nestdotland/nest.land/issues/170#issue-647844339). Users can then create higher-level abstractions for providing the necessary permission arguments while retaining sandbox control of their own environments. Just handing over the keys is not something that everyone can do.

asos-craigmorten

comment created time in 2 days

issue commentWICG/native-file-system

Access parent directory

@lukejagodzinski That's what's great about foundational-level APIs: They provide only what's absolutely necessary and because of that, should be as performant as possible. Then other abstractions can provide tailored interfaces by application (at the cost of performance).

lukejagodzinski

comment created time in 2 days

issue commentmanyuanrong/deno_mongo

Generate ObjectId

@manyuanrong I think more people finding this plugin are going to anticipate the same or similar API to the Node driver. I'm not sure if that's an eventual goal of yours or not, but you should probably clarify that in the readme.

aliddy23

comment created time in 3 days

issue commentmanyuanrong/deno_mongo

Generate ObjectId

@aliddy23 Ref: https://docs.mongodb.com/manual/reference/method/ObjectId/

const hex = [...Array(256).keys()]
  .map(index => index.toString(16).padStart(2, '0'));

const createObjectId = (counter?: Uint8Array) => {
  const seconds = Math.floor(Date.now() / 1000);
  const rCounter = counter ?? crypto.getRandomValues(new Uint8Array(3));
  const r = crypto.getRandomValues(new Uint8Array(5));

  return `${seconds.toString(16)}${[...r.values(), ...rCounter.values()].map(int => hex[int]).join('')}`;
};
console.log(createObjectId());
aliddy23

comment created time in 3 days

startedhedinne/popping-and-locking-vscode

started time in 3 days

issue commenthedinne/popping-and-locking-vscode

Decrease highlight bg color compared to selection bg color

I’m glad you agree. This theme is one of the small minority that differentiates a maximum amount of tokens in different contexts. (And the colors are ✨.) It’s hard to imagine finding something else to use!

jsejcksn

comment created time in 3 days

startedrealm/realm-js

started time in 4 days

issue commentmicrosoft/TypeScript

Add type to retrieve valid events of an EventTarget

Also, classes which extend EventTarget should be able to provide an EventMap type argument so that the corresponding listeners recognize the appropriate types and events.

Here's an example:

type SpellCastEvent = CustomEvent<{
  id: number;
  effect: string;
  name: string;
}> & {
  type: 'spell_cast';
};

type SpellcasterEventMap = {
  spell_cast: SpellCastEvent;
};

class Spellcaster extends EventTarget<SpellcasterEventMap> {
  constructor() {
    super();
    // ...
  }
}

function spellEventHandler (event: SpellCastEvent) {
  console.log(`The ${event.detail.name} spell was cast.`);
}

const spellcaster = new Spellcaster();

spellcaster.addEventListener('spell_cast', spellEventHandler);

Right now, this causes an error when calling spellcaster.addEventListener(), and has to be addressed with a type assertion in the handler like so:

function spellEventHandler (event: Event) {
  const ev = (event as SpellCastEvent);
  console.log(`The ${ev.detail.name} spell was cast.`);
}

You can see the errors I'm describing in #39425.

kripod

comment created time in 4 days

issue commentdenoland/vscode_deno

[Discussion] Possible solution to fix delays and versioning confusion: Merge `typescript-deno-plugin` into `vscode_deno`?

typescript-deno-plugin is not only used in vscode, but also used by vim and idea

and we still need to publish typescript-deno-plugin to npm

☝️ Very important that it remains separately available to other consumers

David-Else

comment created time in 4 days

pull request commentGlench/fuzzyset.js

Add ES module

This this PR doesn't have anything to do with TypeScript—it's just a convenient side-effect that it solves #46.

is there a way to make it work that works drop-in for the browser as well as in Typescript and Node?

Short answer

If you want to support old browsers like IE11 and Node versions before 12.17.0, then you must provide separate files in formats supported by those environments.

Otherwise, you can drop the CommonJS file and just use ESM, in a major version change. If people want support for older formats, they can always use an older version of the package.

More info

JavaScript lacked an official, standardized module system until ES2015, so Node chose to use CommonJS. Now that ESM is the standard, Node supports it as well (without using any flags) starting in v12.17.0. However, the decision to use an unofficial module system has made things complicated for the ecosystem. I encourage you to read about the complexities of Node's transition to ESM, especially about dual CJS/ESM packages.

If you want to publish multiple file formats, you can use a build step to generate them from your ESM source.

jsejcksn

comment created time in 4 days

issue commenteslint/eslint

Support ESM config (.eslintrc.mjs)

Given that we are moving forward with a different config system

@nzakas I thought it was just an RFC at this point. Especially in consideration of the statement in your most recent message, isn’t it prudent to support ESM in the current system?

jsejcksn

comment created time in 4 days

pull request commentGlench/fuzzyset.js

Add ES module

@Glench Thoughts?

jsejcksn

comment created time in 5 days

issue openedmicrosoft/TypeScript

lib.dom.d.ts window interfaces missing "gamepadconnected" and "gamepaddisconnected"

TypeScript Version: 4.0.0-dev.20200703

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: gamepad OR gamepadconnected

Code

1:

window.addEventListener('gamepadconnected', event => console.log(event.gamepad));

Property 'gamepad' does not exist on type 'Event'.

2:

window.addEventListener('gamepadconnected', (event: GamepadEvent) => console.log(event.gamepad));

No overload matches this call. Overload 1 of 2, '(type: "abort" | "afterprint" | "beforeprint" | "beforeunload" | "blur" | "canplay" | "canplaythrough" | "change" | "click" | "compassneedscalibration" | "contextmenu" | "dblclick" | ... 122 more ... | "unhandledrejection", listener: (this: Window, ev: Event | ... 22 more ... | PromiseRejectionEvent) => any, options?: boolean | ... 1 more ... | undefined): void', gave the following error. Argument of type '"gamepadconnected"' is not assignable to parameter of type '"abort" | "afterprint" | "beforeprint" | "beforeunload" | "blur" | "canplay" | "canplaythrough" | "change" | "click" | "compassneedscalibration" | "contextmenu" | "dblclick" | ... 122 more ... | "unhandledrejection"'. Overload 2 of 2, '(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions | undefined): void', gave the following error. Argument of type '(event: GamepadEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject'. Type '(event: GamepadEvent) => void' is not assignable to type 'EventListener'. Types of parameters 'event' and 'evt' are incompatible. Property 'gamepad' is missing in type 'Event' but required in type 'GamepadEvent'.

Expected behavior:

No errors.

Actual behavior:

See errors ☝️

Playground Link: https://www.typescriptlang.org/play?target=99&ts=4.0.0-dev.20200703#code/O4SwdgJg9sB0CGEIFEBuBTMAXAMiAzlpugE4AUA5AObwC26ADogMZRhjrNEQUA0ABOgzZ+AXgB8-VmHxQANulhyoVMkMxZYNekwgBKPQG4AUKEgwESNBryFi5anUYs2HLuh4C1wrAC5+AOJOutbYemKS0rIKSireGlrBiAYmQA

lib.dom.d.ts has Gamepad, GamepadEvent, etc., but the related window interfaces lack references to the Gamepad API

created time in 6 days

startedyoannmoinet/nipplejs

started time in 6 days

startedVSCodium/vscodium

started time in 8 days

issue commentWICG/native-file-system

Access parent directory

@lukejagodzinski What would be the value of entry.parent in the event that the file handle was obtained directly and the app doesn't have permission to access the parent?

lukejagodzinski

comment created time in 8 days

startedsveltejs/svelte

started time in 8 days

startedpreactjs/preact

started time in 8 days

issue commentdenolib/ms

Add versioned release tag(s)

@kt3k. Thanks! The conventional format is ‘vSEMVER`, (beginning with a literal v). You are obviously free to use whatever format you prefer, but consider surveying other community modules.

jsejcksn

comment created time in 8 days

pull request commentjustjavac/typescript-deno-plugin

Add support for URLs with non-default ports

@justjavac I'd love to get the functionality of this commit in denoland/vscode_deno. What is needed for that? A new release?

I saw that the 1.31.0 release was reverted, but I'm not sure why.

jsejcksn

comment created time in 9 days

pull request commentdenoland/vscode_deno

revert changes to get it working again

Just trying to get back to a good state quickly.

What does this mean, and what does it reference?

ry

comment created time in 9 days

issue openeddenolib/ms

Add versioned release tag(s)

I can import now using commit hash like https://deno.land/x/ms@368ad2fad4477b6ad19bff696a6eaf57a4f627a0/ms.ts, but semver tags are much nicer.

See:

  • https://deno.land/manual/linking_to_external_code#how-do-i-import-a-specific-version-of-a-module
  • https://help.github.com/en/github/administering-a-repository/managing-releases-in-a-repository

created time in 9 days

issue commentcodesandbox/codesandbox-client

Add deno-js support

@lbogdan How does one use a VS Code extension in CodeSandbox? This is the official one, which takes care of those issues:

https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno

hazae41

comment created time in 9 days

issue openedbwiklund/gamepad.js

[Website] Add search, sort, filtering for controllers/codes

Since the pagination is for presentation only, and the entire dataset is downloaded to the client on page load, it would be nice to be able to search, sort, and filter the data.

Basic lowercase text str.includes() filtering would be a great start, but fuzzy search would be even better.

Adding support for sorting by field would be great, too (reversing, sort by count/variant/etc.).

I'm sure you could get community help with this, but I'm not sure how the website relates to this repo, since the site links to this repo, but there's not mention of a repo dedicated to the website source. Is there a repo for that purpose, or plans for one?

created time in 10 days

CommitCommentEvent

issue closedmicrosoft/terminal

Updating apps in Microsoft Store terminates Windows Terminal without notice

<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:

  1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
  2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
  3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
  4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
  5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed! -->

<!-- This bug tracker is monitored by Windows Terminal development team and other technical folks.

Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible.

-->

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 1.0.1811.0

Any other software? Microsoft Store

Steps to reproduce

  1. Have open one or more Windows Terminal sessions
  2. Update apps in Microsoft Store

Expected behavior

If there is an update for Windows Terminal, I am notified and given a choice to defer the update and continue my session(s), or to terminate the application and initiate the update.

Actual behavior

The Windows Terminal app is terminated without notice

closed time in 10 days

jsejcksn

issue commentmicrosoft/terminal

Updating apps in Microsoft Store terminates Windows Terminal without notice

Duplicate issue

  • #6726
  • #3915
jsejcksn

comment created time in 10 days

issue openedmicrosoft/terminal

Updating apps in Microsoft Store terminates Windows Terminal without notice

<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:

  1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
  2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
  3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
  4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
  5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed! -->

<!-- This bug tracker is monitored by Windows Terminal development team and other technical folks.

Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible.

-->

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 1.0.1811.0

Any other software? Microsoft Store

Steps to reproduce

  1. Have open one or more Windows Terminal sessions
  2. Update apps in Microsoft Store

Expected behavior

If there is an update for Windows Terminal, I am notified and given a choice to defer the update and continue my session(s), or to terminate the application and initiate the update.

Actual behavior

The Windows Terminal app is terminated without notice

created time in 10 days

issue commentnestlandofficial/nest.land

Permissions / API

@tbaumer22 Thanks for linking me to the other issue. I think this one is effectively a duplicate of that one, so feel free to close it if you agree.

jsejcksn

comment created time in 11 days

issue commentdenoland/deno

How to provide an --allow-* arg containing a comma?

On topic: Has the idea been discussed to allow for pattern matching in the --allow-* arg values?

jsejcksn

comment created time in 11 days

starteddotansimha/graphql-code-generator

started time in 11 days

startedgraphql/graphql-js

started time in 11 days

issue openednestlandofficial/nest.land

Permissions / API

It is not possible for me to grant unsandboxed/unrestricted access to any unsigned application in my CLI environment. Using --allow-all during installation is simply not a possibility.

I would still like to interact with nest.land, and I am able to grant eggs restricted permissions in order to do so.

e.g.

--allow-net 🙅 --allow-net=x.nest.land,deno.land,denopkg.com 👍

--allow-read 🙅 --allow-read="$HOME/.nest-api-key","$HOME/.eggs" 👍

--allow-write 🙅 --allow-write="$HOME/.nest-api-key","$HOME/.eggs" 👍

--allow-env 🙅 --allow-run 🙅 (this is presently equivalent to --allow-all)

I realize that some parts of the application might require either access to my environment variables OR for me to provide configuration values.

Will you provide a list maximally-restrictive permissions for functionality? If this is not possible, and you are unwilling to refactor the application to support greater user privacy and control, can you please detail how I can use the API to publish to and interact with nest.land? If there is already documentation for this, just point me to it. Thanks!

created time in 11 days

pull request commentKong/insomnia

Run GraphQL query based on cursor position.

It seems like this change didn't make it into the docs: https://support.insomnia.rest/article/61-graphql

bwlt

comment created time in 11 days

pull request commentdenoland/vscode_deno

Add enabled "paths" config option

Some questions to consider:

  • Is the intended use for this to match patterns relative to the workspace directory or root directory?
  • Regex patterns and/or glob patterns?
  • Is deno.enablePatterns a more suitable name for an array of patterns?
Flaque

comment created time in 11 days

delete branch jsejcksn/typescript-deno-plugin

delete branch : resolve-remote-modules-with-ports

delete time in 11 days

pull request commentjustjavac/typescript-deno-plugin

Add support for URLs with non-default ports

This adds support for port numbers in remote module resolution. I didn't see any places that would support a test for this, so please test with a local file server before merging.

@justjavac Did it work as expected?

jsejcksn

comment created time in 11 days

delete branch jsejcksn/typescript-deno-plugin

delete branch : upgrade-deno

delete time in 11 days

issue commentBentoumiTech/denox

Add option: args

Perhaps the args value can also be null to handle the case where it is set on workspace.globals but one or more scripts shouldn't inherit the value.

jsejcksn

comment created time in 11 days

issue commentdenoland/deno

How to provide an --allow-* arg containing a comma?

@ry Nope

I prepared a test for anyone who wants to explore this:

comma.test.ts:

import {exists} from 'https://deno.land/std@0.59.0/fs/exists.ts';

const fileNames = [
  'file',
  'file,withcomma',
];

for (const fileName of fileNames) {
  Deno.test(`Read "${fileName}"`, async () => {
    await exists(fileName);
  });
}

Results:

deno test comma.test.ts # fail (0/2)

deno test --allow-read comma.test.ts # pass (2/2)

deno test --allow-read="file,file\,withcomma" comma.test.ts # fail (1/2)
deno test --allow-read="file,file\\,withcomma" comma.test.ts # fail (1/2)

deno test --allow-read="file","file,withcomma" comma.test.ts # fail (1/2)
deno test --allow-read="file","file\,withcomma" comma.test.ts # fail (1/2)
deno test --allow-read="file","file\\,withcomma" comma.test.ts # fail (1/2)
jsejcksn

comment created time in 11 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

Maybe you should add a warning or troubleshoot in the readme about that error, or some concrete error if in you kernel version contains "microsoft" and haven't access to .exes.

@Nisgrak Added in https://github.com/rsp/deno-clipboard/pull/5/commits/4f7dfd2bac74a4cf2f2a69e2176b0e8bedb31231

jsejcksn

comment created time in 11 days

push eventjsejcksn/deno-clipboard

Jesse Jackson

commit sha 2f76a8e0e384416d4003047109859404d27e1260

Try to preserve clipboard after testing

view details

Jesse Jackson

commit sha 4f7dfd2bac74a4cf2f2a69e2176b0e8bedb31231

Add discrete error message for WSL

view details

push time in 11 days

issue commentnestlandofficial/nest.land

[FEATURE] Add .eggignore file and allow users to chose between the ignore file or the files field in egg.json

It would be nice to provide or link to a utility for generating the files array from the package directory. I think the main chore here is having to manually create the list. +1 for the util supporting a filter file like .gitignore

MartonDev

comment created time in 12 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

@rsp Thoughts?

jsejcksn

comment created time in 12 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

@Nisgrak That's great to hear. So everything is working now: the tests pass when you run deno test --allow-run in the repo directory?

jsejcksn

comment created time in 12 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

uname -r -v
which clip.exe
which powershell.exe

@Nisgrak Will you try those commands using a first-party Microsoft terminal application like %windir%\system32\cmd.exe or Windows Terminal?

jsejcksn

comment created time in 12 days

issue openeddenoland/deno

How to provide an --allow-* arg containing a comma?

In an --allow-* permission that accepts a comma-separated list, how do I provide a value that contains a comma?

I tried:

deno run --allow-read="./filewithoutcomma,./file\,withcomma" script.ts

and

deno run --allow-read="./filewithoutcomma,./file\\,withcomma" script.ts

Neither worked.

I tried asking via other help channels, but got no responses, so I'm hoping someone can address this here. Thanks!

created time in 12 days

issue commentdenoland/deno

deno bundle bugs?

Incorrect. It does in a lot of cases...

In this case it is a duplicate of #4539 which is not handled properly at the moment. (In this case Pika is providing an X-TypeScript-Types headers, but it is functionally equivalent to the triple slash directive.

@kitsonk Thanks for correcting me. I never want to spread misinformation.

zalelion

comment created time in 12 days

issue commentBentoumiTech/denox

Import 'https://raw.githubusercontent.com/LOCALPATH' 404 Not Found

This bug exists in macOS as well and is limited to script workspace files. I think it is caused by calling path.resolve (Deno doc, Node doc) at this line because the import is a remote URL:

https://github.com/BentoumiTech/denox/blob/7774ec1709bdfc5b9dc756a6b4642ac849274455/src/utils/file.ts#L15

If you clone the denox repo and run it locally, it loads the workspace file without error.

creepinson

comment created time in 12 days

issue openedBentoumiTech/denox

Document workspace file resolution logic

Issue Type

  • Other (Documentation)

I see there is resolution logic for this, but it is not yet documented.

Ref. source: https://github.com/BentoumiTech/denox/blob/7774ec1709bdfc5b9dc756a6b4642ac849274455/src/parser/deno_workspace.ts#L12-L27

https://github.com/BentoumiTech/denox/blob/7774ec1709bdfc5b9dc756a6b4642ac849274455/src/const.ts#L3-L14

I think it would be good to reconsider the resolution order based on some rules. This is how ESLint does it. Here is a suggested idea with included reasoning:

(Don't support extensionless deno-workspace because of ambiguity — but if you feel strongly about this, explain clearly which format(s) are valid without an extension, e.g. yaml/json)

  1. First, files that begin with deno-workspace (not dotfiles because in the event of a conflict, the dotfile is potentially hidden and could be a surprise).

  2. Next, in the following extension order, preferring more human-readable formats and static files, which offer better security at the cost of flexibility (more on this below):

    • .yaml
    • .yml
    • .json
    • (no extension would go here if it is not a script)
    • .ts
    • .js
  3. Files that begin with .deno-workspace following the same extension order as above

So, the suggested order would be:

  • deno-workspace.yaml
  • deno-workspace.yml
  • deno-workspace.json
  • deno-workspace (if it is not a script)
  • deno-workspace.ts
  • deno-workspace.js
  • .deno-workspace.yaml
  • .deno-workspace.yml
  • .deno-workspace.json
  • .deno-workspace (if it is not a script)
  • .deno-workspace.ts
  • .deno-workspace.js

Security

It appears that when evaluating workspace script files, they are evaluated with the permissions inherited from denox, which is suggested to be --allow-all at installation. Is that correct? If so, that could be very dangerous.

Static configuration files are easier to reason about than dynamic scripts, so they are easier to secure.

created time in 12 days

startedBentoumiTech/denox

started time in 12 days

issue openedBentoumiTech/denox

Add option: args

Issue Type

  • Feature Request

Add a new args array property to options.globals and options.scripts[name].

This would allow default arguments to be appended to the interpolated command. Here are some examples:

Script:

scripts:
  develop:
    file: main.ts
    args:
      - hello
globals:
  deno_options:
    allow-read: true
> denox run develop
# equal to:
# deno run --allow-read main.ts hello
> denox run develop more args
# equal to:
# deno run --allow-read main.ts hello more args

Global:

scripts:
  develop:
    file: main.ts
globals:
  args:
    - foo bar
    - baz
  deno_options:
    allow-read: true
> denox run develop
# equal to:
# deno run --allow-read main.ts "foo bar" baz
> denox run develop more args
# equal to:
# deno run --allow-read main.ts "foo bar" baz more args

Both: (script replaces global, like with deno_options)

scripts:
  develop:
    file: main.ts
    args:
      - nice to
      - meet you
globals:
  args:
    - foo bar
    - baz
  deno_options:
    allow-read: true
> denox run develop
# equal to:
# deno run --allow-read main.ts "nice to" "meet you"
> denox run develop more args
# equal to:
# deno run --allow-read main.ts "nice to" "meet you" more args

created time in 12 days

issue openedBentoumiTech/denox

Provide a meta-command to output interpolated deno command strings

Issue Type

  • Feature Request

This screenshot is shown in the readme:

denox in terminal

After running the command, it shows this text in stdout:

Running main script with allow-read, seed and reload options ...

This doesn't appear in the current version of denox. I don't know why for certain, but I agree that it shouldn't be in stdout for multiple reasons.

However, this is the core functionality of denox: to interpolate commands for proxying to deno.

It would be extremely useful for denox to provide the interpolated command strings using a prefix like command, for example:

deno-workspace.yaml

scripts:
  main:
    file: main.ts
    deno_options:
      allow-net: example.com
      unstable: true
> denox command run main script args
deno run --allow-net=example.com --unstable main.ts script args

This would be useful for understanding how denox is parsing the workspace file and could potentially help to debug denox in the future.

Info

  • DenoX version: 0.4.0

created time in 12 days

issue commentBentoumiTech/denox

Syntax: "denox start" as option to "denox run start"

I love less typing, too! I have proposed an alternate solution to this in #16

dllmkdir

comment created time in 12 days

issue openedBentoumiTech/denox

Support additional Deno commands

Issue Type

  • Feature Request

It appears that currently denox supports only proxying the deno run command. Are there plans to implement other commands like deno info, deno repl, deno eval, etc? If so, are the plans on a roadmap somewhere?

created time in 12 days

issue openedBentoumiTech/denox

Terser syntax through well-documented defaults and inference

Issue Type

  • Feature Request

It appears that one of the primary goals of this project is to reduce typing. I think every programmer loves that.

It might be possible to allow for even terser syntax by establishing and documenting some sensible defaults and inference behavior. Here are some suggested considerations:

Default script:

For example, one could use the command denox run, which would be expanded to denox run default. (I gave default as the example here, but maybe you like main, etc.)

Example:

deno-workspace.yaml

scripts:
  default:
    file: main.ts
    deno_options:
      allow-net: example.com

shell

denox run
# equal to:
# deno run --allow-net=example.com main.ts

Inferring file from script:

Likewise, in deno-workspace.scripts: If a script does not provide a value for file, it could be inferred from its script key—this would allow it to be an optional property if people would like to organize scripts directly by file name. This practice provides the advantage of native terminal tab-completion and also promotes an organizational structure which aligns with the workspace filesystem.

Example:

This:

scripts:
  main.ts:
    file: main.ts
    deno_options:
      allow-net: example.com

could be equal to:

scripts:
  main.ts:
    deno_options:
      allow-net: example.com

created time in 12 days

startedemotion-js/emotion

started time in 12 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

@Nisgrak I’lll look into this more. Those executables with the .exe extensions should be in your path. See https://docs.microsoft.com/en-us/windows/wsl/interop#run-windows-tools-from-linux

Have you modified your path or installed tools which might have modified your path?

jsejcksn

comment created time in 13 days

pull request commentrsp/deno-clipboard

Update; Add read parsing options

@Nisgrak That means that your environment was not able to be detected as WSL.

Can you provide some information about your environment?

  1. Is it WSL or WSL 2?

  2. Which terminal are you using?

  3. Which distribution have you installed from the Windows store?

  4. Will you please copy and paste the output of the following three commands? They are currently what is being used to make the determination:

uname -r -v
which clip.exe
which powershell.exe
jsejcksn

comment created time in 13 days

issue commentdenoland/deno

deno bundle bugs?

deno bundle is for running code in Deno. It also does not bundle remote imports.

In order to run your compiled TypeScript code in the browser, you're going to need a compiler for that purpose (like tsc with an appropriate tsconfig.json or webpack, etc.)

zalelion

comment created time in 13 days

push eventjsejcksn/typescript-deno-plugin

Jesse Jackson

commit sha 5e8fd8e6ad6ebb15586c4014bf10915f7ebf34de

Format source

view details

push time in 13 days

PR opened justjavac/typescript-deno-plugin

Add support for URLs with non-default ports

Ref. Deno source: https://github.com/denoland/deno/blob/2da084058397efd6f517ba98c9882760ec0a7bd6/cli/disk_cache.rs#L55

This adds support for port numbers in remote module resolution. I didn't see any places that would support a test for this, so please test with a local file server before merging.

I think this should resolve https://github.com/denoland/vscode_deno/issues/24#issuecomment-649918614.

+1 -1

0 comment

1 changed file

pr created time in 13 days

PR opened justjavac/typescript-deno-plugin

upgrade deno@v1.1.2

Update type definitions

+77 -1276

0 comment

1 changed file

pr created time in 13 days

create barnchjsejcksn/typescript-deno-plugin

branch : upgrade-deno

created branch time in 13 days

fork jsejcksn/typescript-deno-plugin

Deno language service plugin for TypeScript

fork in 13 days

push eventjsejcksn/deno-clipboard

Jesse Jackson

commit sha cbfbbfed9cb8e0c5ce949c8ef30b3df4b9e23697

Replace "trim" option with "trimFinalNewlines" and catch exceptions while determining Linux binary

view details

Jesse Jackson

commit sha 762d6654236b717a0a0e75f158fedfe8d6d0b170

Update readme to reflect updatd read options

view details

Jesse Jackson

commit sha 5f8f7f44708f6f0d9a5f17a68f70f86512886b6f

Update read options in tests

view details

push time in 13 days

startedgskinner/regexr

started time in 14 days

issue commentdenoland/deno

I need a CORS equivalent method.

@kitsonk Issue templates can be created for this repository to help steer people. See codesandbox/codesandbox-client/issues/new/choose for an example. You might consider using the GitHub discussions feature, too.

mateusfg7

comment created time in 14 days

issue commentdenoland/deno

Provide .exe and .tar releases

This is a very reasonable request. The source code is already being released in zip and tar.gz formats.

I also like that you gave a 👍 to your own post 😄 .

MarkTiedemann

comment created time in 14 days

issue commentgskinner/regexr

Option to hide the "named capture groups may not be supported" warning

I'd like for this option as well! It would make identifying actual errors easier.

leumasme

comment created time in 14 days

issue commentGoogleChrome/web.dev

Glitch embeds don't display

This issue is still unresolved.

jsejcksn

comment created time in 14 days

issue commentasdf-vm/asdf

Wrap terminal line output to 80 characters

+1 for a machine-readable-formatted option using a flag. I suggest JSON.

jsejcksn

comment created time in 15 days

issue openedubersl0th/markdown

Create tagged releases

That way users can import a specific version of the module and the API won't potentially change and break their app. Using semver values for tag versions (e.g. v0.1.0, v1.1.2, etc.) is ideal.

See:

  • https://deno.land/manual/linking_to_external_code#how-do-i-import-a-specific-version-of-a-module
  • https://help.github.com/en/github/administering-a-repository/managing-releases-in-a-repository

created time in 15 days

issue commentdenoland/vscode_deno

The remote module has not been cached locally

I am also experiencing this issue. Here are the details:

caching-issue

<details> <summary><code>caching-issue.ts</code></summary>

import {assertEquals} from 'https://deno.land/std@0.58.0/testing/asserts.ts';
import {mean} from 'http://localhost:8080/local-modules/stats@v0.1.2/mod.ts';

/* eslint-disable no-magic-numbers */
Deno.test('Average of [3, 4, 5, 6] is 4.5', () => {
  assertEquals(mean([3, 4, 5, 6]), 4.5);
});

</details>

<details> <summary><code>tsserver.log</code></summary>

Info 0    [20:49:24.516] Starting TS Server
Info 1    [20:49:24.516] Version: 3.9.4
Info 2    [20:49:24.516] Arguments: /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Renderer).app/Contents/MacOS/Code Helper (Renderer) /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /var/folders/hx/8w56lz5x1_l9wn_yfyt1tsg00000gn/T/vscode-typescript501/98bf878b86d03a90af36/tscancellation-d3bf007d74294c64b069.tmp* --logVerbosity normal --logFile /Users/private/Library/Application Support/Code/logs/20200625T164055/exthost12/vscode.typescript-language-features/tsserver-log-G1hjnt/tsserver.log --globalPlugins typescript-vscode-sh-plugin,typescript-deno-plugin,typescript-styled-plugin --pluginProbeLocations /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features,/Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0,/Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [20:49:24.516] Platform: darwin NodeVersion: 12 CaseSensitive: false
Info 4    [20:49:24.535] Host information vscode
Info 5    [20:49:24.536] Host watch options changed to undefined, it will be take effect for next watches.
Info 6    [20:49:24.538] Search path: /Users/private/redacted/path/deno/experiments
Info 7    [20:49:24.539] For info: /Users/private/redacted/path/deno/experiments/caching-issue.ts :: No config files found.
Info 8    [20:49:24.542] Loading global plugin typescript-vscode-sh-plugin
Info 9    [20:49:24.543] Enabling plugin typescript-vscode-sh-plugin from candidate paths: /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features,/Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0,/Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29,/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../..
Info 10   [20:49:24.543] Loading typescript-vscode-sh-plugin from /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features (resolved to /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/node_modules)
Info 11   [20:49:24.565] typescript-vscode-sh-plugin initialized. Intercepting getEncodedSemanticClassifications and getEncodedSyntacticClassifications.
Info 12   [20:49:24.565] Plugin validation succeded
Info 13   [20:49:24.565] Loading global plugin typescript-deno-plugin
Info 14   [20:49:24.566] Enabling plugin typescript-deno-plugin from candidate paths: /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features,/Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0,/Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29,/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../..
Info 15   [20:49:24.566] Loading typescript-deno-plugin from /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features (resolved to /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/node_modules)
Info 16   [20:49:24.586] Loading typescript-deno-plugin from /Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0 (resolved to /Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0/node_modules)
Info 17   [20:49:24.605] [typescript-deno-plugin] plugin created.
Info 18   [20:49:24.605] Plugin validation succeded
Info 19   [20:49:24.605] Loading global plugin typescript-styled-plugin
Info 20   [20:49:24.605] Enabling plugin typescript-styled-plugin from candidate paths: /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features,/Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0,/Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29,/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../..
Info 21   [20:49:24.605] Loading typescript-styled-plugin from /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features (resolved to /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/node_modules)
Info 22   [20:49:24.607] Loading typescript-styled-plugin from /Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0 (resolved to /Users/private/.vscode/extensions/denoland.vscode-deno-1.25.0/node_modules)
Info 23   [20:49:24.608] Loading typescript-styled-plugin from /Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29 (resolved to /Users/private/.vscode/extensions/jpoissonnier.vscode-styled-components-0.0.29/node_modules)
Info 24   [20:49:24.864] [ts-styled-plugin] config: {"tags":["styled","css","extend","injectGlobal","createGlobalStyle"],"validate":true,"lint":{"emptyRules":"ignore"},"emmet":{}}
Info 25   [20:49:24.865] Plugin validation succeded
Info 26   [20:49:24.875] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 27   [20:49:24.887] [typescript-deno-plugin] resolveModuleNames
Info 28   [20:49:24.888] [typescript-deno-plugin] baseUrl: file:///Users/private/redacted/path/deno/experiments/
Info 29   [20:49:24.889] [typescript-deno-plugin] module "https://deno.land/std@0.58.0/testing/asserts.ts" -> /Users/private/.deno/deps/https/deno.land/58c9a55bab3b33d848cff0b415ceec25dc97802d8d85a98b16da34e10602f7e9
Info 30   [20:49:24.893] [typescript-deno-plugin] baseUrl: file:///Users/private/redacted/path/deno/experiments/
Info 31   [20:49:24.893] [typescript-deno-plugin] module "http://localhost:8080/local-modules/stats@v0.1.2/mod.ts" can not resolved
Info 32   [20:49:24.927] [typescript-deno-plugin] resolveModuleNames
Info 33   [20:49:24.927] [typescript-deno-plugin] baseUrl: https://deno.land/std@0.58.0/testing/asserts.ts
Info 34   [20:49:24.928] [typescript-deno-plugin] module "../fmt/colors.ts" -> /Users/private/.deno/deps/https/deno.land/ef6ca0ef046cccdbea7c45278e960f814d41bf6a2697847f55e198dad00d9b5e
Info 35   [20:49:24.929] [typescript-deno-plugin] baseUrl: https://deno.land/std@0.58.0/testing/asserts.ts
Info 36   [20:49:24.929] [typescript-deno-plugin] module "./diff.ts" -> /Users/private/.deno/deps/https/deno.land/cd43bebf29b1eaa2587ab47177d86aa21791581d31d992a582011f950722c7ef
Info 37   [20:49:25.721] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 1 structureChanged: true Elapsed: 845ms
Info 38   [20:49:25.721] Project '/dev/null/inferredProject1*' (Inferred)
Info 39   [20:49:25.721] 	Files (45)

Info 40   [20:49:25.722] -----------------------------------------------
Info 41   [20:49:25.723] Project '/dev/null/inferredProject1*' (Inferred)
Info 41   [20:49:25.723] 	Files (45)

Info 41   [20:49:25.723] -----------------------------------------------
Info 41   [20:49:25.723] Open files: 
Info 41   [20:49:25.723] 	FileName: /Users/private/redacted/path/deno/experiments/caching-issue.ts ProjectRootPath: /Users/private/redacted/path/deno
Info 41   [20:49:25.723] 		Projects: /dev/null/inferredProject1*
Info 41   [20:49:26.63] [typescript-deno-plugin] config change to:
{
  "enable": true
}
Info 42   [20:49:26.63] got projects updated in background, updating diagnostics for /Users/private/redacted/path/deno/experiments/caching-issue.ts
Info 43   [20:49:26.63] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 44   [20:49:26.64] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 2 structureChanged: false Elapsed: 1ms
Info 45   [20:49:26.68] [typescript-deno-plugin] getSemanticDiagnostics
Info 46   [20:49:26.88] [typescript-deno-plugin] baseUrl: file:///Users/private/redacted/path/deno/experiments/
Info 47   [20:49:26.268] [typescript-deno-plugin] getSemanticDiagnostics
Info 48   [20:49:27.40] Before ensureProjectForOpenFiles:
Info 49   [20:49:27.40] Project '/dev/null/inferredProject1*' (Inferred)
Info 49   [20:49:27.40] 	Files (45)

Info 49   [20:49:27.40] -----------------------------------------------
Info 49   [20:49:27.40] Open files: 
Info 49   [20:49:27.40] 	FileName: /Users/private/redacted/path/deno/experiments/caching-issue.ts ProjectRootPath: /Users/private/redacted/path/deno
Info 49   [20:49:27.40] 		Projects: /dev/null/inferredProject1*
Info 49   [20:49:27.41] After ensureProjectForOpenFiles:
Info 50   [20:49:27.41] Project '/dev/null/inferredProject1*' (Inferred)
Info 50   [20:49:27.41] 	Files (45)

Info 50   [20:49:27.41] -----------------------------------------------
Info 50   [20:49:27.41] Open files: 
Info 50   [20:49:27.41] 	FileName: /Users/private/redacted/path/deno/experiments/caching-issue.ts ProjectRootPath: /Users/private/redacted/path/deno
Info 50   [20:49:27.41] 		Projects: /dev/null/inferredProject1*
Info 50   [20:49:27.41] got projects updated in background, updating diagnostics for /Users/private/redacted/path/deno/experiments/caching-issue.ts
Info 51   [20:49:27.245] [typescript-deno-plugin] getSemanticDiagnostics
Info 52   [20:49:27.369] FileWatcher:: Triggered with /Users/private/.deno/lib.webworker.d.ts 1:: WatchInfo: /Users/private/.deno/lib.webworker.d.ts 500 undefined Project:  WatchType: Closed Script info
Info 53   [20:49:27.369] Elapsed:: 0ms FileWatcher:: Triggered with /Users/private/.deno/lib.webworker.d.ts 1:: WatchInfo: /Users/private/.deno/lib.webworker.d.ts 500 undefined Project:  WatchType: Closed Script info
Info 54   [20:49:27.369] FileWatcher:: Triggered with /Users/private/.deno/lib.deno.d.ts 1:: WatchInfo: /Users/private/.deno/lib.deno.d.ts 500 undefined Project:  WatchType: Closed Script info
Info 55   [20:49:27.369] Elapsed:: 0ms FileWatcher:: Triggered with /Users/private/.deno/lib.deno.d.ts 1:: WatchInfo: /Users/private/.deno/lib.deno.d.ts 500 undefined Project:  WatchType: Closed Script info
Info 56   [20:49:27.624] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 57   [20:49:27.627] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 3 structureChanged: false Elapsed: 3ms
Info 58   [20:49:29.870] Before ensureProjectForOpenFiles:
Info 59   [20:49:29.870] Project '/dev/null/inferredProject1*' (Inferred)
Info 59   [20:49:29.870] 	Files (45)

Info 59   [20:49:29.870] -----------------------------------------------
Info 59   [20:49:29.870] Open files: 
Info 59   [20:49:29.870] 	FileName: /Users/private/redacted/path/deno/experiments/caching-issue.ts ProjectRootPath: /Users/private/redacted/path/deno
Info 59   [20:49:29.870] 		Projects: /dev/null/inferredProject1*
Info 59   [20:49:29.870] After ensureProjectForOpenFiles:
Info 60   [20:49:29.870] Project '/dev/null/inferredProject1*' (Inferred)
Info 60   [20:49:29.870] 	Files (45)

Info 60   [20:49:29.870] -----------------------------------------------
Info 60   [20:49:29.870] Open files: 
Info 60   [20:49:29.871] 	FileName: /Users/private/redacted/path/deno/experiments/caching-issue.ts ProjectRootPath: /Users/private/redacted/path/deno
Info 60   [20:49:29.871] 		Projects: /dev/null/inferredProject1*
Info 60   [20:49:29.871] got projects updated in background, updating diagnostics for /Users/private/redacted/path/deno/experiments/caching-issue.ts
Info 61   [20:49:30.75] [typescript-deno-plugin] getSemanticDiagnostics

</details>

<details> <summary>Shell outputs (<code>zsh</code>)</summary>

% deno --version         
deno 1.1.1
v8 8.5.104
typescript 3.9.2
% deno test caching-issue.ts
running 1 tests
test Average of [3, 4, 5, 6] is 4.5 ... ok (3ms)

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (3ms)
% deno info http://localhost:8080/local-modules/stats@v0.1.2/mod.ts
local: /Users/private/.deno/deps/http/localhost_PORT8080/47d143b247e69e7d6627d6c9419e17b72d601518baf87391f9bfc62927df7dff
type: TypeScript
compiled: /Users/private/.deno/gen/http/localhost_PORT8080/local-modules/stats@v0.1.2/mod.ts.js
map: /Users/private/.deno/gen/http/localhost_PORT8080/local-modules/stats@v0.1.2/mod.ts.js.map
deps:
http://localhost:8080/local-modules/stats@v0.1.2/mod.ts
  ├── http://localhost:8080/local-modules/stats@v0.1.2/five-numbers.ts
  └── http://localhost:8080/local-modules/stats@v0.1.2/mean.ts
% deno info caching-issue.ts
local: /Users/private/redacted/path/deno/experiments/caching-issue.ts
type: TypeScript
compiled: /Users/private/.deno/gen/file/Users/private/redacted/path/deno/experiments/caching-issue.ts.js
map: /Users/private/.deno/gen/file/Users/private/redacted/path/deno/experiments/caching-issue.ts.js.map
deps:
file:///Users/private/redacted/path/deno/experiments/caching-issue.ts
  ├─┬ https://deno.land/std@0.58.0/testing/asserts.ts
  │ ├── https://deno.land/std@0.58.0/fmt/colors.ts
  │ └── https://deno.land/std@0.58.0/testing/diff.ts
  └─┬ http://localhost:8080/local-modules/stats@v0.1.2/mod.ts
    ├── http://localhost:8080/local-modules/stats@v0.1.2/five-numbers.ts
    └── http://localhost:8080/local-modules/stats@v0.1.2/mean.ts

</details>

See shell outputs for details. Clearly, the module is actually cached, but it appears that typescript-deno-plugin cannot determine the cache location for the module. The relevant diagnostic message appears to be coming from typescript-deno-plugin > src/tsls_host_wrappers/resolve_module_names.ts#L88.

LeonMrBonnie

comment created time in 15 days

issue commenteslint/eslint

Support ESM config (.eslintrc.mjs)

Sure—I just didn't see a place to track ESM configs specifically, so I created this issue.

jsejcksn

comment created time in 15 days

issue commentdenoland/deno

Discussion: CLI cache clean commands

I think it's logical for this functionality to be an additional argument to deno cache, using something like --delete or --invalidate, and it would change the behavior of the command to delete the cached module and its dependencies.

An example:

Caching:

% deno cache --reload http://localhost:8080/local-modules/asdf@v0.1.3/mod.ts 
Download http://localhost:8080/local-modules/asdf@v0.1.3/mod.ts
Download http://localhost:8080/local-modules/asdf@v0.1.3/deps.ts
Download https://deno.land/x/semver@v1.0.0/mod.ts
Download https://deno.land/std@0.58.0/testing/asserts.ts
Download http://localhost:8080/local-modules/process-io@v0.1.2/mod.ts
Download https://deno.land/std@0.58.0/fmt/colors.ts
Download https://deno.land/std@0.58.0/testing/diff.ts
Compile http://localhost:8080/local-modules/asdf@v0.1.3/mod.ts

Deleting:

% deno cache --delete http://localhost:8080/local-modules/asdf@v0.1.3/mod.ts 
Delete http://localhost:8080/local-modules/asdf@v0.1.3/mod.ts
Delete http://localhost:8080/local-modules/asdf@v0.1.3/deps.ts
Delete https://deno.land/x/semver@v1.0.0/mod.ts
Delete https://deno.land/std@0.58.0/testing/asserts.ts
Delete http://localhost:8080/local-modules/process-io@v0.1.2/mod.ts
Delete https://deno.land/std@0.58.0/fmt/colors.ts
Delete https://deno.land/std@0.58.0/testing/diff.ts
kevinkassimo

comment created time in 15 days

issue commenteslint/eslint

Support ESM config (.eslintrc.mjs)

@kaicataldo I looked and I don't think I have enough knowledge about ESLint internals to provide implementation details. Is there an RFC for an RFC 😄?

jsejcksn

comment created time in 15 days

issue commenteslint/eslint

Support ESM config (.eslintrc.mjs)

@kaicataldo Oh, wow—I thought this was already on the roadmap based on all of the discussion around it. I’ll take a look at the RFC process. Does it require having any knowledge of ESLint’s internal API (not user API)?

jsejcksn

comment created time in 16 days

release jsejcksn/test

v0.1.1

released time in 16 days

more