profile
viewpoint
Joyce Er joyceerhl @microsoft Planet Jupyter software engineer

joyceerhl/econ 1

Python demos for economics diagrams

margaretfoster/WTO 1

Code for the topic modeling the WTO project

DukeAPO/dukeapo-client 0

Client side code for Duke APO website.

joyceerhl/A-December-of-Algorithms-2019 0

Welcome to another year of A December of Algorithms. This is a small collection of algorithms to implement this December. Finish it all to get a certificate. :christmas_tree:

joyceerhl/authy-ssh 0

Easy two-factor authentication for ssh servers

joyceerhl/autofocus 0

Chrome website blocker & redirector extension

joyceerhl/dslabs 0

Distributed Systems Labs and Framework

joyceerhl/gather 0

Spit shine for Jupyter notebooks 🧽✨

issue commentmicrosoft/vscode-python

Extension just shows loading when working with numpy and pandas.

Hey @akshitgupta29, thanks for reporting this bug! Could I ask what the python.jediEnabled and python.languageServer settings are set to for your machine? You can find this in VS Code by hitting Command+Shift+P and typing in 'Preferences: Open settings (JSON)'.

akshitgupta29

comment created time in 4 hours

issue commentmicrosoft/vscode-python

text underneath an arrow caused 'math processing error'

Thanks for reporting this. Note for triage: we're tracking related markdown problems in #12519 and #12606.

linjzq

comment created time in a day

Pull request review commentmicrosoft/vscode-python

Put trusted notebooks behind an experiment

 import { createHmac } from 'crypto'; import { inject, injectable } from 'inversify'; import { EventEmitter, Uri } from 'vscode';-import { IConfigurationService } from '../../common/types';+import { EnableTrustedNotebooks } from '../../common/experiments/groups';+import { IConfigurationService, IExperimentService } from '../../common/types'; import { IDigestStorage, ITrustService } from '../types';  @injectable() export class TrustService implements ITrustService {+    public get experimentEnabled() {

Yeah it ended up being the exact same number of files changed (14) but what I had before was definitely harder to follow. Thanks guys 😊

joyceerhl

comment created time in 2 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha e38782db5209f2d3ead68d040f4137110dcda98c

Don't show trust message if not in exp

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-python

Put trusted notebooks behind an experiment

 export class ActiveEditorContextService implements IExtensionSingleActivationSer         // This is temporary, and once we ship native editor this needs to be removed.         setSharedProperty('ds_notebookeditor', e?.type);         this.nativeContext.set(!!e).ignoreErrors();-        this.isNotebookTrusted.set(e?.model?.isTrusted === true).ignoreErrors();+        this.isNotebookTrusted.set(e?.model?.isTrusted !== false).ignoreErrors();

If trusted=undefined we want to show all commands for editing notebooks, so the context variable should be set to true. But I agree with Rich and I'm reverting these changes, will check in new code shortly

joyceerhl

comment created time in 2 days

Pull request review commentmicrosoft/vscode-python

Put trusted notebooks behind an experiment

 import { createHmac } from 'crypto'; import { inject, injectable } from 'inversify'; import { EventEmitter, Uri } from 'vscode';-import { IConfigurationService } from '../../common/types';+import { EnableTrustedNotebooks } from '../../common/experiments/groups';+import { IConfigurationService, IExperimentService } from '../../common/types'; import { IDigestStorage, ITrustService } from '../types';  @injectable() export class TrustService implements ITrustService {+    public get experimentEnabled() {

Yeah agreed, the only reason I didn't do that to start with was that we'd need to send that shouldShowTrustMessage flag over with the cells, which means updating all the redux stuff. I think it ends up being the same number of files that need to be changed.

Also, this experimentEnabled stuff is inside trustService because I didn't want nativeEditor.ts to have to query the exp service to get the value of the shouldShowTrustMessage flag and send it over. My thought was that whether the experiment is enabled is a property of the trustService class, so we should read it off that. But I can see that this exposes more stuff on the public interface, so I'm happy to drop these changes.

joyceerhl

comment created time in 2 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 469d7847251405bcd547db84cde752c205d846f1

Doh

view details

push time in 2 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 91987b5b3b32f83f10f49abba642d537726554ab

Minor refactor

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-python

Put trusted notebooks behind an experiment

 export interface INotebookModel {     readonly onDidEdit: Event<NotebookModelChange>;     readonly isDisposed: boolean;     readonly metadata: nbformat.INotebookMetadata | undefined;-    readonly isTrusted: boolean;+    readonly isTrusted: boolean | undefined; // undefined denotes not in experiment

I'm using isNotebookTrusted === undefined to denote that the user is not in the experiment, in which case:

  1. No trust message should be displayed
  2. All buttons should work
  3. No prompt to trust untrusted notebooks should be displayed
  4. All command palette commands for editing notebooks should appear

For 2., 3., and 4., we effectively want the same behavior as if the notebook was actually trusted, so undefined and true get the same treatment.

joyceerhl

comment created time in 2 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha c7662a00e6b043a800322a2e56b08d3fe317592f

Disable trusted notebooks UI-side if not in exp

view details

push time in 2 days

PR opened microsoft/vscode-docs

Update Python documentation for connecting to remote Jupyter servers

We've since changed the name of the command to connect to a remote server and added a quickpick in the process.

+5 -2

0 comment

2 changed files

pr created time in 2 days

push eventjoyceerhl/vscode-docs

Joyce Er

commit sha 7daf6ee63e222d97d9d316acfa7a661f47dc492f

Resize

view details

push time in 2 days

push eventjoyceerhl/vscode-docs

Joyce Er

commit sha 8122a687bb8c27fb995b31d1132c81448b775ff4

Add connect-to-existing.png

view details

push time in 2 days

push eventjoyceerhl/vscode-docs

Joyce Er

commit sha 30770206df783af1d41083339cf79329d4bfa4a8

Update Jupyter docs

view details

push time in 2 days

push eventjoyceerhl/vscode-docs

Joyce Er

commit sha 2bca8bc264931dd8df254a4a1aed028967a2ef6f

Add connect-to-existing.png

view details

push time in 2 days

create barnchjoyceerhl/vscode-docs

branch : update-jupyter-docs

created branch time in 2 days

fork joyceerhl/vscode-docs

Public documentation for Visual Studio Code

http://code.visualstudio.com/docs

fork in 2 days

issue commentmicrosoft/vscode-python

Remote jupter server stuck at "Starting Jupyter Server"

Hi @sahilseth, thanks for your patience! I was unable to repro locally, so could I also ask about how you set up your Jupyter server? Did you configure SSL/HTTPS the same way the docs describe here?

sahilseth

comment created time in 2 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 21fcb0b21086d302b7f01f012cee3b0c18ac2494

DS: Fixes for trusted notebooks UI (#12685) * Prompt to trust notebook should be error message * Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar * Refactor readOnly markdown props for consistency * Sign up for keydown / up events when props.readOnly changes

view details

Kartik Raj

commit sha 678e016c86079abc557e6a1a6daab20ba05295ed

Log time taken by pytest hook and increase timeout (#12682)

view details

Eric Snow

commit sha 53e6fcebae17c582367013a0575c7b0b7d9e0087

Move remaining "virtual"-env-related code to the py-envs component tree. (#12516) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases. For those most part this PR only moves code between files. In some cases this involves refactoring code so that part of it can be moved.

view details

Rich Chiodo

commit sha 2ac130e64993790bb8500e3227c0808487149213

Fix variable flash when using run by line (#12687) * Add refresh count where appropriate * More refresh cases * Fix run by line test. * Add news entry

view details

Nicolas Kruchten

commit sha ab1eadfb5f846d84969e4ae401f308a337c58b00

Bump plotly.js to 1.54.5 (#12609) * Bump plotly.js to 1.54.5 * update lockfile

view details

Rich Chiodo

commit sha 7c6d40a458ead2083533a784f1501029160dfc5e

Give restarts a chance when running debugger tests (#12696)

view details

Rich Chiodo

commit sha 3a926e25c4499ab85b9604ca3e65aa3186048e09

Refactor ipywidget tests to use real kernel to wait for idle (#12695)

view details

Don Jayamanne

commit sha 05d9e4125bd2e39fea0235792495682ddaa18eaf

Add icon to restart kernel for VSC Notebooks (#12686) For #10496 Existing icon used for restart icon

view details

Peter Law

commit sha 58220ca200dadbdc19f616bfc44b4022f1e54c3b

Update to Jedi 0.17.1 (#12471) * Update to Jedi 0.17.1 This brings completions for Django (via django-stubs, which is now included in Jedi) as well as support for Python 3.9 and various bugfixes (mostly around generic type annotations). * Rename news entry to match GitHub issue

view details

Rich Chiodo

commit sha 744cb928d258a494f9797075fcb6baee0801ce01

Fix export from the interactive window (#12704) * Fix export from the interactive window * Make sure to reset flag at beginning of every test. * Potential fix for linxu

view details

Karthik Nadig

commit sha f8a31a3cea8721eaa4abb5bc9bed317a7b0b701f

Merge back release into master (#12701)

view details

Don Jayamanne

commit sha ea4026367449aca9a0e966514ac4c4801fbfa074

Tests for opening multiple notebooks and toggling (#12703)

view details

Pavel Minaev

commit sha 306885efdae1d316e28e6c69e34a7afd893f247b

Fix #12705: Tests broken due to Prospector / Python 2.7 incompatibility (#12707) Pin prospector to 1.2.0 in test-requirements.txt.

view details

Mikhail Arkhipov

commit sha 7d2d03654595f1935a2ab7586647254ab7c47d3c

Remove language server survey (#12677) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Remove LS surver * More removal * One more * Typo * Remove unused

view details

Joyce Er

commit sha a067a95315aae8fa862dc602529f06c4293e6307

Add link to python.dataScience.alwaysTrustNotebooks setting (#12702)

view details

Rich Chiodo

commit sha 09625065242c9e4865c9b7c84feabfe11ea34145

Special case failure for windows (#12714)

view details

Don Jayamanne

commit sha 08a0538e450dfcd5a9f1e7b95cd3f7fad2afd09a

Add some logging to a flaky test (#12711) For #12690 Added some logging to see whats causing the tests to fail.

view details

Brett Cannon

commit sha 9c338d4a81ff2c5a0bdcb1c84a1a21b107d88e5e

Drop Developer Tools from the bug issue template

view details

push time in 2 days

pull request commentmicrosoft/vscode-python

Put trusted notebooks behind an experiment

Oops. @rchiodo @IanMatthewHuff @DavidKutu I just set up the experiment in Control Tower, and the code we currently have will show the 'Trusted' message for all users who are not enrolled in the experiment. Should we show the user anything related to trusted notebooks at all if the feature is turned off?

joyceerhl

comment created time in 2 days

issue commentmicrosoft/vscode-python

Add Vim feature for Jupyter Notebook

Hi @Matin-Moezi, are you asking for Vim keybindings or something else?

Matin-Moezi

comment created time in 2 days

push eventmicrosoft/vscode-python

Joyce Er

commit sha a067a95315aae8fa862dc602529f06c4293e6307

Add link to python.dataScience.alwaysTrustNotebooks setting (#12702)

view details

push time in 3 days

PR merged microsoft/vscode-python

Reviewers
Add link to python.dataScience.alwaysTrustNotebooks setting skip news

For #12611

Adds a link to the info message which, when clicked, will take the user to the python.dataScience.alwaysTrustNotebooks setting in the Settings GUI.

Also add 'learn more' link which goes to aka.ms/trusted-notebooks. The link target will be updated when the documentation on trusted notebooks becomes available.

settings

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+4 -5

3 comments

4 changed files

joyceerhl

pr closed time in 3 days

push eventjoyceerhl/vscode-python

Karthik Nadig

commit sha f8a31a3cea8721eaa4abb5bc9bed317a7b0b701f

Merge back release into master (#12701)

view details

Don Jayamanne

commit sha ea4026367449aca9a0e966514ac4c4801fbfa074

Tests for opening multiple notebooks and toggling (#12703)

view details

Pavel Minaev

commit sha 306885efdae1d316e28e6c69e34a7afd893f247b

Fix #12705: Tests broken due to Prospector / Python 2.7 incompatibility (#12707) Pin prospector to 1.2.0 in test-requirements.txt.

view details

Mikhail Arkhipov

commit sha 7d2d03654595f1935a2ab7586647254ab7c47d3c

Remove language server survey (#12677) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Remove LS surver * More removal * One more * Typo * Remove unused

view details

Joyce Er

commit sha 3faea20d01267acd93f74a778f8e09b171ab2922

Merge branch 'master' of https://github.com/microsoft/vscode-python into always-trust-notebooks

view details

push time in 3 days

push eventjoyceerhl/vscode-python

Mikhail Arkhipov

commit sha 7d2d03654595f1935a2ab7586647254ab7c47d3c

Remove language server survey (#12677) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Remove LS surver * More removal * One more * Typo * Remove unused

view details

Joyce Er

commit sha 42403458e8bd77bc743e20f5c12d0e58168ddf37

Merge branch 'master' of https://github.com/microsoft/vscode-python into trusted-notebooks-experiment

view details

push time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 4666c7fe313cfcdc291ca0668699d744fba5b54c

Update unit test

view details

push time in 3 days

PR opened microsoft/vscode-python

Reviewers
Put trusted notebooks behind an experiment

For #12146

Note that we still need to enable this experiment in Control Tower before this PR can be merged.

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+20 -7

0 comment

2 changed files

pr created time in 3 days

issue closedmicrosoft/vscode-python

DS: Add trusted notebooks telemetry

Telemetry needed for:

  • [ ] Size of digest store
  • [ ] Number of lock acquisition failures when initializing key
  • [ ] Total time taken to acquire lock

closed time in 3 days

joyceerhl

issue commentmicrosoft/vscode-python

DS: Add trusted notebooks telemetry

Closing as we've decided not to collect telemetry on this.

joyceerhl

comment created time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 21fcb0b21086d302b7f01f012cee3b0c18ac2494

DS: Fixes for trusted notebooks UI (#12685) * Prompt to trust notebook should be error message * Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar * Refactor readOnly markdown props for consistency * Sign up for keydown / up events when props.readOnly changes

view details

Kartik Raj

commit sha 678e016c86079abc557e6a1a6daab20ba05295ed

Log time taken by pytest hook and increase timeout (#12682)

view details

Eric Snow

commit sha 53e6fcebae17c582367013a0575c7b0b7d9e0087

Move remaining "virtual"-env-related code to the py-envs component tree. (#12516) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases. For those most part this PR only moves code between files. In some cases this involves refactoring code so that part of it can be moved.

view details

Rich Chiodo

commit sha 2ac130e64993790bb8500e3227c0808487149213

Fix variable flash when using run by line (#12687) * Add refresh count where appropriate * More refresh cases * Fix run by line test. * Add news entry

view details

Nicolas Kruchten

commit sha ab1eadfb5f846d84969e4ae401f308a337c58b00

Bump plotly.js to 1.54.5 (#12609) * Bump plotly.js to 1.54.5 * update lockfile

view details

Rich Chiodo

commit sha 7c6d40a458ead2083533a784f1501029160dfc5e

Give restarts a chance when running debugger tests (#12696)

view details

Rich Chiodo

commit sha 3a926e25c4499ab85b9604ca3e65aa3186048e09

Refactor ipywidget tests to use real kernel to wait for idle (#12695)

view details

Don Jayamanne

commit sha 05d9e4125bd2e39fea0235792495682ddaa18eaf

Add icon to restart kernel for VSC Notebooks (#12686) For #10496 Existing icon used for restart icon

view details

Peter Law

commit sha 58220ca200dadbdc19f616bfc44b4022f1e54c3b

Update to Jedi 0.17.1 (#12471) * Update to Jedi 0.17.1 This brings completions for Django (via django-stubs, which is now included in Jedi) as well as support for Python 3.9 and various bugfixes (mostly around generic type annotations). * Rename news entry to match GitHub issue

view details

Rich Chiodo

commit sha 744cb928d258a494f9797075fcb6baee0801ce01

Fix export from the interactive window (#12704) * Fix export from the interactive window * Make sure to reset flag at beginning of every test. * Potential fix for linxu

view details

Karthik Nadig

commit sha f8a31a3cea8721eaa4abb5bc9bed317a7b0b701f

Merge back release into master (#12701)

view details

Don Jayamanne

commit sha ea4026367449aca9a0e966514ac4c4801fbfa074

Tests for opening multiple notebooks and toggling (#12703)

view details

Pavel Minaev

commit sha 306885efdae1d316e28e6c69e34a7afd893f247b

Fix #12705: Tests broken due to Prospector / Python 2.7 incompatibility (#12707) Pin prospector to 1.2.0 in test-requirements.txt.

view details

Joyce Er

commit sha fb20aa3427e31e82c79414830bc4681bdc6058dc

Merge branch 'master' of https://github.com/microsoft/vscode-python into trusted-notebooks-experiment

view details

push time in 3 days

create barnchjoyceerhl/vscode-python

branch : trusted-notebooks-experiment

created branch time in 3 days

PullRequestEvent

PR closed microsoft/vscode-python

Reviewers
Add link to python.dataScience.alwaysTrustNotebooks setting skip news

For #12611

Adds a link to the info message which, when clicked, will take the user to the python.dataScience.alwaysTrustNotebooks setting in the Settings GUI.

Also add 'learn more' link which goes to aka.ms/trusted-notebooks. The link target will be updated when the documentation on trusted notebooks becomes available.

settings

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+4 -5

3 comments

4 changed files

joyceerhl

pr closed time in 3 days

push eventjoyceerhl/vscode-python

Don Jayamanne

commit sha 5a4954ad4e10448902c53f782574ca030d8ba5d3

Fix unit test issues when using ts-node on GHA (#12670) For #12669

view details

Don Jayamanne

commit sha ee929acb9492172b035079b1b1cd20a29d7a3104

Fixes to opening VSCode Notebook (#12671) For #10496 Not sure how, but some changes seem to have gone amiss.

view details

Don Jayamanne

commit sha 2cabccc37d5a94824da3c3570a9b07b8e4c59c3d

Download & install renderer extension when opening a VSC Notebook (#12652) Disabled, until the Renderers Extension can be shipped.

view details

Joyce Er

commit sha 14acf9837ffa10082884c8a768d37126d8785f1f

DS: Hide commands for interacting with notebooks when active notebook is untrusted (#12657)

view details

Ian Huff

commit sha 2e4709397db658965ce9a8008b10579e8a6b8ca6

Fix linux tests to report correctly, get rid of stream destroyed messages on raw kernel shutdown (#12643)

view details

Rich Chiodo

commit sha 929195d4ebce66be21c9d3dcfe6c01a5a3d559d1

Add extensibility point to allow custom authorization (#12651) * Working idea? * Working prototype * Abstract out concept of the URI into a handle so can ask for it when appropriate. * Get azure ml compute to work without token in url * Add new extension * Refactor to have other extension supply test compute provider * Get to build * Fix test extension to build with webpack * Extract out user specific entries * Add unit tests * Fixup nbformat changes * Add news entry * Add directions for using to readme * Update styling * Fix failing tests * More functional test failures * Fix sonar error * Use IExtensions instead of vscode directly. * Some refactoring of the example extension * Preliminary api change * Fix up quick picker to go away * Update unit tests * Remove need for unnecessary 'as any' * Can call on second reopen with loading other extensions * Fix error message on reopen without checking extensions * Fix id to be readonly and add test for when no picker call made * Change package json to supply id as well Change uri provider registration to verify uniqueness of ids

view details

Don Jayamanne

commit sha b071d1752a1eaaebc7ec275051805f3fc98f5bb5

Ensure we can open VSCode Notebook with old editor (#12676) If we setup old editor to always open ipynb files, then opening with VSC Notebook doesn't work.

view details

Don Jayamanne

commit sha cb0791a0d22660efb33b21529e20c59d766ed608

Updates to Notebooks based on latest VSC API changes (#12672) For #10496

view details

Eric Snow

commit sha a6db5c036d2e3ad3b51c8b92136eae7ec4704c23

Use composition rather than inheritance for ProtocolParser. (#12680) For #12679 This fixes some inversify-related test failures.

view details

Rich Chiodo

commit sha 8bb3ddf71e61bb33ce06c0dc91250e0fd82e98f6

Add package name to output (#12683)

view details

Don Jayamanne

commit sha 0ac275750dce0d83bdf59770fafb69734a51dd0b

Register notebook with VSC only in Insiders (#12681) For #10496 If the API changes, and user is not using the VSC Notebooks or insiders, then swallow errors. Do not register API against stable version of VSCode. Also fixed a test. Basically we need to ensure VSC works when using this API and not crash if the API changes.

view details

push time in 3 days

push eventjoyceerhl/vscode-python

Don Jayamanne

commit sha 05d9e4125bd2e39fea0235792495682ddaa18eaf

Add icon to restart kernel for VSC Notebooks (#12686) For #10496 Existing icon used for restart icon

view details

Peter Law

commit sha 58220ca200dadbdc19f616bfc44b4022f1e54c3b

Update to Jedi 0.17.1 (#12471) * Update to Jedi 0.17.1 This brings completions for Django (via django-stubs, which is now included in Jedi) as well as support for Python 3.9 and various bugfixes (mostly around generic type annotations). * Rename news entry to match GitHub issue

view details

Rich Chiodo

commit sha 744cb928d258a494f9797075fcb6baee0801ce01

Fix export from the interactive window (#12704) * Fix export from the interactive window * Make sure to reset flag at beginning of every test. * Potential fix for linxu

view details

Joyce Er

commit sha 2fc1ffa12ac9cf15ac8b2d81aace96188db8d998

Merge branch 'master' of https://github.com/microsoft/vscode-python into always-trust-notebooks

view details

push time in 3 days

Pull request review commentmicrosoft/vscode-python

Add link to python.dataScience.alwaysTrustNotebooks setting

                 "python.dataScience.alwaysTrustNotebooks": {                     "type": "boolean",                     "default": false,-                    "description": "Automatically trust all notebooks that are opened. Warning: only enable this setting if you are absolutely certain that you wish to trust all notebooks.",+                    "description": "Enabling this setting will automatically trust any opened notebook and therefore display markdown and render code cells. You will no longer be prompted to trust individual notebooks and harmful code could automatically run.",

Done!

joyceerhl

comment created time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 28d5632e1ad229c6a09d019cb5497ca530f9e0da

Add aka.ms/trusted-notebooks link

view details

push time in 3 days

Pull request review commentmicrosoft/vscode-python

Add link to python.dataScience.alwaysTrustNotebooks setting

                 "python.dataScience.alwaysTrustNotebooks": {                     "type": "boolean",                     "default": false,-                    "description": "Automatically trust all notebooks that are opened. Warning: only enable this setting if you are absolutely certain that you wish to trust all notebooks.",+                    "description": "Enabling this setting will automatically trust any opened notebook and therefore display markdown and render code cells. You will no longer be prompted to trust individual notebooks and harmful code could automatically run.",

Or are you saying we should generate a placeholder link and update the pointer when we have the actual link to redirect to?

joyceerhl

comment created time in 3 days

Pull request review commentmicrosoft/vscode-python

Add link to python.dataScience.alwaysTrustNotebooks setting

                 "python.dataScience.alwaysTrustNotebooks": {                     "type": "boolean",                     "default": false,-                    "description": "Automatically trust all notebooks that are opened. Warning: only enable this setting if you are absolutely certain that you wish to trust all notebooks.",+                    "description": "Enabling this setting will automatically trust any opened notebook and therefore display markdown and render code cells. You will no longer be prompted to trust individual notebooks and harmful code could automatically run.",

We don't have a link to docs yet. That's what this issue is for.

joyceerhl

comment created time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 65ce8784af89ea29b1372645a41f837e82ecb1f9

Feedback from Ian

view details

push time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha c4eaf0c9592c72908906a99623d383795e86b8d7

Feedback from Don

view details

push time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha da331358af1a100d0089cd6a4e074dfe751085fb

Add parens to match spec

view details

push time in 3 days

PR opened microsoft/vscode-python

Reviewers
Add link to python.dataScience.alwaysTrustNotebooks setting skip news

For #12611

Adds a link to the info message which, when clicked, will take the user to the python.dataScience.alwaysTrustNotebooks setting in the Settings GUI.

settings

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+7 -6

0 comment

4 changed files

pr created time in 3 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 21fcb0b21086d302b7f01f012cee3b0c18ac2494

DS: Fixes for trusted notebooks UI (#12685) * Prompt to trust notebook should be error message * Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar * Refactor readOnly markdown props for consistency * Sign up for keydown / up events when props.readOnly changes

view details

Kartik Raj

commit sha 678e016c86079abc557e6a1a6daab20ba05295ed

Log time taken by pytest hook and increase timeout (#12682)

view details

Eric Snow

commit sha 53e6fcebae17c582367013a0575c7b0b7d9e0087

Move remaining "virtual"-env-related code to the py-envs component tree. (#12516) This change is part of the work to isolate a "component" for Python environments. The focus here is on pulling over the remaining significant sections of code belonging to the "discovery" portion of the py-envs component. There are a few pieces here and there but we'll get those pulled over in later phases. For those most part this PR only moves code between files. In some cases this involves refactoring code so that part of it can be moved.

view details

Rich Chiodo

commit sha 2ac130e64993790bb8500e3227c0808487149213

Fix variable flash when using run by line (#12687) * Add refresh count where appropriate * More refresh cases * Fix run by line test. * Add news entry

view details

Nicolas Kruchten

commit sha ab1eadfb5f846d84969e4ae401f308a337c58b00

Bump plotly.js to 1.54.5 (#12609) * Bump plotly.js to 1.54.5 * update lockfile

view details

Rich Chiodo

commit sha 7c6d40a458ead2083533a784f1501029160dfc5e

Give restarts a chance when running debugger tests (#12696)

view details

Rich Chiodo

commit sha 3a926e25c4499ab85b9604ca3e65aa3186048e09

Refactor ipywidget tests to use real kernel to wait for idle (#12695)

view details

Joyce Er

commit sha 6a2558a3d913a43e59f77d9e652a94d852fd74ab

Merge branch 'master' of https://github.com/microsoft/vscode-python into always-trust-notebooks

view details

push time in 3 days

create barnchjoyceerhl/vscode-python

branch : always-trust-notebooks

created branch time in 3 days

IssuesEvent

push eventmicrosoft/vscode-python

Joyce Er

commit sha 21fcb0b21086d302b7f01f012cee3b0c18ac2494

DS: Fixes for trusted notebooks UI (#12685) * Prompt to trust notebook should be error message * Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar * Refactor readOnly markdown props for consistency * Sign up for keydown / up events when props.readOnly changes

view details

push time in 4 days

PR merged microsoft/vscode-python

Reviewers
DS: Fixes for trusted notebooks UI skip news

Fixes #12148

  • Display prompt as error message so it doesn't dismiss on its own
  • Show markdown editor source per Graham's feedback at demo
  • Fix bug where shift+enter wasn't working on code cells after trusting a previously untrusted notebook image

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+17 -17

2 comments

6 changed files

joyceerhl

pr closed time in 4 days

issue closedmicrosoft/vscode-python

DS: Tell user if notebook is untrusted

Feature: Notebook Editor, Interactive Window, Python Editor cells

  • [x] Display 'Trusted' / 'Not Trusted'
  • [x] Prompt user to trust an untrusted notebook when user attempts to execute, save, or save as
  • [x] Hide code cell outputs and markdown cells
  • [x] Eat keyboard shortcuts e.g. shift-enter and commands when notebook is in untrusted state
  • [ ] Fix bug where keyboard commands are not re-enabled after trusting an untrusted notebook
  • [ ] Show markdown source in monaco editor if notebook is untrusted

closed time in 4 days

joyceerhl

issue openedmicrosoft/vscode-python

Add link to docs on trusted notebooks

The prompt we show to customers when an untrusted notebook is opened should include a link to documentation explaining what trusted notebooks are, what they mitigate, and the implications of enabling the alwaysTrustNotebooks setting.

created time in 4 days

Pull request review commentmicrosoft/vscode-python

DS: Fixes for trusted notebooks UI

 export class Editor extends React.Component<IEditorProps> {                 }             }         }+        if (prevProps.readOnly === true && this.props.readOnly === false && this.editorRef) {

Previously, we only signed up for keyup and keydown events from Monaco when the editor mounted and if the editor wasn't readonly. This meant that after toggling a notebook from untrusted to trusted, the code cells weren't signed up for keydown events, so shift+enter didn't work. This bit of code here is necessary to ensure that after the value of readOnly changes, the editor becomes responsive to shift+enter and other keypresses

joyceerhl

comment created time in 4 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 22ea58886ca7011804a5ba4959f98da075ac02eb

Sign up for keydown / up events when props.readOnly changes

view details

push time in 4 days

PR opened microsoft/vscode-python

DS: Fixes for trusted notebooks UI

Closes #12148

  • Display prompt as error message so it doesn't dismiss on its own
  • Show markdown editor source per Graham's feedback at demo image

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+13 -17

0 comment

5 changed files

pr created time in 4 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 1ba8f12ea2dae2bb7007cef8f51e4732d69c2e45

Fix apparent bug with markdown editor styling This was causing the markdown cells to jut out 2 pixels to the right of the middle content bar

view details

Joyce Er

commit sha 6d83767824bcdf66dc194ac5a8c47cc06144048c

Refactor readOnly markdown props for consistency

view details

push time in 4 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha b9d8cf02f88730362916c79d1bb9e6d6b8f4d622

Prompt to trust notebook should be error message

view details

push time in 4 days

create barnchjoyceerhl/vscode-python

branch : fixes

created branch time in 4 days

issue closedmicrosoft/vscode-python

Infinite reload button when enabling custom editor

For some reason this code is not working in the vsix:

        // Double check the package json has the necessary entries for contributing a custom editor
        if (this.useCustomEditorApi && !appEnvironment.packageJson.contributes?.customEditors) {
            this.rewritePackageJson().catch((e) => traceError(`Error rewriting package json: `, e));
        }

Maybe the packagejson is null when in the vsix.

closed time in 4 days

rchiodo

issue closedmicrosoft/vscode-python

Cell content out of sync

Bug: Notebook Editor, Interactive Window, Editor cells

Sometimes code in cell can't be executed because of some syntax errors which is not actually in code.

Demonstration: https://youtu.be/UZb9CEAfr6k

Steps to cause the bug to occur

It happens sometimes, I do not know how to reproduce it.

I use dockerized jupyter instance run with: docker run -p 8888:8888 jupyter/scipy-notebook

Actual behavior

https://youtu.be/UZb9CEAfr6k

Expected behavior

...

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Remote
  • Extension version: 2020.4.76186
  • VS Code version: 1.45.0
  • Setting python.jediEnabled: true
  • Python and/or Anaconda version: 3.7.6
  • OS: Mac:
  • Virtual environment: docker

Developer Tools Console Output

https://pastebin.com/XX0jKSpx

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

closed time in 4 days

atomAltera

push eventmicrosoft/vscode-python

Joyce Er

commit sha 14acf9837ffa10082884c8a768d37126d8785f1f

DS: Hide commands for interacting with notebooks when active notebook is untrusted (#12657)

view details

push time in 4 days

PR merged microsoft/vscode-python

Reviewers
DS: Hide commands for interacting with notebooks when active notebook is untrusted skip news

For #12148

First half of the GIF illustrates commands being hidden for an untrusted notebook. Second half of the GIF illustrates the same commands becoming available when a trusted notebook is opened. commands

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+37 -12

1 comment

5 changed files

joyceerhl

pr closed time in 4 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 24dc238cdd242f1ecb18cbe5cc04e9ae796e7850

Feedback from Ian and Rich

view details

push time in 4 days

Pull request review commentmicrosoft/vscode-python

DS: Hide commands for interacting with notebooks when active notebook is untrusted

 export class TrustService implements ITrustService {         }         // Compute digest and see if notebook is trusted         const digest = await this.computeDigest(notebookContents);-        return this.digestStorage.containsDigest(uri, digest);+        const isTrusted = await this.digestStorage.containsDigest(uri, digest);+        this._onDidSetNotebookTrust.fire(isTrusted);

Yeah I had it fire on isNotebookTrusted since nativeEditorStorage queries the service when loading a notebook. But updating the context key when the active editor changes should be sufficient for that. Thanks :)

joyceerhl

comment created time in 4 days

Pull request review commentmicrosoft/vscode-python

DS: Hide commands for interacting with notebooks when active notebook is untrusted

 export class TrustService implements ITrustService {         }         // Compute digest and see if notebook is trusted         const digest = await this.computeDigest(notebookContents);-        return this.digestStorage.containsDigest(uri, digest);+        const isTrusted = await this.digestStorage.containsDigest(uri, digest);+        this._onDidSetNotebookTrust.fire(isTrusted);

So something like this?

    private onDidSetNotebookTrust() {
        if (this.notebookEditorProvider.activeEditor?.model !== undefined) {
            this.isNotebookTrusted.set(this.notebookEditorProvider.activeEditor?.model?.isTrusted).ignoreErrors();
        }
    }
joyceerhl

comment created time in 4 days

Pull request review commentmicrosoft/vscode-python

DS: Hide commands for interacting with notebooks when active notebook is untrusted

 export class ActiveEditorContextService implements IExtensionSingleActivationSer         this.udpateNativeNotebookCellContext();         this.updateMergedContexts();     }+    private onDidSetNotebookTrust(e: boolean) {

Yep you're totally right, thanks for bringing this up, and this could happen with the code I've checked in for showing an info message to the user if an untrusted notebook is opened. Particularly on extension activation when dirty notebooks from the previous session are automatically reopened, if an untrusted notebook is opened and then a trusted notebook is opened on top of it, the info message will show up for the untrusted notebook, and if the user clicks 'Trust' on the info message, it will trust the untrusted notebook that is not currently active. Will fix this!

joyceerhl

comment created time in 4 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha cfd5eaa64de1bdefa69afe9f9070e4464835caef

🤦‍♀️

view details

push time in 5 days

issue commentmicrosoft/vscode-python

Infinite reload button when enabling custom editor

Validated.

rchiodo

comment created time in 5 days

issue commentmicrosoft/vscode-python

Cell content out of sync

Validated.

atomAltera

comment created time in 5 days

push eventjoyceerhl/vscode-python

Mikhail Arkhipov

commit sha e0b80243727c598583a073c981c17958328711eb

Language server name (#12653)

view details

push time in 5 days

Pull request review commentmicrosoft/vscode-python

DS: Hide commands for interacting with notebooks when active notebook is untrusted

 export class TrustService implements ITrustService {         }         // Compute digest and see if notebook is trusted         const digest = await this.computeDigest(notebookContents);-        return this.digestStorage.containsDigest(uri, digest);+        const isTrusted = await this.digestStorage.containsDigest(uri, digest);+        this._onDidSetNotebookTrust.fire(isTrusted);

Not sure what you mean by context key watcher. Do you mean activeEditorContext.ts?

joyceerhl

comment created time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 4af71b5e604893ed7d4fcfe62fe716e83c1e8282

Make hygiene happy

view details

push time in 5 days

PR opened microsoft/vscode-python

Reviewers
DS: Hide commands for interacting with notebooks when active notebook is untrusted skip news

For #12148

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+37 -15

0 comment

5 changed files

pr created time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 53e06c09170a7d72cddf8557dcb6414d37809f30

Bad merge

view details

push time in 5 days

push eventjoyceerhl/vscode-python

Mikhail Arkhipov

commit sha e0b80243727c598583a073c981c17958328711eb

Language server name (#12653)

view details

Joyce Er

commit sha 66bd58c7cf26dafd179a33e8f72a0804c7c020ef

Merge branch 'master' of https://github.com/microsoft/vscode-python into hide-commands

view details

push time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 1fed562edc6a1b32082cac12defa1369cd455768

Linter fixes

view details

push time in 5 days

create barnchjoyceerhl/vscode-python

branch : hide-commands

created branch time in 5 days

push eventjoyceerhl/vscode-python

Ian Huff

commit sha 46e01e58e86fac1216492eac2c30c035a65b9ca3

pull type from type file (#12605) Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha 782690d042291e61470bdb8e7f357d1f7070f58a

Fix IW kernel selection style (#12608) * Merge KernelSelection and TrustMessage * Rename KernelSelection to JupyterInfo

view details

Ian Huff

commit sha 08b8e5c8a2cb55fe77ccf9b0975aa123f618949c

Cache full ZMQ check promise, not just the result of the import (#12610) * save ZMQ support check in a promise to prevent race condition * remove old comment Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha bbca2fd6f8c892b5bdf5f7046480944a580fb8aa

DS: Allow user to override checking notebook trust (#12612)

view details

Kartik Raj

commit sha d214e0114304efff6628adedae9ef2197d396c59

Skip more flaky tests (#12635) * Skip more flaky tests * Add issue link comment

view details

Don Jayamanne

commit sha a42b02662e585b6defcca02f8718e92e641b10c0

Simplify INotebookModel when using VSCode Notebooks (#12604) * Two INotebookModels, one for existing Notebook and one for VS Code Notebooks * VS Code Notebooks will not need a lot of the API in INotebookModel class (such as updates to cells, undo/redo, etc). * VSC Notebooks will use INotebookModel as a mere mirror (readonly view) of the actual VSC NotebookDocument. This PR just refactors stuff (moving stuff to accommodate the two new INotebook classes).

view details

Kartik Raj

commit sha 9891723c1e471c04f404fa4bb48e3a36de0fc827

Changed public API for execution to return an object and provide a callback which is called when interpreter setting changes (#12597) * Modified the API * Fix gulp errors * Code reviews

view details

Don Jayamanne

commit sha 538d9130ff2e25904306c84a3ac5782f0a4da0cd

Model is in charge of updates to model & cells (#12640) For #10496 Part 2 of #12604 Move code related to updates to INotebookModel into the corresponding INotebookModel class.

view details

Luciana Abud

commit sha 096c601ecbfd39816cff06896cdd8a22aec8896d

Remove ** from activation rule in package.json for workspaces with mspythonconfig.json (#12636) * Removing ** from activation rule on presence of mspythoncofing.json file * Add news entry

view details

David Kutugata

commit sha 03e8ad5a9f64df4a8dff5a5a6e983340a6550561

More start page telemetry (#12647) * add telemetry for the start page * add news file

view details

Don Jayamanne

commit sha 2960baff6d992e957830238307903c3d6d29d631

Fix flaky Daemon and MimeType tracker tests (#12646) For #12567, #12637 Use a better package for a fake clock. Added more comments in one of the damon pool tests.

view details

Joyce Er

commit sha 2a1c244fb1797b4082ea8fd1120b2356fc727c31

DS: Open untrusted notebooks as readonly (#12579)

view details

push time in 5 days

push eventmicrosoft/vscode-python

Joyce Er

commit sha 2a1c244fb1797b4082ea8fd1120b2356fc727c31

DS: Open untrusted notebooks as readonly (#12579)

view details

push time in 5 days

PR merged microsoft/vscode-python

Reviewers
DS: Open untrusted notebooks as readonly skip news

For #12148

readonly

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+80 -24

3 comments

12 changed files

joyceerhl

pr closed time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha bbca2fd6f8c892b5bdf5f7046480944a580fb8aa

DS: Allow user to override checking notebook trust (#12612)

view details

Kartik Raj

commit sha d214e0114304efff6628adedae9ef2197d396c59

Skip more flaky tests (#12635) * Skip more flaky tests * Add issue link comment

view details

Don Jayamanne

commit sha a42b02662e585b6defcca02f8718e92e641b10c0

Simplify INotebookModel when using VSCode Notebooks (#12604) * Two INotebookModels, one for existing Notebook and one for VS Code Notebooks * VS Code Notebooks will not need a lot of the API in INotebookModel class (such as updates to cells, undo/redo, etc). * VSC Notebooks will use INotebookModel as a mere mirror (readonly view) of the actual VSC NotebookDocument. This PR just refactors stuff (moving stuff to accommodate the two new INotebook classes).

view details

Kartik Raj

commit sha 9891723c1e471c04f404fa4bb48e3a36de0fc827

Changed public API for execution to return an object and provide a callback which is called when interpreter setting changes (#12597) * Modified the API * Fix gulp errors * Code reviews

view details

Don Jayamanne

commit sha 538d9130ff2e25904306c84a3ac5782f0a4da0cd

Model is in charge of updates to model & cells (#12640) For #10496 Part 2 of #12604 Move code related to updates to INotebookModel into the corresponding INotebookModel class.

view details

Luciana Abud

commit sha 096c601ecbfd39816cff06896cdd8a22aec8896d

Remove ** from activation rule in package.json for workspaces with mspythonconfig.json (#12636) * Removing ** from activation rule on presence of mspythoncofing.json file * Add news entry

view details

Joyce Er

commit sha d22aae952446645763c7ead05060474395f675e3

Merge branch 'master' of https://github.com/microsoft/vscode-python into joyceerhl/readonly

view details

David Kutugata

commit sha 03e8ad5a9f64df4a8dff5a5a6e983340a6550561

More start page telemetry (#12647) * add telemetry for the start page * add news file

view details

Joyce Er

commit sha 345adaa64e86efb3d5fdb6aad663903f798d238a

Merge branch 'master' of https://github.com/microsoft/vscode-python into joyceerhl/readonly

view details

push time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 72233b151fb7079f7c34a31a93cb5dcda2b999d2

Stub isNotebookTrusted in tests

view details

push time in 5 days

issue closedmicrosoft/vscode-python

Make Notebook rendering a per Notebook toggle rather than global.

Feature: Notebook Editor, Interactive Window, Python Editor cells

<!----------------------------------------------------------------------------------------------- PLEASE READ If this issue doesn't relate to Jupyter Notebooks, Python Interactive Window features or other "cell"-based features of the Python extension, please use the main Python feature request template instead of this one. Thank you! ------------------------------------------------------------------------------------------------->

Description

I sometime want to see the raw JSON of a notebook file rather than the rendered notebook. For example I recently updated the kernelspec in a number of our template notebooks to match our default environment which required me to edit the JSON. Whilst I can toggle notebook rendering off on a global level via settings it would be nice if I could toggle this on a per notebook basis via the command palette.

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

closed time in 5 days

petebryan

issue commentmicrosoft/vscode-python

Make Notebook rendering a per Notebook toggle rather than global.

Thanks for your suggestion! This is a duplicate of #12576. This will likely be addressed once VS Code adds native support for editing notebooks. Please follow microsoft/vscode#91987 for progress updates 😊

petebryan

comment created time in 5 days

Pull request review commentmicrosoft/vscode-python

DS: Open untrusted notebooks as readonly

 export class NativeEditorStorage implements INotebookStorage {         @inject(IMemento) @named(GLOBAL_MEMENTO) private globalStorage: Memento,         @inject(IMemento) @named(WORKSPACE_MEMENTO) private localStorage: Memento,         @inject(ITrustService) private trustService: ITrustService,-        @inject(UseVSCodeNotebookEditorApi) private readonly useNativeEditorApi: boolean-    ) {}+        @inject(UseVSCodeNotebookEditorApi) private readonly useNativeEditorApi: boolean,+        @inject(ICommandManager) private commandManager: ICommandManager+    ) {+        this.isNotebookTrustedContextKey = new ContextKey(EditorContexts.IsNotebookTrusted, this.commandManager);

Yep, Rich made this same recommendation on Friday. I've reverted the ContextKey changes and will be hide notebook-editing commands to a different PR.

joyceerhl

comment created time in 5 days

push eventmicrosoft/vscode-python

Joyce Er

commit sha bbca2fd6f8c892b5bdf5f7046480944a580fb8aa

DS: Allow user to override checking notebook trust (#12612)

view details

push time in 5 days

PR merged microsoft/vscode-python

Reviewers
DS: Allow user to override checking notebook trust

For #12611

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+31 -3

1 comment

13 changed files

joyceerhl

pr closed time in 5 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha b2a9b7c1b38ed5e46729b9d68431a0328c8a3db1

Show markdown editor even if untrusted

view details

Ian Huff

commit sha 46e01e58e86fac1216492eac2c30c035a65b9ca3

pull type from type file (#12605) Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha 782690d042291e61470bdb8e7f357d1f7070f58a

Fix IW kernel selection style (#12608) * Merge KernelSelection and TrustMessage * Rename KernelSelection to JupyterInfo

view details

Ian Huff

commit sha 08b8e5c8a2cb55fe77ccf9b0975aa123f618949c

Cache full ZMQ check promise, not just the result of the import (#12610) * save ZMQ support check in a promise to prevent race condition * remove old comment Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha 30af5e95590cf860eaf2a8dcc623a1f64c258b2c

Merge branch 'master' of https://github.com/microsoft/vscode-python into joyceerhl/readonly

view details

push time in 5 days

push eventmicrosoft/vscode-python

Joyce Er

commit sha 782690d042291e61470bdb8e7f357d1f7070f58a

Fix IW kernel selection style (#12608) * Merge KernelSelection and TrustMessage * Rename KernelSelection to JupyterInfo

view details

push time in 5 days

PR merged microsoft/vscode-python

Reviewers
Fix IW kernel selection style skip news

Broke this in #12466 when I moved margin-left: auto into a wrapper div around KernelSelection and TrustMessage for toolbar.tsx and forgot to update interactivePanel.tsx. Thanks @DavidKutu for catching this!

After fix: image

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+54 -78

1 comment

6 changed files

joyceerhl

pr closed time in 5 days

issue commentmicrosoft/vscode-python

Attempting To Run Jupyter Notebook In Virtual Environment Produces "Command Failed" Error

bash: python: command not found

It looks like Python has not been added to your path, so bash is unable to locate it and run our Python files. Does running a Jupyter notebook work outside your venv? If not, could you try adding Python to your path and let me know if that helps?

Salazar-99

comment created time in 6 days

issue closedmicrosoft/vscode-python

No indent in jupyter notebook

Issue Type: <b>Bug</b>

When called for a function the auto indentation does not work instead i had to opt for pressing tab every time for writing a program

Extension version: 2020.6.90262 VS Code version: Code - Insiders 1.47.0-insider (9bf6af04dcb5c2e531cedca83cd188939ca1b0db, 2020-06-26T18:55:07.038Z) OS version: Windows_NT x64 10.0.19042

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz (8 x 1190)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 7.78GB (3.03GB free)
Process Argv
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 6 days

VENOMNBB

issue commentmicrosoft/vscode-python

No indent in jupyter notebook

Thanks for reporting this! We have merged a fix for this (#12428), and while that fix will become available in the next release, you can get it now by installing the Insiders build of VS Code and opting into daily or weekly updates from the Python extension. We are already tracking this bug in #12389, so I'm closing this as a duplicate of that issue. Hope this helps and sorry for the trouble!

VENOMNBB

comment created time in 6 days

issue closedmicrosoft/vscode-python

Auto-indent not working in Jupyter Notebooks

Bug: Notebook Editor, Interactive Window, Editor cells

<!----------------------------------------------------------------------------------------------- PLEASE READ If this issue doesn't relate to Jupyter Notebooks, Python Interactive Window features or other notebook or "cell"-based features of the Python extension, please use the main Python bug template instead of this one. Thank you! ------------------------------------------------------------------------------------------------->

Steps to cause the bug to occur

  1. Write a function\class definition e.g. def func(a, b):
  2. Press Enter

Actual behavior (cursor position)

image

Expected behavior (cursor position)

image

NOTE: This issue wasn't present till the most recent update <!----------------------------------------------------------------------------------------------- Animated GIFs can be effective means to describe a bug. Consider using a tool like https://github.com/phw/peek or https://www.screentogif.com/ to create one. ------------------------------------------------------------------------------------------------->

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local
  • Extension version: 2020.06.90262
  • VS Code version: 1.46
  • Setting python.jediEnabled: false
  • Setting python.languageServer: None
  • Python and/or Anaconda version: 4.8.3 (python 3.7.7)
  • OS: Windows 10
  • Virtual environment: conda

Developer Tools Console Output

<!----------------------------------------------------------------------------------------------- Copy/paste the output in the "Console" tab in the "Developer Tools" panel (Help > Toggle Developer Tools). For better details, run the "Enable source map support for extension debugging" command in VS Code at least once beforehand. ------------------------------------------------------------------------------------------------->

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

closed time in 7 days

sujaybokil

issue commentmicrosoft/vscode-python

Auto-indent not working in Jupyter Notebooks

Thanks for reporting this, everyone! We have merged a fix for this (#12428), and while that fix will become available in the next release, you can get it now by installing the Insiders build of VS Code and opting into daily or weekly updates from the Python extension. We are already tracking this bug in #12389, so I'm closing this as a duplicate of that issue. Hope this helps and sorry for the trouble!

sujaybokil

comment created time in 7 days

Pull request review commentmicrosoft/vscode-python

DS: Allow user to override checking notebook trust

                     "description": "When debugging, debug just my code.",                     "scope": "resource"                 },+                "python.dataScience.alwaysTrustNotebooks": {+                    "type": "boolean",+                    "default": false,+                    "description": "Automatically trust all notebooks that are opened. Warning: only enable this setting if you are absolutely certain that you wish to trust all notebooks.",

Oh did not know there was a machine scope, that's exactly what we should do. Fixed!

joyceerhl

comment created time in 8 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 561af4afb702b95cb89aae1850da334118f93a70

Feedback from Don

view details

push time in 8 days

Pull request review commentmicrosoft/vscode-python

DS: Allow user to override checking notebook trust

 import { createHmac } from 'crypto'; import { inject, injectable } from 'inversify';+import { IConfigurationService } from '../../common/types'; import { IDigestStorage, ITrustService } from '../types';  @injectable() export class TrustService implements ITrustService {+    private alwaysTrustNotebooks: boolean;     constructor(         // @inject(IExperimentsManager) private readonly experiment: IExperimentsManager,-        @inject(IDigestStorage) private readonly digestStorage: IDigestStorage-    ) {}+        @inject(IDigestStorage) private readonly digestStorage: IDigestStorage,+        @inject(IConfigurationService) private configService: IConfigurationService+    ) {+        this.alwaysTrustNotebooks = this.configService.getSettings().datascience.alwaysTrustNotebooks;

Good call, thank you!

joyceerhl

comment created time in 8 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha e483b0968e3a5014e9420efb949275286bc23c08

Feedback from Don

view details

push time in 8 days

push eventjoyceerhl/vscode-python

Ian Huff

commit sha 46e01e58e86fac1216492eac2c30c035a65b9ca3

pull type from type file (#12605) Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha 52ffc6c2ccb03b8e681679805aaf227e6735e05f

Merge branch 'master' of https://github.com/microsoft/vscode-python into trust-override-setting

view details

Joyce Er

commit sha 63b1ca63f04264c984fa043d3fe6e7213d2fa8fc

Fix tests

view details

push time in 8 days

push eventjoyceerhl/vscode-python

Joyce Er

commit sha 7447ffefdc21b8352c8639474a5e635ccdca3c0e

Add description and news entry

view details

push time in 8 days

PR opened microsoft/vscode-python

Reviewers
DS: Allow user to override checking notebook trust

For #12611

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+22 -4

0 comment

3 changed files

pr created time in 8 days

more