profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/joseph-flinn/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

BW-Tony/HelmTest 0

testing helm

joseph-flinn/argocd-example-apps 0

Example Apps to Demonstrate Argo CD

joseph-flinn/AzureSignTool 0

SignTool Library and Azure Key Vault Support

joseph-flinn/browser 0

The browser extension vault (Chrome, Firefox, Opera, Edge, Safari, & more).

joseph-flinn/cli 0

The command line vault (Windows, macOS, & Linux).

joseph-flinn/coursework 0

Online coursework

joseph-flinn/data-projects 0

Random Data Analytics projects

joseph-flinn/desktop 0

The desktop vault (Windows, macOS, & Linux).

joseph-flinn/devops-training 0

One-on-one general devops training

joseph-flinn/directory-connector 0

A tool for syncing a directory (AD, LDAP, Azure, G Suite, Okta) to an organization.

pull request commentbitwarden/server

Implement code coverage tool

The .sln looks good, just a good ol' standard solution file, nothing wonky going on 👍🏻 . After all these years you think Microsoft would make .sln file format XML to match .*proj files.... but nope, not a chance.

Hey now, they said not a chance at 64bit Visual Studio and look where we are now. Just gotta be patient for another 12 years.

justindbaur

comment created time in 6 hours

pull request commentbitwarden/server

Implement code coverage tool

I'm no expert at reading sln files, it's always just handled for me. bitwarden/dept-engineering, cscharf -- anything to weigh in on that front?

The .sln looks good, just a good ol' standard solution file, nothing wonky going on 👍🏻 . After all these years you think Microsoft would make .sln file format XML to match .*proj files.... but nope, not a chance.

justindbaur

comment created time in 6 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"

So I wanted to do this so it would have feature-parity with it's PowerShell counterpart. That one takes advantage of $PSScriptRoot so no matter your working directory when you run it find the solution bases on where it is and not the caller. But if you are down to remove this line (that I totally didn't just steal from Stack Overflow and I completely understand😏) then I am down to.

justindbaur

comment created time in 7 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"

This script root isn't necessary. The only place you're using it is dotnet test, which is perfectly happy taking a relative path to the .sln file.


justindbaur

comment created time in 8 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"++echo "CONFIGURATION = ${CONFIGURATION}"+echo "OUTPUT = ${OUTPUT}"+echo "REPORT_TYPE = ${REPORT_TYPE}"+echo "SCRIPT_ROOT = ${SCRIPT_ROOT}"

justindbaur

comment created time in 8 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"++echo "CONFIGURATION = ${CONFIGURATION}"+echo "OUTPUT = ${OUTPUT}"+echo "REPORT_TYPE = ${REPORT_TYPE}"+echo "SCRIPT_ROOT = ${SCRIPT_ROOT}"++echo "Collectiong Code Coverage"+# Install tools+dotnet tool restore+# Print Environment+dotnet --version++if [[ -d $OUTPUT ]]+then+    echo "Cleaning output location"+    rm -rf $OUTPUT+fi++dotnet test "$SCRIPT_ROOT/bitwarden.tests.sln" /p:CoverletOutputFormatter="cobertura" --collect:"XPlat Code Coverage" --results-directory:"$OUTPUT" -c $CONFIGURATION++dotnet tool run reportgenerator -reports:$OUTPUT/**/*.cobertura.xml -targetdir:$OUTPUT -reporttype:"$REPORT_TYPE"

Please add trailing newline

justindbaur

comment created time in 8 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"++echo "CONFIGURATION = ${CONFIGURATION}"+echo "OUTPUT = ${OUTPUT}"+echo "REPORT_TYPE = ${REPORT_TYPE}"+echo "SCRIPT_ROOT = ${SCRIPT_ROOT}"++echo "Collectiong Code Coverage"+# Install tools+dotnet tool restore+# Print Environment+dotnet --version++if [[ -d $OUTPUT ]]+then

Please move to previous line:

if [[ -d $OUTPUT]]; then
justindbaur

comment created time in 8 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]

Move do to the same line as while:

while [[ $# -gt 0 ]]; do
justindbaur

comment created time in a day

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"++case $key in+    -c|--configuration)++    CONFIGURATION="$2"+    shift+    shift+    ;;+    -o|--output)+    OUTPUT="$2"+    shift+    shift+    ;;+    -rt|--reportType)+    REPORT_TYPE="$2"+    shift+    shift+    ;;+    *)+    shift+    ;;+esac+done++SCRIPT_ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"++echo "CONFIGURATION = ${CONFIGURATION}"+echo "OUTPUT = ${OUTPUT}"+echo "REPORT_TYPE = ${REPORT_TYPE}"+echo "SCRIPT_ROOT = ${SCRIPT_ROOT}"++echo "Collectiong Code Coverage"+# Install tools+dotnet tool restore+# Print Environment+dotnet --version++if [[ -d $OUTPUT ]]+then+    echo "Cleaning output location"+    rm -rf $OUTPUT+fi++dotnet test "$SCRIPT_ROOT/bitwarden.tests.sln" /p:CoverletOutputFormatter="cobertura" --collect:"XPlat Code Coverage" --results-directory:"$OUTPUT" -c $CONFIGURATION
dotnet test "./bitwarden.tests.sln" /p:CoverletOutputFormatter="cobertura" --collect:"XPlat Code Coverage" --results-directory:"$OUTPUT" -c $CONFIGURATION
justindbaur

comment created time in 8 hours

Pull request review commentbitwarden/server

Implement code coverage tool

+#!/bin/bash++# Set defaults if no values supplied+CONFIGURATION="Release"+OUTPUT="CoverageOutput"+REPORT_TYPE="lcov"+++# Read in arguments+while [[ $# -gt 0  ]]+do+key="$1"

Indent from key...esac, inclusive

justindbaur

comment created time in a day

push eventbitwarden/server

Chad Scharf

commit sha e0f81efe265543c3bf0a3c23fb6e33595f0e0ba4

coookie path

view details

push time in a day

push eventbitwarden/server

Chad Scharf

commit sha 583545191b9fd8f18e2b5213ab07da06764e4417

let's try this instead

view details

push time in a day

push eventbitwarden/server

Chad Scharf

commit sha ab5995c970bfe1734eeb20fe7d9ab4393678f62b

hard-code /sso path for SSO too

view details

push time in a day

push eventbitwarden/server

Chad Scharf

commit sha c79819cda3ba14d13ea0ed9dffee43aab50a94f1

Always include `/portal` path

view details

push time in a day

push eventbitwarden/server

Chad Scharf

commit sha 43089ec74fae7af832a02ff77f6ba56ca4653998

More logging on startup of content and web root paths

view details

push time in a day

push eventbitwarden/server

Chad Scharf

commit sha 519addd14c1ac4754526e0cd81bcb66f80e63d16

More debuggin'

view details

push time in a day

PR opened bitwarden/server

Redefine cipher "share" to "move to organization"

Overview

The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true.

When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization". Additionally, email communications should not imply users can share with organizations. Instead, users can share items with each other using or through organizations.

Files Changed

  • CiphersController: Update error response to use move instead of share
  • MailTempltates: use using to clarify that users are not maintaining ownership of moved items.
+5 -5

0 comment

3 changed files

pr created time in 2 days

create barnchbitwarden/server

branch : change-share-term

created branch time in 2 days

PR closed bitwarden/server

Default usernames

Community forum thread: https://community.bitwarden.com/t/default-usernames/19071

jslib PR: https://github.com/bitwarden/jslib/pull/286 web PR: https://github.com/bitwarden/web/pull/854

+286 -6

2 comments

8 changed files

michalchecinski

pr closed time in 2 days

pull request commentbitwarden/server

Default usernames

Closing this PR as the new approach discussed in the forum thread does not require any changes to server.

michalchecinski

comment created time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 488c2c01fe50e1ba23c70266d49546610c42e49e

Fix payload purpose

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 8a42beccdcb061b871cdb222f2d2da4ebb011be9

Logging for license service

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 65b2d1c29721f15a0e643fc6565fc05df5cc7464

append other purpose

view details

Chad Scharf

commit sha 309f238b3e04bdf063b92722ef9afbd50ad00512

Merge branch 'qa-rc' of https://github.com/bitwarden/server into qa-rc

view details

push time in 2 days

push eventbitwarden/server

addison

commit sha 048d52ef9d8929629092a585c5c08dc826c8c74b

added mysql migrations

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 65731b7519bf87a1b31ac11ccb7bfb2a27e62204

add actual user security stamp to logs

view details

push time in 2 days

push eventbitwarden/server

addison

commit sha 39755c2f52e64aed6f2b0eb8c6a86992ca36d491

generated postgres migrations

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha f8895dd536f4f61c317407851beeab96c29f6e7c

added numbering

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 66823ed7b762ded2a71297fce503a72a4b1fb46b

Let's try this again

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha 349038f7fa2a6e7ad0e15c086ad7e6043329d80a

Let's try this!

view details

push time in 2 days

push eventbitwarden/server

Chad Scharf

commit sha cbd0259e89b17f72889f67e9d1a81814cf2c390c

remove decode token call

view details

push time in 2 days