profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/joscollin/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ceph/ceph-csi 598

CSI driver for Ceph

anilv4/cmy 0

DUMP your thoughts and CLEAR your mind using "cmy". Pronounced as, c-mee . . .

joscollin/ceph 0

Ceph is a distributed object, block, and file storage platform

joscollin/ceph-build 0

Helper scripts for building the official Ceph packages

joscollin/ceph-deploy 0

Deploy Ceph with minimal infrastructure, using just SSH access

joscollin/DesignPatterns 0

My collection of Creational, Structural and Behavioral Patterns

joscollin/dmclock 0

Code that implements the dmclock distributed quality of service algorithm. See "mClock: Handling Throughput Variability for Hypervisor IO Scheduling" by Gulati, Merchant, and Varman.

joscollin/downstream-cherry-picker 0

cherry-pick GitHub PRs that correspond to Red Hat Bugzilla bugs

joscollin/rentreceipt 0

Rent Receipt for Employees in India

joscollin/rocksdb 0

Embedded key-value store for fast storage

PullRequestReviewEvent

pull request commentceph/ceph

pacific: qa: test_ls_H_prints_human_readable_file_size failure

/ceph/teuthology-archive/yuriw-2021-07-08_23:33:26-fs-wip-yuri2-testing-2021-07-08-1142-pacific-distro-basic-smithi/6260232/teuthology.log

Created a tracker for this error too: https://tracker.ceph.com/issues/51704. Please amend the commit.

batrick

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentceph/ceph

pacific: qa: test_ls_H_prints_human_readable_file_size failure

jenkins test make check

batrick

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventjoscollin/ceph

Jos Collin

commit sha de4dfe76e2b9f2bccda1dfe40ec9c6a3e3d89b51

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 17 days

push eventjoscollin/ceph

Jos Collin

commit sha 9d51f5eee45d7a28c99fd02a4ebf9f8e457d3b27

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 17 days

Pull request review commentceph/ceph

mgr/stats: be resilient to offline MDS rank0

 class Module(MgrModule):     def __init__(self, *args, **kwargs):         super(Module, self).__init__(*args, **kwargs)         self.fs_perf_stats = FSPerfStats(self)+        self.prev_rank0_name = None      def notify(self, notify_type, notify_id):         if notify_type == "command":             self.fs_perf_stats.notify(notify_id)+        elif notify_type == "fs_map":

Another issue is self.get('fs_map') should be called via module then.

joscollin

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentceph/ceph

mgr/stats: be resilient to offline MDS rank0

 class Module(MgrModule):     def __init__(self, *args, **kwargs):         super(Module, self).__init__(*args, **kwargs)         self.fs_perf_stats = FSPerfStats(self)+        self.prev_rank0_name = None      def notify(self, notify_type, notify_id):         if notify_type == "command":             self.fs_perf_stats.notify(notify_id)+        elif notify_type == "fs_map":

Because FSPerfStats::notify doesn't seem to be a callback. Having the notify_id empty for fs_map notify_type, I could still move this block of code to a function say FSPerfStats::handle_fsmap_change(). Any better suggestions?

joscollin

comment created time in 17 days

PullRequestReviewEvent

push eventjoscollin/ceph

Jos Collin

commit sha 1ec68370ecc3f6c8cd413479c28cdad38732c43d

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 18 days

push eventjoscollin/ceph

Ronen Friedman

commit sha 4ef143a9a04d10e9a4be34b706032837b68716e0

osd: issue a warning if the scrubber blocks for too long on an object A bug elsewhere in the code might cause the scrubber to be indefinitely blocked waiting for the target range to be available. And a blocked scrubber ties up OSDs scrub resources, potentially blocking other PGs from being scrubbed. For the scrubber - the only remedy is to issue a warning. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

view details

Ronen Friedman

commit sha 2ed6095535e69ac63e4e54b1dbeb2e24c3b4c2b4

osd: asok support for "blocked scrub warning" debug A "scrubdebug" command to artificially block/free object ranges for scrubbing. This asok op-code will be extended in the future to support more debug options. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

view details

Ronen Friedman

commit sha efc5ba14e2db84b06345d4ca78973f21ec466330

osd: send the "blocked scrub" message to the cluster log Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

view details

Jeegn Chen

commit sha 3cafe5774a5a453d58a3a6bed1f02d3200c4bb1d

rgw: avoid infinite loop when deleting a bucket When deleting a bucket with an incomplete multipart upload that has about 2000 parts uploaded, we noticed an infinite loop, which stopped s3cmd from deleting the bucket forever. Per check, when the bucket index was sharded (for example 128 shards), the original logic in RGWRados::cls_bucket_list_unordered() did not calculate the bucket shard ID correctly when the index key of a data part was taken as the marker. The issue is not necessarily reproduced each time. It will depend on the key of the object. To reproduce it in 128-shard bucket, we use 334 as the key for the incomplete multipart upload, which will be located in Shard 127 (known by experiment). In this setup, the original logic will usually come out a shard ID smaller than 127 (since 127 is the largest one) from the marker and thus a circle is constructed, which results in an infinite loop. PS: Some times the bucket ID calculation may incorrectly going forward instead of backward. Thus, the check logic may skip some shards, which may have regular keys. In such scenarios, some non-empty buckets may be deleted by accident. Fixes: http://tracker.ceph.com/issues/49206 Signed-off-by: Jeegn Chen <jeegnchen@tencent.com>

view details

Pritha Srivastava

commit sha f1407efb903bbb264a68ed962086194feaed0b44

rgw/sts: fixes getsessiontoken authenticated with LDAP/Keystone, when object is uploaded via chunked encoding. fixes: https://tracker.ceph.com/issues/49797 Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

view details

Varsha Rao

commit sha 63f5fa2e5e8946be4b4123c588bb133f1b18412b

src/vstart: deploy rgw service with cephadm Signed-off-by: Varsha Rao <varao@redhat.com>

view details

Varsha Rao

commit sha 0d0cd4c6b0e8bbeaa71f54c831d67ef880e58016

src/vstart: create rgw user with system flag As dashboard requires the system flag to be enabled. Signed-off-by: Varsha Rao <varao@redhat.com>

view details

Simon Gao

commit sha b45563d814b4b4eddf87bdc3c659267dc26e5cbf

mds : add timeout to the command, dump cache, to prevent it from running too long and affecting the service the default value for timeout is half the heartbeat time, mds_beacon_interval Signed-off-by: Simon Gao <simon29rock@gmail.com>

view details

Rishabh Dave

commit sha bfdfc7d652b0988d3a4eab9ac54a9ba210a6e9da

client: remove unused include from barrier.cc Signed-off-by: Rishabh Dave <ridave@redhat.com>

view details

Duncan Bellamy

commit sha 8797807f5355eb40f2a5d72eadb485bef94e8c23

pybind/mgr/CMakeLists.txt: exclude files not used at runtime Exclude node_modules so it is not installed with make install Exclude cypress files and dashboard .(dot) files also Fixes: https://tracker.ceph.com/issues/50827 Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>

view details

Simon Gao

commit sha 430d93222a1fd320512859449f3a2644a5694546

qa : add a test for the cmd, dump cache Signed-off-by: Simon Gao <simon29rock@gmail.com>

view details

Jeegn Chen

commit sha 7647823bd42ce8228c3622a91e87680ee22df710

rgw: write meta of a MP part to a correct pool When uploading a multipart part to a non-default storage class, original logic writes the object data to the correct pool for its storage class. But when completing the upload, there's another write op (with a bunch of setxattrs) to the head object targeting the standard pool (because non-multipart uploads write their head objects to the default pool). As a result of this setxattrs op, a redundant zero-sized object is created in a wrong pool. Multipart complete, multipart abort and GC would never try to it clean up. The fix is to make RGWRados::Object::Write::_do_write_meta() learn the difference between multipart and non-multipart head objects and pick the correct placement rule for RGWRados::get_obj_head_ref(). Fixes: http://tracker.ceph.com/issues/49128 Signed-off-by: Jeegn Chen <jeegnchen@tencent.com>

view details

Venky Shankar

commit sha 2e9b840198041adee50b948ade89b9e7c837b6ce

pybind/cephfs: interface to fetch file system id Signed-off-by: Venky Shankar <vshankar@redhat.com>

view details

Venky Shankar

commit sha c8a5342e2b342dbfdad3ffe4f36b49d9ed192c47

pybind/mirroring: disallow adding a active peer back to source Signed-off-by: Venky Shankar <vshankar@redhat.com>

view details

Venky Shankar

commit sha 074f55006edb605b35e3c9c20cdc70c4fa8d96e9

test: add test to verify adding an active peer back to source Fixes: http://tracker.ceph.com/issues/50447 Signed-off-by: Venky Shankar <vshankar@redhat.com>

view details

Patrick Seidensal

commit sha a709abf8bf5a6b25c21db100e87af3a6c2cf382d

mgr/dashboard: deprecated variable usage in Grafana dashboards Fixes: https://tracker.ceph.com/issues/50059 Signed-off-by: Patrick Seidensal <pseidensal@suse.com>

view details

Sage Weil

commit sha e47d816bf78dcb920e2d53140919f361ffd53167

rgw/rgw_rados: include realm_id in daemon metadata Signed-off-by: Sage Weil <sage@newdream.net>

view details

Xiubo Li

commit sha 562ba7877360226bbf09b33a9b0c5664c8d81c12

mds: to print the unknow type value Initialize the metric type when constructing the XXXPayload class, and add one common base Payload class to simplify the code. Fixes: https://tracker.ceph.com/issues/51113 Signed-off-by: Xiubo Li <xiubli@redhat.com>

view details

Yuval Lifshitz

commit sha 5b31052be66ff8debee1e233406e6490f8206fde

rgw/amqp: fix valgrind issue of uninitialized info.ssl Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

view details

Avan Thakkar

commit sha de1e0ccd7a6c065ab2df7d3a108f4132f3942c41

mgr/dashboard: crushmap tree doesn't display crush type other than root Fixes: https://tracker.ceph.com/issues/50971 Signed-off-by: Avan Thakkar <athakkar@redhat.com>

view details

push time in 18 days

PullRequestReviewEvent

Pull request review commentceph/ceph

mgr/stats: be resilient to offline MDS rank0

 class Module(MgrModule):     def __init__(self, *args, **kwargs):         super(Module, self).__init__(*args, **kwargs)         self.fs_perf_stats = FSPerfStats(self)+        try:+            self.prev_mds_name_rank0 = self.get_rank0_mds_name(self.get('fs_map'))

If rank0 becomes unavailable at some point, get_rank0_mds_name returns None and skips the query reregistering. Will push the latest code today for you to check.

joscollin

comment created time in 18 days

push eventjoscollin/ceph

Jos Collin

commit sha a98cf0939a521c95ca5b7946f55b28ff37055789

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 19 days

push eventjoscollin/ceph

Jos Collin

commit sha bd7414eb3b6946c33689329856afc21ea1364a26

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 19 days

push eventjoscollin/ceph

Jos Collin

commit sha bb1df12ccbc3400f9408b46e400c299170b05185

fixed review comments Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 20 days

push eventjoscollin/ceph

Jos Collin

commit sha 8676b2a56769085d0cc17d59f51115276a8f4551

fixed review comments

view details

push time in 20 days

Pull request review commentceph/ceph

mgr/stats: be resilient to offline MDS rank0

 def notify(self, cmdtag):             self.log.debug("client_metadata={0}, to_purge={1}".format(                 self.client_metadata['metadata'], self.client_metadata['to_purge'])) +    def re_register_queries(self):+        #re-register user queries

Fixed the review comments. Please check.

joscollin

comment created time in 23 days

PullRequestReviewEvent

push eventjoscollin/ceph

Jos Collin

commit sha 103e6e6b9e24c7e1c47a37607409b6d6ca6fd2fe

mgr/stats: be resilient to offline MDS rank0 Fixes: https://tracker.ceph.com/issues/50033 Signed-off-by: Jos Collin <jcollin@redhat.com>

view details

push time in 23 days

PR opened ceph/ceph

cephfs-top: fix Refresh interval

<!-- Thank you for opening a pull request! Here are some tips on creating a well formatted contribution.

Please give your pull request a title like "[component]: [short description]"

This is the format for commit messages:

""" [component]: [short description]

[A longer multiline description]

Fixes: [ticket URL on tracker.ceph.com, create one if necessary] Signed-off-by: [Your Name] <[your email]> """

The Signed-off-by line is important, and it is your certification that your contributions satisfy the Developers Certificate or Origin. For more detail, see SubmittingPatches.rst.

The component is the short name of a major daemon or subsystem, something like "mon", "osd", "mds", "rbd, "rgw", etc. For ceph-mgr modules, give the component as "mgr/<module name>" rather than a path into pybind.

For more examples, simply use "git log" and look at some historical commits.

This was just a quick overview. More information for contributors is available here: https://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst

-->

Checklist

  • [ ] References tracker ticket
  • [ ] Updates documentation if necessary
  • [ ] Includes tests for new functionality or reproducer for bug

<details> <summary>Show available Jenkins commands</summary>

  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

</details>

+4 -4

0 comment

2 changed files

pr created time in 25 days

create barnchjoscollin/ceph

branch : wip-doc-cephfs-top-misc-fixes

created branch time in 25 days

PR opened ceph/ceph

mgr/stats: be resilient to offline MDS rank0

Fixes: https://tracker.ceph.com/issues/50033

<!-- Thank you for opening a pull request! Here are some tips on creating a well formatted contribution.

Please give your pull request a title like "[component]: [short description]"

This is the format for commit messages:

""" [component]: [short description]

[A longer multiline description]

Fixes: [ticket URL on tracker.ceph.com, create one if necessary] Signed-off-by: [Your Name] <[your email]> """

The Signed-off-by line is important, and it is your certification that your contributions satisfy the Developers Certificate or Origin. For more detail, see SubmittingPatches.rst.

The component is the short name of a major daemon or subsystem, something like "mon", "osd", "mds", "rbd, "rgw", etc. For ceph-mgr modules, give the component as "mgr/<module name>" rather than a path into pybind.

For more examples, simply use "git log" and look at some historical commits.

This was just a quick overview. More information for contributors is available here: https://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst

-->

Checklist

  • [ ] References tracker ticket
  • [ ] Updates documentation if necessary
  • [ ] Includes tests for new functionality or reproducer for bug

<details> <summary>Show available Jenkins commands</summary>

  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

</details>

+23 -0

0 comment

2 changed files

pr created time in a month

create barnchjoscollin/ceph

branch : wip-B50033-rank0-stale-perf-stats

created branch time in a month

CommitCommentEvent