profile
viewpoint

jorgenfb/analytics-globe 7

Visualize your google analytics data on an interactive globe. Written using Web Components and WebGL with the help of the awesome liberaries Polymer and Three.js

jorgenfb/docker-ursim 6

Universal robots simulator as a docker container

jorgenfb/angular-form-model 5

Angularjs directive for defining a model on a form. Directive will set the ng-model property on all inputs with the name-attribute.

jorgenfb/jorgenfb.github.io 1

My online home

jorgenfb/angular-google-maps 0

AngularJS directives for the Google Maps Javascript API

jorgenfb/backbone 0

Give your JS App some Backbone with Models, Views, Collections, and Events

jorgenfb/bootstrap 0

HTML, CSS, and JS toolkit from Twitter

issue openedUniversalRobots/Universal_Robots_ROS_Driver

Support for booting UR-computer after ROS-driver

I would like the driver to support waiting for the UR computer to boot up.

The driver will try to connect, but exit if unable to do so within a reasonable time. Since the ur_robot_driver is marked as required in the launch file the entire ROS system will be brought down with it.

I would like the driver to support waiting indefinitely for the robot to become available. This would allow us to instruct our users to turn on the robot if its not available. Todays solution just kills everything, including our user interface support systems.

I would like your opinion on this. Is this something you find useful and will consider supporting?

created time in 8 hours

push eventnLinkAS/Universal_Robots_ROS_Driver

Felix Exner

commit sha 3d4763aac6931463a1d88007a9b80e218168ec8e

Disable trajectory test for now (#264) The trajectory test seems to not work anymore since a couple of weeks. Running those locally (also with a ursim running inside a docker container) works perfectly fine, but running it inside the github action not. As this is blocking many merges currently, I suggest to disable this temporarily while opening an issue to fix it.

view details

Felix Exner

commit sha 0584835539041b9b314f1ebcab87d35af7c3bd7a

Added explanation of scaled trajectory controller (#250) * Added explanation of scaled trajectory controller * Apply suggestions from code review Thanks @gavanderhoorn for this in-depth review! Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> * Added another suggestion I missed Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> * Clarified where the speed_scaling value comes from. * Format ros_control correctly * Rewrote bullet point about non-moving robot * Replace time frame with control cycle Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>

view details

Felix Exner

commit sha 406a3308d8d45906d83acd7fa4263cd6476223f3

Updated externalcontrol to v1.0.3 (#245) * Updated externalcontrol to v1.0.3 * Updated externalcontrol to v1.0.4

view details

Jørn Sandvik Nilsson

commit sha b14b5d40f67adc9fcafb917826948a2622549805

add topic for robot status program running

view details

push time in 12 days

push eventnLinkAS/Universal_Robots_ROS_Driver

Felix Exner

commit sha 3d4763aac6931463a1d88007a9b80e218168ec8e

Disable trajectory test for now (#264) The trajectory test seems to not work anymore since a couple of weeks. Running those locally (also with a ursim running inside a docker container) works perfectly fine, but running it inside the github action not. As this is blocking many merges currently, I suggest to disable this temporarily while opening an issue to fix it.

view details

Felix Exner

commit sha 0584835539041b9b314f1ebcab87d35af7c3bd7a

Added explanation of scaled trajectory controller (#250) * Added explanation of scaled trajectory controller * Apply suggestions from code review Thanks @gavanderhoorn for this in-depth review! Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> * Added another suggestion I missed Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl> * Clarified where the speed_scaling value comes from. * Format ros_control correctly * Rewrote bullet point about non-moving robot * Replace time frame with control cycle Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>

view details

Felix Exner

commit sha 406a3308d8d45906d83acd7fa4263cd6476223f3

Updated externalcontrol to v1.0.3 (#245) * Updated externalcontrol to v1.0.3 * Updated externalcontrol to v1.0.4

view details

push time in 12 days

push eventnLinkAS/Universal_Robots_ROS_Driver

Felix Exner

commit sha 3b689213d2cd8e09d5bae46cf76685a3cf1ae61f

Added case label statement

view details

Felix Exner

commit sha 5621c358e6113bf96889a41c80b13ba3594dafff

Initialize member variables It can happen that the action gets triggered before the mode callback got triggered While this changes stops the helper from crashing when this happens, it might not be the best idea to do so as the question remains, what we should do if we haven't even received a current status from the robot. With the changes introduced inside this commit, the helper would trigger the respective state changes, which might lead to wrong requests if we aren't entirely sure what to do. One solution would be to reject goals as long as no status was received, but that would break such scenarios where you want to activate the robot automatically during startup. Another idea would be to delay actually starting the action server until we received both, robot mode and safety mode. But I am not entirely sure whether this will scale well.

view details

Felix Exner

commit sha 4d7016f64268e0166160744a1e6aa63de7f4bf97

Add initialization routine for first messages

view details

Felix Exner

commit sha 5786cee81a0f571ebf7fde11413279bfba09a26f

Added additional waitForService for dashboard service

view details

Felix Exner

commit sha 7089657b254b5aec2ff8637c26b9cd46113de5c6

Added FAQ section about why calibration is extracted separately

view details

Felix Exner

commit sha 9cdfa34cf4841ca18931c5c10e6f7fd2f627b9f3

reworded calibration extraction explanation

view details

Felix Exner

commit sha fe4c68d4857bf027e6f873e96660181db824587f

Added troubleshooting entry about combined_robot_hw

view details

Felix Exner

commit sha 84523890100068dc0606cd37fe49b7060e1149f8

Added a short section about remote-control and headless mode

view details

Felix Exner

commit sha bf26ea5eca4f6c586da029abc91774481c470d28

replaced ros references that shouldn't be there (#178) We want to keep the pure driver part ros-independent

view details

Felix Exner

commit sha 1590881fd82a5cb2f3e664c749aae665062e6c88

Clarified the requirement for using my fork of the universal_robot repo (#181)

view details

Felix Exner

commit sha 43fd5d0e191ab7fcf679775ae88092ad7795f0c9

Merge pull request #179 from UniversalRobots/improve_docs Improve documentation

view details

Felix Exner

commit sha 4fae7361f26de3f0fb205ca295bb8d0a9c75ea36

Merge pull request #177 from UniversalRobots/fix_robot_state_helper Make robot_state helper wait for a first status from robot before advertising the set_mode action.

view details

G.A. vd. Hoorn

commit sha 8d8e909554323d1d54ca2b141782a7e0184569b7

readme: minor clarifications in the "auto-update calibration data" faq entry (#184)

view details

Felix Exner

commit sha 8e2ee6390d50201ab2c5d004e9c97e280e34cfff

Retry reading RTDE interface when unexpected messages appear during s… (#186) * Retry reading RTDE interface when unexpected messages appear during startup At startup we make a couple of requests to the RTDE interface. If the interface publishes messages by itself, a simple read() from the interface might grab another message than the answer. This change checks whether an answer to our requests was received and reports a warning otherwise while retrying.

view details

Felix Exner

commit sha 15f69ce6bfccb236c612dd4f87d96fcc9747406c

Add actual documentation link into calibration checker output The output was generated when we didn't have the final repository available. However, updating the output got lost over time...

view details

Felix Exner

commit sha 285f249ac7413fa822df3c69ad8733d2983256c1

Test: Increase required clang-format version to 9

view details

Felix Exner

commit sha dcde4573713348afdd9aa1f4c34c7a5dbd9a3eb2

Draft for checking URLs

view details

Felix Exner

commit sha 638e92f543755b25b9cea0dfa86d21e05a5766ae

Merge pull request #167 from UniversalRobots/clang-format-update Added case label statement to clang-format stylesheet

view details

G.A. vd. Hoorn

commit sha fe344be45335f6e17b91a6dd78d3514f85ada108

robot_driver: use pass_all_args to reduce verbosity. (#197) The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.

view details

Felix Exner

commit sha 289655e24ca640c8aa1a6acbfaf6f5fc593dbe2c

Merge pull request #193 from UniversalRobots/add_documentation_link Add actual documentation link into calibration checker output

view details

push time in 23 days

push eventnLinkAS/Universal_Robots_ROS_Driver

Felix Exner

commit sha 3b689213d2cd8e09d5bae46cf76685a3cf1ae61f

Added case label statement

view details

Felix Exner

commit sha 5621c358e6113bf96889a41c80b13ba3594dafff

Initialize member variables It can happen that the action gets triggered before the mode callback got triggered While this changes stops the helper from crashing when this happens, it might not be the best idea to do so as the question remains, what we should do if we haven't even received a current status from the robot. With the changes introduced inside this commit, the helper would trigger the respective state changes, which might lead to wrong requests if we aren't entirely sure what to do. One solution would be to reject goals as long as no status was received, but that would break such scenarios where you want to activate the robot automatically during startup. Another idea would be to delay actually starting the action server until we received both, robot mode and safety mode. But I am not entirely sure whether this will scale well.

view details

Felix Exner

commit sha 4d7016f64268e0166160744a1e6aa63de7f4bf97

Add initialization routine for first messages

view details

Felix Exner

commit sha 5786cee81a0f571ebf7fde11413279bfba09a26f

Added additional waitForService for dashboard service

view details

Felix Exner

commit sha 7089657b254b5aec2ff8637c26b9cd46113de5c6

Added FAQ section about why calibration is extracted separately

view details

Felix Exner

commit sha 9cdfa34cf4841ca18931c5c10e6f7fd2f627b9f3

reworded calibration extraction explanation

view details

Felix Exner

commit sha fe4c68d4857bf027e6f873e96660181db824587f

Added troubleshooting entry about combined_robot_hw

view details

Felix Exner

commit sha 84523890100068dc0606cd37fe49b7060e1149f8

Added a short section about remote-control and headless mode

view details

Felix Exner

commit sha bf26ea5eca4f6c586da029abc91774481c470d28

replaced ros references that shouldn't be there (#178) We want to keep the pure driver part ros-independent

view details

Felix Exner

commit sha 1590881fd82a5cb2f3e664c749aae665062e6c88

Clarified the requirement for using my fork of the universal_robot repo (#181)

view details

Felix Exner

commit sha 43fd5d0e191ab7fcf679775ae88092ad7795f0c9

Merge pull request #179 from UniversalRobots/improve_docs Improve documentation

view details

Felix Exner

commit sha 4fae7361f26de3f0fb205ca295bb8d0a9c75ea36

Merge pull request #177 from UniversalRobots/fix_robot_state_helper Make robot_state helper wait for a first status from robot before advertising the set_mode action.

view details

G.A. vd. Hoorn

commit sha 8d8e909554323d1d54ca2b141782a7e0184569b7

readme: minor clarifications in the "auto-update calibration data" faq entry (#184)

view details

Felix Exner

commit sha 8e2ee6390d50201ab2c5d004e9c97e280e34cfff

Retry reading RTDE interface when unexpected messages appear during s… (#186) * Retry reading RTDE interface when unexpected messages appear during startup At startup we make a couple of requests to the RTDE interface. If the interface publishes messages by itself, a simple read() from the interface might grab another message than the answer. This change checks whether an answer to our requests was received and reports a warning otherwise while retrying.

view details

Felix Exner

commit sha 15f69ce6bfccb236c612dd4f87d96fcc9747406c

Add actual documentation link into calibration checker output The output was generated when we didn't have the final repository available. However, updating the output got lost over time...

view details

Felix Exner

commit sha 285f249ac7413fa822df3c69ad8733d2983256c1

Test: Increase required clang-format version to 9

view details

Felix Exner

commit sha dcde4573713348afdd9aa1f4c34c7a5dbd9a3eb2

Draft for checking URLs

view details

Felix Exner

commit sha 638e92f543755b25b9cea0dfa86d21e05a5766ae

Merge pull request #167 from UniversalRobots/clang-format-update Added case label statement to clang-format stylesheet

view details

G.A. vd. Hoorn

commit sha fe344be45335f6e17b91a6dd78d3514f85ada108

robot_driver: use pass_all_args to reduce verbosity. (#197) The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.

view details

Felix Exner

commit sha 289655e24ca640c8aa1a6acbfaf6f5fc593dbe2c

Merge pull request #193 from UniversalRobots/add_documentation_link Add actual documentation link into calibration checker output

view details

push time in 23 days

issue openedros/genpy

regression on kinetic due to #127

The changes in #127 (https://github.com/ros/genpy/blob/kinetic-devel/src/genpy/generator.py#L761) adds the line:

codecs.lookup_error("rosmsg").msg_type = self._type

to deserialization. On kinetic this line throws LookupException with the message: unknown error handler name 'rosmsg'

The issue can be reproduced by using any package that has regenerated its messages since #127. The package where I discovered it was with rosbridge_suite.

This is how to reproduce it:

# Boot up the minimal ros image in docker
docker run -it -p 11311:11311 ros:kinetic-ros-core

# Update apt and install ros-kinetic-rosbridge-suite
apt update
apt install ros-kinetic-rosbridge-suite

# Start roscore
roscore

On the host computer run docker ps to get the container id.

Log into the container and start rosapi (from rosbridge_suite):

docker exec -it <CONTAINER ID> bash

# Inside the container
source /opt/ros/kinetic/setup.bash
rosrun rosapi rosapi_node

Log into the container and call service:

docker exec -it <CONTAINER ID> bash

# Inside the container
source /opt/ros/kinetic/setup.bash
rosservice call /rosapi/get_param what ever

The service call will fail when trying to deserialize the message.

This can probably also be done on your local machine, but I choose docker to make sure we have the same environment.

created time in a month

pull request commentnLinkAS/o3d3xx-ros

feat(diagnostic): add diagnostic to node

Jepp, hvis publiseringshastigheten går under 1hz så defineres det som for dårlig.

jorgenfb

comment created time in a month

PR opened nLinkAS/o3d3xx-ros

feat(diagnostic): add diagnostic to node

Adds frequency monitoring to depth cloud publisher. By default it will publish updates every 5s. If the frequency of the point cloud is below 1 hz it is defined as an ERROR.

Related to JC-342

+22 -2

0 comment

4 changed files

pr created time in a month

create barnchnLinkAS/o3d3xx-ros

branch : feat/diagnostics

created branch time in a month

startedformatc1702/WireViz

started time in 3 months

more