profile
viewpoint
Tobias Preuss johnjohndoe Berlin, Germany http://weblog.avp-ptr.de I 💟 open source.

johnjohndoe/Android-Developers-Samples 68

Tracking changes for Android Developers Samples

johnjohndoe/Android-Design-Downloads 11

Tracking changes for Android Design Downloads

johnjohndoe/AFreeChart 7

AFreeChart is a free charting library for Android based on JFreeChart 1.0.13. Forked from

jancborchardt/focalendar 6

Calendar which allows you to focus, very in progress

dirkschumacher/blume_messnet_api 4

Blume Messnet API

johnjohndoe/aboutapp 4

OI About - A library which provides a AboutActivity for your Android application.

johnjohndoe/android-gradle-plugin-dsl 4

Tracking the documentation for the domain specific language used within the Android plugin

johnjohndoe/AChartEngine 1

AChartEngine is a charting library for Android applications. Forked from

johnjohndoe/ActionBarSherlock-Plugin-Maps 1

Plugin for ActionBarSherlock which provides a base activity that can be used for adding a MapView to your action bar-enabled layouts.

startedmike-north/jsonapi-typescript

started time in 29 minutes

startedquicktype/quicktype

started time in an hour

startedjohnjohndoe/engelsystem

started time in 3 hours

push eventprati0100/git-gui

Pratyush Yadav

commit sha ce83ab2bd3751eadb0eb6f12d1e9d984613a4cc2

git-gui: Only touch GITGUI_MSG when needed In 4e55d19 (git-gui: Cleanup end-of-line whitespace in commit messages., 2007-01-25), the logic to decide if GITGUI_MSG should be saved or deleted was updated to not require the commit message buffer to be modified. This fixes a situation where if the user quits and restarts git-gui multiple times the commit message buffer was lost. Unfortunately, the fix was not quite correct. The check for whether the commit message buffer has been modified is useless. If the commit is _not_ amend, then the check is never performed. If the commit is amend, then saving the message does not matter anyway. Amend state is destroyed on exit and the next time git-gui is opened it starts from scratch, but with the older message retained in the buffer. If amend is selected, the current message is over-written by the amend commit's message. The correct fix would be to not touch GITGUI_MSG at all if the commit message buffer is not modified. This way, the file is not deleted even on multiple restarts. It has the added benefit of not writing the file unnecessarily on every exit. Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

view details

Martin Schön

commit sha 627c87f84c157885d587125cf0c73591a0e3ee7a

git-gui: use commit message template Use the file described by commit.template (if set) to show the commit message template, just like other GUIs. Signed-off-by: Martin Schön <Martin.Schoen@loewensteinmedical.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

view details

push time in 3 hours

push eventprati0100/git-gui

Pratyush Yadav

commit sha 47ce18ef10a75b09decab0acdcc3c955a95c7a4b

git-gui: Only touch GITGUI_MSG when needed In 4e55d19 (git-gui: Cleanup end-of-line whitespace in commit messages., 2007-01-25), the logic to decide if GITGUI_MSG should be saved or deleted was updated to not require the commit message buffer to be modified. This fixes a situation where if the user quits and restarts git-gui multiple times the commit message buffer was lost. Unfortunately, the fix was not quite correct. The check for whether the commit message buffer has been modified is useless. If the commit is _not_ amend, then the check is never performed. If the commit is amend, then saving the message does not matter anyway. Amend state is destroyed on exit and the next time git-gui is opened it starts from scratch, but with the older message retained in the buffer. If amend is selected, the current message is over-written by the amend commit's message. The correct fix would be to not touch GITGUI_MSG at all if the commit message buffer is not modified. This way, the file is not deleted even on multiple restarts. It has the added benefit of not writing the file unnecessarily on every exit. Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

view details

push time in 5 hours

issue commentprati0100/git-gui

Support git commit --template A.K.A. 'commit.template' setting

I pushed out my edits on the branch ms/commit-template here. Can you test them and see if everything still works fine?

ciarancourtney

comment created time in 5 hours

push eventprati0100/git-gui

Martin Schön

commit sha 0373f94c823b5bbab24160e585f70c8bf8ca6ac6

git-gui: use commit message template Use the file described by commit.template (if set) to show the commit message template, just like other GUIs. Signed-off-by: Martin Schön <Martin.Schoen@loewensteinmedical.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

view details

Pratyush Yadav

commit sha c515aab11ba090bb36f15baf3e748c6813207062

git-gui: Only touch GITGUI_MSG when needed In 4e55d19 (git-gui: Cleanup end-of-line whitespace in commit messages., 2007-01-25), the logic to decide if GITGUI_MSG should be saved or deleted was updated to not require the commit message buffer to be modified. This fixes a situation where if the user quits and restarts git-gui multiple times the commit message buffer was lost. Unfortunately, the fix was not quite correct. The check for whether the commit message buffer has been modified is useless. If the commit is _not_ amend, then the check is never performed. If the commit is amend, then saving the message does not matter anyway. Amend state is destroyed on exit and the next time git-gui is opened it starts from scratch, but with the older message retained in the buffer. If amend is selected, the current message is over-written by the amend commit's message. The correct fix would be to not touch GITGUI_MSG at all if the commit message buffer is not modified. This way, the file is not deleted even on multiple restarts. It has the added benefit of not writing the file unnecessarily on every exit.

view details

push time in 5 hours

startedantfu/ni

started time in 6 hours

fork cketti/jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.

https://jitsi.org/meet

fork in 7 hours

issue commentprati0100/git-gui

Support git commit --template A.K.A. 'commit.template' setting

Ah, and it has a very obscure bug. If you load git-gui, do some things, and exit it. Then if you change the commit message template (or even remove it), and open git-gui again it will use the previous message for the first commit and then use the new one from the next commit onwards.

This happens because if the commit message buffer in not empty, git-gui saves the contents to save accidental loss of data. And when opening it again, the saved message (which is the older template) obviously gets priority.

ciarancourtney

comment created time in 20 hours

issue commentprati0100/git-gui

Support git commit --template A.K.A. 'commit.template' setting

@surjikal Thanks for pointing it out. It looks good for the most part but I don't like some parts like the rescan call in commit_committree. I will edit those parts and apply the patch.

Thanks for keeping gui-gui alive, it's the best gui!

:-)

ciarancourtney

comment created time in 20 hours

create barnchprati0100/git-gui

branch : ms/commit-template

created branch time in 21 hours

startedashleygwilliams/x86-kernel

started time in a day

startedtsconfig/bases

started time in a day

created repositorygiantswarm/headless-browser

A docker image for a headless Chrome with Selenium and Webdriver, to run some scripts for checks

created time in a day

issue commentprati0100/git-gui

Support git commit --template A.K.A. 'commit.template' setting

@prati0100 Thanks for keeping gui-gui alive, it's the best gui!

I found a patch online that fixes this issue. I applied it manually to my git-gui copy and it seems to work great.

Here's the patch (https://public-inbox.org/git/1530608011429.41203@loewensteinmedical.de/T/):

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-2.4 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI
	shortcircuit=no autolearn=no autolearn_force=no version=3.4.1
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id D479F1F516
	for <e@80x24.org>; Mon,  2 Jul 2018 18:35:26 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753251AbeGBSfX (ORCPT <rfc822;e@80x24.org>);
        Mon, 2 Jul 2018 14:35:23 -0400
Received: from mail.steuer-voss.de ([85.183.69.95]:47036 "EHLO
        mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753170AbeGBSfW (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 2 Jul 2018 14:35:22 -0400
X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Jul 2018 14:35:22 EDT
X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de
Received: by mail.steuer-voss.de (Postfix, from userid 1000)
        id EC55341BAC; Mon,  2 Jul 2018 20:25:21 +0200 (CEST)
From:   =?UTF-8?q?Martin=20Sch=C3=B6n?= 
        <Martin.Schoen@loewensteinmedical.de>
Date:   Mon, 2 Jul 2018 15:28:09 +0200
Subject: [PATCH] git-gui: use commit message template
To:     git@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Message-Id: <20180702182521.EC55341BAC@mail.steuer-voss.de>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <https://public-inbox.org/git/20180702182521.EC55341BAC@mail.steuer-voss.de/>
List-Archive: <https://public-inbox.org/git/>
List-Post: <mailto:git@vger.kernel.org>

Use the file described by commit.template (if set) to show the commit message
template, just like other GUIs.

Signed-off-by: Martin Sch??n <Martin.Schoen@loewensteinmedical.de>
---
 git-gui.sh     | 9 +++++++++
 lib/commit.tcl | 1 +
 2 files changed, 10 insertions(+)

diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..6fc598d 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1611,6 +1611,12 @@ proc run_prepare_commit_msg_hook {} {
 		fconfigure $fd_sm -encoding utf-8
 		puts -nonewline $fd_pcm [read $fd_sm]
 		close $fd_sm
+	} elseif {[file isfile [get_config commit.template]]} {
+		set pcm_source "template"
+		set fd_sm [open [get_config commit.template] r]
+		fconfigure $fd_sm -encoding utf-8
+		puts -nonewline $fd_pcm [read $fd_sm]
+		close $fd_sm
 	} else {
 		set pcm_source ""
 	}
@@ -1620,6 +1626,9 @@ proc run_prepare_commit_msg_hook {} {
 	set fd_ph [githook_read prepare-commit-msg \
 			[gitdir PREPARE_COMMIT_MSG] $pcm_source]
 	if {$fd_ph eq {}} {
+		if {$pcm_source eq "template"} {
+			load_message PREPARE_COMMIT_MSG
+		}
 		catch {file delete [gitdir PREPARE_COMMIT_MSG]}
 		return 0;
 	}
diff --git a/lib/commit.tcl b/lib/commit.tcl
index 83620b7..168f696 100644
--- a/lib/commit.tcl
+++ b/lib/commit.tcl
@@ -506,6 +506,7 @@ A rescan will be automatically started now.
 	unlock_index
 	reshow_diff
 	ui_status [mc "Created commit %s: %s" [string range $cmt_id 0 7] $subject]
+	rescan ui_ready
 }
 
 proc commit_postcommit_wait {fd_ph cmt_id} {
-- 
2.17.1
ciarancourtney

comment created time in 2 days

created repositoryunclebob/covid_analysis

created time in 2 days

created repositoryromannurik/figui-loader

A webpack loader for bundling figma plugin UIs into your main plugin bundle

created time in 2 days

startedgcanti/fp-ts

started time in 2 days

startedSweetIQ/schemats

started time in 2 days

startedyoongkang/pdfjinja

started time in 2 days

startedethereum/beacon_chain

started time in 3 days

starteddenistakeda/posh

started time in 3 days

fork zonque/rauc

Safe and secure software updates for embedded Linux

https://rauc.io

fork in 3 days

startedjoeax/svidget

started time in 3 days

fork flavienlaurent/kumuluzee-version

KumuluzEE Version to expose version details of your microservices.

https://ee.kumuluz.com

fork in 3 days

MemberEvent

pull request commentwo-ist-markt/wo-ist-markt.github.io

Update position of Holsterhausen market

Sorry, just saw you mentioning me here. Glad you figured it out, thanks for updating :-)

bezin

comment created time in 4 days

more