profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/johlju/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Johan Ljunggren johlju Nyköping, Sweden https://se.linkedin.com/in/johanljunggren Motocross driver. Solution Architect. Likes KTM. Likes everything PowerShell. Maintainer of modules in DSC Community, committee member of the DSC Community.

gaelcolas/Sampler 50

Module template with build pipeline and examples, including DSC elements.

dsccommunity/xSmbShare 27

THIS MODULE HAS BEEN DEPRECATED Please use ComputerManagementDsc/SmbShare instead: https://github.com/PowerShell/ComputerManagementDsc

johlju/AzureDevOpsDsc 2

This module contains DSC resources for deployment and configuration of Azure DevOps and Azure DevOps Server.

johlju/dsccommunity.org 1

Website Portal for the DSC Community

johlju/DscConfigurationExample 1

Example on how to create a DSC configuration repository using templates and common test

johlju/DscResource.Common 1

Common functions used in DSC Resources

johlju/DscResource.DocGenerator 1

Module for generation of DSC Resource documentation

johlju/DscResource.Test 1

Module to test your Projects against the HQRM guidelines

pull request commentdsccommunity/xPSDesiredStateConfiguration

Add support for Auto Documentation - Fixes #677

@PlagueHO just minor things! Awesome work on this, I know how long it takes to do a PR like this 😄

PlagueHO

comment created time in 3 days

PullRequestReviewEvent

issue commentdsccommunity/DscResource.DocGenerator

Suggestion: Automatically add a Table of Contents in the Home.md on build containing all the MOF-, class-, and composite-based resources

In MOF-resources it possible to add the following in each schema to help get the description 🤔 See exmaple in xMsiPackage resource in xPSDesiredStateConfiguration.

[Description("Provides a mechanism to install and uninstall .msi packages.") : Amended,AMENDMENT, LOCALE("MS_409")]
johlju

comment created time in 3 days

issue openedgaelcolas/Sampler

Should have the correct `pipelineIndentationStyle` for the dsccommunity template

Problem description

We have always used the following indentation style for pipelines in DSC Community repositories (HQRM modules).

"powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationForFirstPipeline",

but currently the template is set to

https://github.com/gaelcolas/Sampler/blob/656803bec36b2b279336a7efa76c6cfbf63862c0/Sampler/Templates/VscodeConfig/settings.json#L10

Verbose logs

n/a

How to reproduce

n/a

Expected behavior

Have the correct indentation style for pipelines so we don't have to change the code in all modules to align to HQRM (as suggested by the current template).

Current behavior

Have the wrong expected indentation style for pipelines.

Suggested solution

Change the template when the module type that is being created is dsccommunity.

"powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationForFirstPipeline",

Operating system the target node is running

n/a

PowerShell version and build the target node is running

n/a

Module version used

n/a

created time in 3 days

issue openeddsccommunity/DscResource.DocGenerator

Suggestion: Automatically add a Table of Contents in the Home.md on build containing all the MOF-, class-, and composite-based resources

Details of the scenario you tried and the problem that is occurring

Suggest automatically adding a Table of Contents o the Home.md during build. But only if the Home.md exist in WikiSource and have the correct placeholder.

Steps to reproduce the problem

n/a

Expected behavior

Home.md should have a ToC for quick reference.

Current behavior

No ToC anywhere, unless manually created and maintained by a contributors.

Suggested solution to the issue

Home.md should automatically update a ToC in the Home.md with the name of the resource and the description that can be found in the resource's README.md. The resource name should link to the correct resource wiki page.

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the module that was used

n/a

created time in 3 days

pull request commentdsccommunity/SqlServerDsc

[#1669] SqlLogin: LoginMustChangePassword, LoginPasswordExpirationEna…

I have this on the todo - it was a crazy week at work, but this is next in the todo.

bozho

comment created time in 3 days

push eventjohlju/relabeler-action

dependabot[bot]

commit sha 99460a830ad2e2861b832a3d5ad4b0cfe6a35b93

Bump jest from 27.1.1 to 27.2.0 (#236) Bumps [jest](https://github.com/facebook/jest) from 27.1.1 to 27.2.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/compare/v27.1.1...v27.2.0) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged johlju/relabeler-action

Bump jest from 27.1.1 to 27.2.0 dependencies

Bumps jest from 27.1.1 to 27.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">jest's releases</a>.</em></p> <blockquote> <h2>27.2.0</h2> <h3>Features</h3> <ul> <li><code>[jest-resolver, jest-runtime]</code> Pass <code>conditions</code> to custom resolvers to enable them to implement support for package.json <code>exports</code> field (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11859">#11859</a>)</li> <li><code>[jest-runtime]</code> Allow custom envs to specify <code>exportConditions</code> which is passed together with Jest's own conditions to custom resolvers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11863">#11863</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[@jest/reporters]</code> Use async transform if available to transform files with no coverage (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11852">#11852</a>)</li> <li><code>[jest-util]</code> Return correct value from <code>process.send</code> stub (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11799">#11799</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">jest's changelog</a>.</em></p> <blockquote> <h2>27.2.0</h2> <h3>Features</h3> <ul> <li><code>[jest-resolver, jest-runtime]</code> Pass <code>conditions</code> to custom resolvers to enable them to implement support for package.json <code>exports</code> field (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11859">#11859</a>)</li> <li><code>[jest-runtime]</code> Allow custom envs to specify <code>exportConditions</code> which is passed together with Jest's own conditions to custom resolvers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11863">#11863</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[@jest/reporters]</code> Use async transform if available to transform files with no coverage (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11852">#11852</a>)</li> <li><code>[jest-util]</code> Return correct value from <code>process.send</code> stub (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11799">#11799</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/facebook/jest/commit/b05635c539f8f673dfed5bf05ea727a8d5d7bbe2"><code>b05635c</code></a> v27.2.0</li> <li><a href="https://github.com/facebook/jest/commit/d314c071a0b077843132930e1f1d96bfde7a56e8"><code>d314c07</code></a> chore: roll new website version</li> <li><a href="https://github.com/facebook/jest/commit/b971461e8ae0c857794708876ddeea026aa40bd3"><code>b971461</code></a> chore: update changelog for release</li> <li><a href="https://github.com/facebook/jest/commit/b8094df6060bedfe0da8d1478dc1f9653f85af7e"><code>b8094df</code></a> chore: update lock</li> <li><a href="https://github.com/facebook/jest/commit/8c35c4d5581d0a27952851fb94723dc73842c97a"><code>8c35c4d</code></a> feat: support <code>conditions</code> from test environments (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11863">#11863</a>)</li> <li><a href="https://github.com/facebook/jest/commit/ea8b199720cc3f6950eaf4414c0ffe298dd2402a"><code>ea8b199</code></a> Revert "chore: remove unneeded yarn patch for react native (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11853">#11853</a>)"</li> <li><a href="https://github.com/facebook/jest/commit/50766ccfc01e3df98058364e02b779bc857eaeb5"><code>50766cc</code></a> chore: supress experimental warnings in tests</li> <li><a href="https://github.com/facebook/jest/commit/a0bf67154d93f448805dde4fff06e9f115a81ab2"><code>a0bf671</code></a> feat: pass <code>conditions</code> when resolving modules (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11859">#11859</a>)</li> <li><a href="https://github.com/facebook/jest/commit/03ff659cfa49d726422d0455ee7ad5d2664554f1"><code>03ff659</code></a> chore: refresh lockfile (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11857">#11857</a>)</li> <li><a href="https://github.com/facebook/jest/commit/ae990f0e61923362ceb6db17350d0c385a2d1382"><code>ae990f0</code></a> fix: return correct type from process.send stub (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11799">#11799</a>)</li> <li>Additional commits viewable in <a href="https://github.com/facebook/jest/compare/v27.1.1...v27.2.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+262 -262

0 comment

2 changed files

dependabot[bot]

pr closed time in 5 days

push eventjohlju/relabeler-action

dependabot[bot]

commit sha d3702600e4a46390445200dcd657325a269d46a3

Bump @octokit/webhooks-types from 4.6.0 to 4.7.0 (#237) Bumps [@octokit/webhooks-types](https://github.com/octokit/webhooks) from 4.6.0 to 4.7.0. - [Release notes](https://github.com/octokit/webhooks/releases) - [Commits](https://github.com/octokit/webhooks/compare/v4.6.0...v4.7.0) --- updated-dependencies: - dependency-name: "@octokit/webhooks-types" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged johlju/relabeler-action

Bump @octokit/webhooks-types from 4.6.0 to 4.7.0 dependencies

Bumps @octokit/webhooks-types from 4.6.0 to 4.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/octokit/webhooks/releases"><code>@​octokit/webhooks-types</code>'s releases</a>.</em></p> <blockquote> <h2>v4.7.0</h2> <h1><a href="https://github.com/octokit/webhooks/compare/v4.6.1...v4.7.0">4.7.0</a> (2021-09-15)</h1> <h3>Features</h3> <ul> <li>add new <code>allow_forking</code> & <code>allow_auto_merge</code> properties to <code>repository</code>, add missing <code>workflow_job.queued</code> event, add <code>installation</code> property to <code>workflow_job</code> schemas (<a href="https://github.com/octokit/webhooks/commit/62d18fefdcd960c533315a383aad55651d3fbfa0">62d18fe</a>)</li> </ul> <h2>v4.6.1</h2> <h2><a href="https://github.com/octokit/webhooks/compare/v4.6.0...v4.6.1">4.6.1</a> (2021-09-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>types:</strong> allow non-truthy values in generated output (<a href="https://github-redirect.dependabot.com/octokit/webhooks/issues/556">#556</a>) (<a href="https://github.com/octokit/webhooks/commit/1bd545ee0e19cde9ad0d5b36e450986b10e7d333">1bd545e</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/octokit/webhooks/commit/99105c63795e0a0467b83d27876412cb168b7205"><code>99105c6</code></a> style: lint JSON files</li> <li><a href="https://github.com/octokit/webhooks/commit/62d18fefdcd960c533315a383aad55651d3fbfa0"><code>62d18fe</code></a> feat: add new <code>allow_forking</code> & <code>allow_auto_merge</code> properties to <code>repository</code>...</li> <li><a href="https://github.com/octokit/webhooks/commit/00c35faa0a036bb035fd16c35f223724ddd25dbf"><code>00c35fa</code></a> build(deps): lock file maintenance (<a href="https://github-redirect.dependabot.com/octokit/webhooks/issues/557">#557</a>)</li> <li><a href="https://github.com/octokit/webhooks/commit/1bd545ee0e19cde9ad0d5b36e450986b10e7d333"><code>1bd545e</code></a> fix(types): allow non-truthy values in generated output (<a href="https://github-redirect.dependabot.com/octokit/webhooks/issues/556">#556</a>)</li> <li>See full diff in <a href="https://github.com/octokit/webhooks/compare/v4.6.0...v4.7.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+8 -8

0 comment

2 changed files

dependabot[bot]

pr closed time in 5 days

push eventjohlju/relabeler-action

dependabot[bot]

commit sha aaa68885473f776419e24895c2e6138e253dc5f5

Bump jest-circus from 27.1.1 to 27.2.0 (#235) Bumps [jest-circus](https://github.com/facebook/jest/tree/HEAD/packages/jest-circus) from 27.1.1 to 27.2.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v27.2.0/packages/jest-circus) --- updated-dependencies: - dependency-name: jest-circus dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 6 days

PR merged johlju/relabeler-action

Bump jest-circus from 27.1.1 to 27.2.0 dependencies

Bumps jest-circus from 27.1.1 to 27.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/releases">jest-circus's releases</a>.</em></p> <blockquote> <h2>27.2.0</h2> <h3>Features</h3> <ul> <li><code>[jest-resolver, jest-runtime]</code> Pass <code>conditions</code> to custom resolvers to enable them to implement support for package.json <code>exports</code> field (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11859">#11859</a>)</li> <li><code>[jest-runtime]</code> Allow custom envs to specify <code>exportConditions</code> which is passed together with Jest's own conditions to custom resolvers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11863">#11863</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[@jest/reporters]</code> Use async transform if available to transform files with no coverage (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11852">#11852</a>)</li> <li><code>[jest-util]</code> Return correct value from <code>process.send</code> stub (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11799">#11799</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">jest-circus's changelog</a>.</em></p> <blockquote> <h2>27.2.0</h2> <h3>Features</h3> <ul> <li><code>[jest-resolver, jest-runtime]</code> Pass <code>conditions</code> to custom resolvers to enable them to implement support for package.json <code>exports</code> field (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11859">#11859</a>)</li> <li><code>[jest-runtime]</code> Allow custom envs to specify <code>exportConditions</code> which is passed together with Jest's own conditions to custom resolvers (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11863">#11863</a>)</li> </ul> <h3>Fixes</h3> <ul> <li><code>[@jest/reporters]</code> Use async transform if available to transform files with no coverage (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11852">#11852</a>)</li> <li><code>[jest-util]</code> Return correct value from <code>process.send</code> stub (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11799">#11799</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/facebook/jest/commit/b05635c539f8f673dfed5bf05ea727a8d5d7bbe2"><code>b05635c</code></a> v27.2.0</li> <li><a href="https://github.com/facebook/jest/commit/d6e5ddb0c3c1af54f443f225aa14cdf07c7bb593"><code>d6e5ddb</code></a> Rename all links to main (<a href="https://github.com/facebook/jest/tree/HEAD/packages/jest-circus/issues/11856">#11856</a>)</li> <li>See full diff in <a href="https://github.com/facebook/jest/commits/v27.2.0/packages/jest-circus">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+232 -232

0 comment

2 changed files

dependabot[bot]

pr closed time in 6 days

push eventjohlju/relabeler-action

dependabot[bot]

commit sha c801c59760f1aadecb7d0bb7b9f5447507990bdb

Bump @typescript-eslint/parser from 4.31.0 to 4.31.1 (#233) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.31.0 to 4.31.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 6 days

PR merged johlju/relabeler-action

Bump @typescript-eslint/parser from 4.31.0 to 4.31.1 dependencies

Bumps @typescript-eslint/parser from 4.31.0 to 4.31.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v4.31.1</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.0...v4.31.1">4.31.1</a> (2021-09-13)</h2> <p><strong>Note:</strong> Version bump only for package <code>@​typescript-eslint/typescript-eslint</code></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md"><code>@​typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.31.0...v4.31.1">4.31.1</a> (2021-09-13)</h2> <p><strong>Note:</strong> Version bump only for package <code>@​typescript-eslint/parser</code></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/2006056ad32093dce292e4f02a74a1a94dbb3a0f"><code>2006056</code></a> chore: publish v4.31.1</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.1/packages/parser">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+48 -48

0 comment

2 changed files

dependabot[bot]

pr closed time in 6 days

push eventjohlju/relabeler-action

dependabot[bot]

commit sha 1e914a6839123b6aacb88b59761daf393d9c22dc

Bump @vercel/ncc from 0.31.0 to 0.31.1 (#234) Bumps [@vercel/ncc](https://github.com/vercel/ncc) from 0.31.0 to 0.31.1. - [Release notes](https://github.com/vercel/ncc/releases) - [Commits](https://github.com/vercel/ncc/compare/0.31.0...0.31.1) --- updated-dependencies: - dependency-name: "@vercel/ncc" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 6 days

PR merged johlju/relabeler-action

Bump @vercel/ncc from 0.31.0 to 0.31.1 dependencies

Bumps @vercel/ncc from 0.31.0 to 0.31.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vercel/ncc/releases"><code>@​vercel/ncc</code>'s releases</a>.</em></p> <blockquote> <h2>0.31.1</h2> <h3>Patches</h3> <ul> <li>Fix <code>tsconfig.json</code> detection: <a href="https://github-redirect.dependabot.com/vercel/ncc/issues/770">#770</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vercel/ncc/commit/44b4e0c8f28244a8fef5ffccdfbc9286f27cea5b"><code>44b4e0c</code></a> 0.31.1</li> <li><a href="https://github.com/vercel/ncc/commit/8465dbe1cf0f265619beb57b2ec0b874fd52d323"><code>8465dbe</code></a> Fix <code>tsconfig.json</code> detection (<a href="https://github-redirect.dependabot.com/vercel/ncc/issues/770">#770</a>)</li> <li>See full diff in <a href="https://github.com/vercel/ncc/compare/0.31.0...0.31.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+8 -8

0 comment

2 changed files

dependabot[bot]

pr closed time in 6 days

issue commentdsccommunity/DnsServerDsc

Where are the resources from DNSServerDSC for the Records?

I have not yet tried running resources through PS7 with the latest preview of PSDesiredStateConfiguration. Not sure the work is finished to be able to run in PS7 🤔

brwilkinson

comment created time in 8 days

issue commentdsccommunity/DnsServerDsc

Where are the resources from DNSServerDSC for the Records?

This is a bug in Get-DscResource in PowerShell 7. If you use PowerShell 5.1 they will show using Get-DscResource.

brwilkinson

comment created time in 8 days

delete branch johlju/DnsServerDsc

delete branch : fix/tests

delete time in 8 days

push eventdsccommunity/DnsServerDsc

Johan Ljunggren

commit sha 87db7429f8bc14b30206a97f45e794c090d8dd6e

Fix comment regarding `using module` (#269)

view details

push time in 8 days

PR merged dsccommunity/DnsServerDsc

Fix comment regarding `using module`

Pull Request (PR) description

  • DnRecordBase
    • Update comment regarding use of using module statement.
  • ResourceBase
    • Update comment regarding use of using module statement.

This Pull Request (PR) fixes the following issues

None

Task list

<!-- To aid community reviewers in reviewing and merging your PR, please take the time to run through the below checklist and make sure your PR has everything updated as required.

Change to [x] for each task in the task list that applies to your PR.
For those task that don't apply to you PR, leave those as is.

-->

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+14 -6

1 comment

3 changed files

johlju

pr closed time in 8 days

PullRequestReviewEvent

PR opened dsccommunity/DnsServerDsc

Fix comment regarding `using module`

Pull Request (PR) description

  • DnRecordBase
    • Update comment regarding use of using module statement.
  • ResourceBase
    • Update comment regarding use of using module statement.

This Pull Request (PR) fixes the following issues

None

Task list

<!-- To aid community reviewers in reviewing and merging your PR, please take the time to run through the below checklist and make sure your PR has everything updated as required.

Change to [x] for each task in the task list that applies to your PR.
For those task that don't apply to you PR, leave those as is.

-->

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.
+14 -6

0 comment

3 changed files

pr created time in 8 days

create barnchjohlju/DnsServerDsc

branch : fix/tests

created branch time in 8 days

issue commentdsccommunity/DscResource.Test

`using module` for class-based DSC resource tests?

It seems using module is necessary to be able to inheriting a parent class in the tests. That is why it is not needed in the other tests. 🙂 I should have known that, because I wrote one of the tests 😉

bozho

comment created time in 8 days

issue commentdsccommunity/DscResource.Test

`using module` for class-based DSC resource tests?

I did not know that using module existed there. :) Looking at the test pipeline the first test to be executed is DnsRecordA, and that one does not have using module so it might be possible to remove it from the other places.

This was as a perfect place as another to discuss this, though you will get faster response from the #dsc Slack/Discord channel 😊 See the https://dsccommunity.org how to connect with the community.

bozho

comment created time in 8 days

issue commentdsccommunity/DscResource.Test

`using module` for class-based DSC resource tests?

Btw. the pipeline comes from the Sampler (https://GitHub.com/gaelcolas/Sampler) project that makes it easy to set up an new project with its built-in Plaster template dsccommunity. Though for classes some changes might be needed (which can be copied of DnsServerDsc)

bozho

comment created time in 8 days

issue commentdsccommunity/DscResource.Test

`using module` for class-based DSC resource tests?

We are not using using module at all. But that might be possible if you like that. The module is just imported using Import-Module in the tests.

The classes are separate in the source folder. The build pipeline concatenate everything in the correct order (classes dependent on each other) inside the built module script file (one si for file). The module script file is then reference as the RootModule in the module manifest.

The tests import the built module. Testing is done against the same file (the built module) that will be published (if tests passes).

The pipeline will translate back code coverage hits and missed from the test run to the correct source file.

bozho

comment created time in 8 days

issue openedgaelcolas/Sampler

Add VS Code settings and analyzer settings to SimpleModule that does not required DSC tooling

I wonder if it's a good decision to remove the PSSA rules and vscode integration. It's ok to not enforce them, but I'd prefer that we still "highlight" non-HQRM practices.

They have not been part of the SimpleModule before (because the wrong template name was used in Plaster manifest). Was about to add them but skipped it due to the current implementation is using DSC Community tooling like DscResource.AnalyzerRules. It does not feel right for the SimpleModule template.

Originally posted by @johlju in https://github.com/gaelcolas/Sampler/issues/325#issuecomment-917649398

created time in 9 days

Pull request review commentgaelcolas/Sampler

Fix SimpleModule template

    <!-- Codecov.io -->     <templateFile source='codecov.yml.template'           destination='${PLASTER_PARAM_ModuleName}/codecov.yml'-          condition='${PLASTER_PARAM_ModuleType} -in @("dsccommunity", "CompleteSample", "SimpleModule") -or ${PLASTER_PARAM_Features} -Contains ("All") -or ${PLASTER_PARAM_Features} -Contains ("codecov")'+          condition='(${PLASTER_PARAM_UseCodeCovIo} -eq $true -and ${PLASTER_PARAM_ModuleType} -in @("dsccommunity", "CompleteSample", "SimpleModule")) -or ${PLASTER_PARAM_Features} -Contains ("All") -or ${PLASTER_PARAM_Features} -Contains ("codecov")'

Added a new issue to track that.

johlju

comment created time in 9 days