profile
viewpoint

eduvpn/macos 15

Deprecated, please go to https://github.com/eduvpn/apple

eduvpn/apple 11

app for iOS and macOS

johankool/Drawer 4

A Maps like drawer for iOS.

johankool/GMGridView 1

A performant Grid-View for iOS (iPhone/iPad) that allows sorting of views with gestures (the user can move the items with his finger to sort them) and pinching/rotating/panning gestures allow the user to play with the view and toggle from the cellview to a fullsize display.

johankool/AFNetworking 0

A delightful iOS and OS X networking framework

johankool/AppAuth-iOS 0

iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.

johankool/AQUI 0

A collection of SwiftUI views and utilities.

johankool/CocoaHeadsNL-iOS 0

Repository for CocoaHeadsNL app.

johankool/ColorSense-for-Xcode 0

Plugin for Xcode to make working with colors more visual

issue commentmapbox/mapbox-gl-native-ios

Distribute as XCFramework

Relevant issues in Carthage: https://github.com/Carthage/Carthage/pull/2881 https://github.com/Carthage/Carthage/pull/2801 https://github.com/Carthage/Carthage/pull/3071

johankool

comment created time in 2 days

startedTitouanVanBelle/XCTestHTMLReport

started time in 5 days

issue commentCocoaPods/Xcodeproj

alwaysOutOfDate

Sorry for the noise. Accidentally created issue instead of searching. :blush:

johankool

comment created time in 21 days

issue closedCocoaPods/Xcodeproj

alwaysOutOfDate

closed time in 21 days

johankool

issue openedCocoaPods/Xcodeproj

alwaysOutOfDate

created time in 21 days

push eventegeniq-forks/openapi-generator

Johan Kool

commit sha 43c4aae0767b4e9fbb93b4a142480c8331c08065

Catch exceptions as errors on iOS

view details

Johan Kool

commit sha e27bbb878463eb8dd917bea25e5c3440ccf11223

Catch exceptions as errors on iOS

view details

Johan Kool

commit sha 8ec01311ed4a5a32e31b1d4693a7a98c32cdaf7e

Merge pull request #4 from egeniq-forks/feature/exceptions Catch exceptions as errors on iOS

view details

push time in a month

push eventegeniq-forks/openapi-generator

Johan Kool

commit sha e27bbb878463eb8dd917bea25e5c3440ccf11223

Catch exceptions as errors on iOS

view details

push time in a month

create barnchegeniq-forks/openapi-generator

branch : feature/exceptions

created branch time in a month

push eventliatjokro/liatjokro.github.io

Johan Kool

commit sha 99b1fe69a72f035b102bc92d90069cca9468079d

Update Jekyll

view details

push time in a month

push eventFlatPlanetoid/flatplanetoid.github.io

Johan Kool

commit sha 940007b5b205275781b956e8c921c3e07fe86912

Update Jekyll

view details

push time in a month

push eventjohankool/johankool.github.io

Johan Kool

commit sha 17cea11c6d7a2a0c54f5408b409c742b50eebf64

Update Jekyll

view details

push time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue openedminvws/nl-covid19-notification-app-ios

Unable to Re-enable after Location & Privacy Reset

Describe the bug, issue or concern

It is possible to get the app in a state where it is disabled and cannot be enabled again.

First reported on Code for NL Slack here.

To Reproduce

Steps to reproduce the behavior:

  1. Have the CoronaMelder app installed and active
  2. Go to iOS Settings
  3. Click on General > Reset
  4. Click "Reset Location & Privacy" and complete reset
  5. Open CoronaMelder and notice it is now disabled
  6. Follow steps to re-enable
  7. The screen to re-enable Exposure notifications in iOS settings is blank

Expected behavior

Of course I should be able to enable the app again.

Workaround

Hard kill of the app and restart of the device and disable Exposure notifications doesn't help. Deleting the app and reinstalling it allows for the app to go through the normal onboarding flow again and the app can be enabled again properly.

Analysis

My interpretation of this issue is that by resetting the privacy settings the app gets into the state where it can walk through the onboarding flow again, but the app thinks it already has done this and so sends the user to Exposure Notification screen in Settings. But Apple made it so that this can only be enabled from the app.

It seems that the app keeps track of wether the user has gone through the onboarding and decides based on that what it does on subsequent launches and also assumes that in the main screen that when it is disabled the user always must go to the Settings. Instead it probably should look at the status of the framework to see if user already gave permission or not. (I am assuming here that it works kinda similar to how location permissions work. I have not delved into the code of the app myself.)

Screenshots

Reset: Reset

Blank screen: Blank screen

There is a movie of the issue on Slack. (GitHub doesn't accept videos afaik.)

Smartphone:

  • Device: iPhone 11 Pro Max
  • OS: iOS 14.0
  • Version 1.0.7

Additional context

Add any other context about the problem here.

Governance

  • [√] I've read the contributing document https://github.com/minvws/.github/blob/master/CONTRIBUTING.md
  • [√] I've read and understand the Code of Conduct https://github.com/minvws/.github/blob/master/CODE_OF_CONDUCT.md
  • [√] I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/LICENSE.txt and the contributor license agreement https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/CLA.md
  • where "read" means "blindly accepted in good faith" :-)

created time in a month

PullRequestReviewEvent

issue commenteduvpn/apple

problems authenticating eduvpn

That sounds like an issue with DNS not being set correctly.

jojoba1234

comment created time in 2 months

issue commenteduvpn/apple

problems authenticating eduvpn

Hello @jojoba1234 We've been working on a big update that reworked a good part of the UI as well as internals. For now it is available as Let's Connect Could you try and see if the problem occurs for you there still?

jojoba1234

comment created time in 2 months

PullRequestReviewEvent
MemberEvent

Pull request review commenteduvpn/apple

Some fixes to the redesigned app

 import AppKit import PromiseKit import os.log +protocol ConnectionViewControllerDelegate: class {+    func connectionViewControllerAttemptingToConnect(connectionAttempt: ConnectionAttempt?)

It is a convention for a good reason. While you may not need it now, you are now baking the assumption into ConnectionViewController that it won't ever have a sibling. which is something it should not actually be aware off. Sure, this current code works and you'll probably not gonna need it, but still I'd rather see all delegate protocols according to the convention.

roop

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenteduvpn/apple

Some fixes to the redesigned app

 import AppKit import PromiseKit import os.log +protocol ConnectionViewControllerDelegate: class {+    func connectionViewControllerAttemptingToConnect(connectionAttempt: ConnectionAttempt?)

Delegates should always be pass the caller. So I'd expect something like func connectionViewController(_ controller: ConnectionViewController, attemptingToConnect connectionAttempt: ConnectionAttempt?)

roop

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenteduvpn/apple

Connection screen

 import Foundation import Moya import PromiseKit -enum DiscoveryDataFetcherError: LocalizedError {+enum DiscoveryDataFetcherError: Error {     case dataCouldNotBeVerified     case dataNotFoundInCache } +extension DiscoveryDataFetcherError: AppError {+    var summary: String {+        switch self {+        case .dataCouldNotBeVerified: return "Discovery data could not be verified"+        case .dataNotFoundInCache: return "Discovery data not found in cache"

Not sure if these are shown to user, if yes, make localizable.

roop

comment created time in 3 months

Pull request review commenteduvpn/apple

Connection screen

+//+//  ServerDisplayInfo.swift+//  EduVPN-redesign-macOS+//++import Foundation++enum ServerDisplayInfo {+    case instituteAccessServer(DiscoveryData.InstituteAccessServer)+    case secureInternetServer(DiscoveryData.SecureInternetServer?)+    case serverByURLServer(SimpleServerInstance)+}++extension ServerDisplayInfo {+    func serverName(for locale: Locale, isTitle: Bool = false) -> String {+        switch self {+        case .instituteAccessServer(let server):+            return server.displayName.string(for: locale)+        case .secureInternetServer(let server):+            guard let server = server else { return "Unknown country" }+            return Locale.current.localizedString(forRegionCode: server.countryCode) ?? "Unknown country"

Make "Unknown country" localizable.

roop

comment created time in 3 months

PR closed eduvpn/apple

Search and Connection screens

Merged work of @roop and me

+3873 -836

0 comment

86 changed files

johankool

pr closed time in 3 months

issue openedKhaosT/SimpleVM

Crash on launch with RBSRequestErrorDomain error 5

I couldn't get the app to launch on Big Sur 11.0 Beta (20A5323l) using Xcode 12.0 beta 3 (12A8169g) due to a code signing issue causing it to report RBSRequestErrorDomain error 5. I found that renaming the entitlement com.apple.vm.networking to com.apple.security.virtualization made it work.

created time in 3 months

more